OpenNapServerManager.java
| Index Score | ||
|---|---|---|
 |
 |
org.xnap.plugin.opennap.net |
 |
|
XNap 3 |
View: Reasons, Metrics, Source Code
These are the metrics that contribute to the Enerjy Score for this file, ranked by impact. So the metrics listed at the top influence the score to a greater extent that the metrics listed at the bottom.
| Metric | Description | |
|---|---|---|
| EXITS | Procedure exits |  |
| JAVA0143 | JAVA0143 Synchronized method | |
| BLOCKS | Number of blocks | |
| CYCLOMATIC | Cyclomatic complexity | |
| LOOPS | Number of loops | |
| LOC | Lines of code | |
| JAVA0117 | JAVA0117 Missing javadoc: method 'method' | |
| JAVA0161 | JAVA0161 Conditional wait() not in loop | |
| LOGICAL_LINES | Number of statements | |
| OPERATORS | Number of operators | |
| LINE_COMMENT | Number of line comments | |
| ELOC | Effective lines of code | |
| LINES | Number of lines in the source file | |
| UNIQUE_OPERANDS | Number of unique operands | |
| PROGRAM_LENGTH | Halstead program length | |
| PROGRAM_VOCAB | Halstead program vocabulary | |
| JAVA0254 | JAVA0254 Use enhanced for loop construct instead of Iterator | |
| JAVA0123 | JAVA0123 Use all three components of for loop | |
| COMPARISONS | Number of comparison operators | |
| JAVA0108 | JAVA0108 Incorrect javadoc: no @param tag for 'parameter' | |
| FUNCTIONS | Number of function declarations | |
| OPERANDS | Number of operands | |
| JAVA0264 | JAVA0264 Integer math in long context - check for overflow | |
| RETURNS | Number of return points from functions | |
| DECL_COMMENTS | Comments in declarations | |
| JAVA0041 | JAVA0041 Nested synchronized block | |
| SIZE | Size of the file in bytes | |
| JAVA0034 | JAVA0034 Missing braces in if statement | |
| JAVA0075 | JAVA0075 Method parameter hides field | |
| JAVA0177 | JAVA0177 Variable declaration missing initializer | |
| INTERFACE_COMPLEXITY | Interface complexity | |
| JAVA0145 | JAVA0145 Tab character used in source file | |
| JAVA0076 | JAVA0076 Use of magic number | |
| WHITESPACE | Number of whitespace lines | |
| UNIQUE_OPERATORS | Number of unique operators | |
| JAVA0110 | JAVA0110 Incorrect javadoc: no @return tag | |
| JAVA0137 | JAVA0137 Non-abstract class missing constructor | |
| EXEC_COMMENTS | Comments in executable code | |
| JAVA0128 | JAVA0128 Public constructor in non-public class | |
| JAVA0077 | JAVA0077 Private field not used in declaring class | |
| PROGRAM_VOLUME | Halstead program volume | |
| JAVA0136 | JAVA0136 N methods defined in class (maximum: M) | |
| JAVA0126 | JAVA0126 Method declares unchecked exception in throws | |
| JAVA0087 | JAVA0087 Use of Thread.sleep() | |
| JAVA0173 | JAVA0173 Unused method parameter | |
| JAVA0100 | JAVA0100 Class contains N non-final fields (maximum: M) | |
| JAVA0130 | JAVA0130 Non-static method does not use instance fields | |
| PARAMS | Number of formal parameter declarations | |
| NEST_DEPTH | Maximum nesting depth | |
| JAVA0118 | JAVA0118 Missing javadoc: type 'type' | |
/*
* XNap - A P2P framework and client.
*
* See the file AUTHORS for copyright information.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
*/
package org.xnap.plugin.opennap.net;
import java.beans.PropertyChangeEvent;
import java.beans.PropertyChangeListener;
import java.io.IOException;
import java.util.ArrayList;
import java.util.HashMap;
import java.util.Iterator;
import java.util.LinkedList;
import java.util.List;
import java.util.StringTokenizer;
import org.apache.log4j.Logger;
import org.xnap.XNap;
import org.xnap.event.ListListener;
import org.xnap.event.ListSupport;
import org.xnap.event.StatusListener;
import org.xnap.io.Library;
import org.xnap.io.MetaInfoFile;
import org.xnap.io.MetaInfoManager;
import org.xnap.net.NetHelper;
import org.xnap.plugin.opennap.OpenNapPlugin;
import org.xnap.plugin.opennap.net.msg.ExceptionListener;
import org.xnap.plugin.opennap.net.msg.MessageHandler;
import org.xnap.plugin.opennap.net.msg.client.AddHotlistEntryMessage;
import org.xnap.plugin.opennap.net.msg.client.ShareFileMessage;
import org.xnap.plugin.opennap.user.OpenNapGlobalUser;
import org.xnap.plugin.opennap.util.OpenNapPreferences;
import org.xnap.search.SearchManager;
import org.xnap.util.Formatter;
import org.xnap.util.IllegalOperationException;
import org.xnap.util.Notifier;
import org.xnap.util.PortRange;
import org.xnap.util.Range;
import org.xnap.util.Scheduler;
import org.xnap.util.XNapTask;
public class OpenNapServerManager implements PropertyChangeListener {
//--- Constant(s) ---
//--- Data field(s) ---
private static Logger logger = Logger.getLogger(OpenNapServerManager.class);
private OpenNapPreferences napPrefs = OpenNapPlugin.getPreferences();
private String stats;
private OpenNapListener listener = new OpenNapListener();
protected ListSupport ls = new ListSupport(this);
/**
* A list of {@link StatusListener} objects.
*/
private LinkedList sl = new LinkedList();
/**
* Set to true by {@link #add(OpenNapServer,boolean)} if a
* temporary server has been added.
*/
private boolean addedTemporary = false;
/**
* A list of {@link OpenNapServer} objects.
*/
private List servers = new ArrayList();
/**
* A list of connected {@link OpenNapServer} objects.
*
* @see #setConnected(OpenNapServer, boolean)
*/
private List connectedServers = new LinkedList();
/**
* A list of {@link OpenNapNetwork} objects.
*/
private HashMap networkByName = new HashMap();
private AutoConnector connector = new AutoConnector();
/**
* The indes of the next repository file to share.
*
* @see PostLoginRunner.shareFiles()
*/
private int repositoryIndex = 0;
private AutoFetchTask autoFetchTask;
/**
* Set to true once downloads have been auto resumed.
*/
private boolean resumed = false;
//--- Constructor(s) ---
public OpenNapServerManager()
{
OpenNapPlugin.getPreferences().addPropertyChangeListener(this);
// Repository.getInstance().addListListener(this);
// use the "Other" network as a fallback
networkByName.put("", new OpenNapDefaultNetwork());
updateStats();
}
//--- Method(s) ---
/**
* <code>listener</code> is notified when a server is added or removed.
*/
public void addListListener(ListListener listener)
{
ls.addListListener(listener);
}
public void removeListListener(ListListener listener)
{
ls.removeListListener(listener);
}
/**
* <code>listener</code> is notified when a server is added or removed.
*/
public synchronized void addStatsListener(StatusListener listener)
{
sl.add(listener);
}
public synchronized void removeStatsListener(StatusListener listener)
{
sl.remove(listener);
}
public boolean add(String url, String network, boolean login)
{
StringTokenizer s = new StringTokenizer(url, ":");
if (s.countTokens() != 2) {
return false;
}
String ip = s.nextToken();
int port = 0;
try {
port = Integer.parseInt(s.nextToken());
}
catch (NumberFormatException e) {
}
if (ip.length() == 0
|| port < PortRange.MIN_PORT || port > PortRange.MAX_PORT) {
return false;
}
OpenNapServer server = new OpenNapServer(ip, port, network);
add(server, true);
// if (login) {
// server.connect();
// }
return true;
}
/**
* Adds <code>server</code> if it is not already in the list.
*
* @return true, if the server was added; false, otherwise
*/
public boolean add(OpenNapServer server, boolean login)
{
synchronized (this) {
// keep servers sorted by lastConnect, higher values come first
int index = 0;
for (int i = 0; i < servers.size(); i++) {
OpenNapServer next = (OpenNapServer)servers.get(i);
if (next.equals(server)) {
// we already have the server
return false;
}
if (next.getLastConnect() > server.getLastConnect()) {
index++;
}
}
OpenNapNetwork network = getNetworkByName(server.getNetworkName());
server.setNetwork(network);
server.setListener(listener);
servers.add(index, server);
addedTemporary |= server.isTemporary();
server.addPropertyChangeListener(this);
ls.fireItemAdded(server);
network.add(server);
}
if (login) {
server.connect();
}
connector.wakeup();
return true;
}
/**
* Returns the number of servers that were added.
*/
public int addFrom(OpenNapServerReader reader, boolean temporary)
throws IOException
{
int count = 0;
try {
reader.open();
OpenNapServer s;
while ((s = reader.read()) != null) {
s.setTemporary(temporary);
if (s.getAutoConnect()) {
if (add(s, true)) {
count++;
}
}
else {
if (add(s, false)) {
count++;
}
}
}
}
finally {
reader.close();
}
return count;
}
public void die()
{
setAutoFetchInterval(-1);
OpenNapPlugin.getPreferences().removePropertyChangeListener(this);
connector.die();
try {
saveTo(new OpenNapServerFileWriter(napPrefs.getServerFile()), false);
}
catch (IOException e) {
logger.debug("could not write file", e);
}
if (addedTemporary) {
try {
saveTo(new OpenNapServerFileWriter(napPrefs.getNapigatorFile()), true);
}
catch (IOException e) {
logger.debug("could not write file", e);
}
}
removeAll();
listener.die();
}
public void fetchServerLists()
{
Notifier.info(XNap.tr("Downloading list of OpenNap servers") + "...");
Runnable r = new Runnable()
{
public void run()
{
String urls
= OpenNapPlugin.getPreferences().getNapigatorURL();
StringTokenizer t = new StringTokenizer(urls, "\n");
while (t.hasMoreTokens()) {
String url = t.nextToken().trim();
if (!url.startsWith("#")) {
try {
addFrom(new NapigatorReader(url), true);
}
catch (IOException e) {
Notifier.error(XNap.tr("Could not get list of OpenNap servers: {0}", NetHelper.getErrorMessage(e)), e);
}
}
}
updateStats();
}
};
Thread t = new Thread(r, "AskNapigator");
t.start();
}
public void remove(OpenNapServer server)
{
try {
server.disconnect();
}
catch (IllegalOperationException e) {
// ignore exception, server might not be connected at all
}
synchronized (this) {
server.removePropertyChangeListener(this);
servers.remove(server);
ls.fireItemRemoved(server);
}
}
public synchronized void removeAll()
{
for (Iterator i = servers.iterator(); i.hasNext();) {
OpenNapServer server = (OpenNapServer)i.next();
try {
server.disconnect();
}
catch (IllegalOperationException e) {
// ignore exception, server might not be connected at all
}
server.removePropertyChangeListener(this);
}
servers.clear();
}
public synchronized OpenNapServer getServerByHost(String host)
{
for (Iterator i = servers.iterator(); i.hasNext();) {
OpenNapServer s = (OpenNapServer)i.next();
if (s.getHost().equals(host)) {
return s;
}
}
return null;
}
public AutoConnector getConnector()
{
return connector;
}
public synchronized int getConnectedCount()
{
return connectedServers.size();
}
public synchronized OpenNapServer[] getConnectedServers()
{
return (OpenNapServer[])connectedServers.toArray(new OpenNapServer[0]);
}
public OpenNapNetwork getNetworkByName(String name)
{
OpenNapNetwork n = (OpenNapNetwork)networkByName.get(name);
if (n == null) {
n = new OpenNapNetwork(name);
networkByName.put(name, n);
}
return n;
}
public synchronized OpenNapServer[] getServers()
{
return (OpenNapServer[])servers.toArray(new OpenNapServer[0]);
}
/**
* Returns the stats that were calculated during the last call to
* {@link #updateStats()}.
*/
public String getStats()
{
return stats;
}
public void init()
{
updateListener();
Thread t = new Thread(new InitRunner(), "OpenNapServerManagerInit");
t.start();
}
public void changeNetwork(OpenNapServer server, String newNetworkName)
{
if (!newNetworkName.equals(server.getNetworkName())) {
OpenNapNetwork oldNetwork = server.getNetwork();
oldNetwork.remove(server);
OpenNapNetwork newNetwork = getNetworkByName(newNetworkName);
server.setNetwork(newNetwork);
newNetwork.add(server);
}
}
public int saveTo(OpenNapServerWriter writer, boolean temporary)
throws IOException
{
int count = 0;
try {
writer.open();
for (Iterator i = servers.iterator(); i.hasNext();) {
OpenNapServer s = (OpenNapServer)i.next();
if (s.isTemporary() == temporary) {
writer.write(s);
count++;
}
}
}
finally {
writer.close();
}
return count;
}
public int saveTo(OpenNapServerWriter writer)
throws IOException
{
int count = 0;
try {
writer.open();
for (Iterator i = servers.iterator(); i.hasNext();) {
OpenNapServer s = (OpenNapServer)i.next();
writer.write(s);
count++;
}
}
finally {
writer.close();
}
return count;
}
/**
* Sets the interval for the auto fetch task.
*
* @param interval the auto fetch interval in milli seconds; if <= 0,
* auto fetching is disabled */
public synchronized void setAutoFetchInterval(long interval)
{
if (interval <= 0) {
if (autoFetchTask != null) {
autoFetchTask.cancel();
autoFetchTask = null;
}
}
else {
autoFetchTask = new AutoFetchTask();
Scheduler.run(0, interval, autoFetchTask);
}
}
/**
* Invoked by {@link OpenNapServer} objects once their state
* changes to connected. */
void setConnected(OpenNapServer server, boolean connected)
{
synchronized (connectedServers) {
synchronized (this) {
if (connected) {
connectedServers.add(server);
Thread t
= new Thread(new PostLoginRunner(server), "PostLogin");
t.start();
}
else {
connectedServers.remove(server);
}
}
int size = connectedServers.size();
if (size == 1) {
SearchManager.getInstance().add
(OpenNapPlugin.getSearchManager());
}
else if (size == 0) {
SearchManager.getInstance().remove
(OpenNapPlugin.getSearchManager());
}
if (!resumed
&& napPrefs.getAutoResumeDownloads()
&& size == napPrefs.getAutoResumeConnectedCount()) {
resumed = true;
OpenNapPlugin.getTransferManager().startAllDownloads();
}
}
updateStats();
}
public void propertyChange(PropertyChangeEvent e)
{
String p = e.getPropertyName();
if (p.equals("stats")) {
updateStats();
}
else if (p.equals("firewalled") || p.equals("localPort")) {
updateListener();
}
else if (p.equals("autoFetchNapigator")
|| p.equals("autoFetchNapigatorInterval")) {
updateAutoFetch();
}
}
private void updateAutoFetch()
{
setAutoFetchInterval
(napPrefs.getAutoFetchNapigator()
? napPrefs.getAutoFetchNapigatorInterval() * 60 * 60 * 1000
: -1);
}
private void updateListener()
{
if (napPrefs.getFirewalled()) {
listener.setPortRange(null);
}
else {
PortRange range = new PortRange(napPrefs.getLocalPortRange());
listener.setPortRange(range);
if (listener.getPort() == 0) {
logger.info(XNap.tr("Could not start listener (check local port)"));
}
}
}
/**
* Iterates through all servers and notifies the stats listeners.
*/
private synchronized void updateStats()
{
long userCount = 0;
long fileCount = 0;
long fileSize = 0;
if (connectedServers.size() > 0) {
for (Iterator i = connectedServers.iterator(); i.hasNext();) {
OpenNapServer s = (OpenNapServer)i.next();
userCount += s.getUserCount();
fileCount += s.getFileCount();
fileSize += s.getFileSize();
}
// gb -> byte
fileSize = fileSize * 1024 * 1024 * 1024;
StringBuffer sb = new StringBuffer();
sb.append(Formatter.formatNumber(connectedServers.size()));
sb.append(" " + XNap.tr("of") + " ");
sb.append(Formatter.formatNumber(servers.size()));
sb.append(" " + XNap.tr("Servers") + " / ");
sb.append(Formatter.formatNumber(userCount));
sb.append(" " + XNap.tr("Users") + " / ");
sb.append(Formatter.formatNumber(fileCount));
sb.append(" " + XNap.tr("Files") + " / ");
sb.append(Formatter.formatSize(fileSize));
sb.append(" " + XNap.tr("Shared"));
stats = sb.toString();
}
else {
stats = XNap.tr("{0} Servers (Not Connected)",
new Integer(servers.size()));
}
for (Iterator i = sl.iterator(); i.hasNext();) {
((StatusListener)i.next()).setStatus(stats);
}
}
/**
* Spin-locks until library is read. */
private void waitUntilLibraryIsRead()
{
while (!Library.getInstance().isRead()) {
try {
Thread.sleep(512);
}
catch (InterruptedException e) {
return;
}
}
}
//--- Inner Class(es) ---
private class InitRunner implements Runnable
{
public void run()
{
try {
String filename = napPrefs.getServerFile();
addFrom(new OpenNapServerFileReader(filename), false);
}
catch (IOException e) {
logger.debug("Could not add hosts from file" , e);
}
if (napPrefs.getAutoLoadNapigator()) {
try {
String filename = napPrefs.getNapigatorFile();
addFrom(new OpenNapServerFileReader(filename), true);
}
catch (IOException e) {
logger.debug("Could not add hosts from file" , e);
}
}
updateAutoFetch();
}
}
private class ServerIterator {
private int start;
private boolean looped;
private int next = 0;
/**
* This needs to called prior to each cycle.
*/
public void init()
{
start = next;
looped = false;
}
/**
* Called by AutoConnector to cycle through servers.
*/
public OpenNapServer getNext()
{
synchronized (OpenNapServerManager.this) {
if (servers.isEmpty()) {
return null;
}
if (next > servers.size()) {
if (looped) {
return null;
}
if (start > servers.size() - 1) {
start = servers.size() - 1;
}
next = 0;
looped = true;
}
int index = next;
next++;
if (next >= servers.size()) {
next = 0;
looped = true;
}
if (looped && next >= start) {
return null;
}
return (OpenNapServer)servers.get(index);
}
}
}
public class AutoConnector implements Runnable
{
private boolean die = false;
private boolean enabled = false;
private Thread runner;
private ServerIterator iterator = new ServerIterator();
void die()
{
die = true;
synchronized (this) {
this.notify();
}
}
public synchronized boolean isEnabled()
{
return enabled;
}
public synchronized void setEnabled(boolean newValue)
{
enabled = newValue;
if (enabled) {
if (runner != null) {
wakeup();
}
else {
runner = new Thread(this, "OpenNapConnector");
runner.start();
}
}
}
public void wakeup()
{
if (isEnabled()) {
synchronized (this) {
this.notify();
}
}
}
/**
* Auto connects servers.
*/
public void run()
{
waitUntilLibraryIsRead();
while (!die) {
int left = 2 * (napPrefs.getMaxAutoconnectServers()
- connectedServers.size());
left -= OpenNapNetwork.getTotalConnecting();
iterator.init();
OpenNapServer s;
while ((s = iterator.getNext()) != null && left > 0
&& enabled) {
if (!s.getNetwork().isBusy() && s.isDisconnected()) {
long t = s.getNextAutoConnectTime();
if (t >= 0 && System.currentTimeMillis() >= t) {
s.connect();
left--;
}
}
}
synchronized (this) {
try {
if (enabled) {
this.wait(OpenNapServer.FAILED_INTERVAL);
}
else {
this.wait();
}
}
catch (InterruptedException e) {
}
}
}
}
}
public class PostLoginRunner implements Runnable, ExceptionListener {
OpenNapServer server;
boolean die;
public PostLoginRunner(OpenNapServer server)
{
this.server = server;
}
public void exceptionThrown(Exception e)
{
die = true;
}
public void run()
{
sendHotlist();
shareFiles();
}
public void sendHotlist()
{
// add hotlist users
OpenNapGlobalUser[] users
= OpenNapPlugin.getUserManager().getHotlistUsers();
for (int i = 0; i < users.length && !die; i++) {
AddHotlistEntryMessage msg
= new AddHotlistEntryMessage(users[i].getName());
msg.setExceptionListener(this);
MessageHandler.send(server, msg);
}
}
public void shareFiles()
{
waitUntilLibraryIsRead();
int size = Library.getInstance().size();
if (size == 0) {
return;
}
// share files
if (napPrefs.getLimitSharesPerServer()) {
boolean looped = false;
int toShare = napPrefs.getMaxSharesPerServer();
int start;
int next;
synchronized(OpenNapServerManager.this) {
if (repositoryIndex >= size) {
repositoryIndex = 0;
}
start = repositoryIndex;
next = start;
repositoryIndex += toShare;
}
while (toShare > 0 && !die) {
if (shareFile(next)) {
toShare--;
}
next++;
if (next >= size) {
server.setShared(new Range(start, size - 1));
next = 0;
looped = true;
}
if (next >= start && looped) {
break;
}
}
if (looped) {
if (next > 0) {
server.setShared(new Range(0, next - 1));
}
}
else {
server.setShared(new Range(start, next - 1));
}
synchronized(OpenNapServerManager.this) {
repositoryIndex = next;
}
}
else {
for (int i = 0; i < size; i++) {
shareFile(i);
}
server.setShared(new Range(0, size - 1));
}
}
/**
* Returns the number of files that have been shared.
*
* @return -1, if server disconnected
*/
public boolean shareFile(int index)
{
MetaInfoFile f = Library.getInstance().get(index);
if (f != null && f.isShared()) {
MetaInfoManager.handle(f);
ShareFileMessage msg = new ShareFileMessage(index, f);
msg.setExceptionListener(this);
MessageHandler.send(server, msg);
return true;
}
return false;
}
}
private class AutoFetchTask extends XNapTask {
public AutoFetchTask()
{
}
public void run()
{
fetchServerLists();
}
}
// public synchronized void elementAdded(ListEvent e)
// {
// if (e.getSource() == Repository.getInstance()) {
// if (!napPrefs.getLimitSharesPerOpenNapServer()) {
// RepositoryFile f = (RepositoryFile)e.getElement();
// MessageHandler.send(new ShareFileMessage(e.getIndex(), f));
// }
// }
// }
// public synchronized void elementRemoved(ListEvent e)
// {
// if (e.getSource() == Repository.getInstance()) {
// // FIX ME: check if file is really shared
// RepositoryFile f = (RepositoryFile)e.getElement();
// MessageHandler.send(new UnshareFileMessage(e.getIndex(), f));
// }
// }
}
The table below shows all metrics for OpenNapServerManager.java.
| Metric | Value | Description | |
|---|---|---|---|
| BLOCKS | 155.00 | Number of blocks | |
| BLOCK_COMMENT | 18.00 | Number of block comment lines | |
| COMMENTS | 123.00 | Comment lines | |
| COMMENT_DENSITY | 0.27 | Comment density | |
| COMPARISONS | 76.00 | Number of comparison operators | |
| CYCLOMATIC | 135.00 | Cyclomatic complexity | |
| DECL_COMMENTS | 28.00 | Comments in declarations | |
| DOC_COMMENT | 71.00 | Number of javadoc comment lines | |
| ELOC | 461.00 | Effective lines of code | |
| EXEC_COMMENTS | 12.00 | Comments in executable code | |
| EXITS | 135.00 | Procedure exits | |
| FUNCTIONS | 47.00 | Number of function declarations | |
| HALSTEAD_DIFFICULTY | 0.42 | Halstead difficulty | |
| HALSTEAD_EFFORT | 0.00 | Halstead effort | |
| INTERFACE_COMPLEXITY | 90.00 | Interface complexity | |
| JAVA0001 | 0.00 | JAVA0001 Package name does not contain only lower case letters | |
| JAVA0002 | 0.00 | JAVA0002 Package name does not begin with a top level domain name or country code | |
| JAVA0003 | 0.00 | JAVA0003 Minimize use of on-demand (.*) imports | |
| JAVA0004 | 0.00 | JAVA0004 Unnecessary import from java.lang | |
| JAVA0005 | 0.00 | JAVA0005 Imports not in specified order | |
| JAVA0006 | 0.00 | JAVA0006 Empty finally block | |
| JAVA0007 | 0.00 | JAVA0007 Should not declare public field | |
| JAVA0008 | 1.00 | JAVA0008 Empty catch block | |
| JAVA0009 | 0.00 | JAVA0009 Protected member in final class | |
| JAVA0010 | 0.00 | JAVA0010 Non-instantiable class does not contain a non-private static member | |
| JAVA0011 | 0.00 | JAVA0011 Abstract class does not contain an abstract method | |
| JAVA0012 | 0.00 | JAVA0012 Non-constructor method with same name as declaring class | |
| JAVA0013 | 0.00 | JAVA0013 Non-blank final field is not static | |
| JAVA0014 | 0.00 | JAVA0014 Class with only static members has non-private constructor | |
| JAVA0015 | 0.00 | JAVA0015 Package class contains public nested type | |
| JAVA0016 | 0.00 | JAVA0016 Abstract class contains non-protected constructor | |
| JAVA0017 | 0.00 | JAVA0017 Class name does not have required form | |
| JAVA0018 | 0.00 | JAVA0018 Method name does not have required form | |
| JAVA0019 | 0.00 | JAVA0019 Interface name does not have required form | |
| JAVA0020 | 0.00 | JAVA0020 Field name does not have required form | |
| JAVA0021 | 0.00 | JAVA0021 Interface method name does not have required form | |
| JAVA0022 | 0.00 | JAVA0022 Static final field name does not have required form | |
| JAVA0023 | 0.00 | JAVA0023 Empty finalize method | |
| JAVA0024 | 0.00 | JAVA0024 Empty class | |
| JAVA0025 | 0.00 | JAVA0025 Method override is empty | |
| JAVA0026 | 0.00 | JAVA0026 Finalize method with parameters | |
| JAVA0029 | 0.00 | JAVA0029 Private method not used | |
| JAVA0030 | 0.00 | JAVA0030 Private field not used | |
| JAVA0031 | 0.00 | JAVA0031 Case statement not properly closed | |
| JAVA0032 | 0.00 | JAVA0032 Switch statement missing default | |
| JAVA0033 | 0.00 | JAVA0033 default: not last case in switch statement | |
| JAVA0034 | 0.00 | JAVA0034 Missing braces in if statement | |
| JAVA0035 | 0.00 | JAVA0035 Missing braces in for statement | |
| JAVA0036 | 0.00 | JAVA0036 Missing braces in while statement | |
| JAVA0038 | 0.00 | JAVA0038 Non-case label in switch statement | |
| JAVA0039 | 0.00 | JAVA0039 Break statement with label | |
| JAVA0040 | 0.00 | JAVA0040 Switch statement contains N cases (maximum: M) | |
| JAVA0041 | 1.00 | JAVA0041 Nested synchronized block | |
| JAVA0042 | 0.00 | JAVA0042 Empty synchronized statement | |
| JAVA0043 | 0.00 | JAVA0043 Inner class does not use outer class | |
| JAVA0044 | 0.00 | JAVA0044 Serializable class with no instance variables | |
| JAVA0045 | 0.00 | JAVA0045 Serializable class with only transient fields | |
| JAVA0046 | 0.00 | JAVA0046 Name of class not derived from Exception ends with 'Exception' | |
| JAVA0047 | 0.00 | JAVA0047 Serializable class derives from invalid base class | |
| JAVA0048 | 0.00 | JAVA0048 Name of class derived from Exception does not end with 'Exception' | |
| JAVA0049 | 0.00 | JAVA0049 Nested block at depth N (maximum: M) | |
| JAVA0050 | 0.00 | JAVA0050 Class derives from java.lang.Error | |
| JAVA0051 | 0.00 | JAVA0051 Class derives from java.lang.RuntimeException | |
| JAVA0052 | 0.00 | JAVA0052 Class derives from java.lang.Throwable | |
| JAVA0053 | 0.00 | JAVA0053 Unused label | |
| JAVA0054 | 0.00 | JAVA0054 Inheritance depth N exceeds maximum M | |
| JAVA0055 | 0.00 | JAVA0055 Class should be interface | |
| JAVA0056 | 0.00 | JAVA0056 Unnecessary abstract modifier for interface or annotation | |
| JAVA0057 | 0.00 | JAVA0057 Unnecessary default constructor | |
| JAVA0058 | 0.00 | JAVA0058 Constructor calls super() | |
| JAVA0059 | 0.00 | JAVA0059 Method override only calls super() | |
| JAVA0061 | 0.00 | JAVA0061 Inaccessible member in anonymous class | |
| JAVA0062 | 0.00 | JAVA0062 Public class missing public member or protected constructor | |
| JAVA0063 | 0.00 | JAVA0063 Identifier name should not contain '$' | |
| JAVA0064 | 0.00 | JAVA0064 N variations of identifier name (maximum: M) | |
| JAVA0065 | 0.00 | JAVA0065 Unnecessary final modifier for method in final class | |
| JAVA0066 | 0.00 | JAVA0066 Unnecessary modifier for interface nested type | |
| JAVA0067 | 0.00 | JAVA0067 Array descriptor on identifier name | |
| JAVA0068 | 0.00 | JAVA0068 Modifiers not declared in recommended order | |
| JAVA0071 | 0.00 | JAVA0071 Strings compared with == | |
| JAVA0073 | 0.00 | JAVA0073 Integer division in floating-point context | |
| JAVA0074 | 2.00 | JAVA0074 Use of Object.notify() | |
| JAVA0075 | 4.00 | JAVA0075 Method parameter hides field | |
| JAVA0076 | 7.00 | JAVA0076 Use of magic number | |
| JAVA0077 | 1.00 | JAVA0077 Private field not used in declaring class | |
| JAVA0078 | 0.00 | JAVA0078 Floating point values compared with == | |
| JAVA0079 | 0.00 | JAVA0079 Use of instance to reference static member | |
| JAVA0080 | 0.00 | JAVA0080 Import declaration not used | |
| JAVA0081 | 0.00 | JAVA0081 Boolean literal in comparison | |
| JAVA0082 | 0.00 | JAVA0082 Unnecessary widening cast | |
| JAVA0083 | 0.00 | JAVA0083 Unnecessary instanceof test | |
| JAVA0084 | 1.00 | JAVA0084 Should use compound assignment operator | |
| JAVA0085 | 0.00 | JAVA0085 Use of sun.* class | |
| JAVA0087 | 1.00 | JAVA0087 Use of Thread.sleep() | |
| JAVA0089 | 0.00 | JAVA0089 Use of restricted package | |
| JAVA0092 | 0.00 | JAVA0092 Use of restricted type | |
| JAVA0093 | 0.00 | JAVA0093 Redundant assignment | |
| JAVA0094 | 0.00 | JAVA0094 Field hides a superclass field | |
| JAVA0095 | 0.00 | JAVA0095 Uninitialized private field | |
| JAVA0096 | 0.00 | JAVA0096 Field in nested class hides outer field | |
| JAVA0098 | 1.00 | JAVA0098 Minimize use of implicit field initializers | |
| JAVA0100 | 1.00 | JAVA0100 Class contains N non-final fields (maximum: M) | |
| JAVA0101 | 0.00 | JAVA0101 Unnecessary modifier for field in interface | |
| JAVA0102 | 0.00 | JAVA0102 Last statement in finalize() not super.finalize() | |
| JAVA0103 | 0.00 | JAVA0103 Explicit call to finalize() | |
| JAVA0104 | 0.00 | JAVA0104 finalize() only calls super.finalize() | |
| JAVA0105 | 0.00 | JAVA0105 Duplicate import declaration | |
| JAVA0106 | 0.00 | JAVA0106 Unnecessary import from current package | |
| JAVA0108 | 9.00 | JAVA0108 Incorrect javadoc: no @param tag for 'parameter' | |
| JAVA0109 | 0.00 | JAVA0109 Incorrect javadoc: no parameter 'parameter' | |
| JAVA0110 | 3.00 | JAVA0110 Incorrect javadoc: no @return tag | |
| JAVA0111 | 0.00 | JAVA0111 Incorrect javadoc: @return tag for void method | |
| JAVA0112 | 0.00 | JAVA0112 Incorrect javadoc: no exception 'exception' in throws | |
| JAVA0113 | 0.00 | JAVA0113 Incorrect javadoc: no @author tag | |
| JAVA0114 | 0.00 | JAVA0114 Incorrect javadoc: no @version tag | |
| JAVA0115 | 1.00 | JAVA0115 Incorrect javadoc: no @throws or @exception tag for 'exception' | |
| JAVA0116 | 0.00 | JAVA0116 Missing javadoc: field 'field' | |
| JAVA0117 | 25.00 | JAVA0117 Missing javadoc: method 'method' | |
| JAVA0118 | 3.00 | JAVA0118 Missing javadoc: type 'type' | |
| JAVA0119 | 0.00 | JAVA0119 Control variable changed within body of for loop | |
| JAVA0123 | 6.00 | JAVA0123 Use all three components of for loop | |
| JAVA0125 | 0.00 | JAVA0125 Continue statement with label | |
| JAVA0126 | 0.00 | JAVA0126 Method declares unchecked exception in throws | |
| JAVA0128 | 1.00 | JAVA0128 Public constructor in non-public class | |
| JAVA0130 | 1.00 | JAVA0130 Non-static method does not use instance fields | |
| JAVA0131 | 0.00 | JAVA0131 Compatible method does not override base | |
| JAVA0132 | 0.00 | JAVA0132 Method overload with compatible signature | |
| JAVA0133 | 0.00 | JAVA0133 Non-synchronized method overrides synchronized method | |
| JAVA0135 | 0.00 | JAVA0135 Only one of Object.equals and Object.hashCode defined: missing 'method' | |
| JAVA0136 | 1.00 | JAVA0136 N methods defined in class (maximum: M) | |
| JAVA0137 | 2.00 | JAVA0137 Non-abstract class missing constructor | |
| JAVA0138 | 0.00 | JAVA0138 N parameters defined for method (maximum: M) | |
| JAVA0139 | 0.00 | JAVA0139 Definition of main other than public static void main(java.lang.String[]) | |
| JAVA0141 | 0.00 | JAVA0141 Unnecessary modifier for method in interface | |
| JAVA0143 | 11.00 | JAVA0143 Synchronized method | |
| JAVA0144 | 1.00 | JAVA0144 Line exceeds maximum M characters | |
| JAVA0145 | 1909.00 | JAVA0145 Tab character used in source file | |
| JAVA0150 | 0.00 | JAVA0150 java.lang.Error (or subclass) thrown | |
| JAVA0153 | 0.00 | JAVA0153 Inefficient conversion of integer to string | |
| JAVA0159 | 0.00 | JAVA0159 Inefficient conversion of string to integer | |
| JAVA0160 | 0.00 | JAVA0160 Method does not throw specified exception | |
| JAVA0161 | 2.00 | JAVA0161 Conditional wait() not in loop | |
| JAVA0163 | 0.00 | JAVA0163 Empty statement | |
| JAVA0165 | 0.00 | JAVA0165 Conflicting return statement in finally block | |
| JAVA0166 | 0.00 | JAVA0166 Generic exception caught | |
| JAVA0167 | 0.00 | JAVA0167 ThreadDeath not rethrown | |
| JAVA0169 | 0.00 | JAVA0169 Unnecessary catch block: exception 'exception' | |
| JAVA0170 | 0.00 | JAVA0170 Caught exception not derived from java.lang.Exception | |
| JAVA0171 | 0.00 | JAVA0171 Unused local variable | |
| JAVA0173 | 1.00 | JAVA0173 Unused method parameter | |
| JAVA0174 | 0.00 | JAVA0174 Assigned local variable never used | |
| JAVA0175 | 0.00 | JAVA0175 Successive assignment to variable | |
| JAVA0176 | 0.00 | JAVA0176 Local variable name does not have required form | |
| JAVA0177 | 4.00 | JAVA0177 Variable declaration missing initializer | |
| JAVA0179 | 0.00 | JAVA0179 Local variable hides visible field | |
| JAVA0233 | 0.00 | JAVA0233 Definition of serialVersionUID other than 'private static final long serialVersionUID' | |
| JAVA0234 | 0.00 | JAVA0234 Class is Serializable but does not define serialVersionUID | |
| JAVA0235 | 0.00 | JAVA0235 Class defines serialVersionUID but does not implement Serializable | |
| JAVA0236 | 0.00 | JAVA0236 Attempt to clone an object which does not implement Cloneable | |
| JAVA0237 | 0.00 | JAVA0237 Class implements Cloneable but does not have public clone method | |
| JAVA0238 | 0.00 | JAVA0238 Clone method does not call super.clone() | |
| JAVA0239 | 0.00 | JAVA0239 Class declares 'readObject' or 'writeObject' but does not implement Serializable | |
| JAVA0240 | 0.00 | JAVA0240 Serializable class which declares readObject or writeObject but not both | |
| JAVA0241 | 0.00 | JAVA0241 'readObject' or 'writeObject' should be declared private in Serializable class | |
| JAVA0242 | 0.00 | JAVA0242 Transient field in non-Serializable class | |
| JAVA0243 | 0.00 | JAVA0243 'readResolve' or 'writeReplace' should be declared private or protected | |
| JAVA0244 | 0.00 | JAVA0244 Field or method name in subclass differs only by case from inherited field or method | |
| JAVA0245 | 0.00 | JAVA0245 JUnit TestCase with non-trivial constructor | |
| JAVA0246 | 0.00 | JAVA0246 JUnit assertXXX statement missing message parameter | |
| JAVA0247 | 0.00 | JAVA0247 JUnit 'setUp()' and 'tearDown()' should call super method | |
| JAVA0248 | 0.00 | JAVA0248 JUnit method 'setUp' or 'tearDown' with incorrect signature | |
| JAVA0249 | 0.00 | JAVA0249 JUnit TestCase 'suite()' should be declared static | |
| JAVA0250 | 0.00 | JAVA0250 JUnit TestCase declares testXXX method with incorrect signature | |
| JAVA0251 | 0.00 | JAVA0251 Use '%n' for line breaks in printf/format for platform independence | |
| JAVA0252 | 0.00 | JAVA0252 'enum' is a Java 1.5 reserved word | |
| JAVA0253 | 0.00 | JAVA0253 Not all enum constants consumed in switch statement | |
| JAVA0254 | 6.00 | JAVA0254 Use enhanced for loop construct instead of Iterator | |
| JAVA0255 | 0.00 | JAVA0255 Result of method invocation not used | |
| JAVA0256 | 0.00 | JAVA0256 Assignment of external collection/array to field | |
| JAVA0257 | 0.00 | JAVA0257 Use of 'Constant Interface' anti-pattern | |
| JAVA0258 | 0.00 | JAVA0258 Implement Iterable for foreach compatibility | |
| JAVA0259 | 0.00 | JAVA0259 Return of collection/array field | |
| JAVA0260 | 0.00 | JAVA0260 Use 'enum' instead of Enumerated Type pattern | |
| JAVA0261 | 0.00 | JAVA0261 Use specialized Enum collection types | |
| JAVA0262 | 0.00 | JAVA0262 Use of char in integer context | |
| JAVA0263 | 0.00 | JAVA0263 Long literal ends with 'l' instead of 'L' | |
| JAVA0264 | 5.00 | JAVA0264 Integer math in long context - check for overflow | |
| JAVA0265 | 0.00 | JAVA0265 Use of Throwable.printStackTrace() | |
| JAVA0266 | 0.00 | JAVA0266 Use of System.out | |
| JAVA0267 | 0.00 | JAVA0267 Use of System.err | |
| JAVA0269 | 0.00 | JAVA0269 Contents of StringBuffer never used | |
| JAVA0270 | 0.00 | JAVA0270 Use Java 5.0 enhanced for loop construct to iterate over all elements in an array | |
| JAVA0271 | 0.00 | JAVA0271 Minimize use of on-demand (.*) static imports | |
| JAVA0272 | 0.00 | JAVA0272 Thread.run() called | |
| JAVA0273 | 0.00 | JAVA0273 Non-final derivative of Thread calls start() in constructor | |
| JAVA0274 | 0.00 | JAVA0274 Serializable class has a synchronized readObject() | |
| JAVA0275 | 0.00 | JAVA0275 Serializable class has a synchronized writeObject() and no other synchronized methods | |
| JAVA0276 | 0.00 | JAVA0276 Unnecessary use of String constructor | |
| JAVA0277 | 0.00 | JAVA0277 Iterator.next() implementation does not throw NoSuchElementException | |
| JAVA0278 | 0.00 | JAVA0278 Unnecessary use of Boolean constructor | |
| JAVA0279 | 0.00 | JAVA0279 Serialization method readObject or readObjectNoData calls an overridable method | |
| JAVA0280 | 0.00 | JAVA0280 IllegalMonitorStateException caught | |
| JAVA0281 | 0.00 | JAVA0281 Iterator.next() not called in loop | |
| JAVA0282 | 0.00 | JAVA0282 Call to Iterator.next() in loop which does not test Iterator.hasNext() | |
| JAVA0283 | 0.00 | JAVA0283 Control variable not updated in loop body | |
| JAVA0284 | 0.00 | JAVA0284 Explicit garbage collection | |
| JAVA0285 | 0.00 | JAVA0285 Dereference of potentially null variable | |
| JAVA0286 | 0.00 | JAVA0286 Dereference of null variable | |
| JAVA0287 | 0.00 | JAVA0287 Unnecessary null check | |
| JAVA0288 | 0.00 | JAVA0288 Inconsistent null check | |
| JAVA0289 | 3.00 | null | |
| LINES | 933.00 | Number of lines in the source file | |
| LINE_COMMENT | 34.00 | Number of line comments | |
| LOC | 672.00 | Lines of code | |
| LOGICAL_LINES | 298.00 | Number of statements | |
| LOOPS | 15.00 | Number of loops | |
| NEST_DEPTH | 5.00 | Maximum nesting depth | |
| OPERANDS | 1172.00 | Number of operands | |
| OPERATORS | 2495.00 | Number of operators | |
| PARAMS | 27.00 | Number of formal parameter declarations | |
| PROGRAM_LENGTH | 3667.00 | Halstead program length | |
| PROGRAM_VOCAB | 458.00 | Halstead program vocabulary | |
| PROGRAM_VOLUME | 0.00 | Halstead program volume | |
| RETURNS | 63.00 | Number of return points from functions | |
| SIZE | 20935.00 | Size of the file in bytes | |
| UNIQUE_OPERANDS | 400.00 | Number of unique operands | |
| UNIQUE_OPERATORS | 58.00 | Number of unique operators | |
| WHITESPACE | 138.00 | Number of whitespace lines | |