Connections.java
| Index Score | ||
|---|---|---|
 |
 |
xnap.plugin.gnutella.net |
 |
 |
XNap 2 |
View: Reasons, Metrics, Source Code
These are the metrics that contribute to the Enerjy Score for this file, ranked by impact. So the metrics listed at the top influence the score to a greater extent that the metrics listed at the bottom.
| Metric | Description | |
|---|---|---|
| JAVA0143 | JAVA0143 Synchronized method |  |
| JAVA0117 | JAVA0117 Missing javadoc: method 'method' | |
| JAVA0034 | JAVA0034 Missing braces in if statement | |
| JAVA0254 | JAVA0254 Use enhanced for loop construct instead of Iterator | |
| EXITS | Procedure exits | |
| CYCLOMATIC | Cyclomatic complexity | |
| LOOPS | Number of loops | |
| JAVA0242 | JAVA0242 Transient field in non-Serializable class | |
| BLOCKS | Number of blocks | |
| PROGRAM_VOCAB | Halstead program vocabulary | |
| UNIQUE_OPERANDS | Number of unique operands | |
| JAVA0030 | JAVA0030 Private field not used | |
| LOC | Lines of code | |
| FUNCTIONS | Number of function declarations | |
| UNIQUE_OPERATORS | Number of unique operators | |
| COMPARISONS | Number of comparison operators | |
| OPERATORS | Number of operators | |
| JAVA0008 | JAVA0008 Empty catch block | |
| LOGICAL_LINES | Number of statements | |
| PROGRAM_VOLUME | Halstead program volume | |
| JAVA0136 | JAVA0136 N methods defined in class (maximum: M) | |
| ELOC | Effective lines of code | |
| JAVA0032 | JAVA0032 Switch statement missing default | |
| JAVA0080 | JAVA0080 Import declaration not used | |
| PROGRAM_LENGTH | Halstead program length | |
| JAVA0126 | JAVA0126 Method declares unchecked exception in throws | |
| JAVA0110 | JAVA0110 Incorrect javadoc: no @return tag | |
| JAVA0173 | JAVA0173 Unused method parameter | |
| JAVA0029 | JAVA0029 Private method not used | |
| JAVA0013 | JAVA0013 Non-blank final field is not static | |
| JAVA0100 | JAVA0100 Class contains N non-final fields (maximum: M) | |
| COMMENTS | Comment lines | |
| RETURNS | Number of return points from functions | |
| DOC_COMMENT | Number of javadoc comment lines | |
| DECL_COMMENTS | Comments in declarations | |
| INTERFACE_COMPLEXITY | Interface complexity | |
| LINE_COMMENT | Number of line comments | |
| EXEC_COMMENTS | Comments in executable code | |
| JAVA0270 | JAVA0270 Use Java 5.0 enhanced for loop construct to iterate over all elements in an array | |
| LINES | Number of lines in the source file | |
/*
* XNap
*
* A pure java file sharing client.
*
* See AUTHORS for copyright information.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
*
*/
package xnap.plugin.gnutella.net;
import xnap.plugin.gnutella.util.*;
import xnap.*;
import xnap.io.*;
import xnap.net.*;
import xnap.net.event.*;
import xnap.util.*;
import xnap.util.event.*;
import java.beans.*;
import java.io.*;
import java.util.*;
import java.text.*;
import java.net.*;
import org.apache.log4j.Logger;
public class Connections extends EventVector
implements Runnable, PropertyChangeListener, StatusChangeListener
{
//--- Constant(s) ---
public static final int LOGIN_INTERVAL = 300000;
//--- Data field(s) ---
private static Connections instance;
protected static Logger logger = Logger.getLogger(Connections.class);
protected transient PropertyChangeSupport propertyChange
= new PropertyChangeSupport(this);
private Preferences prefs = Preferences.getInstance();
private GnuPreferences gnuPrefs = GnuPreferences.getInstance();
private int maxConnect = gnuPrefs.getMaxConnections();
private int maxTrying = 2 * maxConnect;
private int connectedCount = 0;
private int tryingCount = 0;
private boolean die = false;
private Thread runner = null;
private Timer timer;
public final int DISCONNECT_INTERVAL = 10 * 1000;
private boolean enabled = false;
private ListenerThread listener = null;
private ServentVector connectedServents = new ServentVector();
private Object lock = new Object();
//--- Constructor(s) ---
private Connections()
{
gnuPrefs.addPropertyChangeListener(this);
listener = new ListenerThread(gnuPrefs.getLocalPort(),
gnuPrefs.getLocalPort());
}
//--- Method(s) ---
public static synchronized Connections getInstance()
{
if (instance == null) {
instance = new Connections();
}
return instance;
}
private void addAutoConnectServents()
{
addServent("connect1.gnutellanet.com:6346", true);
addServent("connect2.gnutellanet.com:6346", true);
addServent("connect3.gnutellanet.com:6346", true);
addServent("connect4.gnutellanet.com:6346", true);
addServent("gnutella.hostscache.com:6364", true);
addServent("router.limewire.com:6346", true);
addServent("qtellaconnect.ath.cx:6347", true);
addServent("public.bearshare.net:6346", true);
}
public boolean addServent(String url, boolean connect)
{
StringTokenizer s = new StringTokenizer(url, ":");
if (s.countTokens() != 2)
return false;
String ip = s.nextToken();
int port = 0;
try {
port = Integer.parseInt(s.nextToken());
}
catch (NumberFormatException e) {
}
if (ip.equals("") || port <= 0)
return false;
Servent servent = new Servent(ip, port);
addServent(servent);
if (connect)
servent.start();
return true;
}
public synchronized void addServent(Servent servent)
{
if (! super.contains(servent)) {
super.add(servent);
servent.addStatusChangeListener(this);
wakeup();
}
}
public void addServent(String firstLine, Socket socket)
{
if (connectedCount < gnuPrefs.getMaxConnections()) {
Servent s = new Servent(firstLine, socket);
addServent(s);
doConnect(s);
}
}
public EventVector getConnectedServents()
{
return connectedServents;
}
public synchronized void removeServent(int index)
{
if (gnuPrefs.getCleanDisconnected()) {
Servent s = (Servent) super.get(index);
s.removeStatusChangeListener(this);
super.remove(index);
}
}
public synchronized void removeServent(Servent s)
{
if (gnuPrefs.getCleanDisconnected()) {
s.removeStatusChangeListener(this);
remove(s);
}
}
public void setEnabled(boolean newValue)
{
enabled = newValue;
if (enabled) {
if (runner != null) {
wakeup();
}
}
}
private void wakeup()
{
if (enabled) {
synchronized (lock) {
lock.notify();
}
}
}
public void init()
{
Debug.log("gnutella: Connections started");
runner = new Thread(this);
runner.start();
(new Thread("ConnectionsInit")
{
public void run()
{
addFromFile(gnuPrefs.getServentsFile());
}
}
).start();
}
public void run()
{
int next = 0;
while (!die) {
if (next > super.size())
next = 0;
int start = next;
boolean looped = false;
while (super.size() > 0 && connectedCount <= maxConnect
&& tryingCount <= maxTrying) {
Debug.log("gnutella: connections next servent: " + next);
Servent s = (Servent) super.get(next);
if (s.getStatus() == Servent.STATUS_NOT_CONNECTED) {
doConnect(s);
}
next++;
if (next >= super.size()) {
next = 0;
looped = true;
}
if (looped && next >= start)
break;
}
if (super.size() == 0) {
Debug.log("gnutella: need to contact autoconnect hosts");
// addAutoConnectServents();
}
synchronized (lock) {
try {
lock.wait();
}
catch (InterruptedException e) {
}
}
}
}
public void die()
{
die = true;
synchronized (lock) {
lock.notify();
}
listener.die();
listener = null;
for (Iterator i = super.iterator(); i.hasNext();) {
doDisconnect((Servent) i.next());
}
instance = null;
}
public void addFromFile(String filename)
{
Servent s;
ServentFile reader = new ServentFile(filename);
if (reader.openReader()) {
while ((s = reader.readServent()) != null) {
addServent(s);
}
}
reader.close();
}
public void saveToFile(String filename)
{
ServentFile writer = new ServentFile(filename);
if (writer.openWriter()) {
/* save cache entries first */
int j = 0;
/* save connections vector */
for (Iterator i = iterator(); i.hasNext() && j < 100; j++) {
writer.writeServent((Servent)i.next());
}
}
writer.close();
}
public void propertyChange(PropertyChangeEvent e)
{
String p = e.getPropertyName();
if (p.equals("localPort")) {
if (listener != null) {
listener.die();
}
listener = new ListenerThread(gnuPrefs.getLocalPort(),
gnuPrefs.getLocalPort());
if (listener.getPort() == 0) {
// setStatusText("Could not start listener (check local port)");
}
}
else if (p.equals("maxConnections")) {
maxConnect = gnuPrefs.getMaxConnections();
maxTrying = 2 * maxConnect;
}
}
public void statusChange(StatusChangeEvent e)
{
switch (e.getNewStatus()) {
case Servent.STATUS_DISCONNECTED:
if (e.getOldStatus() == Servent.STATUS_CONNECTED) {
connectedCount--;
}
else if (e.getOldStatus() == Servent.STATUS_CONNECTING) {
tryingCount--;
}
Servent servent = (Servent) e.getSource();
removeServent(servent);
connectedServents.remove(servent);
wakeup();
break;
case Servent.STATUS_CONNECTED:
if (e.getOldStatus() == Servent.STATUS_CONNECTING) {
connectedCount++;
tryingCount--;
servent = (Servent) e.getSource();
connectedServents.add(servent);
}
break;
case Servent.STATUS_NEW_STATS:
break;
}
}
public synchronized void sendMessage(Message msg)
{
for (Iterator i = connectedServents.iterator(); i.hasNext();) {
Servent con = (Servent) i.next();
con.send(msg, Servent.PRIORITY_NORMAL);
}
}
public synchronized void broadcastMessage(Message msg, Servent source)
{
for (Iterator i = connectedServents.iterator(); i.hasNext();) {
Servent servent = (Servent) i.next();
if (servent != source) {
servent.send(msg, Servent.PRIORITY_BROADCAST);
}
}
}
public void sendPong(PingMessage msg, Servent servent)
{
if (msg.getTTL() + msg.getHops() > 2
|| getConnectedCount() >= gnuPrefs.getMaxConnections())
return;
Repository repository = Repository.getInstance();
PongMessage pongMsg = new PongMessage(msg.getMessageID(),
(short) gnuPrefs.getLocalPort(),
IPHelper.ipStringToBytearray(servent.getLocalAddress()),
repository.getNonNullSize(),
200000);
pongMsg.setTTL(msg.getHops());
servent.send(pongMsg, Servent.PRIORITY_BROADCAST);
}
public void searchRepository(QueryMessage msg, Servent servent)
{
File[] results = Repository.getInstance().search(msg.getSearchString());
if (results != null) {
for (int i = 0; i < results.length; i++) {
}
}
}
/**
* Caches incoming pong messages.
*/
public synchronized void incomingPong(PongMessage msg)
{
String ip = msg.getIP();
if (IPHelper.isPrivateIP(ip))
return;
// Debug.log("Getting new Pong Host", Debug.C_NETWORK);
if (size() < 100) {
addServent(new Servent(ip, msg.getPort()));
}
}
public int getConnectedCount()
{
return connectedCount;
}
public void doConnect(Servent servent)
{
tryingCount++;
servent.start();
}
public void doDisconnect(Servent servent)
{
servent.stop();
}
public ListenerThread getListener()
{
return listener;
}
public int getListenerPort()
{
if (listener != null)
return listener.getPort();
return 0;
}
private class DisconnectTask extends TimerTask
{
public void run()
{
synchronized (Connections.this) {
for (Iterator i = iterator(); i.hasNext(); ) {
Servent s = (Servent) i.next();
if (s.getStatus() == Servent.STATUS_CONNECTING
&& s.getUpTime() == 0
&& s.getConnectTime() > DISCONNECT_INTERVAL) {
Debug.log("DisconnectTask: disconnect");
doDisconnect(s);
}
}
}
}
}
public static class ServentVector extends EventVector
{
public void add(Servent s)
{
super.add(s);
}
public void remove(Servent s)
{
super.remove(s);
}
}
}
The table below shows all metrics for Connections.java.
| Metric | Value | Description | |
|---|---|---|---|
| BLOCKS | 73.00 | Number of blocks | |
| BLOCK_COMMENT | 24.00 | Number of block comment lines | |
| COMMENTS | 34.00 | Comment lines | |
| COMMENT_DENSITY | 0.14 | Comment density | |
| COMPARISONS | 45.00 | Number of comparison operators | |
| CYCLOMATIC | 86.00 | Cyclomatic complexity | |
| DECL_COMMENTS | 6.00 | Comments in declarations | |
| DOC_COMMENT | 3.00 | Number of javadoc comment lines | |
| ELOC | 245.00 | Effective lines of code | |
| EXEC_COMMENTS | 5.00 | Comments in executable code | |
| EXITS | 63.00 | Procedure exits | |
| FUNCTIONS | 32.00 | Number of function declarations | |
| HALSTEAD_DIFFICULTY | 68.53 | Halstead difficulty | |
| HALSTEAD_EFFORT | 0.00 | Halstead effort | |
| INTERFACE_COMPLEXITY | 61.00 | Interface complexity | |
| JAVA0001 | 0.00 | JAVA0001 Package name does not contain only lower case letters | |
| JAVA0002 | 1.00 | JAVA0002 Package name does not begin with a top level domain name or country code | |
| JAVA0003 | 0.00 | JAVA0003 Minimize use of on-demand (.*) imports | |
| JAVA0004 | 0.00 | JAVA0004 Unnecessary import from java.lang | |
| JAVA0005 | 1.00 | JAVA0005 Imports not in specified order | |
| JAVA0006 | 0.00 | JAVA0006 Empty finally block | |
| JAVA0007 | 0.00 | JAVA0007 Should not declare public field | |
| JAVA0008 | 2.00 | JAVA0008 Empty catch block | |
| JAVA0009 | 0.00 | JAVA0009 Protected member in final class | |
| JAVA0010 | 0.00 | JAVA0010 Non-instantiable class does not contain a non-private static member | |
| JAVA0011 | 0.00 | JAVA0011 Abstract class does not contain an abstract method | |
| JAVA0012 | 0.00 | JAVA0012 Non-constructor method with same name as declaring class | |
| JAVA0013 | 1.00 | JAVA0013 Non-blank final field is not static | |
| JAVA0014 | 0.00 | JAVA0014 Class with only static members has non-private constructor | |
| JAVA0015 | 0.00 | JAVA0015 Package class contains public nested type | |
| JAVA0016 | 0.00 | JAVA0016 Abstract class contains public constructor | |
| JAVA0017 | 0.00 | JAVA0017 Class name does not have required form | |
| JAVA0018 | 0.00 | JAVA0018 Method name does not have required form | |
| JAVA0019 | 0.00 | JAVA0019 Interface name does not have required form | |
| JAVA0020 | 0.00 | JAVA0020 Field name does not have required form | |
| JAVA0021 | 0.00 | JAVA0021 Interface method name does not have required form | |
| JAVA0022 | 0.00 | JAVA0022 Static final field name does not have required form | |
| JAVA0023 | 0.00 | JAVA0023 Empty finalize method | |
| JAVA0024 | 0.00 | JAVA0024 Empty class | |
| JAVA0025 | 0.00 | JAVA0025 Method override is empty | |
| JAVA0026 | 0.00 | JAVA0026 Finalize method with parameters | |
| JAVA0029 | 1.00 | JAVA0029 Private method not used | |
| JAVA0030 | 2.00 | JAVA0030 Private field not used | |
| JAVA0031 | 0.00 | JAVA0031 Case statement not properly closed | |
| JAVA0032 | 1.00 | JAVA0032 Switch statement missing default | |
| JAVA0033 | 0.00 | JAVA0033 default: not last case in switch statement | |
| JAVA0034 | 8.00 | JAVA0034 Missing braces in if statement | |
| JAVA0035 | 0.00 | JAVA0035 Missing braces in for statement | |
| JAVA0036 | 0.00 | JAVA0036 Missing braces in while statement | |
| JAVA0038 | 0.00 | JAVA0038 Non-case label in switch statement | |
| JAVA0039 | 0.00 | JAVA0039 Break statement with label | |
| JAVA0040 | 0.00 | JAVA0040 Switch statement contains N cases (maximum: M) | |
| JAVA0041 | 0.00 | JAVA0041 Nested synchronized block | |
| JAVA0042 | 0.00 | JAVA0042 Empty synchronized statement | |
| JAVA0043 | 0.00 | JAVA0043 Inner class does not use outer class | |
| JAVA0044 | 0.00 | JAVA0044 Serializable class with no instance variables | |
| JAVA0045 | 0.00 | JAVA0045 Serializable class with only transient fields | |
| JAVA0046 | 0.00 | JAVA0046 Name of class not derived from Exception ends with 'Exception' | |
| JAVA0047 | 0.00 | JAVA0047 Serializable class derives from invalid base class | |
| JAVA0048 | 0.00 | JAVA0048 Name of class derived from Exception does not end with 'Exception' | |
| JAVA0049 | 0.00 | JAVA0049 Nested block at depth N (maximum: M) | |
| JAVA0050 | 0.00 | JAVA0050 Class derives from java.lang.Error | |
| JAVA0051 | 0.00 | JAVA0051 Class derives from java.lang.RuntimeException | |
| JAVA0052 | 0.00 | JAVA0052 Class derives from java.lang.Throwable | |
| JAVA0053 | 0.00 | JAVA0053 Unused label | |
| JAVA0054 | 0.00 | JAVA0054 Inheritance depth N exceeds maximum M | |
| JAVA0055 | 0.00 | JAVA0055 Class should be interface | |
| JAVA0056 | 0.00 | JAVA0056 Unnecessary abstract modifier for interface or annotation | |
| JAVA0057 | 0.00 | JAVA0057 Unnecessary default constructor | |
| JAVA0058 | 0.00 | JAVA0058 Constructor calls super() | |
| JAVA0059 | 0.00 | JAVA0059 Method override only calls super() | |
| JAVA0061 | 0.00 | JAVA0061 Inaccessible member in anonymous class | |
| JAVA0062 | 0.00 | JAVA0062 Public class missing public member or protected constructor | |
| JAVA0063 | 0.00 | JAVA0063 Identifier name should not contain '$' | |
| JAVA0064 | 0.00 | JAVA0064 N variations of identifier name (maximum: M) | |
| JAVA0065 | 0.00 | JAVA0065 Unnecessary final modifier for method in final class | |
| JAVA0066 | 0.00 | JAVA0066 Unnecessary modifier for interface nested type | |
| JAVA0067 | 0.00 | JAVA0067 Array descriptor on identifier name | |
| JAVA0068 | 0.00 | JAVA0068 Modifiers not declared in recommended order | |
| JAVA0071 | 0.00 | JAVA0071 Strings compared with == | |
| JAVA0073 | 0.00 | JAVA0073 Integer division in floating-point context | |
| JAVA0074 | 2.00 | JAVA0074 Use of Object.notify() | |
| JAVA0075 | 0.00 | JAVA0075 Method parameter hides field | |
| JAVA0076 | 2.00 | JAVA0076 Use of magic number | |
| JAVA0077 | 0.00 | JAVA0077 Private field not used in declaring class | |
| JAVA0078 | 0.00 | JAVA0078 Floating point values compared with == | |
| JAVA0079 | 0.00 | JAVA0079 Use of instance to reference static member | |
| JAVA0080 | 4.00 | JAVA0080 Import declaration not used | |
| JAVA0081 | 0.00 | JAVA0081 Boolean literal in comparison | |
| JAVA0082 | 0.00 | JAVA0082 Unnecessary widening cast | |
| JAVA0083 | 0.00 | JAVA0083 Unnecessary instanceof test | |
| JAVA0084 | 0.00 | JAVA0084 Should use compound assignment operator | |
| JAVA0085 | 0.00 | JAVA0085 Use of sun.* class | |
| JAVA0087 | 0.00 | JAVA0087 Use of Thread.sleep() | |
| JAVA0089 | 0.00 | JAVA0089 Use of restricted package | |
| JAVA0092 | 0.00 | JAVA0092 Use of restricted type | |
| JAVA0093 | 0.00 | JAVA0093 Redundant assignment | |
| JAVA0094 | 0.00 | JAVA0094 Field hides a superclass field | |
| JAVA0095 | 0.00 | JAVA0095 Uninitialized private field | |
| JAVA0096 | 0.00 | JAVA0096 Field in nested class hides outer field | |
| JAVA0098 | 0.00 | JAVA0098 Minimize use of implicit field initializers | |
| JAVA0100 | 1.00 | JAVA0100 Class contains N non-final fields (maximum: M) | |
| JAVA0101 | 0.00 | JAVA0101 Unnecessary modifier for field in interface | |
| JAVA0102 | 0.00 | JAVA0102 Last statement in finalize() not super.finalize() | |
| JAVA0103 | 0.00 | JAVA0103 Explicit call to finalize() | |
| JAVA0104 | 0.00 | JAVA0104 finalize() only calls super.finalize() | |
| JAVA0105 | 0.00 | JAVA0105 Duplicate import declaration | |
| JAVA0106 | 0.00 | JAVA0106 Unnecessary import from current package | |
| JAVA0108 | 1.00 | JAVA0108 Incorrect javadoc: no @param tag for 'parameter' | |
| JAVA0109 | 0.00 | JAVA0109 Incorrect javadoc: no parameter 'parameter' | |
| JAVA0110 | 0.00 | JAVA0110 Incorrect javadoc: no @return tag | |
| JAVA0111 | 0.00 | JAVA0111 Incorrect javadoc: @return tag for void method | |
| JAVA0112 | 0.00 | JAVA0112 Incorrect javadoc: no exception 'exception' in throws | |
| JAVA0113 | 0.00 | JAVA0113 Incorrect javadoc: no @author tag | |
| JAVA0114 | 0.00 | JAVA0114 Incorrect javadoc: no @version tag | |
| JAVA0115 | 0.00 | JAVA0115 Incorrect javadoc: no @throws or @exception tag for 'exception' | |
| JAVA0116 | 2.00 | JAVA0116 Missing javadoc: field 'field' | |
| JAVA0117 | 23.00 | JAVA0117 Missing javadoc: method 'method' | |
| JAVA0118 | 2.00 | JAVA0118 Missing javadoc: type 'type' | |
| JAVA0119 | 0.00 | JAVA0119 Control variable changed within body of for loop | |
| JAVA0123 | 0.00 | JAVA0123 Use all three components of for loop | |
| JAVA0125 | 0.00 | JAVA0125 Continue statement with label | |
| JAVA0126 | 0.00 | JAVA0126 Method declares unchecked exception in throws | |
| JAVA0128 | 0.00 | JAVA0128 Public constructor in non-public class | |
| JAVA0130 | 0.00 | JAVA0130 Non-static method does not use instance fields | |
| JAVA0131 | 2.00 | JAVA0131 Compatible method does not override base | |
| JAVA0132 | 0.00 | JAVA0132 Method overload with compatible signature | |
| JAVA0133 | 0.00 | JAVA0133 Non-synchronized method overrides synchronized method | |
| JAVA0135 | 0.00 | JAVA0135 Only one of Object.equals and Object.hashCode defined: missing 'method' | |
| JAVA0136 | 1.00 | JAVA0136 N methods defined in class (maximum: M) | |
| JAVA0137 | 0.00 | JAVA0137 Non-abstract class missing constructor | |
| JAVA0138 | 0.00 | JAVA0138 N parameters defined for method (maximum: M) | |
| JAVA0139 | 0.00 | JAVA0139 Definition of main other than public static void main(java.lang.String[]) | |
| JAVA0141 | 0.00 | JAVA0141 Unnecessary modifier for method in interface | |
| JAVA0143 | 7.00 | JAVA0143 Synchronized method | |
| JAVA0144 | 0.00 | JAVA0144 Line exceeds maximum M characters | |
| JAVA0145 | 336.00 | JAVA0145 Tab character used in source file | |
| JAVA0150 | 0.00 | JAVA0150 java.lang.Error (or subclass) thrown | |
| JAVA0153 | 0.00 | JAVA0153 Inefficient conversion of integer to string | |
| JAVA0159 | 0.00 | JAVA0159 Inefficient conversion of string to integer | |
| JAVA0160 | 0.00 | JAVA0160 Method does not throw specified exception | |
| JAVA0161 | 0.00 | JAVA0161 Conditional wait() not in loop | |
| JAVA0163 | 0.00 | JAVA0163 Empty statement | |
| JAVA0165 | 0.00 | JAVA0165 Conflicting return statement in finally block | |
| JAVA0166 | 0.00 | JAVA0166 Generic exception caught | |
| JAVA0167 | 0.00 | JAVA0167 ThreadDeath not rethrown | |
| JAVA0169 | 0.00 | JAVA0169 Unnecessary catch block: exception 'exception' | |
| JAVA0170 | 0.00 | JAVA0170 Caught exception not derived from java.lang.Exception | |
| JAVA0171 | 0.00 | JAVA0171 Unused local variable | |
| JAVA0173 | 1.00 | JAVA0173 Unused method parameter | |
| JAVA0174 | 0.00 | JAVA0174 Assigned local variable never used | |
| JAVA0175 | 0.00 | JAVA0175 Successive assignment to variable | |
| JAVA0176 | 0.00 | JAVA0176 Local variable name does not have required form | |
| JAVA0177 | 1.00 | JAVA0177 Variable declaration missing initializer | |
| JAVA0179 | 0.00 | JAVA0179 Local variable hides visible field | |
| JAVA0233 | 0.00 | JAVA0233 Definition of serialVersionUID other than 'private static final long serialVersionUID' | |
| JAVA0234 | 0.00 | JAVA0234 Class is Serializable but does not define serialVersionUID | |
| JAVA0235 | 0.00 | JAVA0235 Class defines serialVersionUID but does not implement Serializable | |
| JAVA0236 | 0.00 | JAVA0236 Attempt to clone an object which does not implement Cloneable | |
| JAVA0237 | 0.00 | JAVA0237 Class implements Cloneable but does not have public clone method | |
| JAVA0238 | 0.00 | JAVA0238 Clone method does not call super.clone() | |
| JAVA0239 | 0.00 | JAVA0239 Class declares 'readObject' or 'writeObject' but does not implement Serializable | |
| JAVA0240 | 0.00 | JAVA0240 Serializable class which declares readObject or writeObject but not both | |
| JAVA0241 | 0.00 | JAVA0241 'readObject' or 'writeObject' should be declared private in Serializable class | |
| JAVA0242 | 1.00 | JAVA0242 Transient field in non-Serializable class | |
| JAVA0243 | 0.00 | JAVA0243 'readResolve' or 'writeReplace' should be declared private or protected | |
| JAVA0244 | 0.00 | JAVA0244 Field or method name in subclass differs only by case from inherited field or method | |
| JAVA0245 | 0.00 | JAVA0245 JUnit TestCase with non-trivial constructor | |
| JAVA0246 | 0.00 | JAVA0246 JUnit assertXXX statement missing message parameter | |
| JAVA0247 | 0.00 | JAVA0247 JUnit 'setUp()' and 'tearDown()' should call super method | |
| JAVA0248 | 0.00 | JAVA0248 JUnit method 'setUp' or 'tearDown' with incorrect signature | |
| JAVA0249 | 0.00 | JAVA0249 JUnit TestCase 'suite()' should be declared static | |
| JAVA0250 | 0.00 | JAVA0250 JUnit TestCase declares testXXX method with incorrect signature | |
| JAVA0251 | 0.00 | JAVA0251 Use '%n' for line breaks in printf/format for platform independence | |
| JAVA0252 | 0.00 | JAVA0252 'enum' is a Java 1.5 reserved word | |
| JAVA0253 | 0.00 | JAVA0253 Not all enum constants consumed in switch statement | |
| JAVA0254 | 5.00 | JAVA0254 Use enhanced for loop construct instead of Iterator | |
| JAVA0255 | 0.00 | JAVA0255 Result of method invocation not used | |
| JAVA0256 | 0.00 | JAVA0256 Assignment of external collection/array to field | |
| JAVA0257 | 0.00 | JAVA0257 Use of 'Constant Interface' anti-pattern | |
| JAVA0258 | 0.00 | JAVA0258 Implement Iterable for foreach compatibility | |
| JAVA0259 | 0.00 | JAVA0259 Return of collection/array field | |
| JAVA0260 | 0.00 | JAVA0260 Use 'enum' instead of Enumerated Type pattern | |
| JAVA0261 | 0.00 | JAVA0261 Use specialized Enum collection types | |
| JAVA0262 | 0.00 | JAVA0262 Use of char in integer context | |
| JAVA0263 | 0.00 | JAVA0263 Long literal ends with 'l' instead of 'L' | |
| JAVA0264 | 0.00 | JAVA0264 Integer math in long context - check for overflow | |
| JAVA0265 | 0.00 | JAVA0265 Use of Throwable.printStackTrace() | |
| JAVA0266 | 0.00 | JAVA0266 Use of System.out | |
| JAVA0267 | 0.00 | JAVA0267 Use of System.err | |
| JAVA0269 | 0.00 | JAVA0269 Contents of StringBuffer never used | |
| JAVA0270 | 1.00 | JAVA0270 Use Java 5.0 enhanced for loop construct to iterate over all elements in an array | |
| JAVA0271 | 0.00 | JAVA0271 Minimize use of on-demand (.*) static imports | |
| JAVA0272 | 0.00 | JAVA0272 Thread.run() called | |
| JAVA0273 | 0.00 | JAVA0273 Non-final derivative of Thread calls start() in constructor | |
| JAVA0274 | 0.00 | JAVA0274 Serializable class has a synchronized readObject() | |
| JAVA0275 | 0.00 | JAVA0275 Serializable class has a synchronized writeObject() and no other synchronized methods | |
| JAVA0276 | 0.00 | JAVA0276 Unnecessary use of String constructor | |
| JAVA0277 | 0.00 | JAVA0277 Iterator.next() implementation does not throw NoSuchElementException | |
| JAVA0278 | 0.00 | JAVA0278 Unnecessary use of Boolean constructor | |
| JAVA0279 | 0.00 | JAVA0279 Serialization method readObject or readObjectNoData calls an overridable method | |
| JAVA0280 | 0.00 | JAVA0280 IllegalMonitorStateException caught | |
| JAVA0281 | 0.00 | JAVA0281 Iterator.next() not called in loop | |
| JAVA0282 | 0.00 | JAVA0282 Call to Iterator.next() in loop which does not test Iterator.hasNext() | |
| JAVA0283 | 0.00 | JAVA0283 Control variable not updated in loop body | |
| JAVA0284 | 0.00 | JAVA0284 Explicit garbage collection | |
| JAVA0285 | 0.00 | JAVA0285 Dereference of potentially null variable | |
| JAVA0286 | 0.00 | JAVA0286 Dereference of null variable | |
| JAVA0287 | 0.00 | JAVA0287 Unnecessary null check | |
| JAVA0288 | 0.00 | JAVA0288 Inconsistent null check | |
| LINES | 468.00 | Number of lines in the source file | |
| LINE_COMMENT | 7.00 | Number of line comments | |
| LOC | 359.00 | Lines of code | |
| LOGICAL_LINES | 156.00 | Number of statements | |
| LOOPS | 9.00 | Number of loops | |
| NEST_DEPTH | 4.00 | Maximum nesting depth | |
| OPERANDS | 607.00 | Number of operands | |
| OPERATORS | 1358.00 | Number of operators | |
| PARAMS | 24.00 | Number of formal parameter declarations | |
| PROGRAM_LENGTH | 1965.00 | Halstead program length | |
| PROGRAM_VOCAB | 304.00 | Halstead program vocabulary | |
| PROGRAM_VOLUME | 0.00 | Halstead program volume | |
| RETURNS | 37.00 | Number of return points from functions | |
| SIZE | 10631.00 | Size of the file in bytes | |
| UNIQUE_OPERANDS | 248.00 | Number of unique operands | |
| UNIQUE_OPERATORS | 56.00 | Number of unique operators | |
| WHITESPACE | 75.00 | Number of whitespace lines | |