AspectJAdviceParameterNameDiscoverer.java

Index Score
org.springframework.aop.aspectj
Spring Framework

View: Reasons, Metrics, Source Code

These are the metrics that contribute to the Enerjy Score for this file, ranked by impact. So the metrics listed at the top influence the score to a greater extent that the metrics listed at the bottom.

MetricDescription
LOOPSNumber of loops
COMPARISONSNumber of comparison operators
CYCLOMATICCyclomatic complexity
BLOCKSNumber of blocks
SIZESize of the file in bytes
EXEC_COMMENTSComments in executable code
JAVA0119JAVA0119 Control variable changed within body of for loop
OPERATORSNumber of operators
LINESNumber of lines in the source file
LOCLines of code
LOGICAL_LINESNumber of statements
PROGRAM_LENGTHHalstead program length
DECL_COMMENTSComments in declarations
ELOCEffective lines of code
COMMENTSComment lines
RETURNSNumber of return points from functions
JAVA0034JAVA0034 Missing braces in if statement
DOC_COMMENTNumber of javadoc comment lines
OPERANDSNumber of operands
LINE_COMMENTNumber of line comments
PROGRAM_VOCABHalstead program vocabulary
UNIQUE_OPERANDSNumber of unique operands
EXITSProcedure exits
INTERFACE_COMPLEXITYInterface complexity
JAVA0145JAVA0145 Tab character used in source file
JAVA0108JAVA0108 Incorrect javadoc: no @param tag for 'parameter'
JAVA0254JAVA0254 Use enhanced for loop construct instead of Iterator
UNIQUE_OPERATORSNumber of unique operators
JAVA0130JAVA0130 Non-static method does not use instance fields
JAVA0128JAVA0128 Public constructor in non-public class
PROGRAM_VOLUMEHalstead program volume
JAVA0136JAVA0136 N methods defined in class (maximum: M)
JAVA0126JAVA0126 Method declares unchecked exception in throws
FUNCTIONSNumber of function declarations
JAVA0117JAVA0117 Missing javadoc: method 'method'
JAVA0051JAVA0051 Class derives from java.lang.RuntimeException
JAVA0100JAVA0100 Class contains N non-final fields (maximum: M)
JAVA0270JAVA0270 Use Java 5.0 enhanced for loop construct to iterate over all elements in an array
NEST_DEPTHMaximum nesting depth
/* * Copyright 2002-2007 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and * limitations under the License. */ package org.springframework.aop.aspectj; import java.lang.reflect.Constructor; import java.lang.reflect.Method; import java.util.ArrayList; import java.util.HashSet; import java.util.Iterator; import java.util.List; import java.util.Set; import org.aspectj.lang.JoinPoint; import org.aspectj.lang.ProceedingJoinPoint; import org.aspectj.weaver.tools.PointcutParser; import org.aspectj.weaver.tools.PointcutPrimitive; import org.springframework.core.ParameterNameDiscoverer; import org.springframework.util.ClassUtils; import org.springframework.util.StringUtils; /** * {@link ParameterNameDiscoverer} implementation that tries to deduce parameter names * for an advice method from the pointcut expression, returning, and throwing clauses. * If an unambiguous interpretation is not available, it returns <code>null</code>. * * <p>This class interprets arguments in the following way: * <ol> * <li>If the first parameter of the method is of type {@link JoinPoint} * or {@link ProceedingJoinPoint}, it is assumed to be for passing * <code>thisJoinPoint</code> to the advice, and the parameter name will * be assigned the value <code>"thisJoinPoint"</code>.</li> * <li>If the first parameter of the method is of type * <code>JoinPoint.StaticPart</code>, it is assumed to be for passing * <code>"thisJoinPointStaticPart"</code> to the advice, and the parameter name * will be assigned the value <code>"thisJoinPointStaticPart"</code>.</li> * <li>If a {@link #setThrowingName(String) throwingName} has been set, and * there are no unbound arguments of type <code>Throwable+</code>, then an * {@link IllegalArgumentException} is raised. If there is more than one * unbound argument of type <code>Throwable+</code>, then an * {@link AmbiguousBindingException} is raised. If there is exactly one * unbound argument of type <code>Throwable+</code>, then the corresponding * parameter name is assigned the value &lt;throwingName&gt;.</li> * <li>If there remain unbound arguments, then the pointcut expression is * examined. Let <code>a</code> be the number of annotation-based pointcut * expressions (&#64;annotation, &#64;this, &#64;target, &#64;args, * &#64;within, &#64;withincode) that are used in binding form. Usage in * binding form has itself to be deduced: if the expression inside the * pointcut is a single string literal that meets Java variable name * conventions it is assumed to be a variable name. If <code>a</code> is * zero we proceed to the next stage. If <code>a</code> &gt; 1 then an * <code>AmbiguousBindingException</code> is raised. If <code>a</code> == 1, * and there are no unbound arguments of type <code>Annotation+</code>, * then an <code>IllegalArgumentException</code> is raised. if there is * exactly one such argument, then the corresponding parameter name is * assigned the value from the pointcut expression.</li> * <li>If a returningName has been set, and there are no unbound arguments * then an <code>IllegalArgumentException</code> is raised. If there is * more than one unbound argument then an * <code>AmbiguousBindingException</code> is raised. If there is exactly * one unbound argument then the corresponding parameter name is assigned * the value &lt;returningName&gt;.</li> * <li>If there remain unbound arguments, then the pointcut expression is * examined once more for <code>this</code>, <code>target</code>, and * <code>args</code> pointcut expressions used in the binding form (binding * forms are deduced as described for the annotation based pointcuts). If * there remains more than one unbound argument of a primitive type (which * can only be bound in <code>args</code>) then an * <code>AmbiguousBindingException</code> is raised. If there is exactly * one argument of a primitive type, then if exactly one <code>args</code> * bound variable was found, we assign the corresponding parameter name * the variable name. If there were no <code>args</code> bound variables * found an <code>IllegalStateException</code> is raised. If there are * multiple <code>args</code> bound variables, an * <code>AmbiguousBindingException</code> is raised. At this point, if * there remains more than one unbound argument we raise an * <code>AmbiguousBindingException</code>. If there are no unbound arguments * remaining, we are done. If there is exactly one unbound argument * remaining, and only one candidate variable name unbound from * <code>this</code>, <code>target</code>, or <code>args</code>, it is * assigned as the corresponding parameter name. If there are multiple * possibilities, an <code>AmbiguousBindingException</code> is raised.</li> * </ol> * * <p>The behavior on raising an <code>IllegalArgumentException</code> or * <code>AmbiguousBindingException</code> is configurable to allow this discoverer * to be used as part of a chain-of-responsibility. By default the condition will * be logged and the <code>getParameterNames(..)</code> method will simply return * <code>null</code>. If the {@link #setRaiseExceptions(boolean) raiseExceptions} * property is set to <code>true</code>, the conditions will be thrown as * <code>IllegalArgumentException</code> and <code>AmbiguousBindingException</code>, * respectively. * * <p>Was that perfectly clear? ;) * * <p>Short version: If an unambiguous binding can be deduced, then it is. * If the advice requirements cannot possibly be satisfied, then <code>null</code> * is returned. By setting the {@link #setRaiseExceptions(boolean) raiseExceptions} * property to <code>true</code>, descriptive exceptions will be thrown instead of * returning <code>null</code> in the case that the parameter names cannot be discovered. * * @author Adrian Colyer * @since 2.0 */ public class AspectJAdviceParameterNameDiscoverer implements ParameterNameDiscoverer { private static final String ANNOTATION_CLASS_NAME = "java.lang.annotation.Annotation"; private static final String THIS_JOIN_POINT = "thisJoinPoint"; private static final String THIS_JOIN_POINT_STATIC_PART = "thisJoinPointStaticPart"; // Steps in the binding algorithm... private static final int STEP_JOIN_POINT_BINDING = 1; private static final int STEP_THROWING_BINDING = 2; private static final int STEP_ANNOTATION_BINDING = 3; private static final int STEP_RETURNING_BINDING = 4; private static final int STEP_PRIMITIVE_ARGS_BINDING = 5; private static final int STEP_THIS_TARGET_ARGS_BINDING = 6; private static final int STEP_REFERENCE_PCUT_BINDING = 7; private static final int STEP_FINISHED = 8; private static final Set singleValuedAnnotationPcds = new HashSet(); private static final Set nonReferencePointcutTokens = new HashSet(); private static Class annotationClass; static { singleValuedAnnotationPcds.add("@this"); singleValuedAnnotationPcds.add("@target"); singleValuedAnnotationPcds.add("@within"); singleValuedAnnotationPcds.add("@withincode"); singleValuedAnnotationPcds.add("@annotation"); Set pointcutPrimitives = PointcutParser.getAllSupportedPointcutPrimitives(); for (Iterator iterator = pointcutPrimitives.iterator(); iterator.hasNext();) { PointcutPrimitive primitive = (PointcutPrimitive) iterator.next(); nonReferencePointcutTokens.add(primitive.getName()); } nonReferencePointcutTokens.add("&&"); nonReferencePointcutTokens.add("!"); nonReferencePointcutTokens.add("||"); nonReferencePointcutTokens.add("and"); nonReferencePointcutTokens.add("or"); nonReferencePointcutTokens.add("not"); try { annotationClass = ClassUtils.forName(ANNOTATION_CLASS_NAME, AspectJAdviceParameterNameDiscoverer.class.getClassLoader()); } catch (ClassNotFoundException ex) { // Running on < JDK 1.5, this is OK... annotationClass = null; } } private boolean raiseExceptions; /** * If the advice is afterReturning, and binds the return value, this is the parameter name used. */ private String returningName; /** * If the advice is afterThrowing, and binds the thrown value, this is the parameter name used. */ private String throwingName; /** * The pointcut expression associated with the advice, as a simple String. */ private String pointcutExpression; private Class[] argumentTypes; private String[] parameterNameBindings; private int numberOfRemainingUnboundArguments; private int algorithmicStep = STEP_JOIN_POINT_BINDING; /** * Create a new discoverer that attempts to discover parameter names * from the given pointcut expression. */ public AspectJAdviceParameterNameDiscoverer(String pointcutExpression) { this.pointcutExpression = pointcutExpression; } /** * Indicate whether {@link IllegalArgumentException} and {@link AmbiguousBindingException} * must be thrown as appropriate in the case of failing to deduce advice parameter names. * @param raiseExceptions <code>true</code> if exceptions are to be thrown */ public void setRaiseExceptions(boolean raiseExceptions) { this.raiseExceptions = raiseExceptions; } /** * If <code>afterReturning</code> advice binds the return value, the * returning variable name must be specified. * @param returningName the name of the returning variable */ public void setReturningName(String returningName) { this.returningName = returningName; } /** * If <code>afterThrowing</code> advice binds the thrown value, the * throwing variable name must be specified. * @param throwingName the name of the throwing variable */ public void setThrowingName(String throwingName) { this.throwingName = throwingName; } /** * Deduce the parameter names for an advice method. * <p>See the {@link AspectJAdviceParameterNameDiscoverer class level javadoc} * for this class for details of the algorithm used. * @param method the target {@link Method} * @return the parameter names */ public String[] getParameterNames(Method method) { this.argumentTypes = method.getParameterTypes(); this.numberOfRemainingUnboundArguments = this.argumentTypes.length; this.parameterNameBindings = new String[this.numberOfRemainingUnboundArguments]; this.algorithmicStep = STEP_JOIN_POINT_BINDING; int minimumNumberUnboundArgs = 0; if (this.returningName != null) { minimumNumberUnboundArgs++; } if (this.throwingName != null) { minimumNumberUnboundArgs++; } if (this.numberOfRemainingUnboundArguments < minimumNumberUnboundArgs) { throw new IllegalStateException( "Not enough arguments in method to satisfy binding of returning and throwing variables"); } try { while ((this.numberOfRemainingUnboundArguments > 0) && (this.algorithmicStep < STEP_FINISHED)) { switch (this.algorithmicStep++) { case STEP_JOIN_POINT_BINDING: if (!maybeBindThisJoinPoint()) { maybeBindThisJoinPointStaticPart(); } break; case STEP_THROWING_BINDING: maybeBindThrowingVariable(); break; case STEP_ANNOTATION_BINDING: maybeBindAnnotationsFromPointcutExpression(); break; case STEP_RETURNING_BINDING: maybeBindReturningVariable(); break; case STEP_PRIMITIVE_ARGS_BINDING: maybeBindPrimitiveArgsFromPointcutExpression(); break; case STEP_THIS_TARGET_ARGS_BINDING: maybeBindThisOrTargetOrArgsFromPointcutExpression(); break; case STEP_REFERENCE_PCUT_BINDING: maybeBindReferencePointcutParameter(); break; default: throw new IllegalStateException("Unknown algorithmic step: " + (this.algorithmicStep - 1)); } } } catch (AmbiguousBindingException ambigEx) { if (this.raiseExceptions) { throw ambigEx; } else { return null; } } catch (IllegalArgumentException ex) { if (this.raiseExceptions) { throw ex; } else { return null; } } if (this.numberOfRemainingUnboundArguments == 0) { return this.parameterNameBindings; } else { if (this.raiseExceptions) { throw new IllegalStateException("Failed to bind all argument names: " + this.numberOfRemainingUnboundArguments + " argument(s) could not be bound"); } else { // convention for failing is to return null, allowing participation in a chain of responsibility return null; } } } /** * An advice method can never be a constructor in Spring. * @return <code>null</code> * @throws UnsupportedOperationException if * {@link #setRaiseExceptions(boolean) raiseExceptions} has been set to <code>true</code> */ public String[] getParameterNames(Constructor ctor) { if (this.raiseExceptions) { throw new UnsupportedOperationException("An advice method can never be a constructor"); } else { // we return null rather than throw an exception so that we behave well // in a chain-of-responsibility. return null; } } private void bindParameterName(int index, String name) { this.parameterNameBindings[index] = name; this.numberOfRemainingUnboundArguments--; } /** * If the first parameter is of type JoinPoint or ProceedingJoinPoint,bind "thisJoinPoint" as * parameter name and return true, else return false. */ private boolean maybeBindThisJoinPoint() { if ((this.argumentTypes[0] == JoinPoint.class) || (this.argumentTypes[0] == ProceedingJoinPoint.class)) { bindParameterName(0, THIS_JOIN_POINT); return true; } else { return false; } } private void maybeBindThisJoinPointStaticPart() { if (this.argumentTypes[0] == JoinPoint.StaticPart.class) { bindParameterName(0, THIS_JOIN_POINT_STATIC_PART); } } /** * If a throwing name was specified and there is exactly one choice remaining * (argument that is a subtype of Throwable) then bind it. */ private void maybeBindThrowingVariable() { if (this.throwingName == null) { return; } // So there is binding work to do... int throwableIndex = -1; for (int i = 0; i < this.argumentTypes.length; i++) { if (isUnbound(i) && isSubtypeOf(Throwable.class, i)) { if (throwableIndex == -1) { throwableIndex = i; } else { // Second candidate we've found - ambiguous binding throw new AmbiguousBindingException("Binding of throwing parameter '" + this.throwingName + "' is ambiguous: could be bound to argument " + throwableIndex + " or argument " + i); } } } if (throwableIndex == -1) { throw new IllegalStateException("Binding of throwing parameter '" + this.throwingName + "' could not be completed as no available arguments are a subtype of Throwable"); } else { bindParameterName(throwableIndex, this.throwingName); } } /** * If a returning variable was specified and there is only one choice remaining, bind it. */ private void maybeBindReturningVariable() { if (this.numberOfRemainingUnboundArguments == 0) { throw new IllegalStateException( "Algorithm assumes that there must be at least one unbound parameter on entry to this method"); } if (this.returningName != null) { if (this.numberOfRemainingUnboundArguments > 1) { throw new AmbiguousBindingException("Binding of returning parameter '" + this.returningName + "' is ambiguous, there are " + this.numberOfRemainingUnboundArguments + " candidates."); } // We're all set... find the unbound parameter, and bind it. for (int i = 0; i < this.parameterNameBindings.length; i++) { if (this.parameterNameBindings[i] == null) { bindParameterName(i, this.returningName); break; } } } } /** * Parse the string pointcut expression looking for: * &#64;this, &#64;target, &#64;args, &#64;within, &#64;withincode, &#64;annotation. * If we find one of these pointcut expressions, try and extract a candidate variable * name (or variable names, in the case of args). * <p>Some more support from AspectJ in doing this exercise would be nice... :) */ private void maybeBindAnnotationsFromPointcutExpression() { List varNames = new ArrayList(); String[] tokens = StringUtils.tokenizeToStringArray(this.pointcutExpression, " "); for (int i = 0; i < tokens.length; i++) { String toMatch = tokens[i]; int firstParenIndex = toMatch.indexOf("("); if (firstParenIndex != -1) { toMatch = toMatch.substring(0, firstParenIndex); } if (singleValuedAnnotationPcds.contains(toMatch)) { PointcutBody body = getPointcutBody(tokens, i); i += body.numTokensConsumed; String varName = maybeExtractVariableName(body.text); if (varName != null) { varNames.add(varName); } } else if (tokens[i].startsWith("@args(") || tokens[i].equals("@args")) { PointcutBody body = getPointcutBody(tokens, i); i += body.numTokensConsumed; maybeExtractVariableNamesFromArgs(body.text, varNames); } } bindAnnotationsFromVarNames(varNames); } /** * Match the given list of extracted variable names to argument slots. */ private void bindAnnotationsFromVarNames(List varNames) { if (!varNames.isEmpty()) { // we have work to do... int numAnnotationSlots = countNumberOfUnboundAnnotationArguments(); if (numAnnotationSlots > 1) { throw new AmbiguousBindingException("Found " + varNames.size() + " potential annotation variable(s), and " + numAnnotationSlots + " potential argument slots"); } else if (numAnnotationSlots == 1) { if (varNames.size() == 1) { // it's a match findAndBind(annotationClass, (String) varNames.get(0)); } else { // multiple candidate vars, but only one slot throw new IllegalArgumentException("Found " + varNames.size() + " candidate annotation binding variables" + " but only one potential argument binding slot"); } } else { // no slots so presume those candidate vars were actually type names } } } /* * If the token starts meets Java identifier conventions, it's in. */ private String maybeExtractVariableName(String candidateToken) { if (candidateToken == null || candidateToken.equals("")) { return null; } if (Character.isJavaIdentifierStart(candidateToken.charAt(0)) && Character.isLowerCase(candidateToken.charAt(0))) { char[] tokenChars = candidateToken.toCharArray(); for (int i = 0; i < tokenChars.length; i++) { if (!Character.isJavaIdentifierPart(tokenChars[i])) { return null; } } return candidateToken; } else { return null; } } /** * Given an args pointcut body (could be <code>args</code> or <code>at_args</code>), * add any candidate variable names to the given list. */ private void maybeExtractVariableNamesFromArgs(String argsSpec, List varNames) { if (argsSpec == null) { return; } String[] tokens = StringUtils.tokenizeToStringArray(argsSpec, ","); for (int i = 0; i < tokens.length; i++) { tokens[i] = StringUtils.trimWhitespace(tokens[i]); String varName = maybeExtractVariableName(tokens[i]); if (varName != null) { varNames.add(varName); } } } /** * Parse the string pointcut expression looking for this(), target() and args() expressions. * If we find one, try and extract a candidate variable name and bind it. */ private void maybeBindThisOrTargetOrArgsFromPointcutExpression() { if (this.numberOfRemainingUnboundArguments > 1) { throw new AmbiguousBindingException("Still " + this.numberOfRemainingUnboundArguments + " unbound args at this(),target(),args() binding stage, with no way to determine between them"); } List varNames = new ArrayList(); String[] tokens = StringUtils.tokenizeToStringArray(this.pointcutExpression, " "); for (int i = 0; i < tokens.length; i++) { if (tokens[i].equals("this") || tokens[i].startsWith("this(") || tokens[i].equals("target") || tokens[i].startsWith("target(")) { PointcutBody body = getPointcutBody(tokens, i); i += body.numTokensConsumed; String varName = maybeExtractVariableName(body.text); if (varName != null) { varNames.add(varName); } } else if (tokens[i].equals("args") || tokens[i].startsWith("args(")) { PointcutBody body = getPointcutBody(tokens, i); i += body.numTokensConsumed; List candidateVarNames = new ArrayList(); maybeExtractVariableNamesFromArgs(body.text, candidateVarNames); // we may have found some var names that were bound in previous primitive args binding step, // filter them out... for (Iterator iter = candidateVarNames.iterator(); iter.hasNext();) { String varName = (String) iter.next(); if (!alreadyBound(varName)) { varNames.add(varName); } } } } if (varNames.size() > 1) { throw new AmbiguousBindingException("Found " + varNames.size() + " candidate this(), target() or args() variables but only one unbound argument slot"); } else if (varNames.size() == 1) { for (int j = 0; j < this.parameterNameBindings.length; j++) { if (isUnbound(j)) { bindParameterName(j, (String) varNames.get(0)); break; } } } // else varNames.size must be 0 and we have nothing to bind. } private void maybeBindReferencePointcutParameter() { if (this.numberOfRemainingUnboundArguments > 1) { throw new AmbiguousBindingException("Still " + this.numberOfRemainingUnboundArguments + " unbound args at reference pointcut binding stage, with no way to determine between them"); } List varNames = new ArrayList(); String[] tokens = StringUtils.tokenizeToStringArray(this.pointcutExpression, " "); for (int i = 0; i < tokens.length; i++) { String toMatch = tokens[i]; if (toMatch.startsWith("!")) { toMatch = toMatch.substring(1); } int firstParenIndex = toMatch.indexOf("("); if (firstParenIndex != -1) { toMatch = toMatch.substring(0, firstParenIndex); } else { if (tokens.length < i + 2) { // no "(" and nothing following continue; } else { String nextToken = tokens[i + 1]; if (nextToken.charAt(0) != '(') { // next token is not "(" either, can't be a pc... continue; } } } // eat the body PointcutBody body = getPointcutBody(tokens, i); i += body.numTokensConsumed; if (!nonReferencePointcutTokens.contains(toMatch)) { // then it could be a reference pointcut String varName = maybeExtractVariableName(body.text); if (varName != null) { varNames.add(varName); } } } if (varNames.size() > 1) { throw new AmbiguousBindingException("Found " + varNames.size() + " candidate reference pointcut variables but only one unbound argument slot"); } else if (varNames.size() == 1) { for (int j = 0; j < this.parameterNameBindings.length; j++) { if (isUnbound(j)) { bindParameterName(j, (String) varNames.get(0)); break; } } } // else varNames.size must be 0 and we have nothing to bind. } /* * We've found the start of a binding pointcut at the given index into the * token array. Now we need to extract the pointcut body and return it. */ private PointcutBody getPointcutBody(String[] tokens, int startIndex) { int numTokensConsumed = 0; String currentToken = tokens[startIndex]; int bodyStart = currentToken.indexOf('('); if (currentToken.charAt(currentToken.length() - 1) == ')') { // It's an all in one... get the text between the first (and the last) return new PointcutBody(0, currentToken.substring(bodyStart + 1, currentToken.length() - 1)); } else { StringBuffer sb = new StringBuffer(); if (bodyStart >= 0 && bodyStart != (currentToken.length() - 1)) { sb.append(currentToken.substring(bodyStart + 1)); sb.append(" "); } numTokensConsumed++; int currentIndex = startIndex + numTokensConsumed; while (currentIndex < tokens.length) { if (tokens[currentIndex].equals("(")) { currentIndex++; continue; } if (tokens[currentIndex].endsWith(")")) { sb.append(tokens[currentIndex].substring(0, tokens[currentIndex].length() - 1)); return new PointcutBody(numTokensConsumed, sb.toString().trim()); } String toAppend = tokens[currentIndex]; if (toAppend.startsWith("(")) { toAppend = toAppend.substring(1); } sb.append(toAppend); sb.append(" "); currentIndex++; numTokensConsumed++; } } // We looked and failed... return new PointcutBody(numTokensConsumed, null); } /** * Match up args against unbound arguments of primitive types */ private void maybeBindPrimitiveArgsFromPointcutExpression() { int numUnboundPrimitives = countNumberOfUnboundPrimitiveArguments(); if (numUnboundPrimitives > 1) { throw new AmbiguousBindingException("Found '" + numUnboundPrimitives + "' unbound primitive arguments with no way to distinguish between them."); } if (numUnboundPrimitives == 1) { // Look for arg variable and bind it if we find exactly one... List varNames = new ArrayList(); String[] tokens = StringUtils.tokenizeToStringArray(this.pointcutExpression, " "); for (int i = 0; i < tokens.length; i++) { if (tokens[i].equals("args") || tokens[i].startsWith("args(")) { PointcutBody body = getPointcutBody(tokens, i); i += body.numTokensConsumed; maybeExtractVariableNamesFromArgs(body.text, varNames); } } if (varNames.size() > 1) { throw new AmbiguousBindingException("Found " + varNames.size() + " candidate variable names but only one candidate binding slot when matching primitive args"); } else if (varNames.size() == 1) { // 1 primitive arg, and one candidate... for (int i = 0; i < this.argumentTypes.length; i++) { if (isUnbound(i) && this.argumentTypes[i].isPrimitive()) { bindParameterName(i, (String) varNames.get(0)); break; } } } } } /* * Return true if the parameter name binding for the given parameter * index has not yet been assigned. */ private boolean isUnbound(int i) { return this.parameterNameBindings[i] == null; } private boolean alreadyBound(String varName) { for (int i = 0; i < this.parameterNameBindings.length; i++) { if (!isUnbound(i) && varName.equals(this.parameterNameBindings[i])) { return true; } } return false; } /* * Return <code>true</code> if the given argument type is a subclass * of the given supertype. */ private boolean isSubtypeOf(Class supertype, int argumentNumber) { return supertype.isAssignableFrom(this.argumentTypes[argumentNumber]); } private int countNumberOfUnboundAnnotationArguments() { if (annotationClass == null) { // We're running on a JDK < 1.5 return 0; } int count = 0; for (int i = 0; i < this.argumentTypes.length; i++) { if (isUnbound(i) && isSubtypeOf(annotationClass, i)) { count++; } } return count; } private int countNumberOfUnboundPrimitiveArguments() { int count = 0; for (int i = 0; i < this.argumentTypes.length; i++) { if (isUnbound(i) && this.argumentTypes[i].isPrimitive()) { count++; } } return count; } /* * Find the argument index with the given type, and bind the given * <code>varName</code> in that position. */ private void findAndBind(Class argumentType, String varName) { for (int i = 0; i < this.argumentTypes.length; i++) { if (isUnbound(i) && isSubtypeOf(argumentType, i)) { bindParameterName(i, varName); return; } } throw new IllegalStateException("Expected to find an unbound argument of type '" + argumentType.getName() + "'"); } /** * Simple struct to hold the extracted text from a pointcut body, together * with the number of tokens consumed in extracting it. */ private static class PointcutBody { private int numTokensConsumed; private String text; public PointcutBody(int tokens, String text) { this.numTokensConsumed = tokens; this.text = text; } } /** * Thrown in response to an ambiguous binding being detected when * trying to resolve a method's parameter names. */ public static class AmbiguousBindingException extends RuntimeException { /** * Construct a new AmbiguousBindingException with the specified message. * @param msg the detail message */ public AmbiguousBindingException(String msg) { super(msg); } } }

The table below shows all metrics for AspectJAdviceParameterNameDiscoverer.java.

MetricValueDescription
BLOCKS132.00Number of blocks
BLOCK_COMMENT34.00Number of block comment lines
COMMENTS227.00Comment lines
COMMENT_DENSITY 0.60Comment density
COMPARISONS109.00Number of comparison operators
CYCLOMATIC138.00Cyclomatic complexity
DECL_COMMENTS28.00Comments in declarations
DOC_COMMENT168.00Number of javadoc comment lines
ELOC381.00Effective lines of code
EXEC_COMMENTS22.00Comments in executable code
EXITS55.00Procedure exits
FUNCTIONS27.00Number of function declarations
HALSTEAD_DIFFICULTY99.87Halstead difficulty
HALSTEAD_EFFORT 0.00Halstead effort
INTERFACE_COMPLEXITY81.00Interface complexity
JAVA0001 0.00JAVA0001 Package name does not contain only lower case letters
JAVA0002 0.00JAVA0002 Package name does not begin with a top level domain name or country code
JAVA0003 0.00JAVA0003 Minimize use of on-demand (.*) imports
JAVA0004 0.00JAVA0004 Unnecessary import from java.lang
JAVA0005 0.00JAVA0005 Imports not in specified order
JAVA0006 0.00JAVA0006 Empty finally block
JAVA0007 0.00JAVA0007 Should not declare public field
JAVA0008 0.00JAVA0008 Empty catch block
JAVA0009 0.00JAVA0009 Protected member in final class
JAVA0010 0.00JAVA0010 Non-instantiable class does not contain a non-private static member
JAVA0011 0.00JAVA0011 Abstract class does not contain an abstract method
JAVA0012 0.00JAVA0012 Non-constructor method with same name as declaring class
JAVA0013 0.00JAVA0013 Non-blank final field is not static
JAVA0014 0.00JAVA0014 Class with only static members has non-private constructor
JAVA0015 0.00JAVA0015 Package class contains public nested type
JAVA0016 0.00JAVA0016 Abstract class contains public constructor
JAVA0017 0.00JAVA0017 Class name does not have required form
JAVA0018 0.00JAVA0018 Method name does not have required form
JAVA0019 0.00JAVA0019 Interface name does not have required form
JAVA0020 0.00JAVA0020 Field name does not have required form
JAVA0021 0.00JAVA0021 Interface method name does not have required form
JAVA0022 0.00JAVA0022 Static final field name does not have required form
JAVA0023 0.00JAVA0023 Empty finalize method
JAVA0024 0.00JAVA0024 Empty class
JAVA0025 0.00JAVA0025 Method override is empty
JAVA0026 0.00JAVA0026 Finalize method with parameters
JAVA0029 0.00JAVA0029 Private method not used
JAVA0030 0.00JAVA0030 Private field not used
JAVA0031 0.00JAVA0031 Case statement not properly closed
JAVA0032 0.00JAVA0032 Switch statement missing default
JAVA0033 0.00JAVA0033 default: not last case in switch statement
JAVA0034 0.00JAVA0034 Missing braces in if statement
JAVA0035 0.00JAVA0035 Missing braces in for statement
JAVA0036 0.00JAVA0036 Missing braces in while statement
JAVA0038 0.00JAVA0038 Non-case label in switch statement
JAVA0039 0.00JAVA0039 Break statement with label
JAVA0040 0.00JAVA0040 Switch statement contains N cases (maximum: M)
JAVA0041 0.00JAVA0041 Nested synchronized block
JAVA0042 0.00JAVA0042 Empty synchronized statement
JAVA0043 0.00JAVA0043 Inner class does not use outer class
JAVA0044 0.00JAVA0044 Serializable class with no instance variables
JAVA0045 0.00JAVA0045 Serializable class with only transient fields
JAVA0046 0.00JAVA0046 Name of class not derived from Exception ends with 'Exception'
JAVA0047 0.00JAVA0047 Serializable class derives from invalid base class
JAVA0048 0.00JAVA0048 Name of class derived from Exception does not end with 'Exception'
JAVA0049 0.00JAVA0049 Nested block at depth N (maximum: M)
JAVA0050 0.00JAVA0050 Class derives from java.lang.Error
JAVA0051 1.00JAVA0051 Class derives from java.lang.RuntimeException
JAVA0052 0.00JAVA0052 Class derives from java.lang.Throwable
JAVA0053 0.00JAVA0053 Unused label
JAVA0054 0.00JAVA0054 Inheritance depth N exceeds maximum M
JAVA0055 0.00JAVA0055 Class should be interface
JAVA0056 0.00JAVA0056 Unnecessary abstract modifier for interface or annotation
JAVA0057 0.00JAVA0057 Unnecessary default constructor
JAVA0058 0.00JAVA0058 Constructor calls super()
JAVA0059 0.00JAVA0059 Method override only calls super()
JAVA0061 0.00JAVA0061 Inaccessible member in anonymous class
JAVA0062 0.00JAVA0062 Public class missing public member or protected constructor
JAVA0063 0.00JAVA0063 Identifier name should not contain '$'
JAVA0064 0.00JAVA0064 N variations of identifier name (maximum: M)
JAVA0065 0.00JAVA0065 Unnecessary final modifier for method in final class
JAVA0066 0.00JAVA0066 Unnecessary modifier for interface nested type
JAVA0067 0.00JAVA0067 Array descriptor on identifier name
JAVA0068 0.00JAVA0068 Modifiers not declared in recommended order
JAVA0071 0.00JAVA0071 Strings compared with ==
JAVA0073 0.00JAVA0073 Integer division in floating-point context
JAVA0074 0.00JAVA0074 Use of Object.notify()
JAVA0075 0.00JAVA0075 Method parameter hides field
JAVA0076 0.00JAVA0076 Use of magic number
JAVA0077 0.00JAVA0077 Private field not used in declaring class
JAVA0078 0.00JAVA0078 Floating point values compared with ==
JAVA0079 0.00JAVA0079 Use of instance to reference static member
JAVA0080 0.00JAVA0080 Import declaration not used
JAVA0081 0.00JAVA0081 Boolean literal in comparison
JAVA0082 0.00JAVA0082 Unnecessary widening cast
JAVA0083 0.00JAVA0083 Unnecessary instanceof test
JAVA0084 0.00JAVA0084 Should use compound assignment operator
JAVA0085 0.00JAVA0085 Use of sun.* class
JAVA0087 0.00JAVA0087 Use of Thread.sleep()
JAVA0089 0.00JAVA0089 Use of restricted package
JAVA0092 0.00JAVA0092 Use of restricted type
JAVA0093 0.00JAVA0093 Redundant assignment
JAVA0094 0.00JAVA0094 Field hides a superclass field
JAVA0095 0.00JAVA0095 Uninitialized private field
JAVA0096 0.00JAVA0096 Field in nested class hides outer field
JAVA0098 0.00JAVA0098 Minimize use of implicit field initializers
JAVA0100 1.00JAVA0100 Class contains N non-final fields (maximum: M)
JAVA0101 0.00JAVA0101 Unnecessary modifier for field in interface
JAVA0102 0.00JAVA0102 Last statement in finalize() not super.finalize()
JAVA0103 0.00JAVA0103 Explicit call to finalize()
JAVA0104 0.00JAVA0104 finalize() only calls super.finalize()
JAVA0105 0.00JAVA0105 Duplicate import declaration
JAVA0106 0.00JAVA0106 Unnecessary import from current package
JAVA0108 4.00JAVA0108 Incorrect javadoc: no @param tag for 'parameter'
JAVA0109 0.00JAVA0109 Incorrect javadoc: no parameter 'parameter'
JAVA0110 1.00JAVA0110 Incorrect javadoc: no @return tag
JAVA0111 0.00JAVA0111 Incorrect javadoc: @return tag for void method
JAVA0112 0.00JAVA0112 Incorrect javadoc: no exception 'exception' in throws
JAVA0113 0.00JAVA0113 Incorrect javadoc: no @author tag
JAVA0114 1.00JAVA0114 Incorrect javadoc: no @version tag
JAVA0115 0.00JAVA0115 Incorrect javadoc: no @throws or @exception tag for 'exception'
JAVA0116 0.00JAVA0116 Missing javadoc: field 'field'
JAVA0117 1.00JAVA0117 Missing javadoc: method 'method'
JAVA0118 0.00JAVA0118 Missing javadoc: type 'type'
JAVA0119 6.00JAVA0119 Control variable changed within body of for loop
JAVA0123 0.00JAVA0123 Use all three components of for loop
JAVA0125 0.00JAVA0125 Continue statement with label
JAVA0126 0.00JAVA0126 Method declares unchecked exception in throws
JAVA0128 1.00JAVA0128 Public constructor in non-public class
JAVA0130 2.00JAVA0130 Non-static method does not use instance fields
JAVA0131 0.00JAVA0131 Compatible method does not override base
JAVA0132 0.00JAVA0132 Method overload with compatible signature
JAVA0133 0.00JAVA0133 Non-synchronized method overrides synchronized method
JAVA0135 0.00JAVA0135 Only one of Object.equals and Object.hashCode defined: missing 'method'
JAVA0136 1.00JAVA0136 N methods defined in class (maximum: M)
JAVA0137 0.00JAVA0137 Non-abstract class missing constructor
JAVA0138 0.00JAVA0138 N parameters defined for method (maximum: M)
JAVA0139 0.00JAVA0139 Definition of main other than public static void main(java.lang.String[])
JAVA0141 0.00JAVA0141 Unnecessary modifier for method in interface
JAVA0143 0.00JAVA0143 Synchronized method
JAVA0144 0.00JAVA0144 Line exceeds maximum M characters
JAVA01451673.00JAVA0145 Tab character used in source file
JAVA0150 0.00JAVA0150 java.lang.Error (or subclass) thrown
JAVA0153 0.00JAVA0153 Inefficient conversion of integer to string
JAVA0159 0.00JAVA0159 Inefficient conversion of string to integer
JAVA0160 0.00JAVA0160 Method does not throw specified exception
JAVA0161 0.00JAVA0161 Conditional wait() not in loop
JAVA0163 0.00JAVA0163 Empty statement
JAVA0165 0.00JAVA0165 Conflicting return statement in finally block
JAVA0166 0.00JAVA0166 Generic exception caught
JAVA0167 0.00JAVA0167 ThreadDeath not rethrown
JAVA0169 0.00JAVA0169 Unnecessary catch block: exception 'exception'
JAVA0170 0.00JAVA0170 Caught exception not derived from java.lang.Exception
JAVA0171 0.00JAVA0171 Unused local variable
JAVA0173 0.00JAVA0173 Unused method parameter
JAVA0174 0.00JAVA0174 Assigned local variable never used
JAVA0175 0.00JAVA0175 Successive assignment to variable
JAVA0176 0.00JAVA0176 Local variable name does not have required form
JAVA0177 0.00JAVA0177 Variable declaration missing initializer
JAVA0179 0.00JAVA0179 Local variable hides visible field
JAVA0233 0.00JAVA0233 Definition of serialVersionUID other than 'private static final long serialVersionUID'
JAVA0234 1.00JAVA0234 Class is Serializable but does not define serialVersionUID
JAVA0235 0.00JAVA0235 Class defines serialVersionUID but does not implement Serializable
JAVA0236 0.00JAVA0236 Attempt to clone an object which does not implement Cloneable
JAVA0237 0.00JAVA0237 Class implements Cloneable but does not have public clone method
JAVA0238 0.00JAVA0238 Clone method does not call super.clone()
JAVA0239 0.00JAVA0239 Class declares 'readObject' or 'writeObject' but does not implement Serializable
JAVA0240 0.00JAVA0240 Serializable class which declares readObject or writeObject but not both
JAVA0241 0.00JAVA0241 'readObject' or 'writeObject' should be declared private in Serializable class
JAVA0242 0.00JAVA0242 Transient field in non-Serializable class
JAVA0243 0.00JAVA0243 'readResolve' or 'writeReplace' should be declared private or protected
JAVA0244 0.00JAVA0244 Field or method name in subclass differs only by case from inherited field or method
JAVA0245 0.00JAVA0245 JUnit TestCase with non-trivial constructor
JAVA0246 0.00JAVA0246 JUnit assertXXX statement missing message parameter
JAVA0247 0.00JAVA0247 JUnit 'setUp()' and 'tearDown()' should call super method
JAVA0248 0.00JAVA0248 JUnit method 'setUp' or 'tearDown' with incorrect signature
JAVA0249 0.00JAVA0249 JUnit TestCase 'suite()' should be declared static
JAVA0250 0.00JAVA0250 JUnit TestCase declares testXXX method with incorrect signature
JAVA0251 0.00JAVA0251 Use '%n' for line breaks in printf/format for platform independence
JAVA0252 0.00JAVA0252 'enum' is a Java 1.5 reserved word
JAVA0253 0.00JAVA0253 Not all enum constants consumed in switch statement
JAVA0254 2.00JAVA0254 Use enhanced for loop construct instead of Iterator
JAVA0255 0.00JAVA0255 Result of method invocation not used
JAVA0256 0.00JAVA0256 Assignment of external collection/array to field
JAVA0257 0.00JAVA0257 Use of 'Constant Interface' anti-pattern
JAVA0258 0.00JAVA0258 Implement Iterable for foreach compatibility
JAVA0259 1.00JAVA0259 Return of collection/array field
JAVA0260 0.00JAVA0260 Use 'enum' instead of Enumerated Type pattern
JAVA0261 0.00JAVA0261 Use specialized Enum collection types
JAVA0262 0.00JAVA0262 Use of char in integer context
JAVA0263 0.00JAVA0263 Long literal ends with 'l' instead of 'L'
JAVA0264 0.00JAVA0264 Integer math in long context - check for overflow
JAVA0265 0.00JAVA0265 Use of Throwable.printStackTrace()
JAVA0266 0.00JAVA0266 Use of System.out
JAVA0267 0.00JAVA0267 Use of System.err
JAVA0269 0.00JAVA0269 Contents of StringBuffer never used
JAVA0270 1.00JAVA0270 Use Java 5.0 enhanced for loop construct to iterate over all elements in an array
JAVA0271 0.00JAVA0271 Minimize use of on-demand (.*) static imports
JAVA0272 0.00JAVA0272 Thread.run() called
JAVA0273 0.00JAVA0273 Non-final derivative of Thread calls start() in constructor
JAVA0274 0.00JAVA0274 Serializable class has a synchronized readObject()
JAVA0275 0.00JAVA0275 Serializable class has a synchronized writeObject() and no other synchronized methods
JAVA0276 0.00JAVA0276 Unnecessary use of String constructor
JAVA0277 0.00JAVA0277 Iterator.next() implementation does not throw NoSuchElementException
JAVA0278 0.00JAVA0278 Unnecessary use of Boolean constructor
JAVA0279 0.00JAVA0279 Serialization method readObject or readObjectNoData calls an overridable method
JAVA0280 0.00JAVA0280 IllegalMonitorStateException caught
JAVA0281 0.00JAVA0281 Iterator.next() not called in loop
JAVA0282 0.00JAVA0282 Call to Iterator.next() in loop which does not test Iterator.hasNext()
JAVA0283 0.00JAVA0283 Control variable not updated in loop body
JAVA0284 0.00JAVA0284 Explicit garbage collection
JAVA0285 0.00JAVA0285 Dereference of potentially null variable
JAVA0286 0.00JAVA0286 Dereference of null variable
JAVA0287 0.00JAVA0287 Unnecessary null check
JAVA0288 0.00JAVA0288 Inconsistent null check
LINES826.00Number of lines in the source file
LINE_COMMENT25.00Number of line comments
LOC517.00Lines of code
LOGICAL_LINES248.00Number of statements
LOOPS19.00Number of loops
NEST_DEPTH 5.00Maximum nesting depth
OPERANDS1013.00Number of operands
OPERATORS2235.00Number of operators
PARAMS23.00Number of formal parameter declarations
PROGRAM_LENGTH3248.00Halstead program length
PROGRAM_VOCAB340.00Halstead program vocabulary
PROGRAM_VOLUME 0.00Halstead program volume
RETURNS58.00Number of return points from functions
SIZE28763.00Size of the file in bytes
UNIQUE_OPERANDS284.00Number of unique operands
UNIQUE_OPERATORS56.00Number of unique operators
WHITESPACE82.00Number of whitespace lines