MethodVerifier.java
| Index Score | ||
|---|---|---|
 |
 |
net.sourceforge.phpdt.internal.compiler.lookup |
 |
 |
PHPeclipse |
View: Reasons, Metrics, Source Code
These are the metrics that contribute to the Enerjy Score for this file, ranked by impact. So the metrics listed at the top influence the score to a greater extent that the metrics listed at the bottom.
| Metric | Description | |
|---|---|---|
| LINE_COMMENT | Number of line comments |  |
| JAVA0034 | JAVA0034 Missing braces in if statement | |
| LOOPS | Number of loops | |
| COMPARISONS | Number of comparison operators | |
| EXEC_COMMENTS | Comments in executable code | |
| JAVA0145 | JAVA0145 Tab character used in source file | |
| CYCLOMATIC | Cyclomatic complexity | |
| JAVA0123 | JAVA0123 Use all three components of for loop | |
| JAVA0036 | JAVA0036 Missing braces in while statement | |
| JAVA0049 | JAVA0049 Nested block at depth N (maximum: M) | |
| JAVA0125 | JAVA0125 Continue statement with label | |
| SIZE | Size of the file in bytes | |
| OPERATORS | Number of operators | |
| JAVA0035 | JAVA0035 Missing braces in for statement | |
| ELOC | Effective lines of code | |
| PROGRAM_LENGTH | Halstead program length | |
| OPERANDS | Number of operands | |
| LOC | Lines of code | |
| EXITS | Procedure exits | |
| LOGICAL_LINES | Number of statements | |
| JAVA0163 | JAVA0163 Empty statement | |
| LINES | Number of lines in the source file | |
| NEST_DEPTH | Maximum nesting depth | |
| JAVA0039 | JAVA0039 Break statement with label | |
| BLOCKS | Number of blocks | |
| COMMENTS | Comment lines | |
| UNIQUE_OPERATORS | Number of unique operators | |
| JAVA0130 | JAVA0130 Non-static method does not use instance fields | |
| PROGRAM_VOCAB | Halstead program vocabulary | |
| UNIQUE_OPERANDS | Number of unique operands | |
| JAVA0119 | JAVA0119 Control variable changed within body of for loop | |
| PROGRAM_VOLUME | Halstead program volume | |
| JAVA0126 | JAVA0126 Method declares unchecked exception in throws | |
| JAVA0110 | JAVA0110 Incorrect javadoc: no @return tag | |
| JAVA0108 | JAVA0108 Incorrect javadoc: no @param tag for 'parameter' | |
| DOC_COMMENT | Number of javadoc comment lines | |
| DECL_COMMENTS | Comments in declarations | |
| JAVA0075 | JAVA0075 Method parameter hides field | |
| WHITESPACE | Number of whitespace lines | |
/*******************************************************************************
* Copyright (c) 2000, 2003 IBM Corporation and others.
* All rights reserved. This program and the accompanying materials
* are made available under the terms of the Common Public License v1.0
* which accompanies this distribution, and is available at
* http://www.eclipse.org/legal/cpl-v10.html
*
* Contributors:
* IBM Corporation - initial API and implementation
*******************************************************************************/
package net.sourceforge.phpdt.internal.compiler.lookup;
import net.sourceforge.phpdt.core.compiler.CharOperation;
import net.sourceforge.phpdt.internal.compiler.ast.MethodDeclaration;
import net.sourceforge.phpdt.internal.compiler.ast.TypeDeclaration;
import net.sourceforge.phpdt.internal.compiler.problem.ProblemReporter;
import net.sourceforge.phpdt.internal.compiler.util.HashtableOfObject;
public final class MethodVerifier implements TagBits, TypeConstants {
SourceTypeBinding type;
HashtableOfObject inheritedMethods;
HashtableOfObject currentMethods;
ReferenceBinding runtimeException;
ReferenceBinding errorException;
LookupEnvironment environment;
/*
* Binding creation is responsible for reporting all problems with types: -
* all modifier problems (duplicates & multiple visibility modifiers +
* incompatible combinations - abstract/final) - plus invalid modifiers
* given the context (the verifier did not do this before) - qualified name
* collisions between a type and a package (types in default packages are
* excluded) - all type hierarchy problems: - cycles in the superclass or
* superinterface hierarchy - an ambiguous, invisible or missing superclass
* or superinterface - extending a final class - extending an interface
* instead of a class - implementing a class instead of an interface -
* implementing the same interface more than once (ie. duplicate interfaces) -
* with nested types: - shadowing an enclosing type's source name - defining
* a static class or interface inside a non-static nested class - defining
* an interface as a local type (local types can only be classes)
*/
public MethodVerifier(LookupEnvironment environment) {
this.type = null; // Initialized with the public method
// verify(SourceTypeBinding)
this.inheritedMethods = null;
this.currentMethods = null;
this.runtimeException = null;
this.errorException = null;
this.environment = environment;
}
private void checkAgainstInheritedMethods(MethodBinding currentMethod,
MethodBinding[] methods, int length) {
currentMethod.modifiers |= CompilerModifiers.AccOverriding;
for (int i = length; --i >= 0;) {
MethodBinding inheritedMethod = methods[i];
if (!currentMethod.isAbstract() && inheritedMethod.isAbstract())
currentMethod.modifiers |= CompilerModifiers.AccImplementing;
if (currentMethod.returnType != inheritedMethod.returnType) {
this.problemReporter(currentMethod).incompatibleReturnType(
currentMethod, inheritedMethod);
} else if (currentMethod.isStatic() != inheritedMethod.isStatic()) { // Cannot
// override
// a
// static
// method
// or
// hide
// an
// instance
// method
this.problemReporter(currentMethod).staticAndInstanceConflict(
currentMethod, inheritedMethod);
} else {
if (currentMethod.thrownExceptions != NoExceptions)
this.checkExceptions(currentMethod, inheritedMethod);
if (inheritedMethod.isFinal())
this.problemReporter(currentMethod)
.finalMethodCannotBeOverridden(currentMethod,
inheritedMethod);
if (!this.isAsVisible(currentMethod, inheritedMethod))
this.problemReporter(currentMethod).visibilityConflict(
currentMethod, inheritedMethod);
// if (inheritedMethod.isViewedAsDeprecated())
// if (!currentMethod.isViewedAsDeprecated() ||
// environment.options.reportDeprecationInsideDeprecatedCode)
// this.problemReporter(currentMethod).overridesDeprecatedMethod(currentMethod,
// inheritedMethod);
}
}
}
/*
* "8.4.4" Verify that newExceptions are all included in
* inheritedExceptions. Assumes all exceptions are valid and throwable.
* Unchecked exceptions (compatible with runtime & error) are ignored (see
* the spec on pg. 203).
*/
private void checkExceptions(MethodBinding newMethod,
MethodBinding inheritedMethod) {
ReferenceBinding[] newExceptions = newMethod.thrownExceptions;
ReferenceBinding[] inheritedExceptions = inheritedMethod.thrownExceptions;
for (int i = newExceptions.length; --i >= 0;) {
ReferenceBinding newException = newExceptions[i];
int j = inheritedExceptions.length;
while (--j > -1
&& !this.isSameClassOrSubclassOf(newException,
inheritedExceptions[j]))
;
if (j == -1)
if (!(newException.isCompatibleWith(this.runtimeException()) || newException
.isCompatibleWith(this.errorException())))
this.problemReporter(newMethod)
.incompatibleExceptionInThrowsClause(this.type,
newMethod, inheritedMethod, newException);
}
}
private void checkInheritedMethods(MethodBinding[] methods, int length) {
TypeBinding returnType = methods[0].returnType;
int index = length;
while (--index > 0 && returnType == methods[index].returnType)
;
if (index > 0) { // All inherited methods do NOT have the same
// vmSignature
this.problemReporter().inheritedMethodsHaveIncompatibleReturnTypes(
this.type, methods, length);
return;
}
MethodBinding concreteMethod = null;
if (!type.isInterface()) { // ignore concrete methods for interfaces
for (int i = length; --i >= 0;) { // Remember that only one of the
// methods can be non-abstract
if (!methods[i].isAbstract()) {
concreteMethod = methods[i];
break;
}
}
}
if (concreteMethod == null) {
if (this.type.isClass() && !this.type.isAbstract()) {
for (int i = length; --i >= 0;)
if (!mustImplementAbstractMethod(methods[i]))
return; // have already reported problem against the
// concrete superclass
TypeDeclaration typeDeclaration = this.type.scope.referenceContext;
if (typeDeclaration != null) {
MethodDeclaration missingAbstractMethod = typeDeclaration
.addMissingAbstractMethodFor(methods[0]);
missingAbstractMethod.scope.problemReporter()
.abstractMethodMustBeImplemented(this.type,
methods[0]);
} else {
this.problemReporter().abstractMethodMustBeImplemented(
this.type, methods[0]);
}
}
return;
}
MethodBinding[] abstractMethods = new MethodBinding[length - 1];
index = 0;
for (int i = length; --i >= 0;)
if (methods[i] != concreteMethod)
abstractMethods[index++] = methods[i];
// Remember that interfaces can only define public instance methods
if (concreteMethod.isStatic())
// Cannot inherit a static method which is specified as an instance
// method by an interface
this.problemReporter().staticInheritedMethodConflicts(type,
concreteMethod, abstractMethods);
if (!concreteMethod.isPublic())
// Cannot reduce visibility of a public method specified by an
// interface
this.problemReporter().inheritedMethodReducesVisibility(type,
concreteMethod, abstractMethods);
if (concreteMethod.thrownExceptions != NoExceptions)
for (int i = abstractMethods.length; --i >= 0;)
this.checkExceptions(concreteMethod, abstractMethods[i]);
}
/*
* For each inherited method identifier (message pattern - vm signature
* minus the return type) if current method exists if current's vm signature
* does not match an inherited signature then complain else compare
* current's exceptions & visibility against each inherited method else if
* inherited methods = 1 if inherited is abstract && type is NOT an
* interface or abstract, complain else if vm signatures do not match
* complain else find the concrete implementation amongst the abstract
* methods (can only be 1) if one exists then it must be a public instance
* method compare concrete's exceptions against each abstract method else
* complain about missing implementation only if type is NOT an interface or
* abstract
*/
private void checkMethods() {
boolean mustImplementAbstractMethods = this.type.isClass()
&& !this.type.isAbstract();
char[][] methodSelectors = this.inheritedMethods.keyTable;
for (int s = methodSelectors.length; --s >= 0;) {
if (methodSelectors[s] != null) {
MethodBinding[] current = (MethodBinding[]) this.currentMethods
.get(methodSelectors[s]);
MethodBinding[] inherited = (MethodBinding[]) this.inheritedMethods.valueTable[s];
int index = -1;
MethodBinding[] matchingInherited = new MethodBinding[inherited.length];
if (current != null) {
for (int i = 0, length1 = current.length; i < length1; i++) {
while (index >= 0)
matchingInherited[index--] = null; // clear the
// previous
// contents of
// the matching
// methods
MethodBinding currentMethod = current[i];
for (int j = 0, length2 = inherited.length; j < length2; j++) {
if (inherited[j] != null
&& currentMethod
.areParametersEqual(inherited[j])) {
matchingInherited[++index] = inherited[j];
inherited[j] = null; // do not want to find
// it again
}
}
if (index >= 0)
this.checkAgainstInheritedMethods(currentMethod,
matchingInherited, index + 1); // pass in
// the
// length of
// matching
}
}
for (int i = 0, length = inherited.length; i < length; i++) {
while (index >= 0)
matchingInherited[index--] = null; // clear the
// previous contents
// of the matching
// methods
if (inherited[i] != null) {
matchingInherited[++index] = inherited[i];
for (int j = i + 1; j < length; j++) {
if (inherited[j] != null
&& inherited[i]
.areParametersEqual(inherited[j])) {
matchingInherited[++index] = inherited[j];
inherited[j] = null; // do not want to find
// it again
}
}
}
if (index > 0) {
this
.checkInheritedMethods(matchingInherited,
index + 1); // pass in the length of
// matching
} else if (mustImplementAbstractMethods && index == 0
&& matchingInherited[0].isAbstract()) {
if (mustImplementAbstractMethod(matchingInherited[0])) {
TypeDeclaration typeDeclaration = this.type.scope.referenceContext;
if (typeDeclaration != null) {
MethodDeclaration missingAbstractMethod = typeDeclaration
.addMissingAbstractMethodFor(matchingInherited[0]);
missingAbstractMethod.scope
.problemReporter()
.abstractMethodMustBeImplemented(
this.type, matchingInherited[0]);
} else {
this
.problemReporter()
.abstractMethodMustBeImplemented(
this.type, matchingInherited[0]);
}
}
}
}
}
}
}
private void checkPackagePrivateAbstractMethod(MethodBinding abstractMethod) {
ReferenceBinding superType = this.type.superclass();
char[] selector = abstractMethod.selector;
do {
if (!superType.isValidBinding())
return;
if (!superType.isAbstract())
return; // closer non abstract super type will be flagged
// instead
MethodBinding[] methods = superType.getMethods(selector);
nextMethod: for (int m = methods.length; --m >= 0;) {
MethodBinding method = methods[m];
if (method.returnType != abstractMethod.returnType
|| !method.areParametersEqual(abstractMethod))
continue nextMethod;
if (method.isPrivate() || method.isConstructor()
|| method.isDefaultAbstract())
continue nextMethod;
if (superType.fPackage == abstractMethod.declaringClass.fPackage)
return; // found concrete implementation of abstract method
// in same package
}
} while ((superType = superType.superclass()) != abstractMethod.declaringClass);
// non visible abstract methods cannot be overridden so the type must be
// defined abstract
this.problemReporter().abstractMethodCannotBeOverridden(this.type,
abstractMethod);
}
/*
* Binding creation is responsible for reporting: - all modifier problems
* (duplicates & multiple visibility modifiers + incompatible combinations) -
* plus invalid modifiers given the context... examples: - interface methods
* can only be public - abstract methods can only be defined by abstract
* classes - collisions... 2 methods with identical vmSelectors - multiple
* methods with the same message pattern but different return types -
* ambiguous, invisible or missing return/argument/exception types - check
* the type of any array is not void - check that each exception type is
* Throwable or a subclass of it
*/
private void computeInheritedMethods() {
this.inheritedMethods = new HashtableOfObject(51); // maps method
// selectors to an
// array of
// methods... must
// search to match
// paramaters &
// return type
ReferenceBinding[][] interfacesToVisit = new ReferenceBinding[5][];
int lastPosition = 0;
interfacesToVisit[lastPosition] = type.superInterfaces();
ReferenceBinding superType = this.type.isClass() ? this.type
.superclass() : this.type.scope.getJavaLangObject(); // check
// interface
// methods
// against
// Object
MethodBinding[] nonVisibleDefaultMethods = null;
int nonVisibleCount = 0;
while (superType != null) {
if (superType.isValidBinding()) {
ReferenceBinding[] itsInterfaces = superType.superInterfaces();
if (itsInterfaces != NoSuperInterfaces) {
if (++lastPosition == interfacesToVisit.length)
System
.arraycopy(
interfacesToVisit,
0,
interfacesToVisit = new ReferenceBinding[lastPosition * 2][],
0, lastPosition);
interfacesToVisit[lastPosition] = itsInterfaces;
}
MethodBinding[] methods = superType.methods();
nextMethod: for (int m = methods.length; --m >= 0;) {
MethodBinding method = methods[m];
if (!(method.isPrivate() || method.isConstructor() || method
.isDefaultAbstract())) { // look at all methods
// which are NOT private
// or constructors or
// default abstract
MethodBinding[] existingMethods = (MethodBinding[]) this.inheritedMethods
.get(method.selector);
if (existingMethods != null) {
for (int i = 0, length = existingMethods.length; i < length; i++) {
if (method.returnType == existingMethods[i].returnType
&& method
.areParametersEqual(existingMethods[i])) {
if (method.isDefault()
&& method.isAbstract()
&& method.declaringClass.fPackage != type.fPackage)
checkPackagePrivateAbstractMethod(method);
continue nextMethod;
}
}
}
if (nonVisibleDefaultMethods != null)
for (int i = 0; i < nonVisibleCount; i++)
if (method.returnType == nonVisibleDefaultMethods[i].returnType
&& CharOperation
.equals(
method.selector,
nonVisibleDefaultMethods[i].selector)
&& method
.areParametersEqual(nonVisibleDefaultMethods[i]))
continue nextMethod;
if (!(method.isDefault() && method.declaringClass.fPackage != type.fPackage)) { // ignore
// methods
// which
// have
// default
// visibility
// and
// are
// NOT
// defined
// in
// another
// package
if (existingMethods == null)
existingMethods = new MethodBinding[1];
else
System
.arraycopy(
existingMethods,
0,
(existingMethods = new MethodBinding[existingMethods.length + 1]),
0, existingMethods.length - 1);
existingMethods[existingMethods.length - 1] = method;
this.inheritedMethods.put(method.selector,
existingMethods);
} else {
if (nonVisibleDefaultMethods == null)
nonVisibleDefaultMethods = new MethodBinding[10];
else if (nonVisibleCount == nonVisibleDefaultMethods.length)
System
.arraycopy(
nonVisibleDefaultMethods,
0,
(nonVisibleDefaultMethods = new MethodBinding[nonVisibleCount * 2]),
0, nonVisibleCount);
nonVisibleDefaultMethods[nonVisibleCount++] = method;
if (method.isAbstract() && !this.type.isAbstract()) // non
// visible
// abstract
// methods
// cannot
// be
// overridden
// so
// the
// type
// must
// be
// defined
// abstract
this.problemReporter()
.abstractMethodCannotBeOverridden(
this.type, method);
MethodBinding[] current = (MethodBinding[]) this.currentMethods
.get(method.selector);
if (current != null) { // non visible methods
// cannot be overridden so a
// warning is issued
foundMatch: for (int i = 0, length = current.length; i < length; i++) {
if (method.returnType == current[i].returnType
&& method
.areParametersEqual(current[i])) {
this.problemReporter()
.overridesPackageDefaultMethod(
current[i], method);
break foundMatch;
}
}
}
}
}
}
superType = superType.superclass();
}
}
for (int i = 0; i <= lastPosition; i++) {
ReferenceBinding[] interfaces = interfacesToVisit[i];
if (interfaces == null) {
interfaces = new ReferenceBinding[0];
}
for (int j = 0, length = interfaces.length; j < length; j++) {
superType = interfaces[j];
if ((superType.tagBits & InterfaceVisited) == 0) {
superType.tagBits |= InterfaceVisited;
if (superType.isValidBinding()) {
ReferenceBinding[] itsInterfaces = superType
.superInterfaces();
if (itsInterfaces != NoSuperInterfaces) {
if (++lastPosition == interfacesToVisit.length)
System
.arraycopy(
interfacesToVisit,
0,
interfacesToVisit = new ReferenceBinding[lastPosition * 2][],
0, lastPosition);
interfacesToVisit[lastPosition] = itsInterfaces;
}
MethodBinding[] methods = superType.methods();
for (int m = methods.length; --m >= 0;) { // Interface
// methods
// are all
// abstract
// public
MethodBinding method = methods[m];
MethodBinding[] existingMethods = (MethodBinding[]) this.inheritedMethods
.get(method.selector);
if (existingMethods == null)
existingMethods = new MethodBinding[1];
else
System
.arraycopy(
existingMethods,
0,
(existingMethods = new MethodBinding[existingMethods.length + 1]),
0, existingMethods.length - 1);
existingMethods[existingMethods.length - 1] = method;
this.inheritedMethods.put(method.selector,
existingMethods);
}
}
}
}
}
// bit reinitialization
for (int i = 0; i <= lastPosition; i++) {
ReferenceBinding[] interfaces = interfacesToVisit[i];
if (interfaces == null) {
interfaces = new ReferenceBinding[0];
}
for (int j = 0, length = interfaces.length; j < length; j++)
interfaces[j].tagBits &= ~InterfaceVisited;
}
}
private void computeMethods() {
MethodBinding[] methods = type.methods();
if (methods == null) {
methods = new MethodBinding[0];
}
int size = methods.length;
this.currentMethods = new HashtableOfObject(size == 0 ? 1 : size); // maps
// method
// selectors
// to
// an
// array
// of
// methods...
// must
// search
// to
// match
// paramaters
// &
// return
// type
for (int m = size; --m >= 0;) {
MethodBinding method = methods[m];
if (!(method.isConstructor() || method.isDefaultAbstract())) { // keep
// all
// methods
// which
// are
// NOT
// constructors
// or
// default
// abstract
MethodBinding[] existingMethods = (MethodBinding[]) this.currentMethods
.get(method.selector);
if (existingMethods == null)
existingMethods = new MethodBinding[1];
else
System
.arraycopy(
existingMethods,
0,
(existingMethods = new MethodBinding[existingMethods.length + 1]),
0, existingMethods.length - 1);
existingMethods[existingMethods.length - 1] = method;
this.currentMethods.put(method.selector, existingMethods);
}
}
}
private ReferenceBinding errorException() {
if (errorException == null)
this.errorException = this.type.scope.getJavaLangError();
return errorException;
}
private boolean isAsVisible(MethodBinding newMethod,
MethodBinding inheritedMethod) {
if (inheritedMethod.modifiers == newMethod.modifiers)
return true;
if (newMethod.isPublic())
return true; // Covers everything
if (inheritedMethod.isPublic())
return false;
if (newMethod.isProtected())
return true;
if (inheritedMethod.isProtected())
return false;
return !newMethod.isPrivate(); // The inheritedMethod cannot be private
// since it would not be visible
}
private boolean isSameClassOrSubclassOf(ReferenceBinding testClass,
ReferenceBinding superclass) {
do {
if (testClass == superclass)
return true;
} while ((testClass = testClass.superclass()) != null);
return false;
}
private boolean mustImplementAbstractMethod(MethodBinding abstractMethod) {
// if the type's superclass is an abstract class, then all abstract
// methods must be implemented
// otherwise, skip it if the type's superclass must implement any of the
// inherited methods
ReferenceBinding superclass = this.type.superclass();
ReferenceBinding declaringClass = abstractMethod.declaringClass;
if (declaringClass.isClass()) {
while (superclass.isAbstract() && superclass != declaringClass)
superclass = superclass.superclass(); // find the first
// concrete superclass
// or the abstract
// declaringClass
} else {
if (this.type.implementsInterface(declaringClass, false)) {
if (this.type.isAbstract())
return false; // leave it for the subclasses
if (!superclass.implementsInterface(declaringClass, true)) // only
// if a
// superclass
// does
// not
// also
// implement
// the
// interface
return true;
}
while (superclass.isAbstract()
&& !superclass.implementsInterface(declaringClass, false))
superclass = superclass.superclass(); // find the first
// concrete superclass
// or the superclass
// which implements the
// interface
}
return superclass.isAbstract(); // if it is a concrete class then we
// have already reported problem against
// it
}
private ProblemReporter problemReporter() {
return this.type.scope.problemReporter();
}
private ProblemReporter problemReporter(MethodBinding currentMethod) {
ProblemReporter reporter = problemReporter();
if (currentMethod.declaringClass == type) // only report against the
// currentMethod if its
// implemented by the type
reporter.referenceContext = currentMethod.sourceMethod();
return reporter;
}
private ReferenceBinding runtimeException() {
if (runtimeException == null)
this.runtimeException = this.type.scope
.getJavaLangRuntimeException();
return runtimeException;
}
public void verify(SourceTypeBinding type) {
this.type = type;
this.computeMethods();
this.computeInheritedMethods();
this.checkMethods();
}
public String toString() {
StringBuffer buffer = new StringBuffer(10);
buffer.append("MethodVerifier for type: "); //$NON-NLS-1$
buffer.append(type.readableName());
buffer.append('\n');
buffer.append("\t-inherited methods: "); //$NON-NLS-1$
buffer.append(this.inheritedMethods);
return buffer.toString();
}
}
The table below shows all metrics for MethodVerifier.java.
| Metric | Value | Description | |
|---|---|---|---|
| BLOCKS | 76.00 | Number of blocks | |
| BLOCK_COMMENT | 45.00 | Number of block comment lines | |
| COMMENTS | 188.00 | Comment lines | |
| COMMENT_DENSITY | 0.47 | Comment density | |
| COMPARISONS | 134.00 | Number of comparison operators | |
| CYCLOMATIC | 144.00 | Cyclomatic complexity | |
| DECL_COMMENTS | 5.00 | Comments in declarations | |
| DOC_COMMENT | 10.00 | Number of javadoc comment lines | |
| ELOC | 401.00 | Effective lines of code | |
| EXEC_COMMENTS | 35.00 | Comments in executable code | |
| EXITS | 65.00 | Procedure exits | |
| FUNCTIONS | 17.00 | Number of function declarations | |
| HALSTEAD_DIFFICULTY | 129.28 | Halstead difficulty | |
| HALSTEAD_EFFORT | 0.00 | Halstead effort | |
| INTERFACE_COMPLEXITY | 47.00 | Interface complexity | |
| JAVA0001 | 0.00 | JAVA0001 Package name does not contain only lower case letters | |
| JAVA0002 | 0.00 | JAVA0002 Package name does not begin with a top level domain name or country code | |
| JAVA0003 | 0.00 | JAVA0003 Minimize use of on-demand (.*) imports | |
| JAVA0004 | 0.00 | JAVA0004 Unnecessary import from java.lang | |
| JAVA0005 | 0.00 | JAVA0005 Imports not in specified order | |
| JAVA0006 | 0.00 | JAVA0006 Empty finally block | |
| JAVA0007 | 0.00 | JAVA0007 Should not declare public field | |
| JAVA0008 | 0.00 | JAVA0008 Empty catch block | |
| JAVA0009 | 0.00 | JAVA0009 Protected member in final class | |
| JAVA0010 | 0.00 | JAVA0010 Non-instantiable class does not contain a non-private static member | |
| JAVA0011 | 0.00 | JAVA0011 Abstract class does not contain an abstract method | |
| JAVA0012 | 0.00 | JAVA0012 Non-constructor method with same name as declaring class | |
| JAVA0013 | 0.00 | JAVA0013 Non-blank final field is not static | |
| JAVA0014 | 0.00 | JAVA0014 Class with only static members has non-private constructor | |
| JAVA0015 | 0.00 | JAVA0015 Package class contains public nested type | |
| JAVA0016 | 0.00 | JAVA0016 Abstract class contains public constructor | |
| JAVA0017 | 0.00 | JAVA0017 Class name does not have required form | |
| JAVA0018 | 0.00 | JAVA0018 Method name does not have required form | |
| JAVA0019 | 0.00 | JAVA0019 Interface name does not have required form | |
| JAVA0020 | 0.00 | JAVA0020 Field name does not have required form | |
| JAVA0021 | 0.00 | JAVA0021 Interface method name does not have required form | |
| JAVA0022 | 0.00 | JAVA0022 Static final field name does not have required form | |
| JAVA0023 | 0.00 | JAVA0023 Empty finalize method | |
| JAVA0024 | 0.00 | JAVA0024 Empty class | |
| JAVA0025 | 0.00 | JAVA0025 Method override is empty | |
| JAVA0026 | 0.00 | JAVA0026 Finalize method with parameters | |
| JAVA0029 | 0.00 | JAVA0029 Private method not used | |
| JAVA0030 | 0.00 | JAVA0030 Private field not used | |
| JAVA0031 | 0.00 | JAVA0031 Case statement not properly closed | |
| JAVA0032 | 0.00 | JAVA0032 Switch statement missing default | |
| JAVA0033 | 0.00 | JAVA0033 default: not last case in switch statement | |
| JAVA0034 | 42.00 | JAVA0034 Missing braces in if statement | |
| JAVA0035 | 5.00 | JAVA0035 Missing braces in for statement | |
| JAVA0036 | 6.00 | JAVA0036 Missing braces in while statement | |
| JAVA0038 | 0.00 | JAVA0038 Non-case label in switch statement | |
| JAVA0039 | 1.00 | JAVA0039 Break statement with label | |
| JAVA0040 | 0.00 | JAVA0040 Switch statement contains N cases (maximum: M) | |
| JAVA0041 | 0.00 | JAVA0041 Nested synchronized block | |
| JAVA0042 | 0.00 | JAVA0042 Empty synchronized statement | |
| JAVA0043 | 0.00 | JAVA0043 Inner class does not use outer class | |
| JAVA0044 | 0.00 | JAVA0044 Serializable class with no instance variables | |
| JAVA0045 | 0.00 | JAVA0045 Serializable class with only transient fields | |
| JAVA0046 | 0.00 | JAVA0046 Name of class not derived from Exception ends with 'Exception' | |
| JAVA0047 | 0.00 | JAVA0047 Serializable class derives from invalid base class | |
| JAVA0048 | 0.00 | JAVA0048 Name of class derived from Exception does not end with 'Exception' | |
| JAVA0049 | 8.00 | JAVA0049 Nested block at depth N (maximum: M) | |
| JAVA0050 | 0.00 | JAVA0050 Class derives from java.lang.Error | |
| JAVA0051 | 0.00 | JAVA0051 Class derives from java.lang.RuntimeException | |
| JAVA0052 | 0.00 | JAVA0052 Class derives from java.lang.Throwable | |
| JAVA0053 | 0.00 | JAVA0053 Unused label | |
| JAVA0054 | 0.00 | JAVA0054 Inheritance depth N exceeds maximum M | |
| JAVA0055 | 0.00 | JAVA0055 Class should be interface | |
| JAVA0056 | 0.00 | JAVA0056 Unnecessary abstract modifier for interface or annotation | |
| JAVA0057 | 0.00 | JAVA0057 Unnecessary default constructor | |
| JAVA0058 | 0.00 | JAVA0058 Constructor calls super() | |
| JAVA0059 | 0.00 | JAVA0059 Method override only calls super() | |
| JAVA0061 | 0.00 | JAVA0061 Inaccessible member in anonymous class | |
| JAVA0062 | 0.00 | JAVA0062 Public class missing public member or protected constructor | |
| JAVA0063 | 0.00 | JAVA0063 Identifier name should not contain '$' | |
| JAVA0064 | 0.00 | JAVA0064 N variations of identifier name (maximum: M) | |
| JAVA0065 | 0.00 | JAVA0065 Unnecessary final modifier for method in final class | |
| JAVA0066 | 0.00 | JAVA0066 Unnecessary modifier for interface nested type | |
| JAVA0067 | 0.00 | JAVA0067 Array descriptor on identifier name | |
| JAVA0068 | 0.00 | JAVA0068 Modifiers not declared in recommended order | |
| JAVA0071 | 0.00 | JAVA0071 Strings compared with == | |
| JAVA0073 | 0.00 | JAVA0073 Integer division in floating-point context | |
| JAVA0074 | 0.00 | JAVA0074 Use of Object.notify() | |
| JAVA0075 | 1.00 | JAVA0075 Method parameter hides field | |
| JAVA0076 | 2.00 | JAVA0076 Use of magic number | |
| JAVA0077 | 0.00 | JAVA0077 Private field not used in declaring class | |
| JAVA0078 | 0.00 | JAVA0078 Floating point values compared with == | |
| JAVA0079 | 0.00 | JAVA0079 Use of instance to reference static member | |
| JAVA0080 | 0.00 | JAVA0080 Import declaration not used | |
| JAVA0081 | 0.00 | JAVA0081 Boolean literal in comparison | |
| JAVA0082 | 0.00 | JAVA0082 Unnecessary widening cast | |
| JAVA0083 | 0.00 | JAVA0083 Unnecessary instanceof test | |
| JAVA0084 | 0.00 | JAVA0084 Should use compound assignment operator | |
| JAVA0085 | 0.00 | JAVA0085 Use of sun.* class | |
| JAVA0087 | 0.00 | JAVA0087 Use of Thread.sleep() | |
| JAVA0089 | 0.00 | JAVA0089 Use of restricted package | |
| JAVA0092 | 0.00 | JAVA0092 Use of restricted type | |
| JAVA0093 | 0.00 | JAVA0093 Redundant assignment | |
| JAVA0094 | 0.00 | JAVA0094 Field hides a superclass field | |
| JAVA0095 | 0.00 | JAVA0095 Uninitialized private field | |
| JAVA0096 | 0.00 | JAVA0096 Field in nested class hides outer field | |
| JAVA0098 | 1.00 | JAVA0098 Minimize use of implicit field initializers | |
| JAVA0100 | 0.00 | JAVA0100 Class contains N non-final fields (maximum: M) | |
| JAVA0101 | 0.00 | JAVA0101 Unnecessary modifier for field in interface | |
| JAVA0102 | 0.00 | JAVA0102 Last statement in finalize() not super.finalize() | |
| JAVA0103 | 0.00 | JAVA0103 Explicit call to finalize() | |
| JAVA0104 | 0.00 | JAVA0104 finalize() only calls super.finalize() | |
| JAVA0105 | 0.00 | JAVA0105 Duplicate import declaration | |
| JAVA0106 | 0.00 | JAVA0106 Unnecessary import from current package | |
| JAVA0108 | 0.00 | JAVA0108 Incorrect javadoc: no @param tag for 'parameter' | |
| JAVA0109 | 0.00 | JAVA0109 Incorrect javadoc: no parameter 'parameter' | |
| JAVA0110 | 0.00 | JAVA0110 Incorrect javadoc: no @return tag | |
| JAVA0111 | 0.00 | JAVA0111 Incorrect javadoc: @return tag for void method | |
| JAVA0112 | 0.00 | JAVA0112 Incorrect javadoc: no exception 'exception' in throws | |
| JAVA0113 | 0.00 | JAVA0113 Incorrect javadoc: no @author tag | |
| JAVA0114 | 0.00 | JAVA0114 Incorrect javadoc: no @version tag | |
| JAVA0115 | 0.00 | JAVA0115 Incorrect javadoc: no @throws or @exception tag for 'exception' | |
| JAVA0116 | 0.00 | JAVA0116 Missing javadoc: field 'field' | |
| JAVA0117 | 2.00 | JAVA0117 Missing javadoc: method 'method' | |
| JAVA0118 | 1.00 | JAVA0118 Missing javadoc: type 'type' | |
| JAVA0119 | 1.00 | JAVA0119 Control variable changed within body of for loop | |
| JAVA0123 | 11.00 | JAVA0123 Use all three components of for loop | |
| JAVA0125 | 4.00 | JAVA0125 Continue statement with label | |
| JAVA0126 | 0.00 | JAVA0126 Method declares unchecked exception in throws | |
| JAVA0128 | 0.00 | JAVA0128 Public constructor in non-public class | |
| JAVA0130 | 2.00 | JAVA0130 Non-static method does not use instance fields | |
| JAVA0131 | 0.00 | JAVA0131 Compatible method does not override base | |
| JAVA0132 | 0.00 | JAVA0132 Method overload with compatible signature | |
| JAVA0133 | 0.00 | JAVA0133 Non-synchronized method overrides synchronized method | |
| JAVA0135 | 0.00 | JAVA0135 Only one of Object.equals and Object.hashCode defined: missing 'method' | |
| JAVA0136 | 0.00 | JAVA0136 N methods defined in class (maximum: M) | |
| JAVA0137 | 0.00 | JAVA0137 Non-abstract class missing constructor | |
| JAVA0138 | 0.00 | JAVA0138 N parameters defined for method (maximum: M) | |
| JAVA0139 | 0.00 | JAVA0139 Definition of main other than public static void main(java.lang.String[]) | |
| JAVA0141 | 0.00 | JAVA0141 Unnecessary modifier for method in interface | |
| JAVA0143 | 0.00 | JAVA0143 Synchronized method | |
| JAVA0144 | 0.00 | JAVA0144 Line exceeds maximum M characters | |
| JAVA0145 | 4449.00 | JAVA0145 Tab character used in source file | |
| JAVA0150 | 0.00 | JAVA0150 java.lang.Error (or subclass) thrown | |
| JAVA0153 | 0.00 | JAVA0153 Inefficient conversion of integer to string | |
| JAVA0159 | 0.00 | JAVA0159 Inefficient conversion of string to integer | |
| JAVA0160 | 0.00 | JAVA0160 Method does not throw specified exception | |
| JAVA0161 | 0.00 | JAVA0161 Conditional wait() not in loop | |
| JAVA0163 | 2.00 | JAVA0163 Empty statement | |
| JAVA0165 | 0.00 | JAVA0165 Conflicting return statement in finally block | |
| JAVA0166 | 0.00 | JAVA0166 Generic exception caught | |
| JAVA0167 | 0.00 | JAVA0167 ThreadDeath not rethrown | |
| JAVA0169 | 0.00 | JAVA0169 Unnecessary catch block: exception 'exception' | |
| JAVA0170 | 0.00 | JAVA0170 Caught exception not derived from java.lang.Exception | |
| JAVA0171 | 0.00 | JAVA0171 Unused local variable | |
| JAVA0173 | 0.00 | JAVA0173 Unused method parameter | |
| JAVA0174 | 0.00 | JAVA0174 Assigned local variable never used | |
| JAVA0175 | 0.00 | JAVA0175 Successive assignment to variable | |
| JAVA0176 | 0.00 | JAVA0176 Local variable name does not have required form | |
| JAVA0177 | 0.00 | JAVA0177 Variable declaration missing initializer | |
| JAVA0179 | 0.00 | JAVA0179 Local variable hides visible field | |
| JAVA0233 | 0.00 | JAVA0233 Definition of serialVersionUID other than 'private static final long serialVersionUID' | |
| JAVA0234 | 0.00 | JAVA0234 Class is Serializable but does not define serialVersionUID | |
| JAVA0235 | 0.00 | JAVA0235 Class defines serialVersionUID but does not implement Serializable | |
| JAVA0236 | 0.00 | JAVA0236 Attempt to clone an object which does not implement Cloneable | |
| JAVA0237 | 0.00 | JAVA0237 Class implements Cloneable but does not have public clone method | |
| JAVA0238 | 0.00 | JAVA0238 Clone method does not call super.clone() | |
| JAVA0239 | 0.00 | JAVA0239 Class declares 'readObject' or 'writeObject' but does not implement Serializable | |
| JAVA0240 | 0.00 | JAVA0240 Serializable class which declares readObject or writeObject but not both | |
| JAVA0241 | 0.00 | JAVA0241 'readObject' or 'writeObject' should be declared private in Serializable class | |
| JAVA0242 | 0.00 | JAVA0242 Transient field in non-Serializable class | |
| JAVA0243 | 0.00 | JAVA0243 'readResolve' or 'writeReplace' should be declared private or protected | |
| JAVA0244 | 0.00 | JAVA0244 Field or method name in subclass differs only by case from inherited field or method | |
| JAVA0245 | 0.00 | JAVA0245 JUnit TestCase with non-trivial constructor | |
| JAVA0246 | 0.00 | JAVA0246 JUnit assertXXX statement missing message parameter | |
| JAVA0247 | 0.00 | JAVA0247 JUnit 'setUp()' and 'tearDown()' should call super method | |
| JAVA0248 | 0.00 | JAVA0248 JUnit method 'setUp' or 'tearDown' with incorrect signature | |
| JAVA0249 | 0.00 | JAVA0249 JUnit TestCase 'suite()' should be declared static | |
| JAVA0250 | 0.00 | JAVA0250 JUnit TestCase declares testXXX method with incorrect signature | |
| JAVA0251 | 0.00 | JAVA0251 Use '%n' for line breaks in printf/format for platform independence | |
| JAVA0252 | 0.00 | JAVA0252 'enum' is a Java 1.5 reserved word | |
| JAVA0253 | 0.00 | JAVA0253 Not all enum constants consumed in switch statement | |
| JAVA0254 | 0.00 | JAVA0254 Use enhanced for loop construct instead of Iterator | |
| JAVA0255 | 0.00 | JAVA0255 Result of method invocation not used | |
| JAVA0256 | 0.00 | JAVA0256 Assignment of external collection/array to field | |
| JAVA0257 | 2.00 | JAVA0257 Use of 'Constant Interface' anti-pattern | |
| JAVA0258 | 0.00 | JAVA0258 Implement Iterable for foreach compatibility | |
| JAVA0259 | 0.00 | JAVA0259 Return of collection/array field | |
| JAVA0260 | 0.00 | JAVA0260 Use 'enum' instead of Enumerated Type pattern | |
| JAVA0261 | 0.00 | JAVA0261 Use specialized Enum collection types | |
| JAVA0262 | 0.00 | JAVA0262 Use of char in integer context | |
| JAVA0263 | 0.00 | JAVA0263 Long literal ends with 'l' instead of 'L' | |
| JAVA0264 | 0.00 | JAVA0264 Integer math in long context - check for overflow | |
| JAVA0265 | 0.00 | JAVA0265 Use of Throwable.printStackTrace() | |
| JAVA0266 | 0.00 | JAVA0266 Use of System.out | |
| JAVA0267 | 0.00 | JAVA0267 Use of System.err | |
| JAVA0269 | 0.00 | JAVA0269 Contents of StringBuffer never used | |
| JAVA0270 | 0.00 | JAVA0270 Use Java 5.0 enhanced for loop construct to iterate over all elements in an array | |
| JAVA0271 | 0.00 | JAVA0271 Minimize use of on-demand (.*) static imports | |
| JAVA0272 | 0.00 | JAVA0272 Thread.run() called | |
| JAVA0273 | 0.00 | JAVA0273 Non-final derivative of Thread calls start() in constructor | |
| JAVA0274 | 0.00 | JAVA0274 Serializable class has a synchronized readObject() | |
| JAVA0275 | 0.00 | JAVA0275 Serializable class has a synchronized writeObject() and no other synchronized methods | |
| JAVA0276 | 0.00 | JAVA0276 Unnecessary use of String constructor | |
| JAVA0277 | 0.00 | JAVA0277 Iterator.next() implementation does not throw NoSuchElementException | |
| JAVA0278 | 0.00 | JAVA0278 Unnecessary use of Boolean constructor | |
| JAVA0279 | 0.00 | JAVA0279 Serialization method readObject or readObjectNoData calls an overridable method | |
| JAVA0280 | 0.00 | JAVA0280 IllegalMonitorStateException caught | |
| JAVA0281 | 0.00 | JAVA0281 Iterator.next() not called in loop | |
| JAVA0282 | 0.00 | JAVA0282 Call to Iterator.next() in loop which does not test Iterator.hasNext() | |
| JAVA0283 | 0.00 | JAVA0283 Control variable not updated in loop body | |
| JAVA0284 | 0.00 | JAVA0284 Explicit garbage collection | |
| JAVA0285 | 0.00 | JAVA0285 Dereference of potentially null variable | |
| JAVA0286 | 0.00 | JAVA0286 Dereference of null variable | |
| JAVA0287 | 0.00 | JAVA0287 Unnecessary null check | |
| JAVA0288 | 0.00 | JAVA0288 Inconsistent null check | |
| LINES | 701.00 | Number of lines in the source file | |
| LINE_COMMENT | 133.00 | Number of line comments | |
| LOC | 469.00 | Lines of code | |
| LOGICAL_LINES | 217.00 | Number of statements | |
| LOOPS | 31.00 | Number of loops | |
| NEST_DEPTH | 9.00 | Maximum nesting depth | |
| OPERANDS | 1063.00 | Number of operands | |
| OPERATORS | 2209.00 | Number of operators | |
| PARAMS | 16.00 | Number of formal parameter declarations | |
| PROGRAM_LENGTH | 3272.00 | Halstead program length | |
| PROGRAM_VOCAB | 276.00 | Halstead program vocabulary | |
| PROGRAM_VOLUME | 0.00 | Halstead program volume | |
| RETURNS | 31.00 | Number of return points from functions | |
| SIZE | 25730.00 | Size of the file in bytes | |
| UNIQUE_OPERANDS | 222.00 | Number of unique operands | |
| UNIQUE_OPERATORS | 54.00 | Number of unique operators | |
| WHITESPACE | 44.00 | Number of whitespace lines | |