PongMsg.java
| Index Score | ||
|---|---|---|
 |
 |
phex.msg |
 |
 |
Phex |
View: Reasons, Metrics, Source Code
These are the metrics that contribute to the Enerjy Score for this file, ranked by impact. So the metrics listed at the top influence the score to a greater extent that the metrics listed at the bottom.
| Metric | Description | |
|---|---|---|
| JAVA0108 | JAVA0108 Incorrect javadoc: no @param tag for 'parameter' |  |
| JAVA0177 | JAVA0177 Variable declaration missing initializer | |
| JAVA0034 | JAVA0034 Missing braces in if statement | |
| JAVA0076 | JAVA0076 Use of magic number | |
| JAVA0117 | JAVA0117 Missing javadoc: method 'method' | |
| EXEC_COMMENTS | Comments in executable code | |
| LOC | Lines of code | |
| SIZE | Size of the file in bytes | |
| BLOCKS | Number of blocks | |
| UNIQUE_OPERATORS | Number of unique operators | |
| JAVA0259 | JAVA0259 Return of collection/array field | |
| LINES | Number of lines in the source file | |
| CYCLOMATIC | Cyclomatic complexity | |
| PROGRAM_VOCAB | Halstead program vocabulary | |
| LINE_COMMENT | Number of line comments | |
| LOGICAL_LINES | Number of statements | |
| OPERATORS | Number of operators | |
| PROGRAM_LENGTH | Halstead program length | |
| PROGRAM_VOLUME | Halstead program volume | |
| JAVA0136 | JAVA0136 N methods defined in class (maximum: M) | |
| UNIQUE_OPERANDS | Number of unique operands | |
| OPERANDS | Number of operands | |
| COMPARISONS | Number of comparison operators | |
| JAVA0126 | JAVA0126 Method declares unchecked exception in throws | |
| ELOC | Effective lines of code | |
| DECL_COMMENTS | Comments in declarations | |
| JAVA0100 | JAVA0100 Class contains N non-final fields (maximum: M) | |
| EXITS | Procedure exits | |
| JAVA0130 | JAVA0130 Non-static method does not use instance fields | |
| LOOPS | Number of loops | |
| JAVA0270 | JAVA0270 Use Java 5.0 enhanced for loop construct to iterate over all elements in an array | |
| NEST_DEPTH | Maximum nesting depth | |
| JAVA0110 | JAVA0110 Incorrect javadoc: no @return tag | |
| JAVA0145 | JAVA0145 Tab character used in source file | |
/*
* PHEX - The pure-java Gnutella-servent.
* Copyright (C) 2001 - 2008 Phex Development Group
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
*
* --- SVN Information ---
* $Id: PongMsg.java 4231 2008-07-15 16:01:10Z gregork $
*/
package phex.msg;
import java.util.HashSet;
import java.util.Set;
import phex.common.address.DefaultDestAddress;
import phex.common.address.DestAddress;
import phex.common.address.MalformedDestAddressException;
import phex.common.log.NLogger;
import phex.io.buffer.ByteBuffer;
import phex.net.repres.PresentationManager;
import phex.security.AccessType;
import phex.security.PhexSecurityManager;
import phex.udp.hostcache.UdpHostCache;
import phex.utils.HexConverter;
import phex.utils.IOUtil;
/**
* <p>A pong response.</p>
*
* <p>This encapsulates a Gnutella message that informs this servent of the
* vital statistics of a Gnutella host. Pongs should only ever be received
* in response to pings.</p>
*
* <p>This implementation handles GGEP extension blocks.</p>
*/
public class PongMsg extends Message
{
protected static final int MIN_PONG_DATA_LEN = 14;
/**
* <p>The un-parsed body of the message.</p>
*/
private byte[] body;
/**
* The address this pong is carrying.
*/
private DestAddress pongAddress;
private long fileCount;
private long fileSizeInKB;
private String vendor;
private int vendorVersionMajor = -1;
private int vendorVersionMinor = -1;
private int avgDailyUptime;
private boolean isUltrapeer;
private GGEPBlock ggepBlock;
/**
* holds the information that can appear in udp pongs
*/
private Set<DestAddress> ippDestAddresses;
private Set<UdpHostCache> udpHostCaches;
private UdpHostCache udpHostCache;
public PongMsg( MsgHeader aHeader, byte[] payload, PhexSecurityManager securityService )
{
super( aHeader );
getHeader().setPayloadType( MsgHeader.PONG_PAYLOAD );
body = payload;
getHeader().setDataLength( body.length );
avgDailyUptime = -1;
// parse the body
parseBody( securityService );
}
/**
* <p>Create a new MsgInitResponse.</p>
*
* <p>The header will be modified so that its function property becomes
* MsgHeader.sInitResponse. The header argument is owned by this object.</p>
*
* @param header the MsgHeader to associate with the new message
*/
protected PongMsg( MsgHeader header, DestAddress pongAddress, int fileCount,
int fileSizeInKB, boolean isUltrapeer, GGEPBlock ggepBlock )
{
super( header );
getHeader().setPayloadType( MsgHeader.PONG_PAYLOAD );
this.pongAddress = pongAddress;
this.fileCount = fileCount;
this.isUltrapeer = isUltrapeer;
this.ggepBlock = ggepBlock;
if ( isUltrapeer )
{
this.fileSizeInKB = createUltrapeerMarking( fileSizeInKB );
}
else
{
this.fileSizeInKB = fileSizeInKB;
}
buildBody();
getHeader().setDataLength( body.length );
}
/**
* Get the address this pong is carrying.
* @return the address of this pong message.
*/
public DestAddress getPongAddress()
{
return pongAddress;
}
/**
* Get the number of files served from this servent.
*
* @return a zero or positive integer giving the number of files served
*/
public long getFileCount()
{
return fileCount;
}
/**
* Get the number of bytes served by this servent.
*
* @return the number of bytes served
*/
public long getFileSizeInKB()
{
return fileSizeInKB;
}
/**
* @return the vendor
*/
public String getVendor()
{
return vendor;
}
/**
* @return the vendorVersionMajor
*/
public int getVendorVersionMajor()
{
return vendorVersionMajor;
}
/**
* @return the vendorVersionMinor
*/
public int getVendorVersionMinor()
{
return vendorVersionMinor;
}
/**
* @return the avgDailyUptime
*/
public int getDailyUptime()
{
return avgDailyUptime;
}
public boolean hasFreeLeafSlots()
{
if ( ggepBlock == null ||
!ggepBlock.isExtensionAvailable( GGEPBlock.ULTRAPEER_ID ) )
{
return false;
}
byte[] data = ggepBlock.getExtensionData( GGEPBlock.ULTRAPEER_ID );
if ( data != null )
{
if( data.length >= 3 )
{
if( data[1] > 0 )
{
return true;
}
}
}
return false;
}
public boolean hasFreeUPSlots()
{
if ( ggepBlock == null ||
!ggepBlock.isExtensionAvailable( GGEPBlock.ULTRAPEER_ID ) )
{
return false;
}
byte[] data = ggepBlock.getExtensionData( GGEPBlock.ULTRAPEER_ID );
if ( data != null )
{
if( data.length >= 3 )
{
if( data[2] > 0 )
{
return true;
}
}
}
return false;
}
public Set<DestAddress> getIPPDestAddresses()
{
return ippDestAddresses;
}
public Set<UdpHostCache> getUdpHostCaches()
{
return udpHostCaches;
}
public UdpHostCache getUdpHostCache()
{
return udpHostCache;
}
public byte[] getBody()
{
return body;
}
/**
* {@inheritDoc}
*/
@Override
public ByteBuffer createMessageBuffer()
{
return ByteBuffer.wrap( body );
}
public byte[] getbytes()
{
byte[] data = new byte[ MsgHeader.DATA_LENGTH + body.length ];
byte[] hdr = getHeader().getBytes();
System.arraycopy( hdr, 0, data, 0, MsgHeader.DATA_LENGTH );
System.arraycopy( body, 0, data, MsgHeader.DATA_LENGTH , body.length );
return data;
}
public String getDebugString()
{
return "Pong[ Addr=" + pongAddress +
", FileCount=" + fileCount +
", FileSize=" + fileSizeInKB +
", AvgUptime=" + avgDailyUptime +
", HEX=[" + HexConverter.toHexString( body ) +
"] ]";
}
private void buildBody()
{
byte[] ggepExtension;
int extensionLength;
if ( ggepBlock != null )
{
// we only build from the first GGEP block our body
ggepExtension = ggepBlock.getBytes();
extensionLength = ggepExtension.length;
}
else
{
ggepExtension = null;
extensionLength = 0;
}
body = new byte[ 14 + extensionLength ];
IOUtil.serializeShortLE( (short)pongAddress.getPort(), body, 0 );
System.arraycopy( pongAddress.getIpAddress().getHostIP(), 0, body, 2, 4 );
IOUtil.serializeIntLE( (int)fileCount, body, 6);
IOUtil.serializeIntLE( (int)fileSizeInKB, body, 10);
if ( ggepExtension != null )
{
System.arraycopy( ggepExtension, 0, body, 14, extensionLength );
}
}
private void parseBody( PhexSecurityManager securityService )
{
int port = IOUtil.unsignedShort2Int(IOUtil.deserializeShortLE( body, 0 ));
byte[] ip = new byte[4];
ip[0] = body[2];
ip[1] = body[3];
ip[2] = body[4];
ip[3] = body[5];
pongAddress = new DefaultDestAddress( ip, port );
fileCount = IOUtil.unsignedInt2Long( IOUtil.deserializeIntLE( body, 6 ) );
fileSizeInKB = IOUtil.unsignedInt2Long( IOUtil.deserializeIntLE( body, 10 ) );
// parse possible GGEP data
if ( body.length <= 14 )
{
return;
}
parseGGEPBlocks( securityService );
}
private void parseGGEPBlocks( PhexSecurityManager securityService )
{
ggepBlock = GGEPBlock.mergeGGEPBlocks( GGEPBlock.parseGGEPBlocks( body, 14 ) );
if ( ggepBlock.isExtensionAvailable( GGEPBlock.VENDOR_CODE_ID ) )
{
byte[] data = ggepBlock.getExtensionData( GGEPBlock.VENDOR_CODE_ID );
if ( data.length >= 4 )
{
vendor = new String( data, 0, 4 ).intern();
if ( data.length > 4 )
{
vendorVersionMajor = data[4] >> 4;
vendorVersionMinor = data[4] & 0x0F;
}
}
}
if ( ggepBlock.isExtensionAvailable( GGEPBlock.AVARAGE_DAILY_UPTIME ) )
{
byte[] data = ggepBlock.getExtensionData( GGEPBlock.AVARAGE_DAILY_UPTIME );
if ( data != null )
{
if ( data.length >= 1 && data.length <= 4)
{
avgDailyUptime = IOUtil.deserializeIntLE( data, 0, data.length );
if ( avgDailyUptime <= 0 )
{
NLogger.warn( PongMsg.class, "Negative average uptime GGEP extension data: " +
avgDailyUptime + " - " + HexConverter.toHexString( data ) );
avgDailyUptime = -1;
}
}
else
{
NLogger.warn( PongMsg.class, "Invalid average uptime GGEP extension data: " +
HexConverter.toHexString( data ) );
avgDailyUptime = -1;
}
}
}
// checks for the UP ggep extension
// if its present and the host has free slots its added to the respective free slots container
// in NetworkHostContainer ....as of now we ignore the actual count of the slots available
if ( ggepBlock.isExtensionAvailable( GGEPBlock.UDP_HOST_CACHE_IPP ) )
{
byte[] data = ggepBlock.getExtensionData( GGEPBlock.UDP_HOST_CACHE_IPP );
if ( data != null )
{
ippDestAddresses = unpackIpPortData( data, securityService );
}
}
// try to get any packed udp host cache list which may be present in udp pongs
if( ggepBlock.isExtensionAvailable( GGEPBlock.UDP_HOST_CACHE_PHC))
{
byte[] data = ggepBlock.getExtensionData( GGEPBlock.UDP_HOST_CACHE_PHC );
if ( data != null )
{
String packedData = new String( data );
udpHostCaches = parsePackedHostCache( packedData, securityService );
}
}
//check if the sending host is a udp host cache n add to
//the functional udp host cache container
if( ggepBlock.isExtensionAvailable( GGEPBlock.UDP_HOST_CACHE_UDPHC))
{
byte[] data = ggepBlock.getExtensionData( GGEPBlock.UDP_HOST_CACHE_UDPHC );
try
{
DestAddress address;
if ( data != null && data.length > 0)
{
address = new DefaultDestAddress( new String( data ), pongAddress.getPort() );
}
else
{
address = pongAddress;
}
//add to the container
AccessType access = securityService.controlHostAddressAccess(
address );
if ( access == AccessType.ACCESS_GRANTED )
{
udpHostCache = new UdpHostCache( address );
}
}
catch( IllegalArgumentException e)
{
NLogger.warn( PongMsg.class, "INVALID Udp Host Cache found " +
"and ignored " + e);
}
}
}
/**
* gets the list of udp host cache addresses from the
* packed host cache ggep extension
* @param packedHostCaches
*/
private Set<UdpHostCache> parsePackedHostCache( String packedHostCaches, PhexSecurityManager securityMgr )
{
PresentationManager netPresMgr = PresentationManager.getInstance();
String[] hostCaches = packedHostCaches.split( "\n" );
Set<UdpHostCache> packedUdpHostCaches = new HashSet<UdpHostCache>( hostCaches.length );
for( int i=0; i < hostCaches.length; i++ )
{
//find the position of the first key/value pair if any
int pos = hostCaches[i].indexOf( "&" );
try
{
DestAddress address;
//no key/value pair found
if( pos == -1)
{
address = netPresMgr.createHostAddress(hostCaches[i], DefaultDestAddress.DEFAULT_PORT);
}
else
{
//key/value pair found, but just ignore as of now
String temp = hostCaches[i].substring( 0, pos );
address = netPresMgr.createHostAddress(temp, DefaultDestAddress.DEFAULT_PORT);
}
AccessType access = securityMgr.controlHostAddressAccess( address );
if ( access == AccessType.ACCESS_GRANTED )
{
UdpHostCache cache = new UdpHostCache( address );
packedUdpHostCaches.add( cache );
}
}
catch ( MalformedDestAddressException e )
{
// just ignore and continue with next string
NLogger.warn( PongMsg.class, " Ignored " +
"One Host Cache address in a packed host cache list "
+ e );
continue;
}
}
return packedUdpHostCaches;
}
private static Set<DestAddress> unpackIpPortData( byte[] data, PhexSecurityManager securityMgr )
{
Set<DestAddress> ipPortPairs = null;
try
{
final int FIELD_SIZE = 6;
if (data.length % FIELD_SIZE != 0)
{
throw new InvalidGGEPBlockException("invalid IPPORT EXTENSION DATA IN PONG");
}
int size = data.length/FIELD_SIZE;
ipPortPairs = new HashSet<DestAddress>();
int index;
for (int i=0; i<size; i++)
{
index = i*FIELD_SIZE;
byte[] ip = new byte[4];
System.arraycopy(data, index, ip, 0, 4);
int port = IOUtil.unsignedShort2Int(
IOUtil.deserializeShortLE( data, index + 4 ) );
AccessType access = securityMgr.controlHostIPAccess( ip );
if ( access == AccessType.ACCESS_GRANTED )
{
DestAddress current = new DefaultDestAddress( ip, port );
ipPortPairs.add( current );
}
}
}
catch ( InvalidGGEPBlockException exp )
{
//ignore and continue parsing...
NLogger.warn( PongMsg.class, exp );
}
return ipPortPairs;
}
/**
* Returns true if this pong is marking a ultrapeer. This is the case when
* fileSizeInKB is a power of two but at least 8.
* @return true if this pong is marking a ultrapeer.
*/
public boolean isUltrapeerMarked()
{
if ( fileSizeInKB < 8 )
{
return false;
}
return ( fileSizeInKB & (fileSizeInKB - 1 ) ) == 0;
}
/**
* Sets the ultrapeer kbytes field for ultrapeers.
* This is done by returning the nearest power of two of the kbytes field.
* A kbytes value of 1536 would return 1024.
* 1535 512.
*/
private static int createUltrapeerMarking( int kbytes )
{
if ( kbytes < 12 )
{
return 8;
}
// first get the bit count of the value and substract 1...
int bitCount = IOUtil.determineBitCount( kbytes );
// calculate the power of two...
int power = (int)Math.pow( 2, bitCount );
// now determine the border value of the exponent...
int minBorder = power - (power / 4);
if ( kbytes < minBorder )
{
power = (int)Math.pow( 2, bitCount-1 );
}
return power;
}
}
The table below shows all metrics for PongMsg.java.
| Metric | Value | Description | |
|---|---|---|---|
| BLOCKS | 71.00 | Number of blocks | |
| BLOCK_COMMENT | 21.00 | Number of block comment lines | |
| COMMENTS | 110.00 | Comment lines | |
| COMMENT_DENSITY | 0.45 | Comment density | |
| COMPARISONS | 42.00 | Number of comparison operators | |
| CYCLOMATIC | 67.00 | Cyclomatic complexity | |
| DECL_COMMENTS | 17.00 | Comments in declarations | |
| DOC_COMMENT | 71.00 | Number of javadoc comment lines | |
| ELOC | 242.00 | Effective lines of code | |
| EXEC_COMMENTS | 15.00 | Comments in executable code | |
| EXITS | 41.00 | Procedure exits | |
| FUNCTIONS | 25.00 | Number of function declarations | |
| HALSTEAD_DIFFICULTY | 93.20 | Halstead difficulty | |
| HALSTEAD_EFFORT | 0.00 | Halstead effort | |
| INTERFACE_COMPLEXITY | 48.00 | Interface complexity | |
| JAVA0001 | 0.00 | JAVA0001 Package name does not contain only lower case letters | |
| JAVA0002 | 1.00 | JAVA0002 Package name does not begin with a top level domain name or country code | |
| JAVA0003 | 0.00 | JAVA0003 Minimize use of on-demand (.*) imports | |
| JAVA0004 | 0.00 | JAVA0004 Unnecessary import from java.lang | |
| JAVA0005 | 0.00 | JAVA0005 Imports not in specified order | |
| JAVA0006 | 0.00 | JAVA0006 Empty finally block | |
| JAVA0007 | 0.00 | JAVA0007 Should not declare public field | |
| JAVA0008 | 0.00 | JAVA0008 Empty catch block | |
| JAVA0009 | 0.00 | JAVA0009 Protected member in final class | |
| JAVA0010 | 0.00 | JAVA0010 Non-instantiable class does not contain a non-private static member | |
| JAVA0011 | 0.00 | JAVA0011 Abstract class does not contain an abstract method | |
| JAVA0012 | 0.00 | JAVA0012 Non-constructor method with same name as declaring class | |
| JAVA0013 | 0.00 | JAVA0013 Non-blank final field is not static | |
| JAVA0014 | 0.00 | JAVA0014 Class with only static members has non-private constructor | |
| JAVA0015 | 0.00 | JAVA0015 Package class contains public nested type | |
| JAVA0016 | 0.00 | JAVA0016 Abstract class contains public constructor | |
| JAVA0017 | 0.00 | JAVA0017 Class name does not have required form | |
| JAVA0018 | 0.00 | JAVA0018 Method name does not have required form | |
| JAVA0019 | 0.00 | JAVA0019 Interface name does not have required form | |
| JAVA0020 | 0.00 | JAVA0020 Field name does not have required form | |
| JAVA0021 | 0.00 | JAVA0021 Interface method name does not have required form | |
| JAVA0022 | 0.00 | JAVA0022 Static final field name does not have required form | |
| JAVA0023 | 0.00 | JAVA0023 Empty finalize method | |
| JAVA0024 | 0.00 | JAVA0024 Empty class | |
| JAVA0025 | 0.00 | JAVA0025 Method override is empty | |
| JAVA0026 | 0.00 | JAVA0026 Finalize method with parameters | |
| JAVA0029 | 0.00 | JAVA0029 Private method not used | |
| JAVA0030 | 0.00 | JAVA0030 Private field not used | |
| JAVA0031 | 0.00 | JAVA0031 Case statement not properly closed | |
| JAVA0032 | 0.00 | JAVA0032 Switch statement missing default | |
| JAVA0033 | 0.00 | JAVA0033 default: not last case in switch statement | |
| JAVA0034 | 0.00 | JAVA0034 Missing braces in if statement | |
| JAVA0035 | 0.00 | JAVA0035 Missing braces in for statement | |
| JAVA0036 | 0.00 | JAVA0036 Missing braces in while statement | |
| JAVA0038 | 0.00 | JAVA0038 Non-case label in switch statement | |
| JAVA0039 | 0.00 | JAVA0039 Break statement with label | |
| JAVA0040 | 0.00 | JAVA0040 Switch statement contains N cases (maximum: M) | |
| JAVA0041 | 0.00 | JAVA0041 Nested synchronized block | |
| JAVA0042 | 0.00 | JAVA0042 Empty synchronized statement | |
| JAVA0043 | 0.00 | JAVA0043 Inner class does not use outer class | |
| JAVA0044 | 0.00 | JAVA0044 Serializable class with no instance variables | |
| JAVA0045 | 0.00 | JAVA0045 Serializable class with only transient fields | |
| JAVA0046 | 0.00 | JAVA0046 Name of class not derived from Exception ends with 'Exception' | |
| JAVA0047 | 0.00 | JAVA0047 Serializable class derives from invalid base class | |
| JAVA0048 | 0.00 | JAVA0048 Name of class derived from Exception does not end with 'Exception' | |
| JAVA0049 | 0.00 | JAVA0049 Nested block at depth N (maximum: M) | |
| JAVA0050 | 0.00 | JAVA0050 Class derives from java.lang.Error | |
| JAVA0051 | 0.00 | JAVA0051 Class derives from java.lang.RuntimeException | |
| JAVA0052 | 0.00 | JAVA0052 Class derives from java.lang.Throwable | |
| JAVA0053 | 0.00 | JAVA0053 Unused label | |
| JAVA0054 | 0.00 | JAVA0054 Inheritance depth N exceeds maximum M | |
| JAVA0055 | 0.00 | JAVA0055 Class should be interface | |
| JAVA0056 | 0.00 | JAVA0056 Unnecessary abstract modifier for interface or annotation | |
| JAVA0057 | 0.00 | JAVA0057 Unnecessary default constructor | |
| JAVA0058 | 0.00 | JAVA0058 Constructor calls super() | |
| JAVA0059 | 0.00 | JAVA0059 Method override only calls super() | |
| JAVA0061 | 0.00 | JAVA0061 Inaccessible member in anonymous class | |
| JAVA0062 | 0.00 | JAVA0062 Public class missing public member or protected constructor | |
| JAVA0063 | 0.00 | JAVA0063 Identifier name should not contain '$' | |
| JAVA0064 | 0.00 | JAVA0064 N variations of identifier name (maximum: M) | |
| JAVA0065 | 0.00 | JAVA0065 Unnecessary final modifier for method in final class | |
| JAVA0066 | 0.00 | JAVA0066 Unnecessary modifier for interface nested type | |
| JAVA0067 | 0.00 | JAVA0067 Array descriptor on identifier name | |
| JAVA0068 | 0.00 | JAVA0068 Modifiers not declared in recommended order | |
| JAVA0071 | 0.00 | JAVA0071 Strings compared with == | |
| JAVA0073 | 0.00 | JAVA0073 Integer division in floating-point context | |
| JAVA0074 | 0.00 | JAVA0074 Use of Object.notify() | |
| JAVA0075 | 0.00 | JAVA0075 Method parameter hides field | |
| JAVA0076 | 10.00 | JAVA0076 Use of magic number | |
| JAVA0077 | 0.00 | JAVA0077 Private field not used in declaring class | |
| JAVA0078 | 0.00 | JAVA0078 Floating point values compared with == | |
| JAVA0079 | 0.00 | JAVA0079 Use of instance to reference static member | |
| JAVA0080 | 0.00 | JAVA0080 Import declaration not used | |
| JAVA0081 | 0.00 | JAVA0081 Boolean literal in comparison | |
| JAVA0082 | 0.00 | JAVA0082 Unnecessary widening cast | |
| JAVA0083 | 0.00 | JAVA0083 Unnecessary instanceof test | |
| JAVA0084 | 0.00 | JAVA0084 Should use compound assignment operator | |
| JAVA0085 | 0.00 | JAVA0085 Use of sun.* class | |
| JAVA0087 | 0.00 | JAVA0087 Use of Thread.sleep() | |
| JAVA0089 | 0.00 | JAVA0089 Use of restricted package | |
| JAVA0092 | 0.00 | JAVA0092 Use of restricted type | |
| JAVA0093 | 0.00 | JAVA0093 Redundant assignment | |
| JAVA0094 | 0.00 | JAVA0094 Field hides a superclass field | |
| JAVA0095 | 0.00 | JAVA0095 Uninitialized private field | |
| JAVA0096 | 0.00 | JAVA0096 Field in nested class hides outer field | |
| JAVA0098 | 0.00 | JAVA0098 Minimize use of implicit field initializers | |
| JAVA0100 | 1.00 | JAVA0100 Class contains N non-final fields (maximum: M) | |
| JAVA0101 | 0.00 | JAVA0101 Unnecessary modifier for field in interface | |
| JAVA0102 | 0.00 | JAVA0102 Last statement in finalize() not super.finalize() | |
| JAVA0103 | 0.00 | JAVA0103 Explicit call to finalize() | |
| JAVA0104 | 0.00 | JAVA0104 finalize() only calls super.finalize() | |
| JAVA0105 | 0.00 | JAVA0105 Duplicate import declaration | |
| JAVA0106 | 0.00 | JAVA0106 Unnecessary import from current package | |
| JAVA0108 | 7.00 | JAVA0108 Incorrect javadoc: no @param tag for 'parameter' | |
| JAVA0109 | 0.00 | JAVA0109 Incorrect javadoc: no parameter 'parameter' | |
| JAVA0110 | 2.00 | JAVA0110 Incorrect javadoc: no @return tag | |
| JAVA0111 | 0.00 | JAVA0111 Incorrect javadoc: @return tag for void method | |
| JAVA0112 | 0.00 | JAVA0112 Incorrect javadoc: no exception 'exception' in throws | |
| JAVA0113 | 1.00 | JAVA0113 Incorrect javadoc: no @author tag | |
| JAVA0114 | 1.00 | JAVA0114 Incorrect javadoc: no @version tag | |
| JAVA0115 | 0.00 | JAVA0115 Incorrect javadoc: no @throws or @exception tag for 'exception' | |
| JAVA0116 | 0.00 | JAVA0116 Missing javadoc: field 'field' | |
| JAVA0117 | 9.00 | JAVA0117 Missing javadoc: method 'method' | |
| JAVA0118 | 0.00 | JAVA0118 Missing javadoc: type 'type' | |
| JAVA0119 | 0.00 | JAVA0119 Control variable changed within body of for loop | |
| JAVA0123 | 0.00 | JAVA0123 Use all three components of for loop | |
| JAVA0125 | 0.00 | JAVA0125 Continue statement with label | |
| JAVA0126 | 0.00 | JAVA0126 Method declares unchecked exception in throws | |
| JAVA0128 | 0.00 | JAVA0128 Public constructor in non-public class | |
| JAVA0130 | 1.00 | JAVA0130 Non-static method does not use instance fields | |
| JAVA0131 | 0.00 | JAVA0131 Compatible method does not override base | |
| JAVA0132 | 0.00 | JAVA0132 Method overload with compatible signature | |
| JAVA0133 | 0.00 | JAVA0133 Non-synchronized method overrides synchronized method | |
| JAVA0135 | 0.00 | JAVA0135 Only one of Object.equals and Object.hashCode defined: missing 'method' | |
| JAVA0136 | 1.00 | JAVA0136 N methods defined in class (maximum: M) | |
| JAVA0137 | 0.00 | JAVA0137 Non-abstract class missing constructor | |
| JAVA0138 | 1.00 | JAVA0138 N parameters defined for method (maximum: M) | |
| JAVA0139 | 0.00 | JAVA0139 Definition of main other than public static void main(java.lang.String[]) | |
| JAVA0141 | 0.00 | JAVA0141 Unnecessary modifier for method in interface | |
| JAVA0143 | 0.00 | JAVA0143 Synchronized method | |
| JAVA0144 | 0.00 | JAVA0144 Line exceeds maximum M characters | |
| JAVA0145 | 0.00 | JAVA0145 Tab character used in source file | |
| JAVA0150 | 0.00 | JAVA0150 java.lang.Error (or subclass) thrown | |
| JAVA0153 | 0.00 | JAVA0153 Inefficient conversion of integer to string | |
| JAVA0159 | 0.00 | JAVA0159 Inefficient conversion of string to integer | |
| JAVA0160 | 0.00 | JAVA0160 Method does not throw specified exception | |
| JAVA0161 | 0.00 | JAVA0161 Conditional wait() not in loop | |
| JAVA0163 | 0.00 | JAVA0163 Empty statement | |
| JAVA0165 | 0.00 | JAVA0165 Conflicting return statement in finally block | |
| JAVA0166 | 0.00 | JAVA0166 Generic exception caught | |
| JAVA0167 | 0.00 | JAVA0167 ThreadDeath not rethrown | |
| JAVA0169 | 0.00 | JAVA0169 Unnecessary catch block: exception 'exception' | |
| JAVA0170 | 0.00 | JAVA0170 Caught exception not derived from java.lang.Exception | |
| JAVA0171 | 0.00 | JAVA0171 Unused local variable | |
| JAVA0173 | 0.00 | JAVA0173 Unused method parameter | |
| JAVA0174 | 0.00 | JAVA0174 Assigned local variable never used | |
| JAVA0175 | 0.00 | JAVA0175 Successive assignment to variable | |
| JAVA0176 | 0.00 | JAVA0176 Local variable name does not have required form | |
| JAVA0177 | 5.00 | JAVA0177 Variable declaration missing initializer | |
| JAVA0179 | 0.00 | JAVA0179 Local variable hides visible field | |
| JAVA0233 | 0.00 | JAVA0233 Definition of serialVersionUID other than 'private static final long serialVersionUID' | |
| JAVA0234 | 0.00 | JAVA0234 Class is Serializable but does not define serialVersionUID | |
| JAVA0235 | 0.00 | JAVA0235 Class defines serialVersionUID but does not implement Serializable | |
| JAVA0236 | 0.00 | JAVA0236 Attempt to clone an object which does not implement Cloneable | |
| JAVA0237 | 0.00 | JAVA0237 Class implements Cloneable but does not have public clone method | |
| JAVA0238 | 0.00 | JAVA0238 Clone method does not call super.clone() | |
| JAVA0239 | 0.00 | JAVA0239 Class declares 'readObject' or 'writeObject' but does not implement Serializable | |
| JAVA0240 | 0.00 | JAVA0240 Serializable class which declares readObject or writeObject but not both | |
| JAVA0241 | 0.00 | JAVA0241 'readObject' or 'writeObject' should be declared private in Serializable class | |
| JAVA0242 | 0.00 | JAVA0242 Transient field in non-Serializable class | |
| JAVA0243 | 0.00 | JAVA0243 'readResolve' or 'writeReplace' should be declared private or protected | |
| JAVA0244 | 0.00 | JAVA0244 Field or method name in subclass differs only by case from inherited field or method | |
| JAVA0245 | 0.00 | JAVA0245 JUnit TestCase with non-trivial constructor | |
| JAVA0246 | 0.00 | JAVA0246 JUnit assertXXX statement missing message parameter | |
| JAVA0247 | 0.00 | JAVA0247 JUnit 'setUp()' and 'tearDown()' should call super method | |
| JAVA0248 | 0.00 | JAVA0248 JUnit method 'setUp' or 'tearDown' with incorrect signature | |
| JAVA0249 | 0.00 | JAVA0249 JUnit TestCase 'suite()' should be declared static | |
| JAVA0250 | 0.00 | JAVA0250 JUnit TestCase declares testXXX method with incorrect signature | |
| JAVA0251 | 0.00 | JAVA0251 Use '%n' for line breaks in printf/format for platform independence | |
| JAVA0252 | 0.00 | JAVA0252 'enum' is a Java 1.5 reserved word | |
| JAVA0253 | 0.00 | JAVA0253 Not all enum constants consumed in switch statement | |
| JAVA0254 | 0.00 | JAVA0254 Use enhanced for loop construct instead of Iterator | |
| JAVA0255 | 0.00 | JAVA0255 Result of method invocation not used | |
| JAVA0256 | 1.00 | JAVA0256 Assignment of external collection/array to field | |
| JAVA0257 | 0.00 | JAVA0257 Use of 'Constant Interface' anti-pattern | |
| JAVA0258 | 0.00 | JAVA0258 Implement Iterable for foreach compatibility | |
| JAVA0259 | 3.00 | JAVA0259 Return of collection/array field | |
| JAVA0260 | 0.00 | JAVA0260 Use 'enum' instead of Enumerated Type pattern | |
| JAVA0261 | 0.00 | JAVA0261 Use specialized Enum collection types | |
| JAVA0262 | 0.00 | JAVA0262 Use of char in integer context | |
| JAVA0263 | 0.00 | JAVA0263 Long literal ends with 'l' instead of 'L' | |
| JAVA0264 | 0.00 | JAVA0264 Integer math in long context - check for overflow | |
| JAVA0265 | 0.00 | JAVA0265 Use of Throwable.printStackTrace() | |
| JAVA0266 | 0.00 | JAVA0266 Use of System.out | |
| JAVA0267 | 0.00 | JAVA0267 Use of System.err | |
| JAVA0269 | 0.00 | JAVA0269 Contents of StringBuffer never used | |
| JAVA0270 | 1.00 | JAVA0270 Use Java 5.0 enhanced for loop construct to iterate over all elements in an array | |
| JAVA0271 | 0.00 | JAVA0271 Minimize use of on-demand (.*) static imports | |
| JAVA0272 | 0.00 | JAVA0272 Thread.run() called | |
| JAVA0273 | 0.00 | JAVA0273 Non-final derivative of Thread calls start() in constructor | |
| JAVA0274 | 0.00 | JAVA0274 Serializable class has a synchronized readObject() | |
| JAVA0275 | 0.00 | JAVA0275 Serializable class has a synchronized writeObject() and no other synchronized methods | |
| JAVA0276 | 0.00 | JAVA0276 Unnecessary use of String constructor | |
| JAVA0277 | 0.00 | JAVA0277 Iterator.next() implementation does not throw NoSuchElementException | |
| JAVA0278 | 0.00 | JAVA0278 Unnecessary use of Boolean constructor | |
| JAVA0279 | 0.00 | JAVA0279 Serialization method readObject or readObjectNoData calls an overridable method | |
| JAVA0280 | 0.00 | JAVA0280 IllegalMonitorStateException caught | |
| JAVA0281 | 0.00 | JAVA0281 Iterator.next() not called in loop | |
| JAVA0282 | 0.00 | JAVA0282 Call to Iterator.next() in loop which does not test Iterator.hasNext() | |
| JAVA0283 | 0.00 | JAVA0283 Control variable not updated in loop body | |
| JAVA0284 | 0.00 | JAVA0284 Explicit garbage collection | |
| JAVA0285 | 0.00 | JAVA0285 Dereference of potentially null variable | |
| JAVA0286 | 0.00 | JAVA0286 Dereference of null variable | |
| JAVA0287 | 0.00 | JAVA0287 Unnecessary null check | |
| JAVA0288 | 0.00 | JAVA0288 Inconsistent null check | |
| LINES | 548.00 | Number of lines in the source file | |
| LINE_COMMENT | 18.00 | Number of line comments | |
| LOC | 385.00 | Lines of code | |
| LOGICAL_LINES | 157.00 | Number of statements | |
| LOOPS | 2.00 | Number of loops | |
| NEST_DEPTH | 5.00 | Maximum nesting depth | |
| OPERANDS | 690.00 | Number of operands | |
| OPERATORS | 1326.00 | Number of operators | |
| PARAMS | 16.00 | Number of formal parameter declarations | |
| PROGRAM_LENGTH | 2016.00 | Halstead program length | |
| PROGRAM_VOCAB | 268.00 | Halstead program vocabulary | |
| PROGRAM_VOLUME | 0.00 | Halstead program volume | |
| RETURNS | 32.00 | Number of return points from functions | |
| SIZE | 17290.00 | Size of the file in bytes | |
| UNIQUE_OPERANDS | 211.00 | Number of unique operands | |
| UNIQUE_OPERATORS | 57.00 | Number of unique operators | |
| WHITESPACE | 53.00 | Number of whitespace lines | |