NetworkHostsContainer.java
| Index Score | ||
|---|---|---|
 |
 |
phex.host |
 |
 |
Phex |
View: Reasons, Metrics, Source Code
These are the metrics that contribute to the Enerjy Score for this file, ranked by impact. So the metrics listed at the top influence the score to a greater extent that the metrics listed at the bottom.
| Metric | Description | |
|---|---|---|
| JAVA0143 | JAVA0143 Synchronized method |  |
| LINE_COMMENT | Number of line comments | |
| EXEC_COMMENTS | Comments in executable code | |
| DECL_COMMENTS | Comments in declarations | |
| JAVA0117 | JAVA0117 Missing javadoc: method 'method' | |
| JAVA0034 | JAVA0034 Missing braces in if statement | |
| SIZE | Size of the file in bytes | |
| JAVA0108 | JAVA0108 Incorrect javadoc: no @param tag for 'parameter' | |
| FUNCTIONS | Number of function declarations | |
| BLOCKS | Number of blocks | |
| COMMENTS | Comment lines | |
| JAVA0177 | JAVA0177 Variable declaration missing initializer | |
| LINES | Number of lines in the source file | |
| CYCLOMATIC | Cyclomatic complexity | |
| COMPARISONS | Number of comparison operators | |
| LOC | Lines of code | |
| EXITS | Procedure exits | |
| RETURNS | Number of return points from functions | |
| JAVA0110 | JAVA0110 Incorrect javadoc: no @return tag | |
| UNIQUE_OPERATORS | Number of unique operators | |
| PROGRAM_VOLUME | Halstead program volume | |
| JAVA0136 | JAVA0136 N methods defined in class (maximum: M) | |
| PROGRAM_VOCAB | Halstead program vocabulary | |
| JAVA0126 | JAVA0126 Method declares unchecked exception in throws | |
| OPERATORS | Number of operators | |
| DOC_COMMENT | Number of javadoc comment lines | |
| UNIQUE_OPERANDS | Number of unique operands | |
| JAVA0173 | JAVA0173 Unused method parameter | |
| INTERFACE_COMPLEXITY | Interface complexity | |
| PROGRAM_LENGTH | Halstead program length | |
| JAVA0068 | JAVA0068 Modifiers not declared in recommended order | |
| NEST_DEPTH | Maximum nesting depth | |
| JAVA0145 | JAVA0145 Tab character used in source file | |
| ELOC | Effective lines of code | |
/*
* PHEX - The pure-java Gnutella-servent.
* Copyright (C) 2001 - 2007 Phex Development Group
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
*
* --- SVN Information ---
* $Id: NetworkHostsContainer.java 4155 2008-03-21 17:08:12Z gregork $
*/
package phex.host;
import java.util.ArrayList;
import java.util.HashSet;
import java.util.List;
import org.bushe.swing.event.annotation.EventTopicSubscriber;
import phex.common.AbstractLifeCycle;
import phex.common.address.DestAddress;
import phex.connection.ConnectionObserver;
import phex.event.ChangeEvent;
import phex.event.ContainerEvent;
import phex.event.PhexEventTopics;
import phex.gui.prefs.NetworkTabPrefs;
import phex.prefs.core.ConnectionPrefs;
import phex.prefs.core.NetworkPrefs;
import phex.servent.OnlineStatus;
import phex.servent.Servent;
import phex.utils.Localizer;
/**
* Responsible for holding all hosts of the current network neighbor hood.
*/
final public class NetworkHostsContainer extends AbstractLifeCycle
{
private Servent servent;
/**
* The complete neighbor hood. Contains all connected and not connected
* hosts independent from its connection type.
* This collection is mainly used for GUI representation.
*/
private final List<Host> networkHosts;
/**
* Contains a list of connected peer connections.
*/
private final List<Host> peerConnections;
/**
* Contains a list of connected ultrapeer connections.
*/
private final List<Host> ultrapeerConnections;
/**
* The number of connections that are leafUltrapeerConnections inside the
* ultrapeerConnections list.
*/
private int leafUltrapeerConnectionCount;
/**
* Contains a list of connected leaf connections, in case we act as there
* Ultrapeer.
*/
private final List<Host> leafConnections;
public NetworkHostsContainer( Servent servent )
{
this.servent = servent;
networkHosts = new ArrayList<Host>();
peerConnections = new ArrayList<Host>();
ultrapeerConnections = new ArrayList<Host>();
leafConnections = new ArrayList<Host>();
servent.getEventService().processAnnotations( this );
}
@Override
protected void doStart()
{
ConnectionObserver observer = new ConnectionObserver( this,
servent.getMessageService() );
observer.start();
}
/**
* Returns true if the local host is a shielded leaf node ( has a connection
* to a ultrapeer).
*/
public synchronized boolean isShieldedLeafNode()
{
return leafUltrapeerConnectionCount > 0;
}
/**
* Indicates if connection to leafs are available.
* @return true if connection to leafs are available,
* false otherwise
*/
public synchronized boolean hasLeafConnections()
{
// we are a ultrapeer if we have any leaf slots filled.
return !leafConnections.isEmpty();
}
/**
* Indicates if connection to ultrapeers are available.
* @return true if connection to ultrapeers are available,
* false otherwise
*/
public synchronized boolean hasUltrapeerConnections()
{
return !ultrapeerConnections.isEmpty();
}
/**
* Used to check if we have anymore ultrapeer slots. Usually this method
* should only be used used as a Ultrapeer.
* @return true if ultrapeer slots are available, false otherwise.
*/
public boolean hasUltrapeerSlotsAvailable()
{
// Note: That we don't response on pings when the slots are full this
// results in not getting that many incoming requests.
return ultrapeerConnections.size() < ConnectionPrefs.Up2UpConnections.get().intValue();
}
/**
* Returns the number of open slots for leaf nodes. Usually this method
* should only be used used as a Ultrapeer.
* @return the number of open slots for leaf nodes.
*/
public int getOpenUltrapeerSlotsCount()
{
return ConnectionPrefs.Up2UpConnections.get().intValue() - ultrapeerConnections.size();
}
/**
* Used to check if we would provide a Ultrapeer that will become a possible
* leaf through leaf guidance a slot. This is only the case if we have not
* already a ultrapeer too much and if we have a leaf slot available.
* @return true if we have a leaf slot available to guide a ultrapeer,
* false otherwise
*/
public boolean hasLeafSlotForUltrapeerAvailable()
{
return hasLeafSlotsAvailable() &&
// Allow one more up2up connection to accept this possibly leaf guided
// ultrapeer
ultrapeerConnections.size() < ConnectionPrefs.Up2UpConnections.get().intValue() + 1;
}
/**
* Used to check if we have anymore leaf slots. Usually this method
* is only used used as a Ultrapeer.
* @return true if we have leaf slots available, false otherwise.
*/
public boolean hasLeafSlotsAvailable()
{
// Note: That we don't response on pings when the slots are full this
// results in not getting that many incoming requests.
return leafConnections.size() < ConnectionPrefs.Up2LeafConnections.get().intValue();
}
/**
* Returns the number of open slots for leaf nodes.
* @return the number of open slots for leaf nodes.
*/
public int getOpenLeafSlotsCount()
{
if ( servent.isUltrapeer() )
{
return ConnectionPrefs.Up2LeafConnections.get().intValue() - leafConnections.size();
}
return 0;
}
/**
* Returns all available connected ultrapeers.
* @return all available connected ultrapeers.
*/
public synchronized Host[] getUltrapeerConnections()
{
Host[] hosts = new Host[ ultrapeerConnections.size() ];
ultrapeerConnections.toArray( hosts );
return hosts;
}
/**
* Returns all available connected leafs.
* @return all available connected leafs.
*/
public synchronized Host[] getLeafConnections()
{
Host[] hosts = new Host[ leafConnections.size() ];
leafConnections.toArray( hosts );
return hosts;
}
/**
* Returns all available connected peers.
* @return all available connected peers.
*/
public synchronized Host[] getPeerConnections()
{
Host[] hosts = new Host[ peerConnections.size() ];
peerConnections.toArray( hosts );
return hosts;
}
public synchronized int getTotalConnectionCount()
{
return ultrapeerConnections.size() +
leafConnections.size() +
peerConnections.size();
}
public int getLeafConnectionCount()
{
return leafConnections.size();
}
public synchronized int getUltrapeerConnectionCount()
{
return ultrapeerConnections.size();
}
/**
* Returns a array of push proxy addresses or null if
* this is not a shielded leaf node.
* @return a array of push proxy addresses or null.
*/
public DestAddress[] getPushProxies()
{
if ( isShieldedLeafNode() )
{
HashSet<DestAddress> pushProxies = new HashSet<DestAddress>();
for ( Host host : ultrapeerConnections )
{
DestAddress pushProxyAddress = host.getPushProxyAddress();
if ( pushProxyAddress != null )
{
pushProxies.add( pushProxyAddress );
if ( pushProxies.size() == 4 )
{
break;
}
}
}
DestAddress[] addresses = new DestAddress[ pushProxies.size() ];
pushProxies.toArray( addresses );
return addresses;
}
return null;
}
public synchronized void addIncomingHost( Host host )
{
// a incoming host is new for the network and is connected
addNetworkHost( host );
addConnectedHost( host );
//dump();
}
/**
* Adds a connected host to the connected host list. But only if its already
* in the network host list.
* @param host the host to add to the connected host list.
*/
public synchronized void addConnectedHost( Host host )
{
// make sure host is still in network and not already removed
if ( !networkHosts.contains( host ) )
{// host is already removed by user action...
host.disconnect();
return;
}
if ( host.isUltrapeer() )
{
ultrapeerConnections.add( host );
if ( host.isLeafUltrapeerConnection() )
{
leafUltrapeerConnectionCount++;
}
}
else if ( host.isUltrapeerLeafConnection() )
{
leafConnections.add( host );
}
else
{
assert false : "Peer connections should not be used anymore";
peerConnections.add( host );
}
//dump();
}
/**
* @deprecated use host.disconnect();
*/
@Deprecated
public synchronized void disconnectHost( Host host )
{
if ( host == null )
{
return;
}
if ( host.isUltrapeer() )
{
boolean isRemoved = ultrapeerConnections.remove( host );
if ( isRemoved && host.isLeafUltrapeerConnection() )
{
leafUltrapeerConnectionCount--;
}
}
else if ( host.isUltrapeerLeafConnection() )
{
leafConnections.remove( host );
}
else
{
//assert false : "Peer connections should not be used anymore";
peerConnections.remove( host );
}
// clean routings
servent.getMessageService().removeRoutings( host );
servent.getQueryService().removeHostQueries( host );
//dump();
// This is only for testing!!!
/*if ( connectedHosts.contains( host ) )
{
// go crazy
throw new RuntimeException ("notrem");
}*/
}
/**
* Checks for hosts that have a connection timeout...
* Checks if a connected host is able to keep up...
* if not it will be removed...
*/
public synchronized void periodicallyCheckHosts()
{
HostStatus status;
long currentTime = System.currentTimeMillis();
Host[] badHosts = new Host[ networkHosts.size() ];
int badHostsPos = 0;
//boolean isShieldedLeafNode = isShieldedLeafNode();
for( Host host : networkHosts )
{
status = host.getStatus();
if ( status == HostStatus.CONNECTED )
{
host.checkForStableConnection( currentTime );
String policyInfraction = null;
if ( host.tooManyDropPackets() )
{
policyInfraction = Localizer.getString( "TooManyDroppedPackets" );
}
else if ( host.isSendQueueTooLong() )
{
policyInfraction = Localizer.getString( "SendQueueTooLong" );
}
else if ( host.isNoVendorDisconnectApplying() )
{
policyInfraction = Localizer.getString( "NoVendorString" );
}
// freeloaders are no real problem
// else if ( host.isFreeloader( currentTime ) )
// {
// policyInfraction = Localizer.getString( "FreeloaderNotSharing" );
// }
if ( policyInfraction != null )
{
//Logger.logMessage( Logger.FINE, "log.core.msg",
// "Applying disconnect policy to host: " + host +
// " drops: " + host.tooManyDropPackets() +
// " queue: " + host.sendQueueTooLong() );
host.setStatus( HostStatus.ERROR, policyInfraction, currentTime );
host.disconnect();
}
}
if ( NetworkPrefs.AutoRemoveBadHosts.get().booleanValue() )
{
// first collect...
if ( status != HostStatus.CONNECTED &&
status != HostStatus.CONNECTING &&
status != HostStatus.ACCEPTING )
{
if ( host.isErrorStatusExpired( currentTime,
NetworkTabPrefs.HostErrorDisplayTime.get().intValue() ) )
{
//Logger.logMessage( Logger.DEBUG, "log.core.msg",
// "Cleaning up network host: " + host + " Status: " + status );
badHosts[ badHostsPos ] = host;
badHostsPos ++;
continue;
}
}
}
}
// kill all bad hosts...
if ( badHostsPos > 0 )
{
removeNetworkHosts( badHosts );
}
}
public synchronized Host getNetworkHostAt( int index )
{
if ( index < 0 || index >= networkHosts.size() )
{
return null;
}
return networkHosts.get( index );
}
public synchronized Host[] getNetworkHostsAt( int[] indices )
{
int length = indices.length;
Host[] hosts = new Host[ length ];
for ( int i = 0; i < length; i++ )
{
if ( indices[i] < 0 || indices[i] >= networkHosts.size() )
{
hosts[i] = null;
}
else
{
hosts[i] = networkHosts.get( indices[i] );
}
}
return hosts;
}
public synchronized Host getNetworkHost( DestAddress address )
{
for ( Host networkHost : networkHosts )
{
DestAddress networkAddress = networkHost.getHostAddress();
if ( networkAddress.equals( address ) )
{
return networkHost;
}
}
//not found
return null;
}
/**
* Returns the count of the complete neighbour hood, containing all
* connected and not connected hosts independent from its connection type.
*/
public synchronized int getNetworkHostCount()
{
return networkHosts.size();
}
/**
* Returns the count of the networks hosts with the given status.
*/
public synchronized int getNetworkHostCount( HostStatus status )
{
int count = 0;
for( Host host : networkHosts )
{
if ( host.getStatus() == status )
{
count ++;
}
}
return count;
}
/**
* Adds a host to the network host list.
* @param host the host to add to the network host list.
*/
public synchronized void addNetworkHost( Host host )
{
int position = networkHosts.size();
networkHosts.add( host );
fireNetworkHostAdded( host, position );
//dump();
}
public synchronized boolean isConnectedToHost( DestAddress address )
{
// Check for duplicate.
for (int i = 0; i < networkHosts.size(); i++)
{
Host host = networkHosts.get( i );
if ( host.getHostAddress().equals( address ) )
{// already connected
return true;
}
}
return false;
}
public synchronized void removeAllNetworkHosts()
{
Host host;
while ( networkHosts.size() > 0 )
{
host = networkHosts.get( 0 );
internalRemoveNetworkHost( host );
}
}
public synchronized void removeNetworkHosts( Host[] hosts )
{
Host host;
int length = hosts.length;
for ( int i = 0; i < length; i++ )
{
host = hosts[ i ];
internalRemoveNetworkHost( host );
}
}
public synchronized void removeNetworkHost( Host host )
{
internalRemoveNetworkHost( host );
}
/**
* Disconnects from host.
*/
private synchronized void internalRemoveNetworkHost( Host host )
{
if ( host == null )
{
return;
}
host.disconnect();
int position = networkHosts.indexOf( host );
if ( position >= 0 )
{
networkHosts.remove( position );
fireNetworkHostRemoved( host, position );
}
//dump();
}
///////////////////// START event handling methods ////////////////////////
private void fireNetworkHostAdded( Host host, int position )
{
servent.getEventService().publish( PhexEventTopics.Net_Hosts,
new ContainerEvent( ContainerEvent.Type.ADDED, host, this, position ) );
}
private void fireNetworkHostRemoved( Host host, int position )
{
servent.getEventService().publish( PhexEventTopics.Net_Hosts,
new ContainerEvent( ContainerEvent.Type.REMOVED, host, this, position ) );
}
/**
* Reacts on online status changes to initialize or save caught hosts.
*/
@EventTopicSubscriber(topic=PhexEventTopics.Servent_OnlineStatus)
public void onOnlineStatusEvent( String topic, ChangeEvent event )
{
OnlineStatus oldStatus = (OnlineStatus) event.getOldValue();
OnlineStatus newStatus = (OnlineStatus) event.getNewValue();
if ( newStatus == OnlineStatus.OFFLINE &&
oldStatus != OnlineStatus.OFFLINE )
{// switch from any online to offline status
// Disconnect all hosts
removeAllNetworkHosts();
}
}
///////////////////// END event handling methods ////////////////////////
/////////////////////////// debug ///////////////////////////////////////
/*private synchronized void dump()
{
System.out.println( "-------------- network -----------------" );
Iterator iterator = networkHosts.iterator();
while ( iterator.hasNext() )
{
System.out.println( iterator.next() );
}
System.out.println( "-------------- connected ---------------" );
iterator = connectedHosts.iterator();
while ( iterator.hasNext() )
{
System.out.println( iterator.next() );
}
System.out.println( "----------------------------------------" );
}*/
}
The table below shows all metrics for NetworkHostsContainer.java.
| Metric | Value | Description | |
|---|---|---|---|
| BLOCKS | 75.00 | Number of blocks | |
| BLOCK_COMMENT | 42.00 | Number of block comment lines | |
| COMMENTS | 188.00 | Comment lines | |
| COMMENT_DENSITY | 0.84 | Comment density | |
| COMPARISONS | 51.00 | Number of comparison operators | |
| CYCLOMATIC | 75.00 | Cyclomatic complexity | |
| DECL_COMMENTS | 31.00 | Comments in declarations | |
| DOC_COMMENT | 109.00 | Number of javadoc comment lines | |
| ELOC | 223.00 | Effective lines of code | |
| EXEC_COMMENTS | 23.00 | Comments in executable code | |
| EXITS | 52.00 | Procedure exits | |
| FUNCTIONS | 35.00 | Number of function declarations | |
| HALSTEAD_DIFFICULTY | 72.17 | Halstead difficulty | |
| HALSTEAD_EFFORT | 0.00 | Halstead effort | |
| INTERFACE_COMPLEXITY | 62.00 | Interface complexity | |
| JAVA0001 | 0.00 | JAVA0001 Package name does not contain only lower case letters | |
| JAVA0002 | 1.00 | JAVA0002 Package name does not begin with a top level domain name or country code | |
| JAVA0003 | 0.00 | JAVA0003 Minimize use of on-demand (.*) imports | |
| JAVA0004 | 0.00 | JAVA0004 Unnecessary import from java.lang | |
| JAVA0005 | 0.00 | JAVA0005 Imports not in specified order | |
| JAVA0006 | 0.00 | JAVA0006 Empty finally block | |
| JAVA0007 | 0.00 | JAVA0007 Should not declare public field | |
| JAVA0008 | 0.00 | JAVA0008 Empty catch block | |
| JAVA0009 | 0.00 | JAVA0009 Protected member in final class | |
| JAVA0010 | 0.00 | JAVA0010 Non-instantiable class does not contain a non-private static member | |
| JAVA0011 | 0.00 | JAVA0011 Abstract class does not contain an abstract method | |
| JAVA0012 | 0.00 | JAVA0012 Non-constructor method with same name as declaring class | |
| JAVA0013 | 0.00 | JAVA0013 Non-blank final field is not static | |
| JAVA0014 | 0.00 | JAVA0014 Class with only static members has non-private constructor | |
| JAVA0015 | 0.00 | JAVA0015 Package class contains public nested type | |
| JAVA0016 | 0.00 | JAVA0016 Abstract class contains public constructor | |
| JAVA0017 | 0.00 | JAVA0017 Class name does not have required form | |
| JAVA0018 | 0.00 | JAVA0018 Method name does not have required form | |
| JAVA0019 | 0.00 | JAVA0019 Interface name does not have required form | |
| JAVA0020 | 0.00 | JAVA0020 Field name does not have required form | |
| JAVA0021 | 0.00 | JAVA0021 Interface method name does not have required form | |
| JAVA0022 | 0.00 | JAVA0022 Static final field name does not have required form | |
| JAVA0023 | 0.00 | JAVA0023 Empty finalize method | |
| JAVA0024 | 0.00 | JAVA0024 Empty class | |
| JAVA0025 | 0.00 | JAVA0025 Method override is empty | |
| JAVA0026 | 0.00 | JAVA0026 Finalize method with parameters | |
| JAVA0029 | 0.00 | JAVA0029 Private method not used | |
| JAVA0030 | 0.00 | JAVA0030 Private field not used | |
| JAVA0031 | 0.00 | JAVA0031 Case statement not properly closed | |
| JAVA0032 | 0.00 | JAVA0032 Switch statement missing default | |
| JAVA0033 | 0.00 | JAVA0033 default: not last case in switch statement | |
| JAVA0034 | 0.00 | JAVA0034 Missing braces in if statement | |
| JAVA0035 | 0.00 | JAVA0035 Missing braces in for statement | |
| JAVA0036 | 0.00 | JAVA0036 Missing braces in while statement | |
| JAVA0038 | 0.00 | JAVA0038 Non-case label in switch statement | |
| JAVA0039 | 0.00 | JAVA0039 Break statement with label | |
| JAVA0040 | 0.00 | JAVA0040 Switch statement contains N cases (maximum: M) | |
| JAVA0041 | 0.00 | JAVA0041 Nested synchronized block | |
| JAVA0042 | 0.00 | JAVA0042 Empty synchronized statement | |
| JAVA0043 | 0.00 | JAVA0043 Inner class does not use outer class | |
| JAVA0044 | 0.00 | JAVA0044 Serializable class with no instance variables | |
| JAVA0045 | 0.00 | JAVA0045 Serializable class with only transient fields | |
| JAVA0046 | 0.00 | JAVA0046 Name of class not derived from Exception ends with 'Exception' | |
| JAVA0047 | 0.00 | JAVA0047 Serializable class derives from invalid base class | |
| JAVA0048 | 0.00 | JAVA0048 Name of class derived from Exception does not end with 'Exception' | |
| JAVA0049 | 0.00 | JAVA0049 Nested block at depth N (maximum: M) | |
| JAVA0050 | 0.00 | JAVA0050 Class derives from java.lang.Error | |
| JAVA0051 | 0.00 | JAVA0051 Class derives from java.lang.RuntimeException | |
| JAVA0052 | 0.00 | JAVA0052 Class derives from java.lang.Throwable | |
| JAVA0053 | 0.00 | JAVA0053 Unused label | |
| JAVA0054 | 0.00 | JAVA0054 Inheritance depth N exceeds maximum M | |
| JAVA0055 | 0.00 | JAVA0055 Class should be interface | |
| JAVA0056 | 0.00 | JAVA0056 Unnecessary abstract modifier for interface or annotation | |
| JAVA0057 | 0.00 | JAVA0057 Unnecessary default constructor | |
| JAVA0058 | 0.00 | JAVA0058 Constructor calls super() | |
| JAVA0059 | 0.00 | JAVA0059 Method override only calls super() | |
| JAVA0061 | 0.00 | JAVA0061 Inaccessible member in anonymous class | |
| JAVA0062 | 0.00 | JAVA0062 Public class missing public member or protected constructor | |
| JAVA0063 | 0.00 | JAVA0063 Identifier name should not contain '$' | |
| JAVA0064 | 0.00 | JAVA0064 N variations of identifier name (maximum: M) | |
| JAVA0065 | 0.00 | JAVA0065 Unnecessary final modifier for method in final class | |
| JAVA0066 | 0.00 | JAVA0066 Unnecessary modifier for interface nested type | |
| JAVA0067 | 0.00 | JAVA0067 Array descriptor on identifier name | |
| JAVA0068 | 1.00 | JAVA0068 Modifiers not declared in recommended order | |
| JAVA0071 | 0.00 | JAVA0071 Strings compared with == | |
| JAVA0073 | 0.00 | JAVA0073 Integer division in floating-point context | |
| JAVA0074 | 0.00 | JAVA0074 Use of Object.notify() | |
| JAVA0075 | 0.00 | JAVA0075 Method parameter hides field | |
| JAVA0076 | 0.00 | JAVA0076 Use of magic number | |
| JAVA0077 | 0.00 | JAVA0077 Private field not used in declaring class | |
| JAVA0078 | 0.00 | JAVA0078 Floating point values compared with == | |
| JAVA0079 | 0.00 | JAVA0079 Use of instance to reference static member | |
| JAVA0080 | 0.00 | JAVA0080 Import declaration not used | |
| JAVA0081 | 0.00 | JAVA0081 Boolean literal in comparison | |
| JAVA0082 | 0.00 | JAVA0082 Unnecessary widening cast | |
| JAVA0083 | 0.00 | JAVA0083 Unnecessary instanceof test | |
| JAVA0084 | 0.00 | JAVA0084 Should use compound assignment operator | |
| JAVA0085 | 0.00 | JAVA0085 Use of sun.* class | |
| JAVA0087 | 0.00 | JAVA0087 Use of Thread.sleep() | |
| JAVA0089 | 0.00 | JAVA0089 Use of restricted package | |
| JAVA0092 | 0.00 | JAVA0092 Use of restricted type | |
| JAVA0093 | 0.00 | JAVA0093 Redundant assignment | |
| JAVA0094 | 0.00 | JAVA0094 Field hides a superclass field | |
| JAVA0095 | 0.00 | JAVA0095 Uninitialized private field | |
| JAVA0096 | 0.00 | JAVA0096 Field in nested class hides outer field | |
| JAVA0098 | 0.00 | JAVA0098 Minimize use of implicit field initializers | |
| JAVA0100 | 0.00 | JAVA0100 Class contains N non-final fields (maximum: M) | |
| JAVA0101 | 0.00 | JAVA0101 Unnecessary modifier for field in interface | |
| JAVA0102 | 0.00 | JAVA0102 Last statement in finalize() not super.finalize() | |
| JAVA0103 | 0.00 | JAVA0103 Explicit call to finalize() | |
| JAVA0104 | 0.00 | JAVA0104 finalize() only calls super.finalize() | |
| JAVA0105 | 0.00 | JAVA0105 Duplicate import declaration | |
| JAVA0106 | 0.00 | JAVA0106 Unnecessary import from current package | |
| JAVA0108 | 5.00 | JAVA0108 Incorrect javadoc: no @param tag for 'parameter' | |
| JAVA0109 | 0.00 | JAVA0109 Incorrect javadoc: no parameter 'parameter' | |
| JAVA0110 | 3.00 | JAVA0110 Incorrect javadoc: no @return tag | |
| JAVA0111 | 0.00 | JAVA0111 Incorrect javadoc: @return tag for void method | |
| JAVA0112 | 0.00 | JAVA0112 Incorrect javadoc: no exception 'exception' in throws | |
| JAVA0113 | 1.00 | JAVA0113 Incorrect javadoc: no @author tag | |
| JAVA0114 | 1.00 | JAVA0114 Incorrect javadoc: no @version tag | |
| JAVA0115 | 0.00 | JAVA0115 Incorrect javadoc: no @throws or @exception tag for 'exception' | |
| JAVA0116 | 0.00 | JAVA0116 Missing javadoc: field 'field' | |
| JAVA0117 | 12.00 | JAVA0117 Missing javadoc: method 'method' | |
| JAVA0118 | 0.00 | JAVA0118 Missing javadoc: type 'type' | |
| JAVA0119 | 0.00 | JAVA0119 Control variable changed within body of for loop | |
| JAVA0123 | 0.00 | JAVA0123 Use all three components of for loop | |
| JAVA0125 | 0.00 | JAVA0125 Continue statement with label | |
| JAVA0126 | 0.00 | JAVA0126 Method declares unchecked exception in throws | |
| JAVA0128 | 0.00 | JAVA0128 Public constructor in non-public class | |
| JAVA0130 | 0.00 | JAVA0130 Non-static method does not use instance fields | |
| JAVA0131 | 0.00 | JAVA0131 Compatible method does not override base | |
| JAVA0132 | 0.00 | JAVA0132 Method overload with compatible signature | |
| JAVA0133 | 0.00 | JAVA0133 Non-synchronized method overrides synchronized method | |
| JAVA0135 | 0.00 | JAVA0135 Only one of Object.equals and Object.hashCode defined: missing 'method' | |
| JAVA0136 | 1.00 | JAVA0136 N methods defined in class (maximum: M) | |
| JAVA0137 | 0.00 | JAVA0137 Non-abstract class missing constructor | |
| JAVA0138 | 0.00 | JAVA0138 N parameters defined for method (maximum: M) | |
| JAVA0139 | 0.00 | JAVA0139 Definition of main other than public static void main(java.lang.String[]) | |
| JAVA0141 | 0.00 | JAVA0141 Unnecessary modifier for method in interface | |
| JAVA0143 | 23.00 | JAVA0143 Synchronized method | |
| JAVA0144 | 0.00 | JAVA0144 Line exceeds maximum M characters | |
| JAVA0145 | 0.00 | JAVA0145 Tab character used in source file | |
| JAVA0150 | 0.00 | JAVA0150 java.lang.Error (or subclass) thrown | |
| JAVA0153 | 0.00 | JAVA0153 Inefficient conversion of integer to string | |
| JAVA0159 | 0.00 | JAVA0159 Inefficient conversion of string to integer | |
| JAVA0160 | 0.00 | JAVA0160 Method does not throw specified exception | |
| JAVA0161 | 0.00 | JAVA0161 Conditional wait() not in loop | |
| JAVA0163 | 0.00 | JAVA0163 Empty statement | |
| JAVA0165 | 0.00 | JAVA0165 Conflicting return statement in finally block | |
| JAVA0166 | 0.00 | JAVA0166 Generic exception caught | |
| JAVA0167 | 0.00 | JAVA0167 ThreadDeath not rethrown | |
| JAVA0169 | 0.00 | JAVA0169 Unnecessary catch block: exception 'exception' | |
| JAVA0170 | 0.00 | JAVA0170 Caught exception not derived from java.lang.Exception | |
| JAVA0171 | 0.00 | JAVA0171 Unused local variable | |
| JAVA0173 | 1.00 | JAVA0173 Unused method parameter | |
| JAVA0174 | 0.00 | JAVA0174 Assigned local variable never used | |
| JAVA0175 | 0.00 | JAVA0175 Successive assignment to variable | |
| JAVA0176 | 0.00 | JAVA0176 Local variable name does not have required form | |
| JAVA0177 | 3.00 | JAVA0177 Variable declaration missing initializer | |
| JAVA0179 | 0.00 | JAVA0179 Local variable hides visible field | |
| JAVA0233 | 0.00 | JAVA0233 Definition of serialVersionUID other than 'private static final long serialVersionUID' | |
| JAVA0234 | 0.00 | JAVA0234 Class is Serializable but does not define serialVersionUID | |
| JAVA0235 | 0.00 | JAVA0235 Class defines serialVersionUID but does not implement Serializable | |
| JAVA0236 | 0.00 | JAVA0236 Attempt to clone an object which does not implement Cloneable | |
| JAVA0237 | 0.00 | JAVA0237 Class implements Cloneable but does not have public clone method | |
| JAVA0238 | 0.00 | JAVA0238 Clone method does not call super.clone() | |
| JAVA0239 | 0.00 | JAVA0239 Class declares 'readObject' or 'writeObject' but does not implement Serializable | |
| JAVA0240 | 0.00 | JAVA0240 Serializable class which declares readObject or writeObject but not both | |
| JAVA0241 | 0.00 | JAVA0241 'readObject' or 'writeObject' should be declared private in Serializable class | |
| JAVA0242 | 0.00 | JAVA0242 Transient field in non-Serializable class | |
| JAVA0243 | 0.00 | JAVA0243 'readResolve' or 'writeReplace' should be declared private or protected | |
| JAVA0244 | 0.00 | JAVA0244 Field or method name in subclass differs only by case from inherited field or method | |
| JAVA0245 | 0.00 | JAVA0245 JUnit TestCase with non-trivial constructor | |
| JAVA0246 | 0.00 | JAVA0246 JUnit assertXXX statement missing message parameter | |
| JAVA0247 | 0.00 | JAVA0247 JUnit 'setUp()' and 'tearDown()' should call super method | |
| JAVA0248 | 0.00 | JAVA0248 JUnit method 'setUp' or 'tearDown' with incorrect signature | |
| JAVA0249 | 0.00 | JAVA0249 JUnit TestCase 'suite()' should be declared static | |
| JAVA0250 | 0.00 | JAVA0250 JUnit TestCase declares testXXX method with incorrect signature | |
| JAVA0251 | 0.00 | JAVA0251 Use '%n' for line breaks in printf/format for platform independence | |
| JAVA0252 | 0.00 | JAVA0252 'enum' is a Java 1.5 reserved word | |
| JAVA0253 | 0.00 | JAVA0253 Not all enum constants consumed in switch statement | |
| JAVA0254 | 0.00 | JAVA0254 Use enhanced for loop construct instead of Iterator | |
| JAVA0255 | 0.00 | JAVA0255 Result of method invocation not used | |
| JAVA0256 | 0.00 | JAVA0256 Assignment of external collection/array to field | |
| JAVA0257 | 0.00 | JAVA0257 Use of 'Constant Interface' anti-pattern | |
| JAVA0258 | 0.00 | JAVA0258 Implement Iterable for foreach compatibility | |
| JAVA0259 | 0.00 | JAVA0259 Return of collection/array field | |
| JAVA0260 | 0.00 | JAVA0260 Use 'enum' instead of Enumerated Type pattern | |
| JAVA0261 | 0.00 | JAVA0261 Use specialized Enum collection types | |
| JAVA0262 | 0.00 | JAVA0262 Use of char in integer context | |
| JAVA0263 | 0.00 | JAVA0263 Long literal ends with 'l' instead of 'L' | |
| JAVA0264 | 0.00 | JAVA0264 Integer math in long context - check for overflow | |
| JAVA0265 | 0.00 | JAVA0265 Use of Throwable.printStackTrace() | |
| JAVA0266 | 0.00 | JAVA0266 Use of System.out | |
| JAVA0267 | 0.00 | JAVA0267 Use of System.err | |
| JAVA0269 | 0.00 | JAVA0269 Contents of StringBuffer never used | |
| JAVA0270 | 0.00 | JAVA0270 Use Java 5.0 enhanced for loop construct to iterate over all elements in an array | |
| JAVA0271 | 0.00 | JAVA0271 Minimize use of on-demand (.*) static imports | |
| JAVA0272 | 0.00 | JAVA0272 Thread.run() called | |
| JAVA0273 | 0.00 | JAVA0273 Non-final derivative of Thread calls start() in constructor | |
| JAVA0274 | 0.00 | JAVA0274 Serializable class has a synchronized readObject() | |
| JAVA0275 | 0.00 | JAVA0275 Serializable class has a synchronized writeObject() and no other synchronized methods | |
| JAVA0276 | 0.00 | JAVA0276 Unnecessary use of String constructor | |
| JAVA0277 | 0.00 | JAVA0277 Iterator.next() implementation does not throw NoSuchElementException | |
| JAVA0278 | 0.00 | JAVA0278 Unnecessary use of Boolean constructor | |
| JAVA0279 | 0.00 | JAVA0279 Serialization method readObject or readObjectNoData calls an overridable method | |
| JAVA0280 | 0.00 | JAVA0280 IllegalMonitorStateException caught | |
| JAVA0281 | 0.00 | JAVA0281 Iterator.next() not called in loop | |
| JAVA0282 | 0.00 | JAVA0282 Call to Iterator.next() in loop which does not test Iterator.hasNext() | |
| JAVA0283 | 0.00 | JAVA0283 Control variable not updated in loop body | |
| JAVA0284 | 0.00 | JAVA0284 Explicit garbage collection | |
| JAVA0285 | 0.00 | JAVA0285 Dereference of potentially null variable | |
| JAVA0286 | 0.00 | JAVA0286 Dereference of null variable | |
| JAVA0287 | 0.00 | JAVA0287 Unnecessary null check | |
| JAVA0288 | 0.00 | JAVA0288 Inconsistent null check | |
| LINES | 615.00 | Number of lines in the source file | |
| LINE_COMMENT | 37.00 | Number of line comments | |
| LOC | 371.00 | Lines of code | |
| LOGICAL_LINES | 136.00 | Number of statements | |
| LOOPS | 4.00 | Number of loops | |
| NEST_DEPTH | 5.00 | Maximum nesting depth | |
| OPERANDS | 586.00 | Number of operands | |
| OPERATORS | 1258.00 | Number of operators | |
| PARAMS | 19.00 | Number of formal parameter declarations | |
| PROGRAM_LENGTH | 1844.00 | Halstead program length | |
| PROGRAM_VOCAB | 253.00 | Halstead program vocabulary | |
| PROGRAM_VOLUME | 0.00 | Halstead program volume | |
| RETURNS | 43.00 | Number of return points from functions | |
| SIZE | 19357.00 | Size of the file in bytes | |
| UNIQUE_OPERANDS | 203.00 | Number of unique operands | |
| UNIQUE_OPERATORS | 50.00 | Number of unique operators | |
| WHITESPACE | 56.00 | Number of whitespace lines | |