PropertiesPanelUIComponent.java
| Index Score | ||
|---|---|---|
 |
 |
org.pentaho.ui.component |
 |
 |
Pentaho |
View: Reasons, Metrics, Source Code
These are the metrics that contribute to the Enerjy Score for this file, ranked by impact. So the metrics listed at the top influence the score to a greater extent that the metrics listed at the bottom.
| Metric | Description | |
|---|---|---|
| EXITS | Procedure exits |  |
| JAVA0034 | JAVA0034 Missing braces in if statement | |
| UNIQUE_OPERANDS | Number of unique operands | |
| PROGRAM_VOCAB | Halstead program vocabulary | |
| JAVA0144 | JAVA0144 Line exceeds maximum M characters | |
| OPERANDS | Number of operands | |
| LOGICAL_LINES | Number of statements | |
| JAVA0130 | JAVA0130 Non-static method does not use instance fields | |
| PROGRAM_LENGTH | Halstead program length | |
| LOOPS | Number of loops | |
| OPERATORS | Number of operators | |
| JAVA0254 | JAVA0254 Use enhanced for loop construct instead of Iterator | |
| SIZE | Size of the file in bytes | |
| NEST_DEPTH | Maximum nesting depth | |
| ELOC | Effective lines of code | |
| PROGRAM_VOLUME | Halstead program volume | |
| JAVA0259 | JAVA0259 Return of collection/array field | |
| UNIQUE_OPERATORS | Number of unique operators | |
| JAVA0080 | JAVA0080 Import declaration not used | |
| JAVA0126 | JAVA0126 Method declares unchecked exception in throws | |
| JAVA0110 | JAVA0110 Incorrect javadoc: no @return tag | |
| JAVA0171 | JAVA0171 Unused local variable | |
| LOC | Lines of code | |
| JAVA0108 | JAVA0108 Incorrect javadoc: no @param tag for 'parameter' | |
| COMMENTS | Comment lines | |
| DOC_COMMENT | Number of javadoc comment lines | |
| DECL_COMMENTS | Comments in declarations | |
| JAVA0270 | JAVA0270 Use Java 5.0 enhanced for loop construct to iterate over all elements in an array | |
| PARAMS | Number of formal parameter declarations | |
| JAVA0145 | JAVA0145 Tab character used in source file | |
/*
* Copyright 2005 Pentaho Corporation. All rights reserved.
* This software was developed by Pentaho Corporation and is provided under the terms
* of the Mozilla Public License, Version 1.1, or any later version. You may not use
* this file except in compliance with the license. If you need a copy of the license,
* please go to http://www.mozilla.org/MPL/MPL-1.1.txt. The Original Code is the Pentaho
* BI Platform. The Initial Developer is Pentaho Corporation.
*
* Software distributed under the Mozilla Public License is distributed on an "AS IS"
* basis, WITHOUT WARRANTY OF ANY KIND, either express or implied. Please refer to
* the license for the specific language governing your rights and limitations.
*
* Created Mar 14, 2006
* @author wseyler
*/
package org.pentaho.ui.component;
import java.util.Comparator;
import java.util.Enumeration;
import java.util.Iterator;
import java.util.LinkedHashMap;
import java.util.List;
import java.util.Map;
import java.util.Set;
import java.util.StringTokenizer;
import java.util.TreeMap;
import javax.servlet.http.HttpServletRequest;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
import org.dom4j.Document;
import org.dom4j.DocumentHelper;
import org.dom4j.Element;
import org.pentaho.core.repository.ISolutionRepository;
import org.pentaho.core.session.IPentahoSession;
import org.pentaho.core.solution.HttpRequestParameterProvider;
import org.pentaho.core.solution.ISolutionFile;
import org.pentaho.core.system.PentahoSystem;
import org.pentaho.core.ui.IPentahoUrlFactory;
import org.pentaho.messages.Messages;
import org.pentaho.repository.HibernateUtil;
import org.pentaho.ui.XmlComponent;
import com.pentaho.security.AcegiPermissionMgr;
import com.pentaho.security.IPermissionMask;
import com.pentaho.security.IPermissionMgr;
import com.pentaho.security.IPermissionRecipient;
import com.pentaho.security.PentahoAccessControlException;
import com.pentaho.security.SimplePermissionMask;
import com.pentaho.security.SimpleRole;
import com.pentaho.security.SimpleUser;
import com.pentaho.security.UserDetailsRoleListService;
import com.pentaho.security.acls.IAclHolder;
import com.pentaho.security.acls.IAclSolutionFile;
import com.pentaho.security.acls.PentahoAclEntry;
/**
* TODO mlowery Need to remove direct references to PentahoAclEntry permission constants. Instead, reference
* ISolutionRepository permission constants.
*/
public class PropertiesPanelUIComponent extends XmlComponent {
private static final long serialVersionUID = 1L;
private static final Log logger = LogFactory.getLog(PropertiesPanelUIComponent.class);
private static final String TYPE_PARAM = "type"; //$NON-NLS-1$
private static final String ACTION_PARAM = "action"; //$NON-NLS-1$
private static final String ADD_NAME_PARAM = "add_name"; //$NON-NLS-1$
private static final String PATH_PARAM = "path"; //$NON-NLS-1$
private static final String LIST_ACTION = "list"; //$NON-NLS-1$
private static final String ADD_BTN_PARAM = "addBtn"; //$NON-NLS-1$
private static final String UPDATE_BTN_PARAM = "updateBtn"; //$NON-NLS-1$
private static final String PERMISSION_PREFIX = "perm_"; //$NON-NLS-1$
private static final String ROLE_TYPE = "role"; //$NON-NLS-1$
private static final String ROLE_PREFIX = ROLE_TYPE + "_"; //$NON-NLS-1$
private static final String USER_TYPE = "user"; //$NON-NLS-1$
private static final String USER_PREFIX = USER_TYPE + "_"; //$NON-NLS-1$
private static final String PERMISSION_SEPERATOR = "#"; //$NON-NLS-1$
private static final String DELETE_PREFIX = "delete_"; //$NON-NLS-1$
private static final String NO_FILE_PATH_NODE_NAME = "no-file-path"; //$NON-NLS-1
private static final String SET_PERMISSIONS_DENIED_NAME = "set-permissions-denied"; //$NON-NLS-1
private static final String NO_ACLS_NODE_NAME = "no-acls"; //$NON-NLS-1$
private static final String INPUT_PAGE_NODE_NAME = "input-page"; //$NON-NLS-1$
private static final String FILE_PATH_NODE_NAME = "file-path"; //$NON-NLS-1$
private static final String IS_DIR_NODE_NAME = "is-directory"; //$NON-NLS-1$
private static final String RECIPIENTS_NODE_NAME = "recipients"; //$NON-NLS-1$
private static final String ROLE_NODE_NAME = "role"; //$NON-NLS-1$
private static final String USER_NODE_NAME = "user"; //$NON-NLS-1$
private static final String PERMISSION_NAMES_NODE_NAME = "permission-names"; //$NON-NLS-1$
private static final String NAME_NODE_NAME = "name"; //$NON-NLS-1$
private static final String ACCESS_CONTROL_LIST_NODE_NAME = "ac-list"; //$NON-NLS-1$
private static final String ACCESS_CONTROL_NODE_NAME = "access-control"; //$NON-NLS-1$
private static final String RECIPIENT_NODE_NAME = "recipient"; //$NON-NLS-1$
private static final String PERMISSION_NODE_NAME = "permission"; //$NON-NLS-1$
private static final String PERMITTED_NODE_NAME = "permitted"; //$NON-NLS-1$
private static final String EMPTY_STRING = ""; //$NON-NLS-1$
private static final String TRUE = "true"; //$NON-NLS-1$
private static final String FALSE = "false"; //$NON-NLS-1$
private static final String ON = "on"; //$NON-NLS-1$
private static final String DISPLAY_PATH_NODE_NAME = "display-path"; //$NON-NLS-1$
protected IPentahoSession session = null;
protected String baseUrl = null;
boolean includeUsers = PentahoSystem.getSystemSetting("access-ui/include-users", "true").equals("true"); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$
boolean includeRoles = PentahoSystem.getSystemSetting("access-ui/include-roles", "true").equals("true"); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$
protected ISolutionRepository repository;
private List allUsersList;
private List allRolesList;
protected UserDetailsRoleListService userDetailsRoleListService;
public PropertiesPanelUIComponent(IPentahoUrlFactory urlFactory, List messages, IPentahoSession session) {
super(urlFactory, messages, null);
this.session = session;
setXsl("text/html", "PropertiesPanel.xsl"); //$NON-NLS-1$ //$NON-NLS-2$
setXslProperty("baseUrl", urlFactory.getDisplayUrlBuilder().getUrl()); //$NON-NLS-1$
repository = PentahoSystem.getSolutionRepository(session);
if (!repository.supportsAccessControls()) {
error(Messages.getString("PropertiesPanelUIComponent.ERROR_0001_BAD_CONFIGURATION")); //$NON-NLS-1$
}
userDetailsRoleListService = PentahoSystem.getUserDetailsRoleListService();
}
public Document getXmlContent() {
if (!repository.supportsAccessControls()) {
return noACLSPage();
}
String actionStr = this.getParameter(ACTION_PARAM, EMPTY_STRING); // No
// nulls
String pathStr = this.getParameter(PATH_PARAM, null);
ISolutionFile file = null;
try {
HibernateUtil.beginTransaction();
file = repository.getFileByPath(pathStr);
} catch (Exception e) {
// do nothing since we want file to be null if it wasn't found
// TODO sbarkdull, arg, let's at least log it
}
// default action if none is passed is to list (showInputPage) the acls
if (actionStr == null || actionStr.equalsIgnoreCase(LIST_ACTION) || actionStr.equalsIgnoreCase(EMPTY_STRING)) {
HibernateUtil.commitTransaction();
if (file != null) {
return showInputPage(file);
}
return noPathPage();
} else {
HttpServletRequest request = ((HttpRequestParameterProvider) getParameterProviders().get(
HttpRequestParameterProvider.SCOPE_REQUEST)).getRequest();
if (request.getParameter(ADD_BTN_PARAM) != null && !request.getParameter(ADD_BTN_PARAM).equals("")) { //$NON-NLS-1$
doAddToAcls(file);
}
try {
if (request.getParameter(UPDATE_BTN_PARAM) != null && !request.getParameter(UPDATE_BTN_PARAM).equals("")) { //$NON-NLS-1$
doUpdateAcls(file);
}
} catch (PentahoAccessControlException e) {
HibernateUtil.rollbackTransaction();
return setPermissionsFailedPage( e.getLocalizedMessage());
}
HibernateUtil.commitTransaction();
repository.resetRepository();
if (file != null) {
return showInputPage(file);
}
return noPathPage();
}
}
private void doUpdateAcls(ISolutionFile file) throws PentahoAccessControlException {
HttpServletRequest request = ((HttpRequestParameterProvider) getParameterProviders().get(
HttpRequestParameterProvider.SCOPE_REQUEST)).getRequest();
Map permMap = new LinkedHashMap<IPermissionRecipient, IPermissionMask>();
Enumeration enum1 = request.getParameterNames();
while (enum1.hasMoreElements()) {
String name = (String) enum1.nextElement();
if (name.startsWith(USER_PREFIX) || name.startsWith(ROLE_PREFIX)) {
boolean isRole = name.startsWith(ROLE_PREFIX);
name = name.replaceFirst(isRole ? ROLE_PREFIX : USER_PREFIX, EMPTY_STRING);
String lineNumber = name.substring(name.lastIndexOf('_') + 1);
name = name.substring(0, name.lastIndexOf('_'));
if (!isFlaggedForDelete(name)) { // If this is one being deleted we don't do anything with it
PentahoAclEntry entry = new PentahoAclEntry();
IPermissionRecipient permissionRecipient = isRole ? new SimpleRole(name) : new SimpleUser(name);
SimplePermissionMask permissionMask = new SimplePermissionMask();
Enumeration enum2 = request.getParameterNames();
while (enum2.hasMoreElements()) {
String perm = (String) enum2.nextElement();
if (perm.startsWith(PERMISSION_PREFIX)) {
perm = perm.replaceFirst(PERMISSION_PREFIX, EMPTY_STRING);
String permNumber = perm.substring(perm.lastIndexOf('_') + 1);
if (permNumber.equals(lineNumber)) { // Congratulation... we have a winner!
perm = perm.substring(0, perm.lastIndexOf('_'));
permissionMask.addPermission(((Integer) PentahoAclEntry.getValidPermissionsNameMap().get(perm)).intValue());
}
}
}
permMap.put(permissionRecipient, permissionMask);
}
}
}
if (file instanceof IAclSolutionFile) {
repository.setPermissions(file, permMap);
}
}
private boolean isFlaggedForDelete(String name) {
HttpServletRequest request = ((HttpRequestParameterProvider) getParameterProviders().get(
HttpRequestParameterProvider.SCOPE_REQUEST)).getRequest();
return ON.equalsIgnoreCase(request.getParameter(DELETE_PREFIX + name));
}
private void doAddToAcls(ISolutionFile file) {
HttpServletRequest request = ((HttpRequestParameterProvider) getParameterProviders().get(
HttpRequestParameterProvider.SCOPE_REQUEST)).getRequest();
String[] names = request.getParameterValues(ADD_NAME_PARAM);
for (int i = 0; i < names.length; i++) {
String name = names[i];
IPermissionRecipient permissionRecipient = null;
if (name.startsWith(ROLE_PREFIX)) {
permissionRecipient = new SimpleRole(name.replaceFirst(ROLE_PREFIX, EMPTY_STRING));
} else {
permissionRecipient = new SimpleUser(name.replaceFirst(USER_PREFIX, EMPTY_STRING));
}
SimplePermissionMask permissionMask = new SimplePermissionMask();
Enumeration enumeration = request.getParameterNames();
while (enumeration.hasMoreElements()) {
String paramName = enumeration.nextElement().toString();
if (paramName.startsWith(PERMISSION_PREFIX)) {
String permKey = paramName.replaceFirst(PERMISSION_PREFIX, EMPTY_STRING);
StringTokenizer tokenizer = new StringTokenizer(permKey, PERMISSION_SEPERATOR);
String permName = tokenizer.nextToken();
String perm = tokenizer.nextToken();
if (permName.equals("Untitled-0")) { //$NON-NLS-1$
permissionMask.addPermission(((Integer) PentahoAclEntry.getValidPermissionsNameMap().get(perm)).intValue());
}
}
}
if (file instanceof IAclSolutionFile) {
repository.addPermission(file, permissionRecipient, permissionMask);
}
}
}
private Document noPathPage() {
Document document = DocumentHelper.createDocument();
document.addElement(NO_FILE_PATH_NODE_NAME).addText(
Messages.getString("PropertiesPanelUIComponent.USER_NO_FILE_SELECTED")); //$NON-NLS-1$
return document;
}
private Document setPermissionsFailedPage( String msg ) {
Document document = DocumentHelper.createDocument();
document.addElement(SET_PERMISSIONS_DENIED_NAME).addText( msg );
return document;
}
private Document noACLSPage() {
Document document = DocumentHelper.createDocument();
document.addElement(NO_ACLS_NODE_NAME).addText(
Messages.getString("PropertiesPanelUIComponent.ERROR_0001_BAD_CONFIGURATION")); //$NON-NLS-1$
return document;
}
protected Document showInputPage(ISolutionFile file) {
Document document = DocumentHelper.createDocument();
Element root = document.addElement(INPUT_PAGE_NODE_NAME).addText(file.getFullPath());
// Add the info for the file we're working on
root.addElement(FILE_PATH_NODE_NAME).addText(file.getFullPath());
root.addElement(DISPLAY_PATH_NODE_NAME).addText(
file.getFullPath().replaceFirst(repository.getRepositoryName(), EMPTY_STRING).replaceFirst("//", "/")); //$NON-NLS-1$//$NON-NLS-2$
root.addElement(IS_DIR_NODE_NAME).addText(file.isDirectory() ? TRUE : FALSE);
Element recipients = root.addElement(RECIPIENTS_NODE_NAME);
Iterator iter = null;
if (includeRoles) {
// Add all the possible roles
List rList = getAllRolesList();
if (rList != null) {
iter = rList.iterator();
while (iter.hasNext()) {
recipients.addElement(ROLE_NODE_NAME).addText(iter.next().toString());
}
}
}
if (includeUsers) {
// Add all the possible users
List uList = getAllUsersList();
if (uList != null) {
iter = uList.iterator();
while (iter.hasNext()) {
recipients.addElement(USER_NODE_NAME).addText(iter.next().toString());
}
}
}
// Add the names of all the permissions
Map permissionsMap = PentahoAclEntry.getValidPermissionsNameMap();
// permissionsMap.remove(Messages.getString("PentahoAclEntry.USER_SUBSCRIBE")); //$NON-NLS-1$
Iterator keyIter = permissionsMap.keySet().iterator();
Element permNames = root.addElement(PERMISSION_NAMES_NODE_NAME);
while (keyIter.hasNext()) {
permNames.addElement(NAME_NODE_NAME).addText(keyIter.next().toString());
}
Element acListNode = root.addElement(ACCESS_CONTROL_LIST_NODE_NAME);
TreeMap<IPermissionRecipient, IPermissionMask> sortedMap = new TreeMap<IPermissionRecipient, IPermissionMask>(new Comparator<IPermissionRecipient>() {
public int compare(IPermissionRecipient arg0, IPermissionRecipient arg1) {
return arg0.getName().compareTo(arg1.getName());
}
});
sortedMap.putAll(repository.getPermissions(file));
for (Map.Entry<IPermissionRecipient, IPermissionMask> mapEntry :sortedMap.entrySet()) {
IPermissionRecipient permissionRecipient = mapEntry.getKey();
Element acNode = acListNode.addElement(ACCESS_CONTROL_NODE_NAME);
Element recipientNode = acNode.addElement(RECIPIENT_NODE_NAME);
recipientNode.setText(permissionRecipient.getName());
recipientNode.addAttribute(TYPE_PARAM, (permissionRecipient instanceof SimpleRole) ? ROLE_TYPE : USER_TYPE);
// Add individual permissions for this group
for (Iterator keyIterator = permissionsMap.keySet().iterator(); keyIterator.hasNext();) {
Element aPermission = acNode.addElement(PERMISSION_NODE_NAME);
String permName = keyIterator.next().toString();
aPermission.addElement(NAME_NODE_NAME).setText(permName);
int permMask = ((Integer) permissionsMap.get(permName)).intValue();
boolean isPermitted = repository.hasAccess(permissionRecipient, file, permMask);
aPermission.addElement(PERMITTED_NODE_NAME).addText(isPermitted ? TRUE : FALSE);
}
}
return document;
}
public List getAllUsersList() {
if (allUsersList == null) {
allUsersList = userDetailsRoleListService.getAllUsers();
}
return allUsersList;
}
public List getAllRolesList() {
if (allRolesList == null) {
allRolesList = userDetailsRoleListService.getAllRoles();
}
return allRolesList;
}
public Log getLogger() {
return logger;
}
public boolean validate() {
return true;
}
}
The table below shows all metrics for PropertiesPanelUIComponent.java.
| Metric | Value | Description | |
|---|---|---|---|
| BLOCKS | 51.00 | Number of blocks | |
| BLOCK_COMMENT | 15.00 | Number of block comment lines | |
| COMMENTS | 29.00 | Comment lines | |
| COMMENT_DENSITY | 0.12 | Comment density | |
| COMPARISONS | 34.00 | Number of comparison operators | |
| CYCLOMATIC | 56.00 | Cyclomatic complexity | |
| DECL_COMMENTS | 2.00 | Comments in declarations | |
| DOC_COMMENT | 4.00 | Number of javadoc comment lines | |
| ELOC | 251.00 | Effective lines of code | |
| EXEC_COMMENTS | 9.00 | Comments in executable code | |
| EXITS | 73.00 | Procedure exits | |
| FUNCTIONS | 14.00 | Number of function declarations | |
| HALSTEAD_DIFFICULTY | 71.53 | Halstead difficulty | |
| HALSTEAD_EFFORT | 0.00 | Halstead effort | |
| INTERFACE_COMPLEXITY | 34.00 | Interface complexity | |
| JAVA0001 | 0.00 | JAVA0001 Package name does not contain only lower case letters | |
| JAVA0002 | 0.00 | JAVA0002 Package name does not begin with a top level domain name or country code | |
| JAVA0003 | 0.00 | JAVA0003 Minimize use of on-demand (.*) imports | |
| JAVA0004 | 0.00 | JAVA0004 Unnecessary import from java.lang | |
| JAVA0005 | 0.00 | JAVA0005 Imports not in specified order | |
| JAVA0006 | 0.00 | JAVA0006 Empty finally block | |
| JAVA0007 | 0.00 | JAVA0007 Should not declare public field | |
| JAVA0008 | 0.00 | JAVA0008 Empty catch block | |
| JAVA0009 | 0.00 | JAVA0009 Protected member in final class | |
| JAVA0010 | 0.00 | JAVA0010 Non-instantiable class does not contain a non-private static member | |
| JAVA0011 | 0.00 | JAVA0011 Abstract class does not contain an abstract method | |
| JAVA0012 | 0.00 | JAVA0012 Non-constructor method with same name as declaring class | |
| JAVA0013 | 0.00 | JAVA0013 Non-blank final field is not static | |
| JAVA0014 | 0.00 | JAVA0014 Class with only static members has non-private constructor | |
| JAVA0015 | 0.00 | JAVA0015 Package class contains public nested type | |
| JAVA0016 | 0.00 | JAVA0016 Abstract class contains public constructor | |
| JAVA0017 | 0.00 | JAVA0017 Class name does not have required form | |
| JAVA0018 | 0.00 | JAVA0018 Method name does not have required form | |
| JAVA0019 | 0.00 | JAVA0019 Interface name does not have required form | |
| JAVA0020 | 0.00 | JAVA0020 Field name does not have required form | |
| JAVA0021 | 0.00 | JAVA0021 Interface method name does not have required form | |
| JAVA0022 | 0.00 | JAVA0022 Static final field name does not have required form | |
| JAVA0023 | 0.00 | JAVA0023 Empty finalize method | |
| JAVA0024 | 0.00 | JAVA0024 Empty class | |
| JAVA0025 | 0.00 | JAVA0025 Method override is empty | |
| JAVA0026 | 0.00 | JAVA0026 Finalize method with parameters | |
| JAVA0029 | 0.00 | JAVA0029 Private method not used | |
| JAVA0030 | 0.00 | JAVA0030 Private field not used | |
| JAVA0031 | 0.00 | JAVA0031 Case statement not properly closed | |
| JAVA0032 | 0.00 | JAVA0032 Switch statement missing default | |
| JAVA0033 | 0.00 | JAVA0033 default: not last case in switch statement | |
| JAVA0034 | 0.00 | JAVA0034 Missing braces in if statement | |
| JAVA0035 | 0.00 | JAVA0035 Missing braces in for statement | |
| JAVA0036 | 0.00 | JAVA0036 Missing braces in while statement | |
| JAVA0038 | 0.00 | JAVA0038 Non-case label in switch statement | |
| JAVA0039 | 0.00 | JAVA0039 Break statement with label | |
| JAVA0040 | 0.00 | JAVA0040 Switch statement contains N cases (maximum: M) | |
| JAVA0041 | 0.00 | JAVA0041 Nested synchronized block | |
| JAVA0042 | 0.00 | JAVA0042 Empty synchronized statement | |
| JAVA0043 | 0.00 | JAVA0043 Inner class does not use outer class | |
| JAVA0044 | 0.00 | JAVA0044 Serializable class with no instance variables | |
| JAVA0045 | 0.00 | JAVA0045 Serializable class with only transient fields | |
| JAVA0046 | 0.00 | JAVA0046 Name of class not derived from Exception ends with 'Exception' | |
| JAVA0047 | 0.00 | JAVA0047 Serializable class derives from invalid base class | |
| JAVA0048 | 0.00 | JAVA0048 Name of class derived from Exception does not end with 'Exception' | |
| JAVA0049 | 1.00 | JAVA0049 Nested block at depth N (maximum: M) | |
| JAVA0050 | 0.00 | JAVA0050 Class derives from java.lang.Error | |
| JAVA0051 | 0.00 | JAVA0051 Class derives from java.lang.RuntimeException | |
| JAVA0052 | 0.00 | JAVA0052 Class derives from java.lang.Throwable | |
| JAVA0053 | 0.00 | JAVA0053 Unused label | |
| JAVA0054 | 1.00 | JAVA0054 Inheritance depth N exceeds maximum M | |
| JAVA0055 | 0.00 | JAVA0055 Class should be interface | |
| JAVA0056 | 0.00 | JAVA0056 Unnecessary abstract modifier for interface or annotation | |
| JAVA0057 | 0.00 | JAVA0057 Unnecessary default constructor | |
| JAVA0058 | 0.00 | JAVA0058 Constructor calls super() | |
| JAVA0059 | 0.00 | JAVA0059 Method override only calls super() | |
| JAVA0061 | 0.00 | JAVA0061 Inaccessible member in anonymous class | |
| JAVA0062 | 0.00 | JAVA0062 Public class missing public member or protected constructor | |
| JAVA0063 | 0.00 | JAVA0063 Identifier name should not contain '$' | |
| JAVA0064 | 0.00 | JAVA0064 N variations of identifier name (maximum: M) | |
| JAVA0065 | 0.00 | JAVA0065 Unnecessary final modifier for method in final class | |
| JAVA0066 | 0.00 | JAVA0066 Unnecessary modifier for interface nested type | |
| JAVA0067 | 0.00 | JAVA0067 Array descriptor on identifier name | |
| JAVA0068 | 0.00 | JAVA0068 Modifiers not declared in recommended order | |
| JAVA0071 | 0.00 | JAVA0071 Strings compared with == | |
| JAVA0073 | 0.00 | JAVA0073 Integer division in floating-point context | |
| JAVA0074 | 0.00 | JAVA0074 Use of Object.notify() | |
| JAVA0075 | 0.00 | JAVA0075 Method parameter hides field | |
| JAVA0076 | 0.00 | JAVA0076 Use of magic number | |
| JAVA0077 | 0.00 | JAVA0077 Private field not used in declaring class | |
| JAVA0078 | 0.00 | JAVA0078 Floating point values compared with == | |
| JAVA0079 | 0.00 | JAVA0079 Use of instance to reference static member | |
| JAVA0080 | 4.00 | JAVA0080 Import declaration not used | |
| JAVA0081 | 0.00 | JAVA0081 Boolean literal in comparison | |
| JAVA0082 | 0.00 | JAVA0082 Unnecessary widening cast | |
| JAVA0083 | 0.00 | JAVA0083 Unnecessary instanceof test | |
| JAVA0084 | 0.00 | JAVA0084 Should use compound assignment operator | |
| JAVA0085 | 0.00 | JAVA0085 Use of sun.* class | |
| JAVA0087 | 0.00 | JAVA0087 Use of Thread.sleep() | |
| JAVA0089 | 0.00 | JAVA0089 Use of restricted package | |
| JAVA0092 | 0.00 | JAVA0092 Use of restricted type | |
| JAVA0093 | 0.00 | JAVA0093 Redundant assignment | |
| JAVA0094 | 0.00 | JAVA0094 Field hides a superclass field | |
| JAVA0095 | 0.00 | JAVA0095 Uninitialized private field | |
| JAVA0096 | 0.00 | JAVA0096 Field in nested class hides outer field | |
| JAVA0098 | 0.00 | JAVA0098 Minimize use of implicit field initializers | |
| JAVA0100 | 0.00 | JAVA0100 Class contains N non-final fields (maximum: M) | |
| JAVA0101 | 0.00 | JAVA0101 Unnecessary modifier for field in interface | |
| JAVA0102 | 0.00 | JAVA0102 Last statement in finalize() not super.finalize() | |
| JAVA0103 | 0.00 | JAVA0103 Explicit call to finalize() | |
| JAVA0104 | 0.00 | JAVA0104 finalize() only calls super.finalize() | |
| JAVA0105 | 0.00 | JAVA0105 Duplicate import declaration | |
| JAVA0106 | 0.00 | JAVA0106 Unnecessary import from current package | |
| JAVA0108 | 0.00 | JAVA0108 Incorrect javadoc: no @param tag for 'parameter' | |
| JAVA0109 | 0.00 | JAVA0109 Incorrect javadoc: no parameter 'parameter' | |
| JAVA0110 | 0.00 | JAVA0110 Incorrect javadoc: no @return tag | |
| JAVA0111 | 0.00 | JAVA0111 Incorrect javadoc: @return tag for void method | |
| JAVA0112 | 0.00 | JAVA0112 Incorrect javadoc: no exception 'exception' in throws | |
| JAVA0113 | 1.00 | JAVA0113 Incorrect javadoc: no @author tag | |
| JAVA0114 | 1.00 | JAVA0114 Incorrect javadoc: no @version tag | |
| JAVA0115 | 0.00 | JAVA0115 Incorrect javadoc: no @throws or @exception tag for 'exception' | |
| JAVA0116 | 0.00 | JAVA0116 Missing javadoc: field 'field' | |
| JAVA0117 | 4.00 | JAVA0117 Missing javadoc: method 'method' | |
| JAVA0118 | 0.00 | JAVA0118 Missing javadoc: type 'type' | |
| JAVA0119 | 0.00 | JAVA0119 Control variable changed within body of for loop | |
| JAVA0123 | 0.00 | JAVA0123 Use all three components of for loop | |
| JAVA0125 | 0.00 | JAVA0125 Continue statement with label | |
| JAVA0126 | 0.00 | JAVA0126 Method declares unchecked exception in throws | |
| JAVA0128 | 0.00 | JAVA0128 Public constructor in non-public class | |
| JAVA0130 | 3.00 | JAVA0130 Non-static method does not use instance fields | |
| JAVA0131 | 0.00 | JAVA0131 Compatible method does not override base | |
| JAVA0132 | 0.00 | JAVA0132 Method overload with compatible signature | |
| JAVA0133 | 0.00 | JAVA0133 Non-synchronized method overrides synchronized method | |
| JAVA0135 | 0.00 | JAVA0135 Only one of Object.equals and Object.hashCode defined: missing 'method' | |
| JAVA0136 | 0.00 | JAVA0136 N methods defined in class (maximum: M) | |
| JAVA0137 | 0.00 | JAVA0137 Non-abstract class missing constructor | |
| JAVA0138 | 0.00 | JAVA0138 N parameters defined for method (maximum: M) | |
| JAVA0139 | 0.00 | JAVA0139 Definition of main other than public static void main(java.lang.String[]) | |
| JAVA0141 | 0.00 | JAVA0141 Unnecessary modifier for method in interface | |
| JAVA0143 | 0.00 | JAVA0143 Synchronized method | |
| JAVA0144 | 4.00 | JAVA0144 Line exceeds maximum M characters | |
| JAVA0145 | 8.00 | JAVA0145 Tab character used in source file | |
| JAVA0150 | 0.00 | JAVA0150 java.lang.Error (or subclass) thrown | |
| JAVA0153 | 0.00 | JAVA0153 Inefficient conversion of integer to string | |
| JAVA0159 | 0.00 | JAVA0159 Inefficient conversion of string to integer | |
| JAVA0160 | 0.00 | JAVA0160 Method does not throw specified exception | |
| JAVA0161 | 0.00 | JAVA0161 Conditional wait() not in loop | |
| JAVA0163 | 0.00 | JAVA0163 Empty statement | |
| JAVA0165 | 0.00 | JAVA0165 Conflicting return statement in finally block | |
| JAVA0166 | 1.00 | JAVA0166 Generic exception caught | |
| JAVA0167 | 0.00 | JAVA0167 ThreadDeath not rethrown | |
| JAVA0169 | 0.00 | JAVA0169 Unnecessary catch block: exception 'exception' | |
| JAVA0170 | 0.00 | JAVA0170 Caught exception not derived from java.lang.Exception | |
| JAVA0171 | 1.00 | JAVA0171 Unused local variable | |
| JAVA0173 | 0.00 | JAVA0173 Unused method parameter | |
| JAVA0174 | 0.00 | JAVA0174 Assigned local variable never used | |
| JAVA0175 | 0.00 | JAVA0175 Successive assignment to variable | |
| JAVA0176 | 0.00 | JAVA0176 Local variable name does not have required form | |
| JAVA0177 | 0.00 | JAVA0177 Variable declaration missing initializer | |
| JAVA0179 | 0.00 | JAVA0179 Local variable hides visible field | |
| JAVA0233 | 0.00 | JAVA0233 Definition of serialVersionUID other than 'private static final long serialVersionUID' | |
| JAVA0234 | 0.00 | JAVA0234 Class is Serializable but does not define serialVersionUID | |
| JAVA0235 | 0.00 | JAVA0235 Class defines serialVersionUID but does not implement Serializable | |
| JAVA0236 | 0.00 | JAVA0236 Attempt to clone an object which does not implement Cloneable | |
| JAVA0237 | 0.00 | JAVA0237 Class implements Cloneable but does not have public clone method | |
| JAVA0238 | 0.00 | JAVA0238 Clone method does not call super.clone() | |
| JAVA0239 | 0.00 | JAVA0239 Class declares 'readObject' or 'writeObject' but does not implement Serializable | |
| JAVA0240 | 0.00 | JAVA0240 Serializable class which declares readObject or writeObject but not both | |
| JAVA0241 | 0.00 | JAVA0241 'readObject' or 'writeObject' should be declared private in Serializable class | |
| JAVA0242 | 0.00 | JAVA0242 Transient field in non-Serializable class | |
| JAVA0243 | 0.00 | JAVA0243 'readResolve' or 'writeReplace' should be declared private or protected | |
| JAVA0244 | 0.00 | JAVA0244 Field or method name in subclass differs only by case from inherited field or method | |
| JAVA0245 | 0.00 | JAVA0245 JUnit TestCase with non-trivial constructor | |
| JAVA0246 | 0.00 | JAVA0246 JUnit assertXXX statement missing message parameter | |
| JAVA0247 | 0.00 | JAVA0247 JUnit 'setUp()' and 'tearDown()' should call super method | |
| JAVA0248 | 0.00 | JAVA0248 JUnit method 'setUp' or 'tearDown' with incorrect signature | |
| JAVA0249 | 0.00 | JAVA0249 JUnit TestCase 'suite()' should be declared static | |
| JAVA0250 | 0.00 | JAVA0250 JUnit TestCase declares testXXX method with incorrect signature | |
| JAVA0251 | 0.00 | JAVA0251 Use '%n' for line breaks in printf/format for platform independence | |
| JAVA0252 | 0.00 | JAVA0252 'enum' is a Java 1.5 reserved word | |
| JAVA0253 | 0.00 | JAVA0253 Not all enum constants consumed in switch statement | |
| JAVA0254 | 2.00 | JAVA0254 Use enhanced for loop construct instead of Iterator | |
| JAVA0255 | 0.00 | JAVA0255 Result of method invocation not used | |
| JAVA0256 | 0.00 | JAVA0256 Assignment of external collection/array to field | |
| JAVA0257 | 0.00 | JAVA0257 Use of 'Constant Interface' anti-pattern | |
| JAVA0258 | 0.00 | JAVA0258 Implement Iterable for foreach compatibility | |
| JAVA0259 | 2.00 | JAVA0259 Return of collection/array field | |
| JAVA0260 | 0.00 | JAVA0260 Use 'enum' instead of Enumerated Type pattern | |
| JAVA0261 | 0.00 | JAVA0261 Use specialized Enum collection types | |
| JAVA0262 | 0.00 | JAVA0262 Use of char in integer context | |
| JAVA0263 | 0.00 | JAVA0263 Long literal ends with 'l' instead of 'L' | |
| JAVA0264 | 0.00 | JAVA0264 Integer math in long context - check for overflow | |
| JAVA0265 | 0.00 | JAVA0265 Use of Throwable.printStackTrace() | |
| JAVA0266 | 0.00 | JAVA0266 Use of System.out | |
| JAVA0267 | 0.00 | JAVA0267 Use of System.err | |
| JAVA0269 | 0.00 | JAVA0269 Contents of StringBuffer never used | |
| JAVA0270 | 1.00 | JAVA0270 Use Java 5.0 enhanced for loop construct to iterate over all elements in an array | |
| JAVA0271 | 0.00 | JAVA0271 Minimize use of on-demand (.*) static imports | |
| JAVA0272 | 0.00 | JAVA0272 Thread.run() called | |
| JAVA0273 | 0.00 | JAVA0273 Non-final derivative of Thread calls start() in constructor | |
| JAVA0274 | 0.00 | JAVA0274 Serializable class has a synchronized readObject() | |
| JAVA0275 | 0.00 | JAVA0275 Serializable class has a synchronized writeObject() and no other synchronized methods | |
| JAVA0276 | 0.00 | JAVA0276 Unnecessary use of String constructor | |
| JAVA0277 | 0.00 | JAVA0277 Iterator.next() implementation does not throw NoSuchElementException | |
| JAVA0278 | 0.00 | JAVA0278 Unnecessary use of Boolean constructor | |
| JAVA0279 | 0.00 | JAVA0279 Serialization method readObject or readObjectNoData calls an overridable method | |
| JAVA0280 | 0.00 | JAVA0280 IllegalMonitorStateException caught | |
| JAVA0281 | 0.00 | JAVA0281 Iterator.next() not called in loop | |
| JAVA0282 | 0.00 | JAVA0282 Call to Iterator.next() in loop which does not test Iterator.hasNext() | |
| JAVA0283 | 0.00 | JAVA0283 Control variable not updated in loop body | |
| JAVA0284 | 0.00 | JAVA0284 Explicit garbage collection | |
| JAVA0285 | 0.00 | JAVA0285 Dereference of potentially null variable | |
| JAVA0286 | 0.00 | JAVA0286 Dereference of null variable | |
| JAVA0287 | 0.00 | JAVA0287 Unnecessary null check | |
| JAVA0288 | 0.00 | JAVA0288 Inconsistent null check | |
| LINES | 405.00 | Number of lines in the source file | |
| LINE_COMMENT | 10.00 | Number of line comments | |
| LOC | 299.00 | Lines of code | |
| LOGICAL_LINES | 195.00 | Number of statements | |
| LOOPS | 8.00 | Number of loops | |
| NEST_DEPTH | 7.00 | Maximum nesting depth | |
| OPERANDS | 915.00 | Number of operands | |
| OPERATORS | 1552.00 | Number of operators | |
| PARAMS | 10.00 | Number of formal parameter declarations | |
| PROGRAM_LENGTH | 2467.00 | Halstead program length | |
| PROGRAM_VOCAB | 355.00 | Halstead program vocabulary | |
| PROGRAM_VOLUME | 0.00 | Halstead program volume | |
| RETURNS | 24.00 | Number of return points from functions | |
| SIZE | 17056.00 | Size of the file in bytes | |
| UNIQUE_OPERANDS | 307.00 | Number of unique operands | |
| UNIQUE_OPERATORS | 48.00 | Number of unique operators | |
| WHITESPACE | 77.00 | Number of whitespace lines | |