ClientThread.java
| Index Score | ||
|---|---|---|
 |
 |
net.sf.l2j.loginserver |
 |
 |
L2J |
View: Reasons, Metrics, Source Code
These are the metrics that contribute to the Enerjy Score for this file, ranked by impact. So the metrics listed at the top influence the score to a greater extent that the metrics listed at the bottom.
| Metric | Description | |
|---|---|---|
| JAVA0020 | JAVA0020 Field name does not have required form |  |
| JAVA0076 | JAVA0076 Use of magic number | |
| JAVA0034 | JAVA0034 Missing braces in if statement | |
| LOOPS | Number of loops | |
| EXITS | Procedure exits | |
| JAVA0031 | JAVA0031 Case statement not properly closed | |
| JAVA0049 | JAVA0049 Nested block at depth N (maximum: M) | |
| NEST_DEPTH | Maximum nesting depth | |
| UNIQUE_OPERATORS | Number of unique operators | |
| JAVA0130 | JAVA0130 Non-static method does not use instance fields | |
| LOGICAL_LINES | Number of statements | |
| JAVA0166 | JAVA0166 Generic exception caught | |
| PROGRAM_VOCAB | Halstead program vocabulary | |
| PROGRAM_VOLUME | Halstead program volume | |
| JAVA0126 | JAVA0126 Method declares unchecked exception in throws | |
| JAVA0273 | JAVA0273 Non-final derivative of Thread calls start() in constructor | |
| JAVA0110 | JAVA0110 Incorrect javadoc: no @return tag | |
| UNIQUE_OPERANDS | Number of unique operands | |
| JAVA0171 | JAVA0171 Unused local variable | |
| JAVA0265 | JAVA0265 Use of Throwable.printStackTrace() | |
| LINE_COMMENT | Number of line comments | |
| JAVA0117 | JAVA0117 Missing javadoc: method 'method' | |
| JAVA0029 | JAVA0029 Private method not used | |
| EXEC_COMMENTS | Comments in executable code | |
| BLOCK_COMMENT | Number of block comment lines | |
| JAVA0100 | JAVA0100 Class contains N non-final fields (maximum: M) | |
| DOC_COMMENT | Number of javadoc comment lines | |
| DECL_COMMENTS | Comments in declarations | |
| FUNCTIONS | Number of function declarations | |
| RETURNS | Number of return points from functions | |
| INTERFACE_COMPLEXITY | Interface complexity | |
| OPERANDS | Number of operands | |
/*
* $Header: /cvsroot/l2j/L2_Gameserver/java/net/sf/l2j/loginserver/ClientThread.java,v 1.15 2004/11/19 08:54:43 l2chef Exp $
*
* $Author: l2chef $
* $Date: 2004/11/19 08:54:43 $
* $Revision: 1.15 $
* $Log: ClientThread.java,v $
* Revision 1.15 2004/11/19 08:54:43 l2chef
* database is now used
*
* Revision 1.14 2004/09/26 00:17:58 l2chef
* hacking protection added. IP banning added
*
* Revision 1.13 2004/09/16 18:59:20 nuocnam
* Old connection is dropped if you try to log in and account is already in use. (nuocnam)
*
* Revision 1.12 2004/08/01 22:39:05 l2chef
* testserver flag possible
*
* Revision 1.11 2004/07/19 23:11:09 l2chef
* accounts can be banned if accesslevel is set to negative value (Deth)
*
* Revision 1.10 2004/07/13 23:17:33 l2chef
* empty blocks commented
*
* Revision 1.9 2004/07/11 11:45:36 l2chef
* no limit on client packet size
*
* Revision 1.8 2004/07/05 23:02:32 l2chef
* access levels are stored for logins
*
* Revision 1.7 2004/07/05 20:24:52 l2chef
* better handling of incoming corrupt data
*
* Revision 1.6 2004/07/04 19:04:39 l2chef
* dont log password
*
* Revision 1.5 2004/07/04 11:15:23 l2chef
* logging is used instead of system.out
*
* Revision 1.4 2004/06/29 22:55:00 l2chef
* binding ips can be defined independent of public server hostname
*
* Revision 1.3 2004/06/27 08:51:43 jeichhorn
* Added copyright notice
*
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2, or (at your option)
* any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA
* 02111-1307, USA.
*
* http://www.gnu.org/copyleft/gpl.html
*/
package net.sf.l2j.loginserver;
import java.io.BufferedOutputStream;
import java.io.IOException;
import java.io.InputStream;
import java.io.OutputStream;
import java.net.InetAddress;
import java.net.Socket;
import java.util.ArrayList;
import java.util.List;
import java.util.logging.Logger;
import net.sf.l2j.loginserver.clientpackets.RequestAuthLogin;
import net.sf.l2j.loginserver.clientpackets.RequestServerList;
import net.sf.l2j.loginserver.clientpackets.RequestServerLogin;
import net.sf.l2j.loginserver.serverpackets.Init;
import net.sf.l2j.loginserver.serverpackets.LoginFail;
import net.sf.l2j.loginserver.serverpackets.LoginOk;
import net.sf.l2j.loginserver.serverpackets.PlayOk;
import net.sf.l2j.loginserver.serverpackets.ServerBasePacket;
import net.sf.l2j.loginserver.serverpackets.ServerList;
/**
* This class ...
*
* @version $Revision: 1.15 $ $Date: 2004/11/19 08:54:43 $
*/
public class ClientThread extends Thread
{
static Logger _log = Logger.getLogger(ClientThread.class.getName());
private InputStream _in;
private OutputStream _out;
private NewCrypt _crypt;
private Logins _logins;
private Socket _csocket;
private String _gameServerHost;
private int _gameServerPort;
private static List _bannedIPs = new ArrayList();
public ClientThread(Socket client, Logins logins, String host, int port) throws IOException
{
_csocket = client;
String ip = client.getInetAddress().getHostAddress();
if (_bannedIPs.contains(ip))
{
throw new IOException("banned IP");
}
_in = client.getInputStream();
_out = new BufferedOutputStream(client.getOutputStream());
_crypt = new NewCrypt("[;'.]94-31==-%&@!^+]\000");
_logins = logins;
_gameServerHost = host;
_gameServerPort = port;
start();
}
public void run()
{
_log.fine("loginserver thread[C] started");
int lengthHi =0;
int lengthLo =0;
int length = 0;
boolean checksumOk = false;
int sessionKey = -1;
String account = null;
String gameServerIp = null;
try
{
// external ip address gets resolved again for each new connection
// this should help users with dynamic IPs
InetAddress adr = InetAddress.getByName(_gameServerHost);
gameServerIp = adr.getHostAddress();
Init startPacket = new Init();
_out.write(startPacket.getLength() & 0xff);
_out.write(startPacket.getLength() >> 8 &0xff);
_out.write(startPacket.getContent());
_out.flush();
while (true)
{
lengthLo = _in.read();
lengthHi = _in.read();
length= lengthHi*256 + lengthLo;
if (lengthHi < 0 )
{
_log.warning("Client terminated the connection.");
break;
}
byte[] incoming = new byte[length];
incoming[0] = (byte) lengthLo;
incoming[1] = (byte) lengthHi;
int receivedBytes = 0;
int newBytes = 0;
while (newBytes != -1 && receivedBytes<length-2)
{
newBytes = _in.read(incoming, 2, length-2);
receivedBytes = receivedBytes + newBytes;
}
if (receivedBytes != length-2)
{
_log.warning("Incomplete Packet is sent to the server, closing connection.");
break;
}
byte[] decrypt = new byte[length - 2];
System.arraycopy(incoming, 2, decrypt, 0, decrypt.length);
// decrypt if we have a key
decrypt = _crypt.decrypt(decrypt);
checksumOk = _crypt.checksum(decrypt);
_log.finest("[C]\n"+printData(decrypt, decrypt.length));
int packetType = decrypt[0]&0xff;
switch (packetType)
{
case 00:
{
RequestAuthLogin ral = new RequestAuthLogin(decrypt);
account = ral.getUser().toLowerCase();
_log.fine("RequestAuthLogin from user:" + account);
LoginController lc = LoginController.getInstance();
if (_logins.loginValid(account, ral.getPassword(), _csocket.getInetAddress()))
{
if (!lc.isAccountInGameServer(account) && !lc.isAccountInLoginServer(account) )
{
sessionKey = lc.assignSessionKeyToLogin(account, _csocket);
_log.fine("assigned SessionKey:" + Integer.toHexString(sessionKey));
LoginOk lok = new LoginOk();
sendPacket(lok);
}
else
{
_log.fine("KICKING!");
if (lc.isAccountInLoginServer(account)) {
_log.warning("account is in use on Login server (kicking off):" + account);
lc.getLoginServerConnection(account).close();
lc.removeLoginServerLogin(account);
}
if (lc.isAccountInGameServer(account)) {
_log.warning("account is in use on Gamea server (kicking off):" + account);
lc.getClientConnection(account).close();
lc.removeGameServerLogin(account);
}
LoginFail lok = new LoginFail(LoginFail.REASON_ACCOUNT_IN_USE);
sendPacket(lok);
}
}
else
{
LoginFail lok = new LoginFail(LoginFail.REASON_USER_OR_PASS_WRONG);
sendPacket(lok);
}
break;
}
case 02:
{
_log.fine("RequestServerLogin");
RequestServerLogin rsl = new RequestServerLogin(decrypt);
_log.fine("login to server:" + rsl.getData3());
//PlayFail po = new PlayFail(PlayFail.REASON_TOO_MANY_PLAYERS);
PlayOk po = new PlayOk(sessionKey);
sendPacket(po);
break;
}
case 05:
{
_log.fine("RequestServerList");
RequestServerList rsl = new RequestServerList(decrypt);
ServerList sl = new ServerList();
int current = LoginController.getInstance().getOnlinePlayerCount();
int max = LoginController.getInstance().getMaxAllowedOnlinePlayers();
sl.addServer(gameServerIp, _gameServerPort, true, false, current, max);
sendPacket(sl);
break;
}
default:
{
_log.warning("Unknown Packet:" + packetType);
_log.warning(printData(decrypt, decrypt.length));
}
}
}
}
catch (HackingException e)
{
_bannedIPs.add(e.getIP());
}
catch (Exception e)
{
e.printStackTrace();
}
finally
{
try
{
_csocket.close();
}
catch (Exception e1)
{
// ignore problems
}
LoginController.getInstance().removeLoginServerLogin(account);
_log.fine("loginserver thread[C] stopped");
}
}
/**
* @param sl
* @throws IOException
*/
private void sendPacket(ServerBasePacket sl) throws IOException
{
byte[] data = sl.getContent();
_crypt.checksum(data);
_log.finest("[S]\n"+printData(data, data.length));
data = _crypt.crypt(data);
int len = data.length+2;
_out.write(len & 0xff);
_out.write(len >> 8 &0xff);
_out.write(data);
_out.flush();
}
private String printData(byte[] data, int len)
{
StringBuffer result = new StringBuffer();
int counter = 0;
for (int i=0;i< len;i++)
{
if (counter % 16 == 0)
{
result.append(fillHex(i,4)+": ");
}
result.append(fillHex(data[i] & 0xff, 2) + " ");
counter++;
if (counter == 16)
{
result.append(" ");
int charpoint = i-15;
for (int a=0; a<16;a++)
{
int t1 = data[charpoint++];
if (t1 > 0x1f && t1 < 0x80)
{
result.append((char)t1);
}
else
{
result.append('.');
}
}
result.append("\n");
counter = 0;
}
}
int rest = data.length % 16;
if (rest > 0 )
{
for (int i=0; i<17-rest;i++ )
{
result.append(" ");
}
int charpoint = data.length-rest;
for (int a=0; a<rest;a++)
{
int t1 = data[charpoint++];
if (t1 > 0x1f && t1 < 0x80)
{
result.append((char)t1);
}
else
{
result.append('.');
}
}
result.append("\n");
}
return result.toString();
}
private String fillHex(int data, int digits)
{
String number = Integer.toHexString(data);
for (int i=number.length(); i< digits; i++)
{
number = "0" + number;
}
return number;
}
private String getTerminatedString( byte[] data, int offset )
{
StringBuffer result = new StringBuffer();
for( int i=offset; i<data.length; i++)
{
if( data[i] == 0x00 )
{
break;
}
result.append( (char) data[i] );
}
return result.toString();
}
/**
* @param line
*/
public static void addBannedIP(String ip)
{
_bannedIPs.add(ip);
}
}
The table below shows all metrics for ClientThread.java.
| Metric | Value | Description | |
|---|---|---|---|
| BLOCKS | 42.00 | Number of blocks | |
| BLOCK_COMMENT | 64.00 | Number of block comment lines | |
| COMMENTS | 81.00 | Comment lines | |
| COMMENT_DENSITY | 0.42 | Comment density | |
| COMPARISONS | 32.00 | Number of comparison operators | |
| CYCLOMATIC | 39.00 | Cyclomatic complexity | |
| DECL_COMMENTS | 4.00 | Comments in declarations | |
| DOC_COMMENT | 12.00 | Number of javadoc comment lines | |
| ELOC | 195.00 | Effective lines of code | |
| EXEC_COMMENTS | 4.00 | Comments in executable code | |
| EXITS | 53.00 | Procedure exits | |
| FUNCTIONS | 7.00 | Number of function declarations | |
| HALSTEAD_DIFFICULTY | 82.70 | Halstead difficulty | |
| HALSTEAD_EFFORT | 0.00 | Halstead effort | |
| INTERFACE_COMPLEXITY | 28.00 | Interface complexity | |
| JAVA0001 | 1.00 | JAVA0001 Package name does not contain only lower case letters | |
| JAVA0002 | 0.00 | JAVA0002 Package name does not begin with a top level domain name or country code | |
| JAVA0003 | 0.00 | JAVA0003 Minimize use of on-demand (.*) imports | |
| JAVA0004 | 0.00 | JAVA0004 Unnecessary import from java.lang | |
| JAVA0005 | 0.00 | JAVA0005 Imports not in specified order | |
| JAVA0006 | 0.00 | JAVA0006 Empty finally block | |
| JAVA0007 | 0.00 | JAVA0007 Should not declare public field | |
| JAVA0008 | 0.00 | JAVA0008 Empty catch block | |
| JAVA0009 | 0.00 | JAVA0009 Protected member in final class | |
| JAVA0010 | 0.00 | JAVA0010 Non-instantiable class does not contain a non-private static member | |
| JAVA0011 | 0.00 | JAVA0011 Abstract class does not contain an abstract method | |
| JAVA0012 | 0.00 | JAVA0012 Non-constructor method with same name as declaring class | |
| JAVA0013 | 0.00 | JAVA0013 Non-blank final field is not static | |
| JAVA0014 | 0.00 | JAVA0014 Class with only static members has non-private constructor | |
| JAVA0015 | 0.00 | JAVA0015 Package class contains public nested type | |
| JAVA0016 | 0.00 | JAVA0016 Abstract class contains public constructor | |
| JAVA0017 | 0.00 | JAVA0017 Class name does not have required form | |
| JAVA0018 | 0.00 | JAVA0018 Method name does not have required form | |
| JAVA0019 | 0.00 | JAVA0019 Interface name does not have required form | |
| JAVA0020 | 7.00 | JAVA0020 Field name does not have required form | |
| JAVA0021 | 0.00 | JAVA0021 Interface method name does not have required form | |
| JAVA0022 | 0.00 | JAVA0022 Static final field name does not have required form | |
| JAVA0023 | 0.00 | JAVA0023 Empty finalize method | |
| JAVA0024 | 0.00 | JAVA0024 Empty class | |
| JAVA0025 | 0.00 | JAVA0025 Method override is empty | |
| JAVA0026 | 0.00 | JAVA0026 Finalize method with parameters | |
| JAVA0029 | 1.00 | JAVA0029 Private method not used | |
| JAVA0030 | 0.00 | JAVA0030 Private field not used | |
| JAVA0031 | 1.00 | JAVA0031 Case statement not properly closed | |
| JAVA0032 | 0.00 | JAVA0032 Switch statement missing default | |
| JAVA0033 | 0.00 | JAVA0033 default: not last case in switch statement | |
| JAVA0034 | 0.00 | JAVA0034 Missing braces in if statement | |
| JAVA0035 | 0.00 | JAVA0035 Missing braces in for statement | |
| JAVA0036 | 0.00 | JAVA0036 Missing braces in while statement | |
| JAVA0038 | 0.00 | JAVA0038 Non-case label in switch statement | |
| JAVA0039 | 0.00 | JAVA0039 Break statement with label | |
| JAVA0040 | 0.00 | JAVA0040 Switch statement contains N cases (maximum: M) | |
| JAVA0041 | 0.00 | JAVA0041 Nested synchronized block | |
| JAVA0042 | 0.00 | JAVA0042 Empty synchronized statement | |
| JAVA0043 | 0.00 | JAVA0043 Inner class does not use outer class | |
| JAVA0044 | 0.00 | JAVA0044 Serializable class with no instance variables | |
| JAVA0045 | 0.00 | JAVA0045 Serializable class with only transient fields | |
| JAVA0046 | 0.00 | JAVA0046 Name of class not derived from Exception ends with 'Exception' | |
| JAVA0047 | 0.00 | JAVA0047 Serializable class derives from invalid base class | |
| JAVA0048 | 0.00 | JAVA0048 Name of class derived from Exception does not end with 'Exception' | |
| JAVA0049 | 2.00 | JAVA0049 Nested block at depth N (maximum: M) | |
| JAVA0050 | 0.00 | JAVA0050 Class derives from java.lang.Error | |
| JAVA0051 | 0.00 | JAVA0051 Class derives from java.lang.RuntimeException | |
| JAVA0052 | 0.00 | JAVA0052 Class derives from java.lang.Throwable | |
| JAVA0053 | 0.00 | JAVA0053 Unused label | |
| JAVA0054 | 0.00 | JAVA0054 Inheritance depth N exceeds maximum M | |
| JAVA0055 | 0.00 | JAVA0055 Class should be interface | |
| JAVA0056 | 0.00 | JAVA0056 Unnecessary abstract modifier for interface or annotation | |
| JAVA0057 | 0.00 | JAVA0057 Unnecessary default constructor | |
| JAVA0058 | 0.00 | JAVA0058 Constructor calls super() | |
| JAVA0059 | 0.00 | JAVA0059 Method override only calls super() | |
| JAVA0061 | 0.00 | JAVA0061 Inaccessible member in anonymous class | |
| JAVA0062 | 0.00 | JAVA0062 Public class missing public member or protected constructor | |
| JAVA0063 | 0.00 | JAVA0063 Identifier name should not contain '$' | |
| JAVA0064 | 0.00 | JAVA0064 N variations of identifier name (maximum: M) | |
| JAVA0065 | 0.00 | JAVA0065 Unnecessary final modifier for method in final class | |
| JAVA0066 | 0.00 | JAVA0066 Unnecessary modifier for interface nested type | |
| JAVA0067 | 0.00 | JAVA0067 Array descriptor on identifier name | |
| JAVA0068 | 0.00 | JAVA0068 Modifiers not declared in recommended order | |
| JAVA0071 | 0.00 | JAVA0071 Strings compared with == | |
| JAVA0073 | 0.00 | JAVA0073 Integer division in floating-point context | |
| JAVA0074 | 0.00 | JAVA0074 Use of Object.notify() | |
| JAVA0075 | 0.00 | JAVA0075 Method parameter hides field | |
| JAVA0076 | 16.00 | JAVA0076 Use of magic number | |
| JAVA0077 | 0.00 | JAVA0077 Private field not used in declaring class | |
| JAVA0078 | 0.00 | JAVA0078 Floating point values compared with == | |
| JAVA0079 | 0.00 | JAVA0079 Use of instance to reference static member | |
| JAVA0080 | 0.00 | JAVA0080 Import declaration not used | |
| JAVA0081 | 0.00 | JAVA0081 Boolean literal in comparison | |
| JAVA0082 | 0.00 | JAVA0082 Unnecessary widening cast | |
| JAVA0083 | 0.00 | JAVA0083 Unnecessary instanceof test | |
| JAVA0084 | 1.00 | JAVA0084 Should use compound assignment operator | |
| JAVA0085 | 0.00 | JAVA0085 Use of sun.* class | |
| JAVA0087 | 0.00 | JAVA0087 Use of Thread.sleep() | |
| JAVA0089 | 0.00 | JAVA0089 Use of restricted package | |
| JAVA0092 | 0.00 | JAVA0092 Use of restricted type | |
| JAVA0093 | 0.00 | JAVA0093 Redundant assignment | |
| JAVA0094 | 0.00 | JAVA0094 Field hides a superclass field | |
| JAVA0095 | 0.00 | JAVA0095 Uninitialized private field | |
| JAVA0096 | 0.00 | JAVA0096 Field in nested class hides outer field | |
| JAVA0098 | 0.00 | JAVA0098 Minimize use of implicit field initializers | |
| JAVA0100 | 1.00 | JAVA0100 Class contains N non-final fields (maximum: M) | |
| JAVA0101 | 0.00 | JAVA0101 Unnecessary modifier for field in interface | |
| JAVA0102 | 0.00 | JAVA0102 Last statement in finalize() not super.finalize() | |
| JAVA0103 | 0.00 | JAVA0103 Explicit call to finalize() | |
| JAVA0104 | 0.00 | JAVA0104 finalize() only calls super.finalize() | |
| JAVA0105 | 0.00 | JAVA0105 Duplicate import declaration | |
| JAVA0106 | 0.00 | JAVA0106 Unnecessary import from current package | |
| JAVA0108 | 1.00 | JAVA0108 Incorrect javadoc: no @param tag for 'parameter' | |
| JAVA0109 | 1.00 | JAVA0109 Incorrect javadoc: no parameter 'parameter' | |
| JAVA0110 | 0.00 | JAVA0110 Incorrect javadoc: no @return tag | |
| JAVA0111 | 0.00 | JAVA0111 Incorrect javadoc: @return tag for void method | |
| JAVA0112 | 0.00 | JAVA0112 Incorrect javadoc: no exception 'exception' in throws | |
| JAVA0113 | 1.00 | JAVA0113 Incorrect javadoc: no @author tag | |
| JAVA0114 | 0.00 | JAVA0114 Incorrect javadoc: no @version tag | |
| JAVA0115 | 0.00 | JAVA0115 Incorrect javadoc: no @throws or @exception tag for 'exception' | |
| JAVA0116 | 0.00 | JAVA0116 Missing javadoc: field 'field' | |
| JAVA0117 | 1.00 | JAVA0117 Missing javadoc: method 'method' | |
| JAVA0118 | 0.00 | JAVA0118 Missing javadoc: type 'type' | |
| JAVA0119 | 0.00 | JAVA0119 Control variable changed within body of for loop | |
| JAVA0123 | 0.00 | JAVA0123 Use all three components of for loop | |
| JAVA0125 | 0.00 | JAVA0125 Continue statement with label | |
| JAVA0126 | 0.00 | JAVA0126 Method declares unchecked exception in throws | |
| JAVA0128 | 0.00 | JAVA0128 Public constructor in non-public class | |
| JAVA0130 | 2.00 | JAVA0130 Non-static method does not use instance fields | |
| JAVA0131 | 0.00 | JAVA0131 Compatible method does not override base | |
| JAVA0132 | 0.00 | JAVA0132 Method overload with compatible signature | |
| JAVA0133 | 0.00 | JAVA0133 Non-synchronized method overrides synchronized method | |
| JAVA0135 | 0.00 | JAVA0135 Only one of Object.equals and Object.hashCode defined: missing 'method' | |
| JAVA0136 | 0.00 | JAVA0136 N methods defined in class (maximum: M) | |
| JAVA0137 | 0.00 | JAVA0137 Non-abstract class missing constructor | |
| JAVA0138 | 0.00 | JAVA0138 N parameters defined for method (maximum: M) | |
| JAVA0139 | 0.00 | JAVA0139 Definition of main other than public static void main(java.lang.String[]) | |
| JAVA0141 | 0.00 | JAVA0141 Unnecessary modifier for method in interface | |
| JAVA0143 | 0.00 | JAVA0143 Synchronized method | |
| JAVA0144 | 0.00 | JAVA0144 Line exceeds maximum M characters | |
| JAVA0145 | 1095.00 | JAVA0145 Tab character used in source file | |
| JAVA0150 | 0.00 | JAVA0150 java.lang.Error (or subclass) thrown | |
| JAVA0153 | 0.00 | JAVA0153 Inefficient conversion of integer to string | |
| JAVA0159 | 0.00 | JAVA0159 Inefficient conversion of string to integer | |
| JAVA0160 | 0.00 | JAVA0160 Method does not throw specified exception | |
| JAVA0161 | 0.00 | JAVA0161 Conditional wait() not in loop | |
| JAVA0163 | 0.00 | JAVA0163 Empty statement | |
| JAVA0165 | 0.00 | JAVA0165 Conflicting return statement in finally block | |
| JAVA0166 | 2.00 | JAVA0166 Generic exception caught | |
| JAVA0167 | 0.00 | JAVA0167 ThreadDeath not rethrown | |
| JAVA0169 | 0.00 | JAVA0169 Unnecessary catch block: exception 'exception' | |
| JAVA0170 | 0.00 | JAVA0170 Caught exception not derived from java.lang.Exception | |
| JAVA0171 | 1.00 | JAVA0171 Unused local variable | |
| JAVA0173 | 0.00 | JAVA0173 Unused method parameter | |
| JAVA0174 | 0.00 | JAVA0174 Assigned local variable never used | |
| JAVA0175 | 1.00 | JAVA0175 Successive assignment to variable | |
| JAVA0176 | 0.00 | JAVA0176 Local variable name does not have required form | |
| JAVA0177 | 0.00 | JAVA0177 Variable declaration missing initializer | |
| JAVA0179 | 0.00 | JAVA0179 Local variable hides visible field | |
| JAVA0233 | 0.00 | JAVA0233 Definition of serialVersionUID other than 'private static final long serialVersionUID' | |
| JAVA0234 | 0.00 | JAVA0234 Class is Serializable but does not define serialVersionUID | |
| JAVA0235 | 0.00 | JAVA0235 Class defines serialVersionUID but does not implement Serializable | |
| JAVA0236 | 0.00 | JAVA0236 Attempt to clone an object which does not implement Cloneable | |
| JAVA0237 | 0.00 | JAVA0237 Class implements Cloneable but does not have public clone method | |
| JAVA0238 | 0.00 | JAVA0238 Clone method does not call super.clone() | |
| JAVA0239 | 0.00 | JAVA0239 Class declares 'readObject' or 'writeObject' but does not implement Serializable | |
| JAVA0240 | 0.00 | JAVA0240 Serializable class which declares readObject or writeObject but not both | |
| JAVA0241 | 0.00 | JAVA0241 'readObject' or 'writeObject' should be declared private in Serializable class | |
| JAVA0242 | 0.00 | JAVA0242 Transient field in non-Serializable class | |
| JAVA0243 | 0.00 | JAVA0243 'readResolve' or 'writeReplace' should be declared private or protected | |
| JAVA0244 | 0.00 | JAVA0244 Field or method name in subclass differs only by case from inherited field or method | |
| JAVA0245 | 0.00 | JAVA0245 JUnit TestCase with non-trivial constructor | |
| JAVA0246 | 0.00 | JAVA0246 JUnit assertXXX statement missing message parameter | |
| JAVA0247 | 0.00 | JAVA0247 JUnit 'setUp()' and 'tearDown()' should call super method | |
| JAVA0248 | 0.00 | JAVA0248 JUnit method 'setUp' or 'tearDown' with incorrect signature | |
| JAVA0249 | 0.00 | JAVA0249 JUnit TestCase 'suite()' should be declared static | |
| JAVA0250 | 0.00 | JAVA0250 JUnit TestCase declares testXXX method with incorrect signature | |
| JAVA0251 | 0.00 | JAVA0251 Use '%n' for line breaks in printf/format for platform independence | |
| JAVA0252 | 0.00 | JAVA0252 'enum' is a Java 1.5 reserved word | |
| JAVA0253 | 0.00 | JAVA0253 Not all enum constants consumed in switch statement | |
| JAVA0254 | 0.00 | JAVA0254 Use enhanced for loop construct instead of Iterator | |
| JAVA0255 | 0.00 | JAVA0255 Result of method invocation not used | |
| JAVA0256 | 0.00 | JAVA0256 Assignment of external collection/array to field | |
| JAVA0257 | 0.00 | JAVA0257 Use of 'Constant Interface' anti-pattern | |
| JAVA0258 | 0.00 | JAVA0258 Implement Iterable for foreach compatibility | |
| JAVA0259 | 0.00 | JAVA0259 Return of collection/array field | |
| JAVA0260 | 0.00 | JAVA0260 Use 'enum' instead of Enumerated Type pattern | |
| JAVA0261 | 0.00 | JAVA0261 Use specialized Enum collection types | |
| JAVA0262 | 0.00 | JAVA0262 Use of char in integer context | |
| JAVA0263 | 0.00 | JAVA0263 Long literal ends with 'l' instead of 'L' | |
| JAVA0264 | 0.00 | JAVA0264 Integer math in long context - check for overflow | |
| JAVA0265 | 1.00 | JAVA0265 Use of Throwable.printStackTrace() | |
| JAVA0266 | 0.00 | JAVA0266 Use of System.out | |
| JAVA0267 | 0.00 | JAVA0267 Use of System.err | |
| JAVA0269 | 0.00 | JAVA0269 Contents of StringBuffer never used | |
| JAVA0270 | 0.00 | JAVA0270 Use Java 5.0 enhanced for loop construct to iterate over all elements in an array | |
| JAVA0271 | 0.00 | JAVA0271 Minimize use of on-demand (.*) static imports | |
| JAVA0272 | 0.00 | JAVA0272 Thread.run() called | |
| JAVA0273 | 1.00 | JAVA0273 Non-final derivative of Thread calls start() in constructor | |
| JAVA0274 | 0.00 | JAVA0274 Serializable class has a synchronized readObject() | |
| JAVA0275 | 0.00 | JAVA0275 Serializable class has a synchronized writeObject() and no other synchronized methods | |
| JAVA0276 | 0.00 | JAVA0276 Unnecessary use of String constructor | |
| JAVA0277 | 0.00 | JAVA0277 Iterator.next() implementation does not throw NoSuchElementException | |
| JAVA0278 | 0.00 | JAVA0278 Unnecessary use of Boolean constructor | |
| JAVA0279 | 0.00 | JAVA0279 Serialization method readObject or readObjectNoData calls an overridable method | |
| JAVA0280 | 0.00 | JAVA0280 IllegalMonitorStateException caught | |
| JAVA0281 | 0.00 | JAVA0281 Iterator.next() not called in loop | |
| JAVA0282 | 0.00 | JAVA0282 Call to Iterator.next() in loop which does not test Iterator.hasNext() | |
| JAVA0283 | 0.00 | JAVA0283 Control variable not updated in loop body | |
| JAVA0284 | 0.00 | JAVA0284 Explicit garbage collection | |
| JAVA0285 | 0.00 | JAVA0285 Dereference of potentially null variable | |
| JAVA0286 | 0.00 | JAVA0286 Dereference of null variable | |
| JAVA0287 | 0.00 | JAVA0287 Unnecessary null check | |
| JAVA0288 | 0.00 | JAVA0288 Inconsistent null check | |
| LINES | 412.00 | Number of lines in the source file | |
| LINE_COMMENT | 5.00 | Number of line comments | |
| LOC | 281.00 | Lines of code | |
| LOGICAL_LINES | 163.00 | Number of statements | |
| LOOPS | 8.00 | Number of loops | |
| NEST_DEPTH | 7.00 | Maximum nesting depth | |
| OPERANDS | 631.00 | Number of operands | |
| OPERATORS | 1077.00 | Number of operators | |
| PARAMS | 12.00 | Number of formal parameter declarations | |
| PROGRAM_LENGTH | 1708.00 | Halstead program length | |
| PROGRAM_VOCAB | 260.00 | Halstead program vocabulary | |
| PROGRAM_VOLUME | 0.00 | Halstead program volume | |
| RETURNS | 16.00 | Number of return points from functions | |
| SIZE | 10431.00 | Size of the file in bytes | |
| UNIQUE_OPERANDS | 206.00 | Number of unique operands | |
| UNIQUE_OPERATORS | 54.00 | Number of unique operators | |
| WHITESPACE | 50.00 | Number of whitespace lines | |