L2Attackable.java
| Index Score | ||
|---|---|---|
 |
 |
net.sf.l2j.gameserver.model |
 |
 |
L2J |
View: Reasons, Metrics, Source Code
These are the metrics that contribute to the Enerjy Score for this file, ranked by impact. So the metrics listed at the top influence the score to a greater extent that the metrics listed at the bottom.
| Metric | Description | |
|---|---|---|
| EXEC_COMMENTS | Comments in executable code |  |
| JAVA0020 | JAVA0020 Field name does not have required form | |
| EXITS | Procedure exits | |
| LINE_COMMENT | Number of line comments | |
| COMPARISONS | Number of comparison operators | |
| JAVA0117 | JAVA0117 Missing javadoc: method 'method' | |
| JAVA0076 | JAVA0076 Use of magic number | |
| LOC | Lines of code | |
| CYCLOMATIC | Cyclomatic complexity | |
| BLOCKS | Number of blocks | |
| PROGRAM_VOCAB | Halstead program vocabulary | |
| JAVA0143 | JAVA0143 Synchronized method | |
| LINES | Number of lines in the source file | |
| UNIQUE_OPERANDS | Number of unique operands | |
| JAVA0128 | JAVA0128 Public constructor in non-public class | |
| OPERATORS | Number of operators | |
| LOGICAL_LINES | Number of statements | |
| JAVA0285 | JAVA0285 Dereference of potentially null variable | |
| FUNCTIONS | Number of function declarations | |
| JAVA0254 | JAVA0254 Use enhanced for loop construct instead of Iterator | |
| JAVA0173 | JAVA0173 Unused method parameter | |
| JAVA0171 | JAVA0171 Unused local variable | |
| PROGRAM_LENGTH | Halstead program length | |
| JAVA0265 | JAVA0265 Use of Throwable.printStackTrace() | |
| JAVA0145 | JAVA0145 Tab character used in source file | |
| UNIQUE_OPERATORS | Number of unique operators | |
| NEST_DEPTH | Maximum nesting depth | |
| ELOC | Effective lines of code | |
| JAVA0170 | JAVA0170 Caught exception not derived from java.lang.Exception | |
| JAVA0166 | JAVA0166 Generic exception caught | |
| OPERANDS | Number of operands | |
| SIZE | Size of the file in bytes | |
| PROGRAM_VOLUME | Halstead program volume | |
| JAVA0136 | JAVA0136 N methods defined in class (maximum: M) | |
| JAVA0126 | JAVA0126 Method declares unchecked exception in throws | |
| JAVA0110 | JAVA0110 Incorrect javadoc: no @return tag | |
| JAVA0034 | JAVA0034 Missing braces in if statement | |
| DECL_COMMENTS | Comments in declarations | |
| JAVA0100 | JAVA0100 Class contains N non-final fields (maximum: M) | |
| DOC_COMMENT | Number of javadoc comment lines | |
| BLOCK_COMMENT | Number of block comment lines | |
| JAVA0270 | JAVA0270 Use Java 5.0 enhanced for loop construct to iterate over all elements in an array | |
/*
* $Header: /cvsroot/l2j/L2_Gameserver/java/net/sf/l2j/gameserver/model/L2Attackable.java,v 1.24 2004/10/23 23:48:50 l2chef Exp $
*
* $Author: l2chef $
* $Date: 2004/10/23 23:48:50 $
* $Revision: 1.24 $
* $Log: L2Attackable.java,v $
* Revision 1.24 2004/10/23 23:48:50 l2chef
* temporary fix for drops falling thru floor
* target scan is done 20 times less to reduce cpu load
*
* Revision 1.23 2004/10/08 11:00:59 nuocnam
* fixed exp attribution so you get correct XP when fighting stronger monsters
*
* Revision 1.22 2004/09/30 20:07:50 dethx
* *** empty log message ***
*
* Revision 1.21 2004/09/27 08:44:53 nuocnam
* Everything party related moved to L2Party class.
*
* Revision 1.20 2004/09/24 19:42:19 jeichhorn
* fixed file comments
*
*
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2, or (at your option)
* any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA
* 02111-1307, USA.
*
* http://www.gnu.org/copyleft/gpl.html
*/
package net.sf.l2j.gameserver.model;
import java.io.PrintWriter;
import java.io.StringWriter;
import java.util.ArrayList;
import java.util.HashMap;
import java.util.Iterator;
import java.util.List;
import java.util.Set;
import java.util.Timer;
import java.util.TimerTask;
import java.util.logging.Logger;
import net.sf.l2j.gameserver.ItemTable;
import net.sf.l2j.gameserver.RatesController;
import net.sf.l2j.gameserver.serverpackets.DropItem;
import net.sf.l2j.gameserver.templates.L2Npc;
import net.sf.l2j.gameserver.templates.L2Weapon;
/**
* This class ...
*
* @version $Revision: 1.24 $ $Date: 2004/10/23 23:48:50 $
*/
public class L2Attackable extends L2NpcInstance
{
private static Logger _log = Logger.getLogger(L2Attackable.class.getName());
class AITask extends TimerTask
{
L2Character _instance;
public AITask(L2Character instance)
{
_instance = instance;
}
public void run()
{
try
{
int x1 = getX() + getRnd().nextInt(500) -250;
int y1 = getY() + getRnd().nextInt(500) -250;
moveTo(x1, y1, getZ(), 0);
}
catch (Throwable e)
{
_log.warning(getObjectId()+": Problem occured in AiTask:"+e);
StringWriter pw = new StringWriter();
PrintWriter prw = new PrintWriter(pw);
e.printStackTrace(prw);
_log.severe(pw.toString());
}
}
}
class AIAttackeTask extends TimerTask
{
L2Character _instance;
public AIAttackeTask(L2Character instance)
{
_instance = instance;
}
public void run()
{
try
{
if (!isInCombat())
{
_log.finer(getObjectId()+": monster knows "+getKnownPlayers().size() + " players");
Set knownPlayers = getKnownPlayers();
for (Iterator iter = knownPlayers.iterator(); iter.hasNext();)
{
L2PcInstance player = (L2PcInstance) iter.next();
// dont do further checking if the player is dead or Z coordinate is very different
// TODO find a good value for the max allowed Z distance
if (getCondition2(player))
{
double distance = getDistance(player.getX(), player.getY());
if((distance <= (getCollisionRadius()+200)))
{
_log.fine(getObjectId()+": Player "+player.getObjectId()+" in aggro range. Attacking!");
if(_currentAiTask != null)
{
_currentAiTask.cancel();
}
setTarget(player);
startAttack(player);
}
}
}
}
else
{
if(_currentAIAttackeTask != null)
{
_currentAIAttackeTask.cancel();
}
}
}
catch (Throwable e)
{
_log.warning(getObjectId()+": Problem occured in AiAttackTask:"+e);
StringWriter pw = new StringWriter();
PrintWriter prw = new PrintWriter(pw);
e.printStackTrace(prw);
_log.severe(pw.toString());
}
}
}
private int _moveRadius;
private boolean _active;
private AITask _currentAiTask;
private AIAttackeTask _currentAIAttackeTask;
private static Timer _aiTimer = new Timer(true);
private static Timer _attackTimer = new Timer(true);
private HashMap _aggroList = new HashMap();
private L2Weapon _dummyWeapon;
private boolean _sweepActive;
private boolean _killedAlready = false;
/**
* @param template
*/
public L2Attackable(L2Npc template)
{
super(template);
}
public boolean getCondition2(L2PcInstance player)
{
return false;
}
/**
* event that is called when the destination coordinates are reached
*/
public void onTargetReached()
{
super.onTargetReached();
switch (getCurrentState())
{
case STATE_PICKUP_ITEM:
// doPickupItem();
break;
case STATE_ATTACKING:
startCombat();
break;
case STATE_RANDOM_WALK:
randomWalk();
break;
default:
break;
}
}
private void randomWalk()
{
if (_active)
{
_log.fine(getObjectId()+": target reached ! new target calculated.");
int wait = (10 + getRnd().nextInt(120))*1000;
_currentAiTask = new AITask(this);
_aiTimer.schedule(_currentAiTask, wait);
}
else
{
_log.fine(getObjectId()+": target reached ! noone around .. cancel movement.");
}
}
protected void startRandomWalking()
{
_currentAiTask = new AITask(this);
int wait = (10 + getRnd().nextInt(120))*1000;
_aiTimer.schedule(_currentAiTask, wait);
setCurrentState(STATE_RANDOM_WALK);
}
protected synchronized void startTargetScan()
{
// only one scan task is allowed, and we dont start scanning if we already
if (_currentAIAttackeTask == null && getTarget() == null )
{
_currentAIAttackeTask = new AIAttackeTask(this);
_attackTimer.scheduleAtFixedRate(_currentAIAttackeTask,100,1000);
}
}
public void startAttack(L2Character target)
{
// one target is enough
stopTargetScan();
super.startAttack(target);
}
/* (non-Javadoc)
* @see net.sf.l2j.gameserver.model.L2Object#setX(int)
*/
public void setX(int x)
{
super.setX(x);
}
/* (non-Javadoc)
* @see net.sf.l2j.gameserver.model.L2Object#setY(int)
*/
public void setY(int y)
{
super.setY(y);
}
/* (non-Javadoc)
* @see net.sf.l2j.gameserver.model.L2Object#setZ(int)
*/
public void setZ(int z)
{
super.setZ(z);
}
/* (non-Javadoc)
* @see net.sf.l2j.gameserver.model.L2Character#removeKnownObject(net.sf.l2j.gameserver.model.L2Object)
*/
public void removeKnownObject(L2Object object)
{
super.removeKnownObject(object);
// this monster forgets any agro when hostile leaves the area
if (object instanceof L2Character)
{
_aggroList.remove((L2Character) object);
}
}
/* (non-Javadoc)
* @see net.sf.l2j.gameserver.model.L2Character#reduceCurrentHp(int)
*/
public void reduceCurrentHp(int damage, L2Character attacker)
{
super.reduceCurrentHp(damage, attacker);
// this is usually only called in combat
calculateAggro(damage, attacker);
if (!isDead() && attacker != null)
{
if (!isInCombat())
{
stopRandomWalking();
startAttack(attacker);
}
else
{
_log.fine("already attacking");
}
}
else if (isDead())
{
// killing is only possible one time
synchronized(this)
{
if (!_killedAlready)
{
_killedAlready = true;
stopRandomWalking();
stopTargetScan();
calculateRewards(attacker);
}
}
}
}
/**
* @param attacker
*/
private void calculateRewards(L2Character lastAttacker)
{
Iterator it = _aggroList.keySet().iterator();
int numberOfAttackers = _aggroList.size();
int npcID = getNpcTemplate().getNpcId();
int npcLvl = getLevel();
while (it.hasNext())
{
L2Character attacker = (L2Character) it.next();
Integer value = (Integer) _aggroList.get(attacker);
L2Party attackerParty = null;
if (attacker instanceof L2PcInstance)
{
L2PcInstance temp = (L2PcInstance)attacker;
if (temp.isInParty()) attackerParty = temp.getParty();
}
//FIXME Pets arent party members yet - they are not considered as party members in l2 (nuocnam)
if (npcID > 0 && value !=null && attackerParty == null)
{
int newXp = 0;
int newSp = 0;
int dmg = value.intValue();
if (dmg > getMaxHp())
{
dmg = getMaxHp();
}
//mob = 24, atk = 10, diff = -14 (full xp)
//mob = 24, atk = 28, diff = 4 (some xp)
//mob = 24, atk = 50, diff = 26 (no xp)
int diff = attacker.getLevel() - getLevel();
// mob is 1 to 9 levels below attacker lvl
if ((diff > 0) && (diff <= 9) && attacker.knownsObject(this))
{
newXp = getExpReward()*(dmg / getMaxHp());
newSp = getSpReward()*(dmg / getMaxHp());
newXp = (newXp - (int)(((double)diff/10) * newXp));
newSp = (newSp - (int)(((double)diff/10) * newSp));
}
//attacker's level below or equal to mob lvl
else if ((diff <= 0) && attacker.knownsObject(this))
{
newXp = getExpReward()*(dmg / getMaxHp());
newSp = getSpReward()*(dmg / getMaxHp());
}
//mob is more than 9 levels below attacker lvl
else if ((diff > 9) && attacker.knownsObject(this))
{
newXp = 0;
newSp = 0;
}
if (newXp <= 0)
{
newXp = 0;
newSp = 0;
}
else if (newSp <= 0 && newXp > 0)
{
newSp = 0;
}
attacker.addExpAndSp(newXp, newSp);
_aggroList.remove(attacker);
it = _aggroList.keySet().iterator();
}
else
{
//share with party members
int partyDmg = 0;
ArrayList members = attackerParty.getPartyMembers();
for(int i = 0; i < members.size(); i++) {
L2PcInstance tmp = (L2PcInstance) members.get(i);
if (_aggroList.containsKey(tmp)) {
partyDmg += ((Integer) _aggroList.get(tmp)).intValue();
_aggroList.remove(tmp);
}
}
it = _aggroList.keySet().iterator(); //reset iterator so removed peeps are no longer in
if (partyDmg > getMaxHp()) partyDmg = getMaxHp();
attackerParty.distributeXpAndSp(partyDmg, getMaxHp(), getExpReward(), getSpReward());
}
}
doItemDrop();
}
/**
* @param damage
* @param attacker
*/
private void calculateAggro(int damage, L2Character attacker)
{
int newAggro = damage;
Integer aggroValue = (Integer) _aggroList.get(attacker);
if (aggroValue != null)
{
// add the old value
newAggro += aggroValue.intValue();
}
_aggroList.put(attacker, new Integer(newAggro));
if (_aggroList.size() == 1)
{
setTarget(attacker);
}
else
{
// find highest aggrovalue to decide target should be here
// now we just use the last attacker is the new target
setTarget(attacker);
}
}
/**
*/
public void doItemDrop()
{
// FIXME: SWEEP is not implemented... waiting for skills...
List drops = getNpcTemplate().getDropData();
// See how many items we need to drop for a given mobId
_log.finer("this npc has "+drops.size()+" drops defined");
for (Iterator iter = drops.iterator(); iter.hasNext();)
{
L2DropData drop = (L2DropData) iter.next();
if (drop.isSweep())
{
// this is a sweep drop, it will not appear on the ground
// so just skip it
continue;
}
// Roll the dice.. between 0 and MAX_CHANCE
int roll = L2NpcInstance.getRnd().nextInt(L2DropData.MAX_CHANCE);
// compare roll with chance... "are we lucky?"
if (roll < drop.getChance()*RatesController.getInstance().getDropRate())
{
L2ItemInstance dropit = ItemTable.getInstance().createItem(drop.getItemId());
// Get min,max,sweep
int min = drop.getMinDrop();
int max = drop.getMaxDrop();
int itemCount = 0;
if (min < max)
{
// getRnd().nextInt(n) requires n > 0
// Get RND between 0 and (max-min) then add min to get range between min and max...
itemCount = L2NpcInstance.getRnd().nextInt(max - min) + min;
}
else
{
itemCount = 1;
}
if (dropit.getItemId() == 57)
{
itemCount = itemCount * RatesController.getInstance().getAdenaRate();
}
if (itemCount != 0) // only happens if min=0 and max=1... but still need to check!
{
dropit.setCount(itemCount);
_log.fine("Item id to drop: "+drop.getItemId()+" amount: "+dropit.getCount());
// position where mob was last
dropit.setX(getX());
dropit.setY(getY());
dropit.setZ(getZ()+100);
// otherwise you cannot pick it up
dropit.setOnTheGround(true);
DropItem dis = new DropItem(dropit, getObjectId());
// also notify all other players about the drop
L2Character[] players = broadcastPacket(dis);
for (int k = 0; k < players.length; k++)
{
((L2PcInstance)players[k]).addKnownObjectWithoutCreate(dropit);
}
L2World.getInstance().addVisibleObject(dropit);
}
else
{
_log.warning("Roll produced 0 items to drop... Cancelling");
}
}
}
}
/**
*
*/
protected void stopRandomWalking()
{
// dont walk around any more
if (_currentAiTask != null)
{
_currentAiTask.cancel();
_currentAiTask = null;
}
}
protected boolean isTargetScanActive()
{
return (_currentAIAttackeTask != null);
}
protected synchronized void stopTargetScan()
{
if (_currentAIAttackeTask != null)
{
_currentAIAttackeTask.cancel();
_currentAIAttackeTask = null;
}
}
/* (non-Javadoc)
* @see net.sf.l2j.gameserver.model.L2Character#setCurrentHp(double)
*/
public void setCurrentHp(double currentHp)
{
super.setCurrentHp(currentHp);
}
/* (non-Javadoc)
* @see net.sf.l2j.gameserver.model.L2Character#getActiveWeapon()
*/
public L2Weapon getActiveWeapon()
{
return _dummyWeapon;
}
/**
* this method has to be called AFTER setLevel() was executed
*/
public void setPhysicalAttack(int physicalAttack)
{
super.setPhysicalAttack(physicalAttack);
// create a dummy weapon
_dummyWeapon = new L2Weapon();
_dummyWeapon.setPDamage(physicalAttack);
int randDmg = getLevel();
_dummyWeapon.setRandomDamage(randDmg);
}
//some exports for guards
public boolean noTarget()
{
return _aggroList.isEmpty();
}
public boolean containsTarget(L2Character player)
{
return _aggroList.containsKey(player);
}
public void clearAggroList()
{
_aggroList.clear();
}
public boolean isActive()
{
return _active;
}
public void setActive(boolean b)
{
_active = b;
}
public void setMoveRadius(int i)
{
_moveRadius = i;
}
public boolean isSweepActive()
{
return _sweepActive;
}
public void setSweepActive(boolean sweepActive)
{
_sweepActive = sweepActive;
}
}
The table below shows all metrics for L2Attackable.java.
| Metric | Value | Description | |
|---|---|---|---|
| BLOCKS | 80.00 | Number of blocks | |
| BLOCK_COMMENT | 63.00 | Number of block comment lines | |
| COMMENTS | 123.00 | Comment lines | |
| COMMENT_DENSITY | 0.47 | Comment density | |
| COMPARISONS | 76.00 | Number of comparison operators | |
| CYCLOMATIC | 84.00 | Cyclomatic complexity | |
| DECL_COMMENTS | 17.00 | Comments in declarations | |
| DOC_COMMENT | 26.00 | Number of javadoc comment lines | |
| ELOC | 264.00 | Effective lines of code | |
| EXEC_COMMENTS | 27.00 | Comments in executable code | |
| EXITS | 89.00 | Procedure exits | |
| FUNCTIONS | 33.00 | Number of function declarations | |
| HALSTEAD_DIFFICULTY | 74.49 | Halstead difficulty | |
| HALSTEAD_EFFORT | 0.00 | Halstead effort | |
| INTERFACE_COMPLEXITY | 53.00 | Interface complexity | |
| JAVA0001 | 1.00 | JAVA0001 Package name does not contain only lower case letters | |
| JAVA0002 | 0.00 | JAVA0002 Package name does not begin with a top level domain name or country code | |
| JAVA0003 | 0.00 | JAVA0003 Minimize use of on-demand (.*) imports | |
| JAVA0004 | 0.00 | JAVA0004 Unnecessary import from java.lang | |
| JAVA0005 | 0.00 | JAVA0005 Imports not in specified order | |
| JAVA0006 | 0.00 | JAVA0006 Empty finally block | |
| JAVA0007 | 0.00 | JAVA0007 Should not declare public field | |
| JAVA0008 | 0.00 | JAVA0008 Empty catch block | |
| JAVA0009 | 0.00 | JAVA0009 Protected member in final class | |
| JAVA0010 | 0.00 | JAVA0010 Non-instantiable class does not contain a non-private static member | |
| JAVA0011 | 0.00 | JAVA0011 Abstract class does not contain an abstract method | |
| JAVA0012 | 0.00 | JAVA0012 Non-constructor method with same name as declaring class | |
| JAVA0013 | 0.00 | JAVA0013 Non-blank final field is not static | |
| JAVA0014 | 0.00 | JAVA0014 Class with only static members has non-private constructor | |
| JAVA0015 | 0.00 | JAVA0015 Package class contains public nested type | |
| JAVA0016 | 0.00 | JAVA0016 Abstract class contains public constructor | |
| JAVA0017 | 0.00 | JAVA0017 Class name does not have required form | |
| JAVA0018 | 0.00 | JAVA0018 Method name does not have required form | |
| JAVA0019 | 0.00 | JAVA0019 Interface name does not have required form | |
| JAVA0020 | 10.00 | JAVA0020 Field name does not have required form | |
| JAVA0021 | 0.00 | JAVA0021 Interface method name does not have required form | |
| JAVA0022 | 0.00 | JAVA0022 Static final field name does not have required form | |
| JAVA0023 | 0.00 | JAVA0023 Empty finalize method | |
| JAVA0024 | 0.00 | JAVA0024 Empty class | |
| JAVA0025 | 0.00 | JAVA0025 Method override is empty | |
| JAVA0026 | 0.00 | JAVA0026 Finalize method with parameters | |
| JAVA0029 | 0.00 | JAVA0029 Private method not used | |
| JAVA0030 | 0.00 | JAVA0030 Private field not used | |
| JAVA0031 | 0.00 | JAVA0031 Case statement not properly closed | |
| JAVA0032 | 0.00 | JAVA0032 Switch statement missing default | |
| JAVA0033 | 0.00 | JAVA0033 default: not last case in switch statement | |
| JAVA0034 | 2.00 | JAVA0034 Missing braces in if statement | |
| JAVA0035 | 0.00 | JAVA0035 Missing braces in for statement | |
| JAVA0036 | 0.00 | JAVA0036 Missing braces in while statement | |
| JAVA0038 | 0.00 | JAVA0038 Non-case label in switch statement | |
| JAVA0039 | 0.00 | JAVA0039 Break statement with label | |
| JAVA0040 | 0.00 | JAVA0040 Switch statement contains N cases (maximum: M) | |
| JAVA0041 | 0.00 | JAVA0041 Nested synchronized block | |
| JAVA0042 | 0.00 | JAVA0042 Empty synchronized statement | |
| JAVA0043 | 0.00 | JAVA0043 Inner class does not use outer class | |
| JAVA0044 | 0.00 | JAVA0044 Serializable class with no instance variables | |
| JAVA0045 | 0.00 | JAVA0045 Serializable class with only transient fields | |
| JAVA0046 | 0.00 | JAVA0046 Name of class not derived from Exception ends with 'Exception' | |
| JAVA0047 | 0.00 | JAVA0047 Serializable class derives from invalid base class | |
| JAVA0048 | 0.00 | JAVA0048 Name of class derived from Exception does not end with 'Exception' | |
| JAVA0049 | 1.00 | JAVA0049 Nested block at depth N (maximum: M) | |
| JAVA0050 | 0.00 | JAVA0050 Class derives from java.lang.Error | |
| JAVA0051 | 0.00 | JAVA0051 Class derives from java.lang.RuntimeException | |
| JAVA0052 | 0.00 | JAVA0052 Class derives from java.lang.Throwable | |
| JAVA0053 | 0.00 | JAVA0053 Unused label | |
| JAVA0054 | 1.00 | JAVA0054 Inheritance depth N exceeds maximum M | |
| JAVA0055 | 0.00 | JAVA0055 Class should be interface | |
| JAVA0056 | 0.00 | JAVA0056 Unnecessary abstract modifier for interface or annotation | |
| JAVA0057 | 0.00 | JAVA0057 Unnecessary default constructor | |
| JAVA0058 | 0.00 | JAVA0058 Constructor calls super() | |
| JAVA0059 | 4.00 | JAVA0059 Method override only calls super() | |
| JAVA0061 | 0.00 | JAVA0061 Inaccessible member in anonymous class | |
| JAVA0062 | 0.00 | JAVA0062 Public class missing public member or protected constructor | |
| JAVA0063 | 0.00 | JAVA0063 Identifier name should not contain '$' | |
| JAVA0064 | 0.00 | JAVA0064 N variations of identifier name (maximum: M) | |
| JAVA0065 | 0.00 | JAVA0065 Unnecessary final modifier for method in final class | |
| JAVA0066 | 0.00 | JAVA0066 Unnecessary modifier for interface nested type | |
| JAVA0067 | 0.00 | JAVA0067 Array descriptor on identifier name | |
| JAVA0068 | 0.00 | JAVA0068 Modifiers not declared in recommended order | |
| JAVA0071 | 0.00 | JAVA0071 Strings compared with == | |
| JAVA0073 | 0.00 | JAVA0073 Integer division in floating-point context | |
| JAVA0074 | 0.00 | JAVA0074 Use of Object.notify() | |
| JAVA0075 | 0.00 | JAVA0075 Method parameter hides field | |
| JAVA0076 | 17.00 | JAVA0076 Use of magic number | |
| JAVA0077 | 0.00 | JAVA0077 Private field not used in declaring class | |
| JAVA0078 | 0.00 | JAVA0078 Floating point values compared with == | |
| JAVA0079 | 0.00 | JAVA0079 Use of instance to reference static member | |
| JAVA0080 | 0.00 | JAVA0080 Import declaration not used | |
| JAVA0081 | 0.00 | JAVA0081 Boolean literal in comparison | |
| JAVA0082 | 0.00 | JAVA0082 Unnecessary widening cast | |
| JAVA0083 | 0.00 | JAVA0083 Unnecessary instanceof test | |
| JAVA0084 | 1.00 | JAVA0084 Should use compound assignment operator | |
| JAVA0085 | 0.00 | JAVA0085 Use of sun.* class | |
| JAVA0087 | 0.00 | JAVA0087 Use of Thread.sleep() | |
| JAVA0089 | 0.00 | JAVA0089 Use of restricted package | |
| JAVA0092 | 0.00 | JAVA0092 Use of restricted type | |
| JAVA0093 | 0.00 | JAVA0093 Redundant assignment | |
| JAVA0094 | 0.00 | JAVA0094 Field hides a superclass field | |
| JAVA0095 | 0.00 | JAVA0095 Uninitialized private field | |
| JAVA0096 | 0.00 | JAVA0096 Field in nested class hides outer field | |
| JAVA0098 | 0.00 | JAVA0098 Minimize use of implicit field initializers | |
| JAVA0100 | 1.00 | JAVA0100 Class contains N non-final fields (maximum: M) | |
| JAVA0101 | 0.00 | JAVA0101 Unnecessary modifier for field in interface | |
| JAVA0102 | 0.00 | JAVA0102 Last statement in finalize() not super.finalize() | |
| JAVA0103 | 0.00 | JAVA0103 Explicit call to finalize() | |
| JAVA0104 | 0.00 | JAVA0104 finalize() only calls super.finalize() | |
| JAVA0105 | 0.00 | JAVA0105 Duplicate import declaration | |
| JAVA0106 | 0.00 | JAVA0106 Unnecessary import from current package | |
| JAVA0108 | 1.00 | JAVA0108 Incorrect javadoc: no @param tag for 'parameter' | |
| JAVA0109 | 1.00 | JAVA0109 Incorrect javadoc: no parameter 'parameter' | |
| JAVA0110 | 0.00 | JAVA0110 Incorrect javadoc: no @return tag | |
| JAVA0111 | 0.00 | JAVA0111 Incorrect javadoc: @return tag for void method | |
| JAVA0112 | 0.00 | JAVA0112 Incorrect javadoc: no exception 'exception' in throws | |
| JAVA0113 | 1.00 | JAVA0113 Incorrect javadoc: no @author tag | |
| JAVA0114 | 0.00 | JAVA0114 Incorrect javadoc: no @version tag | |
| JAVA0115 | 0.00 | JAVA0115 Incorrect javadoc: no @throws or @exception tag for 'exception' | |
| JAVA0116 | 0.00 | JAVA0116 Missing javadoc: field 'field' | |
| JAVA0117 | 15.00 | JAVA0117 Missing javadoc: method 'method' | |
| JAVA0118 | 0.00 | JAVA0118 Missing javadoc: type 'type' | |
| JAVA0119 | 0.00 | JAVA0119 Control variable changed within body of for loop | |
| JAVA0123 | 0.00 | JAVA0123 Use all three components of for loop | |
| JAVA0125 | 0.00 | JAVA0125 Continue statement with label | |
| JAVA0126 | 0.00 | JAVA0126 Method declares unchecked exception in throws | |
| JAVA0128 | 2.00 | JAVA0128 Public constructor in non-public class | |
| JAVA0130 | 0.00 | JAVA0130 Non-static method does not use instance fields | |
| JAVA0131 | 0.00 | JAVA0131 Compatible method does not override base | |
| JAVA0132 | 0.00 | JAVA0132 Method overload with compatible signature | |
| JAVA0133 | 0.00 | JAVA0133 Non-synchronized method overrides synchronized method | |
| JAVA0135 | 0.00 | JAVA0135 Only one of Object.equals and Object.hashCode defined: missing 'method' | |
| JAVA0136 | 1.00 | JAVA0136 N methods defined in class (maximum: M) | |
| JAVA0137 | 0.00 | JAVA0137 Non-abstract class missing constructor | |
| JAVA0138 | 0.00 | JAVA0138 N parameters defined for method (maximum: M) | |
| JAVA0139 | 0.00 | JAVA0139 Definition of main other than public static void main(java.lang.String[]) | |
| JAVA0141 | 0.00 | JAVA0141 Unnecessary modifier for method in interface | |
| JAVA0143 | 2.00 | JAVA0143 Synchronized method | |
| JAVA0144 | 0.00 | JAVA0144 Line exceeds maximum M characters | |
| JAVA0145 | 1552.00 | JAVA0145 Tab character used in source file | |
| JAVA0150 | 0.00 | JAVA0150 java.lang.Error (or subclass) thrown | |
| JAVA0153 | 0.00 | JAVA0153 Inefficient conversion of integer to string | |
| JAVA0159 | 0.00 | JAVA0159 Inefficient conversion of string to integer | |
| JAVA0160 | 0.00 | JAVA0160 Method does not throw specified exception | |
| JAVA0161 | 0.00 | JAVA0161 Conditional wait() not in loop | |
| JAVA0163 | 0.00 | JAVA0163 Empty statement | |
| JAVA0165 | 0.00 | JAVA0165 Conflicting return statement in finally block | |
| JAVA0166 | 2.00 | JAVA0166 Generic exception caught | |
| JAVA0167 | 0.00 | JAVA0167 ThreadDeath not rethrown | |
| JAVA0169 | 0.00 | JAVA0169 Unnecessary catch block: exception 'exception' | |
| JAVA0170 | 2.00 | JAVA0170 Caught exception not derived from java.lang.Exception | |
| JAVA0171 | 2.00 | JAVA0171 Unused local variable | |
| JAVA0173 | 2.00 | JAVA0173 Unused method parameter | |
| JAVA0174 | 0.00 | JAVA0174 Assigned local variable never used | |
| JAVA0175 | 0.00 | JAVA0175 Successive assignment to variable | |
| JAVA0176 | 0.00 | JAVA0176 Local variable name does not have required form | |
| JAVA0177 | 0.00 | JAVA0177 Variable declaration missing initializer | |
| JAVA0179 | 0.00 | JAVA0179 Local variable hides visible field | |
| JAVA0233 | 0.00 | JAVA0233 Definition of serialVersionUID other than 'private static final long serialVersionUID' | |
| JAVA0234 | 0.00 | JAVA0234 Class is Serializable but does not define serialVersionUID | |
| JAVA0235 | 0.00 | JAVA0235 Class defines serialVersionUID but does not implement Serializable | |
| JAVA0236 | 0.00 | JAVA0236 Attempt to clone an object which does not implement Cloneable | |
| JAVA0237 | 0.00 | JAVA0237 Class implements Cloneable but does not have public clone method | |
| JAVA0238 | 0.00 | JAVA0238 Clone method does not call super.clone() | |
| JAVA0239 | 0.00 | JAVA0239 Class declares 'readObject' or 'writeObject' but does not implement Serializable | |
| JAVA0240 | 0.00 | JAVA0240 Serializable class which declares readObject or writeObject but not both | |
| JAVA0241 | 0.00 | JAVA0241 'readObject' or 'writeObject' should be declared private in Serializable class | |
| JAVA0242 | 0.00 | JAVA0242 Transient field in non-Serializable class | |
| JAVA0243 | 0.00 | JAVA0243 'readResolve' or 'writeReplace' should be declared private or protected | |
| JAVA0244 | 0.00 | JAVA0244 Field or method name in subclass differs only by case from inherited field or method | |
| JAVA0245 | 0.00 | JAVA0245 JUnit TestCase with non-trivial constructor | |
| JAVA0246 | 0.00 | JAVA0246 JUnit assertXXX statement missing message parameter | |
| JAVA0247 | 0.00 | JAVA0247 JUnit 'setUp()' and 'tearDown()' should call super method | |
| JAVA0248 | 0.00 | JAVA0248 JUnit method 'setUp' or 'tearDown' with incorrect signature | |
| JAVA0249 | 0.00 | JAVA0249 JUnit TestCase 'suite()' should be declared static | |
| JAVA0250 | 0.00 | JAVA0250 JUnit TestCase declares testXXX method with incorrect signature | |
| JAVA0251 | 0.00 | JAVA0251 Use '%n' for line breaks in printf/format for platform independence | |
| JAVA0252 | 0.00 | JAVA0252 'enum' is a Java 1.5 reserved word | |
| JAVA0253 | 0.00 | JAVA0253 Not all enum constants consumed in switch statement | |
| JAVA0254 | 2.00 | JAVA0254 Use enhanced for loop construct instead of Iterator | |
| JAVA0255 | 0.00 | JAVA0255 Result of method invocation not used | |
| JAVA0256 | 0.00 | JAVA0256 Assignment of external collection/array to field | |
| JAVA0257 | 0.00 | JAVA0257 Use of 'Constant Interface' anti-pattern | |
| JAVA0258 | 0.00 | JAVA0258 Implement Iterable for foreach compatibility | |
| JAVA0259 | 0.00 | JAVA0259 Return of collection/array field | |
| JAVA0260 | 0.00 | JAVA0260 Use 'enum' instead of Enumerated Type pattern | |
| JAVA0261 | 0.00 | JAVA0261 Use specialized Enum collection types | |
| JAVA0262 | 0.00 | JAVA0262 Use of char in integer context | |
| JAVA0263 | 0.00 | JAVA0263 Long literal ends with 'l' instead of 'L' | |
| JAVA0264 | 0.00 | JAVA0264 Integer math in long context - check for overflow | |
| JAVA0265 | 2.00 | JAVA0265 Use of Throwable.printStackTrace() | |
| JAVA0266 | 0.00 | JAVA0266 Use of System.out | |
| JAVA0267 | 0.00 | JAVA0267 Use of System.err | |
| JAVA0269 | 0.00 | JAVA0269 Contents of StringBuffer never used | |
| JAVA0270 | 1.00 | JAVA0270 Use Java 5.0 enhanced for loop construct to iterate over all elements in an array | |
| JAVA0271 | 0.00 | JAVA0271 Minimize use of on-demand (.*) static imports | |
| JAVA0272 | 0.00 | JAVA0272 Thread.run() called | |
| JAVA0273 | 0.00 | JAVA0273 Non-final derivative of Thread calls start() in constructor | |
| JAVA0274 | 0.00 | JAVA0274 Serializable class has a synchronized readObject() | |
| JAVA0275 | 0.00 | JAVA0275 Serializable class has a synchronized writeObject() and no other synchronized methods | |
| JAVA0276 | 0.00 | JAVA0276 Unnecessary use of String constructor | |
| JAVA0277 | 0.00 | JAVA0277 Iterator.next() implementation does not throw NoSuchElementException | |
| JAVA0278 | 0.00 | JAVA0278 Unnecessary use of Boolean constructor | |
| JAVA0279 | 0.00 | JAVA0279 Serialization method readObject or readObjectNoData calls an overridable method | |
| JAVA0280 | 0.00 | JAVA0280 IllegalMonitorStateException caught | |
| JAVA0281 | 0.00 | JAVA0281 Iterator.next() not called in loop | |
| JAVA0282 | 0.00 | JAVA0282 Call to Iterator.next() in loop which does not test Iterator.hasNext() | |
| JAVA0283 | 0.00 | JAVA0283 Control variable not updated in loop body | |
| JAVA0284 | 0.00 | JAVA0284 Explicit garbage collection | |
| JAVA0285 | 2.00 | JAVA0285 Dereference of potentially null variable | |
| JAVA0286 | 0.00 | JAVA0286 Dereference of null variable | |
| JAVA0287 | 0.00 | JAVA0287 Unnecessary null check | |
| JAVA0288 | 0.00 | JAVA0288 Inconsistent null check | |
| LINES | 643.00 | Number of lines in the source file | |
| LINE_COMMENT | 34.00 | Number of line comments | |
| LOC | 429.00 | Lines of code | |
| LOGICAL_LINES | 183.00 | Number of statements | |
| LOOPS | 5.00 | Number of loops | |
| NEST_DEPTH | 7.00 | Maximum nesting depth | |
| OPERANDS | 721.00 | Number of operands | |
| OPERATORS | 1579.00 | Number of operators | |
| PARAMS | 20.00 | Number of formal parameter declarations | |
| PROGRAM_LENGTH | 2300.00 | Halstead program length | |
| PROGRAM_VOCAB | 327.00 | Halstead program vocabulary | |
| PROGRAM_VOLUME | 0.00 | Halstead program volume | |
| RETURNS | 33.00 | Number of return points from functions | |
| SIZE | 15066.00 | Size of the file in bytes | |
| UNIQUE_OPERANDS | 271.00 | Number of unique operands | |
| UNIQUE_OPERATORS | 56.00 | Number of unique operators | |
| WHITESPACE | 91.00 | Number of whitespace lines | |