Inventory.java
| Index Score | ||
|---|---|---|
 |
 |
net.sf.l2j.gameserver.model |
 |
 |
L2J |
View: Reasons, Metrics, Source Code
These are the metrics that contribute to the Enerjy Score for this file, ranked by impact. So the metrics listed at the top influence the score to a greater extent that the metrics listed at the bottom.
| Metric | Description | |
|---|---|---|
| LOC | Lines of code |  |
| BLOCKS | Number of blocks | |
| JAVA0020 | JAVA0020 Field name does not have required form | |
| LOGICAL_LINES | Number of statements | |
| JAVA0108 | JAVA0108 Incorrect javadoc: no @param tag for 'parameter' | |
| CYCLOMATIC | Cyclomatic complexity | |
| JAVA0116 | JAVA0116 Missing javadoc: field 'field' | |
| LINES | Number of lines in the source file | |
| ELOC | Effective lines of code | |
| JAVA0117 | JAVA0117 Missing javadoc: method 'method' | |
| OPERATORS | Number of operators | |
| JAVA0110 | JAVA0110 Incorrect javadoc: no @return tag | |
| JAVA0034 | JAVA0034 Missing braces in if statement | |
| JAVA0040 | JAVA0040 Switch statement contains N cases (maximum: M) | |
| PROGRAM_LENGTH | Halstead program length | |
| JAVA0145 | JAVA0145 Tab character used in source file | |
| OPERANDS | Number of operands | |
| SIZE | Size of the file in bytes | |
| JAVA0171 | JAVA0171 Unused local variable | |
| JAVA0031 | JAVA0031 Case statement not properly closed | |
| COMPARISONS | Number of comparison operators | |
| JAVA0076 | JAVA0076 Use of magic number | |
| JAVA0109 | JAVA0109 Incorrect javadoc: no parameter 'parameter' | |
| FUNCTIONS | Number of function declarations | |
| PROGRAM_VOCAB | Halstead program vocabulary | |
| UNIQUE_OPERANDS | Number of unique operands | |
| EXITS | Procedure exits | |
| RETURNS | Number of return points from functions | |
| PROGRAM_VOLUME | Halstead program volume | |
| DECL_COMMENTS | Comments in declarations | |
| INTERFACE_COMPLEXITY | Interface complexity | |
| JAVA0136 | JAVA0136 N methods defined in class (maximum: M) | |
| JAVA0032 | JAVA0032 Switch statement missing default | |
| JAVA0126 | JAVA0126 Method declares unchecked exception in throws | |
| UNIQUE_OPERATORS | Number of unique operators | |
| LINE_COMMENT | Number of line comments | |
| EXEC_COMMENTS | Comments in executable code | |
| JAVA0254 | JAVA0254 Use enhanced for loop construct instead of Iterator | |
/*
* $Header: /cvsroot/l2j/L2_Gameserver/java/net/sf/l2j/gameserver/model/Inventory.java,v 1.13 2004/11/07 12:59:43 l2chef Exp $
*
* $Author: l2chef $
* $Date: 2004/11/07 12:59:43 $
* $Revision: 1.13 $
* $Log: Inventory.java,v $
* Revision 1.13 2004/11/07 12:59:43 l2chef
* pdef mdef mpbonus are calculated in inventory now
*
* Revision 1.12 2004/10/17 06:48:04 l2chef
* no more direct access to Item collection to avoid wrong usage
* fixed double adena reduction on dropItem
*
* Revision 1.11 2004/09/28 20:31:30 l2chef
* full armor slot handling fixed
*
* Revision 1.10 2004/09/25 22:43:11 l2chef
* fixed adena dupe bug
*
* Revision 1.9 2004/09/18 01:41:39 whatev66
* added private store buy/sell
*
* Revision 1.6 2004/07/30 22:29:41 l2chef
* player status gets updated when destroying equiped items (NuocNam)
*
* Revision 1.5 2004/07/12 20:54:40 l2chef
* warehouses added (nuocnan)
* char data is now stored in subfolder data/accounts
*
* Revision 1.4 2004/07/04 19:15:13 l2chef
* fixed bug with picking up adena
*
* Revision 1.3 2004/07/04 11:13:27 l2chef
* logging is used instead of system.out
*
* Revision 1.2 2004/06/27 08:51:42 jeichhorn
* Added copyright notice
*
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2, or (at your option)
* any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA
* 02111-1307, USA.
*
* http://www.gnu.org/copyleft/gpl.html
*/
package net.sf.l2j.gameserver.model;
import java.util.ArrayList;
import java.util.Iterator;
import java.util.logging.Logger;
import net.sf.l2j.gameserver.ItemTable;
import net.sf.l2j.gameserver.templates.L2Armor;
import net.sf.l2j.gameserver.templates.L2Item;
import net.sf.l2j.gameserver.templates.L2Weapon;
/**
* This class ...
*
* @version $Revision: 1.13 $ $Date: 2004/11/07 12:59:43 $
*/
public class Inventory
{
private static Logger _log = Logger.getLogger(Inventory.class.getName());
public static final int PAPERDOLL_UNDER = 0;
public static final int PAPERDOLL_LEAR = 1;
public static final int PAPERDOLL_REAR = 2;
public static final int PAPERDOLL_NECK = 3;
public static final int PAPERDOLL_LFINGER = 4;
public static final int PAPERDOLL_RFINGER = 5;
public static final int PAPERDOLL_HEAD = 6;
public static final int PAPERDOLL_RHAND = 7;
public static final int PAPERDOLL_LHAND = 8;
public static final int PAPERDOLL_GLOVES = 9;
public static final int PAPERDOLL_CHEST = 10;
public static final int PAPERDOLL_LEGS = 11;
public static final int PAPERDOLL_FEET = 12;
public static final int PAPERDOLL_BACK = 13;
public static final int PAPERDOLL_LRHAND = 14;
private L2ItemInstance[] _paperdoll;
private L2ItemInstance _adena;
private ArrayList _items;
private int _totalWeight;
private int _mpBonus;
private int _mDef;
private int _pDef;
public Inventory()
{
_paperdoll = new L2ItemInstance[0x10];
_items = new ArrayList();
}
public int getSize()
{
return _items.size();
}
public L2ItemInstance[] getItems()
{
return (L2ItemInstance[]) _items.toArray(new L2ItemInstance[_items.size()]);
}
public L2ItemInstance addItem(L2ItemInstance newItem)
{
L2ItemInstance result = newItem;
boolean stackableFound = false;
if (newItem.getItemId() == 57)
{
addAdena(newItem.getCount());
return _adena;
}
if (newItem.isStackable())
{
int itemId = newItem.getItemId();
L2ItemInstance old = findItemByItemId(itemId);
if (old != null)
{
old.setCount(old.getCount()+newItem.getCount()); // add new item to existing stack
stackableFound = true;
old.setLastChange(L2ItemInstance.MODIFIED);
result = old;
}
}
if (!stackableFound)
{
_items.add(newItem);
newItem.setLastChange((L2ItemInstance.ADDED));
}
refreshWeight();
return result;
}
public L2ItemInstance findItemByItemId(int itemId)
{
for (int i=0; i<_items.size();i++)
{
L2ItemInstance temp = (L2ItemInstance)_items.get(i);
if (temp.getItemId() == itemId)
{
return temp;
}
}
return null;
}
/**
* @return
*/
public L2ItemInstance getPaperdollItem(int slot)
{
return _paperdoll[slot];
}
public int getPaperdollItemId(int slot)
{
if (_paperdoll[slot] != null)
{
return _paperdoll[slot].getItemId();
}
else
{
return 0;
}
}
public int getPaperdollObjectId(int slot)
{
if (_paperdoll[slot] != null)
{
return _paperdoll[slot].getObjectId();
}
else
{
return 0;
}
}
/**
* equips an item in the given slot. the item has to be already in the inventory
* @param underwear
*/
public void setPaperdollItem(int slot, L2ItemInstance item)
{
_paperdoll[slot] = item;
item.setEquipSlot(slot);
refreshWeight();
}
/**
* @param slot
*/
public L2ItemInstance[] unEquipItemInBodySlot(int slot)
{
ArrayList unequipedItems = new ArrayList();
_log.fine("--- unequip body slot:" + slot);
int pdollSlot = -1;
L2ItemInstance item = null;
switch (slot)
{
case L2Item.SLOT_L_EAR:
{
pdollSlot = PAPERDOLL_LEAR;
break;
}
case L2Item.SLOT_R_EAR:
{
pdollSlot = PAPERDOLL_REAR;
break;
}
case L2Item.SLOT_NECK:
{
pdollSlot = PAPERDOLL_NECK;
break;
}
case L2Item.SLOT_R_FINGER:
{
pdollSlot = PAPERDOLL_RFINGER;
break;
}
case L2Item.SLOT_L_FINGER:
{
pdollSlot = PAPERDOLL_LFINGER;
break;
}
case L2Item.SLOT_HEAD:
{
pdollSlot = PAPERDOLL_HEAD;
break;
}
case L2Item.SLOT_R_HAND:
{
pdollSlot = PAPERDOLL_RHAND;
break;
}
case L2Item.SLOT_L_HAND:
{
pdollSlot = PAPERDOLL_LHAND;
break;
}
case L2Item.SLOT_GLOVES:
{
pdollSlot = PAPERDOLL_GLOVES;
break;
}
case L2Item.SLOT_CHEST:
case L2Item.SLOT_FULL_ARMOR:
{
pdollSlot = PAPERDOLL_CHEST;
break;
}
case L2Item.SLOT_LEGS:
{
pdollSlot = PAPERDOLL_LEGS;
break;
}
case L2Item.SLOT_LR_HAND:
{
unEquipSlot(unequipedItems, PAPERDOLL_LHAND);
unEquipSlot(PAPERDOLL_RHAND);// this should be the same as in LRHAND
pdollSlot = PAPERDOLL_LRHAND;
break;
}
case L2Item.SLOT_BACK:
{
pdollSlot = PAPERDOLL_BACK;
break;
}
case L2Item.SLOT_FEET:
{
pdollSlot = PAPERDOLL_FEET;
break;
}
case L2Item.SLOT_UNDERWEAR:
{
pdollSlot = PAPERDOLL_UNDER;
break;
}
}
unEquipSlot(unequipedItems, pdollSlot);
return (L2ItemInstance[]) unequipedItems.toArray(new L2ItemInstance[unequipedItems.size()]);
}
/**
* same as unEquipItemFromBodySlot, but can be used with L2ItemInstance.getEquipSlot()
* @param slot
*/
public L2ItemInstance[] unEquipItemOnPaperdoll(int pdollSlot)
{
ArrayList unequipedItems = new ArrayList();
_log.fine("--- unequip body slot:" + pdollSlot);
L2ItemInstance item = null;
if (pdollSlot == PAPERDOLL_LRHAND)
{
unEquipSlot(unequipedItems, PAPERDOLL_LHAND);
unEquipSlot(PAPERDOLL_RHAND);// this should be the same as in LRHAND
}
unEquipSlot(unequipedItems, pdollSlot);
return (L2ItemInstance[]) unequipedItems.toArray(new L2ItemInstance[unequipedItems.size()]);
}
/**
*
* @param item
* @return arraylist of all items that were updated
*/
public ArrayList equipItem(L2ItemInstance item)
{
ArrayList changedItems = new ArrayList();
int targetSlot = item.getItem().getBodyPart();
switch (targetSlot)
{
case L2Item.SLOT_LR_HAND:
{
unEquipSlot(changedItems, PAPERDOLL_LHAND);
L2ItemInstance old1 = unEquipSlot(PAPERDOLL_LRHAND);
if (old1 != null)
{
// exchange 2h for 2h
changedItems.add(old1);
unEquipSlot(PAPERDOLL_RHAND);
unEquipSlot(changedItems, PAPERDOLL_LHAND);
}
else
{
unEquipSlot(changedItems, PAPERDOLL_RHAND);
}
setPaperdollItem(PAPERDOLL_RHAND, item);
setPaperdollItem(PAPERDOLL_LRHAND, item);
if (((L2Weapon)item.getItem()).getWeaponType() == L2Weapon.WEAPON_TYPE_BOW)
{
L2ItemInstance arrow = findArrowForBow(item.getItem());
if (arrow != null)
{
setPaperdollItem(PAPERDOLL_LHAND, arrow);
arrow.setLastChange(L2ItemInstance.MODIFIED);
changedItems.add(arrow);
}
}
break;
}
case L2Item.SLOT_L_HAND:
{
L2ItemInstance old1 = unEquipSlot(PAPERDOLL_LRHAND);
if (old1 != null)
{
unEquipSlot(changedItems, PAPERDOLL_RHAND);
}
unEquipSlot(changedItems, PAPERDOLL_LHAND);
setPaperdollItem(PAPERDOLL_LHAND, item);
break;
}
case L2Item.SLOT_R_HAND:
{
if (unEquipSlot(changedItems, PAPERDOLL_LRHAND))
{
unEquipSlot(changedItems, PAPERDOLL_LHAND);
unEquipSlot(PAPERDOLL_RHAND);
}
else
{
unEquipSlot(changedItems, PAPERDOLL_RHAND);
}
setPaperdollItem(PAPERDOLL_RHAND, item);
break;
}
case L2Item.SLOT_L_EAR | L2Item.SLOT_R_EAR:
{
if (_paperdoll[PAPERDOLL_LEAR] == null)
{
setPaperdollItem(PAPERDOLL_LEAR, item);
}
else if (_paperdoll[PAPERDOLL_REAR] == null)
{
setPaperdollItem(PAPERDOLL_REAR, item);
}
else
{
unEquipSlot(changedItems, PAPERDOLL_LEAR);
setPaperdollItem(PAPERDOLL_LEAR, item);
}
break;
}
case L2Item.SLOT_L_FINGER | L2Item.SLOT_R_FINGER:
{
if (_paperdoll[PAPERDOLL_LFINGER] == null)
{
setPaperdollItem(PAPERDOLL_LFINGER, item);
}
else if (_paperdoll[PAPERDOLL_RFINGER] == null)
{
setPaperdollItem(PAPERDOLL_RFINGER, item);
}
else
{
unEquipSlot(changedItems, PAPERDOLL_LFINGER);
setPaperdollItem(PAPERDOLL_LFINGER, item);
}
break;
}
case L2Item.SLOT_NECK:
{
unEquipSlot(changedItems, PAPERDOLL_NECK);
setPaperdollItem(PAPERDOLL_NECK, item);
break;
}
case L2Item.SLOT_FULL_ARMOR:
{
unEquipSlot(changedItems, PAPERDOLL_CHEST);
unEquipSlot(changedItems, PAPERDOLL_LEGS);
setPaperdollItem(PAPERDOLL_CHEST, item);
break;
}
case L2Item.SLOT_CHEST:
{
unEquipSlot(changedItems, PAPERDOLL_CHEST);
setPaperdollItem(PAPERDOLL_CHEST, item);
break;
}
case L2Item.SLOT_LEGS:
{
// handle full armor
L2ItemInstance chest = getPaperdollItem(PAPERDOLL_CHEST);
if (chest != null && chest.getItem().getBodyPart() == L2Item.SLOT_FULL_ARMOR)
{
unEquipSlot(changedItems, PAPERDOLL_CHEST);
}
unEquipSlot(changedItems, PAPERDOLL_LEGS);
setPaperdollItem(PAPERDOLL_LEGS, item);
break;
}
case L2Item.SLOT_FEET:
{
unEquipSlot(changedItems, PAPERDOLL_FEET);
setPaperdollItem(PAPERDOLL_FEET, item);
break;
}
case L2Item.SLOT_GLOVES:
{
unEquipSlot(changedItems, PAPERDOLL_GLOVES);
setPaperdollItem(PAPERDOLL_GLOVES, item);
break;
}
case L2Item.SLOT_HEAD:
{
unEquipSlot(changedItems, PAPERDOLL_HEAD);
setPaperdollItem(PAPERDOLL_HEAD, item);
break;
}
case L2Item.SLOT_UNDERWEAR:
{
unEquipSlot(changedItems, PAPERDOLL_UNDER);
setPaperdollItem(PAPERDOLL_UNDER, item);
break;
}
case L2Item.SLOT_BACK:
{
unEquipSlot(changedItems, PAPERDOLL_BACK);
setPaperdollItem(PAPERDOLL_BACK, item);
break;
}
default:
{
_log.warning("unknown body slot:" + targetSlot);
}
}
L2Item template = item.getItem();
if (template instanceof L2Armor)
{
L2Armor armor = (L2Armor)template;
_mDef += armor.getMDef();
_pDef += armor.getPDef();
_mpBonus += armor.getMpBonus();
}
changedItems.add(item);
item.setLastChange(L2ItemInstance.MODIFIED);
return changedItems;
}
private L2ItemInstance unEquipSlot(int slot)
{
_log.fine("--- unEquipSlot: "+ slot);
L2ItemInstance item =_paperdoll[slot];
if (item != null)
{
item.setEquipSlot(-1);
item.setLastChange(L2ItemInstance.MODIFIED);
_paperdoll[slot] = null;
L2Item template = item.getItem();
if (template instanceof L2Armor)
{
L2Armor armor = (L2Armor)template;
_mDef -= armor.getMDef();
_pDef -= armor.getPDef();
_mpBonus -= armor.getMpBonus();
}
}
return item;
}
/**
* @returns true if an item was unequiped
*/
private boolean unEquipSlot(ArrayList changedItems, int slot)
{
if (slot == -1)
{
// invalid slot
return false;
}
L2ItemInstance item =_paperdoll[slot];
if (item != null)
{
item.setEquipSlot(-1);
changedItems.add(item);
item.setLastChange(L2ItemInstance.MODIFIED);
_paperdoll[slot] = null;
L2Item template = item.getItem();
if (template instanceof L2Armor)
{
L2Armor armor = (L2Armor)template;
_mDef -= armor.getMDef();
_pDef -= armor.getPDef();
_mpBonus -= armor.getMpBonus();
}
}
return item != null;
}
/**
* @param objectId
* @return
*/
public L2ItemInstance getItem(int objectId)
{
for (int i = 0; i < _items.size(); i++)
{
L2ItemInstance temp = (L2ItemInstance) _items.get(i);
if (temp.getObjectId() == objectId)
{
return temp;
}
}
return null;
}
/**
* @return
*/
public L2ItemInstance getAdenaInstance()
{
return _adena;
}
/**
* @return
*/
public int getAdena()
{
if (_adena == null)
{
return 0;
}
else
{
return _adena.getCount();
}
}
public void setAdena(int adena)
{
if (adena == 0)
{
if ( _adena != null && _items.contains(_adena))
{
_items.remove(_adena);
_adena = null;
}
}
else
{
if (_adena == null)
{
_adena = ItemTable.getInstance().createItem(57);
}
_adena.setCount(adena);
if (!_items.contains(_adena))
{
_items.add(_adena);
}
}
}
/**
* @param adena
*/
public void addAdena(int adena)
{
setAdena(getAdena() + adena);
}
public void reduceAdena(int adena)
{
setAdena(getAdena() - adena);
}
/**
* @param objectId
*/
public L2ItemInstance destroyItem(int objectId, int count)
{
L2ItemInstance item = getItem(objectId);
if (item.getCount() == count)
{
_items.remove(item);
item.setCount(0);
item.setLastChange(L2ItemInstance.REMOVED);
}
else
{
item.setCount(item.getCount()-count);
item.setLastChange(L2ItemInstance.MODIFIED);
}
refreshWeight();
return item;
}
// we need this one cuz warehouses send itemId only
/**
* @param objectId
*/
public L2ItemInstance destroyItemByItemId(int itemId, int count)
{
L2ItemInstance item = findItemByItemId(itemId);
if (item.getCount() == count)
{
_items.remove(item);
item.setCount(0);
item.setLastChange(L2ItemInstance.REMOVED);
}
else
{
item.setCount(item.getCount()-count);
item.setLastChange(L2ItemInstance.MODIFIED);
}
refreshWeight();
return item;
}
/**
* @param objectId
*/
public L2ItemInstance dropItem(int objectId, int count)
{
L2ItemInstance oldItem = getItem(objectId);
return dropItem(oldItem, count);
}
/**
* @param oldItem
* @param count
* @return
*/
public L2ItemInstance dropItem(L2ItemInstance oldItem, int count)
{
if (oldItem == null)
{
_log.warning("DropItem: item id does not exist in inventory");
return null;
}
if (oldItem.isEquipped())
{
unEquipItemInBodySlot(oldItem.getItem().getBodyPart());
}
if (oldItem.getItemId() == 57)
{
reduceAdena(count);
L2ItemInstance adena = ItemTable.getInstance().createItem(oldItem.getItemId());
adena.setCount(count);
return adena;
}
else if (oldItem.getCount() == count)
{
_log.fine(" count = count --> remove");
_items.remove(oldItem);
oldItem.setLastChange(L2ItemInstance.REMOVED);
refreshWeight();
return oldItem;
}
else
{
_log.fine(" count != count --> reduce");
oldItem.setCount(oldItem.getCount()-count);
oldItem.setLastChange(L2ItemInstance.MODIFIED);
L2ItemInstance newItem = ItemTable.getInstance().createItem(oldItem.getItemId());
newItem.setCount(count);
refreshWeight();
return newItem;
}
}
private void refreshWeight()
{
int weight = 0;
for (Iterator iter = _items.iterator(); iter.hasNext();)
{
L2ItemInstance element = (L2ItemInstance) iter.next();
weight += element.getItem().getWeight() * element.getCount();
}
_totalWeight = weight;
}
/**
* @return Returns the totalWeight.
*/
public int getTotalWeight()
{
return _totalWeight;
}
public L2ItemInstance findArrowForBow(L2Item bow)
{
int arrowsId = 0;
switch (bow.getCrystalType())
{
case (L2Weapon.CRYSTAL_NONE):
{
arrowsId = 17;
break;
}
case (L2Weapon.CRYSTAL_D):
{
arrowsId = 1341;
break;
}
case (L2Weapon.CRYSTAL_C):
{
arrowsId = 1342;
break;
}
case (L2Weapon.CRYSTAL_B):
{
arrowsId = 1343;
break;
}
case (L2Weapon.CRYSTAL_A):
{
arrowsId = 1344;
break;
}
case (L2Weapon.CRYSTAL_S):
{
arrowsId = 1345;
break;
}
default:
{
// broken weapon.csv ??
arrowsId = 17;
break;
}
}
return findItemByItemId(arrowsId);
}
public int getMDef()
{
return _mDef;
}
public int getMpBonus()
{
return _mpBonus;
}
public int getPDef()
{
return _pDef;
}
}
The table below shows all metrics for Inventory.java.
| Metric | Value | Description | |
|---|---|---|---|
| BLOCKS | 117.00 | Number of blocks | |
| BLOCK_COMMENT | 57.00 | Number of block comment lines | |
| COMMENTS | 119.00 | Comment lines | |
| COMMENT_DENSITY | 0.30 | Comment density | |
| COMPARISONS | 47.00 | Number of comparison operators | |
| CYCLOMATIC | 109.00 | Cyclomatic complexity | |
| DECL_COMMENTS | 18.00 | Comments in declarations | |
| DOC_COMMENT | 57.00 | Number of javadoc comment lines | |
| ELOC | 398.00 | Effective lines of code | |
| EXEC_COMMENTS | 4.00 | Comments in executable code | |
| EXITS | 45.00 | Procedure exits | |
| FUNCTIONS | 30.00 | Number of function declarations | |
| HALSTEAD_DIFFICULTY | 96.89 | Halstead difficulty | |
| HALSTEAD_EFFORT | 0.00 | Halstead effort | |
| INTERFACE_COMPLEXITY | 66.00 | Interface complexity | |
| JAVA0001 | 1.00 | JAVA0001 Package name does not contain only lower case letters | |
| JAVA0002 | 0.00 | JAVA0002 Package name does not begin with a top level domain name or country code | |
| JAVA0003 | 0.00 | JAVA0003 Minimize use of on-demand (.*) imports | |
| JAVA0004 | 0.00 | JAVA0004 Unnecessary import from java.lang | |
| JAVA0005 | 0.00 | JAVA0005 Imports not in specified order | |
| JAVA0006 | 0.00 | JAVA0006 Empty finally block | |
| JAVA0007 | 0.00 | JAVA0007 Should not declare public field | |
| JAVA0008 | 0.00 | JAVA0008 Empty catch block | |
| JAVA0009 | 0.00 | JAVA0009 Protected member in final class | |
| JAVA0010 | 0.00 | JAVA0010 Non-instantiable class does not contain a non-private static member | |
| JAVA0011 | 0.00 | JAVA0011 Abstract class does not contain an abstract method | |
| JAVA0012 | 0.00 | JAVA0012 Non-constructor method with same name as declaring class | |
| JAVA0013 | 0.00 | JAVA0013 Non-blank final field is not static | |
| JAVA0014 | 0.00 | JAVA0014 Class with only static members has non-private constructor | |
| JAVA0015 | 0.00 | JAVA0015 Package class contains public nested type | |
| JAVA0016 | 0.00 | JAVA0016 Abstract class contains public constructor | |
| JAVA0017 | 0.00 | JAVA0017 Class name does not have required form | |
| JAVA0018 | 0.00 | JAVA0018 Method name does not have required form | |
| JAVA0019 | 0.00 | JAVA0019 Interface name does not have required form | |
| JAVA0020 | 7.00 | JAVA0020 Field name does not have required form | |
| JAVA0021 | 0.00 | JAVA0021 Interface method name does not have required form | |
| JAVA0022 | 0.00 | JAVA0022 Static final field name does not have required form | |
| JAVA0023 | 0.00 | JAVA0023 Empty finalize method | |
| JAVA0024 | 0.00 | JAVA0024 Empty class | |
| JAVA0025 | 0.00 | JAVA0025 Method override is empty | |
| JAVA0026 | 0.00 | JAVA0026 Finalize method with parameters | |
| JAVA0029 | 0.00 | JAVA0029 Private method not used | |
| JAVA0030 | 0.00 | JAVA0030 Private field not used | |
| JAVA0031 | 1.00 | JAVA0031 Case statement not properly closed | |
| JAVA0032 | 1.00 | JAVA0032 Switch statement missing default | |
| JAVA0033 | 0.00 | JAVA0033 default: not last case in switch statement | |
| JAVA0034 | 0.00 | JAVA0034 Missing braces in if statement | |
| JAVA0035 | 0.00 | JAVA0035 Missing braces in for statement | |
| JAVA0036 | 0.00 | JAVA0036 Missing braces in while statement | |
| JAVA0038 | 0.00 | JAVA0038 Non-case label in switch statement | |
| JAVA0039 | 0.00 | JAVA0039 Break statement with label | |
| JAVA0040 | 2.00 | JAVA0040 Switch statement contains N cases (maximum: M) | |
| JAVA0041 | 0.00 | JAVA0041 Nested synchronized block | |
| JAVA0042 | 0.00 | JAVA0042 Empty synchronized statement | |
| JAVA0043 | 0.00 | JAVA0043 Inner class does not use outer class | |
| JAVA0044 | 0.00 | JAVA0044 Serializable class with no instance variables | |
| JAVA0045 | 0.00 | JAVA0045 Serializable class with only transient fields | |
| JAVA0046 | 0.00 | JAVA0046 Name of class not derived from Exception ends with 'Exception' | |
| JAVA0047 | 0.00 | JAVA0047 Serializable class derives from invalid base class | |
| JAVA0048 | 0.00 | JAVA0048 Name of class derived from Exception does not end with 'Exception' | |
| JAVA0049 | 0.00 | JAVA0049 Nested block at depth N (maximum: M) | |
| JAVA0050 | 0.00 | JAVA0050 Class derives from java.lang.Error | |
| JAVA0051 | 0.00 | JAVA0051 Class derives from java.lang.RuntimeException | |
| JAVA0052 | 0.00 | JAVA0052 Class derives from java.lang.Throwable | |
| JAVA0053 | 0.00 | JAVA0053 Unused label | |
| JAVA0054 | 0.00 | JAVA0054 Inheritance depth N exceeds maximum M | |
| JAVA0055 | 0.00 | JAVA0055 Class should be interface | |
| JAVA0056 | 0.00 | JAVA0056 Unnecessary abstract modifier for interface or annotation | |
| JAVA0057 | 0.00 | JAVA0057 Unnecessary default constructor | |
| JAVA0058 | 0.00 | JAVA0058 Constructor calls super() | |
| JAVA0059 | 0.00 | JAVA0059 Method override only calls super() | |
| JAVA0061 | 0.00 | JAVA0061 Inaccessible member in anonymous class | |
| JAVA0062 | 0.00 | JAVA0062 Public class missing public member or protected constructor | |
| JAVA0063 | 0.00 | JAVA0063 Identifier name should not contain '$' | |
| JAVA0064 | 0.00 | JAVA0064 N variations of identifier name (maximum: M) | |
| JAVA0065 | 0.00 | JAVA0065 Unnecessary final modifier for method in final class | |
| JAVA0066 | 0.00 | JAVA0066 Unnecessary modifier for interface nested type | |
| JAVA0067 | 0.00 | JAVA0067 Array descriptor on identifier name | |
| JAVA0068 | 0.00 | JAVA0068 Modifiers not declared in recommended order | |
| JAVA0071 | 0.00 | JAVA0071 Strings compared with == | |
| JAVA0073 | 0.00 | JAVA0073 Integer division in floating-point context | |
| JAVA0074 | 0.00 | JAVA0074 Use of Object.notify() | |
| JAVA0075 | 0.00 | JAVA0075 Method parameter hides field | |
| JAVA0076 | 5.00 | JAVA0076 Use of magic number | |
| JAVA0077 | 0.00 | JAVA0077 Private field not used in declaring class | |
| JAVA0078 | 0.00 | JAVA0078 Floating point values compared with == | |
| JAVA0079 | 0.00 | JAVA0079 Use of instance to reference static member | |
| JAVA0080 | 0.00 | JAVA0080 Import declaration not used | |
| JAVA0081 | 0.00 | JAVA0081 Boolean literal in comparison | |
| JAVA0082 | 0.00 | JAVA0082 Unnecessary widening cast | |
| JAVA0083 | 0.00 | JAVA0083 Unnecessary instanceof test | |
| JAVA0084 | 0.00 | JAVA0084 Should use compound assignment operator | |
| JAVA0085 | 0.00 | JAVA0085 Use of sun.* class | |
| JAVA0087 | 0.00 | JAVA0087 Use of Thread.sleep() | |
| JAVA0089 | 0.00 | JAVA0089 Use of restricted package | |
| JAVA0092 | 0.00 | JAVA0092 Use of restricted type | |
| JAVA0093 | 0.00 | JAVA0093 Redundant assignment | |
| JAVA0094 | 0.00 | JAVA0094 Field hides a superclass field | |
| JAVA0095 | 0.00 | JAVA0095 Uninitialized private field | |
| JAVA0096 | 0.00 | JAVA0096 Field in nested class hides outer field | |
| JAVA0098 | 0.00 | JAVA0098 Minimize use of implicit field initializers | |
| JAVA0100 | 0.00 | JAVA0100 Class contains N non-final fields (maximum: M) | |
| JAVA0101 | 0.00 | JAVA0101 Unnecessary modifier for field in interface | |
| JAVA0102 | 0.00 | JAVA0102 Last statement in finalize() not super.finalize() | |
| JAVA0103 | 0.00 | JAVA0103 Explicit call to finalize() | |
| JAVA0104 | 0.00 | JAVA0104 finalize() only calls super.finalize() | |
| JAVA0105 | 0.00 | JAVA0105 Duplicate import declaration | |
| JAVA0106 | 0.00 | JAVA0106 Unnecessary import from current package | |
| JAVA0108 | 10.00 | JAVA0108 Incorrect javadoc: no @param tag for 'parameter' | |
| JAVA0109 | 3.00 | JAVA0109 Incorrect javadoc: no parameter 'parameter' | |
| JAVA0110 | 6.00 | JAVA0110 Incorrect javadoc: no @return tag | |
| JAVA0111 | 0.00 | JAVA0111 Incorrect javadoc: @return tag for void method | |
| JAVA0112 | 0.00 | JAVA0112 Incorrect javadoc: no exception 'exception' in throws | |
| JAVA0113 | 1.00 | JAVA0113 Incorrect javadoc: no @author tag | |
| JAVA0114 | 0.00 | JAVA0114 Incorrect javadoc: no @version tag | |
| JAVA0115 | 0.00 | JAVA0115 Incorrect javadoc: no @throws or @exception tag for 'exception' | |
| JAVA0116 | 15.00 | JAVA0116 Missing javadoc: field 'field' | |
| JAVA0117 | 13.00 | JAVA0117 Missing javadoc: method 'method' | |
| JAVA0118 | 0.00 | JAVA0118 Missing javadoc: type 'type' | |
| JAVA0119 | 0.00 | JAVA0119 Control variable changed within body of for loop | |
| JAVA0123 | 0.00 | JAVA0123 Use all three components of for loop | |
| JAVA0125 | 0.00 | JAVA0125 Continue statement with label | |
| JAVA0126 | 0.00 | JAVA0126 Method declares unchecked exception in throws | |
| JAVA0128 | 0.00 | JAVA0128 Public constructor in non-public class | |
| JAVA0130 | 0.00 | JAVA0130 Non-static method does not use instance fields | |
| JAVA0131 | 0.00 | JAVA0131 Compatible method does not override base | |
| JAVA0132 | 0.00 | JAVA0132 Method overload with compatible signature | |
| JAVA0133 | 0.00 | JAVA0133 Non-synchronized method overrides synchronized method | |
| JAVA0135 | 0.00 | JAVA0135 Only one of Object.equals and Object.hashCode defined: missing 'method' | |
| JAVA0136 | 1.00 | JAVA0136 N methods defined in class (maximum: M) | |
| JAVA0137 | 0.00 | JAVA0137 Non-abstract class missing constructor | |
| JAVA0138 | 0.00 | JAVA0138 N parameters defined for method (maximum: M) | |
| JAVA0139 | 0.00 | JAVA0139 Definition of main other than public static void main(java.lang.String[]) | |
| JAVA0141 | 0.00 | JAVA0141 Unnecessary modifier for method in interface | |
| JAVA0143 | 0.00 | JAVA0143 Synchronized method | |
| JAVA0144 | 0.00 | JAVA0144 Line exceeds maximum M characters | |
| JAVA0145 | 1888.00 | JAVA0145 Tab character used in source file | |
| JAVA0150 | 0.00 | JAVA0150 java.lang.Error (or subclass) thrown | |
| JAVA0153 | 0.00 | JAVA0153 Inefficient conversion of integer to string | |
| JAVA0159 | 0.00 | JAVA0159 Inefficient conversion of string to integer | |
| JAVA0160 | 0.00 | JAVA0160 Method does not throw specified exception | |
| JAVA0161 | 0.00 | JAVA0161 Conditional wait() not in loop | |
| JAVA0163 | 0.00 | JAVA0163 Empty statement | |
| JAVA0165 | 0.00 | JAVA0165 Conflicting return statement in finally block | |
| JAVA0166 | 0.00 | JAVA0166 Generic exception caught | |
| JAVA0167 | 0.00 | JAVA0167 ThreadDeath not rethrown | |
| JAVA0169 | 0.00 | JAVA0169 Unnecessary catch block: exception 'exception' | |
| JAVA0170 | 0.00 | JAVA0170 Caught exception not derived from java.lang.Exception | |
| JAVA0171 | 2.00 | JAVA0171 Unused local variable | |
| JAVA0173 | 0.00 | JAVA0173 Unused method parameter | |
| JAVA0174 | 0.00 | JAVA0174 Assigned local variable never used | |
| JAVA0175 | 0.00 | JAVA0175 Successive assignment to variable | |
| JAVA0176 | 0.00 | JAVA0176 Local variable name does not have required form | |
| JAVA0177 | 0.00 | JAVA0177 Variable declaration missing initializer | |
| JAVA0179 | 0.00 | JAVA0179 Local variable hides visible field | |
| JAVA0233 | 0.00 | JAVA0233 Definition of serialVersionUID other than 'private static final long serialVersionUID' | |
| JAVA0234 | 0.00 | JAVA0234 Class is Serializable but does not define serialVersionUID | |
| JAVA0235 | 0.00 | JAVA0235 Class defines serialVersionUID but does not implement Serializable | |
| JAVA0236 | 0.00 | JAVA0236 Attempt to clone an object which does not implement Cloneable | |
| JAVA0237 | 0.00 | JAVA0237 Class implements Cloneable but does not have public clone method | |
| JAVA0238 | 0.00 | JAVA0238 Clone method does not call super.clone() | |
| JAVA0239 | 0.00 | JAVA0239 Class declares 'readObject' or 'writeObject' but does not implement Serializable | |
| JAVA0240 | 0.00 | JAVA0240 Serializable class which declares readObject or writeObject but not both | |
| JAVA0241 | 0.00 | JAVA0241 'readObject' or 'writeObject' should be declared private in Serializable class | |
| JAVA0242 | 0.00 | JAVA0242 Transient field in non-Serializable class | |
| JAVA0243 | 0.00 | JAVA0243 'readResolve' or 'writeReplace' should be declared private or protected | |
| JAVA0244 | 0.00 | JAVA0244 Field or method name in subclass differs only by case from inherited field or method | |
| JAVA0245 | 0.00 | JAVA0245 JUnit TestCase with non-trivial constructor | |
| JAVA0246 | 0.00 | JAVA0246 JUnit assertXXX statement missing message parameter | |
| JAVA0247 | 0.00 | JAVA0247 JUnit 'setUp()' and 'tearDown()' should call super method | |
| JAVA0248 | 0.00 | JAVA0248 JUnit method 'setUp' or 'tearDown' with incorrect signature | |
| JAVA0249 | 0.00 | JAVA0249 JUnit TestCase 'suite()' should be declared static | |
| JAVA0250 | 0.00 | JAVA0250 JUnit TestCase declares testXXX method with incorrect signature | |
| JAVA0251 | 0.00 | JAVA0251 Use '%n' for line breaks in printf/format for platform independence | |
| JAVA0252 | 0.00 | JAVA0252 'enum' is a Java 1.5 reserved word | |
| JAVA0253 | 0.00 | JAVA0253 Not all enum constants consumed in switch statement | |
| JAVA0254 | 1.00 | JAVA0254 Use enhanced for loop construct instead of Iterator | |
| JAVA0255 | 0.00 | JAVA0255 Result of method invocation not used | |
| JAVA0256 | 0.00 | JAVA0256 Assignment of external collection/array to field | |
| JAVA0257 | 0.00 | JAVA0257 Use of 'Constant Interface' anti-pattern | |
| JAVA0258 | 0.00 | JAVA0258 Implement Iterable for foreach compatibility | |
| JAVA0259 | 0.00 | JAVA0259 Return of collection/array field | |
| JAVA0260 | 0.00 | JAVA0260 Use 'enum' instead of Enumerated Type pattern | |
| JAVA0261 | 0.00 | JAVA0261 Use specialized Enum collection types | |
| JAVA0262 | 0.00 | JAVA0262 Use of char in integer context | |
| JAVA0263 | 0.00 | JAVA0263 Long literal ends with 'l' instead of 'L' | |
| JAVA0264 | 0.00 | JAVA0264 Integer math in long context - check for overflow | |
| JAVA0265 | 0.00 | JAVA0265 Use of Throwable.printStackTrace() | |
| JAVA0266 | 0.00 | JAVA0266 Use of System.out | |
| JAVA0267 | 0.00 | JAVA0267 Use of System.err | |
| JAVA0269 | 0.00 | JAVA0269 Contents of StringBuffer never used | |
| JAVA0270 | 0.00 | JAVA0270 Use Java 5.0 enhanced for loop construct to iterate over all elements in an array | |
| JAVA0271 | 0.00 | JAVA0271 Minimize use of on-demand (.*) static imports | |
| JAVA0272 | 0.00 | JAVA0272 Thread.run() called | |
| JAVA0273 | 0.00 | JAVA0273 Non-final derivative of Thread calls start() in constructor | |
| JAVA0274 | 0.00 | JAVA0274 Serializable class has a synchronized readObject() | |
| JAVA0275 | 0.00 | JAVA0275 Serializable class has a synchronized writeObject() and no other synchronized methods | |
| JAVA0276 | 0.00 | JAVA0276 Unnecessary use of String constructor | |
| JAVA0277 | 0.00 | JAVA0277 Iterator.next() implementation does not throw NoSuchElementException | |
| JAVA0278 | 0.00 | JAVA0278 Unnecessary use of Boolean constructor | |
| JAVA0279 | 0.00 | JAVA0279 Serialization method readObject or readObjectNoData calls an overridable method | |
| JAVA0280 | 0.00 | JAVA0280 IllegalMonitorStateException caught | |
| JAVA0281 | 0.00 | JAVA0281 Iterator.next() not called in loop | |
| JAVA0282 | 0.00 | JAVA0282 Call to Iterator.next() in loop which does not test Iterator.hasNext() | |
| JAVA0283 | 0.00 | JAVA0283 Control variable not updated in loop body | |
| JAVA0284 | 0.00 | JAVA0284 Explicit garbage collection | |
| JAVA0285 | 0.00 | JAVA0285 Dereference of potentially null variable | |
| JAVA0286 | 0.00 | JAVA0286 Dereference of null variable | |
| JAVA0287 | 0.00 | JAVA0287 Unnecessary null check | |
| JAVA0288 | 0.00 | JAVA0288 Inconsistent null check | |
| LINES | 842.00 | Number of lines in the source file | |
| LINE_COMMENT | 5.00 | Number of line comments | |
| LOC | 640.00 | Lines of code | |
| LOGICAL_LINES | 282.00 | Number of statements | |
| LOOPS | 3.00 | Number of loops | |
| NEST_DEPTH | 4.00 | Maximum nesting depth | |
| OPERANDS | 931.00 | Number of operands | |
| OPERATORS | 1921.00 | Number of operators | |
| PARAMS | 26.00 | Number of formal parameter declarations | |
| PROGRAM_LENGTH | 2852.00 | Halstead program length | |
| PROGRAM_VOCAB | 267.00 | Halstead program vocabulary | |
| PROGRAM_VOLUME | 0.00 | Halstead program volume | |
| RETURNS | 40.00 | Number of return points from functions | |
| SIZE | 17666.00 | Size of the file in bytes | |
| UNIQUE_OPERANDS | 221.00 | Number of unique operands | |
| UNIQUE_OPERATORS | 46.00 | Number of unique operators | |
| WHITESPACE | 83.00 | Number of whitespace lines | |