AreaCombatData.java
| Index Score | ||
|---|---|---|
 |
 |
net.sourceforge.kolmafia |
 |
 |
KoLmafia |
View: Reasons, Metrics, Source Code
These are the metrics that contribute to the Enerjy Score for this file, ranked by impact. So the metrics listed at the top influence the score to a greater extent that the metrics listed at the bottom.
| Metric | Description | |
|---|---|---|
| JAVA0117 | JAVA0117 Missing javadoc: method 'method' |  |
| JAVA0076 | JAVA0076 Use of magic number | |
| COMPARISONS | Number of comparison operators | |
| JAVA0034 | JAVA0034 Missing braces in if statement | |
| EXITS | Procedure exits | |
| OPERATORS | Number of operators | |
| PROGRAM_LENGTH | Halstead program length | |
| LOGICAL_LINES | Number of statements | |
| LOC | Lines of code | |
| UNIQUE_OPERANDS | Number of unique operands | |
| PROGRAM_VOCAB | Halstead program vocabulary | |
| OPERANDS | Number of operands | |
| INTERFACE_COMPLEXITY | Interface complexity | |
| PARAMS | Number of formal parameter declarations | |
| CYCLOMATIC | Cyclomatic complexity | |
| BLOCKS | Number of blocks | |
| RETURNS | Number of return points from functions | |
| ELOC | Effective lines of code | |
| LINES | Number of lines in the source file | |
| JAVA0144 | JAVA0144 Line exceeds maximum M characters | |
| PROGRAM_VOLUME | Halstead program volume | |
| SIZE | Size of the file in bytes | |
| JAVA0136 | JAVA0136 N methods defined in class (maximum: M) | |
| JAVA0138 | JAVA0138 N parameters defined for method (maximum: M) | |
| JAVA0078 | JAVA0078 Floating point values compared with == | |
| JAVA0126 | JAVA0126 Method declares unchecked exception in throws | |
| JAVA0110 | JAVA0110 Incorrect javadoc: no @return tag | |
| EXEC_COMMENTS | Comments in executable code | |
| UNIQUE_OPERATORS | Number of unique operators | |
| JAVA0108 | JAVA0108 Incorrect javadoc: no @param tag for 'parameter' | |
| COMMENTS | Comment lines | |
| DECL_COMMENTS | Comments in declarations | |
| FUNCTIONS | Number of function declarations | |
| DOC_COMMENT | Number of javadoc comment lines | |
| JAVA0130 | JAVA0130 Non-static method does not use instance fields | |
/**
* Copyright (c) 2005-2008, KoLmafia development team
* http://kolmafia.sourceforge.net/
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
*
* [1] Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* [2] Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in
* the documentation and/or other materials provided with the
* distribution.
* [3] Neither the name "KoLmafia" nor the names of its contributors may
* be used to endorse or promote products derived from this software
* without specific prior written permission.
*
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
* FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
* COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
* INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
* BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
* LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
* CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
* ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
* POSSIBILITY OF SUCH DAMAGE.
*/
package net.sourceforge.kolmafia;
import java.util.ArrayList;
import java.util.List;
import net.sourceforge.kolmafia.persistence.MonsterDatabase;
import net.sourceforge.kolmafia.persistence.MonsterDatabase.Monster;
import net.sourceforge.kolmafia.session.EquipmentManager;
import net.sourceforge.kolmafia.utilities.StringUtilities;
public class AreaCombatData
{
private static float lastDropModifier = 0.0f;
private static float lastDropMultiplier = 0.0f;
private int minHit;
private int maxHit;
private int minEvade;
private int maxEvade;
private final int combats;
private int weights;
// Parallel lists: monsters and encounter weighting
private final List monsters;
private final List weightings;
public AreaCombatData( final int combats )
{
this.monsters = new ArrayList();
this.weightings = new ArrayList();
this.combats = combats;
this.weights = 0;
this.minHit = Integer.MAX_VALUE;
this.maxHit = 0;
this.minEvade = Integer.MAX_VALUE;
this.maxEvade = 0;
}
public boolean addMonster( String name )
{
int weighting = 1;
int colon = name.indexOf( ":" );
if ( colon > 0 )
{
weighting = StringUtilities.parseInt( name.substring( colon + 1 ).trim() );
name = name.substring( 0, colon );
}
Monster monster = MonsterDatabase.findMonster( name, false );
if ( monster == null )
{
return false;
}
this.monsters.add( monster );
this.weightings.add( new Integer( weighting ) );
// Don't let ultra-rare monsters skew hit and evade numbers -
// or anything else.
if ( weighting < 0 )
{
return true;
}
// Don't let special monsters skew combat percentage numbers
// or things derived from them, like area-wide item and meat
// drops. Do include them in hit and evade ("safety") numbers.
if ( weighting > 0 )
{
this.weights += weighting;
}
int attack = monster.getAttack();
if ( attack < this.minEvade )
{
this.minEvade = attack;
}
if ( attack > this.maxEvade )
{
this.maxEvade = attack;
}
int defense = monster.getDefense();
if ( defense < this.minHit )
{
this.minHit = defense;
}
if ( defense > this.maxHit )
{
this.maxHit = defense;
}
return true;
}
public int getMonsterCount()
{
return this.monsters.size();
}
public Monster getMonster( final int i )
{
return (Monster) this.monsters.get( i );
}
public boolean hasMonster( final Monster m )
{
if ( m == null )
{
return false;
}
return this.monsters.contains( m );
}
public int getWeighting( final int i )
{
return ( (Integer) this.weightings.get( i ) ).intValue();
}
public int combats()
{
return this.combats;
}
public int minHit()
{
return this.minHit == Integer.MAX_VALUE ? 0 : this.minHit;
}
public int maxHit()
{
return this.maxHit;
}
public int minEvade()
{
return this.minEvade == Integer.MAX_VALUE ? 0 : this.minEvade;
}
public int maxEvade()
{
return this.maxEvade;
}
public boolean willHitSomething()
{
int ml = KoLCharacter.getMonsterLevelAdjustment();
int hitStat = EquipmentManager.getAdjustedHitStat();
return AreaCombatData.hitPercent( hitStat - ml, this.minHit() ) > 0.0f;
}
public String toString()
{
return this.toString( false );
}
public String toString( final boolean fullString )
{
StringBuffer buffer = new StringBuffer();
buffer.append( "<html>" );
this.getSummary( buffer, fullString );
buffer.append( "<br><br>" );
this.getMonsterData( buffer, fullString );
buffer.append( "</html>" );
return buffer.toString();
}
public void getSummary( final StringBuffer buffer, final boolean fullString )
{
int ml = KoLCharacter.getMonsterLevelAdjustment();
int moxie = KoLCharacter.getAdjustedMoxie() - ml;
String statName = EquipmentManager.getHitStatType() == KoLConstants.MOXIE ? "Mox" : "Mus";
int hitstat = EquipmentManager.getAdjustedHitStat() - ml;
float minHitPercent = AreaCombatData.hitPercent( hitstat, this.minHit() );
float maxHitPercent = AreaCombatData.hitPercent( hitstat, this.maxHit );
int minPerfectHit = AreaCombatData.perfectHit( hitstat, this.minHit() );
int maxPerfectHit = AreaCombatData.perfectHit( hitstat, this.maxHit );
float minEvadePercent = AreaCombatData.hitPercent( moxie, this.minEvade() );
float maxEvadePercent = AreaCombatData.hitPercent( moxie, this.maxEvade );
int minPerfectEvade = AreaCombatData.perfectHit( moxie, this.minEvade() );
int maxPerfectEvade = AreaCombatData.perfectHit( moxie, this.maxEvade );
// statGain constants
FamiliarData familiar = KoLCharacter.getFamiliar();
float experienceAdjustment = KoLCharacter.getExperienceAdjustment();
// Area Combat percentage
float combatFactor = this.areaCombatPercent() / 100.0f;
// Iterate once through monsters to calculate average statGain
float averageExperience = 0.0f;
for ( int i = 0; i < this.monsters.size(); ++i )
{
int weighting = this.getWeighting( i );
// Omit ultra-rare (-1) and special (0) monsters
if ( weighting < 1 )
{
continue;
}
Monster monster = this.getMonster( i );
float weight = (float) weighting / (float) this.weights;
averageExperience += weight * monster.getAdjustedExperience( experienceAdjustment, ml, familiar );
}
buffer.append( "<b>Hit</b>: " );
buffer.append( this.getRateString(
minHitPercent, minPerfectHit, maxHitPercent, maxPerfectHit, statName, fullString ) );
buffer.append( "<br><b>Evade</b>: " );
buffer.append( this.getRateString(
minEvadePercent, minPerfectEvade, maxEvadePercent, maxPerfectEvade, "Mox", fullString ) );
buffer.append( "<br><b>Combat Rate</b>: " );
if ( this.combats > 0 )
{
buffer.append( this.format( combatFactor * 100.0f ) + "%" );
buffer.append( "<br><b>Combat XP</b>: " + KoLConstants.FLOAT_FORMAT.format( averageExperience * combatFactor ) );
}
else if ( this.combats == 0 )
{
buffer.append( "0%" );
}
else
{
buffer.append( "No data" );
}
}
public void getMonsterData( final StringBuffer buffer, final boolean fullString )
{
int ml = KoLCharacter.getMonsterLevelAdjustment();
int moxie = KoLCharacter.getAdjustedMoxie() - ml;
int hitstat = EquipmentManager.getAdjustedHitStat() - ml;
float combatFactor = this.areaCombatPercent() / 100.0f;
for ( int i = 0; i < this.monsters.size(); ++i )
{
if ( i > 0 )
{
buffer.append( "<br><br>" );
}
buffer.append( this.getMonsterString(
this.getMonster( i ), moxie, hitstat, ml, this.getWeighting( i ), combatFactor, fullString ) );
}
}
private String format( final float percentage )
{
return String.valueOf( (int) percentage );
}
private float areaCombatPercent()
{
// If we don't have the data, pretend it's all combat
if ( this.combats < 0 )
{
return 100.0f;
}
// Some areas are inherently all combat or no combat
if ( this.combats == 0 || this.combats == 100 )
{
return this.combats;
}
float pct = this.combats + KoLCharacter.getCombatRateAdjustment();
return Math.max( 0.0f, Math.min( 100.0f, pct ) );
}
private String getRateString( final float minPercent, final int minMargin, final float maxPercent,
final int maxMargin, final String statName, boolean fullString )
{
StringBuffer buffer = new StringBuffer();
buffer.append( this.format( minPercent ) );
buffer.append( "%/" );
buffer.append( this.format( maxPercent ) );
buffer.append( "%" );
if ( !fullString )
{
return buffer.toString();
}
buffer.append( " (" );
buffer.append( statName );
if ( minMargin >= 0 )
{
buffer.append( "+" );
}
buffer.append( minMargin );
buffer.append( "/" );
if ( maxMargin >= 0 )
{
buffer.append( "+" );
}
buffer.append( maxMargin );
buffer.append( ")" );
return buffer.toString();
}
private String getMonsterString( final Monster monster, final int moxie, final int hitstat, final int ml,
final int weighting, final float combatFactor, final boolean fullString )
{
// moxie and hitstat already adjusted for monster level
int defense = monster.getDefense();
float hitPercent = AreaCombatData.hitPercent( hitstat, defense );
int attack = monster.getAttack();
float evadePercent = AreaCombatData.hitPercent( moxie, attack );
int health = monster.getAdjustedHP( ml );
float statGain = monster.getExperience();
StringBuffer buffer = new StringBuffer();
int ed = monster.getDefenseElement();
int ea = monster.getAttackElement();
int element = ed == MonsterDatabase.NONE ? ea : ed;
// Color the monster name according to its element
buffer.append( " <font color=" + AreaCombatData.elementColor( element ) + "><b>" );
buffer.append( monster.getName() );
buffer.append( "</b></font> (" );
if ( weighting < 0 )
{
buffer.append( "ultra-rare" );
}
else if ( weighting == 0 )
{
buffer.append( "special" );
}
else
{
buffer.append( this.format( 100.0f * combatFactor * weighting / this.weights ) + "%" );
}
buffer.append( ")<br>Hit: <font color=" + AreaCombatData.elementColor( ed ) + ">" );
buffer.append( this.format( hitPercent ) );
buffer.append( "%</font>, Evade: <font color=" + AreaCombatData.elementColor( ea ) + ">" );
buffer.append( this.format( evadePercent ) );
buffer.append( "%</font><br>HP: " + health + ", XP: " + KoLConstants.FLOAT_FORMAT.format( statGain ) );
if ( fullString )
{
this.appendMeatDrop( buffer, monster );
}
this.appendItemList( buffer, monster.getItems(), monster.getPocketRates(), fullString );
return buffer.toString();
}
private void appendMeatDrop( final StringBuffer buffer, final Monster monster )
{
int minMeat = monster.getMinMeat();
int maxMeat = monster.getMaxMeat();
if ( minMeat == 0 && maxMeat == 0 )
{
return;
}
float modifier = ( KoLCharacter.getMeatDropPercentAdjustment() + 100.0f ) / 100.0f;
buffer.append( "<br>Meat: " + this.format( minMeat * modifier ) + "-" + this.format( maxMeat * modifier ) + " (" + this.format( ( minMeat + maxMeat ) * modifier / 2.0f ) + " average)" );
}
private void appendItemList( final StringBuffer buffer, final List items, final List pocketRates, boolean fullString )
{
if ( items.size() == 0 )
{
return;
}
float itemModifier = AreaCombatData.getDropRateModifier();
for ( int i = 0; i < items.size(); ++i )
{
AdventureResult item = (AdventureResult) items.get( i );
if ( !fullString )
{
if ( i == 0 )
{
buffer.append( "<br>" );
}
else
{
buffer.append( ", " );
}
buffer.append( item.getName() );
continue;
}
buffer.append( "<br>" );
float stealRate =
KoLCharacter.isMoxieClass() && !KoLCharacter.canInteract() ? ( (Float) pocketRates.get( i ) ).floatValue() : 0.0f;
float dropRate = Math.min( item.getCount() * itemModifier, 100.0f );
float effectiveDropRate = stealRate * 100.0f + ( 1.0f - stealRate ) * dropRate;
String rate1 = this.format( dropRate );
String rate2 = this.format( effectiveDropRate );
buffer.append( item.getName() );
buffer.append( " (" );
buffer.append( rate2 );
if ( !rate1.equals( rate2 ) )
{
buffer.append( "%, " );
buffer.append( rate1 );
buffer.append( "%, " );
buffer.append( this.format( stealRate * 100.0f ) );
}
buffer.append( "%)" );
}
}
public static final float getDropRateModifier()
{
if ( AreaCombatData.lastDropMultiplier != 0.0f && KoLCharacter.getItemDropPercentAdjustment() == AreaCombatData.lastDropModifier )
{
return AreaCombatData.lastDropMultiplier;
}
AreaCombatData.lastDropModifier = KoLCharacter.getItemDropPercentAdjustment();
AreaCombatData.lastDropMultiplier = ( 100.0f + AreaCombatData.lastDropModifier ) / 100.0f;
return AreaCombatData.lastDropMultiplier;
}
public static final String elementColor( final int element )
{
if ( element == MonsterDatabase.HEAT )
{
return "#ff0000";
}
if ( element == MonsterDatabase.COLD )
{
return "#0000ff";
}
if ( element == MonsterDatabase.STENCH )
{
return "#008000";
}
if ( element == MonsterDatabase.SPOOKY )
{
return "#808080";
}
if ( element == MonsterDatabase.SLEAZE )
{
return "#8a2be2";
}
return "#000000";
}
public static final float hitPercent( final int attack, final int defense )
{
// ( (Attack - Defense) / 18 ) * 100 + 50 = Hit%
float percent = 100.0f * ( attack - defense ) / 18 + 50.0f;
if ( percent < 0.0f )
{
return 0.0f;
}
if ( percent > 100.0f )
{
return 100.0f;
}
return percent;
}
public static final int perfectHit( final int attack, final int defense )
{
return attack - defense - 9;
}
}
The table below shows all metrics for AreaCombatData.java.
| Metric | Value | Description | |
|---|---|---|---|
| BLOCKS | 66.00 | Number of blocks | |
| BLOCK_COMMENT | 0.00 | Number of block comment lines | |
| COMMENTS | 47.00 | Comment lines | |
| COMMENT_DENSITY | 0.18 | Comment density | |
| COMPARISONS | 65.00 | Number of comparison operators | |
| CYCLOMATIC | 72.00 | Cyclomatic complexity | |
| DECL_COMMENTS | 2.00 | Comments in declarations | |
| DOC_COMMENT | 32.00 | Number of javadoc comment lines | |
| ELOC | 257.00 | Effective lines of code | |
| EXEC_COMMENTS | 11.00 | Comments in executable code | |
| EXITS | 61.00 | Procedure exits | |
| FUNCTIONS | 26.00 | Number of function declarations | |
| HALSTEAD_DIFFICULTY | 71.60 | Halstead difficulty | |
| HALSTEAD_EFFORT | 0.00 | Halstead effort | |
| INTERFACE_COMPLEXITY | 77.00 | Interface complexity | |
| JAVA0001 | 0.00 | JAVA0001 Package name does not contain only lower case letters | |
| JAVA0002 | 0.00 | JAVA0002 Package name does not begin with a top level domain name or country code | |
| JAVA0003 | 0.00 | JAVA0003 Minimize use of on-demand (.*) imports | |
| JAVA0004 | 0.00 | JAVA0004 Unnecessary import from java.lang | |
| JAVA0005 | 0.00 | JAVA0005 Imports not in specified order | |
| JAVA0006 | 0.00 | JAVA0006 Empty finally block | |
| JAVA0007 | 0.00 | JAVA0007 Should not declare public field | |
| JAVA0008 | 0.00 | JAVA0008 Empty catch block | |
| JAVA0009 | 0.00 | JAVA0009 Protected member in final class | |
| JAVA0010 | 0.00 | JAVA0010 Non-instantiable class does not contain a non-private static member | |
| JAVA0011 | 0.00 | JAVA0011 Abstract class does not contain an abstract method | |
| JAVA0012 | 0.00 | JAVA0012 Non-constructor method with same name as declaring class | |
| JAVA0013 | 0.00 | JAVA0013 Non-blank final field is not static | |
| JAVA0014 | 0.00 | JAVA0014 Class with only static members has non-private constructor | |
| JAVA0015 | 0.00 | JAVA0015 Package class contains public nested type | |
| JAVA0016 | 0.00 | JAVA0016 Abstract class contains public constructor | |
| JAVA0017 | 0.00 | JAVA0017 Class name does not have required form | |
| JAVA0018 | 0.00 | JAVA0018 Method name does not have required form | |
| JAVA0019 | 0.00 | JAVA0019 Interface name does not have required form | |
| JAVA0020 | 0.00 | JAVA0020 Field name does not have required form | |
| JAVA0021 | 0.00 | JAVA0021 Interface method name does not have required form | |
| JAVA0022 | 0.00 | JAVA0022 Static final field name does not have required form | |
| JAVA0023 | 0.00 | JAVA0023 Empty finalize method | |
| JAVA0024 | 0.00 | JAVA0024 Empty class | |
| JAVA0025 | 0.00 | JAVA0025 Method override is empty | |
| JAVA0026 | 0.00 | JAVA0026 Finalize method with parameters | |
| JAVA0029 | 0.00 | JAVA0029 Private method not used | |
| JAVA0030 | 0.00 | JAVA0030 Private field not used | |
| JAVA0031 | 0.00 | JAVA0031 Case statement not properly closed | |
| JAVA0032 | 0.00 | JAVA0032 Switch statement missing default | |
| JAVA0033 | 0.00 | JAVA0033 default: not last case in switch statement | |
| JAVA0034 | 0.00 | JAVA0034 Missing braces in if statement | |
| JAVA0035 | 0.00 | JAVA0035 Missing braces in for statement | |
| JAVA0036 | 0.00 | JAVA0036 Missing braces in while statement | |
| JAVA0038 | 0.00 | JAVA0038 Non-case label in switch statement | |
| JAVA0039 | 0.00 | JAVA0039 Break statement with label | |
| JAVA0040 | 0.00 | JAVA0040 Switch statement contains N cases (maximum: M) | |
| JAVA0041 | 0.00 | JAVA0041 Nested synchronized block | |
| JAVA0042 | 0.00 | JAVA0042 Empty synchronized statement | |
| JAVA0043 | 0.00 | JAVA0043 Inner class does not use outer class | |
| JAVA0044 | 0.00 | JAVA0044 Serializable class with no instance variables | |
| JAVA0045 | 0.00 | JAVA0045 Serializable class with only transient fields | |
| JAVA0046 | 0.00 | JAVA0046 Name of class not derived from Exception ends with 'Exception' | |
| JAVA0047 | 0.00 | JAVA0047 Serializable class derives from invalid base class | |
| JAVA0048 | 0.00 | JAVA0048 Name of class derived from Exception does not end with 'Exception' | |
| JAVA0049 | 0.00 | JAVA0049 Nested block at depth N (maximum: M) | |
| JAVA0050 | 0.00 | JAVA0050 Class derives from java.lang.Error | |
| JAVA0051 | 0.00 | JAVA0051 Class derives from java.lang.RuntimeException | |
| JAVA0052 | 0.00 | JAVA0052 Class derives from java.lang.Throwable | |
| JAVA0053 | 0.00 | JAVA0053 Unused label | |
| JAVA0054 | 0.00 | JAVA0054 Inheritance depth N exceeds maximum M | |
| JAVA0055 | 0.00 | JAVA0055 Class should be interface | |
| JAVA0056 | 0.00 | JAVA0056 Unnecessary abstract modifier for interface or annotation | |
| JAVA0057 | 0.00 | JAVA0057 Unnecessary default constructor | |
| JAVA0058 | 0.00 | JAVA0058 Constructor calls super() | |
| JAVA0059 | 0.00 | JAVA0059 Method override only calls super() | |
| JAVA0061 | 0.00 | JAVA0061 Inaccessible member in anonymous class | |
| JAVA0062 | 0.00 | JAVA0062 Public class missing public member or protected constructor | |
| JAVA0063 | 0.00 | JAVA0063 Identifier name should not contain '$' | |
| JAVA0064 | 1.00 | JAVA0064 N variations of identifier name (maximum: M) | |
| JAVA0065 | 0.00 | JAVA0065 Unnecessary final modifier for method in final class | |
| JAVA0066 | 0.00 | JAVA0066 Unnecessary modifier for interface nested type | |
| JAVA0067 | 0.00 | JAVA0067 Array descriptor on identifier name | |
| JAVA0068 | 0.00 | JAVA0068 Modifiers not declared in recommended order | |
| JAVA0071 | 0.00 | JAVA0071 Strings compared with == | |
| JAVA0073 | 0.00 | JAVA0073 Integer division in floating-point context | |
| JAVA0074 | 0.00 | JAVA0074 Use of Object.notify() | |
| JAVA0075 | 0.00 | JAVA0075 Method parameter hides field | |
| JAVA0076 | 16.00 | JAVA0076 Use of magic number | |
| JAVA0077 | 0.00 | JAVA0077 Private field not used in declaring class | |
| JAVA0078 | 2.00 | JAVA0078 Floating point values compared with == | |
| JAVA0079 | 0.00 | JAVA0079 Use of instance to reference static member | |
| JAVA0080 | 0.00 | JAVA0080 Import declaration not used | |
| JAVA0081 | 0.00 | JAVA0081 Boolean literal in comparison | |
| JAVA0082 | 0.00 | JAVA0082 Unnecessary widening cast | |
| JAVA0083 | 0.00 | JAVA0083 Unnecessary instanceof test | |
| JAVA0084 | 0.00 | JAVA0084 Should use compound assignment operator | |
| JAVA0085 | 0.00 | JAVA0085 Use of sun.* class | |
| JAVA0087 | 0.00 | JAVA0087 Use of Thread.sleep() | |
| JAVA0089 | 0.00 | JAVA0089 Use of restricted package | |
| JAVA0092 | 0.00 | JAVA0092 Use of restricted type | |
| JAVA0093 | 0.00 | JAVA0093 Redundant assignment | |
| JAVA0094 | 0.00 | JAVA0094 Field hides a superclass field | |
| JAVA0095 | 0.00 | JAVA0095 Uninitialized private field | |
| JAVA0096 | 0.00 | JAVA0096 Field in nested class hides outer field | |
| JAVA0098 | 0.00 | JAVA0098 Minimize use of implicit field initializers | |
| JAVA0100 | 0.00 | JAVA0100 Class contains N non-final fields (maximum: M) | |
| JAVA0101 | 0.00 | JAVA0101 Unnecessary modifier for field in interface | |
| JAVA0102 | 0.00 | JAVA0102 Last statement in finalize() not super.finalize() | |
| JAVA0103 | 0.00 | JAVA0103 Explicit call to finalize() | |
| JAVA0104 | 0.00 | JAVA0104 finalize() only calls super.finalize() | |
| JAVA0105 | 0.00 | JAVA0105 Duplicate import declaration | |
| JAVA0106 | 0.00 | JAVA0106 Unnecessary import from current package | |
| JAVA0108 | 0.00 | JAVA0108 Incorrect javadoc: no @param tag for 'parameter' | |
| JAVA0109 | 0.00 | JAVA0109 Incorrect javadoc: no parameter 'parameter' | |
| JAVA0110 | 0.00 | JAVA0110 Incorrect javadoc: no @return tag | |
| JAVA0111 | 0.00 | JAVA0111 Incorrect javadoc: @return tag for void method | |
| JAVA0112 | 0.00 | JAVA0112 Incorrect javadoc: no exception 'exception' in throws | |
| JAVA0113 | 0.00 | JAVA0113 Incorrect javadoc: no @author tag | |
| JAVA0114 | 0.00 | JAVA0114 Incorrect javadoc: no @version tag | |
| JAVA0115 | 0.00 | JAVA0115 Incorrect javadoc: no @throws or @exception tag for 'exception' | |
| JAVA0116 | 0.00 | JAVA0116 Missing javadoc: field 'field' | |
| JAVA0117 | 19.00 | JAVA0117 Missing javadoc: method 'method' | |
| JAVA0118 | 1.00 | JAVA0118 Missing javadoc: type 'type' | |
| JAVA0119 | 0.00 | JAVA0119 Control variable changed within body of for loop | |
| JAVA0123 | 0.00 | JAVA0123 Use all three components of for loop | |
| JAVA0125 | 0.00 | JAVA0125 Continue statement with label | |
| JAVA0126 | 0.00 | JAVA0126 Method declares unchecked exception in throws | |
| JAVA0128 | 0.00 | JAVA0128 Public constructor in non-public class | |
| JAVA0130 | 1.00 | JAVA0130 Non-static method does not use instance fields | |
| JAVA0131 | 0.00 | JAVA0131 Compatible method does not override base | |
| JAVA0132 | 0.00 | JAVA0132 Method overload with compatible signature | |
| JAVA0133 | 0.00 | JAVA0133 Non-synchronized method overrides synchronized method | |
| JAVA0135 | 0.00 | JAVA0135 Only one of Object.equals and Object.hashCode defined: missing 'method' | |
| JAVA0136 | 1.00 | JAVA0136 N methods defined in class (maximum: M) | |
| JAVA0137 | 0.00 | JAVA0137 Non-abstract class missing constructor | |
| JAVA0138 | 2.00 | JAVA0138 N parameters defined for method (maximum: M) | |
| JAVA0139 | 0.00 | JAVA0139 Definition of main other than public static void main(java.lang.String[]) | |
| JAVA0141 | 0.00 | JAVA0141 Unnecessary modifier for method in interface | |
| JAVA0143 | 0.00 | JAVA0143 Synchronized method | |
| JAVA0144 | 2.00 | JAVA0144 Line exceeds maximum M characters | |
| JAVA0145 | 805.00 | JAVA0145 Tab character used in source file | |
| JAVA0150 | 0.00 | JAVA0150 java.lang.Error (or subclass) thrown | |
| JAVA0153 | 0.00 | JAVA0153 Inefficient conversion of integer to string | |
| JAVA0159 | 0.00 | JAVA0159 Inefficient conversion of string to integer | |
| JAVA0160 | 0.00 | JAVA0160 Method does not throw specified exception | |
| JAVA0161 | 0.00 | JAVA0161 Conditional wait() not in loop | |
| JAVA0163 | 0.00 | JAVA0163 Empty statement | |
| JAVA0165 | 0.00 | JAVA0165 Conflicting return statement in finally block | |
| JAVA0166 | 0.00 | JAVA0166 Generic exception caught | |
| JAVA0167 | 0.00 | JAVA0167 ThreadDeath not rethrown | |
| JAVA0169 | 0.00 | JAVA0169 Unnecessary catch block: exception 'exception' | |
| JAVA0170 | 0.00 | JAVA0170 Caught exception not derived from java.lang.Exception | |
| JAVA0171 | 0.00 | JAVA0171 Unused local variable | |
| JAVA0173 | 0.00 | JAVA0173 Unused method parameter | |
| JAVA0174 | 0.00 | JAVA0174 Assigned local variable never used | |
| JAVA0175 | 0.00 | JAVA0175 Successive assignment to variable | |
| JAVA0176 | 0.00 | JAVA0176 Local variable name does not have required form | |
| JAVA0177 | 0.00 | JAVA0177 Variable declaration missing initializer | |
| JAVA0179 | 0.00 | JAVA0179 Local variable hides visible field | |
| JAVA0233 | 0.00 | JAVA0233 Definition of serialVersionUID other than 'private static final long serialVersionUID' | |
| JAVA0234 | 0.00 | JAVA0234 Class is Serializable but does not define serialVersionUID | |
| JAVA0235 | 0.00 | JAVA0235 Class defines serialVersionUID but does not implement Serializable | |
| JAVA0236 | 0.00 | JAVA0236 Attempt to clone an object which does not implement Cloneable | |
| JAVA0237 | 0.00 | JAVA0237 Class implements Cloneable but does not have public clone method | |
| JAVA0238 | 0.00 | JAVA0238 Clone method does not call super.clone() | |
| JAVA0239 | 0.00 | JAVA0239 Class declares 'readObject' or 'writeObject' but does not implement Serializable | |
| JAVA0240 | 0.00 | JAVA0240 Serializable class which declares readObject or writeObject but not both | |
| JAVA0241 | 0.00 | JAVA0241 'readObject' or 'writeObject' should be declared private in Serializable class | |
| JAVA0242 | 0.00 | JAVA0242 Transient field in non-Serializable class | |
| JAVA0243 | 0.00 | JAVA0243 'readResolve' or 'writeReplace' should be declared private or protected | |
| JAVA0244 | 0.00 | JAVA0244 Field or method name in subclass differs only by case from inherited field or method | |
| JAVA0245 | 0.00 | JAVA0245 JUnit TestCase with non-trivial constructor | |
| JAVA0246 | 0.00 | JAVA0246 JUnit assertXXX statement missing message parameter | |
| JAVA0247 | 0.00 | JAVA0247 JUnit 'setUp()' and 'tearDown()' should call super method | |
| JAVA0248 | 0.00 | JAVA0248 JUnit method 'setUp' or 'tearDown' with incorrect signature | |
| JAVA0249 | 0.00 | JAVA0249 JUnit TestCase 'suite()' should be declared static | |
| JAVA0250 | 0.00 | JAVA0250 JUnit TestCase declares testXXX method with incorrect signature | |
| JAVA0251 | 0.00 | JAVA0251 Use '%n' for line breaks in printf/format for platform independence | |
| JAVA0252 | 0.00 | JAVA0252 'enum' is a Java 1.5 reserved word | |
| JAVA0253 | 0.00 | JAVA0253 Not all enum constants consumed in switch statement | |
| JAVA0254 | 0.00 | JAVA0254 Use enhanced for loop construct instead of Iterator | |
| JAVA0255 | 0.00 | JAVA0255 Result of method invocation not used | |
| JAVA0256 | 0.00 | JAVA0256 Assignment of external collection/array to field | |
| JAVA0257 | 0.00 | JAVA0257 Use of 'Constant Interface' anti-pattern | |
| JAVA0258 | 0.00 | JAVA0258 Implement Iterable for foreach compatibility | |
| JAVA0259 | 0.00 | JAVA0259 Return of collection/array field | |
| JAVA0260 | 0.00 | JAVA0260 Use 'enum' instead of Enumerated Type pattern | |
| JAVA0261 | 0.00 | JAVA0261 Use specialized Enum collection types | |
| JAVA0262 | 0.00 | JAVA0262 Use of char in integer context | |
| JAVA0263 | 0.00 | JAVA0263 Long literal ends with 'l' instead of 'L' | |
| JAVA0264 | 0.00 | JAVA0264 Integer math in long context - check for overflow | |
| JAVA0265 | 0.00 | JAVA0265 Use of Throwable.printStackTrace() | |
| JAVA0266 | 0.00 | JAVA0266 Use of System.out | |
| JAVA0267 | 0.00 | JAVA0267 Use of System.err | |
| JAVA0269 | 0.00 | JAVA0269 Contents of StringBuffer never used | |
| JAVA0270 | 0.00 | JAVA0270 Use Java 5.0 enhanced for loop construct to iterate over all elements in an array | |
| JAVA0271 | 0.00 | JAVA0271 Minimize use of on-demand (.*) static imports | |
| JAVA0272 | 0.00 | JAVA0272 Thread.run() called | |
| JAVA0273 | 0.00 | JAVA0273 Non-final derivative of Thread calls start() in constructor | |
| JAVA0274 | 0.00 | JAVA0274 Serializable class has a synchronized readObject() | |
| JAVA0275 | 0.00 | JAVA0275 Serializable class has a synchronized writeObject() and no other synchronized methods | |
| JAVA0276 | 0.00 | JAVA0276 Unnecessary use of String constructor | |
| JAVA0277 | 0.00 | JAVA0277 Iterator.next() implementation does not throw NoSuchElementException | |
| JAVA0278 | 0.00 | JAVA0278 Unnecessary use of Boolean constructor | |
| JAVA0279 | 0.00 | JAVA0279 Serialization method readObject or readObjectNoData calls an overridable method | |
| JAVA0280 | 0.00 | JAVA0280 IllegalMonitorStateException caught | |
| JAVA0281 | 0.00 | JAVA0281 Iterator.next() not called in loop | |
| JAVA0282 | 0.00 | JAVA0282 Call to Iterator.next() in loop which does not test Iterator.hasNext() | |
| JAVA0283 | 0.00 | JAVA0283 Control variable not updated in loop body | |
| JAVA0284 | 0.00 | JAVA0284 Explicit garbage collection | |
| JAVA0285 | 0.00 | JAVA0285 Dereference of potentially null variable | |
| JAVA0286 | 0.00 | JAVA0286 Dereference of null variable | |
| JAVA0287 | 0.00 | JAVA0287 Unnecessary null check | |
| JAVA0288 | 0.00 | JAVA0288 Inconsistent null check | |
| LINES | 531.00 | Number of lines in the source file | |
| LINE_COMMENT | 15.00 | Number of line comments | |
| LOC | 391.00 | Lines of code | |
| LOGICAL_LINES | 190.00 | Number of statements | |
| LOOPS | 3.00 | Number of loops | |
| NEST_DEPTH | 4.00 | Maximum nesting depth | |
| OPERANDS | 821.00 | Number of operands | |
| OPERATORS | 1675.00 | Number of operators | |
| PARAMS | 35.00 | Number of formal parameter declarations | |
| PROGRAM_LENGTH | 2496.00 | Halstead program length | |
| PROGRAM_VOCAB | 303.00 | Halstead program vocabulary | |
| PROGRAM_VOLUME | 0.00 | Halstead program volume | |
| RETURNS | 42.00 | Number of return points from functions | |
| SIZE | 14794.00 | Size of the file in bytes | |
| UNIQUE_OPERANDS | 258.00 | Number of unique operands | |
| UNIQUE_OPERATORS | 45.00 | Number of unique operators | |
| WHITESPACE | 93.00 | Number of whitespace lines | |