StandardMessageRouter.java
| Index Score | ||
|---|---|---|
 |
 |
com.limegroup.gnutella |
 |
 |
FrostWire |
View: Reasons, Metrics, Source Code
These are the metrics that contribute to the Enerjy Score for this file, ranked by impact. So the metrics listed at the top influence the score to a greater extent that the metrics listed at the bottom.
| Metric | Description | |
|---|---|---|
| LINE_COMMENT | Number of line comments |  |
| EXEC_COMMENTS | Comments in executable code | |
| JAVA0034 | JAVA0034 Missing braces in if statement | |
| PARAMS | Number of formal parameter declarations | |
| EXITS | Procedure exits | |
| UNIQUE_OPERANDS | Number of unique operands | |
| PROGRAM_VOCAB | Halstead program vocabulary | |
| SIZE | Size of the file in bytes | |
| OPERANDS | Number of operands | |
| PROGRAM_LENGTH | Halstead program length | |
| INTERFACE_COMPLEXITY | Interface complexity | |
| ELOC | Effective lines of code | |
| COMPARISONS | Number of comparison operators | |
| OPERATORS | Number of operators | |
| LOC | Lines of code | |
| JAVA0035 | JAVA0035 Missing braces in for statement | |
| CYCLOMATIC | Cyclomatic complexity | |
| LOGICAL_LINES | Number of statements | |
| UNIQUE_OPERATORS | Number of unique operators | |
| LINES | Number of lines in the source file | |
| JAVA0130 | JAVA0130 Non-static method does not use instance fields | |
| JAVA0108 | JAVA0108 Incorrect javadoc: no @param tag for 'parameter' | |
| JAVA0144 | JAVA0144 Line exceeds maximum M characters | |
| JAVA0008 | JAVA0008 Empty catch block | |
| JAVA0076 | JAVA0076 Use of magic number | |
| NEST_DEPTH | Maximum nesting depth | |
| PROGRAM_VOLUME | Halstead program volume | |
| JAVA0138 | JAVA0138 N parameters defined for method (maximum: M) | |
| JAVA0126 | JAVA0126 Method declares unchecked exception in throws | |
| JAVA0117 | JAVA0117 Missing javadoc: method 'method' | |
| DECL_COMMENTS | Comments in declarations | |
| DOC_COMMENT | Number of javadoc comment lines | |
| FUNCTIONS | Number of function declarations | |
| JAVA0145 | JAVA0145 Tab character used in source file | |
package com.limegroup.gnutella;
import java.io.IOException;
import java.io.UnsupportedEncodingException;
import java.net.InetAddress;
import java.net.InetSocketAddress;
import java.net.UnknownHostException;
import java.util.ArrayList;
import java.util.Collection;
import java.util.Collections;
import java.util.LinkedList;
import java.util.List;
import java.util.Set;
import java.util.concurrent.ScheduledExecutorService;
import java.util.concurrent.TimeUnit;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
import org.limewire.io.IPPortCombo;
import org.limewire.io.IpPort;
import org.limewire.io.NetworkUtils;
import org.limewire.net.SocketsManager;
import org.limewire.security.MACCalculatorRepositoryManager;
import org.limewire.security.SecurityToken;
import com.google.inject.Inject;
import com.google.inject.Provider;
import com.google.inject.Singleton;
import com.google.inject.name.Named;
import com.limegroup.gnutella.auth.ContentManager;
import com.limegroup.gnutella.connection.RoutedConnection;
import com.limegroup.gnutella.dht.DHTManager;
import com.limegroup.gnutella.guess.OnDemandUnicaster;
import com.limegroup.gnutella.messagehandlers.InspectionRequestHandler;
import com.limegroup.gnutella.messagehandlers.OOBHandler;
import com.limegroup.gnutella.messagehandlers.UDPCrawlerPingHandler;
import com.limegroup.gnutella.messages.FeatureSearchData;
import com.limegroup.gnutella.messages.PingReply;
import com.limegroup.gnutella.messages.PingReplyFactory;
import com.limegroup.gnutella.messages.PingRequest;
import com.limegroup.gnutella.messages.PingRequestFactory;
import com.limegroup.gnutella.messages.QueryReply;
import com.limegroup.gnutella.messages.QueryReplyFactory;
import com.limegroup.gnutella.messages.QueryRequest;
import com.limegroup.gnutella.messages.QueryRequestFactory;
import com.limegroup.gnutella.messages.StaticMessages;
import com.limegroup.gnutella.messages.vendor.HeadPongFactory;
import com.limegroup.gnutella.messages.vendor.ReplyNumberVendorMessage;
import com.limegroup.gnutella.messages.vendor.ReplyNumberVendorMessageFactory;
import com.limegroup.gnutella.search.QueryDispatcher;
import com.limegroup.gnutella.search.QueryHandlerFactory;
import com.limegroup.gnutella.search.SearchResultHandler;
import com.limegroup.gnutella.settings.ChatSettings;
import com.limegroup.gnutella.settings.ConnectionSettings;
import com.limegroup.gnutella.settings.MessageSettings;
import com.limegroup.gnutella.simpp.SimppManager;
import com.limegroup.gnutella.util.DataUtils;
import com.limegroup.gnutella.version.UpdateHandler;
import com.limegroup.gnutella.xml.LimeXMLDocumentHelper;
import com.limegroup.gnutella.xml.LimeXMLUtils;
/**
* This class is the message routing implementation for TCP messages.
*/
@Singleton
public class StandardMessageRouter extends MessageRouterImpl {
private static final Log LOG = LogFactory.getLog(StandardMessageRouter.class);
private final Statistics statistics;
private final ReplyNumberVendorMessageFactory replyNumberVendorMessageFactory;
@Inject
public StandardMessageRouter(NetworkManager networkManager,
QueryRequestFactory queryRequestFactory,
QueryHandlerFactory queryHandlerFactory,
OnDemandUnicaster onDemandUnicaster,
HeadPongFactory headPongFactory, PingReplyFactory pingReplyFactory,
ConnectionManager connectionManager, @Named("forMeReplyHandler")
ReplyHandler forMeReplyHandler, QueryUnicaster queryUnicaster,
FileManager fileManager, ContentManager contentManager,
DHTManager dhtManager, UploadManager uploadManager,
DownloadManager downloadManager, UDPService udpService,
SearchResultHandler searchResultHandler,
SocketsManager socketsManager, HostCatcher hostCatcher,
QueryReplyFactory queryReplyFactory, StaticMessages staticMessages,
Provider<MessageDispatcher> messageDispatcher,
MulticastService multicastService, QueryDispatcher queryDispatcher,
Provider<ActivityCallback> activityCallback,
ConnectionServices connectionServices,
ApplicationServices applicationServices,
@Named("backgroundExecutor")
ScheduledExecutorService backgroundExecutor,
Provider<PongCacher> pongCacher,
Provider<SimppManager> simppManager,
Provider<UpdateHandler> updateHandler,
GuidMapManager guidMapManager,
UDPReplyHandlerCache udpReplyHandlerCache,
Provider<InspectionRequestHandler> inspectionRequestHandlerFactory,
Provider<UDPCrawlerPingHandler> udpCrawlerPingHandlerFactory,
Statistics statistics,
ReplyNumberVendorMessageFactory replyNumberVendorMessageFactory,
PingRequestFactory pingRequestFactory, MessageHandlerBinder messageHandlerBinder,
Provider<OOBHandler> oobHandlerFactory,
Provider<MACCalculatorRepositoryManager> MACCalculatorRepositoryManager) {
super(networkManager, queryRequestFactory, queryHandlerFactory,
onDemandUnicaster, headPongFactory, pingReplyFactory,
connectionManager, forMeReplyHandler, queryUnicaster,
fileManager, contentManager, dhtManager, uploadManager,
downloadManager, udpService, searchResultHandler,
socketsManager, hostCatcher, queryReplyFactory, staticMessages,
messageDispatcher, multicastService, queryDispatcher,
activityCallback, connectionServices, applicationServices,
backgroundExecutor, pongCacher, simppManager, updateHandler,
guidMapManager, udpReplyHandlerCache, inspectionRequestHandlerFactory,
udpCrawlerPingHandlerFactory,
pingRequestFactory, messageHandlerBinder, oobHandlerFactory,
MACCalculatorRepositoryManager);
this.statistics = statistics;
this.replyNumberVendorMessageFactory = replyNumberVendorMessageFactory;
}
/**
* Responds to a Gnutella ping with cached pongs. This does special handling
* for both "heartbeat" pings that were sent to ensure that the connection
* is still live as well as for pings from a crawler.
*
* @param ping the <tt>PingRequest</tt> to respond to
* @param handler the <tt>ReplyHandler</tt> to send any pongs to
*/
@Override
protected void respondToPingRequest(PingRequest ping,
ReplyHandler handler) {
//If this wasn't a handshake or crawler ping, check if we can accept
//incoming connection for old-style unrouted connections, ultrapeers, or
//leaves. TODO: does this mean leaves always respond to pings?
int hops = ping.getHops();
int ttl = ping.getTTL();
if ( (hops+ttl > 2)
&& !connectionManager.allowAnyConnection())
return;
// Only send pongs for ourself if we have a valid address & port.
if(NetworkUtils.isValidAddress(networkManager.getAddress()) &&
NetworkUtils.isValidPort(networkManager.getPort())) {
//SPECIAL CASE: for crawler ping
// TODO:: this means that we can never send TTL=2 pings without
// them being interpreted as from the crawler!!
if(hops ==1 && ttl==1) {
handleCrawlerPing(ping, handler);
return;
//Note that the while handling crawler ping, we dont send our
//own pong, as that is unnecessary, since crawler already has
//our address.
}
// handle heartbeat pings specially -- bypass pong caching code
if(ping.isHeartbeat()) {
sendPingReply(pingReplyFactory.create(ping.getGUID(), (byte)1),
handler);
return;
}
//send its own ping in all the cases
int newTTL = hops+1;
if ( (hops+ttl) <=2)
newTTL = 1;
// send our own pong if we have free slots or if our average
// daily uptime is more than 1/2 hour
if(connectionManager.hasFreeSlots() ||
statistics.calculateDailyUptime() > 60*30) {
PingReply pr =
pingReplyFactory.create(ping.getGUID(), (byte)newTTL);
sendPingReply(pr, handler);
}
}
List<PingReply> pongs = pongCacher.get().getBestPongs(ping.getLocale());
byte[] guid = ping.getGUID();
InetAddress pingerIP = handler.getInetAddress();
for(PingReply pr : pongs) {
if(pr.getInetAddress().equals(pingerIP))
continue;
sendPingReply(pingReplyFactory.mutateGUID(pr, guid), handler);
}
}
/**
* Responds to a ping request received over a UDP port. This is
* handled differently from all other ping requests. Instead of
* responding with cached pongs, we respond with a pong from our node.
*
* @param request the <tt>PingRequest</tt> to service
* @param addr the <tt>InetSocketAddress</tt> containing the IP
* and port of the client node
* @param handler the <tt>ReplyHandler</tt> that should handle any
* replies
*/
@Override
protected void respondToUDPPingRequest(PingRequest request,
InetSocketAddress addr,
ReplyHandler handler) {
if(!networkManager.isIpPortValid())
return;
IpPort ipport = null;
if (request.requestsIP()) {
try {
ipport = new IPPortCombo(
addr.getAddress().getHostAddress(),
addr.getPort());
} catch(IOException tooBad) { }
}
List<IpPort> dhthosts = Collections.emptyList();
int maxHosts = ConnectionSettings.NUM_RETURN_PONGS.getValue();
if (request.requestsDHTIPP() && dhtManager.isRunning()) {
dhthosts = dhtManager.getActiveDHTNodes(maxHosts);
}
int numDHTHosts = dhthosts.size();
byte[] data = request.getSupportsCachedPongData();
Collection<IpPort> gnuthosts = Collections.emptyList();
if(data != null){
boolean isUltrapeer =
data.length >= 1 &&
(data[0] & PingRequest.SCP_ULTRAPEER_OR_LEAF_MASK) ==
PingRequest.SCP_ULTRAPEER;
int dhtFraction = ConnectionSettings.DHT_TO_GNUT_HOSTS_PONG.getValue();
int maxDHTHosts = Math.round(((float)dhtFraction/100)*maxHosts);
gnuthosts = connectionServices.getPreferencedHosts(
isUltrapeer,
request.getLocale(),
maxHosts - Math.min(numDHTHosts, maxDHTHosts));
//remove extra dht hosts
dhthosts = dhthosts.subList(0, Math.min(numDHTHosts,maxHosts - gnuthosts.size()));
}
PingReply reply;
if (ipport != null)
reply = pingReplyFactory.create(request.getGUID(), (byte)1, ipport, gnuthosts, dhthosts);
else
reply = pingReplyFactory.create(request.getGUID(), (byte)1, gnuthosts, dhthosts);
if(LOG.isDebugEnabled()) {
LOG.debug("Responding to UDPPingRequest "+(request.requestsDHTIPP()?"with DHTIPP ":"") +
"from : "+ addr + " with Gnutella hosts: \n"+ gnuthosts
+ "\n and DHT hosts: \n" + dhthosts);
}
sendPingReply(reply, handler);
}
/**
* Handles the crawler ping of Hops=0 & TTL=2, by sending pongs
* corresponding to all its leaves
* @param m The ping request received
* @param handler the <tt>ReplyHandler</tt> that should handle any
* replies
*/
private void handleCrawlerPing(PingRequest m, ReplyHandler handler) {
//TODO: why is this any different than the standard pong? In other
//words, why no ultrapong marking, proper address calculation, etc?
//send the pongs for leaves
List<RoutedConnection> leafConnections = connectionManager.getInitializedClientConnections();
for(RoutedConnection connection : leafConnections) {
//create the pong for this connection
PingReply pr =
pingReplyFactory.createExternal(m.getGUID(), (byte)2,
connection.getPort(),
connection.getInetAddress().getAddress(),
false);
//hop the message, as it is ideally coming from the connected host
pr.hop();
sendPingReply(pr, handler);
}
//pongs for the neighbors will be sent by neighbors themselves
//as ping will be broadcasted to them (since TTL=2)
}
@Override
protected boolean respondToQueryRequest(QueryRequest queryRequest,
byte[] clientGUID,
ReplyHandler handler) {
//Only respond if we understand the actual feature, if it had a feature.
if(!FeatureSearchData.supportsFeature(queryRequest.getFeatureSelector()))
return false;
// Only send results if we're not busy. Note that this ignores
// queue slots -- we're considered busy if all of our "normal"
// slots are full. This allows some spillover into our queue that
// is necessary because we're always returning more total hits than
// we have slots available.
if(!uploadManager.mayBeServiceable() ) {
return false;
}
// Ensure that we have a valid IP & Port before we send the response.
// Otherwise the QueryReply will fail on creation.
if( !NetworkUtils.isValidPort(networkManager.getPort()) ||
!NetworkUtils.isValidAddress(networkManager.getAddress()))
return false;
// Run the local query
Response[] responses = fileManager.query(queryRequest);
return sendResponses(responses, queryRequest, handler);
}
private boolean sendResponses(Response[] responses, QueryRequest query,
ReplyHandler handler) {
// if either there are no responses or, the
// response array came back null for some reason,
// exit this method
if ( (responses == null) || ((responses.length < 1)) )
return false;
// if we cannot service a regular query, only send back results for
// application-shared metafiles, if any.
if (!uploadManager.isServiceable()) {
List<Response> filtered = new ArrayList<Response>(responses.length);
for(Response r : responses) {
if (r.isMetaFile() &&
fileManager.isFileApplicationShared(r.getName()))
filtered.add(r);
}
if (filtered.isEmpty()) // nothing to send..
return false;
if (filtered.size() != responses.length)
responses = filtered.toArray(new Response[filtered.size()]);
}
// Here we can do a couple of things - if the query wants
// out-of-band replies we should do things differently. else just
// send it off as usual. only send out-of-band if you can
// receive solicited udp AND not servicing too many
// uploads AND not connected to the originator of the query
if (query.desiresOutOfBandReplies() &&
!isConnectedTo(query, handler) &&
networkManager.canReceiveSolicited() &&
NetworkUtils.isValidAddressAndPort(query.getReplyAddress(), query.getReplyPort())) {
// send the replies out-of-band - we need to
// 1) buffer the responses
// 2) send a ReplyNumberVM with the number of responses
if (bufferResponsesForLaterDelivery(query, responses)) {
// special out of band handling....
InetAddress addr = null;
try {
addr = InetAddress.getByName(query.getReplyAddress());
} catch (UnknownHostException uhe) {}
final int port = query.getReplyPort();
if(addr != null) {
// send a ReplyNumberVM to the host - he'll ACK you if he
// wants the whole shebang
int resultCount =
(responses.length > 255) ? 255 : responses.length;
final ReplyNumberVendorMessage vm = query.desiresOutOfBandRepliesV3() ?
replyNumberVendorMessageFactory.createV3ReplyNumberVendorMessage(new GUID(query.getGUID()), resultCount) :
replyNumberVendorMessageFactory.createV2ReplyNumberVendorMessage(new GUID(query.getGUID()), resultCount);
udpService.send(vm, addr, port);
if (MessageSettings.OOB_REDUNDANCY.getValue() &&
query.desiresOutOfBandRepliesV3()) {
final InetAddress addrf = addr;
backgroundExecutor.schedule(new Runnable() {
public void run () {
udpService.send(vm, addrf, port);
}
}, 100, TimeUnit.MILLISECONDS);
}
return true;
}
} else {
// else i couldn't buffer the responses due to busy-ness, oh, scrap
// them.....
return false;
}
}
// send the replies in-band
// -----------------------------
//convert responses to QueryReplies
Iterable<QueryReply> iterable = responsesToQueryReplies(responses,
query);
//send the query replies
try {
for(QueryReply queryReply : iterable)
sendQueryReply(queryReply);
} catch (IOException e) {
// if there is an error, do nothing..
}
// -----------------------------
return true;
}
/** Returns whether or not we are connected to the originator of this query.
* PRE: assumes query.desiresOutOfBandReplies == true
*/
private final boolean isConnectedTo(QueryRequest query,
ReplyHandler handler) {
return query.matchesReplyAddress(handler.getInetAddress().getAddress());
}
/**
* Creates a <tt>List</tt> of <tt>QueryReply</tt> instances with
* compressed XML data, if requested.
*
* @return a new <tt>List</tt> of <tt>QueryReply</tt> instances
*/
@Override
protected List<QueryReply> createQueryReply(byte[] guid, byte ttl,
long speed, Response[] res,
byte[] clientGUID,
boolean busy, boolean uploaded,
boolean measuredSpeed,
boolean isFromMcast,
boolean isFWTransfer,
SecurityToken securityToken) {
List<QueryReply> queryReplies = new ArrayList<QueryReply>();
QueryReply queryReply = null;
// pick the right address & port depending on multicast & fwtrans
// if we cannot find a valid address & port, exit early.
int port = -1;
byte[] ip = null;
// first try using multicast addresses & ports, but if they're
// invalid, fallback to non multicast.
if(isFromMcast) {
ip = networkManager.getNonForcedAddress();
port = networkManager.getNonForcedPort();
if(!NetworkUtils.isValidPort(port) ||
!NetworkUtils.isValidAddress(ip))
isFromMcast = false;
}
if(!isFromMcast) {
// see if we have a valid FWTrans address. if not, fall back.
if(isFWTransfer) {
port = udpService.getStableUDPPort();
ip = networkManager.getExternalAddress();
if(!NetworkUtils.isValidAddress(ip)
|| !NetworkUtils.isValidPort(port))
isFWTransfer = false;
}
// if we still don't have a valid address here, exit early.
if(!isFWTransfer) {
ip = networkManager.getAddress();
port = networkManager.getPort();
if(!NetworkUtils.isValidAddress(ip) ||
!NetworkUtils.isValidPort(port))
return Collections.emptyList();
}
}
// get the xml collection string...
String xmlCollectionString =
LimeXMLDocumentHelper.getAggregateString(res);
if (xmlCollectionString == null)
xmlCollectionString = "";
byte[] xmlBytes = null;
try {
xmlBytes = xmlCollectionString.getBytes("UTF-8");
} catch(UnsupportedEncodingException ueex) {
throw new IllegalStateException(ueex);
}
// get the *latest* push proxies if we have not accepted an incoming
// connection in this session
boolean notIncoming = !networkManager.acceptedIncomingConnection();
Set<? extends IpPort> proxies = notIncoming ? connectionManager.getPushProxies() : null;
// it may be too big....
if (xmlBytes.length > QueryReply.XML_MAX_SIZE) {
// ok, need to partition responses up once again and send out
// multiple query replies.....
List<Response[]> splitResps = new LinkedList<Response[]>();
splitAndAddResponses(splitResps, res);
while (!splitResps.isEmpty()) {
Response[] currResps = splitResps.remove(0);
String currXML = LimeXMLDocumentHelper.getAggregateString(currResps);
byte[] currXMLBytes = null;
try {
currXMLBytes = currXML.getBytes("UTF-8");
} catch(UnsupportedEncodingException ueex) {
throw new IllegalStateException(ueex);
}
if ((currXMLBytes.length > QueryReply.XML_MAX_SIZE) &&
(currResps.length > 1))
splitAndAddResponses(splitResps, currResps);
else {
// create xml bytes if possible...
byte[] xmlCompressed = null;
if (!currXML.equals(""))
xmlCompressed = LimeXMLUtils.compress(currXMLBytes);
else //there is no XML
xmlCompressed = DataUtils.EMPTY_BYTE_ARRAY;
// create the new queryReply
queryReply = queryReplyFactory.createQueryReply(guid, ttl,
port, ip, speed, currResps, _clientGUID,
xmlCompressed, notIncoming, busy, uploaded, measuredSpeed,
ChatSettings.CHAT_ENABLED.getValue(), isFromMcast, isFWTransfer, proxies, securityToken);
queryReplies.add(queryReply);
}
}
}
else { // xml is small enough, no problem.....
// get xml bytes if possible....
byte[] xmlCompressed = null;
if (!xmlCollectionString.equals(""))
xmlCompressed =
LimeXMLUtils.compress(xmlBytes);
else //there is no XML
xmlCompressed = DataUtils.EMPTY_BYTE_ARRAY;
// create the new queryReply
queryReply = queryReplyFactory.createQueryReply(guid, ttl, port,
ip, speed, res, _clientGUID, xmlCompressed, notIncoming,
busy, uploaded, measuredSpeed, ChatSettings.CHAT_ENABLED.getValue(), isFromMcast, isFWTransfer,
proxies, securityToken);
queryReplies.add(queryReply);
}
return queryReplies;
}
/** @return Simply splits the input array into two (almost) equally sized
* arrays.
*/
private Response[][] splitResponses(Response[] in) {
int middle = in.length/2;
Response[][] retResps = new Response[2][];
retResps[0] = new Response[middle];
retResps[1] = new Response[in.length-middle];
for (int i = 0; i < middle; i++)
retResps[0][i] = in[i];
for (int i = 0; i < (in.length-middle); i++)
retResps[1][i] = in[i+middle];
return retResps;
}
private void splitAndAddResponses(List<Response[]> addTo, Response[] toSplit) {
Response[][] splits = splitResponses(toSplit);
addTo.add(splits[0]);
addTo.add(splits[1]);
}
}
The table below shows all metrics for StandardMessageRouter.java.
| Metric | Value | Description | |
|---|---|---|---|
| BLOCKS | 47.00 | Number of blocks | |
| BLOCK_COMMENT | 0.00 | Number of block comment lines | |
| COMMENTS | 112.00 | Comment lines | |
| COMMENT_DENSITY | 0.32 | Comment density | |
| COMPARISONS | 62.00 | Number of comparison operators | |
| CYCLOMATIC | 75.00 | Cyclomatic complexity | |
| DECL_COMMENTS | 7.00 | Comments in declarations | |
| DOC_COMMENT | 41.00 | Number of javadoc comment lines | |
| ELOC | 353.00 | Effective lines of code | |
| EXEC_COMMENTS | 41.00 | Comments in executable code | |
| EXITS | 98.00 | Procedure exits | |
| FUNCTIONS | 11.00 | Number of function declarations | |
| HALSTEAD_DIFFICULTY | 79.07 | Halstead difficulty | |
| HALSTEAD_EFFORT | 0.00 | Halstead effort | |
| INTERFACE_COMPLEXITY | 96.00 | Interface complexity | |
| JAVA0001 | 0.00 | JAVA0001 Package name does not contain only lower case letters | |
| JAVA0002 | 0.00 | JAVA0002 Package name does not begin with a top level domain name or country code | |
| JAVA0003 | 0.00 | JAVA0003 Minimize use of on-demand (.*) imports | |
| JAVA0004 | 0.00 | JAVA0004 Unnecessary import from java.lang | |
| JAVA0005 | 0.00 | JAVA0005 Imports not in specified order | |
| JAVA0006 | 0.00 | JAVA0006 Empty finally block | |
| JAVA0007 | 0.00 | JAVA0007 Should not declare public field | |
| JAVA0008 | 2.00 | JAVA0008 Empty catch block | |
| JAVA0009 | 0.00 | JAVA0009 Protected member in final class | |
| JAVA0010 | 0.00 | JAVA0010 Non-instantiable class does not contain a non-private static member | |
| JAVA0011 | 0.00 | JAVA0011 Abstract class does not contain an abstract method | |
| JAVA0012 | 0.00 | JAVA0012 Non-constructor method with same name as declaring class | |
| JAVA0013 | 0.00 | JAVA0013 Non-blank final field is not static | |
| JAVA0014 | 0.00 | JAVA0014 Class with only static members has non-private constructor | |
| JAVA0015 | 0.00 | JAVA0015 Package class contains public nested type | |
| JAVA0016 | 0.00 | JAVA0016 Abstract class contains public constructor | |
| JAVA0017 | 0.00 | JAVA0017 Class name does not have required form | |
| JAVA0018 | 0.00 | JAVA0018 Method name does not have required form | |
| JAVA0019 | 0.00 | JAVA0019 Interface name does not have required form | |
| JAVA0020 | 0.00 | JAVA0020 Field name does not have required form | |
| JAVA0021 | 0.00 | JAVA0021 Interface method name does not have required form | |
| JAVA0022 | 0.00 | JAVA0022 Static final field name does not have required form | |
| JAVA0023 | 0.00 | JAVA0023 Empty finalize method | |
| JAVA0024 | 0.00 | JAVA0024 Empty class | |
| JAVA0025 | 0.00 | JAVA0025 Method override is empty | |
| JAVA0026 | 0.00 | JAVA0026 Finalize method with parameters | |
| JAVA0029 | 0.00 | JAVA0029 Private method not used | |
| JAVA0030 | 0.00 | JAVA0030 Private field not used | |
| JAVA0031 | 0.00 | JAVA0031 Case statement not properly closed | |
| JAVA0032 | 0.00 | JAVA0032 Switch statement missing default | |
| JAVA0033 | 0.00 | JAVA0033 default: not last case in switch statement | |
| JAVA0034 | 21.00 | JAVA0034 Missing braces in if statement | |
| JAVA0035 | 2.00 | JAVA0035 Missing braces in for statement | |
| JAVA0036 | 0.00 | JAVA0036 Missing braces in while statement | |
| JAVA0038 | 0.00 | JAVA0038 Non-case label in switch statement | |
| JAVA0039 | 0.00 | JAVA0039 Break statement with label | |
| JAVA0040 | 0.00 | JAVA0040 Switch statement contains N cases (maximum: M) | |
| JAVA0041 | 0.00 | JAVA0041 Nested synchronized block | |
| JAVA0042 | 0.00 | JAVA0042 Empty synchronized statement | |
| JAVA0043 | 0.00 | JAVA0043 Inner class does not use outer class | |
| JAVA0044 | 0.00 | JAVA0044 Serializable class with no instance variables | |
| JAVA0045 | 0.00 | JAVA0045 Serializable class with only transient fields | |
| JAVA0046 | 0.00 | JAVA0046 Name of class not derived from Exception ends with 'Exception' | |
| JAVA0047 | 0.00 | JAVA0047 Serializable class derives from invalid base class | |
| JAVA0048 | 0.00 | JAVA0048 Name of class derived from Exception does not end with 'Exception' | |
| JAVA0049 | 1.00 | JAVA0049 Nested block at depth N (maximum: M) | |
| JAVA0050 | 0.00 | JAVA0050 Class derives from java.lang.Error | |
| JAVA0051 | 0.00 | JAVA0051 Class derives from java.lang.RuntimeException | |
| JAVA0052 | 0.00 | JAVA0052 Class derives from java.lang.Throwable | |
| JAVA0053 | 0.00 | JAVA0053 Unused label | |
| JAVA0054 | 0.00 | JAVA0054 Inheritance depth N exceeds maximum M | |
| JAVA0055 | 0.00 | JAVA0055 Class should be interface | |
| JAVA0056 | 0.00 | JAVA0056 Unnecessary abstract modifier for interface or annotation | |
| JAVA0057 | 0.00 | JAVA0057 Unnecessary default constructor | |
| JAVA0058 | 0.00 | JAVA0058 Constructor calls super() | |
| JAVA0059 | 0.00 | JAVA0059 Method override only calls super() | |
| JAVA0061 | 0.00 | JAVA0061 Inaccessible member in anonymous class | |
| JAVA0062 | 0.00 | JAVA0062 Public class missing public member or protected constructor | |
| JAVA0063 | 0.00 | JAVA0063 Identifier name should not contain '$' | |
| JAVA0064 | 0.00 | JAVA0064 N variations of identifier name (maximum: M) | |
| JAVA0065 | 0.00 | JAVA0065 Unnecessary final modifier for method in final class | |
| JAVA0066 | 0.00 | JAVA0066 Unnecessary modifier for interface nested type | |
| JAVA0067 | 0.00 | JAVA0067 Array descriptor on identifier name | |
| JAVA0068 | 0.00 | JAVA0068 Modifiers not declared in recommended order | |
| JAVA0071 | 0.00 | JAVA0071 Strings compared with == | |
| JAVA0073 | 0.00 | JAVA0073 Integer division in floating-point context | |
| JAVA0074 | 0.00 | JAVA0074 Use of Object.notify() | |
| JAVA0075 | 0.00 | JAVA0075 Method parameter hides field | |
| JAVA0076 | 4.00 | JAVA0076 Use of magic number | |
| JAVA0077 | 0.00 | JAVA0077 Private field not used in declaring class | |
| JAVA0078 | 0.00 | JAVA0078 Floating point values compared with == | |
| JAVA0079 | 0.00 | JAVA0079 Use of instance to reference static member | |
| JAVA0080 | 0.00 | JAVA0080 Import declaration not used | |
| JAVA0081 | 0.00 | JAVA0081 Boolean literal in comparison | |
| JAVA0082 | 0.00 | JAVA0082 Unnecessary widening cast | |
| JAVA0083 | 0.00 | JAVA0083 Unnecessary instanceof test | |
| JAVA0084 | 0.00 | JAVA0084 Should use compound assignment operator | |
| JAVA0085 | 0.00 | JAVA0085 Use of sun.* class | |
| JAVA0087 | 0.00 | JAVA0087 Use of Thread.sleep() | |
| JAVA0089 | 0.00 | JAVA0089 Use of restricted package | |
| JAVA0092 | 0.00 | JAVA0092 Use of restricted type | |
| JAVA0093 | 0.00 | JAVA0093 Redundant assignment | |
| JAVA0094 | 0.00 | JAVA0094 Field hides a superclass field | |
| JAVA0095 | 0.00 | JAVA0095 Uninitialized private field | |
| JAVA0096 | 0.00 | JAVA0096 Field in nested class hides outer field | |
| JAVA0098 | 0.00 | JAVA0098 Minimize use of implicit field initializers | |
| JAVA0100 | 0.00 | JAVA0100 Class contains N non-final fields (maximum: M) | |
| JAVA0101 | 0.00 | JAVA0101 Unnecessary modifier for field in interface | |
| JAVA0102 | 0.00 | JAVA0102 Last statement in finalize() not super.finalize() | |
| JAVA0103 | 0.00 | JAVA0103 Explicit call to finalize() | |
| JAVA0104 | 0.00 | JAVA0104 finalize() only calls super.finalize() | |
| JAVA0105 | 0.00 | JAVA0105 Duplicate import declaration | |
| JAVA0106 | 0.00 | JAVA0106 Unnecessary import from current package | |
| JAVA0108 | 3.00 | JAVA0108 Incorrect javadoc: no @param tag for 'parameter' | |
| JAVA0109 | 0.00 | JAVA0109 Incorrect javadoc: no parameter 'parameter' | |
| JAVA0110 | 1.00 | JAVA0110 Incorrect javadoc: no @return tag | |
| JAVA0111 | 0.00 | JAVA0111 Incorrect javadoc: @return tag for void method | |
| JAVA0112 | 0.00 | JAVA0112 Incorrect javadoc: no exception 'exception' in throws | |
| JAVA0113 | 1.00 | JAVA0113 Incorrect javadoc: no @author tag | |
| JAVA0114 | 1.00 | JAVA0114 Incorrect javadoc: no @version tag | |
| JAVA0115 | 0.00 | JAVA0115 Incorrect javadoc: no @throws or @exception tag for 'exception' | |
| JAVA0116 | 0.00 | JAVA0116 Missing javadoc: field 'field' | |
| JAVA0117 | 1.00 | JAVA0117 Missing javadoc: method 'method' | |
| JAVA0118 | 0.00 | JAVA0118 Missing javadoc: type 'type' | |
| JAVA0119 | 0.00 | JAVA0119 Control variable changed within body of for loop | |
| JAVA0123 | 0.00 | JAVA0123 Use all three components of for loop | |
| JAVA0125 | 0.00 | JAVA0125 Continue statement with label | |
| JAVA0126 | 0.00 | JAVA0126 Method declares unchecked exception in throws | |
| JAVA0128 | 0.00 | JAVA0128 Public constructor in non-public class | |
| JAVA0130 | 2.00 | JAVA0130 Non-static method does not use instance fields | |
| JAVA0131 | 0.00 | JAVA0131 Compatible method does not override base | |
| JAVA0132 | 0.00 | JAVA0132 Method overload with compatible signature | |
| JAVA0133 | 0.00 | JAVA0133 Non-synchronized method overrides synchronized method | |
| JAVA0135 | 0.00 | JAVA0135 Only one of Object.equals and Object.hashCode defined: missing 'method' | |
| JAVA0136 | 0.00 | JAVA0136 N methods defined in class (maximum: M) | |
| JAVA0137 | 0.00 | JAVA0137 Non-abstract class missing constructor | |
| JAVA0138 | 2.00 | JAVA0138 N parameters defined for method (maximum: M) | |
| JAVA0139 | 0.00 | JAVA0139 Definition of main other than public static void main(java.lang.String[]) | |
| JAVA0141 | 0.00 | JAVA0141 Unnecessary modifier for method in interface | |
| JAVA0143 | 0.00 | JAVA0143 Synchronized method | |
| JAVA0144 | 2.00 | JAVA0144 Line exceeds maximum M characters | |
| JAVA0145 | 47.00 | JAVA0145 Tab character used in source file | |
| JAVA0150 | 0.00 | JAVA0150 java.lang.Error (or subclass) thrown | |
| JAVA0153 | 0.00 | JAVA0153 Inefficient conversion of integer to string | |
| JAVA0159 | 0.00 | JAVA0159 Inefficient conversion of string to integer | |
| JAVA0160 | 0.00 | JAVA0160 Method does not throw specified exception | |
| JAVA0161 | 0.00 | JAVA0161 Conditional wait() not in loop | |
| JAVA0163 | 0.00 | JAVA0163 Empty statement | |
| JAVA0165 | 0.00 | JAVA0165 Conflicting return statement in finally block | |
| JAVA0166 | 0.00 | JAVA0166 Generic exception caught | |
| JAVA0167 | 0.00 | JAVA0167 ThreadDeath not rethrown | |
| JAVA0169 | 0.00 | JAVA0169 Unnecessary catch block: exception 'exception' | |
| JAVA0170 | 0.00 | JAVA0170 Caught exception not derived from java.lang.Exception | |
| JAVA0171 | 0.00 | JAVA0171 Unused local variable | |
| JAVA0173 | 0.00 | JAVA0173 Unused method parameter | |
| JAVA0174 | 0.00 | JAVA0174 Assigned local variable never used | |
| JAVA0175 | 0.00 | JAVA0175 Successive assignment to variable | |
| JAVA0176 | 0.00 | JAVA0176 Local variable name does not have required form | |
| JAVA0177 | 1.00 | JAVA0177 Variable declaration missing initializer | |
| JAVA0179 | 0.00 | JAVA0179 Local variable hides visible field | |
| JAVA0233 | 0.00 | JAVA0233 Definition of serialVersionUID other than 'private static final long serialVersionUID' | |
| JAVA0234 | 0.00 | JAVA0234 Class is Serializable but does not define serialVersionUID | |
| JAVA0235 | 0.00 | JAVA0235 Class defines serialVersionUID but does not implement Serializable | |
| JAVA0236 | 0.00 | JAVA0236 Attempt to clone an object which does not implement Cloneable | |
| JAVA0237 | 0.00 | JAVA0237 Class implements Cloneable but does not have public clone method | |
| JAVA0238 | 0.00 | JAVA0238 Clone method does not call super.clone() | |
| JAVA0239 | 0.00 | JAVA0239 Class declares 'readObject' or 'writeObject' but does not implement Serializable | |
| JAVA0240 | 0.00 | JAVA0240 Serializable class which declares readObject or writeObject but not both | |
| JAVA0241 | 0.00 | JAVA0241 'readObject' or 'writeObject' should be declared private in Serializable class | |
| JAVA0242 | 0.00 | JAVA0242 Transient field in non-Serializable class | |
| JAVA0243 | 0.00 | JAVA0243 'readResolve' or 'writeReplace' should be declared private or protected | |
| JAVA0244 | 0.00 | JAVA0244 Field or method name in subclass differs only by case from inherited field or method | |
| JAVA0245 | 0.00 | JAVA0245 JUnit TestCase with non-trivial constructor | |
| JAVA0246 | 0.00 | JAVA0246 JUnit assertXXX statement missing message parameter | |
| JAVA0247 | 0.00 | JAVA0247 JUnit 'setUp()' and 'tearDown()' should call super method | |
| JAVA0248 | 0.00 | JAVA0248 JUnit method 'setUp' or 'tearDown' with incorrect signature | |
| JAVA0249 | 0.00 | JAVA0249 JUnit TestCase 'suite()' should be declared static | |
| JAVA0250 | 0.00 | JAVA0250 JUnit TestCase declares testXXX method with incorrect signature | |
| JAVA0251 | 0.00 | JAVA0251 Use '%n' for line breaks in printf/format for platform independence | |
| JAVA0252 | 0.00 | JAVA0252 'enum' is a Java 1.5 reserved word | |
| JAVA0253 | 0.00 | JAVA0253 Not all enum constants consumed in switch statement | |
| JAVA0254 | 0.00 | JAVA0254 Use enhanced for loop construct instead of Iterator | |
| JAVA0255 | 0.00 | JAVA0255 Result of method invocation not used | |
| JAVA0256 | 0.00 | JAVA0256 Assignment of external collection/array to field | |
| JAVA0257 | 0.00 | JAVA0257 Use of 'Constant Interface' anti-pattern | |
| JAVA0258 | 0.00 | JAVA0258 Implement Iterable for foreach compatibility | |
| JAVA0259 | 0.00 | JAVA0259 Return of collection/array field | |
| JAVA0260 | 0.00 | JAVA0260 Use 'enum' instead of Enumerated Type pattern | |
| JAVA0261 | 0.00 | JAVA0261 Use specialized Enum collection types | |
| JAVA0262 | 0.00 | JAVA0262 Use of char in integer context | |
| JAVA0263 | 0.00 | JAVA0263 Long literal ends with 'l' instead of 'L' | |
| JAVA0264 | 0.00 | JAVA0264 Integer math in long context - check for overflow | |
| JAVA0265 | 0.00 | JAVA0265 Use of Throwable.printStackTrace() | |
| JAVA0266 | 0.00 | JAVA0266 Use of System.out | |
| JAVA0267 | 0.00 | JAVA0267 Use of System.err | |
| JAVA0269 | 0.00 | JAVA0269 Contents of StringBuffer never used | |
| JAVA0270 | 0.00 | JAVA0270 Use Java 5.0 enhanced for loop construct to iterate over all elements in an array | |
| JAVA0271 | 0.00 | JAVA0271 Minimize use of on-demand (.*) static imports | |
| JAVA0272 | 0.00 | JAVA0272 Thread.run() called | |
| JAVA0273 | 0.00 | JAVA0273 Non-final derivative of Thread calls start() in constructor | |
| JAVA0274 | 0.00 | JAVA0274 Serializable class has a synchronized readObject() | |
| JAVA0275 | 0.00 | JAVA0275 Serializable class has a synchronized writeObject() and no other synchronized methods | |
| JAVA0276 | 0.00 | JAVA0276 Unnecessary use of String constructor | |
| JAVA0277 | 0.00 | JAVA0277 Iterator.next() implementation does not throw NoSuchElementException | |
| JAVA0278 | 0.00 | JAVA0278 Unnecessary use of Boolean constructor | |
| JAVA0279 | 0.00 | JAVA0279 Serialization method readObject or readObjectNoData calls an overridable method | |
| JAVA0280 | 0.00 | JAVA0280 IllegalMonitorStateException caught | |
| JAVA0281 | 0.00 | JAVA0281 Iterator.next() not called in loop | |
| JAVA0282 | 0.00 | JAVA0282 Call to Iterator.next() in loop which does not test Iterator.hasNext() | |
| JAVA0283 | 0.00 | JAVA0283 Control variable not updated in loop body | |
| JAVA0284 | 0.00 | JAVA0284 Explicit garbage collection | |
| JAVA0285 | 0.00 | JAVA0285 Dereference of potentially null variable | |
| JAVA0286 | 0.00 | JAVA0286 Dereference of null variable | |
| JAVA0287 | 0.00 | JAVA0287 Unnecessary null check | |
| JAVA0288 | 0.00 | JAVA0288 Inconsistent null check | |
| LINES | 580.00 | Number of lines in the source file | |
| LINE_COMMENT | 71.00 | Number of line comments | |
| LOC | 393.00 | Lines of code | |
| LOGICAL_LINES | 180.00 | Number of statements | |
| LOOPS | 3.00 | Number of loops | |
| NEST_DEPTH | 6.00 | Maximum nesting depth | |
| OPERANDS | 1107.00 | Number of operands | |
| OPERATORS | 1824.00 | Number of operators | |
| PARAMS | 69.00 | Number of formal parameter declarations | |
| PROGRAM_LENGTH | 2931.00 | Halstead program length | |
| PROGRAM_VOCAB | 464.00 | Halstead program vocabulary | |
| PROGRAM_VOLUME | 0.00 | Halstead program volume | |
| RETURNS | 27.00 | Number of return points from functions | |
| SIZE | 25828.00 | Size of the file in bytes | |
| UNIQUE_OPERANDS | 406.00 | Number of unique operands | |
| UNIQUE_OPERATORS | 58.00 | Number of unique operators | |
| WHITESPACE | 75.00 | Number of whitespace lines | |