SSKInsertSender.java
| Index Score | ||
|---|---|---|
 |
 |
freenet.node |
 |
 |
Freenet |
View: Reasons, Metrics, Source Code
These are the metrics that contribute to the Enerjy Score for this file, ranked by impact. So the metrics listed at the top influence the score to a greater extent that the metrics listed at the bottom.
| Metric | Description | |
|---|---|---|
| JAVA0034 | JAVA0034 Missing braces in if statement |  |
| EXEC_COMMENTS | Comments in executable code | |
| LINE_COMMENT | Number of line comments | |
| JAVA0144 | JAVA0144 Line exceeds maximum M characters | |
| JAVA0143 | JAVA0143 Synchronized method | |
| LOGICAL_LINES | Number of statements | |
| SIZE | Size of the file in bytes | |
| CYCLOMATIC | Cyclomatic complexity | |
| OPERATORS | Number of operators | |
| PROGRAM_LENGTH | Halstead program length | |
| ELOC | Effective lines of code | |
| UNIQUE_OPERANDS | Number of unique operands | |
| PROGRAM_VOCAB | Halstead program vocabulary | |
| OPERANDS | Number of operands | |
| BLOCKS | Number of blocks | |
| LOC | Lines of code | |
| EXITS | Procedure exits | |
| LINES | Number of lines in the source file | |
| JAVA0117 | JAVA0117 Missing javadoc: method 'method' | |
| JAVA0259 | JAVA0259 Return of collection/array field | |
| JAVA0170 | JAVA0170 Caught exception not derived from java.lang.Exception | |
| UNIQUE_OPERATORS | Number of unique operators | |
| JAVA0177 | JAVA0177 Variable declaration missing initializer | |
| COMPARISONS | Number of comparison operators | |
| JAVA0145 | JAVA0145 Tab character used in source file | |
| NEST_DEPTH | Maximum nesting depth | |
| PROGRAM_VOLUME | Halstead program volume | |
| JAVA0136 | JAVA0136 N methods defined in class (maximum: M) | |
| JAVA0126 | JAVA0126 Method declares unchecked exception in throws | |
| JAVA0179 | JAVA0179 Local variable hides visible field | |
| JAVA0110 | JAVA0110 Incorrect javadoc: no @return tag | |
| RETURNS | Number of return points from functions | |
| DECL_COMMENTS | Comments in declarations | |
| JAVA0100 | JAVA0100 Class contains N non-final fields (maximum: M) | |
| JAVA0108 | JAVA0108 Incorrect javadoc: no @param tag for 'parameter' | |
/* This code is part of Freenet. It is distributed under the GNU General
* Public License, version 2 (or at your option any later version). See
* http://www.gnu.org/ for further details of the GPL. */
package freenet.node;
import java.util.Arrays;
import java.util.HashSet;
import freenet.crypt.DSAPublicKey;
import freenet.crypt.SHA256;
import freenet.io.comm.ByteCounter;
import freenet.io.comm.DMT;
import freenet.io.comm.DisconnectedException;
import freenet.io.comm.Message;
import freenet.io.comm.MessageFilter;
import freenet.io.comm.NotConnectedException;
import freenet.io.xfer.WaitedTooLongException;
import freenet.keys.NodeSSK;
import freenet.keys.SSKBlock;
import freenet.keys.SSKVerifyException;
import freenet.support.Logger;
import freenet.support.OOMHandler;
import freenet.support.ShortBuffer;
import freenet.support.io.NativeThread;
/**
* SSKs require separate logic for inserts and requests, for various reasons:
* - SSKs can collide.
* - SSKs have only 1kB of data, so we can pack it into the DataReply, and we don't need to
* wait for a long data-transfer timeout.
* - SSKs have pubkeys, which don't always need to be sent.
*/
public class SSKInsertSender implements PrioRunnable, AnyInsertSender, ByteCounter {
// Constants
static final int ACCEPTED_TIMEOUT = 10000;
static final int SEARCH_TIMEOUT = 60000;
// Basics
final NodeSSK myKey;
final double target;
final long uid;
short htl;
final PeerNode source;
final Node node;
/** SSK's pubkey */
final DSAPublicKey pubKey;
/** SSK's pubkey's hash */
final byte[] pubKeyHash;
/** Data (we know at start of insert) - can change if we get a collision */
byte[] data;
/** Headers (we know at start of insert) - can change if we get a collision */
byte[] headers;
final boolean fromStore;
final long startTime;
private boolean sentRequest;
private boolean hasCollided;
private boolean hasRecentlyCollided;
private SSKBlock block;
private static boolean logMINOR;
private int status = -1;
/** Still running */
static final int NOT_FINISHED = -1;
/** Successful insert */
static final int SUCCESS = 0;
/** Route not found */
static final int ROUTE_NOT_FOUND = 1;
/** Internal error */
static final int INTERNAL_ERROR = 3;
/** Timed out waiting for response */
static final int TIMED_OUT = 4;
/** Locally Generated a RejectedOverload */
static final int GENERATED_REJECTED_OVERLOAD = 5;
/** Could not get off the node at all! */
static final int ROUTE_REALLY_NOT_FOUND = 6;
SSKInsertSender(SSKBlock block, long uid, short htl, PeerNode source, Node node, boolean fromStore) {
logMINOR = Logger.shouldLog(Logger.MINOR, this);
this.fromStore = fromStore;
this.node = node;
this.source = source;
this.htl = htl;
this.uid = uid;
myKey = (NodeSSK) block.getKey();
data = block.getRawData();
headers = block.getRawHeaders();
target = myKey.toNormalizedDouble();
pubKey = myKey.getPubKey();
if(pubKey == null)
throw new IllegalArgumentException("Must have pubkey to insert data!!");
// pubKey.fingerprint() is not the same as hash(pubKey.asBytes())). FIXME it should be!
byte[] pubKeyAsBytes = pubKey.asBytes();
pubKeyHash = SHA256.digest(pubKeyAsBytes);
this.block = block;
startTime = System.currentTimeMillis();
}
void start() {
node.executor.execute(this, "SSKInsertSender for UID "+uid+" on "+node.getDarknetPortNumber()+" at "+System.currentTimeMillis());
}
public void run() {
freenet.support.Logger.OSThread.logPID(this);
short origHTL = htl;
node.addInsertSender(myKey, htl, this);
try {
realRun();
} catch (OutOfMemoryError e) {
OOMHandler.handleOOM(e);
if(status == NOT_FINISHED)
finish(INTERNAL_ERROR, null);
} catch (Throwable t) {
Logger.error(this, "Caught "+t, t);
if(status == NOT_FINISHED)
finish(INTERNAL_ERROR, null);
} finally {
node.removeInsertSender(myKey, origHTL, this);
}
}
private void realRun() {
HashSet nodesRoutedTo = new HashSet();
HashSet nodesNotIgnored = new HashSet();
PeerNode next = null;
while(true) {
/*
* If we haven't routed to any node yet, decrement according to the source.
* If we have, decrement according to the node which just failed.
* Because:
* 1) If we always decrement according to source then we can be at max or min HTL
* for a long time while we visit *every* peer node. This is BAD!
* 2) The node which just failed can be seen as the requestor for our purposes.
*/
// Decrement at this point so we can DNF immediately on reaching HTL 0.
htl = node.decrementHTL(sentRequest ? next : source, htl);
if(htl == 0) {
// Send an InsertReply back
finish(SUCCESS, null);
return;
}
// Route it
next = node.peers.closerPeer(source, nodesRoutedTo, nodesNotIgnored, target, true, node.isAdvancedModeEnabled(), -1, null, null);
if(next == null) {
// Backtrack
finish(ROUTE_NOT_FOUND, null);
return;
}
if(logMINOR) Logger.minor(this, "Routing insert to "+next);
nodesRoutedTo.add(next);
Message req = DMT.createFNPSSKInsertRequest(uid, htl, myKey, headers, data, pubKeyHash);
Message request = DMT.createFNPSSKInsertRequestNew(uid, htl, myKey);
// Wait for ack or reject... will come before even a locally generated DataReply
MessageFilter mfAccepted = MessageFilter.create().setSource(next).setField(DMT.UID, uid).setTimeout(ACCEPTED_TIMEOUT).setType(DMT.FNPSSKAccepted);
MessageFilter mfRejectedLoop = MessageFilter.create().setSource(next).setField(DMT.UID, uid).setTimeout(ACCEPTED_TIMEOUT).setType(DMT.FNPRejectedLoop);
MessageFilter mfRejectedOverload = MessageFilter.create().setSource(next).setField(DMT.UID, uid).setTimeout(ACCEPTED_TIMEOUT).setType(DMT.FNPRejectedOverload);
// mfRejectedOverload must be the last thing in the or
// So its or pointer remains null
// Otherwise we need to recreate it below
mfRejectedOverload.clearOr();
MessageFilter mf = mfAccepted.or(mfRejectedLoop.or(mfRejectedOverload));
// Send to next node
try {
next.sendAsync(request, null, 0, this);
if(RequestHandler.SEND_OLD_FORMAT_SSK) {
next.sendAsync(req, null, 0, this);
// Not throttled, so report here.
sentPayload(data.length);
}
} catch (NotConnectedException e1) {
if(logMINOR) Logger.minor(this, "Not connected to "+next);
continue;
}
sentRequest = true;
Message msg = null;
/*
* Because messages may be re-ordered, it is
* entirely possible that we get a non-local RejectedOverload,
* followed by an Accepted. So we must loop here.
*/
while (true) {
try {
msg = node.usm.waitFor(mf, this);
} catch (DisconnectedException e) {
Logger.normal(this, "Disconnected from " + next
+ " while waiting for Accepted");
break;
}
if (msg == null) {
// Terminal overload
// Try to propagate back to source
if(logMINOR) Logger.minor(this, "Timeout");
next.localRejectedOverload("Timeout");
forwardRejectedOverload();
break;
}
if (msg.getSpec() == DMT.FNPRejectedOverload) {
// Non-fatal - probably still have time left
if (msg.getBoolean(DMT.IS_LOCAL)) {
next.localRejectedOverload("ForwardRejectedOverload3");
if(logMINOR) Logger.minor(this, "Local RejectedOverload, moving on to next peer");
// Give up on this one, try another
break;
} else {
forwardRejectedOverload();
}
continue;
}
if (msg.getSpec() == DMT.FNPRejectedLoop) {
next.successNotOverload();
// Loop - we don't want to send the data to this one
break;
}
if (msg.getSpec() != DMT.FNPSSKAccepted) {
Logger.error(this,
"Unexpected message waiting for SSKAccepted: "
+ msg);
break;
}
// Otherwise is an FNPSSKAccepted
break;
}
if((msg == null) || (msg.getSpec() != DMT.FNPSSKAccepted)) continue;
if(logMINOR) Logger.minor(this, "Got Accepted on "+this);
// Send the headers and data
Message headersMsg = DMT.createFNPSSKInsertRequestHeaders(uid, headers);
Message dataMsg = DMT.createFNPSSKInsertRequestData(uid, data);
try {
next.sendAsync(headersMsg, null, 0, this);
next.sendThrottledMessage(dataMsg, data.length, this, SSKInsertHandler.DATA_INSERT_TIMEOUT, false);
} catch (NotConnectedException e1) {
if(logMINOR) Logger.minor(this, "Not connected to "+next);
continue;
} catch (WaitedTooLongException e) {
Logger.error(this, "Waited too long to send "+dataMsg+" to "+next+" on "+this);
continue;
} catch (SyncSendWaitedTooLongException e) {
// Impossible
}
// Do we need to send them the pubkey?
if(msg.getBoolean(DMT.NEED_PUB_KEY)) {
Message pkMsg = DMT.createFNPSSKPubKey(uid, pubKey);
try {
next.sendAsync(pkMsg, null, 0, this);
} catch (NotConnectedException e) {
if(logMINOR) Logger.minor(this, "Node disconnected while sending pubkey: "+next);
continue;
}
// Wait for the SSKPubKeyAccepted
MessageFilter mf1 = MessageFilter.create().setSource(next).setField(DMT.UID, uid).setTimeout(ACCEPTED_TIMEOUT).setType(DMT.FNPSSKPubKeyAccepted);
Message newAck;
try {
newAck = node.usm.waitFor(mf1, this);
} catch (DisconnectedException e) {
if(logMINOR) Logger.minor(this, "Disconnected from "+next);
break;
}
if(newAck == null) {
// Try to propagate back to source
if(logMINOR) Logger.minor(this, "Timeout");
next.localRejectedOverload("Timeout2");
forwardRejectedOverload();
// Try another peer
break;
}
}
// We have sent them the pubkey, and the data.
// Wait for the response.
/** What are we waiting for now??:
* - FNPRouteNotFound - couldn't exhaust HTL, but send us the
* data anyway please
* - FNPInsertReply - used up all HTL, yay
* - FNPRejectOverload - propagating an overload error :(
* - FNPDataFound - target already has the data, and the data is
* an SVK/SSK/KSK, therefore could be different to what we are
* inserting.
* - FNPDataInsertRejected - the insert was invalid
*/
MessageFilter mfInsertReply = MessageFilter.create().setSource(next).setField(DMT.UID, uid).setTimeout(SEARCH_TIMEOUT).setType(DMT.FNPInsertReply);
mfRejectedOverload.setTimeout(SEARCH_TIMEOUT);
mfRejectedOverload.clearOr();
MessageFilter mfRouteNotFound = MessageFilter.create().setSource(next).setField(DMT.UID, uid).setTimeout(SEARCH_TIMEOUT).setType(DMT.FNPRouteNotFound);
MessageFilter mfDataInsertRejected = MessageFilter.create().setSource(next).setField(DMT.UID, uid).setTimeout(SEARCH_TIMEOUT).setType(DMT.FNPDataInsertRejected);
MessageFilter mfDataFound = MessageFilter.create().setSource(next).setField(DMT.UID, uid).setTimeout(SEARCH_TIMEOUT).setType(DMT.FNPSSKDataFound);
mf = mfRouteNotFound.or(mfInsertReply.or(mfRejectedOverload.or(mfDataFound.or(mfDataInsertRejected))));
while (true) {
try {
msg = node.usm.waitFor(mf, this);
} catch (DisconnectedException e) {
Logger.normal(this, "Disconnected from " + next
+ " while waiting for InsertReply on " + this);
break;
}
if (msg == null) {
// Timeout :(
// Fairly serious problem
Logger.error(this, "Timeout (" + msg + ") after Accepted in insert; to ("+next+")");
// Terminal overload
// Try to propagate back to source
next.localRejectedOverload("AfterInsertAcceptedTimeout");
finish(TIMED_OUT, next);
return;
}
if (msg.getSpec() == DMT.FNPRejectedOverload) {
// Probably non-fatal, if so, we have time left, can try next one
if (msg.getBoolean(DMT.IS_LOCAL)) {
next.localRejectedOverload("ForwardRejectedOverload4");
if(logMINOR) Logger.minor(this,
"Local RejectedOverload, moving on to next peer");
// Give up on this one, try another
break;
} else {
forwardRejectedOverload();
}
continue; // Wait for any further response
}
if (msg.getSpec() == DMT.FNPRouteNotFound) {
if(logMINOR) Logger.minor(this, "Rejected: RNF");
short newHtl = msg.getShort(DMT.HTL);
if (htl > newHtl)
htl = newHtl;
// Finished as far as this node is concerned
next.successNotOverload();
break;
}
if (msg.getSpec() == DMT.FNPDataInsertRejected) {
next.successNotOverload();
short reason = msg.getShort(DMT.DATA_INSERT_REJECTED_REASON);
if(logMINOR) Logger.minor(this, "DataInsertRejected: " + reason);
if (reason == DMT.DATA_INSERT_REJECTED_VERIFY_FAILED) {
if (fromStore) {
// That's odd...
Logger.error(this,"Verify failed on next node "
+ next + " for DataInsert but we were sending from the store!");
}
}
Logger.error(this, "SSK insert rejected! Reason="
+ DMT.getDataInsertRejectedReason(reason));
break; // What else can we do?
}
if (msg.getSpec() == DMT.FNPSSKDataFound) {
/**
* Data was already on node, and was NOT equal to what we sent. COLLISION!
*
* We can either accept the old data or the new data.
* OLD DATA:
* - KSK-based stuff is usable. Well, somewhat; a node could spoof KSKs on
* receiving an insert, (if it knows them in advance), but it cannot just
* start inserts to overwrite old SSKs.
* - You cannot "update" an SSK.
* NEW DATA:
* - KSK-based stuff not usable. (Some people think this is a good idea!).
* - Illusion of updatability. (VERY BAD IMHO, because it's not really
* updatable... FIXME implement TUKs; would determine latest version based
* on version number, and propagate on request with a certain probability or
* according to time. However there are good arguments to do updating at a
* higher level (e.g. key bottleneck argument), and TUKs should probably be
* distinct from SSKs.
*
* For now, accept the "old" i.e. preexisting data.
*/
Logger.normal(this, "Got collision on "+myKey+" ("+uid+") sending to "+next.getPeer());
// FNPSSKDataFound == FNPInsertRequest
// Lets assume the pubkeys are the same (otherwise SHA-256 has been broken
// and we're completely screwed anyway).
byte[] newData = ((ShortBuffer) msg.getObject(DMT.DATA)).getData();
byte[] newHeaders = ((ShortBuffer) msg.getObject(DMT.BLOCK_HEADERS)).getData();
if(Arrays.equals(newData, data) && Arrays.equals(newHeaders, headers)) {
Logger.error(this, "Node sent us collision but data and headers are identical!! from "+next+" on "+uid);
// Try next node, this one is evil!
break;
}
try {
block = new SSKBlock(newData, newHeaders, myKey, false);
} catch (SSKVerifyException e) {
Logger.error(this, "Node sent us collision but got corrupt SSK!! from "+next+" on "+uid);
// Try next node, no way to tell this one about its mistake as it's stopped listening. FIXME should it?
break;
}
data = newData;
headers = newHeaders;
synchronized(this) {
hasRecentlyCollided = true;
hasCollided = true;
notifyAll();
}
continue;
}
if(msg.getSpec() == DMT.FNPSSKDataFoundHeaders) {
/**
* Data was already on node, and was NOT equal to what we sent. COLLISION!
*
* We can either accept the old data or the new data.
* OLD DATA:
* - KSK-based stuff is usable. Well, somewhat; a node could spoof KSKs on
* receiving an insert, (if it knows them in advance), but it cannot just
* start inserts to overwrite old SSKs.
* - You cannot "update" an SSK.
* NEW DATA:
* - KSK-based stuff not usable. (Some people think this is a good idea!).
* - Illusion of updatability. (VERY BAD IMHO, because it's not really
* updatable... FIXME implement TUKs; would determine latest version based
* on version number, and propagate on request with a certain probability or
* according to time. However there are good arguments to do updating at a
* higher level (e.g. key bottleneck argument), and TUKs should probably be
* distinct from SSKs.
*
* For now, accept the "old" i.e. preexisting data.
*/
Logger.normal(this, "Got collision on "+myKey+" ("+uid+") sending to "+next.getPeer());
headers = ((ShortBuffer) msg.getObject(DMT.BLOCK_HEADERS)).getData();
// Wait for the data
MessageFilter mfData = MessageFilter.create().setSource(next).setField(DMT.UID, uid).setTimeout(RequestSender.FETCH_TIMEOUT).setType(DMT.FNPSSKDataFoundData);
Message dataMessage;
try {
dataMessage = node.usm.waitFor(mfData, this);
} catch (DisconnectedException e) {
if(logMINOR)
Logger.minor(this, "Disconnected: "+next+" getting datareply for "+this);
break;
}
if(dataMessage == null) {
Logger.error(this, "Got headers but not data for datareply for insert from "+this);
break;
}
data = ((ShortBuffer) dataMessage.getObject(DMT.DATA)).getData();
synchronized(this) {
hasRecentlyCollided = true;
hasCollided = true;
notifyAll();
}
continue; // The node will now propagate the new data. There is no need to move to the next node yet.
}
if (msg.getSpec() != DMT.FNPInsertReply) {
Logger.error(this, "Unknown reply: " + msg);
finish(INTERNAL_ERROR, next);
}
// Our task is complete
next.successNotOverload();
finish(SUCCESS, next);
return;
}
}
}
private boolean hasForwardedRejectedOverload;
synchronized boolean receivedRejectedOverload() {
return hasForwardedRejectedOverload;
}
/** Forward RejectedOverload to the request originator.
* DO NOT CALL if have a *local* RejectedOverload.
*/
private synchronized void forwardRejectedOverload() {
if(hasForwardedRejectedOverload) return;
hasForwardedRejectedOverload = true;
notifyAll();
}
private void finish(int code, PeerNode next) {
if(logMINOR) Logger.minor(this, "Finished: "+code+" on "+this, new Exception("debug"));
synchronized(this) {
if(status != NOT_FINISHED)
throw new IllegalStateException("finish() called with "+code+" when was already "+status);
if((code == ROUTE_NOT_FOUND) && !sentRequest)
code = ROUTE_REALLY_NOT_FOUND;
status = code;
notifyAll();
}
if(code == SUCCESS && next != null)
next.onSuccess(true, true);
if(logMINOR) Logger.minor(this, "Set status code: "+getStatusString());
// Nothing to wait for, no downstream transfers, just exit.
}
public synchronized int getStatus() {
return status;
}
public synchronized short getHTL() {
return htl;
}
/**
* @return The current status as a string
*/
public synchronized String getStatusString() {
if(status == SUCCESS)
return "SUCCESS";
if(status == ROUTE_NOT_FOUND)
return "ROUTE NOT FOUND";
if(status == NOT_FINISHED)
return "NOT FINISHED";
if(status == INTERNAL_ERROR)
return "INTERNAL ERROR";
if(status == TIMED_OUT)
return "TIMED OUT";
if(status == GENERATED_REJECTED_OVERLOAD)
return "GENERATED REJECTED OVERLOAD";
if(status == ROUTE_REALLY_NOT_FOUND)
return "ROUTE REALLY NOT FOUND";
return "UNKNOWN STATUS CODE: "+status;
}
public boolean sentRequest() {
return sentRequest;
}
public synchronized boolean hasRecentlyCollided() {
boolean status = hasRecentlyCollided;
hasRecentlyCollided = false;
return status;
}
public boolean hasCollided() {
return hasCollided;
}
public byte[] getPubkeyHash() {
return headers;
}
public byte[] getHeaders() {
return headers;
}
public byte[] getData() {
return data;
}
public SSKBlock getBlock() {
return block;
}
public long getUID() {
return uid;
}
private final Object totalBytesSync = new Object();
private int totalBytesSent;
public void sentBytes(int x) {
synchronized(totalBytesSync) {
totalBytesSent += x;
}
node.nodeStats.insertSentBytes(true, x);
}
public int getTotalSentBytes() {
synchronized(totalBytesSync) {
return totalBytesSent;
}
}
private int totalBytesReceived;
public void receivedBytes(int x) {
synchronized(totalBytesSync) {
totalBytesReceived += x;
}
node.nodeStats.insertReceivedBytes(true, x);
}
public int getTotalReceivedBytes() {
synchronized(totalBytesSync) {
return totalBytesReceived;
}
}
public void sentPayload(int x) {
node.sentPayload(x);
node.nodeStats.insertSentBytes(true, -x);
}
public int getPriority() {
return NativeThread.HIGH_PRIORITY;
}
}
The table below shows all metrics for SSKInsertSender.java.
| Metric | Value | Description | |
|---|---|---|---|
| BLOCKS | 80.00 | Number of blocks | |
| BLOCK_COMMENT | 16.00 | Number of block comment lines | |
| COMMENTS | 133.00 | Comment lines | |
| COMMENT_DENSITY | 0.38 | Comment density | |
| COMPARISONS | 44.00 | Number of comparison operators | |
| CYCLOMATIC | 97.00 | Cyclomatic complexity | |
| DECL_COMMENTS | 17.00 | Comments in declarations | |
| DOC_COMMENT | 74.00 | Number of javadoc comment lines | |
| ELOC | 347.00 | Effective lines of code | |
| EXEC_COMMENTS | 39.00 | Comments in executable code | |
| EXITS | 59.00 | Procedure exits | |
| FUNCTIONS | 24.00 | Number of function declarations | |
| HALSTEAD_DIFFICULTY | 84.08 | Halstead difficulty | |
| HALSTEAD_EFFORT | 0.00 | Halstead effort | |
| INTERFACE_COMPLEXITY | 49.00 | Interface complexity | |
| JAVA0001 | 0.00 | JAVA0001 Package name does not contain only lower case letters | |
| JAVA0002 | 1.00 | JAVA0002 Package name does not begin with a top level domain name or country code | |
| JAVA0003 | 0.00 | JAVA0003 Minimize use of on-demand (.*) imports | |
| JAVA0004 | 0.00 | JAVA0004 Unnecessary import from java.lang | |
| JAVA0005 | 0.00 | JAVA0005 Imports not in specified order | |
| JAVA0006 | 0.00 | JAVA0006 Empty finally block | |
| JAVA0007 | 0.00 | JAVA0007 Should not declare public field | |
| JAVA0008 | 0.00 | JAVA0008 Empty catch block | |
| JAVA0009 | 0.00 | JAVA0009 Protected member in final class | |
| JAVA0010 | 0.00 | JAVA0010 Non-instantiable class does not contain a non-private static member | |
| JAVA0011 | 0.00 | JAVA0011 Abstract class does not contain an abstract method | |
| JAVA0012 | 0.00 | JAVA0012 Non-constructor method with same name as declaring class | |
| JAVA0013 | 0.00 | JAVA0013 Non-blank final field is not static | |
| JAVA0014 | 0.00 | JAVA0014 Class with only static members has non-private constructor | |
| JAVA0015 | 0.00 | JAVA0015 Package class contains public nested type | |
| JAVA0016 | 0.00 | JAVA0016 Abstract class contains public constructor | |
| JAVA0017 | 0.00 | JAVA0017 Class name does not have required form | |
| JAVA0018 | 0.00 | JAVA0018 Method name does not have required form | |
| JAVA0019 | 0.00 | JAVA0019 Interface name does not have required form | |
| JAVA0020 | 0.00 | JAVA0020 Field name does not have required form | |
| JAVA0021 | 0.00 | JAVA0021 Interface method name does not have required form | |
| JAVA0022 | 0.00 | JAVA0022 Static final field name does not have required form | |
| JAVA0023 | 0.00 | JAVA0023 Empty finalize method | |
| JAVA0024 | 0.00 | JAVA0024 Empty class | |
| JAVA0025 | 0.00 | JAVA0025 Method override is empty | |
| JAVA0026 | 0.00 | JAVA0026 Finalize method with parameters | |
| JAVA0029 | 0.00 | JAVA0029 Private method not used | |
| JAVA0030 | 0.00 | JAVA0030 Private field not used | |
| JAVA0031 | 0.00 | JAVA0031 Case statement not properly closed | |
| JAVA0032 | 0.00 | JAVA0032 Switch statement missing default | |
| JAVA0033 | 0.00 | JAVA0033 default: not last case in switch statement | |
| JAVA0034 | 31.00 | JAVA0034 Missing braces in if statement | |
| JAVA0035 | 0.00 | JAVA0035 Missing braces in for statement | |
| JAVA0036 | 0.00 | JAVA0036 Missing braces in while statement | |
| JAVA0038 | 0.00 | JAVA0038 Non-case label in switch statement | |
| JAVA0039 | 0.00 | JAVA0039 Break statement with label | |
| JAVA0040 | 0.00 | JAVA0040 Switch statement contains N cases (maximum: M) | |
| JAVA0041 | 0.00 | JAVA0041 Nested synchronized block | |
| JAVA0042 | 0.00 | JAVA0042 Empty synchronized statement | |
| JAVA0043 | 0.00 | JAVA0043 Inner class does not use outer class | |
| JAVA0044 | 0.00 | JAVA0044 Serializable class with no instance variables | |
| JAVA0045 | 0.00 | JAVA0045 Serializable class with only transient fields | |
| JAVA0046 | 0.00 | JAVA0046 Name of class not derived from Exception ends with 'Exception' | |
| JAVA0047 | 0.00 | JAVA0047 Serializable class derives from invalid base class | |
| JAVA0048 | 0.00 | JAVA0048 Name of class derived from Exception does not end with 'Exception' | |
| JAVA0049 | 1.00 | JAVA0049 Nested block at depth N (maximum: M) | |
| JAVA0050 | 0.00 | JAVA0050 Class derives from java.lang.Error | |
| JAVA0051 | 0.00 | JAVA0051 Class derives from java.lang.RuntimeException | |
| JAVA0052 | 0.00 | JAVA0052 Class derives from java.lang.Throwable | |
| JAVA0053 | 0.00 | JAVA0053 Unused label | |
| JAVA0054 | 0.00 | JAVA0054 Inheritance depth N exceeds maximum M | |
| JAVA0055 | 0.00 | JAVA0055 Class should be interface | |
| JAVA0056 | 0.00 | JAVA0056 Unnecessary abstract modifier for interface or annotation | |
| JAVA0057 | 0.00 | JAVA0057 Unnecessary default constructor | |
| JAVA0058 | 0.00 | JAVA0058 Constructor calls super() | |
| JAVA0059 | 0.00 | JAVA0059 Method override only calls super() | |
| JAVA0061 | 0.00 | JAVA0061 Inaccessible member in anonymous class | |
| JAVA0062 | 0.00 | JAVA0062 Public class missing public member or protected constructor | |
| JAVA0063 | 0.00 | JAVA0063 Identifier name should not contain '$' | |
| JAVA0064 | 0.00 | JAVA0064 N variations of identifier name (maximum: M) | |
| JAVA0065 | 0.00 | JAVA0065 Unnecessary final modifier for method in final class | |
| JAVA0066 | 0.00 | JAVA0066 Unnecessary modifier for interface nested type | |
| JAVA0067 | 0.00 | JAVA0067 Array descriptor on identifier name | |
| JAVA0068 | 0.00 | JAVA0068 Modifiers not declared in recommended order | |
| JAVA0071 | 0.00 | JAVA0071 Strings compared with == | |
| JAVA0073 | 0.00 | JAVA0073 Integer division in floating-point context | |
| JAVA0074 | 0.00 | JAVA0074 Use of Object.notify() | |
| JAVA0075 | 0.00 | JAVA0075 Method parameter hides field | |
| JAVA0076 | 0.00 | JAVA0076 Use of magic number | |
| JAVA0077 | 0.00 | JAVA0077 Private field not used in declaring class | |
| JAVA0078 | 0.00 | JAVA0078 Floating point values compared with == | |
| JAVA0079 | 0.00 | JAVA0079 Use of instance to reference static member | |
| JAVA0080 | 0.00 | JAVA0080 Import declaration not used | |
| JAVA0081 | 0.00 | JAVA0081 Boolean literal in comparison | |
| JAVA0082 | 0.00 | JAVA0082 Unnecessary widening cast | |
| JAVA0083 | 0.00 | JAVA0083 Unnecessary instanceof test | |
| JAVA0084 | 0.00 | JAVA0084 Should use compound assignment operator | |
| JAVA0085 | 0.00 | JAVA0085 Use of sun.* class | |
| JAVA0087 | 0.00 | JAVA0087 Use of Thread.sleep() | |
| JAVA0089 | 0.00 | JAVA0089 Use of restricted package | |
| JAVA0092 | 0.00 | JAVA0092 Use of restricted type | |
| JAVA0093 | 0.00 | JAVA0093 Redundant assignment | |
| JAVA0094 | 0.00 | JAVA0094 Field hides a superclass field | |
| JAVA0095 | 0.00 | JAVA0095 Uninitialized private field | |
| JAVA0096 | 0.00 | JAVA0096 Field in nested class hides outer field | |
| JAVA0098 | 1.00 | JAVA0098 Minimize use of implicit field initializers | |
| JAVA0100 | 1.00 | JAVA0100 Class contains N non-final fields (maximum: M) | |
| JAVA0101 | 0.00 | JAVA0101 Unnecessary modifier for field in interface | |
| JAVA0102 | 0.00 | JAVA0102 Last statement in finalize() not super.finalize() | |
| JAVA0103 | 0.00 | JAVA0103 Explicit call to finalize() | |
| JAVA0104 | 0.00 | JAVA0104 finalize() only calls super.finalize() | |
| JAVA0105 | 0.00 | JAVA0105 Duplicate import declaration | |
| JAVA0106 | 0.00 | JAVA0106 Unnecessary import from current package | |
| JAVA0108 | 0.00 | JAVA0108 Incorrect javadoc: no @param tag for 'parameter' | |
| JAVA0109 | 0.00 | JAVA0109 Incorrect javadoc: no parameter 'parameter' | |
| JAVA0110 | 0.00 | JAVA0110 Incorrect javadoc: no @return tag | |
| JAVA0111 | 0.00 | JAVA0111 Incorrect javadoc: @return tag for void method | |
| JAVA0112 | 0.00 | JAVA0112 Incorrect javadoc: no exception 'exception' in throws | |
| JAVA0113 | 1.00 | JAVA0113 Incorrect javadoc: no @author tag | |
| JAVA0114 | 1.00 | JAVA0114 Incorrect javadoc: no @version tag | |
| JAVA0115 | 0.00 | JAVA0115 Incorrect javadoc: no @throws or @exception tag for 'exception' | |
| JAVA0116 | 0.00 | JAVA0116 Missing javadoc: field 'field' | |
| JAVA0117 | 8.00 | JAVA0117 Missing javadoc: method 'method' | |
| JAVA0118 | 0.00 | JAVA0118 Missing javadoc: type 'type' | |
| JAVA0119 | 0.00 | JAVA0119 Control variable changed within body of for loop | |
| JAVA0123 | 0.00 | JAVA0123 Use all three components of for loop | |
| JAVA0125 | 0.00 | JAVA0125 Continue statement with label | |
| JAVA0126 | 0.00 | JAVA0126 Method declares unchecked exception in throws | |
| JAVA0128 | 0.00 | JAVA0128 Public constructor in non-public class | |
| JAVA0130 | 0.00 | JAVA0130 Non-static method does not use instance fields | |
| JAVA0131 | 0.00 | JAVA0131 Compatible method does not override base | |
| JAVA0132 | 0.00 | JAVA0132 Method overload with compatible signature | |
| JAVA0133 | 0.00 | JAVA0133 Non-synchronized method overrides synchronized method | |
| JAVA0135 | 0.00 | JAVA0135 Only one of Object.equals and Object.hashCode defined: missing 'method' | |
| JAVA0136 | 1.00 | JAVA0136 N methods defined in class (maximum: M) | |
| JAVA0137 | 0.00 | JAVA0137 Non-abstract class missing constructor | |
| JAVA0138 | 1.00 | JAVA0138 N parameters defined for method (maximum: M) | |
| JAVA0139 | 0.00 | JAVA0139 Definition of main other than public static void main(java.lang.String[]) | |
| JAVA0141 | 0.00 | JAVA0141 Unnecessary modifier for method in interface | |
| JAVA0143 | 6.00 | JAVA0143 Synchronized method | |
| JAVA0144 | 11.00 | JAVA0144 Line exceeds maximum M characters | |
| JAVA0145 | 1375.00 | JAVA0145 Tab character used in source file | |
| JAVA0150 | 0.00 | JAVA0150 java.lang.Error (or subclass) thrown | |
| JAVA0153 | 0.00 | JAVA0153 Inefficient conversion of integer to string | |
| JAVA0159 | 0.00 | JAVA0159 Inefficient conversion of string to integer | |
| JAVA0160 | 0.00 | JAVA0160 Method does not throw specified exception | |
| JAVA0161 | 0.00 | JAVA0161 Conditional wait() not in loop | |
| JAVA0163 | 0.00 | JAVA0163 Empty statement | |
| JAVA0165 | 0.00 | JAVA0165 Conflicting return statement in finally block | |
| JAVA0166 | 1.00 | JAVA0166 Generic exception caught | |
| JAVA0167 | 0.00 | JAVA0167 ThreadDeath not rethrown | |
| JAVA0169 | 0.00 | JAVA0169 Unnecessary catch block: exception 'exception' | |
| JAVA0170 | 2.00 | JAVA0170 Caught exception not derived from java.lang.Exception | |
| JAVA0171 | 0.00 | JAVA0171 Unused local variable | |
| JAVA0173 | 0.00 | JAVA0173 Unused method parameter | |
| JAVA0174 | 0.00 | JAVA0174 Assigned local variable never used | |
| JAVA0175 | 0.00 | JAVA0175 Successive assignment to variable | |
| JAVA0176 | 0.00 | JAVA0176 Local variable name does not have required form | |
| JAVA0177 | 2.00 | JAVA0177 Variable declaration missing initializer | |
| JAVA0179 | 1.00 | JAVA0179 Local variable hides visible field | |
| JAVA0233 | 0.00 | JAVA0233 Definition of serialVersionUID other than 'private static final long serialVersionUID' | |
| JAVA0234 | 0.00 | JAVA0234 Class is Serializable but does not define serialVersionUID | |
| JAVA0235 | 0.00 | JAVA0235 Class defines serialVersionUID but does not implement Serializable | |
| JAVA0236 | 0.00 | JAVA0236 Attempt to clone an object which does not implement Cloneable | |
| JAVA0237 | 0.00 | JAVA0237 Class implements Cloneable but does not have public clone method | |
| JAVA0238 | 0.00 | JAVA0238 Clone method does not call super.clone() | |
| JAVA0239 | 0.00 | JAVA0239 Class declares 'readObject' or 'writeObject' but does not implement Serializable | |
| JAVA0240 | 0.00 | JAVA0240 Serializable class which declares readObject or writeObject but not both | |
| JAVA0241 | 0.00 | JAVA0241 'readObject' or 'writeObject' should be declared private in Serializable class | |
| JAVA0242 | 0.00 | JAVA0242 Transient field in non-Serializable class | |
| JAVA0243 | 0.00 | JAVA0243 'readResolve' or 'writeReplace' should be declared private or protected | |
| JAVA0244 | 0.00 | JAVA0244 Field or method name in subclass differs only by case from inherited field or method | |
| JAVA0245 | 0.00 | JAVA0245 JUnit TestCase with non-trivial constructor | |
| JAVA0246 | 0.00 | JAVA0246 JUnit assertXXX statement missing message parameter | |
| JAVA0247 | 0.00 | JAVA0247 JUnit 'setUp()' and 'tearDown()' should call super method | |
| JAVA0248 | 0.00 | JAVA0248 JUnit method 'setUp' or 'tearDown' with incorrect signature | |
| JAVA0249 | 0.00 | JAVA0249 JUnit TestCase 'suite()' should be declared static | |
| JAVA0250 | 0.00 | JAVA0250 JUnit TestCase declares testXXX method with incorrect signature | |
| JAVA0251 | 0.00 | JAVA0251 Use '%n' for line breaks in printf/format for platform independence | |
| JAVA0252 | 0.00 | JAVA0252 'enum' is a Java 1.5 reserved word | |
| JAVA0253 | 0.00 | JAVA0253 Not all enum constants consumed in switch statement | |
| JAVA0254 | 0.00 | JAVA0254 Use enhanced for loop construct instead of Iterator | |
| JAVA0255 | 0.00 | JAVA0255 Result of method invocation not used | |
| JAVA0256 | 0.00 | JAVA0256 Assignment of external collection/array to field | |
| JAVA0257 | 0.00 | JAVA0257 Use of 'Constant Interface' anti-pattern | |
| JAVA0258 | 0.00 | JAVA0258 Implement Iterable for foreach compatibility | |
| JAVA0259 | 3.00 | JAVA0259 Return of collection/array field | |
| JAVA0260 | 0.00 | JAVA0260 Use 'enum' instead of Enumerated Type pattern | |
| JAVA0261 | 0.00 | JAVA0261 Use specialized Enum collection types | |
| JAVA0262 | 0.00 | JAVA0262 Use of char in integer context | |
| JAVA0263 | 0.00 | JAVA0263 Long literal ends with 'l' instead of 'L' | |
| JAVA0264 | 0.00 | JAVA0264 Integer math in long context - check for overflow | |
| JAVA0265 | 0.00 | JAVA0265 Use of Throwable.printStackTrace() | |
| JAVA0266 | 0.00 | JAVA0266 Use of System.out | |
| JAVA0267 | 0.00 | JAVA0267 Use of System.err | |
| JAVA0269 | 0.00 | JAVA0269 Contents of StringBuffer never used | |
| JAVA0270 | 0.00 | JAVA0270 Use Java 5.0 enhanced for loop construct to iterate over all elements in an array | |
| JAVA0271 | 0.00 | JAVA0271 Minimize use of on-demand (.*) static imports | |
| JAVA0272 | 0.00 | JAVA0272 Thread.run() called | |
| JAVA0273 | 0.00 | JAVA0273 Non-final derivative of Thread calls start() in constructor | |
| JAVA0274 | 0.00 | JAVA0274 Serializable class has a synchronized readObject() | |
| JAVA0275 | 0.00 | JAVA0275 Serializable class has a synchronized writeObject() and no other synchronized methods | |
| JAVA0276 | 0.00 | JAVA0276 Unnecessary use of String constructor | |
| JAVA0277 | 0.00 | JAVA0277 Iterator.next() implementation does not throw NoSuchElementException | |
| JAVA0278 | 0.00 | JAVA0278 Unnecessary use of Boolean constructor | |
| JAVA0279 | 0.00 | JAVA0279 Serialization method readObject or readObjectNoData calls an overridable method | |
| JAVA0280 | 0.00 | JAVA0280 IllegalMonitorStateException caught | |
| JAVA0281 | 0.00 | JAVA0281 Iterator.next() not called in loop | |
| JAVA0282 | 0.00 | JAVA0282 Call to Iterator.next() in loop which does not test Iterator.hasNext() | |
| JAVA0283 | 0.00 | JAVA0283 Control variable not updated in loop body | |
| JAVA0284 | 0.00 | JAVA0284 Explicit garbage collection | |
| JAVA0285 | 0.00 | JAVA0285 Dereference of potentially null variable | |
| JAVA0286 | 0.00 | JAVA0286 Dereference of null variable | |
| JAVA0287 | 0.00 | JAVA0287 Unnecessary null check | |
| JAVA0288 | 0.00 | JAVA0288 Inconsistent null check | |
| LINES | 633.00 | Number of lines in the source file | |
| LINE_COMMENT | 43.00 | Number of line comments | |
| LOC | 413.00 | Lines of code | |
| LOGICAL_LINES | 244.00 | Number of statements | |
| LOOPS | 3.00 | Number of loops | |
| NEST_DEPTH | 6.00 | Maximum nesting depth | |
| OPERANDS | 954.00 | Number of operands | |
| OPERATORS | 1961.00 | Number of operators | |
| PARAMS | 11.00 | Number of formal parameter declarations | |
| PROGRAM_LENGTH | 2915.00 | Halstead program length | |
| PROGRAM_VOCAB | 347.00 | Halstead program vocabulary | |
| PROGRAM_VOLUME | 0.00 | Halstead program volume | |
| RETURNS | 38.00 | Number of return points from functions | |
| SIZE | 22488.00 | Size of the file in bytes | |
| UNIQUE_OPERANDS | 295.00 | Number of unique operands | |
| UNIQUE_OPERATORS | 52.00 | Number of unique operators | |
| WHITESPACE | 87.00 | Number of whitespace lines | |