RequestHandler.java

Index Score
freenet.node
Freenet

View: Reasons, Metrics, Source Code

These are the metrics that contribute to the Enerjy Score for this file, ranked by impact. So the metrics listed at the top influence the score to a greater extent that the metrics listed at the bottom.

MetricDescription
JAVA0034JAVA0034 Missing braces in if statement
EXEC_COMMENTSComments in executable code
LINE_COMMENTNumber of line comments
CYCLOMATICCyclomatic complexity
RETURNSNumber of return points from functions
EXITSProcedure exits
JAVA0144JAVA0144 Line exceeds maximum M characters
LOGICAL_LINESNumber of statements
OPERATORSNumber of operators
PROGRAM_LENGTHHalstead program length
ELOCEffective lines of code
SIZESize of the file in bytes
OPERANDSNumber of operands
INTERFACE_COMPLEXITYInterface complexity
UNIQUE_OPERANDSNumber of unique operands
LOCLines of code
PROGRAM_VOCABHalstead program vocabulary
BLOCKSNumber of blocks
LINESNumber of lines in the source file
JAVA0177JAVA0177 Variable declaration missing initializer
JAVA0115JAVA0115 Incorrect javadoc: no @throws or @exception tag for 'exception'
JAVA0145JAVA0145 Tab character used in source file
UNIQUE_OPERATORSNumber of unique operators
FUNCTIONSNumber of function declarations
JAVA0150JAVA0150 java.lang.Error (or subclass) thrown
JAVA0076JAVA0076 Use of magic number
PROGRAM_VOLUMEHalstead program volume
JAVA0136JAVA0136 N methods defined in class (maximum: M)
JAVA0174JAVA0174 Assigned local variable never used
JAVA0138JAVA0138 N parameters defined for method (maximum: M)
JAVA0126JAVA0126 Method declares unchecked exception in throws
JAVA0179JAVA0179 Local variable hides visible field
JAVA0110JAVA0110 Incorrect javadoc: no @return tag
JAVA0117JAVA0117 Missing javadoc: method 'method'
JAVA0173JAVA0173 Unused method parameter
COMPARISONSNumber of comparison operators
JAVA0100JAVA0100 Class contains N non-final fields (maximum: M)
LOOPSNumber of loops
JAVA0075JAVA0075 Method parameter hides field
DOC_COMMENTNumber of javadoc comment lines
PARAMSNumber of formal parameter declarations
JAVA0108JAVA0108 Incorrect javadoc: no @param tag for 'parameter'
/* This code is part of Freenet. It is distributed under the GNU General * Public License, version 2 (or at your option any later version). See * http://www.gnu.org/ for further details of the GPL. */ package freenet.node; import freenet.crypt.DSAPublicKey; import freenet.io.comm.AsyncMessageCallback; import freenet.io.comm.ByteCounter; import freenet.io.comm.DMT; import freenet.io.comm.Message; import freenet.io.comm.NotConnectedException; import freenet.io.comm.PeerParseException; import freenet.io.comm.ReferenceSignatureVerificationException; import freenet.io.xfer.BlockTransmitter; import freenet.io.xfer.PartiallyReceivedBlock; import freenet.io.xfer.WaitedTooLongException; import freenet.keys.CHKBlock; import freenet.keys.Key; import freenet.keys.KeyBlock; import freenet.keys.NodeCHK; import freenet.keys.NodeSSK; import freenet.keys.SSKBlock; import freenet.support.Logger; import freenet.support.SimpleFieldSet; import freenet.support.TimeUtil; import freenet.support.io.NativeThread; /** * Handle an incoming request. Does not do the actual fetching; that * is separated off into RequestSender so we get transfer coalescing * and both ends for free. */ public class RequestHandler implements PrioRunnable, ByteCounter, RequestSender.Listener { private static boolean logMINOR; final Message req; final Node node; final long uid; private short htl; final PeerNode source; private boolean needsPubKey; final Key key; private boolean finalTransferFailed = false; /** The RequestSender, if any */ private RequestSender rs; private int status = RequestSender.NOT_FINISHED; private boolean appliedByteCounts = false; private boolean sentRejectedOverload = false; private long searchStartTime; private long responseDeadline; private BlockTransmitter bt; public String toString() { return super.toString() + " for " + uid; } public RequestHandler(Message m, PeerNode source, long id, Node n, short htl, Key key) { req = m; node = n; uid = id; this.source = source; this.htl = htl; if(htl <= 0) htl = 1; this.key = key; if(key instanceof NodeSSK) needsPubKey = m.getBoolean(DMT.NEED_PUB_KEY); logMINOR = Logger.shouldLog(Logger.MINOR, this); receivedBytes(m.receivedByteCount()); } public void run() { freenet.support.Logger.OSThread.logPID(this); try { realRun(); //The last thing that realRun() does is register as a request-sender listener, so any exception here is the end. } catch(NotConnectedException e) { Logger.normal(this, "requestor gone, could not start request handler wait"); node.removeTransferringRequestHandler(uid); node.unlockUID(uid, key instanceof NodeSSK, false, false, false, false); } catch(Throwable t) { Logger.error(this, "Caught " + t, t); node.removeTransferringRequestHandler(uid); node.unlockUID(uid, key instanceof NodeSSK, false, false, false, false); } } private Exception previousApplyByteCountCall; private void applyByteCounts() { if(disconnected) { Logger.normal(this, "Not applying byte counts as request source disconnected during receive"); return; } if(appliedByteCounts) { Logger.error(this, "applyByteCounts already called", new Exception("error")); Logger.error(this, "first called here", previousApplyByteCountCall); return; } previousApplyByteCountCall = new Exception("first call to applyByteCounts"); appliedByteCounts = true; if((!finalTransferFailed) && rs != null && status != RequestSender.TIMED_OUT && status != RequestSender.GENERATED_REJECTED_OVERLOAD && status != RequestSender.INTERNAL_ERROR) { int sent, rcvd; synchronized(bytesSync) { sent = sentBytes; rcvd = receivedBytes; } sent += rs.getTotalSentBytes(); rcvd += rs.getTotalReceivedBytes(); if(key instanceof NodeSSK) { if(logMINOR) Logger.minor(this, "Remote SSK fetch cost " + sent + '/' + rcvd + " bytes (" + status + ')'); node.nodeStats.remoteSskFetchBytesSentAverage.report(sent); node.nodeStats.remoteSskFetchBytesReceivedAverage.report(rcvd); if(status == RequestSender.SUCCESS) { // Can report both parts, because we had both a Handler and a Sender node.nodeStats.successfulSskFetchBytesSentAverage.report(sent); node.nodeStats.successfulSskFetchBytesReceivedAverage.report(rcvd); } } else { if(logMINOR) Logger.minor(this, "Remote CHK fetch cost " + sent + '/' + rcvd + " bytes (" + status + ')'); node.nodeStats.remoteChkFetchBytesSentAverage.report(sent); node.nodeStats.remoteChkFetchBytesReceivedAverage.report(rcvd); if(status == RequestSender.SUCCESS) { // Can report both parts, because we had both a Handler and a Sender node.nodeStats.successfulChkFetchBytesSentAverage.report(sent); node.nodeStats.successfulChkFetchBytesReceivedAverage.report(rcvd); } } } } private void realRun() throws NotConnectedException { if(logMINOR) Logger.minor(this, "Handling a request: " + uid); Message accepted = DMT.createFNPAccepted(uid); source.sendAsync(accepted, null, 0, this); Object o = node.makeRequestSender(key, htl, uid, source, false, true, false, false); if(o instanceof KeyBlock) { returnLocalData((KeyBlock) o); return; } if(o == null) { // ran out of htl? Message dnf = DMT.createFNPDataNotFound(uid); status = RequestSender.DATA_NOT_FOUND; // for byte logging node.failureTable.onFinalFailure(key, null, htl, FailureTable.REJECT_TIME, source); sendTerminal(dnf); return; } else { long queueTime = source.getProbableSendQueueTime(); synchronized(this) { rs = (RequestSender) o; //If we cannot respond before this time, the 'source' node has already fatally timed out (and we need not return packets which will not be claimed) searchStartTime = System.currentTimeMillis(); responseDeadline = searchStartTime + RequestSender.FETCH_TIMEOUT + queueTime; } rs.addListener(this); } } public void onReceivedRejectOverload() { try { if(!sentRejectedOverload) { // Forward RejectedOverload //Note: This message is only decernable from the terminal messages by the IS_LOCAL flag being false. (!IS_LOCAL)->!Terminal Message msg = DMT.createFNPRejectedOverload(uid, false); source.sendAsync(msg, null, 0, this); //If the status changes (e.g. to SUCCESS), there is little need to send yet another reject overload. sentRejectedOverload = true; } } catch(NotConnectedException e) { Logger.normal(this, "requestor is gone, can't forward reject overload"); } } private boolean disconnected = false; public void onCHKTransferBegins() { try { // Is a CHK. Message df = DMT.createFNPCHKDataFound(uid, rs.getHeaders()); source.sendAsync(df, null, 0, this); PartiallyReceivedBlock prb = rs.getPRB(); bt = new BlockTransmitter(node.usm, source, uid, prb, this); node.addTransferringRequestHandler(uid); bt.sendAsync(node.executor); } catch(NotConnectedException e) { synchronized(this) { disconnected = true; } Logger.normal(this, "requestor is gone, can't begin CHK transfer"); } } private void waitAndFinishCHKTransferOffThread() { node.executor.execute(new Runnable() { public void run() { try { waitAndFinishCHKTransfer(); } catch(NotConnectedException e) { //for byte logging, since the block is the 'terminal' message. applyByteCounts(); unregisterRequestHandlerWithNode(); } } }, "Finish CHK transfer for " + key); } private void waitAndFinishCHKTransfer() throws NotConnectedException { if(logMINOR) Logger.minor(this, "Waiting for CHK transfer to finish"); if(bt.getAsyncExitStatus()) { status = rs.getStatus(); // Successful CHK transfer, maybe path fold finishOpennetChecked(); } else { finalTransferFailed = true; status = rs.getStatus(); //for byte logging, since the block is the 'terminal' message. applyByteCounts(); unregisterRequestHandlerWithNode(); } } public void onRequestSenderFinished(int status) { long now = System.currentTimeMillis(); this.status = status; boolean tooLate; synchronized(this) { tooLate = responseDeadline > 0 && now > responseDeadline; } if(tooLate) { // Offer the data if there is any. node.failureTable.onFinalFailure(key, null, htl, -1, source); PeerNode routedLast = rs == null ? null : rs.routedLast(); // A certain number of these are normal. Logger.normal(this, "requestsender took too long to respond to requestor (" + TimeUtil.formatTime((now - searchStartTime), 2, true) + "/" + (rs == null ? "null" : rs.getStatusString()) + ") routed to " + (routedLast == null ? "null" : routedLast.shortToString())); applyByteCounts(); unregisterRequestHandlerWithNode(); return; } if(status == RequestSender.NOT_FINISHED) Logger.error(this, "onFinished() but not finished?"); try { switch(status) { case RequestSender.NOT_FINISHED: case RequestSender.DATA_NOT_FOUND: Message dnf = DMT.createFNPDataNotFound(uid); sendTerminal(dnf); return; case RequestSender.RECENTLY_FAILED: Message rf = DMT.createFNPRecentlyFailed(uid, rs.getRecentlyFailedTimeLeft()); sendTerminal(rf); return; case RequestSender.GENERATED_REJECTED_OVERLOAD: case RequestSender.TIMED_OUT: case RequestSender.INTERNAL_ERROR: // Locally generated. // Propagate back to source who needs to reduce send rate ///@bug: we may not want to translate fatal timeouts into non-fatal timeouts. Message reject = DMT.createFNPRejectedOverload(uid, true); sendTerminal(reject); return; case RequestSender.ROUTE_NOT_FOUND: // Tell source Message rnf = DMT.createFNPRouteNotFound(uid, rs.getHTL()); sendTerminal(rnf); return; case RequestSender.SUCCESS: if(key instanceof NodeSSK) sendSSK(rs.getHeaders(), rs.getSSKData(), needsPubKey, ((NodeSSK) rs.getSSKBlock().getKey()).getPubKey()); else if(bt == null && !disconnected) { // Bug! This is impossible! Logger.error(this, "Status is SUCCESS but we never started a transfer on " + uid); // Obviously this node is confused, send a terminal reject to make sure the requestor is not waiting forever. reject = DMT.createFNPRejectedOverload(uid, true); sendTerminal(reject); } else if(!disconnected) waitAndFinishCHKTransferOffThread(); return; case RequestSender.VERIFY_FAILURE: case RequestSender.GET_OFFER_VERIFY_FAILURE: if(key instanceof NodeCHK) { if(bt == null && !disconnected) { // Bug! This is impossible! Logger.error(this, "Status is VERIFY_FAILURE but we never started a transfer on " + uid); // Obviously this node is confused, send a terminal reject to make sure the requestor is not waiting forever. reject = DMT.createFNPRejectedOverload(uid, true); sendTerminal(reject); } else if(!disconnected) //Verify fails after receive() is complete, so we might as well propagate it... waitAndFinishCHKTransferOffThread(); return; } reject = DMT.createFNPRejectedOverload(uid, true); sendTerminal(reject); return; case RequestSender.TRANSFER_FAILED: case RequestSender.GET_OFFER_TRANSFER_FAILED: if(key instanceof NodeCHK) { if(bt == null && !disconnected) { // Bug! This is impossible! Logger.error(this, "Status is TRANSFER_FAILED but we never started a transfer on " + uid); // Obviously this node is confused, send a terminal reject to make sure the requestor is not waiting forever. reject = DMT.createFNPRejectedOverload(uid, true); sendTerminal(reject); } else if(!disconnected) waitAndFinishCHKTransferOffThread(); return; } Logger.error(this, "finish(TRANSFER_FAILED) should not be called on SSK?!?!", new Exception("error")); return; default: // Treat as internal error reject = DMT.createFNPRejectedOverload(uid, true); sendTerminal(reject); throw new IllegalStateException("Unknown status code " + status); } } catch(NotConnectedException e) { Logger.normal(this, "requestor is gone, can't send terminal message"); applyByteCounts(); unregisterRequestHandlerWithNode(); } } public static boolean SEND_OLD_FORMAT_SSK = false; private void sendSSK(byte[] headers, final byte[] data, boolean needsPubKey2, DSAPublicKey pubKey) throws NotConnectedException { // SUCCESS requires that BOTH the pubkey AND the data/headers have been received. // The pubKey will have been set on the SSK key, and the SSKBlock will have been constructed. Message headersMsg = DMT.createFNPSSKDataFoundHeaders(uid, headers); source.sendAsync(headersMsg, null, 0, this); final Message dataMsg = DMT.createFNPSSKDataFoundData(uid, data); node.executor.execute(new PrioRunnable() { public int getPriority() { return RequestHandler.this.getPriority(); } public void run() { try { source.sendThrottledMessage(dataMsg, data.length, RequestHandler.this, 60 * 1000, true); applyByteCounts(); } catch(NotConnectedException e) { // Okay } catch(WaitedTooLongException e) { // Grrrr Logger.error(this, "Waited too long to send SSK data on " + RequestHandler.this + " because of bwlimiting"); } catch(SyncSendWaitedTooLongException e) { Logger.error(this, "Waited too long to send SSK data on " + RequestHandler.this + " because of peer"); } finally { unregisterRequestHandlerWithNode(); } } }, "Send throttled SSK data for " + RequestHandler.this); if(SEND_OLD_FORMAT_SSK) { Message df = DMT.createFNPSSKDataFound(uid, headers, data); source.sendAsync(df, null, 0, this); // Not throttled, so report payload here. sentPayload(data.length); } if(needsPubKey) { Message pk = DMT.createFNPSSKPubKey(uid, pubKey); source.sendAsync(pk, null, 0, this); } } static void sendSSK(byte[] headers, byte[] data, boolean needsPubKey, DSAPublicKey pubKey, final PeerNode source, long uid, ByteCounter ctr) throws NotConnectedException, WaitedTooLongException { // SUCCESS requires that BOTH the pubkey AND the data/headers have been received. // The pubKey will have been set on the SSK key, and the SSKBlock will have been constructed. Message headersMsg = DMT.createFNPSSKDataFoundHeaders(uid, headers); source.sendAsync(headersMsg, null, 0, ctr); final Message dataMsg = DMT.createFNPSSKDataFoundData(uid, data); try { source.sendThrottledMessage(dataMsg, data.length, ctr, 60 * 1000, false); } catch(SyncSendWaitedTooLongException e) { // Impossible throw new Error(e); } if(SEND_OLD_FORMAT_SSK) { Message df = DMT.createFNPSSKDataFound(uid, headers, data); source.sendAsync(df, null, 0, ctr); // Not throttled, so report payload here. ctr.sentPayload(data.length); } if(needsPubKey) { Message pk = DMT.createFNPSSKPubKey(uid, pubKey); source.sendAsync(pk, null, 0, ctr); } } /** * Return data from the datastore. * @param block The block we found in the datastore. * @throws NotConnectedException If we lose the connected to the request source. */ private void returnLocalData(KeyBlock block) throws NotConnectedException { if(key instanceof NodeSSK) { sendSSK(block.getRawHeaders(), block.getRawData(), needsPubKey, ((SSKBlock) block).getPubKey()); status = RequestSender.SUCCESS; // for byte logging } else if(block instanceof CHKBlock) { Message df = DMT.createFNPCHKDataFound(uid, block.getRawHeaders()); PartiallyReceivedBlock prb = new PartiallyReceivedBlock(Node.PACKETS_IN_BLOCK, Node.PACKET_SIZE, block.getRawData()); BlockTransmitter bt = new BlockTransmitter(node.usm, source, uid, prb, this); node.addTransferringRequestHandler(uid); source.sendAsync(df, null, 0, this); if(bt.send(node.executor)) { // for byte logging status = RequestSender.SUCCESS; // We've fetched it from our datastore, so there won't be a downstream noderef. // But we want to send at least an FNPOpennetCompletedAck, otherwise the request source // may have to timeout waiting for one. That will be the terminal message. finishOpennetNoRelay(); } else { //also for byte logging, since the block is the 'terminal' message. applyByteCounts(); unregisterRequestHandlerWithNode(); } } else throw new IllegalStateException(); } private void unregisterRequestHandlerWithNode() { node.removeTransferringRequestHandler(uid); node.unlockUID(uid, key instanceof NodeSSK, false, false, false, false); } /** * Sends the 'final' packet of a request in such a way that the thread can be freed (made non-runnable/exit) * and the byte counter will still be accurate. */ private void sendTerminal(Message msg) throws NotConnectedException { if(logMINOR) Logger.minor(this, "sendTerminal(" + msg + ")", new Exception("debug")); if(sendTerminalCalled) throw new IllegalStateException("sendTerminal should only be called once"); else sendTerminalCalled = true; source.sendAsync(msg, new TerminalMessageByteCountCollector(), 0, this); } boolean sendTerminalCalled = false; /** * Note well! These functions are not executed on the RequestHandler thread. */ private class TerminalMessageByteCountCollector implements AsyncMessageCallback { private boolean completed = false; public void acknowledged() { //terminalMessage ack'd by remote peer complete(); } public void disconnected() { Logger.minor(this, "Peer disconnected before terminal message sent for " + RequestHandler.this); complete(); } public void fatalError() { Logger.error(this, "Error sending terminal message?! for " + RequestHandler.this); complete(); } public void sent() { complete(); } private void complete() { synchronized(this) { if(completed) return; completed = true; } //For byte counting, this relies on the fact that the callback will only be excuted once. applyByteCounts(); unregisterRequestHandlerWithNode(); } } /** * Either send an ack, indicating we've finished and aren't interested in opennet, * or wait for a noderef and relay it and wait for a response and relay that, * or send our own noderef and wait for a response and add that. */ private void finishOpennetChecked() throws NotConnectedException { OpennetManager om = node.getOpennet(); if(om != null && (node.passOpennetRefsThroughDarknet() || source.isOpennet()) && finishOpennetInner(om)) { applyByteCounts(); unregisterRequestHandlerWithNode(); return; } Message msg = DMT.createFNPOpennetCompletedAck(uid); sendTerminal(msg); } /** * There is no noderef to pass downstream. If we want a connection, send our * noderef and wait for a reply, otherwise just send an ack. */ private void finishOpennetNoRelay() throws NotConnectedException { OpennetManager om = node.getOpennet(); if(om != null && (source.isOpennet() || node.passOpennetRefsThroughDarknet()) && finishOpennetNoRelayInner(om)) { applyByteCounts(); unregisterRequestHandlerWithNode(); return; } // Otherwise just ack it. Message msg = DMT.createFNPOpennetCompletedAck(uid); sendTerminal(msg); } private boolean finishOpennetInner(OpennetManager om) { byte[] noderef = rs.waitForOpennetNoderef(); if(noderef == null) return finishOpennetNoRelayInner(om); if(node.random.nextInt(OpennetManager.RESET_PATH_FOLDING_PROB) == 0) return finishOpennetNoRelayInner(om); finishOpennetRelay(noderef, om); return true; } /** * Send our noderef to the request source, wait for a reply, if we get one add it. Called when either the request * wasn't routed, or the node it was routed to didn't return a noderef. * @return True if success, or lost connection; false if we need to send an ack. */ private boolean finishOpennetNoRelayInner(OpennetManager om) { if(logMINOR) Logger.minor(this, "Finishing opennet: sending own reference"); if(!om.wantPeer(null, false)) return false; // Don't want a reference try { om.sendOpennetRef(false, uid, source, om.crypto.myCompressedFullRef(), this); } catch(NotConnectedException e) { Logger.normal(this, "Can't send opennet ref because node disconnected on " + this); // Oh well... return true; } // Wait for response byte[] noderef = om.waitForOpennetNoderef(true, source, uid, this); if(noderef == null) return false; SimpleFieldSet ref = om.validateNoderef(noderef, 0, noderef.length, source, false); if(ref == null) return false; try { if(node.addNewOpennetNode(ref) == null) Logger.normal(this, "Asked for opennet ref but didn't want it for " + this + " :\n" + ref); else Logger.normal(this, "Added opennet noderef in " + this); } catch(FSParseException e) { Logger.error(this, "Could not parse opennet noderef for " + this + " from " + source, e); } catch(PeerParseException e) { Logger.error(this, "Could not parse opennet noderef for " + this + " from " + source, e); } catch(ReferenceSignatureVerificationException e) { Logger.error(this, "Bad signature on opennet noderef for " + this + " from " + source + " : " + e, e); } return true; } /** * Called when the node we routed the request to returned a valid noderef, and we don't want it. * So we relay it downstream to somebody who does, and wait to relay the response back upstream. * @param noderef * @param om */ private void finishOpennetRelay(byte[] noderef, OpennetManager om) { if(logMINOR) Logger.minor(this, "Finishing opennet: relaying reference from " + rs.successFrom()); // Send it back to the handler, then wait for the ConnectReply PeerNode dataSource = rs.successFrom(); try { om.sendOpennetRef(false, uid, source, noderef, this); } catch(NotConnectedException e) { // Lost contact with request source, nothing we can do return; } // Now wait for reply from the request source. byte[] newNoderef = om.waitForOpennetNoderef(true, source, uid, this); if(newNoderef == null) // Already sent a ref, no way to tell upstream that we didn't receive one. :( return; // Send it forward to the data source, if it is valid. if(om.validateNoderef(newNoderef, 0, newNoderef.length, source, false) != null) try { om.sendOpennetRef(true, uid, dataSource, newNoderef, this); } catch(NotConnectedException e) { // How sad return; } } private int sentBytes; private int receivedBytes; private volatile Object bytesSync = new Object(); public void sentBytes(int x) { synchronized(bytesSync) { sentBytes += x; } node.nodeStats.requestSentBytes(key instanceof NodeSSK, x); if(logMINOR) Logger.minor(this, "sentBytes(" + x + ") on " + this); } public void receivedBytes(int x) { synchronized(bytesSync) { receivedBytes += x; } node.nodeStats.requestReceivedBytes(key instanceof NodeSSK, x); } public void sentPayload(int x) { /* * Do not add payload to sentBytes. sentBytes() is called with the actual sent bytes, * and we do not deduct the alreadyReportedBytes, which are only used for accounting * for the bandwidth throttle. */ node.sentPayload(x); node.nodeStats.requestSentBytes(key instanceof NodeSSK, -x); if(logMINOR) Logger.minor(this, "sentPayload(" + x + ") on " + this); } public int getPriority() { return NativeThread.HIGH_PRIORITY; } }

The table below shows all metrics for RequestHandler.java.

MetricValueDescription
BLOCKS96.00Number of blocks
BLOCK_COMMENT 8.00Number of block comment lines
COMMENTS96.00Comment lines
COMMENT_DENSITY 0.22Comment density
COMPARISONS40.00Number of comparison operators
CYCLOMATIC129.00Cyclomatic complexity
DECL_COMMENTS10.00Comments in declarations
DOC_COMMENT38.00Number of javadoc comment lines
ELOC428.00Effective lines of code
EXEC_COMMENTS44.00Comments in executable code
EXITS86.00Procedure exits
FUNCTIONS32.00Number of function declarations
HALSTEAD_DIFFICULTY95.00Halstead difficulty
HALSTEAD_EFFORT 0.00Halstead effort
INTERFACE_COMPLEXITY107.00Interface complexity
JAVA0001 0.00JAVA0001 Package name does not contain only lower case letters
JAVA0002 1.00JAVA0002 Package name does not begin with a top level domain name or country code
JAVA0003 0.00JAVA0003 Minimize use of on-demand (.*) imports
JAVA0004 0.00JAVA0004 Unnecessary import from java.lang
JAVA0005 0.00JAVA0005 Imports not in specified order
JAVA0006 0.00JAVA0006 Empty finally block
JAVA0007 1.00JAVA0007 Should not declare public field
JAVA0008 0.00JAVA0008 Empty catch block
JAVA0009 0.00JAVA0009 Protected member in final class
JAVA0010 0.00JAVA0010 Non-instantiable class does not contain a non-private static member
JAVA0011 0.00JAVA0011 Abstract class does not contain an abstract method
JAVA0012 0.00JAVA0012 Non-constructor method with same name as declaring class
JAVA0013 0.00JAVA0013 Non-blank final field is not static
JAVA0014 0.00JAVA0014 Class with only static members has non-private constructor
JAVA0015 0.00JAVA0015 Package class contains public nested type
JAVA0016 0.00JAVA0016 Abstract class contains public constructor
JAVA0017 0.00JAVA0017 Class name does not have required form
JAVA0018 0.00JAVA0018 Method name does not have required form
JAVA0019 0.00JAVA0019 Interface name does not have required form
JAVA0020 0.00JAVA0020 Field name does not have required form
JAVA0021 0.00JAVA0021 Interface method name does not have required form
JAVA0022 0.00JAVA0022 Static final field name does not have required form
JAVA0023 0.00JAVA0023 Empty finalize method
JAVA0024 0.00JAVA0024 Empty class
JAVA0025 0.00JAVA0025 Method override is empty
JAVA0026 0.00JAVA0026 Finalize method with parameters
JAVA0029 0.00JAVA0029 Private method not used
JAVA0030 0.00JAVA0030 Private field not used
JAVA0031 0.00JAVA0031 Case statement not properly closed
JAVA0032 0.00JAVA0032 Switch statement missing default
JAVA0033 0.00JAVA0033 default: not last case in switch statement
JAVA003429.00JAVA0034 Missing braces in if statement
JAVA0035 0.00JAVA0035 Missing braces in for statement
JAVA0036 0.00JAVA0036 Missing braces in while statement
JAVA0038 0.00JAVA0038 Non-case label in switch statement
JAVA0039 0.00JAVA0039 Break statement with label
JAVA0040 0.00JAVA0040 Switch statement contains N cases (maximum: M)
JAVA0041 0.00JAVA0041 Nested synchronized block
JAVA0042 0.00JAVA0042 Empty synchronized statement
JAVA0043 0.00JAVA0043 Inner class does not use outer class
JAVA0044 0.00JAVA0044 Serializable class with no instance variables
JAVA0045 0.00JAVA0045 Serializable class with only transient fields
JAVA0046 0.00JAVA0046 Name of class not derived from Exception ends with 'Exception'
JAVA0047 0.00JAVA0047 Serializable class derives from invalid base class
JAVA0048 0.00JAVA0048 Name of class derived from Exception does not end with 'Exception'
JAVA0049 0.00JAVA0049 Nested block at depth N (maximum: M)
JAVA0050 0.00JAVA0050 Class derives from java.lang.Error
JAVA0051 0.00JAVA0051 Class derives from java.lang.RuntimeException
JAVA0052 0.00JAVA0052 Class derives from java.lang.Throwable
JAVA0053 0.00JAVA0053 Unused label
JAVA0054 0.00JAVA0054 Inheritance depth N exceeds maximum M
JAVA0055 0.00JAVA0055 Class should be interface
JAVA0056 0.00JAVA0056 Unnecessary abstract modifier for interface or annotation
JAVA0057 0.00JAVA0057 Unnecessary default constructor
JAVA0058 0.00JAVA0058 Constructor calls super()
JAVA0059 0.00JAVA0059 Method override only calls super()
JAVA0061 0.00JAVA0061 Inaccessible member in anonymous class
JAVA0062 0.00JAVA0062 Public class missing public member or protected constructor
JAVA0063 0.00JAVA0063 Identifier name should not contain '$'
JAVA0064 0.00JAVA0064 N variations of identifier name (maximum: M)
JAVA0065 0.00JAVA0065 Unnecessary final modifier for method in final class
JAVA0066 0.00JAVA0066 Unnecessary modifier for interface nested type
JAVA0067 0.00JAVA0067 Array descriptor on identifier name
JAVA0068 0.00JAVA0068 Modifiers not declared in recommended order
JAVA0071 0.00JAVA0071 Strings compared with ==
JAVA0073 0.00JAVA0073 Integer division in floating-point context
JAVA0074 0.00JAVA0074 Use of Object.notify()
JAVA0075 1.00JAVA0075 Method parameter hides field
JAVA0076 4.00JAVA0076 Use of magic number
JAVA0077 0.00JAVA0077 Private field not used in declaring class
JAVA0078 0.00JAVA0078 Floating point values compared with ==
JAVA0079 0.00JAVA0079 Use of instance to reference static member
JAVA0080 0.00JAVA0080 Import declaration not used
JAVA0081 0.00JAVA0081 Boolean literal in comparison
JAVA0082 0.00JAVA0082 Unnecessary widening cast
JAVA0083 0.00JAVA0083 Unnecessary instanceof test
JAVA0084 0.00JAVA0084 Should use compound assignment operator
JAVA0085 0.00JAVA0085 Use of sun.* class
JAVA0087 0.00JAVA0087 Use of Thread.sleep()
JAVA0089 0.00JAVA0089 Use of restricted package
JAVA0092 0.00JAVA0092 Use of restricted type
JAVA0093 0.00JAVA0093 Redundant assignment
JAVA0094 0.00JAVA0094 Field hides a superclass field
JAVA0095 0.00JAVA0095 Uninitialized private field
JAVA0096 0.00JAVA0096 Field in nested class hides outer field
JAVA0098 0.00JAVA0098 Minimize use of implicit field initializers
JAVA0100 1.00JAVA0100 Class contains N non-final fields (maximum: M)
JAVA0101 0.00JAVA0101 Unnecessary modifier for field in interface
JAVA0102 0.00JAVA0102 Last statement in finalize() not super.finalize()
JAVA0103 0.00JAVA0103 Explicit call to finalize()
JAVA0104 0.00JAVA0104 finalize() only calls super.finalize()
JAVA0105 0.00JAVA0105 Duplicate import declaration
JAVA0106 0.00JAVA0106 Unnecessary import from current package
JAVA0108 2.00JAVA0108 Incorrect javadoc: no @param tag for 'parameter'
JAVA0109 0.00JAVA0109 Incorrect javadoc: no parameter 'parameter'
JAVA0110 0.00JAVA0110 Incorrect javadoc: no @return tag
JAVA0111 0.00JAVA0111 Incorrect javadoc: @return tag for void method
JAVA0112 0.00JAVA0112 Incorrect javadoc: no exception 'exception' in throws
JAVA0113 1.00JAVA0113 Incorrect javadoc: no @author tag
JAVA0114 1.00JAVA0114 Incorrect javadoc: no @version tag
JAVA0115 3.00JAVA0115 Incorrect javadoc: no @throws or @exception tag for 'exception'
JAVA0116 1.00JAVA0116 Missing javadoc: field 'field'
JAVA0117 1.00JAVA0117 Missing javadoc: method 'method'
JAVA0118 0.00JAVA0118 Missing javadoc: type 'type'
JAVA0119 0.00JAVA0119 Control variable changed within body of for loop
JAVA0123 0.00JAVA0123 Use all three components of for loop
JAVA0125 0.00JAVA0125 Continue statement with label
JAVA0126 0.00JAVA0126 Method declares unchecked exception in throws
JAVA0128 0.00JAVA0128 Public constructor in non-public class
JAVA0130 0.00JAVA0130 Non-static method does not use instance fields
JAVA0131 0.00JAVA0131 Compatible method does not override base
JAVA0132 0.00JAVA0132 Method overload with compatible signature
JAVA0133 0.00JAVA0133 Non-synchronized method overrides synchronized method
JAVA0135 0.00JAVA0135 Only one of Object.equals and Object.hashCode defined: missing 'method'
JAVA0136 1.00JAVA0136 N methods defined in class (maximum: M)
JAVA0137 0.00JAVA0137 Non-abstract class missing constructor
JAVA0138 2.00JAVA0138 N parameters defined for method (maximum: M)
JAVA0139 0.00JAVA0139 Definition of main other than public static void main(java.lang.String[])
JAVA0141 0.00JAVA0141 Unnecessary modifier for method in interface
JAVA0143 0.00JAVA0143 Synchronized method
JAVA0144 9.00JAVA0144 Line exceeds maximum M characters
JAVA01451596.00JAVA0145 Tab character used in source file
JAVA0150 1.00JAVA0150 java.lang.Error (or subclass) thrown
JAVA0153 0.00JAVA0153 Inefficient conversion of integer to string
JAVA0159 0.00JAVA0159 Inefficient conversion of string to integer
JAVA0160 0.00JAVA0160 Method does not throw specified exception
JAVA0161 0.00JAVA0161 Conditional wait() not in loop
JAVA0163 0.00JAVA0163 Empty statement
JAVA0165 0.00JAVA0165 Conflicting return statement in finally block
JAVA0166 1.00JAVA0166 Generic exception caught
JAVA0167 0.00JAVA0167 ThreadDeath not rethrown
JAVA0169 0.00JAVA0169 Unnecessary catch block: exception 'exception'
JAVA0170 1.00JAVA0170 Caught exception not derived from java.lang.Exception
JAVA0171 0.00JAVA0171 Unused local variable
JAVA0173 1.00JAVA0173 Unused method parameter
JAVA0174 1.00JAVA0174 Assigned local variable never used
JAVA0175 0.00JAVA0175 Successive assignment to variable
JAVA0176 0.00JAVA0176 Local variable name does not have required form
JAVA0177 3.00JAVA0177 Variable declaration missing initializer
JAVA0179 1.00JAVA0179 Local variable hides visible field
JAVA0233 0.00JAVA0233 Definition of serialVersionUID other than 'private static final long serialVersionUID'
JAVA0234 0.00JAVA0234 Class is Serializable but does not define serialVersionUID
JAVA0235 0.00JAVA0235 Class defines serialVersionUID but does not implement Serializable
JAVA0236 0.00JAVA0236 Attempt to clone an object which does not implement Cloneable
JAVA0237 0.00JAVA0237 Class implements Cloneable but does not have public clone method
JAVA0238 0.00JAVA0238 Clone method does not call super.clone()
JAVA0239 0.00JAVA0239 Class declares 'readObject' or 'writeObject' but does not implement Serializable
JAVA0240 0.00JAVA0240 Serializable class which declares readObject or writeObject but not both
JAVA0241 0.00JAVA0241 'readObject' or 'writeObject' should be declared private in Serializable class
JAVA0242 0.00JAVA0242 Transient field in non-Serializable class
JAVA0243 0.00JAVA0243 'readResolve' or 'writeReplace' should be declared private or protected
JAVA0244 0.00JAVA0244 Field or method name in subclass differs only by case from inherited field or method
JAVA0245 0.00JAVA0245 JUnit TestCase with non-trivial constructor
JAVA0246 0.00JAVA0246 JUnit assertXXX statement missing message parameter
JAVA0247 0.00JAVA0247 JUnit 'setUp()' and 'tearDown()' should call super method
JAVA0248 0.00JAVA0248 JUnit method 'setUp' or 'tearDown' with incorrect signature
JAVA0249 0.00JAVA0249 JUnit TestCase 'suite()' should be declared static
JAVA0250 0.00JAVA0250 JUnit TestCase declares testXXX method with incorrect signature
JAVA0251 0.00JAVA0251 Use '%n' for line breaks in printf/format for platform independence
JAVA0252 0.00JAVA0252 'enum' is a Java 1.5 reserved word
JAVA0253 0.00JAVA0253 Not all enum constants consumed in switch statement
JAVA0254 0.00JAVA0254 Use enhanced for loop construct instead of Iterator
JAVA0255 0.00JAVA0255 Result of method invocation not used
JAVA0256 0.00JAVA0256 Assignment of external collection/array to field
JAVA0257 0.00JAVA0257 Use of 'Constant Interface' anti-pattern
JAVA0258 0.00JAVA0258 Implement Iterable for foreach compatibility
JAVA0259 0.00JAVA0259 Return of collection/array field
JAVA0260 0.00JAVA0260 Use 'enum' instead of Enumerated Type pattern
JAVA0261 0.00JAVA0261 Use specialized Enum collection types
JAVA0262 0.00JAVA0262 Use of char in integer context
JAVA0263 0.00JAVA0263 Long literal ends with 'l' instead of 'L'
JAVA0264 0.00JAVA0264 Integer math in long context - check for overflow
JAVA0265 0.00JAVA0265 Use of Throwable.printStackTrace()
JAVA0266 0.00JAVA0266 Use of System.out
JAVA0267 0.00JAVA0267 Use of System.err
JAVA0269 0.00JAVA0269 Contents of StringBuffer never used
JAVA0270 0.00JAVA0270 Use Java 5.0 enhanced for loop construct to iterate over all elements in an array
JAVA0271 0.00JAVA0271 Minimize use of on-demand (.*) static imports
JAVA0272 0.00JAVA0272 Thread.run() called
JAVA0273 0.00JAVA0273 Non-final derivative of Thread calls start() in constructor
JAVA0274 0.00JAVA0274 Serializable class has a synchronized readObject()
JAVA0275 0.00JAVA0275 Serializable class has a synchronized writeObject() and no other synchronized methods
JAVA0276 0.00JAVA0276 Unnecessary use of String constructor
JAVA0277 0.00JAVA0277 Iterator.next() implementation does not throw NoSuchElementException
JAVA0278 0.00JAVA0278 Unnecessary use of Boolean constructor
JAVA0279 0.00JAVA0279 Serialization method readObject or readObjectNoData calls an overridable method
JAVA0280 0.00JAVA0280 IllegalMonitorStateException caught
JAVA0281 0.00JAVA0281 Iterator.next() not called in loop
JAVA0282 0.00JAVA0282 Call to Iterator.next() in loop which does not test Iterator.hasNext()
JAVA0283 0.00JAVA0283 Control variable not updated in loop body
JAVA0284 0.00JAVA0284 Explicit garbage collection
JAVA0285 0.00JAVA0285 Dereference of potentially null variable
JAVA0286 0.00JAVA0286 Dereference of null variable
JAVA0287 0.00JAVA0287 Unnecessary null check
JAVA0288 0.00JAVA0288 Inconsistent null check
LINES663.00Number of lines in the source file
LINE_COMMENT50.00Number of line comments
LOC501.00Lines of code
LOGICAL_LINES278.00Number of statements
LOOPS 0.00Number of loops
NEST_DEPTH 4.00Maximum nesting depth
OPERANDS1150.00Number of operands
OPERATORS2369.00Number of operators
PARAMS27.00Number of formal parameter declarations
PROGRAM_LENGTH3519.00Halstead program length
PROGRAM_VOCAB402.00Halstead program vocabulary
PROGRAM_VOLUME 0.00Halstead program volume
RETURNS80.00Number of return points from functions
SIZE23539.00Size of the file in bytes
UNIQUE_OPERANDS345.00Number of unique operands
UNIQUE_OPERATORS57.00Number of unique operators
WHITESPACE66.00Number of whitespace lines