NodeCrypto.java
| Index Score | ||
|---|---|---|
 |
 |
freenet.node |
 |
 |
Freenet |
View: Reasons, Metrics, Source Code
These are the metrics that contribute to the Enerjy Score for this file, ranked by impact. So the metrics listed at the top influence the score to a greater extent that the metrics listed at the bottom.
| Metric | Description | |
|---|---|---|
| JAVA0034 | JAVA0034 Missing braces in if statement |  |
| EXITS | Procedure exits | |
| UNIQUE_OPERANDS | Number of unique operands | |
| JAVA0110 | JAVA0110 Incorrect javadoc: no @return tag | |
| PROGRAM_VOCAB | Halstead program vocabulary | |
| LOGICAL_LINES | Number of statements | |
| JAVA0144 | JAVA0144 Line exceeds maximum M characters | |
| CYCLOMATIC | Cyclomatic complexity | |
| JAVA0108 | JAVA0108 Incorrect javadoc: no @param tag for 'parameter' | |
| DECL_COMMENTS | Comments in declarations | |
| OPERATORS | Number of operators | |
| PROGRAM_LENGTH | Halstead program length | |
| JAVA0117 | JAVA0117 Missing javadoc: method 'method' | |
| OPERANDS | Number of operands | |
| JAVA0150 | JAVA0150 java.lang.Error (or subclass) thrown | |
| JAVA0166 | JAVA0166 Generic exception caught | |
| ELOC | Effective lines of code | |
| JAVA0265 | JAVA0265 Use of Throwable.printStackTrace() | |
| BLOCKS | Number of blocks | |
| JAVA0267 | JAVA0267 Use of System.err | |
| LOC | Lines of code | |
| JAVA0076 | JAVA0076 Use of magic number | |
| SIZE | Size of the file in bytes | |
| JAVA0270 | JAVA0270 Use Java 5.0 enhanced for loop construct to iterate over all elements in an array | |
| UNIQUE_OPERATORS | Number of unique operators | |
| EXEC_COMMENTS | Comments in executable code | |
| FUNCTIONS | Number of function declarations | |
| RETURNS | Number of return points from functions | |
| LINES | Number of lines in the source file | |
| PROGRAM_VOLUME | Halstead program volume | |
| JAVA0136 | JAVA0136 N methods defined in class (maximum: M) | |
| JAVA0035 | JAVA0035 Missing braces in for statement | |
| JAVA0126 | JAVA0126 Method declares unchecked exception in throws | |
| INTERFACE_COMPLEXITY | Interface complexity | |
| JAVA0100 | JAVA0100 Class contains N non-final fields (maximum: M) | |
| LINE_COMMENT | Number of line comments | |
| JAVA0075 | JAVA0075 Method parameter hides field | |
| NEST_DEPTH | Maximum nesting depth | |
/* This code is part of Freenet. It is distributed under the GNU General
* Public License, version 2 (or at your option any later version). See
* http://www.gnu.org/ for further details of the GPL. */
package freenet.node;
import java.io.ByteArrayOutputStream;
import java.io.IOException;
import java.io.UnsupportedEncodingException;
import java.math.BigInteger;
import java.net.MalformedURLException;
import java.security.MessageDigest;
import java.util.Vector;
import java.util.zip.DeflaterOutputStream;
import net.i2p.util.NativeBigInteger;
import freenet.crypt.BlockCipher;
import freenet.crypt.DSA;
import freenet.crypt.DSAGroup;
import freenet.crypt.DSAPrivateKey;
import freenet.crypt.DSAPublicKey;
import freenet.crypt.DSASignature;
import freenet.crypt.Global;
import freenet.crypt.RandomSource;
import freenet.crypt.SHA256;
import freenet.crypt.UnsupportedCipherException;
import freenet.crypt.ciphers.Rijndael;
import freenet.io.AddressTracker;
import freenet.io.comm.FreenetInetAddress;
import freenet.io.comm.Peer;
import freenet.io.comm.UdpSocketHandler;
import freenet.keys.FreenetURI;
import freenet.keys.InsertableClientSSK;
import freenet.support.Base64;
import freenet.support.Fields;
import freenet.support.IllegalBase64Exception;
import freenet.support.Logger;
import freenet.support.SimpleFieldSet;
import freenet.support.io.Closer;
/**
* Cryptographic and transport level node identity.
* @author toad
*/
public class NodeCrypto {
/** Length of a node identity */
public static final int IDENTITY_LENGTH = 32;
final Node node;
final boolean isOpennet;
final RandomSource random;
/** The object which handles our specific UDP port, pulls messages from it, feeds them to the packet mangler for decryption etc */
UdpSocketHandler socket;
public FNPPacketMangler packetMangler;
// FIXME: abstract out address stuff? Possibly to something like NodeReference?
final int portNumber;
byte[] myIdentity; // FIXME: simple identity block; should be unique
/** Hash of identity. Used as setup key. */
byte[] identityHash;
/** Hash of hash of identity i.e. hash of setup key. */
byte[] identityHashHash;
/** My crypto group */
private DSAGroup cryptoGroup;
/** My private key */
private DSAPrivateKey privKey;
/** My public key */
private DSAPublicKey pubKey;
/** My ARK SSK private key */
InsertableClientSSK myARK;
/** My ARK sequence number */
long myARKNumber;
static boolean logMINOR;
final NodeCryptoConfig config;
final NodeIPPortDetector detector;
final BlockCipher anonSetupCipher;
// Noderef related
/** An ordered version of the noderef FieldSet, without the signature */
private String mySignedReference = null;
/** The signature of the above fieldset */
private DSASignature myReferenceSignature = null;
/** A synchronization object used while signing the reference fieldset */
private volatile Object referenceSync = new Object();
/**
* Get port number from a config, create socket and packet mangler
* @throws NodeInitException
*/
public NodeCrypto(final Node node, final boolean isOpennet, NodeCryptoConfig config, long startupTime, boolean enableARKs) throws NodeInitException {
this.node = node;
this.config = config;
random = node.random;
this.isOpennet = isOpennet;
logMINOR = Logger.shouldLog(Logger.MINOR, this);
config.starting(this);
try {
int port = config.getPort();
FreenetInetAddress bindto = config.getBindTo();
UdpSocketHandler u = null;
if(port > 65535) {
throw new NodeInitException(NodeInitException.EXIT_IMPOSSIBLE_USM_PORT, "Impossible port number: "+port);
} else if(port == -1) {
// Pick a random port
for(int i=0;i<200000;i++) {
int portNo = 1024 + random.nextInt(65535-1024);
try {
u = new UdpSocketHandler(portNo, bindto.getAddress(), node, startupTime, getTitle(portNo), node.collector);
port = u.getPortNumber();
break;
} catch (Exception e) {
Logger.normal(this, "Could not use port: "+bindto+ ':' +portNo+": "+e, e);
System.err.println("Could not use port: "+bindto+ ':' +portNo+": "+e);
e.printStackTrace();
continue;
}
}
if(u == null)
throw new NodeInitException(NodeInitException.EXIT_NO_AVAILABLE_UDP_PORTS, "Could not find an available UDP port number for FNP (none specified)");
} else {
try {
u = new UdpSocketHandler(port, bindto.getAddress(), node, startupTime, getTitle(port), node.collector);
} catch (Exception e) {
Logger.error(this, "Caught "+e, e);
System.err.println(e);
e.printStackTrace();
throw new NodeInitException(NodeInitException.EXIT_IMPOSSIBLE_USM_PORT, "Could not bind to port: "+port+" (node already running?)");
}
}
socket = u;
Logger.normal(this, "FNP port created on "+bindto+ ':' +port);
System.out.println("FNP port created on "+bindto+ ':' +port);
portNumber = port;
config.setPort(port);
socket.setDropProbability(config.getDropProbability());
socket.setLowLevelFilter(packetMangler = new FNPPacketMangler(node, this, socket));
detector = new NodeIPPortDetector(node, node.ipDetector, this, enableARKs);
anonSetupCipher = new Rijndael(256,256);
} catch (NodeInitException e) {
config.stopping(this);
throw e;
} catch (RuntimeException e) {
config.stopping(this);
throw e;
} catch (Error e) {
config.stopping(this);
throw e;
} catch (UnsupportedCipherException e) {
config.stopping(this);
throw new Error(e);
} finally {
config.maybeStarted(this);
}
}
private String getTitle(int port) {
// FIXME l10n
return "UDP " + (isOpennet ? "Opennet " : "Darknet ") + "port " + port;
}
/**
* Read the cryptographic keys etc from a SimpleFieldSet
* @param fs
* @throws IOException
*/
public void readCrypto(SimpleFieldSet fs) throws IOException {
String identity = fs.get("identity");
if(identity == null)
throw new IOException();
try {
myIdentity = Base64.decode(identity);
} catch (IllegalBase64Exception e2) {
throw new IOException();
}
identityHash = SHA256.digest(myIdentity);
anonSetupCipher.initialize(identityHash);
identityHashHash = SHA256.digest(identityHash);
try {
cryptoGroup = DSAGroup.create(fs.subset("dsaGroup"));
privKey = DSAPrivateKey.create(fs.subset("dsaPrivKey"), cryptoGroup);
pubKey = DSAPublicKey.create(fs.subset("dsaPubKey"), cryptoGroup);
} catch (IllegalBase64Exception e) {
Logger.error(this, "Caught "+e, e);
throw new IOException(e.toString());
} catch (FSParseException e) {
Logger.error(this, "Caught "+e, e);
throw new IOException(e.toString());
}
InsertableClientSSK ark = null;
// ARK
String s = fs.get("ark.number");
String privARK = fs.get("ark.privURI");
try {
if(privARK != null) {
FreenetURI uri = new FreenetURI(privARK);
ark = InsertableClientSSK.create(uri);
if(s == null) {
ark = null;
myARKNumber = 0;
} else {
try {
myARKNumber = Long.parseLong(s);
} catch (NumberFormatException e) {
myARKNumber = 0;
ark = null;
}
}
}
} catch (MalformedURLException e) {
Logger.minor(this, "Caught "+e, e);
ark = null;
}
if(ark == null) {
ark = InsertableClientSSK.createRandom(random, "ark");
myARKNumber = 0;
}
myARK = ark;
}
/**
* Create the cryptographic keys etc from scratch
*/
public void initCrypto() {
myIdentity = new byte[32];
random.nextBytes(myIdentity);
MessageDigest md = SHA256.getMessageDigest();
identityHash = md.digest(myIdentity);
identityHashHash = md.digest(identityHash);
cryptoGroup = Global.DSAgroupBigA;
privKey = new DSAPrivateKey(cryptoGroup, random);
pubKey = new DSAPublicKey(cryptoGroup, privKey);
myARK = InsertableClientSSK.createRandom(random, "ark");
myARKNumber = 0;
SHA256.returnMessageDigest(md);
anonSetupCipher.initialize(identityHash);
}
public void start(boolean disableHangchecker) {
packetMangler.start();
socket.start(disableHangchecker);
}
public SimpleFieldSet exportPrivateFieldSet() {
SimpleFieldSet fs = exportPublicFieldSet(false, false, false);
addPrivateFields(fs);
return fs;
}
/**
* Export my node reference so that another node can connect to me.
* Public version, includes everything apart from private keys.
* @see exportPublicFieldSet(boolean forSetup).
*/
public SimpleFieldSet exportPublicFieldSet() {
return exportPublicFieldSet(false, false, false);
}
/**
* Export my reference so that another node can connect to me.
* @param forSetup If true, strip out everything that isn't needed for the references
* exchanged immediately after connection setup. I.e. strip out everything that is invariant,
* or that can safely be exchanged later.
* @param forAnonInitiator If true, we are adding a node from an anonymous initiator noderef
* exchange. Minimal noderef which we can construct a PeerNode from. Short lived so no ARK etc.
* Already signed so dump the signature.
*/
SimpleFieldSet exportPublicFieldSet(boolean forSetup, boolean forAnonInitiator, boolean forARK) {
SimpleFieldSet fs = exportPublicCryptoFieldSet(forSetup || forARK, forAnonInitiator);
if((!forAnonInitiator) && (!forSetup)) {
// IP addresses
Peer[] ips = detector.detectPrimaryPeers();
if(ips != null) {
for(int i=0;i<ips.length;i++)
fs.putAppend("physical.udp", ips[i].toString()); // Keep; important that node know all our IPs
}
} // Don't include IPs for anonymous initiator.
// Negotiation types
fs.putSingle("version", Version.getVersionString()); // Keep, vital that peer know our version. For example, some types may be sent in different formats to different node versions (e.g. Peer).
if(!forAnonInitiator)
fs.putSingle("lastGoodVersion", Version.getLastGoodVersionString()); // Also vital
if(node.testnetEnabled) {
fs.put("testnet", true);
fs.put("testnetPort", node.testnetHandler.getPort()); // Useful, saves a lot of complexity
}
if((!isOpennet) && (!forSetup) && (!forARK))
fs.putSingle("myName", node.getMyName());
if(!forAnonInitiator) {
// Anonymous initiator setup type specifies whether the node is opennet or not.
fs.put("opennet", isOpennet);
synchronized (referenceSync) {
if(myReferenceSignature == null || mySignedReference == null || !mySignedReference.equals(fs.toOrderedString())){
mySignedReference = fs.toOrderedString();
try {
myReferenceSignature = signRef(mySignedReference);
} catch (NodeInitException e) {
node.exit(e.exitCode);
}
}
fs.putSingle("sig", myReferenceSignature.toLongString());
}
}
if(logMINOR) Logger.minor(this, "My reference: "+fs.toOrderedString());
return fs;
}
SimpleFieldSet exportPublicCryptoFieldSet(boolean forSetup, boolean forAnonInitiator) {
SimpleFieldSet fs = new SimpleFieldSet(true);
int[] negTypes = packetMangler.supportedNegTypes();
if(!(forSetup || forAnonInitiator))
// Can't change on setup.
// Anonymous initiator doesn't need identity as we don't use it.
fs.putSingle("identity", Base64.encode(myIdentity));
if(!forSetup) {
// These are invariant. They cannot change on connection setup. They can safely be excluded.
fs.put("dsaGroup", cryptoGroup.asFieldSet());
fs.put("dsaPubKey", pubKey.asFieldSet());
}
if(!forAnonInitiator) {
// Short-lived connections don't need ARK and don't need negTypes either.
fs.put("auth.negTypes", negTypes);
if(!forSetup) {
fs.put("ark.number", myARKNumber); // Can be changed on setup
fs.putSingle("ark.pubURI", myARK.getURI().toString(false, false)); // Can be changed on setup
}
}
return fs;
}
DSASignature signRef(String mySignedReference) throws NodeInitException {
if(logMINOR) Logger.minor(this, "Signing reference:\n"+mySignedReference);
try{
byte[] ref = mySignedReference.getBytes("UTF-8");
BigInteger m = new BigInteger(1, SHA256.digest(ref));
if(logMINOR) Logger.minor(this, "m = "+m.toString(16));
DSASignature _signature = DSA.sign(cryptoGroup, privKey, m, random);
if(logMINOR && !DSA.verify(pubKey, _signature, m, false))
throw new NodeInitException(NodeInitException.EXIT_EXCEPTION_TO_DEBUG, mySignedReference);
return _signature;
} catch(UnsupportedEncodingException e){
//duh ?
Logger.error(this, "Error while signing the node identity!" + e, e);
System.err.println("Error while signing the node identity!"+e);
e.printStackTrace();
throw new NodeInitException(NodeInitException.EXIT_CRAPPY_JVM, "Impossible: JVM doesn't support UTF-8");
}
}
private byte[] myCompressedRef(boolean setup, boolean heavySetup, boolean forARK) {
SimpleFieldSet fs = exportPublicFieldSet(setup, heavySetup, forARK);
boolean shouldStripGroup = ((setup || heavySetup) && !forARK) && Global.DSAgroupBigA.equals(cryptoGroup);
if(shouldStripGroup)
fs.removeSubset("dsaGroup");
ByteArrayOutputStream baos = new ByteArrayOutputStream();
DeflaterOutputStream gis;
gis = new DeflaterOutputStream(baos);
try {
fs.writeTo(gis);
} catch (IOException e) {
Logger.error(this, "IOE :"+e.getMessage(), e);
} finally {
Closer.close(gis);
Closer.close(baos);
}
byte[] buf = baos.toByteArray();
if(buf.length >= 4096)
throw new IllegalStateException("We are attempting to send a "+buf.length+" bytes big reference!");
byte[] obuf = new byte[buf.length + 1 + (shouldStripGroup ? 1 : 0)];
int offset = 0;
if(shouldStripGroup) {
obuf[offset++] = 0x3; // compressed noderef - group
int dsaGroupIndex = Global.GROUP_INDEX_BIG_A;
if(logMINOR)
Logger.minor(this, "We are stripping the group from the reference as it's a known group (groupIndex="+dsaGroupIndex+')');
obuf[offset++] = (byte)(dsaGroupIndex & 0xff);
} else
obuf[offset++] = 0x01; // compressed noderef
System.arraycopy(buf, 0, obuf, offset, buf.length);
if(logMINOR)
Logger.minor(this, "myCompressedRef("+setup+","+heavySetup+") returning "+obuf.length+" bytes");
return obuf;
}
/**
* The part of our node reference which is exchanged in the connection setup, compressed.
* @see exportSetupFieldSet()
*/
public byte[] myCompressedSetupRef() {
return myCompressedRef(true, false, false);
}
/**
* The part of our node reference which is exchanged in the connection setup, if we don't
* already have the node, compressed.
* @see exportSetupFieldSet()
*/
public byte[] myCompressedHeavySetupRef() {
return myCompressedRef(false, true, false);
}
/**
* Our full node reference, compressed.
* @see exportSetupFieldSet()
*/
public byte[] myCompressedFullRef() {
return myCompressedRef(false, false, false);
}
void addPrivateFields(SimpleFieldSet fs) {
fs.put("dsaPrivKey", privKey.asFieldSet());
fs.putSingle("ark.privURI", myARK.getInsertURI().toString(false, false));
// FIXME remove the conditional after we've removed it from exportPublic...
// We must save the location!
if(fs.get("location") == null)
fs.put("location", node.lm.getLocation());
}
public int getIdentityHash(){
return Fields.hashCode(identityHash);
}
/** Sign a hash */
DSASignature sign(byte[] hash) {
return DSA.sign(cryptoGroup, privKey, new NativeBigInteger(1, hash), random);
}
public void onSetDropProbability(int val) {
synchronized(this) {
if(socket == null) return;
}
socket.setDropProbability(val);
}
public void stop() {
config.stopping(this);
socket.close(true);
}
public PeerNode[] getPeerNodes() {
if(node.peers == null) return null;
if(isOpennet)
return node.peers.getOpennetPeers();
else
return node.peers.getDarknetPeers();
}
public boolean allowConnection(PeerNode pn, FreenetInetAddress addr) {
if(config.oneConnectionPerAddress()) {
// Disallow multiple connections to the same address
if(node.peers.anyConnectedPeerHasAddress(addr, pn) && !detector.includes(addr)) {
Logger.normal(this, "Not sending handshake packets to "+addr+" for "+pn+" : Same IP address as another node");
return false;
}
}
return true;
}
DSAGroup getCryptoGroup() {
return cryptoGroup;
}
/**
* Get the cipher for connection attempts for e.g. seednode connections from nodes we don't know.
*/
public BlockCipher getAnonSetupCipher() {
return anonSetupCipher;
}
public PeerNode[] getAnonSetupPeerNodes() {
Vector v = new Vector();
PeerNode[] peers = node.peers.myPeers;
for(int i=0;i<peers.length;i++) {
PeerNode pn = peers[i];
if(pn.handshakeUnknownInitiator() && pn.getOutgoingMangler() == packetMangler)
v.add(pn);
}
return (PeerNode[]) v.toArray(new PeerNode[v.size()]);
}
void setPortForwardingBroken() {
this.socket.getAddressTracker().setBroken();
}
/**
* Get my identity.
* @param unknownInitiator Unknown-initiator connections use the hash of the pubkey as the identity to save space
* in packets 3 and 4.
*/
public byte[] getIdentity(boolean unknownInitiator) {
if(unknownInitiator)
return this.pubKey.asBytesHash();
else
return myIdentity;
}
public boolean definitelyPortForwarded() {
return socket.getDetectedConnectivityStatus() == AddressTracker.DEFINITELY_PORT_FORWARDED;
}
public int getDetectedConnectivityStatus() {
return socket.getDetectedConnectivityStatus();
}
public FreenetInetAddress getBindTo() {
return config.getBindTo();
}
}
The table below shows all metrics for NodeCrypto.java.
| Metric | Value | Description | |
|---|---|---|---|
| BLOCKS | 77.00 | Number of blocks | |
| BLOCK_COMMENT | 3.00 | Number of block comment lines | |
| COMMENTS | 83.00 | Comment lines | |
| COMMENT_DENSITY | 0.25 | Comment density | |
| COMPARISONS | 30.00 | Number of comparison operators | |
| CYCLOMATIC | 95.00 | Cyclomatic complexity | |
| DECL_COMMENTS | 27.00 | Comments in declarations | |
| DOC_COMMENT | 64.00 | Number of javadoc comment lines | |
| ELOC | 330.00 | Effective lines of code | |
| EXEC_COMMENTS | 12.00 | Comments in executable code | |
| EXITS | 99.00 | Procedure exits | |
| FUNCTIONS | 29.00 | Number of function declarations | |
| HALSTEAD_DIFFICULTY | 73.54 | Halstead difficulty | |
| HALSTEAD_EFFORT | 0.00 | Halstead effort | |
| INTERFACE_COMPLEXITY | 64.00 | Interface complexity | |
| JAVA0001 | 0.00 | JAVA0001 Package name does not contain only lower case letters | |
| JAVA0002 | 1.00 | JAVA0002 Package name does not begin with a top level domain name or country code | |
| JAVA0003 | 0.00 | JAVA0003 Minimize use of on-demand (.*) imports | |
| JAVA0004 | 0.00 | JAVA0004 Unnecessary import from java.lang | |
| JAVA0005 | 0.00 | JAVA0005 Imports not in specified order | |
| JAVA0006 | 0.00 | JAVA0006 Empty finally block | |
| JAVA0007 | 1.00 | JAVA0007 Should not declare public field | |
| JAVA0008 | 0.00 | JAVA0008 Empty catch block | |
| JAVA0009 | 0.00 | JAVA0009 Protected member in final class | |
| JAVA0010 | 0.00 | JAVA0010 Non-instantiable class does not contain a non-private static member | |
| JAVA0011 | 0.00 | JAVA0011 Abstract class does not contain an abstract method | |
| JAVA0012 | 0.00 | JAVA0012 Non-constructor method with same name as declaring class | |
| JAVA0013 | 0.00 | JAVA0013 Non-blank final field is not static | |
| JAVA0014 | 0.00 | JAVA0014 Class with only static members has non-private constructor | |
| JAVA0015 | 0.00 | JAVA0015 Package class contains public nested type | |
| JAVA0016 | 0.00 | JAVA0016 Abstract class contains public constructor | |
| JAVA0017 | 0.00 | JAVA0017 Class name does not have required form | |
| JAVA0018 | 0.00 | JAVA0018 Method name does not have required form | |
| JAVA0019 | 0.00 | JAVA0019 Interface name does not have required form | |
| JAVA0020 | 0.00 | JAVA0020 Field name does not have required form | |
| JAVA0021 | 0.00 | JAVA0021 Interface method name does not have required form | |
| JAVA0022 | 0.00 | JAVA0022 Static final field name does not have required form | |
| JAVA0023 | 0.00 | JAVA0023 Empty finalize method | |
| JAVA0024 | 0.00 | JAVA0024 Empty class | |
| JAVA0025 | 0.00 | JAVA0025 Method override is empty | |
| JAVA0026 | 0.00 | JAVA0026 Finalize method with parameters | |
| JAVA0029 | 0.00 | JAVA0029 Private method not used | |
| JAVA0030 | 0.00 | JAVA0030 Private field not used | |
| JAVA0031 | 0.00 | JAVA0031 Case statement not properly closed | |
| JAVA0032 | 0.00 | JAVA0032 Switch statement missing default | |
| JAVA0033 | 0.00 | JAVA0033 default: not last case in switch statement | |
| JAVA0034 | 22.00 | JAVA0034 Missing braces in if statement | |
| JAVA0035 | 1.00 | JAVA0035 Missing braces in for statement | |
| JAVA0036 | 0.00 | JAVA0036 Missing braces in while statement | |
| JAVA0038 | 0.00 | JAVA0038 Non-case label in switch statement | |
| JAVA0039 | 0.00 | JAVA0039 Break statement with label | |
| JAVA0040 | 0.00 | JAVA0040 Switch statement contains N cases (maximum: M) | |
| JAVA0041 | 0.00 | JAVA0041 Nested synchronized block | |
| JAVA0042 | 0.00 | JAVA0042 Empty synchronized statement | |
| JAVA0043 | 0.00 | JAVA0043 Inner class does not use outer class | |
| JAVA0044 | 0.00 | JAVA0044 Serializable class with no instance variables | |
| JAVA0045 | 0.00 | JAVA0045 Serializable class with only transient fields | |
| JAVA0046 | 0.00 | JAVA0046 Name of class not derived from Exception ends with 'Exception' | |
| JAVA0047 | 0.00 | JAVA0047 Serializable class derives from invalid base class | |
| JAVA0048 | 0.00 | JAVA0048 Name of class derived from Exception does not end with 'Exception' | |
| JAVA0049 | 0.00 | JAVA0049 Nested block at depth N (maximum: M) | |
| JAVA0050 | 0.00 | JAVA0050 Class derives from java.lang.Error | |
| JAVA0051 | 0.00 | JAVA0051 Class derives from java.lang.RuntimeException | |
| JAVA0052 | 0.00 | JAVA0052 Class derives from java.lang.Throwable | |
| JAVA0053 | 0.00 | JAVA0053 Unused label | |
| JAVA0054 | 0.00 | JAVA0054 Inheritance depth N exceeds maximum M | |
| JAVA0055 | 0.00 | JAVA0055 Class should be interface | |
| JAVA0056 | 0.00 | JAVA0056 Unnecessary abstract modifier for interface or annotation | |
| JAVA0057 | 0.00 | JAVA0057 Unnecessary default constructor | |
| JAVA0058 | 0.00 | JAVA0058 Constructor calls super() | |
| JAVA0059 | 0.00 | JAVA0059 Method override only calls super() | |
| JAVA0061 | 0.00 | JAVA0061 Inaccessible member in anonymous class | |
| JAVA0062 | 0.00 | JAVA0062 Public class missing public member or protected constructor | |
| JAVA0063 | 0.00 | JAVA0063 Identifier name should not contain '$' | |
| JAVA0064 | 0.00 | JAVA0064 N variations of identifier name (maximum: M) | |
| JAVA0065 | 0.00 | JAVA0065 Unnecessary final modifier for method in final class | |
| JAVA0066 | 0.00 | JAVA0066 Unnecessary modifier for interface nested type | |
| JAVA0067 | 0.00 | JAVA0067 Array descriptor on identifier name | |
| JAVA0068 | 0.00 | JAVA0068 Modifiers not declared in recommended order | |
| JAVA0071 | 0.00 | JAVA0071 Strings compared with == | |
| JAVA0073 | 0.00 | JAVA0073 Integer division in floating-point context | |
| JAVA0074 | 0.00 | JAVA0074 Use of Object.notify() | |
| JAVA0075 | 1.00 | JAVA0075 Method parameter hides field | |
| JAVA0076 | 7.00 | JAVA0076 Use of magic number | |
| JAVA0077 | 0.00 | JAVA0077 Private field not used in declaring class | |
| JAVA0078 | 0.00 | JAVA0078 Floating point values compared with == | |
| JAVA0079 | 0.00 | JAVA0079 Use of instance to reference static member | |
| JAVA0080 | 0.00 | JAVA0080 Import declaration not used | |
| JAVA0081 | 0.00 | JAVA0081 Boolean literal in comparison | |
| JAVA0082 | 0.00 | JAVA0082 Unnecessary widening cast | |
| JAVA0083 | 0.00 | JAVA0083 Unnecessary instanceof test | |
| JAVA0084 | 0.00 | JAVA0084 Should use compound assignment operator | |
| JAVA0085 | 0.00 | JAVA0085 Use of sun.* class | |
| JAVA0087 | 0.00 | JAVA0087 Use of Thread.sleep() | |
| JAVA0089 | 0.00 | JAVA0089 Use of restricted package | |
| JAVA0092 | 0.00 | JAVA0092 Use of restricted type | |
| JAVA0093 | 0.00 | JAVA0093 Redundant assignment | |
| JAVA0094 | 0.00 | JAVA0094 Field hides a superclass field | |
| JAVA0095 | 0.00 | JAVA0095 Uninitialized private field | |
| JAVA0096 | 0.00 | JAVA0096 Field in nested class hides outer field | |
| JAVA0098 | 1.00 | JAVA0098 Minimize use of implicit field initializers | |
| JAVA0100 | 1.00 | JAVA0100 Class contains N non-final fields (maximum: M) | |
| JAVA0101 | 0.00 | JAVA0101 Unnecessary modifier for field in interface | |
| JAVA0102 | 0.00 | JAVA0102 Last statement in finalize() not super.finalize() | |
| JAVA0103 | 0.00 | JAVA0103 Explicit call to finalize() | |
| JAVA0104 | 0.00 | JAVA0104 finalize() only calls super.finalize() | |
| JAVA0105 | 0.00 | JAVA0105 Duplicate import declaration | |
| JAVA0106 | 0.00 | JAVA0106 Unnecessary import from current package | |
| JAVA0108 | 7.00 | JAVA0108 Incorrect javadoc: no @param tag for 'parameter' | |
| JAVA0109 | 0.00 | JAVA0109 Incorrect javadoc: no parameter 'parameter' | |
| JAVA0110 | 8.00 | JAVA0110 Incorrect javadoc: no @return tag | |
| JAVA0111 | 0.00 | JAVA0111 Incorrect javadoc: @return tag for void method | |
| JAVA0112 | 0.00 | JAVA0112 Incorrect javadoc: no exception 'exception' in throws | |
| JAVA0113 | 0.00 | JAVA0113 Incorrect javadoc: no @author tag | |
| JAVA0114 | 1.00 | JAVA0114 Incorrect javadoc: no @version tag | |
| JAVA0115 | 0.00 | JAVA0115 Incorrect javadoc: no @throws or @exception tag for 'exception' | |
| JAVA0116 | 1.00 | JAVA0116 Missing javadoc: field 'field' | |
| JAVA0117 | 11.00 | JAVA0117 Missing javadoc: method 'method' | |
| JAVA0118 | 0.00 | JAVA0118 Missing javadoc: type 'type' | |
| JAVA0119 | 0.00 | JAVA0119 Control variable changed within body of for loop | |
| JAVA0123 | 0.00 | JAVA0123 Use all three components of for loop | |
| JAVA0125 | 0.00 | JAVA0125 Continue statement with label | |
| JAVA0126 | 0.00 | JAVA0126 Method declares unchecked exception in throws | |
| JAVA0128 | 0.00 | JAVA0128 Public constructor in non-public class | |
| JAVA0130 | 0.00 | JAVA0130 Non-static method does not use instance fields | |
| JAVA0131 | 0.00 | JAVA0131 Compatible method does not override base | |
| JAVA0132 | 0.00 | JAVA0132 Method overload with compatible signature | |
| JAVA0133 | 0.00 | JAVA0133 Non-synchronized method overrides synchronized method | |
| JAVA0135 | 0.00 | JAVA0135 Only one of Object.equals and Object.hashCode defined: missing 'method' | |
| JAVA0136 | 1.00 | JAVA0136 N methods defined in class (maximum: M) | |
| JAVA0137 | 0.00 | JAVA0137 Non-abstract class missing constructor | |
| JAVA0138 | 0.00 | JAVA0138 N parameters defined for method (maximum: M) | |
| JAVA0139 | 0.00 | JAVA0139 Definition of main other than public static void main(java.lang.String[]) | |
| JAVA0141 | 0.00 | JAVA0141 Unnecessary modifier for method in interface | |
| JAVA0143 | 0.00 | JAVA0143 Synchronized method | |
| JAVA0144 | 6.00 | JAVA0144 Line exceeds maximum M characters | |
| JAVA0145 | 961.00 | JAVA0145 Tab character used in source file | |
| JAVA0150 | 2.00 | JAVA0150 java.lang.Error (or subclass) thrown | |
| JAVA0153 | 0.00 | JAVA0153 Inefficient conversion of integer to string | |
| JAVA0159 | 0.00 | JAVA0159 Inefficient conversion of string to integer | |
| JAVA0160 | 0.00 | JAVA0160 Method does not throw specified exception | |
| JAVA0161 | 0.00 | JAVA0161 Conditional wait() not in loop | |
| JAVA0163 | 0.00 | JAVA0163 Empty statement | |
| JAVA0165 | 0.00 | JAVA0165 Conflicting return statement in finally block | |
| JAVA0166 | 4.00 | JAVA0166 Generic exception caught | |
| JAVA0167 | 0.00 | JAVA0167 ThreadDeath not rethrown | |
| JAVA0169 | 0.00 | JAVA0169 Unnecessary catch block: exception 'exception' | |
| JAVA0170 | 1.00 | JAVA0170 Caught exception not derived from java.lang.Exception | |
| JAVA0171 | 0.00 | JAVA0171 Unused local variable | |
| JAVA0173 | 0.00 | JAVA0173 Unused method parameter | |
| JAVA0174 | 0.00 | JAVA0174 Assigned local variable never used | |
| JAVA0175 | 0.00 | JAVA0175 Successive assignment to variable | |
| JAVA0176 | 1.00 | JAVA0176 Local variable name does not have required form | |
| JAVA0177 | 1.00 | JAVA0177 Variable declaration missing initializer | |
| JAVA0179 | 0.00 | JAVA0179 Local variable hides visible field | |
| JAVA0233 | 0.00 | JAVA0233 Definition of serialVersionUID other than 'private static final long serialVersionUID' | |
| JAVA0234 | 0.00 | JAVA0234 Class is Serializable but does not define serialVersionUID | |
| JAVA0235 | 0.00 | JAVA0235 Class defines serialVersionUID but does not implement Serializable | |
| JAVA0236 | 0.00 | JAVA0236 Attempt to clone an object which does not implement Cloneable | |
| JAVA0237 | 0.00 | JAVA0237 Class implements Cloneable but does not have public clone method | |
| JAVA0238 | 0.00 | JAVA0238 Clone method does not call super.clone() | |
| JAVA0239 | 0.00 | JAVA0239 Class declares 'readObject' or 'writeObject' but does not implement Serializable | |
| JAVA0240 | 0.00 | JAVA0240 Serializable class which declares readObject or writeObject but not both | |
| JAVA0241 | 0.00 | JAVA0241 'readObject' or 'writeObject' should be declared private in Serializable class | |
| JAVA0242 | 0.00 | JAVA0242 Transient field in non-Serializable class | |
| JAVA0243 | 0.00 | JAVA0243 'readResolve' or 'writeReplace' should be declared private or protected | |
| JAVA0244 | 0.00 | JAVA0244 Field or method name in subclass differs only by case from inherited field or method | |
| JAVA0245 | 0.00 | JAVA0245 JUnit TestCase with non-trivial constructor | |
| JAVA0246 | 0.00 | JAVA0246 JUnit assertXXX statement missing message parameter | |
| JAVA0247 | 0.00 | JAVA0247 JUnit 'setUp()' and 'tearDown()' should call super method | |
| JAVA0248 | 0.00 | JAVA0248 JUnit method 'setUp' or 'tearDown' with incorrect signature | |
| JAVA0249 | 0.00 | JAVA0249 JUnit TestCase 'suite()' should be declared static | |
| JAVA0250 | 0.00 | JAVA0250 JUnit TestCase declares testXXX method with incorrect signature | |
| JAVA0251 | 0.00 | JAVA0251 Use '%n' for line breaks in printf/format for platform independence | |
| JAVA0252 | 0.00 | JAVA0252 'enum' is a Java 1.5 reserved word | |
| JAVA0253 | 0.00 | JAVA0253 Not all enum constants consumed in switch statement | |
| JAVA0254 | 0.00 | JAVA0254 Use enhanced for loop construct instead of Iterator | |
| JAVA0255 | 0.00 | JAVA0255 Result of method invocation not used | |
| JAVA0256 | 0.00 | JAVA0256 Assignment of external collection/array to field | |
| JAVA0257 | 0.00 | JAVA0257 Use of 'Constant Interface' anti-pattern | |
| JAVA0258 | 0.00 | JAVA0258 Implement Iterable for foreach compatibility | |
| JAVA0259 | 1.00 | JAVA0259 Return of collection/array field | |
| JAVA0260 | 0.00 | JAVA0260 Use 'enum' instead of Enumerated Type pattern | |
| JAVA0261 | 0.00 | JAVA0261 Use specialized Enum collection types | |
| JAVA0262 | 0.00 | JAVA0262 Use of char in integer context | |
| JAVA0263 | 0.00 | JAVA0263 Long literal ends with 'l' instead of 'L' | |
| JAVA0264 | 0.00 | JAVA0264 Integer math in long context - check for overflow | |
| JAVA0265 | 3.00 | JAVA0265 Use of Throwable.printStackTrace() | |
| JAVA0266 | 1.00 | JAVA0266 Use of System.out | |
| JAVA0267 | 3.00 | JAVA0267 Use of System.err | |
| JAVA0269 | 0.00 | JAVA0269 Contents of StringBuffer never used | |
| JAVA0270 | 2.00 | JAVA0270 Use Java 5.0 enhanced for loop construct to iterate over all elements in an array | |
| JAVA0271 | 0.00 | JAVA0271 Minimize use of on-demand (.*) static imports | |
| JAVA0272 | 0.00 | JAVA0272 Thread.run() called | |
| JAVA0273 | 0.00 | JAVA0273 Non-final derivative of Thread calls start() in constructor | |
| JAVA0274 | 0.00 | JAVA0274 Serializable class has a synchronized readObject() | |
| JAVA0275 | 0.00 | JAVA0275 Serializable class has a synchronized writeObject() and no other synchronized methods | |
| JAVA0276 | 0.00 | JAVA0276 Unnecessary use of String constructor | |
| JAVA0277 | 0.00 | JAVA0277 Iterator.next() implementation does not throw NoSuchElementException | |
| JAVA0278 | 0.00 | JAVA0278 Unnecessary use of Boolean constructor | |
| JAVA0279 | 0.00 | JAVA0279 Serialization method readObject or readObjectNoData calls an overridable method | |
| JAVA0280 | 0.00 | JAVA0280 IllegalMonitorStateException caught | |
| JAVA0281 | 0.00 | JAVA0281 Iterator.next() not called in loop | |
| JAVA0282 | 0.00 | JAVA0282 Call to Iterator.next() in loop which does not test Iterator.hasNext() | |
| JAVA0283 | 0.00 | JAVA0283 Control variable not updated in loop body | |
| JAVA0284 | 0.00 | JAVA0284 Explicit garbage collection | |
| JAVA0285 | 0.00 | JAVA0285 Dereference of potentially null variable | |
| JAVA0286 | 0.00 | JAVA0286 Dereference of null variable | |
| JAVA0287 | 0.00 | JAVA0287 Unnecessary null check | |
| JAVA0288 | 0.00 | JAVA0288 Inconsistent null check | |
| LINES | 528.00 | Number of lines in the source file | |
| LINE_COMMENT | 16.00 | Number of line comments | |
| LOC | 387.00 | Lines of code | |
| LOGICAL_LINES | 239.00 | Number of statements | |
| LOOPS | 3.00 | Number of loops | |
| NEST_DEPTH | 5.00 | Maximum nesting depth | |
| OPERANDS | 986.00 | Number of operands | |
| OPERATORS | 1889.00 | Number of operators | |
| PARAMS | 23.00 | Number of formal parameter declarations | |
| PROGRAM_LENGTH | 2875.00 | Halstead program length | |
| PROGRAM_VOCAB | 416.00 | Halstead program vocabulary | |
| PROGRAM_VOLUME | 0.00 | Halstead program volume | |
| RETURNS | 41.00 | Number of return points from functions | |
| SIZE | 17441.00 | Size of the file in bytes | |
| UNIQUE_OPERANDS | 362.00 | Number of unique operands | |
| UNIQUE_OPERATORS | 54.00 | Number of unique operators | |
| WHITESPACE | 58.00 | Number of whitespace lines | |