CHKInsertHandler.java
| Index Score | ||
|---|---|---|
 |
 |
freenet.node |
 |
 |
Freenet |
View: Reasons, Metrics, Source Code
These are the metrics that contribute to the Enerjy Score for this file, ranked by impact. So the metrics listed at the top influence the score to a greater extent that the metrics listed at the bottom.
| Metric | Description | |
|---|---|---|
| JAVA0034 | JAVA0034 Missing braces in if statement |  |
| EXEC_COMMENTS | Comments in executable code | |
| LINE_COMMENT | Number of line comments | |
| CYCLOMATIC | Cyclomatic complexity | |
| EXITS | Procedure exits | |
| JAVA0161 | JAVA0161 Conditional wait() not in loop | |
| BLOCKS | Number of blocks | |
| JAVA0264 | JAVA0264 Integer math in long context - check for overflow | |
| LOGICAL_LINES | Number of statements | |
| JAVA0144 | JAVA0144 Line exceeds maximum M characters | |
| OPERATORS | Number of operators | |
| PROGRAM_LENGTH | Halstead program length | |
| SIZE | Size of the file in bytes | |
| ELOC | Effective lines of code | |
| PROGRAM_VOCAB | Halstead program vocabulary | |
| JAVA0170 | JAVA0170 Caught exception not derived from java.lang.Exception | |
| UNIQUE_OPERANDS | Number of unique operands | |
| JAVA0177 | JAVA0177 Variable declaration missing initializer | |
| LOC | Lines of code | |
| OPERANDS | Number of operands | |
| UNIQUE_OPERATORS | Number of unique operators | |
| JAVA0143 | JAVA0143 Synchronized method | |
| JAVA0166 | JAVA0166 Generic exception caught | |
| COMPARISONS | Number of comparison operators | |
| PROGRAM_VOLUME | Halstead program volume | |
| JAVA0126 | JAVA0126 Method declares unchecked exception in throws | |
| JAVA0110 | JAVA0110 Incorrect javadoc: no @return tag | |
| LINES | Number of lines in the source file | |
| JAVA0100 | JAVA0100 Class contains N non-final fields (maximum: M) | |
| DOC_COMMENT | Number of javadoc comment lines | |
| DECL_COMMENTS | Comments in declarations | |
| PARAMS | Number of formal parameter declarations | |
| NEST_DEPTH | Maximum nesting depth | |
| COMMENTS | Comment lines | |
/* This code is part of Freenet. It is distributed under the GNU General
* Public License, version 2 (or at your option any later version). See
* http://www.gnu.org/ for further details of the GPL. */
package freenet.node;
import freenet.io.comm.ByteCounter;
import freenet.io.comm.DMT;
import freenet.io.comm.DisconnectedException;
import freenet.io.comm.Message;
import freenet.io.comm.MessageFilter;
import freenet.io.comm.NotConnectedException;
import freenet.io.comm.RetrievalException;
import freenet.io.xfer.AbortedException;
import freenet.io.xfer.BlockReceiver;
import freenet.io.xfer.PartiallyReceivedBlock;
import freenet.keys.CHKBlock;
import freenet.keys.CHKVerifyException;
import freenet.keys.NodeCHK;
import freenet.support.HexUtil;
import freenet.support.Logger;
import freenet.support.OOMHandler;
import freenet.support.ShortBuffer;
import freenet.support.io.NativeThread;
/**
* @author amphibian
*
* Handle an incoming insert request.
* This corresponds to RequestHandler.
*/
public class CHKInsertHandler implements PrioRunnable, ByteCounter {
static final int DATA_INSERT_TIMEOUT = 10000;
final Message req;
final Node node;
final long uid;
final PeerNode source;
final NodeCHK key;
final long startTime;
private short htl;
private CHKInsertSender sender;
private byte[] headers;
private BlockReceiver br;
private Thread runThread;
PartiallyReceivedBlock prb;
private static boolean logMINOR;
CHKInsertHandler(Message req, PeerNode source, long id, Node node, long startTime) {
this.req = req;
this.node = node;
this.uid = id;
this.source = source;
this.startTime = startTime;
key = (NodeCHK) req.getObject(DMT.FREENET_ROUTING_KEY);
htl = req.getShort(DMT.HTL);
if(htl <= 0) htl = 1;
logMINOR = Logger.shouldLog(Logger.MINOR, this);
receivedBytes(req.receivedByteCount());
}
public String toString() {
return super.toString()+" for "+uid;
}
public void run() {
freenet.support.Logger.OSThread.logPID(this);
try {
realRun();
} catch (OutOfMemoryError e) {
OOMHandler.handleOOM(e);
} catch (Throwable t) {
Logger.error(this, "Caught in run() "+t, t);
} finally {
if(logMINOR) Logger.minor(this, "Exiting CHKInsertHandler.run() for "+uid);
node.unlockUID(uid, false, true, false, false, false);
}
}
private void realRun() {
runThread = Thread.currentThread();
// FIXME implement rate limiting or something!
// Send Accepted
Message accepted = DMT.createFNPAccepted(uid);
try {
//Using sendSync here will help the next message filter not timeout... wait here or at the message filter.
source.sendSync(accepted, this);
} catch (NotConnectedException e1) {
if(logMINOR) Logger.minor(this, "Lost connection to source");
return;
}
// Source will send us a DataInsert
MessageFilter mf;
mf = MessageFilter.create().setType(DMT.FNPDataInsert).setField(DMT.UID, uid).setSource(source).setTimeout(DATA_INSERT_TIMEOUT);
Message msg;
try {
msg = node.usm.waitFor(mf, this);
} catch (DisconnectedException e) {
Logger.normal(this, "Disconnected while waiting for DataInsert on "+uid);
return;
}
if(logMINOR) Logger.minor(this, "Received "+msg);
if(msg == null) {
try {
if(source.isConnected() && (startTime > (source.timeLastConnectionCompleted()+Node.HANDSHAKE_TIMEOUT*4)))
Logger.error(this, "Did not receive DataInsert on "+uid+" from "+source+" !");
Message tooSlow = DMT.createFNPRejectedTimeout(uid);
source.sendAsync(tooSlow, null, 0, this);
Message m = DMT.createFNPInsertTransfersCompleted(uid, true);
source.sendAsync(m, null, 0, this);
prb = new PartiallyReceivedBlock(Node.PACKETS_IN_BLOCK, Node.PACKET_SIZE);
br = new BlockReceiver(node.usm, source, uid, prb, this);
prb.abort(RetrievalException.NO_DATAINSERT, "No DataInsert");
br.sendAborted(RetrievalException.NO_DATAINSERT, "No DataInsert");
return;
} catch (NotConnectedException e) {
if(logMINOR) Logger.minor(this, "Lost connection to source");
return;
}
}
// We have a DataInsert
headers = ((ShortBuffer)msg.getObject(DMT.BLOCK_HEADERS)).getData();
// FIXME check the headers
// Now create an CHKInsertSender, or use an existing one, or
// discover that the data is in the store.
// From this point onwards, if we return cleanly we must go through finish().
prb = new PartiallyReceivedBlock(Node.PACKETS_IN_BLOCK, Node.PACKET_SIZE);
if(htl > 0)
sender = node.makeInsertSender(key, htl, uid, source, headers, prb, false, true);
br = new BlockReceiver(node.usm, source, uid, prb, this);
// Receive the data, off thread
Runnable dataReceiver = new DataReceiver();
receiveStarted = true;
node.executor.execute(dataReceiver, "CHKInsertHandler$DataReceiver for UID "+uid);
if(htl == 0) {
canCommit = true;
msg = DMT.createFNPInsertReply(uid);
try {
source.sendSync(msg, this);
} catch (NotConnectedException e) {
// Ignore
}
finish(CHKInsertSender.SUCCESS);
return;
}
// Wait...
// What do we want to wait for?
// If the data receive completes, that's very nice,
// but doesn't really matter. What matters is what
// happens to the CHKInsertSender. If the data receive
// fails, that does matter...
// We are waiting for a terminal status on the CHKInsertSender,
// including SUCCESS.
// If we get transfer failed, we can check whether the receive
// failed first. If it did it's not our fault.
// If the receive failed, and we haven't started transferring
// yet, we probably want to kill the sender.
// So we call the wait method on the CHKInsertSender, but we
// also have a flag locally to indicate the receive failed.
// And if it does, we interrupt.
boolean receivedRejectedOverload = false;
while(true) {
synchronized(sender) {
try {
if(sender.getStatus() == CHKInsertSender.NOT_FINISHED)
sender.wait(5000);
} catch (InterruptedException e) {
// Cool, probably this is because the receive failed...
}
}
if(receiveFailed()) {
// Nothing else we can do
finish(CHKInsertSender.RECEIVE_FAILED);
return;
}
if((!receivedRejectedOverload) && sender.receivedRejectedOverload()) {
receivedRejectedOverload = true;
// Forward it
Message m = DMT.createFNPRejectedOverload(uid, false);
try {
source.sendSync(m, this);
} catch (NotConnectedException e) {
if(logMINOR) Logger.minor(this, "Lost connection to source");
return;
}
}
int status = sender.getStatus();
if(status == CHKInsertSender.NOT_FINISHED) {
continue;
}
// Local RejectedOverload's (fatal).
// Internal error counts as overload. It'd only create a timeout otherwise, which is the same thing anyway.
if((status == CHKInsertSender.TIMED_OUT) ||
(status == CHKInsertSender.GENERATED_REJECTED_OVERLOAD) ||
(status == CHKInsertSender.INTERNAL_ERROR)) {
msg = DMT.createFNPRejectedOverload(uid, true);
try {
source.sendSync(msg, this);
} catch (NotConnectedException e) {
if(logMINOR) Logger.minor(this, "Lost connection to source");
return;
}
// Might as well store it anyway.
if((status == CHKInsertSender.TIMED_OUT) ||
(status == CHKInsertSender.GENERATED_REJECTED_OVERLOAD))
canCommit = true;
finish(status);
return;
}
if((status == CHKInsertSender.ROUTE_NOT_FOUND) || (status == CHKInsertSender.ROUTE_REALLY_NOT_FOUND)) {
msg = DMT.createFNPRouteNotFound(uid, sender.getHTL());
try {
source.sendSync(msg, this);
} catch (NotConnectedException e) {
if(logMINOR) Logger.minor(this, "Lost connection to source");
return;
}
canCommit = true;
finish(status);
return;
}
if(status == CHKInsertSender.RECEIVE_FAILED) {
// Probably source's fault.
finish(status);
return;
}
if(status == CHKInsertSender.SUCCESS) {
msg = DMT.createFNPInsertReply(uid);
try {
source.sendSync(msg, this);
} catch (NotConnectedException e) {
Logger.minor(this, "Lost connection to source");
return;
}
canCommit = true;
finish(status);
return;
}
// Otherwise...?
Logger.error(this, "Unknown status code: "+sender.getStatusString());
msg = DMT.createFNPRejectedOverload(uid, true);
try {
source.sendSync(msg, this);
} catch (NotConnectedException e) {
// Ignore
}
finish(CHKInsertSender.INTERNAL_ERROR);
return;
}
}
private boolean canCommit = false;
private boolean sentCompletion = false;
private Object sentCompletionLock = new Object();
/**
* If canCommit, and we have received all the data, and it
* verifies, then commit it.
*/
private void finish(int code) {
if(logMINOR) Logger.minor(this, "Waiting for receive");
synchronized(this) {
while(receiveStarted && !receiveCompleted) {
try {
wait(100*1000);
} catch (InterruptedException e) {
// Ignore
}
}
}
maybeCommit();
if(logMINOR) Logger.minor(this, "Waiting for completion");
// Wait for completion
boolean sentCompletionWasSet;
synchronized(sentCompletionLock) {
sentCompletionWasSet = sentCompletion;
sentCompletion = true;
}
Message m=null;
if((sender != null) && (!sentCompletionWasSet)) {
//If there are downstream senders, our final success report depends on there being no timeouts in the chain.
while(true) {
synchronized(sender) {
if(sender.completed()) {
break;
}
try {
sender.wait(10*1000);
} catch (InterruptedException e) {
// Loop
}
}
}
boolean failed = sender.anyTransfersFailed();
m = DMT.createFNPInsertTransfersCompleted(uid, failed);
}
if((sender == null) && (!sentCompletionWasSet) && (canCommit)) {
//There are no downstream senders, but we stored the data locally, report successful transfer.
//Note that this is done even if the verify fails.
m = DMT.createFNPInsertTransfersCompleted(uid, false /* no timeouts */);
}
try {
source.sendSync(m, this);
if(logMINOR) Logger.minor(this, "Sent completion: "+m+" for "+this);
} catch (NotConnectedException e1) {
if(logMINOR) Logger.minor(this, "Not connected: "+source+" for "+this);
// May need to commit anyway...
}
if(code != CHKInsertSender.TIMED_OUT && code != CHKInsertSender.GENERATED_REJECTED_OVERLOAD &&
code != CHKInsertSender.INTERNAL_ERROR && code != CHKInsertSender.ROUTE_REALLY_NOT_FOUND &&
code != CHKInsertSender.RECEIVE_FAILED && !receiveFailed()) {
int totalSent = getTotalSentBytes();
int totalReceived = getTotalReceivedBytes();
if(sender != null) {
totalSent += sender.getTotalSentBytes();
totalReceived += sender.getTotalReceivedBytes();
}
if(logMINOR) Logger.minor(this, "Remote CHK insert cost "+totalSent+ '/' +totalReceived+" bytes ("+code+ ") receive failed = "+receiveFailed());
node.nodeStats.remoteChkInsertBytesSentAverage.report(totalSent);
node.nodeStats.remoteChkInsertBytesReceivedAverage.report(totalReceived);
if(code == CHKInsertSender.SUCCESS) {
// Report both sent and received because we have both a Handler and a Sender
if(sender != null && sender.startedSendingData())
node.nodeStats.successfulChkInsertBytesSentAverage.report(totalSent);
node.nodeStats.successfulChkInsertBytesReceivedAverage.report(totalReceived);
}
}
}
/**
* Verify data, or send DataInsertRejected.
*/
private void maybeCommit() {
Message toSend = null;
synchronized(this) {
if((prb == null) || prb.isAborted()) return;
try {
if(!canCommit) return;
if(!prb.allReceived()) return;
CHKBlock block = new CHKBlock(prb.getBlock(), headers, key);
node.store(block);
if(logMINOR) Logger.minor(this, "Committed");
} catch (CHKVerifyException e) {
Logger.error(this, "Verify failed in CHKInsertHandler: "+e+" - headers: "+HexUtil.bytesToHex(headers), e);
toSend = DMT.createFNPDataInsertRejected(uid, DMT.DATA_INSERT_REJECTED_VERIFY_FAILED);
} catch (AbortedException e) {
Logger.error(this, "Receive failed: "+e);
// Receiver thread (below) will handle sending the failure notice
}
}
if(toSend != null) {
try {
source.sendAsync(toSend, null, 0, this);
} catch (NotConnectedException e) {
// :(
if(logMINOR) Logger.minor(this, "Lost connection in "+this+" when sending FNPDataInsertRejected");
}
}
}
/** Has the receive failed? If so, there's not much more that can be done... */
private boolean receiveFailed;
private boolean receiveStarted;
private boolean receiveCompleted;
public class DataReceiver implements PrioRunnable {
public void run() {
freenet.support.Logger.OSThread.logPID(this);
if(logMINOR) Logger.minor(this, "Receiving data for "+CHKInsertHandler.this);
try {
// Don't log whether the transfer succeeded or failed as the transfer was initiated by the source therefore could be unreliable evidence.
br.receive();
if(logMINOR) Logger.minor(this, "Received data for "+CHKInsertHandler.this);
synchronized(CHKInsertHandler.this) {
receiveCompleted = true;
CHKInsertHandler.this.notifyAll();
}
node.nodeStats.successfulBlockReceive();
} catch (RetrievalException e) {
synchronized(CHKInsertHandler.this) {
receiveCompleted = true;
receiveFailed = true;
CHKInsertHandler.this.notifyAll();
}
// Cancel the sender
if(sender != null)
sender.receiveFailed(); // tell it to stop if it hasn't already failed... unless it's sending from store
runThread.interrupt();
Message msg = DMT.createFNPDataInsertRejected(uid, DMT.DATA_INSERT_REJECTED_RECEIVE_FAILED);
try {
source.sendSync(msg, CHKInsertHandler.this);
} catch (NotConnectedException ex) {
//If they are not connected, that's probably why the receive failed!
if (logMINOR) Logger.minor(this, "Can't send "+msg+" to "+source+": "+ex);
}
if (e.getReason()==RetrievalException.SENDER_DISCONNECTED)
Logger.normal(this, "Failed to retrieve (disconnect): "+e, e);
else
// Annoying, but we have stats for this; no need to call attention to it, it's unlikely to be a bug.
Logger.normal(this, "Failed to retrieve ("+e.getReason()+"/"+RetrievalException.getErrString(e.getReason())+"): "+e, e);
node.nodeStats.failedBlockReceive();
return;
} catch (Throwable t) {
Logger.error(this, "Caught "+t, t);
}
}
public String toString() {
return super.toString()+" for "+uid;
}
public int getPriority() {
return NativeThread.HIGH_PRIORITY;
}
}
private synchronized boolean receiveFailed() {
return receiveFailed;
}
private final Object totalSync = new Object();
private int totalSentBytes;
private int totalReceivedBytes;
public void sentBytes(int x) {
synchronized(totalSync) {
totalSentBytes += x;
}
node.nodeStats.insertSentBytes(false, x);
}
public void receivedBytes(int x) {
synchronized(totalSync) {
totalReceivedBytes += x;
}
node.nodeStats.insertReceivedBytes(false, x);
}
public int getTotalSentBytes() {
return totalSentBytes;
}
public int getTotalReceivedBytes() {
return totalReceivedBytes;
}
public void sentPayload(int x) {
node.sentPayload(x);
node.nodeStats.insertSentBytes(false, -x);
}
public int getPriority() {
return NativeThread.HIGH_PRIORITY;
}
}
The table below shows all metrics for CHKInsertHandler.java.
| Metric | Value | Description | |
|---|---|---|---|
| BLOCKS | 84.00 | Number of blocks | |
| BLOCK_COMMENT | 3.00 | Number of block comment lines | |
| COMMENTS | 66.00 | Comment lines | |
| COMMENT_DENSITY | 0.22 | Comment density | |
| COMPARISONS | 44.00 | Number of comparison operators | |
| CYCLOMATIC | 99.00 | Cyclomatic complexity | |
| DECL_COMMENTS | 5.00 | Comments in declarations | |
| DOC_COMMENT | 14.00 | Number of javadoc comment lines | |
| ELOC | 302.00 | Effective lines of code | |
| EXEC_COMMENTS | 32.00 | Comments in executable code | |
| EXITS | 69.00 | Procedure exits | |
| FUNCTIONS | 16.00 | Number of function declarations | |
| HALSTEAD_DIFFICULTY | 79.33 | Halstead difficulty | |
| HALSTEAD_EFFORT | 0.00 | Halstead effort | |
| INTERFACE_COMPLEXITY | 44.00 | Interface complexity | |
| JAVA0001 | 0.00 | JAVA0001 Package name does not contain only lower case letters | |
| JAVA0002 | 1.00 | JAVA0002 Package name does not begin with a top level domain name or country code | |
| JAVA0003 | 0.00 | JAVA0003 Minimize use of on-demand (.*) imports | |
| JAVA0004 | 0.00 | JAVA0004 Unnecessary import from java.lang | |
| JAVA0005 | 0.00 | JAVA0005 Imports not in specified order | |
| JAVA0006 | 0.00 | JAVA0006 Empty finally block | |
| JAVA0007 | 0.00 | JAVA0007 Should not declare public field | |
| JAVA0008 | 0.00 | JAVA0008 Empty catch block | |
| JAVA0009 | 0.00 | JAVA0009 Protected member in final class | |
| JAVA0010 | 0.00 | JAVA0010 Non-instantiable class does not contain a non-private static member | |
| JAVA0011 | 0.00 | JAVA0011 Abstract class does not contain an abstract method | |
| JAVA0012 | 0.00 | JAVA0012 Non-constructor method with same name as declaring class | |
| JAVA0013 | 0.00 | JAVA0013 Non-blank final field is not static | |
| JAVA0014 | 0.00 | JAVA0014 Class with only static members has non-private constructor | |
| JAVA0015 | 0.00 | JAVA0015 Package class contains public nested type | |
| JAVA0016 | 0.00 | JAVA0016 Abstract class contains public constructor | |
| JAVA0017 | 0.00 | JAVA0017 Class name does not have required form | |
| JAVA0018 | 0.00 | JAVA0018 Method name does not have required form | |
| JAVA0019 | 0.00 | JAVA0019 Interface name does not have required form | |
| JAVA0020 | 0.00 | JAVA0020 Field name does not have required form | |
| JAVA0021 | 0.00 | JAVA0021 Interface method name does not have required form | |
| JAVA0022 | 0.00 | JAVA0022 Static final field name does not have required form | |
| JAVA0023 | 0.00 | JAVA0023 Empty finalize method | |
| JAVA0024 | 0.00 | JAVA0024 Empty class | |
| JAVA0025 | 0.00 | JAVA0025 Method override is empty | |
| JAVA0026 | 0.00 | JAVA0026 Finalize method with parameters | |
| JAVA0029 | 0.00 | JAVA0029 Private method not used | |
| JAVA0030 | 0.00 | JAVA0030 Private field not used | |
| JAVA0031 | 0.00 | JAVA0031 Case statement not properly closed | |
| JAVA0032 | 0.00 | JAVA0032 Switch statement missing default | |
| JAVA0033 | 0.00 | JAVA0033 default: not last case in switch statement | |
| JAVA0034 | 29.00 | JAVA0034 Missing braces in if statement | |
| JAVA0035 | 0.00 | JAVA0035 Missing braces in for statement | |
| JAVA0036 | 0.00 | JAVA0036 Missing braces in while statement | |
| JAVA0038 | 0.00 | JAVA0038 Non-case label in switch statement | |
| JAVA0039 | 0.00 | JAVA0039 Break statement with label | |
| JAVA0040 | 0.00 | JAVA0040 Switch statement contains N cases (maximum: M) | |
| JAVA0041 | 0.00 | JAVA0041 Nested synchronized block | |
| JAVA0042 | 0.00 | JAVA0042 Empty synchronized statement | |
| JAVA0043 | 0.00 | JAVA0043 Inner class does not use outer class | |
| JAVA0044 | 0.00 | JAVA0044 Serializable class with no instance variables | |
| JAVA0045 | 0.00 | JAVA0045 Serializable class with only transient fields | |
| JAVA0046 | 0.00 | JAVA0046 Name of class not derived from Exception ends with 'Exception' | |
| JAVA0047 | 0.00 | JAVA0047 Serializable class derives from invalid base class | |
| JAVA0048 | 0.00 | JAVA0048 Name of class derived from Exception does not end with 'Exception' | |
| JAVA0049 | 0.00 | JAVA0049 Nested block at depth N (maximum: M) | |
| JAVA0050 | 0.00 | JAVA0050 Class derives from java.lang.Error | |
| JAVA0051 | 0.00 | JAVA0051 Class derives from java.lang.RuntimeException | |
| JAVA0052 | 0.00 | JAVA0052 Class derives from java.lang.Throwable | |
| JAVA0053 | 0.00 | JAVA0053 Unused label | |
| JAVA0054 | 0.00 | JAVA0054 Inheritance depth N exceeds maximum M | |
| JAVA0055 | 0.00 | JAVA0055 Class should be interface | |
| JAVA0056 | 0.00 | JAVA0056 Unnecessary abstract modifier for interface or annotation | |
| JAVA0057 | 0.00 | JAVA0057 Unnecessary default constructor | |
| JAVA0058 | 0.00 | JAVA0058 Constructor calls super() | |
| JAVA0059 | 0.00 | JAVA0059 Method override only calls super() | |
| JAVA0061 | 0.00 | JAVA0061 Inaccessible member in anonymous class | |
| JAVA0062 | 0.00 | JAVA0062 Public class missing public member or protected constructor | |
| JAVA0063 | 0.00 | JAVA0063 Identifier name should not contain '$' | |
| JAVA0064 | 0.00 | JAVA0064 N variations of identifier name (maximum: M) | |
| JAVA0065 | 0.00 | JAVA0065 Unnecessary final modifier for method in final class | |
| JAVA0066 | 0.00 | JAVA0066 Unnecessary modifier for interface nested type | |
| JAVA0067 | 0.00 | JAVA0067 Array descriptor on identifier name | |
| JAVA0068 | 0.00 | JAVA0068 Modifiers not declared in recommended order | |
| JAVA0071 | 0.00 | JAVA0071 Strings compared with == | |
| JAVA0073 | 0.00 | JAVA0073 Integer division in floating-point context | |
| JAVA0074 | 0.00 | JAVA0074 Use of Object.notify() | |
| JAVA0075 | 0.00 | JAVA0075 Method parameter hides field | |
| JAVA0076 | 2.00 | JAVA0076 Use of magic number | |
| JAVA0077 | 0.00 | JAVA0077 Private field not used in declaring class | |
| JAVA0078 | 0.00 | JAVA0078 Floating point values compared with == | |
| JAVA0079 | 0.00 | JAVA0079 Use of instance to reference static member | |
| JAVA0080 | 0.00 | JAVA0080 Import declaration not used | |
| JAVA0081 | 0.00 | JAVA0081 Boolean literal in comparison | |
| JAVA0082 | 0.00 | JAVA0082 Unnecessary widening cast | |
| JAVA0083 | 0.00 | JAVA0083 Unnecessary instanceof test | |
| JAVA0084 | 0.00 | JAVA0084 Should use compound assignment operator | |
| JAVA0085 | 0.00 | JAVA0085 Use of sun.* class | |
| JAVA0087 | 0.00 | JAVA0087 Use of Thread.sleep() | |
| JAVA0089 | 0.00 | JAVA0089 Use of restricted package | |
| JAVA0092 | 0.00 | JAVA0092 Use of restricted type | |
| JAVA0093 | 0.00 | JAVA0093 Redundant assignment | |
| JAVA0094 | 0.00 | JAVA0094 Field hides a superclass field | |
| JAVA0095 | 0.00 | JAVA0095 Uninitialized private field | |
| JAVA0096 | 0.00 | JAVA0096 Field in nested class hides outer field | |
| JAVA0098 | 0.00 | JAVA0098 Minimize use of implicit field initializers | |
| JAVA0100 | 1.00 | JAVA0100 Class contains N non-final fields (maximum: M) | |
| JAVA0101 | 0.00 | JAVA0101 Unnecessary modifier for field in interface | |
| JAVA0102 | 0.00 | JAVA0102 Last statement in finalize() not super.finalize() | |
| JAVA0103 | 0.00 | JAVA0103 Explicit call to finalize() | |
| JAVA0104 | 0.00 | JAVA0104 finalize() only calls super.finalize() | |
| JAVA0105 | 0.00 | JAVA0105 Duplicate import declaration | |
| JAVA0106 | 0.00 | JAVA0106 Unnecessary import from current package | |
| JAVA0108 | 1.00 | JAVA0108 Incorrect javadoc: no @param tag for 'parameter' | |
| JAVA0109 | 0.00 | JAVA0109 Incorrect javadoc: no parameter 'parameter' | |
| JAVA0110 | 0.00 | JAVA0110 Incorrect javadoc: no @return tag | |
| JAVA0111 | 0.00 | JAVA0111 Incorrect javadoc: @return tag for void method | |
| JAVA0112 | 0.00 | JAVA0112 Incorrect javadoc: no exception 'exception' in throws | |
| JAVA0113 | 0.00 | JAVA0113 Incorrect javadoc: no @author tag | |
| JAVA0114 | 1.00 | JAVA0114 Incorrect javadoc: no @version tag | |
| JAVA0115 | 0.00 | JAVA0115 Incorrect javadoc: no @throws or @exception tag for 'exception' | |
| JAVA0116 | 0.00 | JAVA0116 Missing javadoc: field 'field' | |
| JAVA0117 | 2.00 | JAVA0117 Missing javadoc: method 'method' | |
| JAVA0118 | 1.00 | JAVA0118 Missing javadoc: type 'type' | |
| JAVA0119 | 0.00 | JAVA0119 Control variable changed within body of for loop | |
| JAVA0123 | 0.00 | JAVA0123 Use all three components of for loop | |
| JAVA0125 | 0.00 | JAVA0125 Continue statement with label | |
| JAVA0126 | 0.00 | JAVA0126 Method declares unchecked exception in throws | |
| JAVA0128 | 0.00 | JAVA0128 Public constructor in non-public class | |
| JAVA0130 | 0.00 | JAVA0130 Non-static method does not use instance fields | |
| JAVA0131 | 0.00 | JAVA0131 Compatible method does not override base | |
| JAVA0132 | 0.00 | JAVA0132 Method overload with compatible signature | |
| JAVA0133 | 0.00 | JAVA0133 Non-synchronized method overrides synchronized method | |
| JAVA0135 | 0.00 | JAVA0135 Only one of Object.equals and Object.hashCode defined: missing 'method' | |
| JAVA0136 | 0.00 | JAVA0136 N methods defined in class (maximum: M) | |
| JAVA0137 | 0.00 | JAVA0137 Non-abstract class missing constructor | |
| JAVA0138 | 0.00 | JAVA0138 N parameters defined for method (maximum: M) | |
| JAVA0139 | 0.00 | JAVA0139 Definition of main other than public static void main(java.lang.String[]) | |
| JAVA0141 | 0.00 | JAVA0141 Unnecessary modifier for method in interface | |
| JAVA0143 | 1.00 | JAVA0143 Synchronized method | |
| JAVA0144 | 4.00 | JAVA0144 Line exceeds maximum M characters | |
| JAVA0145 | 446.00 | JAVA0145 Tab character used in source file | |
| JAVA0150 | 0.00 | JAVA0150 java.lang.Error (or subclass) thrown | |
| JAVA0153 | 0.00 | JAVA0153 Inefficient conversion of integer to string | |
| JAVA0159 | 0.00 | JAVA0159 Inefficient conversion of string to integer | |
| JAVA0160 | 0.00 | JAVA0160 Method does not throw specified exception | |
| JAVA0161 | 1.00 | JAVA0161 Conditional wait() not in loop | |
| JAVA0163 | 0.00 | JAVA0163 Empty statement | |
| JAVA0165 | 0.00 | JAVA0165 Conflicting return statement in finally block | |
| JAVA0166 | 2.00 | JAVA0166 Generic exception caught | |
| JAVA0167 | 0.00 | JAVA0167 ThreadDeath not rethrown | |
| JAVA0169 | 0.00 | JAVA0169 Unnecessary catch block: exception 'exception' | |
| JAVA0170 | 3.00 | JAVA0170 Caught exception not derived from java.lang.Exception | |
| JAVA0171 | 0.00 | JAVA0171 Unused local variable | |
| JAVA0173 | 0.00 | JAVA0173 Unused method parameter | |
| JAVA0174 | 0.00 | JAVA0174 Assigned local variable never used | |
| JAVA0175 | 0.00 | JAVA0175 Successive assignment to variable | |
| JAVA0176 | 0.00 | JAVA0176 Local variable name does not have required form | |
| JAVA0177 | 3.00 | JAVA0177 Variable declaration missing initializer | |
| JAVA0179 | 0.00 | JAVA0179 Local variable hides visible field | |
| JAVA0233 | 0.00 | JAVA0233 Definition of serialVersionUID other than 'private static final long serialVersionUID' | |
| JAVA0234 | 0.00 | JAVA0234 Class is Serializable but does not define serialVersionUID | |
| JAVA0235 | 0.00 | JAVA0235 Class defines serialVersionUID but does not implement Serializable | |
| JAVA0236 | 0.00 | JAVA0236 Attempt to clone an object which does not implement Cloneable | |
| JAVA0237 | 0.00 | JAVA0237 Class implements Cloneable but does not have public clone method | |
| JAVA0238 | 0.00 | JAVA0238 Clone method does not call super.clone() | |
| JAVA0239 | 0.00 | JAVA0239 Class declares 'readObject' or 'writeObject' but does not implement Serializable | |
| JAVA0240 | 0.00 | JAVA0240 Serializable class which declares readObject or writeObject but not both | |
| JAVA0241 | 0.00 | JAVA0241 'readObject' or 'writeObject' should be declared private in Serializable class | |
| JAVA0242 | 0.00 | JAVA0242 Transient field in non-Serializable class | |
| JAVA0243 | 0.00 | JAVA0243 'readResolve' or 'writeReplace' should be declared private or protected | |
| JAVA0244 | 0.00 | JAVA0244 Field or method name in subclass differs only by case from inherited field or method | |
| JAVA0245 | 0.00 | JAVA0245 JUnit TestCase with non-trivial constructor | |
| JAVA0246 | 0.00 | JAVA0246 JUnit assertXXX statement missing message parameter | |
| JAVA0247 | 0.00 | JAVA0247 JUnit 'setUp()' and 'tearDown()' should call super method | |
| JAVA0248 | 0.00 | JAVA0248 JUnit method 'setUp' or 'tearDown' with incorrect signature | |
| JAVA0249 | 0.00 | JAVA0249 JUnit TestCase 'suite()' should be declared static | |
| JAVA0250 | 0.00 | JAVA0250 JUnit TestCase declares testXXX method with incorrect signature | |
| JAVA0251 | 0.00 | JAVA0251 Use '%n' for line breaks in printf/format for platform independence | |
| JAVA0252 | 0.00 | JAVA0252 'enum' is a Java 1.5 reserved word | |
| JAVA0253 | 0.00 | JAVA0253 Not all enum constants consumed in switch statement | |
| JAVA0254 | 0.00 | JAVA0254 Use enhanced for loop construct instead of Iterator | |
| JAVA0255 | 0.00 | JAVA0255 Result of method invocation not used | |
| JAVA0256 | 0.00 | JAVA0256 Assignment of external collection/array to field | |
| JAVA0257 | 0.00 | JAVA0257 Use of 'Constant Interface' anti-pattern | |
| JAVA0258 | 0.00 | JAVA0258 Implement Iterable for foreach compatibility | |
| JAVA0259 | 0.00 | JAVA0259 Return of collection/array field | |
| JAVA0260 | 0.00 | JAVA0260 Use 'enum' instead of Enumerated Type pattern | |
| JAVA0261 | 0.00 | JAVA0261 Use specialized Enum collection types | |
| JAVA0262 | 0.00 | JAVA0262 Use of char in integer context | |
| JAVA0263 | 0.00 | JAVA0263 Long literal ends with 'l' instead of 'L' | |
| JAVA0264 | 3.00 | JAVA0264 Integer math in long context - check for overflow | |
| JAVA0265 | 0.00 | JAVA0265 Use of Throwable.printStackTrace() | |
| JAVA0266 | 0.00 | JAVA0266 Use of System.out | |
| JAVA0267 | 0.00 | JAVA0267 Use of System.err | |
| JAVA0269 | 0.00 | JAVA0269 Contents of StringBuffer never used | |
| JAVA0270 | 0.00 | JAVA0270 Use Java 5.0 enhanced for loop construct to iterate over all elements in an array | |
| JAVA0271 | 0.00 | JAVA0271 Minimize use of on-demand (.*) static imports | |
| JAVA0272 | 0.00 | JAVA0272 Thread.run() called | |
| JAVA0273 | 0.00 | JAVA0273 Non-final derivative of Thread calls start() in constructor | |
| JAVA0274 | 0.00 | JAVA0274 Serializable class has a synchronized readObject() | |
| JAVA0275 | 0.00 | JAVA0275 Serializable class has a synchronized writeObject() and no other synchronized methods | |
| JAVA0276 | 0.00 | JAVA0276 Unnecessary use of String constructor | |
| JAVA0277 | 0.00 | JAVA0277 Iterator.next() implementation does not throw NoSuchElementException | |
| JAVA0278 | 0.00 | JAVA0278 Unnecessary use of Boolean constructor | |
| JAVA0279 | 0.00 | JAVA0279 Serialization method readObject or readObjectNoData calls an overridable method | |
| JAVA0280 | 0.00 | JAVA0280 IllegalMonitorStateException caught | |
| JAVA0281 | 0.00 | JAVA0281 Iterator.next() not called in loop | |
| JAVA0282 | 0.00 | JAVA0282 Call to Iterator.next() in loop which does not test Iterator.hasNext() | |
| JAVA0283 | 0.00 | JAVA0283 Control variable not updated in loop body | |
| JAVA0284 | 0.00 | JAVA0284 Explicit garbage collection | |
| JAVA0285 | 0.00 | JAVA0285 Dereference of potentially null variable | |
| JAVA0286 | 0.00 | JAVA0286 Dereference of null variable | |
| JAVA0287 | 0.00 | JAVA0287 Unnecessary null check | |
| JAVA0288 | 0.00 | JAVA0288 Inconsistent null check | |
| LINES | 491.00 | Number of lines in the source file | |
| LINE_COMMENT | 49.00 | Number of line comments | |
| LOC | 366.00 | Lines of code | |
| LOGICAL_LINES | 203.00 | Number of statements | |
| LOOPS | 3.00 | Number of loops | |
| NEST_DEPTH | 5.00 | Maximum nesting depth | |
| OPERANDS | 812.00 | Number of operands | |
| OPERATORS | 1715.00 | Number of operators | |
| PARAMS | 9.00 | Number of formal parameter declarations | |
| PROGRAM_LENGTH | 2527.00 | Halstead program length | |
| PROGRAM_VOCAB | 312.00 | Halstead program vocabulary | |
| PROGRAM_VOLUME | 0.00 | Halstead program volume | |
| RETURNS | 35.00 | Number of return points from functions | |
| SIZE | 17902.00 | Size of the file in bytes | |
| UNIQUE_OPERANDS | 261.00 | Number of unique operands | |
| UNIQUE_OPERATORS | 51.00 | Number of unique operators | |
| WHITESPACE | 59.00 | Number of whitespace lines | |