HTTPRequestImpl.java
| Index Score | ||
|---|---|---|
 |
 |
freenet.clients.http |
 |
 |
Freenet |
View: Reasons, Metrics, Source Code
These are the metrics that contribute to the Enerjy Score for this file, ranked by impact. So the metrics listed at the top influence the score to a greater extent that the metrics listed at the bottom.
| Metric | Description | |
|---|---|---|
| JAVA0034 | JAVA0034 Missing braces in if statement |  |
| DECL_COMMENTS | Comments in declarations | |
| CYCLOMATIC | Cyclomatic complexity | |
| EXEC_COMMENTS | Comments in executable code | |
| RETURNS | Number of return points from functions | |
| JAVA0150 | JAVA0150 java.lang.Error (or subclass) thrown | |
| LOGICAL_LINES | Number of statements | |
| OPERATORS | Number of operators | |
| EXITS | Procedure exits | |
| INTERFACE_COMPLEXITY | Interface complexity | |
| PROGRAM_LENGTH | Halstead program length | |
| LOOPS | Number of loops | |
| COMPARISONS | Number of comparison operators | |
| LINE_COMMENT | Number of line comments | |
| JAVA0076 | JAVA0076 Use of magic number | |
| OPERANDS | Number of operands | |
| SIZE | Size of the file in bytes | |
| ELOC | Effective lines of code | |
| UNIQUE_OPERANDS | Number of unique operands | |
| PROGRAM_VOCAB | Halstead program vocabulary | |
| LINES | Number of lines in the source file | |
| BLOCKS | Number of blocks | |
| LOC | Lines of code | |
| COMMENTS | Comment lines | |
| JAVA0270 | JAVA0270 Use Java 5.0 enhanced for loop construct to iterate over all elements in an array | |
| PARAMS | Number of formal parameter declarations | |
| JAVA0145 | JAVA0145 Tab character used in source file | |
| UNIQUE_OPERATORS | Number of unique operators | |
| JAVA0117 | JAVA0117 Missing javadoc: method 'method' | |
| JAVA0177 | JAVA0177 Variable declaration missing initializer | |
| NEST_DEPTH | Maximum nesting depth | |
| PROGRAM_VOLUME | Halstead program volume | |
| FUNCTIONS | Number of function declarations | |
| JAVA0136 | JAVA0136 N methods defined in class (maximum: M) | |
| JAVA0126 | JAVA0126 Method declares unchecked exception in throws | |
| JAVA0110 | JAVA0110 Incorrect javadoc: no @return tag | |
| JAVA0254 | JAVA0254 Use enhanced for loop construct instead of Iterator | |
| DOC_COMMENT | Number of javadoc comment lines | |
| BLOCK_COMMENT | Number of block comment lines | |
/* This code is part of Freenet. It is distributed under the GNU General
* Public License, version 2 (or at your option any later version). See
* http://www.gnu.org/ for further details of the GPL. */
package freenet.clients.http;
import freenet.support.Fields;
import java.io.BufferedInputStream;
import java.io.BufferedOutputStream;
import java.io.DataInputStream;
import java.io.IOException;
import java.io.InputStream;
import java.io.OutputStream;
import java.io.UnsupportedEncodingException;
import java.net.URI;
import java.net.URISyntaxException;
import java.net.URLDecoder;
import java.util.ArrayList;
import java.util.HashMap;
import java.util.Iterator;
import java.util.LinkedList;
import java.util.List;
import java.util.Map;
import java.util.StringTokenizer;
import freenet.support.Logger;
import freenet.support.MultiValueTable;
import freenet.support.SimpleReadOnlyArrayBucket;
import freenet.support.api.Bucket;
import freenet.support.api.BucketFactory;
import freenet.support.api.HTTPRequest;
import freenet.support.api.HTTPUploadedFile;
import freenet.support.io.BucketTools;
import freenet.support.io.Closer;
import freenet.support.io.LineReadingInputStream;
/**
* Used for passing all HTTP request information to the FredPlugin that handles
* the request. It parses the query string and has several methods for acessing
* the request parameter values.
*
* @author nacktschneck
*/
public class HTTPRequestImpl implements HTTPRequest {
/**
* This map is used to store all parameter values. The name (as String) of
* the parameter is used as key, the returned value is a list (of Strings)
* with all values for that parameter sent in the request. You shouldn't
* access this map directly, use {@link #getParameterValueList(String)} and
* {@link #isParameterSet(String)} insted
*/
private final Map parameterNameValuesMap = new HashMap();
/**
* the original URI as given to the constructor
*/
private URI uri;
/**
* The headers sent by the client
*/
private MultiValueTable headers;
/**
* The data sent in the connection
*/
private Bucket data;
/**
* A hasmap of buckets that we use to store all the parts for a multipart/form-data request
*/
private HashMap parts;
/** A map for uploaded files. */
private Map uploadedFiles = new HashMap();
private final BucketFactory bucketfactory;
/**
* Create a new HTTPRequest for the given URI and parse its request
* parameters.
*
* @param uri
* the URI being requested
*/
public HTTPRequestImpl(URI uri) {
this.uri = uri;
this.parseRequestParameters(uri.getRawQuery(), true, false);
this.data = null;
this.parts = null;
this.bucketfactory = null;
}
/**
* Creates a new HTTPRequest for the given path and url-encoded query string
*
* @param path i.e. /test/test.html
* @param encodedQueryString a=some+text&b=abc%40def.de
* @throws URISyntaxException if the URI is invalid
*/
public HTTPRequestImpl(String path, String encodedQueryString) throws URISyntaxException {
this.data = null;
this.parts = null;
this.bucketfactory = null;
if ((encodedQueryString!=null) && (encodedQueryString.length()>0)) {
this.uri = new URI(path+ '?' +encodedQueryString);
} else {
this.uri = new URI(path);
}
this.parseRequestParameters(uri.getRawQuery(), true, false);
}
/**
* Creates a new HTTPRequest for the given URI and data.
*
* @param uri The URI being requested
* @param h Client headers
* @param d The data
* @param ctx The toadlet context (for headers and bucket factory)
* @throws URISyntaxException if the URI is invalid
*/
public HTTPRequestImpl(URI uri, Bucket d, ToadletContext ctx) {
this.uri = uri;
this.headers = ctx.getHeaders();
this.parseRequestParameters(uri.getRawQuery(), true, false);
this.data = d;
this.parts = new HashMap();
this.bucketfactory = ctx.getBucketFactory();
if(data != null) {
try {
this.parseMultiPartData();
} catch (IOException ioe) {
Logger.error(this, "Temporary files error ? Could not parse: "+ioe, ioe);
}
}
}
/* (non-Javadoc)
* @see freenet.clients.http.HTTPRequest#getPath()
*/
public String getPath() {
return this.uri.getPath();
}
/* (non-Javadoc)
* @see freenet.clients.http.HTTPRequest#hasParameters()
*/
public boolean hasParameters() {
return ! this.parameterNameValuesMap.isEmpty();
}
/**
* Parse the query string and populate {@link #parameterNameValuesMap} with
* the lists of values for each parameter. If this method is not called at
* all, all other methods would be useless. Because they rely on the
* parameter map to be filled.
*
* @param queryString
* the query string in its raw form (not yet url-decoded)
* @param doUrlDecoding TODO
*/
private void parseRequestParameters(String queryString, boolean doUrlDecoding, boolean asParts) {
boolean logMINOR = Logger.shouldLog(Logger.MINOR, this);
if(logMINOR) Logger.minor(this, "queryString is "+queryString+", doUrlDecoding="+doUrlDecoding);
// nothing to do if there was no query string in the URI
if ((queryString == null) || (queryString.length() == 0)) {
return;
}
// iterate over all tokens in the query string (seperated by &)
StringTokenizer tokenizer = new StringTokenizer(queryString, "&");
while (tokenizer.hasMoreTokens()) {
String nameValueToken = tokenizer.nextToken();
if(logMINOR) Logger.minor(this, "Token: "+nameValueToken);
// a token can be either a name, or a name value pair...
String name = null;
String value = "";
int indexOfEqualsChar = nameValueToken.indexOf('=');
if (indexOfEqualsChar < 0) {
// ...it's only a name, so the value stays emptys
name = nameValueToken;
if(logMINOR) Logger.minor(this, "Name: "+name);
} else if (indexOfEqualsChar == nameValueToken.length() - 1) {
// ...it's a name with an empty value, so remove the '='
// character
name = nameValueToken.substring(0, indexOfEqualsChar);
if(logMINOR) Logger.minor(this, "Name: "+name);
} else {
// ...it's a name value pair, split into name and value
name = nameValueToken.substring(0, indexOfEqualsChar);
value = nameValueToken.substring(indexOfEqualsChar + 1);
if(logMINOR) Logger.minor(this, "Name: "+name+" Value: "+value);
}
// url-decode the name and value
if (doUrlDecoding) {
try {
name = URLDecoder.decode(name, "UTF-8");
value = URLDecoder.decode(value, "UTF-8");
} catch (UnsupportedEncodingException e) {
throw new Error("Impossible: JVM doesn't support UTF-8: " + e, e);
}
if(logMINOR) {
Logger.minor(this, "Decoded name: "+name);
Logger.minor(this, "Decoded value: "+value);
}
}
if(asParts) {
// Store as a part
byte[] buf;
try {
buf = value.getBytes("UTF-8");
} catch (UnsupportedEncodingException e) {
throw new Error("Impossible: JVM doesn't support UTF-8: " + e, e);
} // FIXME some other encoding?
Bucket b = new SimpleReadOnlyArrayBucket(buf);
parts.put(name, b);
if(logMINOR)
Logger.minor(this, "Added as part: name="+name+" value="+value);
} else {
// get the list of values for this parameter that were parsed so far
List valueList = this.getParameterValueList(name);
// add this value to the list
valueList.add(value);
}
}
}
/**
* Get the first value of the parameter with the given name.
*
* @param name
* the name of the parameter to get
* @return the first value or <code>null</code> if the parameter was not
* set
*/
private String getParameterValue(String name) {
if (!this.isParameterSet(name)) {
return null;
}
List allValues = this.getParameterValueList(name);
return (String) allValues.get(0);
}
/**
* Get the list of all values for the parameter with the given name. When
* this method is called for a given parameter for the first time, a new
* empty list of values is created and stored in
* {@link #parameterNameValuesMap}. This list is returned and should be
* used to add parameter values. If you only want to check if a parameter is
* set at all, you must use {@link #isParameterSet(String)}.
*
* @param name
* the name of the parameter to get
* @return the list of all values for this parameter that were parsed so
* far.
*/
private List getParameterValueList(String name) {
List values = (List) this.parameterNameValuesMap.get(name);
if (values == null) {
values = new LinkedList();
this.parameterNameValuesMap.put(name, values);
}
return values;
}
/* (non-Javadoc)
* @see freenet.clients.http.HTTPRequest#isParameterSet(java.lang.String)
*/
public boolean isParameterSet(String name) {
return this.parameterNameValuesMap.containsKey(name);
}
/* (non-Javadoc)
* @see freenet.clients.http.HTTPRequest#getParam(java.lang.String)
*/
public String getParam(String name) {
return this.getParam(name, "");
}
/* (non-Javadoc)
* @see freenet.clients.http.HTTPRequest#getParam(java.lang.String, java.lang.String)
*/
public String getParam(String name, String defaultValue) {
String value = this.getParameterValue(name);
if (value == null) {
return defaultValue;
}
return value;
}
/* (non-Javadoc)
* @see freenet.clients.http.HTTPRequest#getIntParam(java.lang.String)
*/
public int getIntParam(String name) {
return this.getIntParam(name, 0);
}
/* (non-Javadoc)
* @see freenet.clients.http.HTTPRequest#getIntParam(java.lang.String, int)
*/
public int getIntParam(String name, int defaultValue) {
if (!this.isParameterSet(name)) {
return defaultValue;
}
String value = this.getParameterValue(name);
try {
return Integer.parseInt(value);
} catch (NumberFormatException e) {
return defaultValue;
}
}
/* (non-Javadoc)
* @see freenet.clients.http.HTTPRequest#getIntPart(java.lang.String, int)
*/
public int getIntPart(String name, int defaultValue) {
if (!this.isPartSet(name)) {
return defaultValue;
}
String value = this.getPartAsString(name, 32);
try {
return Integer.parseInt(value);
} catch (NumberFormatException e) {
return defaultValue;
}
}
// TODO: add similar methods for long, boolean etc.
/* (non-Javadoc)
* @see freenet.clients.http.HTTPRequest#getMultipleParam(java.lang.String)
*/
public String[] getMultipleParam(String name) {
List valueList = this.getParameterValueList(name);
String[] values = new String[valueList.size()];
valueList.toArray(values);
return values;
}
/* (non-Javadoc)
* @see freenet.clients.http.HTTPRequest#getMultipleIntParam(java.lang.String)
*/
public int[] getMultipleIntParam(String name) {
List valueList = this.getParameterValueList(name);
// try parsing all values and put the valid Integers in a new list
List intValueList = new ArrayList();
for (int i = 0; i < valueList.size(); i++) {
try {
intValueList.add(new Integer((String) valueList.get(i)));
} catch (Exception e) {
// ignore invalid parameter values
}
}
// convert the valid Integers to an array of ints
int[] values = new int[intValueList.size()];
for (int i = 0; i < intValueList.size(); i++) {
values[i] = ((Integer) intValueList.get(i)).intValue();
}
return values;
}
// TODO: add similar methods for multiple long, boolean etc.
/**
* Parse submitted data from a bucket.
* Note that if this is application/x-www-form-urlencoded, it will come out as
* params, whereas if it is multipart/form-data it will be separated into buckets.
*/
private void parseMultiPartData() throws IOException {
InputStream is = null;
BufferedInputStream bis = null;
LineReadingInputStream lis = null;
OutputStream bucketos = null;
OutputStream bbos = null;
try {
boolean logMINOR = Logger.shouldLog(Logger.MINOR, this);
if(data == null)
return;
String ctype = (String) this.headers.get("content-type");
if(ctype == null)
return;
if(logMINOR)
Logger.minor(this, "Uploaded content-type: " + ctype);
String[] ctypeparts = ctype.split(";");
if(ctypeparts[0].equalsIgnoreCase("application/x-www-form-urlencoded")) {
// Completely different encoding, but easy to handle
if(data.size() > 1024 * 1024)
throw new IOException("Too big");
byte[] buf = BucketTools.toByteArray(data);
String s = new String(buf, "us-ascii");
parseRequestParameters(s, true, true);
}
if(!ctypeparts[0].trim().equalsIgnoreCase("multipart/form-data") || (ctypeparts.length < 2))
return;
String boundary = null;
for(int i = 0; i < ctypeparts.length; i++) {
String[] subparts = ctypeparts[i].split("=");
if((subparts.length == 2) && subparts[0].trim().equalsIgnoreCase("boundary"))
boundary = subparts[1];
}
if((boundary == null) || (boundary.length() == 0))
return;
if(boundary.charAt(0) == '"')
boundary = boundary.substring(1);
if(boundary.charAt(boundary.length() - 1) == '"')
boundary = boundary.substring(0, boundary.length() - 1);
boundary = "--" + boundary;
if(logMINOR)
Logger.minor(this, "Boundary is: " + boundary);
is = this.data.getInputStream();
bis = new BufferedInputStream(is, 32768);
lis = new LineReadingInputStream(bis);
String line;
line = lis.readLine(100, 100, false); // really it's US-ASCII, but ISO-8859-1 is close enough.
while((bis.available() > 0) && !line.equals(boundary)) {
line = lis.readLine(100, 100, false);
}
boundary = "\r\n" + boundary;
Bucket filedata = null;
String name = null;
String filename = null;
String contentType = null;
while(bis.available() > 0) {
name = null;
filename = null;
contentType = null;
// chomp headers
while((line = lis.readLine(200, 200, true)) /* should be UTF-8 as we told the browser to send UTF-8 */ != null) {
if(line.length() == 0)
break;
String[] lineparts = line.split(":");
if(lineparts == null || lineparts.length == 0)
continue;
String hdrname = lineparts[0].trim();
if(hdrname.equalsIgnoreCase("Content-Disposition")) {
if(lineparts.length < 2)
continue;
String[] valueparts = lineparts[1].split(";");
for(int i = 0; i < valueparts.length; i++) {
String[] subparts = valueparts[i].split("=");
if(subparts.length != 2)
continue;
String fieldname = subparts[0].trim();
String value = subparts[1].trim();
if(value.startsWith("\"") && value.endsWith("\""))
value = value.substring(1, value.length() - 1);
if(fieldname.equalsIgnoreCase("name"))
name = value;
else if(fieldname.equalsIgnoreCase("filename"))
filename = value;
}
}
else if(hdrname.equalsIgnoreCase("Content-Type")) {
contentType = lineparts[1].trim();
if(Logger.shouldLog(Logger.MINOR, this))
Logger.minor(this, "Parsed type: " + contentType);
}
else {
// Do nothing, irrelevant header
}
}
if(name == null)
continue;
// we should be at the data now. Start reading it in, checking for the
// boundary string
// we can only give an upper bound for the size of the bucket
filedata = this.bucketfactory.makeBucket(bis.available());
bucketos = filedata.getOutputStream();
bbos = new BufferedOutputStream(bucketos, 32768);
// buffer characters that match the boundary so far
// FIXME use whatever charset was used
byte[] bbound = boundary.getBytes("UTF-8"); // ISO-8859-1? boundary should be in US-ASCII
int offset = 0;
while((bis.available() > 0) && (offset < bbound.length)) {
byte b = (byte) bis.read();
if(b == bbound[offset])
offset++;
else if((b != bbound[offset]) && (offset > 0)) {
// offset bytes matched, but no more
// write the bytes that matched, then the non-matching byte
bbos.write(bbound, 0, offset);
offset = 0;
if(b == bbound[0])
offset = 1;
else
bbos.write((int) b & 0xff);
}
else
bbos.write((int) b & 0xff);
}
bbos.flush();
bbos.close();
parts.put(name, filedata);
if(logMINOR)
Logger.minor(this, "Name = " + name + " length = " + filedata.size() + " filename = " + filename);
if(filename != null)
uploadedFiles.put(name, new HTTPUploadedFileImpl(filename, contentType, filedata));
}
}
finally {
Closer.close(bbos);
Closer.close(bucketos);
Closer.close(lis);
Closer.close(bis);
Closer.close(is);
}
}
/* (non-Javadoc)
* @see freenet.clients.http.HTTPRequest#getUploadedFile(java.lang.String)
*/
public HTTPUploadedFile getUploadedFile(String name) {
return (HTTPUploadedFile) uploadedFiles.get(name);
}
/* (non-Javadoc)
* @see freenet.clients.http.HTTPRequest#getPart(java.lang.String)
*/
public Bucket getPart(String name) {
return (Bucket)this.parts.get(name);
}
/* (non-Javadoc)
* @see freenet.clients.http.HTTPRequest#isPartSet(java.lang.String)
*/
public boolean isPartSet(String name) {
if(parts == null)
return false;
return this.parts.containsKey(name);
}
public String getPartAsString(String name, int maxlength) {
try {
return new String(getPartAsBytes(name, maxlength), "UTF-8");
} catch (UnsupportedEncodingException e) {
throw new Error("Impossible: JVM doesn't support UTF-8: " + e, e);
}
}
/* (non-Javadoc)
* @see freenet.clients.http.HTTPRequest#getPartAsString(java.lang.String, int)
*/
public byte[] getPartAsBytes(String name, int maxlength) {
Bucket part = (Bucket)this.parts.get(name);
if(part == null) return new byte[0];
if (part.size() > maxlength) return new byte[0];
InputStream is = null;
DataInputStream dis = null;
try {
is = part.getInputStream();
dis = new DataInputStream(is);
byte[] buf = new byte[is.available()];
dis.readFully(buf);
return buf;
} catch (IOException ioe) {
Logger.error(this, "Caught IOE:" + ioe.getMessage());
} finally {
Closer.close(dis);
Closer.close(is);
}
return new byte[0];
}
/* (non-Javadoc)
* @see freenet.clients.http.HTTPRequest#freeParts()
*/
public void freeParts() {
if (this.parts == null) return;
Iterator i = this.parts.keySet().iterator();
while (i.hasNext()) {
String key = (String) i.next();
Bucket b = (Bucket)this.parts.get(key);
b.free();
}
parts.clear();
}
/* (non-Javadoc)
* @see freenet.clients.http.HTTPRequest#getLongParam(java.lang.String, long)
*/
public long getLongParam(String name, long defaultValue) {
if (!this.isParameterSet(name)) {
return defaultValue;
}
String value = this.getParameterValue(name);
try {
return Fields.parseLong(value);
} catch (NumberFormatException e) {
return defaultValue;
}
}
/**
* Container for uploaded files in HTTP POST requests.
*
* @author David 'Bombe' Roden <bombe@freenetproject.org>
* @version $Id$
*/
public static class HTTPUploadedFileImpl implements HTTPUploadedFile {
/** The filename. */
private final String filename;
/** The content type. */
private final String contentType;
/** The data. */
private final Bucket data;
/**
* Creates a new file with the specified filename, content type, and
* data.
*
* @param filename
* The name of the file
* @param contentType
* The content type of the file
* @param data
* The data of the file
*/
public HTTPUploadedFileImpl(String filename, String contentType, Bucket data) {
this.filename = filename;
this.contentType = contentType;
this.data = data;
}
/* (non-Javadoc)
* @see freenet.clients.http.HTTPUploadedFile#getContentType()
*/
public String getContentType() {
return contentType;
}
/* (non-Javadoc)
* @see freenet.clients.http.HTTPUploadedFile#getData()
*/
public Bucket getData() {
return data;
}
/* (non-Javadoc)
* @see freenet.clients.http.HTTPUploadedFile#getFilename()
*/
public String getFilename() {
return filename;
}
}
}
The table below shows all metrics for HTTPRequestImpl.java.
| Metric | Value | Description | |
|---|---|---|---|
| BLOCKS | 81.00 | Number of blocks | |
| BLOCK_COMMENT | 60.00 | Number of block comment lines | |
| COMMENTS | 192.00 | Comment lines | |
| COMMENT_DENSITY | 0.56 | Comment density | |
| COMPARISONS | 65.00 | Number of comparison operators | |
| CYCLOMATIC | 108.00 | Cyclomatic complexity | |
| DECL_COMMENTS | 41.00 | Comments in declarations | |
| DOC_COMMENT | 106.00 | Number of javadoc comment lines | |
| ELOC | 343.00 | Effective lines of code | |
| EXEC_COMMENTS | 20.00 | Comments in executable code | |
| EXITS | 70.00 | Procedure exits | |
| FUNCTIONS | 28.00 | Number of function declarations | |
| HALSTEAD_DIFFICULTY | 87.95 | Halstead difficulty | |
| HALSTEAD_EFFORT | 0.00 | Halstead effort | |
| INTERFACE_COMPLEXITY | 102.00 | Interface complexity | |
| JAVA0001 | 0.00 | JAVA0001 Package name does not contain only lower case letters | |
| JAVA0002 | 1.00 | JAVA0002 Package name does not begin with a top level domain name or country code | |
| JAVA0003 | 0.00 | JAVA0003 Minimize use of on-demand (.*) imports | |
| JAVA0004 | 0.00 | JAVA0004 Unnecessary import from java.lang | |
| JAVA0005 | 1.00 | JAVA0005 Imports not in specified order | |
| JAVA0006 | 0.00 | JAVA0006 Empty finally block | |
| JAVA0007 | 0.00 | JAVA0007 Should not declare public field | |
| JAVA0008 | 0.00 | JAVA0008 Empty catch block | |
| JAVA0009 | 0.00 | JAVA0009 Protected member in final class | |
| JAVA0010 | 0.00 | JAVA0010 Non-instantiable class does not contain a non-private static member | |
| JAVA0011 | 0.00 | JAVA0011 Abstract class does not contain an abstract method | |
| JAVA0012 | 0.00 | JAVA0012 Non-constructor method with same name as declaring class | |
| JAVA0013 | 0.00 | JAVA0013 Non-blank final field is not static | |
| JAVA0014 | 0.00 | JAVA0014 Class with only static members has non-private constructor | |
| JAVA0015 | 0.00 | JAVA0015 Package class contains public nested type | |
| JAVA0016 | 0.00 | JAVA0016 Abstract class contains public constructor | |
| JAVA0017 | 0.00 | JAVA0017 Class name does not have required form | |
| JAVA0018 | 0.00 | JAVA0018 Method name does not have required form | |
| JAVA0019 | 0.00 | JAVA0019 Interface name does not have required form | |
| JAVA0020 | 0.00 | JAVA0020 Field name does not have required form | |
| JAVA0021 | 0.00 | JAVA0021 Interface method name does not have required form | |
| JAVA0022 | 0.00 | JAVA0022 Static final field name does not have required form | |
| JAVA0023 | 0.00 | JAVA0023 Empty finalize method | |
| JAVA0024 | 0.00 | JAVA0024 Empty class | |
| JAVA0025 | 0.00 | JAVA0025 Method override is empty | |
| JAVA0026 | 0.00 | JAVA0026 Finalize method with parameters | |
| JAVA0029 | 0.00 | JAVA0029 Private method not used | |
| JAVA0030 | 0.00 | JAVA0030 Private field not used | |
| JAVA0031 | 0.00 | JAVA0031 Case statement not properly closed | |
| JAVA0032 | 0.00 | JAVA0032 Switch statement missing default | |
| JAVA0033 | 0.00 | JAVA0033 default: not last case in switch statement | |
| JAVA0034 | 35.00 | JAVA0034 Missing braces in if statement | |
| JAVA0035 | 0.00 | JAVA0035 Missing braces in for statement | |
| JAVA0036 | 0.00 | JAVA0036 Missing braces in while statement | |
| JAVA0038 | 0.00 | JAVA0038 Non-case label in switch statement | |
| JAVA0039 | 0.00 | JAVA0039 Break statement with label | |
| JAVA0040 | 0.00 | JAVA0040 Switch statement contains N cases (maximum: M) | |
| JAVA0041 | 0.00 | JAVA0041 Nested synchronized block | |
| JAVA0042 | 0.00 | JAVA0042 Empty synchronized statement | |
| JAVA0043 | 0.00 | JAVA0043 Inner class does not use outer class | |
| JAVA0044 | 0.00 | JAVA0044 Serializable class with no instance variables | |
| JAVA0045 | 0.00 | JAVA0045 Serializable class with only transient fields | |
| JAVA0046 | 0.00 | JAVA0046 Name of class not derived from Exception ends with 'Exception' | |
| JAVA0047 | 0.00 | JAVA0047 Serializable class derives from invalid base class | |
| JAVA0048 | 0.00 | JAVA0048 Name of class derived from Exception does not end with 'Exception' | |
| JAVA0049 | 1.00 | JAVA0049 Nested block at depth N (maximum: M) | |
| JAVA0050 | 0.00 | JAVA0050 Class derives from java.lang.Error | |
| JAVA0051 | 0.00 | JAVA0051 Class derives from java.lang.RuntimeException | |
| JAVA0052 | 0.00 | JAVA0052 Class derives from java.lang.Throwable | |
| JAVA0053 | 0.00 | JAVA0053 Unused label | |
| JAVA0054 | 0.00 | JAVA0054 Inheritance depth N exceeds maximum M | |
| JAVA0055 | 0.00 | JAVA0055 Class should be interface | |
| JAVA0056 | 0.00 | JAVA0056 Unnecessary abstract modifier for interface or annotation | |
| JAVA0057 | 0.00 | JAVA0057 Unnecessary default constructor | |
| JAVA0058 | 0.00 | JAVA0058 Constructor calls super() | |
| JAVA0059 | 0.00 | JAVA0059 Method override only calls super() | |
| JAVA0061 | 0.00 | JAVA0061 Inaccessible member in anonymous class | |
| JAVA0062 | 0.00 | JAVA0062 Public class missing public member or protected constructor | |
| JAVA0063 | 0.00 | JAVA0063 Identifier name should not contain '$' | |
| JAVA0064 | 0.00 | JAVA0064 N variations of identifier name (maximum: M) | |
| JAVA0065 | 0.00 | JAVA0065 Unnecessary final modifier for method in final class | |
| JAVA0066 | 0.00 | JAVA0066 Unnecessary modifier for interface nested type | |
| JAVA0067 | 0.00 | JAVA0067 Array descriptor on identifier name | |
| JAVA0068 | 0.00 | JAVA0068 Modifiers not declared in recommended order | |
| JAVA0071 | 0.00 | JAVA0071 Strings compared with == | |
| JAVA0073 | 0.00 | JAVA0073 Integer division in floating-point context | |
| JAVA0074 | 0.00 | JAVA0074 Use of Object.notify() | |
| JAVA0075 | 0.00 | JAVA0075 Method parameter hides field | |
| JAVA0076 | 12.00 | JAVA0076 Use of magic number | |
| JAVA0077 | 0.00 | JAVA0077 Private field not used in declaring class | |
| JAVA0078 | 0.00 | JAVA0078 Floating point values compared with == | |
| JAVA0079 | 0.00 | JAVA0079 Use of instance to reference static member | |
| JAVA0080 | 0.00 | JAVA0080 Import declaration not used | |
| JAVA0081 | 0.00 | JAVA0081 Boolean literal in comparison | |
| JAVA0082 | 0.00 | JAVA0082 Unnecessary widening cast | |
| JAVA0083 | 0.00 | JAVA0083 Unnecessary instanceof test | |
| JAVA0084 | 0.00 | JAVA0084 Should use compound assignment operator | |
| JAVA0085 | 0.00 | JAVA0085 Use of sun.* class | |
| JAVA0087 | 0.00 | JAVA0087 Use of Thread.sleep() | |
| JAVA0089 | 0.00 | JAVA0089 Use of restricted package | |
| JAVA0092 | 0.00 | JAVA0092 Use of restricted type | |
| JAVA0093 | 0.00 | JAVA0093 Redundant assignment | |
| JAVA0094 | 0.00 | JAVA0094 Field hides a superclass field | |
| JAVA0095 | 0.00 | JAVA0095 Uninitialized private field | |
| JAVA0096 | 0.00 | JAVA0096 Field in nested class hides outer field | |
| JAVA0098 | 0.00 | JAVA0098 Minimize use of implicit field initializers | |
| JAVA0100 | 0.00 | JAVA0100 Class contains N non-final fields (maximum: M) | |
| JAVA0101 | 0.00 | JAVA0101 Unnecessary modifier for field in interface | |
| JAVA0102 | 0.00 | JAVA0102 Last statement in finalize() not super.finalize() | |
| JAVA0103 | 0.00 | JAVA0103 Explicit call to finalize() | |
| JAVA0104 | 0.00 | JAVA0104 finalize() only calls super.finalize() | |
| JAVA0105 | 0.00 | JAVA0105 Duplicate import declaration | |
| JAVA0106 | 0.00 | JAVA0106 Unnecessary import from current package | |
| JAVA0108 | 1.00 | JAVA0108 Incorrect javadoc: no @param tag for 'parameter' | |
| JAVA0109 | 1.00 | JAVA0109 Incorrect javadoc: no parameter 'parameter' | |
| JAVA0110 | 0.00 | JAVA0110 Incorrect javadoc: no @return tag | |
| JAVA0111 | 0.00 | JAVA0111 Incorrect javadoc: @return tag for void method | |
| JAVA0112 | 1.00 | JAVA0112 Incorrect javadoc: no exception 'exception' in throws | |
| JAVA0113 | 0.00 | JAVA0113 Incorrect javadoc: no @author tag | |
| JAVA0114 | 1.00 | JAVA0114 Incorrect javadoc: no @version tag | |
| JAVA0115 | 1.00 | JAVA0115 Incorrect javadoc: no @throws or @exception tag for 'exception' | |
| JAVA0116 | 0.00 | JAVA0116 Missing javadoc: field 'field' | |
| JAVA0117 | 0.00 | JAVA0117 Missing javadoc: method 'method' | |
| JAVA0118 | 0.00 | JAVA0118 Missing javadoc: type 'type' | |
| JAVA0119 | 0.00 | JAVA0119 Control variable changed within body of for loop | |
| JAVA0123 | 0.00 | JAVA0123 Use all three components of for loop | |
| JAVA0125 | 0.00 | JAVA0125 Continue statement with label | |
| JAVA0126 | 0.00 | JAVA0126 Method declares unchecked exception in throws | |
| JAVA0128 | 0.00 | JAVA0128 Public constructor in non-public class | |
| JAVA0130 | 0.00 | JAVA0130 Non-static method does not use instance fields | |
| JAVA0131 | 0.00 | JAVA0131 Compatible method does not override base | |
| JAVA0132 | 0.00 | JAVA0132 Method overload with compatible signature | |
| JAVA0133 | 0.00 | JAVA0133 Non-synchronized method overrides synchronized method | |
| JAVA0135 | 0.00 | JAVA0135 Only one of Object.equals and Object.hashCode defined: missing 'method' | |
| JAVA0136 | 1.00 | JAVA0136 N methods defined in class (maximum: M) | |
| JAVA0137 | 0.00 | JAVA0137 Non-abstract class missing constructor | |
| JAVA0138 | 0.00 | JAVA0138 N parameters defined for method (maximum: M) | |
| JAVA0139 | 0.00 | JAVA0139 Definition of main other than public static void main(java.lang.String[]) | |
| JAVA0141 | 0.00 | JAVA0141 Unnecessary modifier for method in interface | |
| JAVA0143 | 0.00 | JAVA0143 Synchronized method | |
| JAVA0144 | 0.00 | JAVA0144 Line exceeds maximum M characters | |
| JAVA0145 | 1434.00 | JAVA0145 Tab character used in source file | |
| JAVA0150 | 3.00 | JAVA0150 java.lang.Error (or subclass) thrown | |
| JAVA0153 | 0.00 | JAVA0153 Inefficient conversion of integer to string | |
| JAVA0159 | 0.00 | JAVA0159 Inefficient conversion of string to integer | |
| JAVA0160 | 0.00 | JAVA0160 Method does not throw specified exception | |
| JAVA0161 | 0.00 | JAVA0161 Conditional wait() not in loop | |
| JAVA0163 | 0.00 | JAVA0163 Empty statement | |
| JAVA0165 | 0.00 | JAVA0165 Conflicting return statement in finally block | |
| JAVA0166 | 1.00 | JAVA0166 Generic exception caught | |
| JAVA0167 | 0.00 | JAVA0167 ThreadDeath not rethrown | |
| JAVA0169 | 0.00 | JAVA0169 Unnecessary catch block: exception 'exception' | |
| JAVA0170 | 0.00 | JAVA0170 Caught exception not derived from java.lang.Exception | |
| JAVA0171 | 0.00 | JAVA0171 Unused local variable | |
| JAVA0173 | 0.00 | JAVA0173 Unused method parameter | |
| JAVA0174 | 0.00 | JAVA0174 Assigned local variable never used | |
| JAVA0175 | 0.00 | JAVA0175 Successive assignment to variable | |
| JAVA0176 | 0.00 | JAVA0176 Local variable name does not have required form | |
| JAVA0177 | 2.00 | JAVA0177 Variable declaration missing initializer | |
| JAVA0179 | 0.00 | JAVA0179 Local variable hides visible field | |
| JAVA0233 | 0.00 | JAVA0233 Definition of serialVersionUID other than 'private static final long serialVersionUID' | |
| JAVA0234 | 0.00 | JAVA0234 Class is Serializable but does not define serialVersionUID | |
| JAVA0235 | 0.00 | JAVA0235 Class defines serialVersionUID but does not implement Serializable | |
| JAVA0236 | 0.00 | JAVA0236 Attempt to clone an object which does not implement Cloneable | |
| JAVA0237 | 0.00 | JAVA0237 Class implements Cloneable but does not have public clone method | |
| JAVA0238 | 0.00 | JAVA0238 Clone method does not call super.clone() | |
| JAVA0239 | 0.00 | JAVA0239 Class declares 'readObject' or 'writeObject' but does not implement Serializable | |
| JAVA0240 | 0.00 | JAVA0240 Serializable class which declares readObject or writeObject but not both | |
| JAVA0241 | 0.00 | JAVA0241 'readObject' or 'writeObject' should be declared private in Serializable class | |
| JAVA0242 | 0.00 | JAVA0242 Transient field in non-Serializable class | |
| JAVA0243 | 0.00 | JAVA0243 'readResolve' or 'writeReplace' should be declared private or protected | |
| JAVA0244 | 0.00 | JAVA0244 Field or method name in subclass differs only by case from inherited field or method | |
| JAVA0245 | 0.00 | JAVA0245 JUnit TestCase with non-trivial constructor | |
| JAVA0246 | 0.00 | JAVA0246 JUnit assertXXX statement missing message parameter | |
| JAVA0247 | 0.00 | JAVA0247 JUnit 'setUp()' and 'tearDown()' should call super method | |
| JAVA0248 | 0.00 | JAVA0248 JUnit method 'setUp' or 'tearDown' with incorrect signature | |
| JAVA0249 | 0.00 | JAVA0249 JUnit TestCase 'suite()' should be declared static | |
| JAVA0250 | 0.00 | JAVA0250 JUnit TestCase declares testXXX method with incorrect signature | |
| JAVA0251 | 0.00 | JAVA0251 Use '%n' for line breaks in printf/format for platform independence | |
| JAVA0252 | 0.00 | JAVA0252 'enum' is a Java 1.5 reserved word | |
| JAVA0253 | 0.00 | JAVA0253 Not all enum constants consumed in switch statement | |
| JAVA0254 | 1.00 | JAVA0254 Use enhanced for loop construct instead of Iterator | |
| JAVA0255 | 0.00 | JAVA0255 Result of method invocation not used | |
| JAVA0256 | 0.00 | JAVA0256 Assignment of external collection/array to field | |
| JAVA0257 | 0.00 | JAVA0257 Use of 'Constant Interface' anti-pattern | |
| JAVA0258 | 0.00 | JAVA0258 Implement Iterable for foreach compatibility | |
| JAVA0259 | 0.00 | JAVA0259 Return of collection/array field | |
| JAVA0260 | 0.00 | JAVA0260 Use 'enum' instead of Enumerated Type pattern | |
| JAVA0261 | 0.00 | JAVA0261 Use specialized Enum collection types | |
| JAVA0262 | 0.00 | JAVA0262 Use of char in integer context | |
| JAVA0263 | 0.00 | JAVA0263 Long literal ends with 'l' instead of 'L' | |
| JAVA0264 | 0.00 | JAVA0264 Integer math in long context - check for overflow | |
| JAVA0265 | 0.00 | JAVA0265 Use of Throwable.printStackTrace() | |
| JAVA0266 | 0.00 | JAVA0266 Use of System.out | |
| JAVA0267 | 0.00 | JAVA0267 Use of System.err | |
| JAVA0269 | 0.00 | JAVA0269 Contents of StringBuffer never used | |
| JAVA0270 | 2.00 | JAVA0270 Use Java 5.0 enhanced for loop construct to iterate over all elements in an array | |
| JAVA0271 | 0.00 | JAVA0271 Minimize use of on-demand (.*) static imports | |
| JAVA0272 | 0.00 | JAVA0272 Thread.run() called | |
| JAVA0273 | 0.00 | JAVA0273 Non-final derivative of Thread calls start() in constructor | |
| JAVA0274 | 0.00 | JAVA0274 Serializable class has a synchronized readObject() | |
| JAVA0275 | 0.00 | JAVA0275 Serializable class has a synchronized writeObject() and no other synchronized methods | |
| JAVA0276 | 0.00 | JAVA0276 Unnecessary use of String constructor | |
| JAVA0277 | 0.00 | JAVA0277 Iterator.next() implementation does not throw NoSuchElementException | |
| JAVA0278 | 0.00 | JAVA0278 Unnecessary use of Boolean constructor | |
| JAVA0279 | 0.00 | JAVA0279 Serialization method readObject or readObjectNoData calls an overridable method | |
| JAVA0280 | 0.00 | JAVA0280 IllegalMonitorStateException caught | |
| JAVA0281 | 0.00 | JAVA0281 Iterator.next() not called in loop | |
| JAVA0282 | 0.00 | JAVA0282 Call to Iterator.next() in loop which does not test Iterator.hasNext() | |
| JAVA0283 | 0.00 | JAVA0283 Control variable not updated in loop body | |
| JAVA0284 | 0.00 | JAVA0284 Explicit garbage collection | |
| JAVA0285 | 0.00 | JAVA0285 Dereference of potentially null variable | |
| JAVA0286 | 0.00 | JAVA0286 Dereference of null variable | |
| JAVA0287 | 0.00 | JAVA0287 Unnecessary null check | |
| JAVA0288 | 0.00 | JAVA0288 Inconsistent null check | |
| LINES | 686.00 | Number of lines in the source file | |
| LINE_COMMENT | 26.00 | Number of line comments | |
| LOC | 411.00 | Lines of code | |
| LOGICAL_LINES | 240.00 | Number of statements | |
| LOOPS | 10.00 | Number of loops | |
| NEST_DEPTH | 6.00 | Maximum nesting depth | |
| OPERANDS | 1008.00 | Number of operands | |
| OPERATORS | 2015.00 | Number of operators | |
| PARAMS | 34.00 | Number of formal parameter declarations | |
| PROGRAM_LENGTH | 3023.00 | Halstead program length | |
| PROGRAM_VOCAB | 350.00 | Halstead program vocabulary | |
| PROGRAM_VOLUME | 0.00 | Halstead program volume | |
| RETURNS | 68.00 | Number of return points from functions | |
| SIZE | 20143.00 | Size of the file in bytes | |
| UNIQUE_OPERANDS | 298.00 | Number of unique operands | |
| UNIQUE_OPERATORS | 52.00 | Number of unique operators | |
| WHITESPACE | 83.00 | Number of whitespace lines | |