DMCheckerImpl.java
| Index Score | ||
|---|---|---|
 |
 |
org.gudy.azureus2.core3.disk.impl.access.impl |
 |
 |
Azureus |
View: Reasons, Metrics, Source Code
These are the metrics that contribute to the Enerjy Score for this file, ranked by impact. So the metrics listed at the top influence the score to a greater extent that the metrics listed at the bottom.
| Metric | Description | |
|---|---|---|
| JAVA0145 | JAVA0145 Tab character used in source file |  |
| JAVA0049 | JAVA0049 Nested block at depth N (maximum: M) | |
| WHITESPACE | Number of whitespace lines | |
| BLOCKS | Number of blocks | |
| LOC | Lines of code | |
| LINES | Number of lines in the source file | |
| ELOC | Effective lines of code | |
| LINE_COMMENT | Number of line comments | |
| JAVA0170 | JAVA0170 Caught exception not derived from java.lang.Exception | |
| JAVA0166 | JAVA0166 Generic exception caught | |
| LOOPS | Number of loops | |
| SIZE | Size of the file in bytes | |
| JAVA0034 | JAVA0034 Missing braces in if statement | |
| OPERATORS | Number of operators | |
| LOGICAL_LINES | Number of statements | |
| CYCLOMATIC | Cyclomatic complexity | |
| EXITS | Procedure exits | |
| PROGRAM_LENGTH | Halstead program length | |
| NEST_DEPTH | Maximum nesting depth | |
| JAVA0144 | JAVA0144 Line exceeds maximum M characters | |
| PROGRAM_VOCAB | Halstead program vocabulary | |
| UNIQUE_OPERANDS | Number of unique operands | |
| OPERANDS | Number of operands | |
| JAVA0177 | JAVA0177 Variable declaration missing initializer | |
| UNIQUE_OPERATORS | Number of unique operators | |
| EXEC_COMMENTS | Comments in executable code | |
| JAVA0076 | JAVA0076 Use of magic number | |
| INTERFACE_COMPLEXITY | Interface complexity | |
| PARAMS | Number of formal parameter declarations | |
| PROGRAM_VOLUME | Halstead program volume | |
| JAVA0266 | JAVA0266 Use of System.out | |
| COMPARISONS | Number of comparison operators | |
| RETURNS | Number of return points from functions | |
| JAVA0126 | JAVA0126 Method declares unchecked exception in throws | |
| JAVA0110 | JAVA0110 Incorrect javadoc: no @return tag | |
| JAVA0117 | JAVA0117 Missing javadoc: method 'method' | |
| JAVA0061 | JAVA0061 Inaccessible member in anonymous class | |
| FUNCTIONS | Number of function declarations | |
| JAVA0100 | JAVA0100 Class contains N non-final fields (maximum: M) | |
| JAVA0108 | JAVA0108 Incorrect javadoc: no @param tag for 'parameter' | |
| DOC_COMMENT | Number of javadoc comment lines | |
| DECL_COMMENTS | Comments in declarations | |
| COMMENTS | Comment lines | |
/*
* Created on 31-Jul-2004
* Created by Paul Gardner
* Copyright (C) 2004, 2005, 2006 Aelitis, All Rights Reserved.
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License
* as published by the Free Software Foundation; either version 2
* of the License, or (at your option) any later version.
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
*
* AELITIS, SAS au capital de 46,603.30 euros
* 8 Allee Lenotre, La Grille Royale, 78600 Le Mesnil le Roi, France.
*
*/
package org.gudy.azureus2.core3.disk.impl.access.impl;
import java.util.*;
import org.gudy.azureus2.core3.config.COConfigurationManager;
import org.gudy.azureus2.core3.config.ParameterListener;
import org.gudy.azureus2.core3.disk.*;
import org.gudy.azureus2.core3.disk.impl.DiskManagerFileInfoImpl;
import org.gudy.azureus2.core3.disk.impl.DiskManagerHelper;
import org.gudy.azureus2.core3.disk.impl.DiskManagerRecheckInstance;
import org.gudy.azureus2.core3.disk.impl.access.DMChecker;
import org.gudy.azureus2.core3.disk.impl.piecemapper.DMPieceList;
import org.gudy.azureus2.core3.disk.impl.piecemapper.DMPieceMapEntry;
import org.gudy.azureus2.core3.logging.*;
import org.gudy.azureus2.core3.util.*;
import com.aelitis.azureus.core.diskmanager.cache.CacheFile;
/**
* @author parg
*
*/
public class
DMCheckerImpl
implements DMChecker
{
protected static final LogIDs LOGID = LogIDs.DISK;
private static boolean flush_pieces;
private static boolean checking_read_priority;
private static AEMonitor class_mon = new AEMonitor( "DMChecker:class" );
private static List async_check_queue = new ArrayList();
private static AESemaphore async_check_queue_sem = new AESemaphore("DMChecker::asyncCheck");
private static boolean fully_async = COConfigurationManager.getBooleanParameter( "diskmanager.perf.checking.fully.async" );
static{
if ( fully_async ){
new AEThread2( "DMCheckerImpl:asyncCheckScheduler", true )
{
public void
run()
{
while( true ){
async_check_queue_sem.reserve();
Object[] entry;
try{
class_mon.enter();
entry = (Object[])async_check_queue.remove(0);
int queue_size = async_check_queue.size();
if ( queue_size % 100 == 0 && queue_size > 0 ){
System.out.println( "async check queue size=" + async_check_queue.size());
}
}finally{
class_mon.exit();
}
((DMCheckerImpl)entry[0]).enqueueCheckRequest(
(DiskManagerCheckRequest)entry[1],
(DiskManagerCheckRequestListener)entry[2],
flush_pieces );
}
}
}.start();
}
}
static{
ParameterListener param_listener = new ParameterListener() {
public void
parameterChanged(
String str )
{
flush_pieces = COConfigurationManager.getBooleanParameter( "diskmanager.perf.cache.flushpieces" );
checking_read_priority = COConfigurationManager.getBooleanParameter( "diskmanager.perf.checking.read.priority" );
}
};
COConfigurationManager.addAndFireParameterListeners(
new String[]{
"diskmanager.perf.cache.flushpieces",
"diskmanager.perf.checking.read.priority" },
param_listener );
}
protected DiskManagerHelper disk_manager;
protected int async_checks;
protected AESemaphore async_check_sem = new AESemaphore("DMChecker::asyncCheck");
protected int async_reads;
protected AESemaphore async_read_sem = new AESemaphore("DMChecker::asyncRead");
private boolean started;
protected volatile boolean stopped;
private volatile boolean complete_recheck_in_progress;
private volatile int complete_recheck_progress;
private boolean checking_enabled = true;
protected AEMonitor this_mon = new AEMonitor( "DMChecker" );
public
DMCheckerImpl(
DiskManagerHelper _disk_manager )
{
disk_manager = _disk_manager;
}
public void
start()
{
try{
this_mon.enter();
if ( started ){
throw( new RuntimeException( "DMChecker: start while started"));
}
if ( stopped ){
throw( new RuntimeException( "DMChecker: start after stopped"));
}
started = true;
}finally{
this_mon.exit();
}
}
public void
stop()
{
int check_wait;
int read_wait;
try{
this_mon.enter();
if ( stopped || !started ){
return;
}
// when we exit here we guarantee that all file usage operations have completed
// i.e. writes and checks (checks being doubly async)
stopped = true;
read_wait = async_reads;
check_wait = async_checks;
}finally{
this_mon.exit();
}
long log_time = SystemTime.getCurrentTime();
// wait for reads
for (int i=0;i<read_wait;i++){
long now = SystemTime.getCurrentTime();
if ( now < log_time ){
log_time = now;
}else{
if ( now - log_time > 1000 ){
log_time = now;
if ( Logger.isEnabled()){
Logger.log(new LogEvent(disk_manager, LOGID, "Waiting for check-reads to complete - " + (read_wait-i) + " remaining" ));
}
}
}
async_read_sem.reserve();
}
log_time = SystemTime.getCurrentTime();
// wait for checks
for (int i=0;i<check_wait;i++){
long now = SystemTime.getCurrentTime();
if ( now < log_time ){
log_time = now;
}else{
if ( now - log_time > 1000 ){
log_time = now;
if ( Logger.isEnabled()){
Logger.log(new LogEvent(disk_manager, LOGID, "Waiting for checks to complete - " + (read_wait-i) + " remaining" ));
}
}
}
async_check_sem.reserve();
}
}
public int
getCompleteRecheckStatus()
{
if (complete_recheck_in_progress ){
return( complete_recheck_progress );
}else{
return( -1 );
}
}
public void
setCheckingEnabled(
boolean enabled )
{
checking_enabled = enabled;
}
public DiskManagerCheckRequest
createCheckRequest(
int pieceNumber,
Object user_data )
{
return( new DiskManagerCheckRequestImpl( pieceNumber, user_data ));
}
public void
enqueueCompleteRecheckRequest(
final DiskManagerCheckRequest request,
final DiskManagerCheckRequestListener listener )
{
if ( !checking_enabled ){
listener.checkCompleted( request, true );
return;
}
complete_recheck_progress = 0;
complete_recheck_in_progress = true;
new AEThread2("DMChecker::completeRecheck", true )
{
public void
run()
{
DiskManagerRecheckInstance recheck_inst = disk_manager.getRecheckScheduler().register( disk_manager, true );
try{
final AESemaphore sem = new AESemaphore( "DMChecker::completeRecheck" );
int checks_submitted = 0;
final AESemaphore run_sem = new AESemaphore( "DMChecker::completeRecheck:runsem", 2 );
int nbPieces = disk_manager.getNbPieces();
for ( int i=0; i < nbPieces; i++ ){
complete_recheck_progress = 1000*i / nbPieces;
DiskManagerPiece dm_piece = disk_manager.getPiece(i);
// only recheck the piece if it happens to be done (a complete dnd file that's
// been set back to dnd for example) or the piece is part of a non-dnd file
if ( dm_piece.isDone() || !dm_piece.isSkipped()){
run_sem.reserve();
while( !stopped ){
if ( recheck_inst.getPermission()){
break;
}
}
if ( stopped ){
break;
}
enqueueCheckRequest(
createCheckRequest( i, request.getUserData()),
new DiskManagerCheckRequestListener()
{
public void
checkCompleted(
DiskManagerCheckRequest request,
boolean passed )
{
try{
listener.checkCompleted( request, passed );
}catch( Throwable e ){
Debug.printStackTrace(e);
}finally{
complete();
}
}
public void
checkCancelled(
DiskManagerCheckRequest request )
{
try{
listener.checkCancelled( request );
}catch( Throwable e ){
Debug.printStackTrace(e);
}finally{
complete();
}
}
public void
checkFailed(
DiskManagerCheckRequest request,
Throwable cause )
{
try{
listener.checkFailed( request, cause );
}catch( Throwable e ){
Debug.printStackTrace(e);
}finally{
complete();
} }
protected void
complete()
{
run_sem.release();
sem.release();
}
},
false );
checks_submitted++;
}
}
// wait for all to complete
for (int i=0;i<checks_submitted;i++){
sem.reserve();
}
}finally{
complete_recheck_in_progress = false;
recheck_inst.unregister();
}
}
}.start();
}
public void
enqueueCheckRequest(
DiskManagerCheckRequest request,
DiskManagerCheckRequestListener listener )
{
if ( fully_async ){
// if the disk controller read-queue is full then normal the read-request allocation
// will block. This option forces the check request to be scheduled off the caller's
// thread
try{
class_mon.enter();
async_check_queue.add( new Object[]{ this, request, listener });
if ( async_check_queue.size() % 100 == 0 ){
System.out.println( "async check queue size=" + async_check_queue.size());
}
}finally{
class_mon.exit();
}
async_check_queue_sem.release();
}else{
enqueueCheckRequest( request, listener, flush_pieces );
}
}
public boolean
hasOutstandingCheckRequestForPiece(
int piece_number )
{
if ( fully_async ){
try{
class_mon.enter();
for (int i=0;i<async_check_queue.size();i++){
Object[] entry = (Object[])async_check_queue.get(i);
if ( entry[0] == this ){
DiskManagerCheckRequest request = (DiskManagerCheckRequest)entry[1];
if ( request.getPieceNumber() == piece_number ){
return( true );
}
}
}
}finally{
class_mon.exit();
}
}
return( false );
}
protected void
enqueueCheckRequest(
final DiskManagerCheckRequest request,
final DiskManagerCheckRequestListener listener,
boolean read_flush )
{
// everything comes through here - the interceptor listener maintains the piece state and
// does logging
request.requestStarts();
enqueueCheckRequestSupport(
request,
new DiskManagerCheckRequestListener()
{
public void
checkCompleted(
DiskManagerCheckRequest request,
boolean passed )
{
request.requestEnds( true );
try{
int piece_number = request.getPieceNumber();
DiskManagerPiece piece = disk_manager.getPiece(request.getPieceNumber());
piece.setDone( passed );
if ( passed ){
DMPieceList piece_list = disk_manager.getPieceList( piece_number );
for (int i = 0; i < piece_list.size(); i++) {
DMPieceMapEntry piece_entry = piece_list.get(i);
piece_entry.getFile().dataChecked( piece_entry.getOffset(), piece_entry.getLength());
}
}
}finally{
listener.checkCompleted( request, passed );
if (Logger.isEnabled()){
if ( passed ){
Logger.log(new LogEvent(disk_manager, LOGID, LogEvent.LT_INFORMATION,
"Piece " + request.getPieceNumber() + " passed hash check."));
}else{
Logger.log(new LogEvent(disk_manager, LOGID, LogEvent.LT_WARNING,
"Piece " + request.getPieceNumber() + " failed hash check."));
}
}
}
}
public void
checkCancelled(
DiskManagerCheckRequest request )
{
request.requestEnds( false );
// don't explicitly mark a piece as failed if we get a cancellation as the
// existing state will suffice. Either we're rechecking because it is bad
// already (in which case it won't be done, or we're doing a recheck-on-complete
// in which case the state is ok and musn't be flipped to bad
listener.checkCancelled( request );
if (Logger.isEnabled()){
Logger.log(new LogEvent(disk_manager, LOGID, LogEvent.LT_WARNING,
"Piece " + request.getPieceNumber() + " hash check cancelled."));
}
}
public void
checkFailed(
DiskManagerCheckRequest request,
Throwable cause )
{
request.requestEnds( false );
try{
disk_manager.getPiece(request.getPieceNumber()).setDone( false );
}finally{
listener.checkFailed( request, cause );
if (Logger.isEnabled()){
Logger.log(new LogEvent(disk_manager, LOGID, LogEvent.LT_WARNING,
"Piece " + request.getPieceNumber() + " failed hash check - " + Debug.getNestedExceptionMessage( cause )));
}
}
}
}, read_flush );
}
protected void
enqueueCheckRequestSupport(
final DiskManagerCheckRequest request,
final DiskManagerCheckRequestListener listener,
boolean read_flush )
{
if ( !checking_enabled ){
listener.checkCompleted( request, true );
return;
}
int pieceNumber = request.getPieceNumber();
try{
final byte[] required_hash = disk_manager.getPieceHash(pieceNumber);
// quick check that the files that make up this piece are at least big enough
// to warrant reading the data to check
// also, if the piece is entirely compact then we can immediately
// fail as we don't actually have any data for the piece (or can assume we don't)
// we relax this a bit to catch pieces that are part of compact files with less than
// three pieces as it is possible that these were once complete and have all their bits
// living in retained compact areas
DMPieceList pieceList = disk_manager.getPieceList(pieceNumber);
try{
// there are other comments in the code about the existence of 0 length piece lists
// just in case these still occur for who knows what reason ensure that a 0 length list
// causes the code to carry on and do the check (i.e. it is no worse that before this
// optimisation was added...)
boolean all_compact = pieceList.size() > 0;
for (int i = 0; i < pieceList.size(); i++) {
DMPieceMapEntry piece_entry = pieceList.get(i);
DiskManagerFileInfoImpl file_info = piece_entry.getFile();
CacheFile cache_file = file_info.getCacheFile();
if ( cache_file.compareLength( piece_entry.getOffset()) < 0 ){
listener.checkCompleted( request, false );
return;
}
if ( all_compact && ( cache_file.getStorageType() != CacheFile.CT_COMPACT || file_info.getNbPieces() <= 2 )){
all_compact = false;
}
}
if ( all_compact ){
// System.out.println( "Piece " + pieceNumber + " is all compact, failing hash check" );
listener.checkCompleted( request, false );
return;
}
}catch( Throwable e ){
// we can fail here if the disk manager has been stopped as the cache file length access may be being
// performed on a "closed" (i.e. un-owned) file
listener.checkCancelled( request );
return;
}
int this_piece_length = disk_manager.getPieceLength( pieceNumber );
DiskManagerReadRequest read_request = disk_manager.createReadRequest( pieceNumber, 0, this_piece_length );
try{
this_mon.enter();
if ( stopped ){
listener.checkCancelled( request );
return;
}
async_reads++;
}finally{
this_mon.exit();
}
read_request.setFlush( read_flush );
read_request.setUseCache( !request.isAdHoc());
disk_manager.enqueueReadRequest(
read_request,
new DiskManagerReadRequestListener()
{
public void
readCompleted(
DiskManagerReadRequest read_request,
DirectByteBuffer buffer )
{
complete();
try{
this_mon.enter();
if ( stopped ){
buffer.returnToPool();
listener.checkCancelled( request );
return;
}
async_checks++;
}finally{
this_mon.exit();
}
try{
final DirectByteBuffer f_buffer = buffer;
ConcurrentHasher.getSingleton().addRequest(
buffer.getBuffer(DirectByteBuffer.SS_DW),
new ConcurrentHasherRequestListener()
{
public void
complete(
ConcurrentHasherRequest hash_request )
{
int async_result = 3; // cancelled
try{
byte[] testHash = hash_request.getResult();
if ( testHash != null ){
async_result = 1; // success
for (int i = 0; i < testHash.length; i++){
if ( testHash[i] != required_hash[i]){
async_result = 2; // failed;
break;
}
}
}
}finally{
try{
f_buffer.returnToPool();
if ( async_result == 1 ){
listener.checkCompleted( request, true );
}else if ( async_result == 2 ){
listener.checkCompleted( request, false );
}else{
listener.checkCancelled( request );
}
}finally{
try{
this_mon.enter();
async_checks--;
if ( stopped ){
async_check_sem.release();
}
}finally{
this_mon.exit();
}
}
}
}
},
request.isLowPriority());
}catch( Throwable e ){
Debug.printStackTrace(e);
buffer.returnToPool();
listener.checkFailed( request, e );
}
}
public void
readFailed(
DiskManagerReadRequest read_request,
Throwable cause )
{
complete();
listener.checkFailed( request, cause );
}
public int
getPriority()
{
return( checking_read_priority?0:-1 );
}
public void
requestExecuted(long bytes)
{
}
protected void
complete()
{
try{
this_mon.enter();
async_reads--;
if ( stopped ){
async_read_sem.release();
}
}finally{
this_mon.exit();
}
}
});
}catch( Throwable e ){
disk_manager.setFailed( "Piece check error - " + Debug.getNestedExceptionMessage(e));
Debug.printStackTrace( e );
listener.checkFailed( request, e );
}
}
}
The table below shows all metrics for DMCheckerImpl.java.
| Metric | Value | Description | |
|---|---|---|---|
| BLOCKS | 126.00 | Number of blocks | |
| BLOCK_COMMENT | 21.00 | Number of block comment lines | |
| COMMENTS | 55.00 | Comment lines | |
| COMMENT_DENSITY | 0.13 | Comment density | |
| COMPARISONS | 42.00 | Number of comparison operators | |
| CYCLOMATIC | 87.00 | Cyclomatic complexity | |
| DECL_COMMENTS | 2.00 | Comments in declarations | |
| DOC_COMMENT | 4.00 | Number of javadoc comment lines | |
| ELOC | 414.00 | Effective lines of code | |
| EXEC_COMMENTS | 13.00 | Comments in executable code | |
| EXITS | 63.00 | Procedure exits | |
| FUNCTIONS | 27.00 | Number of function declarations | |
| HALSTEAD_DIFFICULTY | 90.13 | Halstead difficulty | |
| HALSTEAD_EFFORT | 0.00 | Halstead effort | |
| INTERFACE_COMPLEXITY | 71.00 | Interface complexity | |
| JAVA0001 | 1.00 | JAVA0001 Package name does not contain only lower case letters | |
| JAVA0002 | 0.00 | JAVA0002 Package name does not begin with a top level domain name or country code | |
| JAVA0003 | 0.00 | JAVA0003 Minimize use of on-demand (.*) imports | |
| JAVA0004 | 0.00 | JAVA0004 Unnecessary import from java.lang | |
| JAVA0005 | 0.00 | JAVA0005 Imports not in specified order | |
| JAVA0006 | 0.00 | JAVA0006 Empty finally block | |
| JAVA0007 | 0.00 | JAVA0007 Should not declare public field | |
| JAVA0008 | 0.00 | JAVA0008 Empty catch block | |
| JAVA0009 | 0.00 | JAVA0009 Protected member in final class | |
| JAVA0010 | 0.00 | JAVA0010 Non-instantiable class does not contain a non-private static member | |
| JAVA0011 | 0.00 | JAVA0011 Abstract class does not contain an abstract method | |
| JAVA0012 | 0.00 | JAVA0012 Non-constructor method with same name as declaring class | |
| JAVA0013 | 0.00 | JAVA0013 Non-blank final field is not static | |
| JAVA0014 | 0.00 | JAVA0014 Class with only static members has non-private constructor | |
| JAVA0015 | 0.00 | JAVA0015 Package class contains public nested type | |
| JAVA0016 | 0.00 | JAVA0016 Abstract class contains public constructor | |
| JAVA0017 | 0.00 | JAVA0017 Class name does not have required form | |
| JAVA0018 | 0.00 | JAVA0018 Method name does not have required form | |
| JAVA0019 | 0.00 | JAVA0019 Interface name does not have required form | |
| JAVA0020 | 0.00 | JAVA0020 Field name does not have required form | |
| JAVA0021 | 0.00 | JAVA0021 Interface method name does not have required form | |
| JAVA0022 | 0.00 | JAVA0022 Static final field name does not have required form | |
| JAVA0023 | 0.00 | JAVA0023 Empty finalize method | |
| JAVA0024 | 0.00 | JAVA0024 Empty class | |
| JAVA0025 | 0.00 | JAVA0025 Method override is empty | |
| JAVA0026 | 0.00 | JAVA0026 Finalize method with parameters | |
| JAVA0029 | 0.00 | JAVA0029 Private method not used | |
| JAVA0030 | 0.00 | JAVA0030 Private field not used | |
| JAVA0031 | 0.00 | JAVA0031 Case statement not properly closed | |
| JAVA0032 | 0.00 | JAVA0032 Switch statement missing default | |
| JAVA0033 | 0.00 | JAVA0033 default: not last case in switch statement | |
| JAVA0034 | 0.00 | JAVA0034 Missing braces in if statement | |
| JAVA0035 | 0.00 | JAVA0035 Missing braces in for statement | |
| JAVA0036 | 0.00 | JAVA0036 Missing braces in while statement | |
| JAVA0038 | 0.00 | JAVA0038 Non-case label in switch statement | |
| JAVA0039 | 0.00 | JAVA0039 Break statement with label | |
| JAVA0040 | 0.00 | JAVA0040 Switch statement contains N cases (maximum: M) | |
| JAVA0041 | 0.00 | JAVA0041 Nested synchronized block | |
| JAVA0042 | 0.00 | JAVA0042 Empty synchronized statement | |
| JAVA0043 | 0.00 | JAVA0043 Inner class does not use outer class | |
| JAVA0044 | 0.00 | JAVA0044 Serializable class with no instance variables | |
| JAVA0045 | 0.00 | JAVA0045 Serializable class with only transient fields | |
| JAVA0046 | 0.00 | JAVA0046 Name of class not derived from Exception ends with 'Exception' | |
| JAVA0047 | 0.00 | JAVA0047 Serializable class derives from invalid base class | |
| JAVA0048 | 0.00 | JAVA0048 Name of class derived from Exception does not end with 'Exception' | |
| JAVA0049 | 10.00 | JAVA0049 Nested block at depth N (maximum: M) | |
| JAVA0050 | 0.00 | JAVA0050 Class derives from java.lang.Error | |
| JAVA0051 | 0.00 | JAVA0051 Class derives from java.lang.RuntimeException | |
| JAVA0052 | 0.00 | JAVA0052 Class derives from java.lang.Throwable | |
| JAVA0053 | 0.00 | JAVA0053 Unused label | |
| JAVA0054 | 0.00 | JAVA0054 Inheritance depth N exceeds maximum M | |
| JAVA0055 | 0.00 | JAVA0055 Class should be interface | |
| JAVA0056 | 0.00 | JAVA0056 Unnecessary abstract modifier for interface or annotation | |
| JAVA0057 | 0.00 | JAVA0057 Unnecessary default constructor | |
| JAVA0058 | 0.00 | JAVA0058 Constructor calls super() | |
| JAVA0059 | 0.00 | JAVA0059 Method override only calls super() | |
| JAVA0061 | 2.00 | JAVA0061 Inaccessible member in anonymous class | |
| JAVA0062 | 0.00 | JAVA0062 Public class missing public member or protected constructor | |
| JAVA0063 | 0.00 | JAVA0063 Identifier name should not contain '$' | |
| JAVA0064 | 0.00 | JAVA0064 N variations of identifier name (maximum: M) | |
| JAVA0065 | 0.00 | JAVA0065 Unnecessary final modifier for method in final class | |
| JAVA0066 | 0.00 | JAVA0066 Unnecessary modifier for interface nested type | |
| JAVA0067 | 0.00 | JAVA0067 Array descriptor on identifier name | |
| JAVA0068 | 0.00 | JAVA0068 Modifiers not declared in recommended order | |
| JAVA0071 | 0.00 | JAVA0071 Strings compared with == | |
| JAVA0073 | 0.00 | JAVA0073 Integer division in floating-point context | |
| JAVA0074 | 0.00 | JAVA0074 Use of Object.notify() | |
| JAVA0075 | 0.00 | JAVA0075 Method parameter hides field | |
| JAVA0076 | 5.00 | JAVA0076 Use of magic number | |
| JAVA0077 | 0.00 | JAVA0077 Private field not used in declaring class | |
| JAVA0078 | 0.00 | JAVA0078 Floating point values compared with == | |
| JAVA0079 | 0.00 | JAVA0079 Use of instance to reference static member | |
| JAVA0080 | 0.00 | JAVA0080 Import declaration not used | |
| JAVA0081 | 0.00 | JAVA0081 Boolean literal in comparison | |
| JAVA0082 | 0.00 | JAVA0082 Unnecessary widening cast | |
| JAVA0083 | 0.00 | JAVA0083 Unnecessary instanceof test | |
| JAVA0084 | 0.00 | JAVA0084 Should use compound assignment operator | |
| JAVA0085 | 0.00 | JAVA0085 Use of sun.* class | |
| JAVA0087 | 0.00 | JAVA0087 Use of Thread.sleep() | |
| JAVA0089 | 0.00 | JAVA0089 Use of restricted package | |
| JAVA0092 | 0.00 | JAVA0092 Use of restricted type | |
| JAVA0093 | 0.00 | JAVA0093 Redundant assignment | |
| JAVA0094 | 0.00 | JAVA0094 Field hides a superclass field | |
| JAVA0095 | 0.00 | JAVA0095 Uninitialized private field | |
| JAVA0096 | 0.00 | JAVA0096 Field in nested class hides outer field | |
| JAVA0098 | 0.00 | JAVA0098 Minimize use of implicit field initializers | |
| JAVA0100 | 1.00 | JAVA0100 Class contains N non-final fields (maximum: M) | |
| JAVA0101 | 0.00 | JAVA0101 Unnecessary modifier for field in interface | |
| JAVA0102 | 0.00 | JAVA0102 Last statement in finalize() not super.finalize() | |
| JAVA0103 | 0.00 | JAVA0103 Explicit call to finalize() | |
| JAVA0104 | 0.00 | JAVA0104 finalize() only calls super.finalize() | |
| JAVA0105 | 0.00 | JAVA0105 Duplicate import declaration | |
| JAVA0106 | 0.00 | JAVA0106 Unnecessary import from current package | |
| JAVA0108 | 0.00 | JAVA0108 Incorrect javadoc: no @param tag for 'parameter' | |
| JAVA0109 | 0.00 | JAVA0109 Incorrect javadoc: no parameter 'parameter' | |
| JAVA0110 | 0.00 | JAVA0110 Incorrect javadoc: no @return tag | |
| JAVA0111 | 0.00 | JAVA0111 Incorrect javadoc: @return tag for void method | |
| JAVA0112 | 0.00 | JAVA0112 Incorrect javadoc: no exception 'exception' in throws | |
| JAVA0113 | 0.00 | JAVA0113 Incorrect javadoc: no @author tag | |
| JAVA0114 | 1.00 | JAVA0114 Incorrect javadoc: no @version tag | |
| JAVA0115 | 0.00 | JAVA0115 Incorrect javadoc: no @throws or @exception tag for 'exception' | |
| JAVA0116 | 0.00 | JAVA0116 Missing javadoc: field 'field' | |
| JAVA0117 | 5.00 | JAVA0117 Missing javadoc: method 'method' | |
| JAVA0118 | 0.00 | JAVA0118 Missing javadoc: type 'type' | |
| JAVA0119 | 0.00 | JAVA0119 Control variable changed within body of for loop | |
| JAVA0123 | 0.00 | JAVA0123 Use all three components of for loop | |
| JAVA0125 | 0.00 | JAVA0125 Continue statement with label | |
| JAVA0126 | 0.00 | JAVA0126 Method declares unchecked exception in throws | |
| JAVA0128 | 0.00 | JAVA0128 Public constructor in non-public class | |
| JAVA0130 | 0.00 | JAVA0130 Non-static method does not use instance fields | |
| JAVA0131 | 0.00 | JAVA0131 Compatible method does not override base | |
| JAVA0132 | 0.00 | JAVA0132 Method overload with compatible signature | |
| JAVA0133 | 0.00 | JAVA0133 Non-synchronized method overrides synchronized method | |
| JAVA0135 | 0.00 | JAVA0135 Only one of Object.equals and Object.hashCode defined: missing 'method' | |
| JAVA0136 | 0.00 | JAVA0136 N methods defined in class (maximum: M) | |
| JAVA0137 | 0.00 | JAVA0137 Non-abstract class missing constructor | |
| JAVA0138 | 0.00 | JAVA0138 N parameters defined for method (maximum: M) | |
| JAVA0139 | 0.00 | JAVA0139 Definition of main other than public static void main(java.lang.String[]) | |
| JAVA0141 | 0.00 | JAVA0141 Unnecessary modifier for method in interface | |
| JAVA0143 | 0.00 | JAVA0143 Synchronized method | |
| JAVA0144 | 4.00 | JAVA0144 Line exceeds maximum M characters | |
| JAVA0145 | 4432.00 | JAVA0145 Tab character used in source file | |
| JAVA0150 | 0.00 | JAVA0150 java.lang.Error (or subclass) thrown | |
| JAVA0153 | 0.00 | JAVA0153 Inefficient conversion of integer to string | |
| JAVA0159 | 0.00 | JAVA0159 Inefficient conversion of string to integer | |
| JAVA0160 | 0.00 | JAVA0160 Method does not throw specified exception | |
| JAVA0161 | 0.00 | JAVA0161 Conditional wait() not in loop | |
| JAVA0163 | 0.00 | JAVA0163 Empty statement | |
| JAVA0165 | 0.00 | JAVA0165 Conflicting return statement in finally block | |
| JAVA0166 | 6.00 | JAVA0166 Generic exception caught | |
| JAVA0167 | 0.00 | JAVA0167 ThreadDeath not rethrown | |
| JAVA0169 | 0.00 | JAVA0169 Unnecessary catch block: exception 'exception' | |
| JAVA0170 | 6.00 | JAVA0170 Caught exception not derived from java.lang.Exception | |
| JAVA0171 | 0.00 | JAVA0171 Unused local variable | |
| JAVA0173 | 0.00 | JAVA0173 Unused method parameter | |
| JAVA0174 | 0.00 | JAVA0174 Assigned local variable never used | |
| JAVA0175 | 0.00 | JAVA0175 Successive assignment to variable | |
| JAVA0176 | 0.00 | JAVA0176 Local variable name does not have required form | |
| JAVA0177 | 3.00 | JAVA0177 Variable declaration missing initializer | |
| JAVA0179 | 0.00 | JAVA0179 Local variable hides visible field | |
| JAVA0233 | 0.00 | JAVA0233 Definition of serialVersionUID other than 'private static final long serialVersionUID' | |
| JAVA0234 | 0.00 | JAVA0234 Class is Serializable but does not define serialVersionUID | |
| JAVA0235 | 0.00 | JAVA0235 Class defines serialVersionUID but does not implement Serializable | |
| JAVA0236 | 0.00 | JAVA0236 Attempt to clone an object which does not implement Cloneable | |
| JAVA0237 | 0.00 | JAVA0237 Class implements Cloneable but does not have public clone method | |
| JAVA0238 | 0.00 | JAVA0238 Clone method does not call super.clone() | |
| JAVA0239 | 0.00 | JAVA0239 Class declares 'readObject' or 'writeObject' but does not implement Serializable | |
| JAVA0240 | 0.00 | JAVA0240 Serializable class which declares readObject or writeObject but not both | |
| JAVA0241 | 0.00 | JAVA0241 'readObject' or 'writeObject' should be declared private in Serializable class | |
| JAVA0242 | 0.00 | JAVA0242 Transient field in non-Serializable class | |
| JAVA0243 | 0.00 | JAVA0243 'readResolve' or 'writeReplace' should be declared private or protected | |
| JAVA0244 | 0.00 | JAVA0244 Field or method name in subclass differs only by case from inherited field or method | |
| JAVA0245 | 0.00 | JAVA0245 JUnit TestCase with non-trivial constructor | |
| JAVA0246 | 0.00 | JAVA0246 JUnit assertXXX statement missing message parameter | |
| JAVA0247 | 0.00 | JAVA0247 JUnit 'setUp()' and 'tearDown()' should call super method | |
| JAVA0248 | 0.00 | JAVA0248 JUnit method 'setUp' or 'tearDown' with incorrect signature | |
| JAVA0249 | 0.00 | JAVA0249 JUnit TestCase 'suite()' should be declared static | |
| JAVA0250 | 0.00 | JAVA0250 JUnit TestCase declares testXXX method with incorrect signature | |
| JAVA0251 | 0.00 | JAVA0251 Use '%n' for line breaks in printf/format for platform independence | |
| JAVA0252 | 0.00 | JAVA0252 'enum' is a Java 1.5 reserved word | |
| JAVA0253 | 0.00 | JAVA0253 Not all enum constants consumed in switch statement | |
| JAVA0254 | 0.00 | JAVA0254 Use enhanced for loop construct instead of Iterator | |
| JAVA0255 | 0.00 | JAVA0255 Result of method invocation not used | |
| JAVA0256 | 0.00 | JAVA0256 Assignment of external collection/array to field | |
| JAVA0257 | 0.00 | JAVA0257 Use of 'Constant Interface' anti-pattern | |
| JAVA0258 | 0.00 | JAVA0258 Implement Iterable for foreach compatibility | |
| JAVA0259 | 0.00 | JAVA0259 Return of collection/array field | |
| JAVA0260 | 0.00 | JAVA0260 Use 'enum' instead of Enumerated Type pattern | |
| JAVA0261 | 0.00 | JAVA0261 Use specialized Enum collection types | |
| JAVA0262 | 0.00 | JAVA0262 Use of char in integer context | |
| JAVA0263 | 0.00 | JAVA0263 Long literal ends with 'l' instead of 'L' | |
| JAVA0264 | 0.00 | JAVA0264 Integer math in long context - check for overflow | |
| JAVA0265 | 0.00 | JAVA0265 Use of Throwable.printStackTrace() | |
| JAVA0266 | 2.00 | JAVA0266 Use of System.out | |
| JAVA0267 | 0.00 | JAVA0267 Use of System.err | |
| JAVA0269 | 0.00 | JAVA0269 Contents of StringBuffer never used | |
| JAVA0270 | 0.00 | JAVA0270 Use Java 5.0 enhanced for loop construct to iterate over all elements in an array | |
| JAVA0271 | 0.00 | JAVA0271 Minimize use of on-demand (.*) static imports | |
| JAVA0272 | 0.00 | JAVA0272 Thread.run() called | |
| JAVA0273 | 0.00 | JAVA0273 Non-final derivative of Thread calls start() in constructor | |
| JAVA0274 | 0.00 | JAVA0274 Serializable class has a synchronized readObject() | |
| JAVA0275 | 0.00 | JAVA0275 Serializable class has a synchronized writeObject() and no other synchronized methods | |
| JAVA0276 | 0.00 | JAVA0276 Unnecessary use of String constructor | |
| JAVA0277 | 0.00 | JAVA0277 Iterator.next() implementation does not throw NoSuchElementException | |
| JAVA0278 | 0.00 | JAVA0278 Unnecessary use of Boolean constructor | |
| JAVA0279 | 0.00 | JAVA0279 Serialization method readObject or readObjectNoData calls an overridable method | |
| JAVA0280 | 0.00 | JAVA0280 IllegalMonitorStateException caught | |
| JAVA0281 | 0.00 | JAVA0281 Iterator.next() not called in loop | |
| JAVA0282 | 0.00 | JAVA0282 Call to Iterator.next() in loop which does not test Iterator.hasNext() | |
| JAVA0283 | 0.00 | JAVA0283 Control variable not updated in loop body | |
| JAVA0284 | 0.00 | JAVA0284 Explicit garbage collection | |
| JAVA0285 | 0.00 | JAVA0285 Dereference of potentially null variable | |
| JAVA0286 | 0.00 | JAVA0286 Dereference of null variable | |
| JAVA0287 | 0.00 | JAVA0287 Unnecessary null check | |
| JAVA0288 | 0.00 | JAVA0288 Inconsistent null check | |
| LINES | 856.00 | Number of lines in the source file | |
| LINE_COMMENT | 30.00 | Number of line comments | |
| LOC | 543.00 | Lines of code | |
| LOGICAL_LINES | 214.00 | Number of statements | |
| LOOPS | 10.00 | Number of loops | |
| NEST_DEPTH | 9.00 | Maximum nesting depth | |
| OPERANDS | 857.00 | Number of operands | |
| OPERATORS | 1838.00 | Number of operators | |
| PARAMS | 32.00 | Number of formal parameter declarations | |
| PROGRAM_LENGTH | 2695.00 | Halstead program length | |
| PROGRAM_VOCAB | 328.00 | Halstead program vocabulary | |
| PROGRAM_VOLUME | 0.00 | Halstead program volume | |
| RETURNS | 39.00 | Number of return points from functions | |
| SIZE | 21516.00 | Size of the file in bytes | |
| UNIQUE_OPERANDS | 271.00 | Number of unique operands | |
| UNIQUE_OPERATORS | 57.00 | Number of unique operators | |
| WHITESPACE | 258.00 | Number of whitespace lines | |