ConfigurationManager.java

Index Score
org.gudy.azureus2.core3.config.impl
Azureus

View: Reasons, Metrics, Source Code

These are the metrics that contribute to the Enerjy Score for this file, ranked by impact. So the metrics listed at the top influence the score to a greater extent that the metrics listed at the bottom.

MetricDescription
JAVA0117JAVA0117 Missing javadoc: method 'method'
BLOCKSNumber of blocks
PARAMSNumber of formal parameter declarations
INTERFACE_COMPLEXITYInterface complexity
CYCLOMATICCyclomatic complexity
JAVA0166JAVA0166 Generic exception caught
RETURNSNumber of return points from functions
JAVA0034JAVA0034 Missing braces in if statement
FUNCTIONSNumber of function declarations
EXITSProcedure exits
LOCLines of code
ELOCEffective lines of code
LINESNumber of lines in the source file
OPERATORSNumber of operators
UNIQUE_OPERANDSNumber of unique operands
PROGRAM_LENGTHHalstead program length
PROGRAM_VOCABHalstead program vocabulary
LOGICAL_LINESNumber of statements
SIZESize of the file in bytes
OPERANDSNumber of operands
WHITESPACENumber of whitespace lines
JAVA0177JAVA0177 Variable declaration missing initializer
JAVA0170JAVA0170 Caught exception not derived from java.lang.Exception
COMPARISONSNumber of comparison operators
EXEC_COMMENTSComments in executable code
LINE_COMMENTNumber of line comments
JAVA0254JAVA0254 Use enhanced for loop construct instead of Iterator
JAVA0049JAVA0049 Nested block at depth N (maximum: M)
UNIQUE_OPERATORSNumber of unique operators
NEST_DEPTHMaximum nesting depth
LOOPSNumber of loops
JAVA0145JAVA0145 Tab character used in source file
PROGRAM_VOLUMEHalstead program volume
JAVA0136JAVA0136 N methods defined in class (maximum: M)
JAVA0126JAVA0126 Method declares unchecked exception in throws
JAVA0100JAVA0100 Class contains N non-final fields (maximum: M)
JAVA0270JAVA0270 Use Java 5.0 enhanced for loop construct to iterate over all elements in an array
DOC_COMMENTNumber of javadoc comment lines
/* * Created on Jun 20, 2003 * Copyright (C) 2003, 2004, 2005, 2006 Aelitis, All Rights Reserved. * * This program is free software; you can redistribute it and/or * modify it under the terms of the GNU General Public License * as published by the Free Software Foundation; either version 2 * of the License, or (at your option) any later version. * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. * * AELITIS, SAS au capital de 46,603.30 euros * 8 Allee Lenotre, La Grille Royale, 78600 Le Mesnil le Roi, France. * */ package org.gudy.azureus2.core3.config.impl; import java.io.*; import java.util.*; import org.gudy.azureus2.core3.util.*; import org.gudy.azureus2.core3.config.*; import org.gudy.azureus2.core3.config.COConfigurationManager.ParameterVerifier; import com.aelitis.azureus.core.security.CryptoManager; /** * A singleton used to store configuration into a bencoded file. * * @author TdC_VgA * */ public class ConfigurationManager implements AEDiagnosticsEvidenceGenerator { private static ConfigurationManager config_temp = null; private static ConfigurationManager config = null; private static AEMonitor class_mon = new AEMonitor( "ConfigMan:class" ); private Map propertiesMap; // leave this NULL - it picks up errors caused by initialisation sequence errors private List transient_properties = new ArrayList(); private List listeners = new ArrayList(); private Hashtable parameterListeners = new Hashtable(); private AEMonitor this_mon = new AEMonitor( "ConfigMan"); private static FrequencyLimitedDispatcher dirty_dispatcher = new FrequencyLimitedDispatcher( new AERunnable() { public void runSupport() { COConfigurationManager.save(); } }, 30*1000 ); public static ConfigurationManager getInstance() { try{ class_mon.enter(); if ( config == null){ // this is nasty but I can't see an easy way around it. Unfortunately while reading the config // we hit other code (logging for example) that needs access to the config data. Things are // cunningly (?) arranged so that a recursive call here *won't* result in a further (looping) // recursive call if we attempt to load the config again. Hence this disgusting code that // goes for a second load attempt if ( config_temp == null ){ config_temp = new ConfigurationManager(); config_temp.load(); config_temp.initialise(); config = config_temp; }else{ if ( config_temp.propertiesMap == null ){ config_temp.load(); } return( config_temp ); } } return config; }finally{ class_mon.exit(); } } public static ConfigurationManager getInstance(Map data) { try{ class_mon.enter(); if (config == null){ config = new ConfigurationManager(data); } return config; }finally{ class_mon.exit(); } } private ConfigurationManager() { } private ConfigurationManager( Map data ) { // default state of play for config initialised from map is debug log files off unless already // specified if ( data.get("Logger.DebugFiles.Enabled") == null ){ data.put( "Logger.DebugFiles.Enabled", new Long(0)); } propertiesMap = data; } protected void initialise() { //ConfigurationChecker.migrateConfig(); //removed 2201 ConfigurationChecker.checkConfiguration(); ConfigurationChecker.setSystemProperties(); AEDiagnostics.addEvidenceGenerator( this ); } public void load(String filename) { Map data = FileUtil.readResilientConfigFile( filename, false ); // horrendous recursive loading going on here due to logger + config depedencies. If already loaded // then use the existing data as it might have already been written to... if ( propertiesMap == null ){ propertiesMap = data; } /* * Can't do this yet. Sometimes, there's a default set to x, but the code * calls get..Parameter(..., y). y != x. When the user sets the the parameter * to x, we remove it from the list. Later, the get..Parameter(.., y) returns * y because there is no entry. * * The solution is to not allow get..Parameter(.., y) when there's a default * value. Another reason to not allow it is that having two defaults confuses * coders. * // Remove entries that are default. Saves memory, reduces // file size when saved again ConfigurationDefaults def = ConfigurationDefaults.getInstance(); Iterator it = new TreeSet(propertiesMap.keySet()).iterator(); while (it.hasNext()) { String key = (String)it.next(); Object defValue = def.getDefaultValueAsObject(key); if (defValue == null) continue; if (defValue instanceof Long) { int iDefValue = ((Long)defValue).intValue(); int iValue = getIntParameter(key, iDefValue); if (iValue == iDefValue) propertiesMap.remove(key); } if (defValue instanceof String) { String sDefValue = defValue.toString(); String sValue = getStringParameter(key, sDefValue); if (sValue.compareTo(sDefValue) == 0) propertiesMap.remove(key); } } */ } public void load() { load("azureus.config"); } public void save(String filename) { if ( propertiesMap == null ){ // nothing to save, initialisation not complete return; } /** * Note - propertiesMap isn't synchronised! We'll clone the map * now, because we need to modify it. The BEncoding code will * create a new map object (TreeMap) because it needs to be * sorted, so we might as well do it here too. */ TreeMap properties_clone = new TreeMap(propertiesMap); // Remove any transient parameters. if (!this.transient_properties.isEmpty()) { properties_clone.keySet().removeAll(this.transient_properties); } FileUtil.writeResilientConfigFile( filename, properties_clone ); List listeners_copy; try{ this_mon.enter(); listeners_copy = new ArrayList( listeners ); }finally{ this_mon.exit(); } for (int i=0;i<listeners_copy.size();i++){ COConfigurationListener l = (COConfigurationListener)listeners_copy.get(i); if (l != null){ try{ l.configurationSaved(); }catch( Throwable e ){ Debug.printStackTrace( e ); } }else{ Debug.out("COConfigurationListener is null"); } } } public void save() { save("azureus.config"); } public void setDirty() { dirty_dispatcher.dispatch(); } public boolean isNewInstall() { return( ConfigurationChecker.isNewInstall()); } public Set getDefinedParameters() { return( propertiesMap.keySet()); } public boolean getBooleanParameter(String parameter, boolean defaultValue) { int defaultInt = defaultValue ? 1 : 0; int result = getIntParameter(parameter, defaultInt); return result == 0 ? false : true; } public boolean getBooleanParameter(String parameter) { ConfigurationDefaults def = ConfigurationDefaults.getInstance(); int result; try { result = getIntParameter(parameter, def.getIntParameter(parameter)); } catch (ConfigurationParameterNotFoundException e) { result = getIntParameter(parameter, ConfigurationDefaults.def_boolean); } return result == 0 ? false : true; } public boolean setParameter(String parameter, boolean value) { return setParameter(parameter, value ? 1 : 0); } private Long getLongParameterRaw(String parameter) { try { return (Long) propertiesMap.get(parameter); } catch (Exception e) { Debug.out( "Parameter '" + parameter + "' has incorrect type", e ); return null; } } public int getIntParameter(String parameter, int defaultValue) { Long tempValue = getLongParameterRaw(parameter); return tempValue != null ? tempValue.intValue() : defaultValue; } public int getIntParameter(String parameter) { ConfigurationDefaults def = ConfigurationDefaults.getInstance(); int result; try { result = getIntParameter(parameter, def.getIntParameter(parameter)); } catch (ConfigurationParameterNotFoundException e) { result = getIntParameter(parameter, ConfigurationDefaults.def_int); } return result; } public long getLongParameter(String parameter, long defaultValue) { Long tempValue = getLongParameterRaw(parameter); return tempValue != null ? tempValue.longValue() : defaultValue; } public long getLongParameter(String parameter) { ConfigurationDefaults def = ConfigurationDefaults.getInstance(); long result; try { result = getLongParameter(parameter, def.getLongParameter(parameter)); } catch (ConfigurationParameterNotFoundException e) { result = getLongParameter(parameter, ConfigurationDefaults.def_long); } return result; } private byte[] getByteParameterRaw(String parameter) { return (byte[]) propertiesMap.get(parameter); } public byte[] getByteParameter(String parameter) { ConfigurationDefaults def = ConfigurationDefaults.getInstance(); byte[] result; try { result = getByteParameter(parameter, def.getByteParameter(parameter)); } catch (ConfigurationParameterNotFoundException e) { result = getByteParameter(parameter, ConfigurationDefaults.def_bytes); } return result; } public byte[] getByteParameter(String parameter, byte[] defaultValue) { byte[] tempValue = getByteParameterRaw(parameter); return tempValue != null ? tempValue : defaultValue; } private String getStringParameter(String parameter, byte[] defaultValue) { byte[] bp = getByteParameter(parameter, defaultValue); if ( bp == null ){ bp = getByteParameter(parameter, null); } if (bp == null) return null; return bytesToString(bp); } public String getStringParameter(String parameter, String defaultValue) { String tempValue = getStringParameter(parameter, (byte[]) null); return tempValue != null ? tempValue : defaultValue; } public String getStringParameter(String parameter) { ConfigurationDefaults def = ConfigurationDefaults.getInstance(); String result; try { result = getStringParameter(parameter, def.getStringParameter(parameter)); } catch (ConfigurationParameterNotFoundException e) { result = getStringParameter(parameter, ConfigurationDefaults.def_String); } return result; } public StringList getStringListParameter(String parameter) { try { List rawList = (List) propertiesMap.get(parameter); if(rawList == null) return new StringListImpl(); return new StringListImpl(rawList); } catch(Exception e) { Debug.out( "Parameter '" + parameter + "' has incorrect type", e ); return new StringListImpl(); } } public boolean setParameter(String parameter,StringList value) { try { List encoded = new ArrayList(); List l = ((StringListImpl)value).getList(); for (int i=0;i<l.size();i++){ encoded.add( stringToBytes((String)l.get(i))); } propertiesMap.put(parameter,encoded); notifyParameterListeners(parameter); } catch(Exception e) { Debug.printStackTrace(e); return false; } return true; } public List getListParameter(String parameter, List def) { try { List rawList = (List) propertiesMap.get(parameter); if(rawList == null) return def; return rawList; } catch(Exception e) { Debug.out( "Parameter '" + parameter + "' has incorrect type", e ); return def; } } public boolean setParameter(String parameter,List value) { try { propertiesMap.put(parameter,value); notifyParameterListeners(parameter); } catch(Exception e) { Debug.printStackTrace(e); return false; } return true; } public Map getMapParameter(String parameter, Map def) { try { Map map = (Map) propertiesMap.get(parameter); if(map == null) return def; return map; } catch(Exception e) { Debug.out( "Parameter '" + parameter + "' has incorrect type", e ); return def; } } public boolean setParameter(String parameter,Map value) { try { propertiesMap.put(parameter,value); notifyParameterListeners(parameter); } catch(Exception e) { Debug.printStackTrace(e); return false; } return true; } public String getDirectoryParameter(String parameter) throws IOException { String dir = getStringParameter(parameter); if( dir.length() > 0 ) { File temp = new File(dir); if (!temp.exists()) { FileUtil.mkdirs(temp); } if (!temp.isDirectory()) { throw new IOException("Configuration error. This is not a directory: " + dir); } } return dir; } public float getFloatParameter(String parameter) { return( getFloatParameter( parameter, ConfigurationDefaults.def_float )); } public float getFloatParameter(String parameter, float def_val) { ConfigurationDefaults def = ConfigurationDefaults.getInstance(); try { Object o = propertiesMap.get(parameter); if (o instanceof Number) { return ((Number)o).floatValue(); } String s = getStringParameter(parameter); if (!s.equals(ConfigurationDefaults.def_String)) return Float.parseFloat(s); } catch (Exception e) { Debug.out( "Parameter '" + parameter + "' has incorrect type", e ); } try { return def.getFloatParameter(parameter); } catch (Exception e2) { return def_val; } } public boolean setParameter(String parameter, float defaultValue) { String newValue = String.valueOf(defaultValue); return setParameter(parameter, stringToBytes(newValue)); } public boolean setParameter(String parameter, int defaultValue) { Long newValue = new Long(defaultValue); try { Long oldValue = (Long) propertiesMap.put(parameter, newValue); return notifyParameterListenersIfChanged(parameter, newValue, oldValue); } catch (ClassCastException e) { // Issuing a warning here would be nice, but both logging and config stuff // at startup create potential deadlocks or stack overflows notifyParameterListeners(parameter); return true; } } public boolean setParameter(String parameter, long defaultValue) { Long newValue = new Long(defaultValue); try { Long oldValue = (Long) propertiesMap.put(parameter, newValue); return notifyParameterListenersIfChanged(parameter, newValue, oldValue); } catch (ClassCastException e) { // Issuing a warning here would be nice, but both logging and config stuff // at startup create potential deadlocks or stack overflows notifyParameterListeners(parameter); return true; } } public boolean setParameter(String parameter, byte[] defaultValue) { try { byte[] oldValue = (byte[]) propertiesMap.put(parameter, defaultValue); return notifyParameterListenersIfChanged(parameter, defaultValue, oldValue); } catch (ClassCastException e) { // Issuing a warning here would be nice, but both logging and config stuff // at startup create potential deadlocks or stack overflows notifyParameterListeners(parameter); return true; } } public boolean setParameter(String parameter, String defaultValue) { return setParameter(parameter, stringToBytes(defaultValue)); } /** * Returns true if a parameter with the given name exists. * @param key The name of the parameter to check. * @param explicit If <tt>true</tt>, we only check for a value which is * definitely stored explicitly, <tt>false</tt> means that we'll also * check against configuration defaults too. */ public boolean hasParameter(String key, boolean explicit) { // We have an explicit value set. if (propertiesMap.containsKey(key)) {return true;} // We have a default value set. if ((!explicit) && ConfigurationDefaults.getInstance().hasParameter(key)) { return true; } return false; } public boolean verifyParameter( String parameter, String value ) { List verifiers = ConfigurationDefaults.getInstance().getVerifiers(parameter); if ( verifiers != null ){ try{ for (int i=0;i<verifiers.size();i++){ ParameterVerifier verifier = (ParameterVerifier)verifiers.get(i); if ( verifier != null ){ try{ if ( !verifier.verify(parameter,value)){ return( false ); } }catch( Throwable e ){ Debug.printStackTrace( e ); } } } }catch( Throwable e ){ // we're not synchronized so possible but unlikely error here Debug.printStackTrace( e ); } } return( true ); } public boolean setRGBParameter(String parameter, int red, int green, int blue) { boolean bAnyChanged = false; bAnyChanged |= setParameter(parameter + ".red", red); bAnyChanged |= setParameter(parameter + ".green", green); bAnyChanged |= setParameter(parameter + ".blue", blue); if (bAnyChanged) notifyParameterListeners(parameter); return bAnyChanged; } public boolean setRGBParameter(String parameter, int[] rgb, boolean override) { boolean changed = false; if (rgb == null) { changed |= removeParameter(parameter + ".override"); changed |= removeParameter(parameter + ".red"); changed |= removeParameter(parameter + ".green"); changed |= removeParameter(parameter + ".blue"); } else { changed |= setParameter(parameter + ".override", override); changed |= setRGBParameter(parameter, rgb[0], rgb[1], rgb[2]); } if (changed) { notifyParameterListeners(parameter); } return changed; } // Sets a parameter back to its default public boolean setParameter(String parameter) throws ConfigurationParameterNotFoundException { ConfigurationDefaults def = ConfigurationDefaults.getInstance(); try { return setParameter(parameter, def.getIntParameter(parameter)); } catch (Exception e) { return setParameter(parameter, def.getStringParameter(parameter)); } } public Object getParameter( String name ) { Object value = propertiesMap.get( name ); if ( value == null ){ value = ConfigurationDefaults.getInstance().getParameter( name ); } return( value ); } /** * Set the raw parameter value to store in the properties map. This should * only be used by trusted callers, and has been added to support external * plugin config files. * * @param parameter Parameter name. * @param value A bencode-ably safe value. */ public void setParameterRawNoNotify(String parameter, Object value) { this.propertiesMap.put(parameter, value); } /** * Use this method to record a parameter as one which can be stored * here, but shouldn't be saved in azureus.config. Instead, some external * object should be responsible for the parameter's persistency (if it * should have any at all). */ public void registerTransientParameter(String param) { this.transient_properties.add(param); } /** * Remove the given configuration parameter completely. * @param parameter to remove * @return true if found and removed, false if not */ public boolean removeParameter( String parameter ) { boolean removed = propertiesMap.remove( parameter ) != null; if (removed) notifyParameterListeners(parameter); return removed; } public boolean removeRGBParameter(String parameter) { boolean bAnyChanged = false; bAnyChanged |= removeParameter(parameter + ".red"); bAnyChanged |= removeParameter(parameter + ".green"); bAnyChanged |= removeParameter(parameter + ".blue"); bAnyChanged |= removeParameter(parameter + ".override"); if (bAnyChanged) notifyParameterListeners(parameter); return bAnyChanged; } /** * Does the given parameter exist. * @param parameter to check * @return true if exists, false if not present */ public boolean doesParameterNonDefaultExist( String parameter ) { return propertiesMap.containsKey( parameter ); } private boolean notifyParameterListenersIfChanged(String parameter, Long newValue, Long oldValue) { if(oldValue == null || 0 != newValue.compareTo(oldValue)) { notifyParameterListeners(parameter); return true; } return false; } private boolean notifyParameterListenersIfChanged(String parameter, byte[] newValue, byte[] oldValue) { if(oldValue == null || !Arrays.equals(newValue, oldValue)) { notifyParameterListeners(parameter); return true; } return false; } private void notifyParameterListeners(String parameter) { LightHashSet parameterListener = (LightHashSet) parameterListeners.get(parameter); if (parameterListener == null) { return; } for (Iterator it = parameterListener.iterator(); it.hasNext();) { ParameterListener listener = (ParameterListener) it.next(); if (listener != null) { try { listener.parameterChanged(parameter); } catch (Throwable e) { // we're not synchronized so possible but unlikely error here Debug.printStackTrace(e); } } } } public void addParameterListener(String parameter, ParameterListener listener){ try{ this_mon.enter(); if(parameter == null || listener == null) return; LightHashSet parameterListener = (LightHashSet) parameterListeners.get(parameter); if(parameterListener == null) { parameterListeners.put(parameter, parameterListener = new LightHashSet(1)); } if(!parameterListener.contains(listener)) parameterListener.add(listener); }finally{ this_mon.exit(); } } public void removeParameterListener(String parameter, ParameterListener listener){ try{ this_mon.enter(); if(parameter == null || listener == null) return; LightHashSet parameterListener = (LightHashSet) parameterListeners.get(parameter); if(parameterListener != null) { parameterListener.remove(listener); } }finally{ this_mon.exit(); } } public void addListener(COConfigurationListener listener) { try{ this_mon.enter(); listeners.add(listener); }finally{ this_mon.exit(); } } public void removeListener(COConfigurationListener listener) { try{ this_mon.enter(); listeners.remove(listener); }finally{ this_mon.exit(); } } public void generate( IndentWriter writer ) { writer.println( "Configuration Details" ); try{ writer.indent(); writer.println( "System Properties" ); try{ writer.indent(); Properties props = System.getProperties(); Iterator it = new TreeSet( props.keySet()).iterator(); while(it.hasNext()){ String key = (String)it.next(); writer.println( key + "=" + props.get( key )); } }finally{ writer.exdent(); } writer.println( "Azureus Config" ); try{ writer.indent(); Iterator it = new TreeSet(propertiesMap.keySet()).iterator(); while( it.hasNext()){ String key = (String)it.next(); // don't dump crypto stuff if ( key.startsWith( CryptoManager.CRYPTO_CONFIG_PREFIX )){ continue; } Object value = propertiesMap.get(key); boolean bParamExists = ConfigurationDefaults.getInstance().doesParameterDefaultExist(key.toString()); if (!bParamExists){ key = "[NoDef] " + key; } if ( value instanceof Long ){ writer.println( key + "=" + value ); }else if ( value instanceof List ){ writer.println( key + "=" + value + "[list]" ); }else if ( value instanceof Map ){ writer.println( key + "=" + value + "[map]" ); }else if ( value instanceof byte[] ){ byte[] b = (byte[])value; boolean hex = false; for (int i=0;i<b.length;i++){ char c = (char)b[i]; if ( ! ( Character.isLetterOrDigit(c) || "`ÔøΩ\"ÔøΩ$%^&*()-_=+[{]};:'@#~,<.>/?'".indexOf(c) != -1 )){ hex = true; break; } } writer.println( key + "=" + (hex?ByteFormatter.nicePrint(b):bytesToString((byte[])value))); }else{ writer.println( key + "=" + value + "[unknown]" ); } } }finally{ writer.exdent(); } }finally{ writer.exdent(); } } protected static String bytesToString( byte[] bytes ) { try{ return( new String( bytes, Constants.DEFAULT_ENCODING )); }catch( Throwable e ){ return( new String(bytes)); } } protected static byte[] stringToBytes( String str ) { try{ return( str.getBytes( Constants.DEFAULT_ENCODING )); }catch( Throwable e ){ return( str.getBytes()); } } }

The table below shows all metrics for ConfigurationManager.java.

MetricValueDescription
BLOCKS176.00Number of blocks
BLOCK_COMMENT55.00Number of block comment lines
COMMENTS122.00Comment lines
COMMENT_DENSITY 0.25Comment density
COMPARISONS60.00Number of comparison operators
CYCLOMATIC154.00Cyclomatic complexity
DECL_COMMENTS 8.00Comments in declarations
DOC_COMMENT43.00Number of javadoc comment lines
ELOC486.00Effective lines of code
EXEC_COMMENTS16.00Comments in executable code
EXITS97.00Procedure exits
FUNCTIONS62.00Number of function declarations
HALSTEAD_DIFFICULTY84.74Halstead difficulty
HALSTEAD_EFFORT 0.00Halstead effort
INTERFACE_COMPLEXITY178.00Interface complexity
JAVA0001 1.00JAVA0001 Package name does not contain only lower case letters
JAVA0002 0.00JAVA0002 Package name does not begin with a top level domain name or country code
JAVA0003 0.00JAVA0003 Minimize use of on-demand (.*) imports
JAVA0004 0.00JAVA0004 Unnecessary import from java.lang
JAVA0005 1.00JAVA0005 Imports not in specified order
JAVA0006 0.00JAVA0006 Empty finally block
JAVA0007 0.00JAVA0007 Should not declare public field
JAVA0008 0.00JAVA0008 Empty catch block
JAVA0009 0.00JAVA0009 Protected member in final class
JAVA0010 0.00JAVA0010 Non-instantiable class does not contain a non-private static member
JAVA0011 0.00JAVA0011 Abstract class does not contain an abstract method
JAVA0012 0.00JAVA0012 Non-constructor method with same name as declaring class
JAVA0013 0.00JAVA0013 Non-blank final field is not static
JAVA0014 0.00JAVA0014 Class with only static members has non-private constructor
JAVA0015 0.00JAVA0015 Package class contains public nested type
JAVA0016 0.00JAVA0016 Abstract class contains public constructor
JAVA0017 0.00JAVA0017 Class name does not have required form
JAVA0018 0.00JAVA0018 Method name does not have required form
JAVA0019 0.00JAVA0019 Interface name does not have required form
JAVA0020 0.00JAVA0020 Field name does not have required form
JAVA0021 0.00JAVA0021 Interface method name does not have required form
JAVA0022 0.00JAVA0022 Static final field name does not have required form
JAVA0023 0.00JAVA0023 Empty finalize method
JAVA0024 0.00JAVA0024 Empty class
JAVA0025 0.00JAVA0025 Method override is empty
JAVA0026 0.00JAVA0026 Finalize method with parameters
JAVA0029 0.00JAVA0029 Private method not used
JAVA0030 0.00JAVA0030 Private field not used
JAVA0031 0.00JAVA0031 Case statement not properly closed
JAVA0032 0.00JAVA0032 Switch statement missing default
JAVA0033 0.00JAVA0033 default: not last case in switch statement
JAVA003411.00JAVA0034 Missing braces in if statement
JAVA0035 0.00JAVA0035 Missing braces in for statement
JAVA0036 0.00JAVA0036 Missing braces in while statement
JAVA0038 0.00JAVA0038 Non-case label in switch statement
JAVA0039 0.00JAVA0039 Break statement with label
JAVA0040 0.00JAVA0040 Switch statement contains N cases (maximum: M)
JAVA0041 0.00JAVA0041 Nested synchronized block
JAVA0042 0.00JAVA0042 Empty synchronized statement
JAVA0043 0.00JAVA0043 Inner class does not use outer class
JAVA0044 0.00JAVA0044 Serializable class with no instance variables
JAVA0045 0.00JAVA0045 Serializable class with only transient fields
JAVA0046 0.00JAVA0046 Name of class not derived from Exception ends with 'Exception'
JAVA0047 0.00JAVA0047 Serializable class derives from invalid base class
JAVA0048 0.00JAVA0048 Name of class derived from Exception does not end with 'Exception'
JAVA0049 3.00JAVA0049 Nested block at depth N (maximum: M)
JAVA0050 0.00JAVA0050 Class derives from java.lang.Error
JAVA0051 0.00JAVA0051 Class derives from java.lang.RuntimeException
JAVA0052 0.00JAVA0052 Class derives from java.lang.Throwable
JAVA0053 0.00JAVA0053 Unused label
JAVA0054 0.00JAVA0054 Inheritance depth N exceeds maximum M
JAVA0055 0.00JAVA0055 Class should be interface
JAVA0056 0.00JAVA0056 Unnecessary abstract modifier for interface or annotation
JAVA0057 0.00JAVA0057 Unnecessary default constructor
JAVA0058 0.00JAVA0058 Constructor calls super()
JAVA0059 0.00JAVA0059 Method override only calls super()
JAVA0061 0.00JAVA0061 Inaccessible member in anonymous class
JAVA0062 0.00JAVA0062 Public class missing public member or protected constructor
JAVA0063 0.00JAVA0063 Identifier name should not contain '$'
JAVA0064 0.00JAVA0064 N variations of identifier name (maximum: M)
JAVA0065 0.00JAVA0065 Unnecessary final modifier for method in final class
JAVA0066 0.00JAVA0066 Unnecessary modifier for interface nested type
JAVA0067 0.00JAVA0067 Array descriptor on identifier name
JAVA0068 0.00JAVA0068 Modifiers not declared in recommended order
JAVA0071 0.00JAVA0071 Strings compared with ==
JAVA0073 0.00JAVA0073 Integer division in floating-point context
JAVA0074 0.00JAVA0074 Use of Object.notify()
JAVA0075 0.00JAVA0075 Method parameter hides field
JAVA0076 0.00JAVA0076 Use of magic number
JAVA0077 0.00JAVA0077 Private field not used in declaring class
JAVA0078 0.00JAVA0078 Floating point values compared with ==
JAVA0079 0.00JAVA0079 Use of instance to reference static member
JAVA0080 0.00JAVA0080 Import declaration not used
JAVA0081 0.00JAVA0081 Boolean literal in comparison
JAVA0082 0.00JAVA0082 Unnecessary widening cast
JAVA0083 0.00JAVA0083 Unnecessary instanceof test
JAVA0084 0.00JAVA0084 Should use compound assignment operator
JAVA0085 0.00JAVA0085 Use of sun.* class
JAVA0087 0.00JAVA0087 Use of Thread.sleep()
JAVA0089 0.00JAVA0089 Use of restricted package
JAVA0092 0.00JAVA0092 Use of restricted type
JAVA0093 0.00JAVA0093 Redundant assignment
JAVA0094 0.00JAVA0094 Field hides a superclass field
JAVA0095 0.00JAVA0095 Uninitialized private field
JAVA0096 0.00JAVA0096 Field in nested class hides outer field
JAVA0098 0.00JAVA0098 Minimize use of implicit field initializers
JAVA0100 1.00JAVA0100 Class contains N non-final fields (maximum: M)
JAVA0101 0.00JAVA0101 Unnecessary modifier for field in interface
JAVA0102 0.00JAVA0102 Last statement in finalize() not super.finalize()
JAVA0103 0.00JAVA0103 Explicit call to finalize()
JAVA0104 0.00JAVA0104 finalize() only calls super.finalize()
JAVA0105 0.00JAVA0105 Duplicate import declaration
JAVA0106 0.00JAVA0106 Unnecessary import from current package
JAVA0108 1.00JAVA0108 Incorrect javadoc: no @param tag for 'parameter'
JAVA0109 0.00JAVA0109 Incorrect javadoc: no parameter 'parameter'
JAVA0110 1.00JAVA0110 Incorrect javadoc: no @return tag
JAVA0111 0.00JAVA0111 Incorrect javadoc: @return tag for void method
JAVA0112 0.00JAVA0112 Incorrect javadoc: no exception 'exception' in throws
JAVA0113 0.00JAVA0113 Incorrect javadoc: no @author tag
JAVA0114 1.00JAVA0114 Incorrect javadoc: no @version tag
JAVA0115 0.00JAVA0115 Incorrect javadoc: no @throws or @exception tag for 'exception'
JAVA0116 0.00JAVA0116 Missing javadoc: field 'field'
JAVA011747.00JAVA0117 Missing javadoc: method 'method'
JAVA0118 0.00JAVA0118 Missing javadoc: type 'type'
JAVA0119 0.00JAVA0119 Control variable changed within body of for loop
JAVA0123 0.00JAVA0123 Use all three components of for loop
JAVA0125 0.00JAVA0125 Continue statement with label
JAVA0126 0.00JAVA0126 Method declares unchecked exception in throws
JAVA0128 0.00JAVA0128 Public constructor in non-public class
JAVA0130 0.00JAVA0130 Non-static method does not use instance fields
JAVA0131 0.00JAVA0131 Compatible method does not override base
JAVA0132 0.00JAVA0132 Method overload with compatible signature
JAVA0133 0.00JAVA0133 Non-synchronized method overrides synchronized method
JAVA0135 0.00JAVA0135 Only one of Object.equals and Object.hashCode defined: missing 'method'
JAVA0136 1.00JAVA0136 N methods defined in class (maximum: M)
JAVA0137 0.00JAVA0137 Non-abstract class missing constructor
JAVA0138 0.00JAVA0138 N parameters defined for method (maximum: M)
JAVA0139 0.00JAVA0139 Definition of main other than public static void main(java.lang.String[])
JAVA0141 0.00JAVA0141 Unnecessary modifier for method in interface
JAVA0143 0.00JAVA0143 Synchronized method
JAVA0144 0.00JAVA0144 Line exceeds maximum M characters
JAVA01451447.00JAVA0145 Tab character used in source file
JAVA0150 0.00JAVA0150 java.lang.Error (or subclass) thrown
JAVA0153 0.00JAVA0153 Inefficient conversion of integer to string
JAVA0159 0.00JAVA0159 Inefficient conversion of string to integer
JAVA0160 0.00JAVA0160 Method does not throw specified exception
JAVA0161 0.00JAVA0161 Conditional wait() not in loop
JAVA0163 0.00JAVA0163 Empty statement
JAVA0165 0.00JAVA0165 Conflicting return statement in finally block
JAVA016616.00JAVA0166 Generic exception caught
JAVA0167 0.00JAVA0167 ThreadDeath not rethrown
JAVA0169 0.00JAVA0169 Unnecessary catch block: exception 'exception'
JAVA0170 6.00JAVA0170 Caught exception not derived from java.lang.Exception
JAVA0171 0.00JAVA0171 Unused local variable
JAVA0173 0.00JAVA0173 Unused method parameter
JAVA0174 0.00JAVA0174 Assigned local variable never used
JAVA0175 0.00JAVA0175 Successive assignment to variable
JAVA0176 0.00JAVA0176 Local variable name does not have required form
JAVA0177 6.00JAVA0177 Variable declaration missing initializer
JAVA0179 0.00JAVA0179 Local variable hides visible field
JAVA0233 0.00JAVA0233 Definition of serialVersionUID other than 'private static final long serialVersionUID'
JAVA0234 0.00JAVA0234 Class is Serializable but does not define serialVersionUID
JAVA0235 0.00JAVA0235 Class defines serialVersionUID but does not implement Serializable
JAVA0236 0.00JAVA0236 Attempt to clone an object which does not implement Cloneable
JAVA0237 0.00JAVA0237 Class implements Cloneable but does not have public clone method
JAVA0238 0.00JAVA0238 Clone method does not call super.clone()
JAVA0239 0.00JAVA0239 Class declares 'readObject' or 'writeObject' but does not implement Serializable
JAVA0240 0.00JAVA0240 Serializable class which declares readObject or writeObject but not both
JAVA0241 0.00JAVA0241 'readObject' or 'writeObject' should be declared private in Serializable class
JAVA0242 0.00JAVA0242 Transient field in non-Serializable class
JAVA0243 0.00JAVA0243 'readResolve' or 'writeReplace' should be declared private or protected
JAVA0244 0.00JAVA0244 Field or method name in subclass differs only by case from inherited field or method
JAVA0245 0.00JAVA0245 JUnit TestCase with non-trivial constructor
JAVA0246 0.00JAVA0246 JUnit assertXXX statement missing message parameter
JAVA0247 0.00JAVA0247 JUnit 'setUp()' and 'tearDown()' should call super method
JAVA0248 0.00JAVA0248 JUnit method 'setUp' or 'tearDown' with incorrect signature
JAVA0249 0.00JAVA0249 JUnit TestCase 'suite()' should be declared static
JAVA0250 0.00JAVA0250 JUnit TestCase declares testXXX method with incorrect signature
JAVA0251 0.00JAVA0251 Use '%n' for line breaks in printf/format for platform independence
JAVA0252 0.00JAVA0252 'enum' is a Java 1.5 reserved word
JAVA0253 0.00JAVA0253 Not all enum constants consumed in switch statement
JAVA0254 3.00JAVA0254 Use enhanced for loop construct instead of Iterator
JAVA0255 0.00JAVA0255 Result of method invocation not used
JAVA0256 0.00JAVA0256 Assignment of external collection/array to field
JAVA0257 0.00JAVA0257 Use of 'Constant Interface' anti-pattern
JAVA0258 0.00JAVA0258 Implement Iterable for foreach compatibility
JAVA0259 0.00JAVA0259 Return of collection/array field
JAVA0260 0.00JAVA0260 Use 'enum' instead of Enumerated Type pattern
JAVA0261 0.00JAVA0261 Use specialized Enum collection types
JAVA0262 0.00JAVA0262 Use of char in integer context
JAVA0263 0.00JAVA0263 Long literal ends with 'l' instead of 'L'
JAVA0264 0.00JAVA0264 Integer math in long context - check for overflow
JAVA0265 0.00JAVA0265 Use of Throwable.printStackTrace()
JAVA0266 0.00JAVA0266 Use of System.out
JAVA0267 0.00JAVA0267 Use of System.err
JAVA0269 0.00JAVA0269 Contents of StringBuffer never used
JAVA0270 1.00JAVA0270 Use Java 5.0 enhanced for loop construct to iterate over all elements in an array
JAVA0271 0.00JAVA0271 Minimize use of on-demand (.*) static imports
JAVA0272 0.00JAVA0272 Thread.run() called
JAVA0273 0.00JAVA0273 Non-final derivative of Thread calls start() in constructor
JAVA0274 0.00JAVA0274 Serializable class has a synchronized readObject()
JAVA0275 0.00JAVA0275 Serializable class has a synchronized writeObject() and no other synchronized methods
JAVA0276 0.00JAVA0276 Unnecessary use of String constructor
JAVA0277 0.00JAVA0277 Iterator.next() implementation does not throw NoSuchElementException
JAVA0278 0.00JAVA0278 Unnecessary use of Boolean constructor
JAVA0279 0.00JAVA0279 Serialization method readObject or readObjectNoData calls an overridable method
JAVA0280 0.00JAVA0280 IllegalMonitorStateException caught
JAVA0281 0.00JAVA0281 Iterator.next() not called in loop
JAVA0282 0.00JAVA0282 Call to Iterator.next() in loop which does not test Iterator.hasNext()
JAVA0283 0.00JAVA0283 Control variable not updated in loop body
JAVA0284 0.00JAVA0284 Explicit garbage collection
JAVA0285 0.00JAVA0285 Dereference of potentially null variable
JAVA0286 0.00JAVA0286 Dereference of null variable
JAVA0287 0.00JAVA0287 Unnecessary null check
JAVA0288 0.00JAVA0288 Inconsistent null check
LINES963.00Number of lines in the source file
LINE_COMMENT24.00Number of line comments
LOC640.00Lines of code
LOGICAL_LINES277.00Number of statements
LOOPS 7.00Number of loops
NEST_DEPTH 7.00Maximum nesting depth
OPERANDS1222.00Number of operands
OPERATORS2518.00Number of operators
PARAMS85.00Number of formal parameter declarations
PROGRAM_LENGTH3740.00Halstead program length
PROGRAM_VOCAB468.00Halstead program vocabulary
PROGRAM_VOLUME 0.00Halstead program volume
RETURNS93.00Number of return points from functions
SIZE25694.00Size of the file in bytes
UNIQUE_OPERANDS411.00Number of unique operands
UNIQUE_OPERATORS57.00Number of unique operators
WHITESPACE201.00Number of whitespace lines