MultiPeerUploader.java
| Index Score | ||
|---|---|---|
 |
 |
com.aelitis.azureus.core.networkmanager.impl |
 |
 |
Azureus |
View: Reasons, Metrics, Source Code
These are the metrics that contribute to the Enerjy Score for this file, ranked by impact. So the metrics listed at the top influence the score to a greater extent that the metrics listed at the bottom.
| Metric | Description | |
|---|---|---|
| JAVA0254 | JAVA0254 Use enhanced for loop construct instead of Iterator |  |
| JAVA0049 | JAVA0049 Nested block at depth N (maximum: M) | |
| LOOPS | Number of loops | |
| BLOCKS | Number of blocks | |
| JAVA0144 | JAVA0144 Line exceeds maximum M characters | |
| SIZE | Size of the file in bytes | |
| EXITS | Procedure exits | |
| COMPARISONS | Number of comparison operators | |
| NEST_DEPTH | Maximum nesting depth | |
| LOGICAL_LINES | Number of statements | |
| WHITESPACE | Number of whitespace lines | |
| CYCLOMATIC | Cyclomatic complexity | |
| OPERATORS | Number of operators | |
| PROGRAM_LENGTH | Halstead program length | |
| LOC | Lines of code | |
| LINES | Number of lines in the source file | |
| PROGRAM_VOCAB | Halstead program vocabulary | |
| ELOC | Effective lines of code | |
| JAVA0117 | JAVA0117 Missing javadoc: method 'method' | |
| UNIQUE_OPERANDS | Number of unique operands | |
| UNIQUE_OPERATORS | Number of unique operators | |
| JAVA0077 | JAVA0077 Private field not used in declaring class | |
| OPERANDS | Number of operands | |
| PROGRAM_VOLUME | Halstead program volume | |
| JAVA0126 | JAVA0126 Method declares unchecked exception in throws | |
| JAVA0110 | JAVA0110 Incorrect javadoc: no @return tag | |
| JAVA0108 | JAVA0108 Incorrect javadoc: no @param tag for 'parameter' | |
| DOC_COMMENT | Number of javadoc comment lines | |
/*
* Created on Sep 28, 2004
* Created by Alon Rohter
* Copyright (C) 2004, 2005, 2006 Aelitis, All Rights Reserved.
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License
* as published by the Free Software Foundation; either version 2
* of the License, or (at your option) any later version.
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
*
* AELITIS, SAS au capital de 46,603.30 euros
* 8 Allee Lenotre, La Grille Royale, 78600 Le Mesnil le Roi, France.
*
*/
package com.aelitis.azureus.core.networkmanager.impl;
import java.io.IOException;
import java.util.*;
import org.gudy.azureus2.core3.util.*;
import com.aelitis.azureus.core.networkmanager.*;
import com.aelitis.azureus.core.peermanager.messaging.*;
/**
* A rate-controlled write entity backed by multiple peer connections, with an
* emphasis on transmitting packets with full payloads, i.e. it writes to the
* transport in mss-sized chunks if at all possible. It also employs fair,
* round-robin write scheduling, where connections each take turns writing a
* single full packet per round.
*/
public class MultiPeerUploader implements RateControlledEntity {
private static final int FLUSH_CHECK_LOOP_TIME = 500; //500ms
private static final int FLUSH_WAIT_TIME = 3*1000; //3sec no-new-data wait before forcing write flush
private long last_flush_check_time = 0;
private final RateHandler rate_handler;
private boolean destroyed = false;
private final HashMap waiting_connections = new HashMap();
private final LinkedList ready_connections = new LinkedList();
private final AEMonitor lists_lock = new AEMonitor( "PacketFillingMultiPeerUploader:lists_lock" );
/**
* Create a new packet-filling multi-peer upload entity,
* rate-controlled by the given handler.
* @param rate_handler listener to handle upload rate limits
*/
public MultiPeerUploader( RateHandler rate_handler ) {
this.rate_handler = rate_handler;
}
/**
* Checks the connections in the waiting list to see if it's time to be force-flushed.
*/
private void flushCheck() {
long diff = SystemTime.getCurrentTime() - last_flush_check_time;
if( !destroyed && (diff > FLUSH_CHECK_LOOP_TIME || diff < 0 ) ) {
try { lists_lock.enter();
long current_time = SystemTime.getCurrentTime();
for( Iterator i = waiting_connections.entrySet().iterator(); i.hasNext(); ) {
Map.Entry entry = (Map.Entry)i.next();
PeerData peer_data = (PeerData)entry.getValue();
long wait_time = current_time - peer_data.last_message_added_time;
if( wait_time > FLUSH_WAIT_TIME || wait_time < 0 ) { //time to force flush
NetworkConnectionBase conn = (NetworkConnectionBase)entry.getKey();
if( conn.getOutgoingMessageQueue().getTotalSize() > 0 ) { //has data to flush
conn.getOutgoingMessageQueue().cancelQueueListener( peer_data.queue_listener ); //cancel the listener
i.remove(); //remove from the waiting list
addToReadyList( conn );
}
else { //no data, so reset flush wait time
peer_data.last_message_added_time = current_time;
}
}
}
}
finally { lists_lock.exit(); }
last_flush_check_time = SystemTime.getCurrentTime();
}
}
/**
* Destroy this upload entity.
* Note: Removes all peer connections in the process.
*/
public void destroy() {
destroyed = true;
try {
lists_lock.enter();
//remove and cancel all connections in waiting list
for( Iterator i = waiting_connections.entrySet().iterator(); i.hasNext(); ) {
Map.Entry entry = (Map.Entry)i.next();
NetworkConnectionBase conn = (NetworkConnectionBase)entry.getKey();
PeerData data = (PeerData)entry.getValue();
conn.getOutgoingMessageQueue().cancelQueueListener( data.queue_listener );
}
waiting_connections.clear();
//remove from ready list
ready_connections.clear();
}
finally {
lists_lock.exit();
}
}
/**
* Add the given connection to be managed by this upload entity.
* @param peer_connection to be write managed
*/
public void addPeerConnection( NetworkConnectionBase peer_connection ) {
int mss_size = peer_connection.getMssSize();
boolean has_urgent_data = peer_connection.getOutgoingMessageQueue().hasUrgentMessage();
int num_bytes_ready = peer_connection.getOutgoingMessageQueue().getTotalSize();
if( num_bytes_ready >= mss_size || has_urgent_data ) { //has a full packet's worth, or has urgent data
addToReadyList( peer_connection );
}
else { //has data to send, but not enough for a full packet
addToWaitingList( peer_connection );
}
}
/**
* Remove the given connection from this upload entity.
* @param peer_connection to be removed
* @return true if the connection was found and removed, false if not removed
*/
public boolean removePeerConnection( NetworkConnectionBase peer_connection ) {
try {
lists_lock.enter();
//look for the connection in the waiting list and cancel listener if found
PeerData peer_data = (PeerData)waiting_connections.remove( peer_connection );
if( peer_data != null ) {
peer_connection.getOutgoingMessageQueue().cancelQueueListener( peer_data.queue_listener );
return true;
}
//look for the connection in the ready list
if( ready_connections.remove( peer_connection ) ) {
return true;
}
return false;
}
finally {
lists_lock.exit();
}
}
//connections with less than a packet's worth of data
private void addToWaitingList( final NetworkConnectionBase conn ) {
final PeerData peer_data = new PeerData();
OutgoingMessageQueue.MessageQueueListener listener = new OutgoingMessageQueue.MessageQueueListener() {
public boolean messageAdded( Message message ) { return true; }
public void messageQueued( Message message ) { //connection now has more data to send
try {
lists_lock.enter();
if( waiting_connections.get( conn ) == null ) { //connection has already been removed from the waiting list
return; //stop further processing
}
int mss_size = conn.getMssSize();
boolean has_urgent_data = conn.getOutgoingMessageQueue().hasUrgentMessage();
int num_bytes_ready = conn.getOutgoingMessageQueue().getTotalSize();
if( num_bytes_ready >= mss_size || has_urgent_data ) { //has a full packet's worth, or has urgent data
waiting_connections.remove( conn ); //remove from waiting list
conn.getOutgoingMessageQueue().cancelQueueListener( this ); //cancel this listener
addToReadyList( conn );
}
else { //still not enough data for a full packet
if ( !peer_data.bumped ){
// only do this once to avoid the possibility that, for example, sending a have
// every 2.9 seconds can result in them being delayed for a significant amount
// of time (e.g. 60 seconds +...)
peer_data.bumped = true;
peer_data.last_message_added_time = SystemTime.getCurrentTime(); //update last message added time
}
}
}
finally {
lists_lock.exit();
}
}
public void
flush()
{
try{
lists_lock.enter();
if ( waiting_connections.remove( conn ) != null ){
conn.getOutgoingMessageQueue().cancelQueueListener( this );
addToReadyList( conn );
}
}finally{
lists_lock.exit();
}
}
public void messageRemoved( Message message ) {/*ignore*/}
public void messageSent( Message message ) {/*ignore*/}
public void protocolBytesSent( int byte_count ) {/*ignore*/}
public void dataBytesSent( int byte_count ) {/*ignore*/}
};
peer_data.queue_listener = listener; //attach listener
peer_data.last_message_added_time = SystemTime.getCurrentTime(); //start flush wait time
peer_data.bumped = false;
try {
lists_lock.enter();
waiting_connections.put( conn, peer_data ); //add to waiting list
conn.getOutgoingMessageQueue().registerQueueListener( listener ); //listen for added data
}
finally {
lists_lock.exit();
}
}
//connections ready to write
private void addToReadyList( final NetworkConnectionBase conn ) {
try {
lists_lock.enter();
ready_connections.addLast( conn ); //add to ready list
}
finally {
lists_lock.exit();
}
}
private int write( EventWaiter waiter, int num_bytes_to_write ) { //TODO: model this class after the simplicity of MultiPeerDownloader
if( num_bytes_to_write < 1 ) {
Debug.out( "num_bytes_to_write < 1" );
return 0; //not allowed to write
}
HashMap connections_to_notify_of_exception = new HashMap();
ArrayList manual_notifications = new ArrayList();
int num_bytes_remaining = num_bytes_to_write;
try {
lists_lock.enter();
int num_unusable_connections = 0;
while( num_bytes_remaining > 0 && num_unusable_connections < ready_connections.size() ) {
NetworkConnectionBase conn = (NetworkConnectionBase)ready_connections.removeFirst();
if( !conn.getTransportBase().isReadyForWrite( waiter ) ) { //not yet ready for writing
ready_connections.addLast( conn ); //re-add to end as currently unusable
num_unusable_connections++;
continue; //move on to the next connection
}
int total_size = conn.getOutgoingMessageQueue().getTotalSize();
if( total_size < 1 ) { //oops, all messages have been removed
addToWaitingList( conn );
continue; //move on to the next connection
}
int mss_size = conn.getMssSize();
int num_bytes_allowed = num_bytes_remaining > mss_size ? mss_size : num_bytes_remaining; //allow a single full packet at most
int num_bytes_available = total_size > mss_size ? mss_size : total_size; //allow a single full packet at most
if( num_bytes_allowed >= num_bytes_available ) { //we're allowed enough (for either a full packet or to drain any remaining data)
int written = 0;
try {
written = conn.getOutgoingMessageQueue().deliverToTransport( num_bytes_available, true );
if( written > 0 ) {
manual_notifications.add( conn ); //register it for manual listener notification
}
boolean has_urgent_data = conn.getOutgoingMessageQueue().hasUrgentMessage();
int remaining = conn.getOutgoingMessageQueue().getTotalSize();
if( remaining >= mss_size || has_urgent_data ) { //still has a full packet's worth, or has urgent data
ready_connections.addLast( conn ); //re-add to end for further writing
num_unusable_connections = 0; //reset the unusable count so that it has a chance to try this connection again in the loop
}
else { //connection does not have enough for a full packet, so remove and place into waiting list
addToWaitingList( conn );
}
}
catch( Throwable e ) { //write exception, so move to waiting list while it waits for removal
if( AEDiagnostics.TRACE_CONNECTION_DROPS ) {
if( e.getMessage() == null ) {
Debug.out( "null write exception message: ", e );
}
else {
if( e.getMessage().indexOf( "An existing connection was forcibly closed by the remote host" ) == -1 &&
e.getMessage().indexOf( "Connection reset by peer" ) == -1 &&
e.getMessage().indexOf( "Broken pipe" ) == -1 &&
e.getMessage().indexOf( "An established connection was aborted by the software in your host machine" ) == -1 ) {
System.out.println( "MP: write exception [" +conn.getTransportBase().getDescription()+ "]: " +e.getMessage() );
}
}
}
if (! (e instanceof IOException )){
Debug.printStackTrace(e);
}
connections_to_notify_of_exception.put( conn, e ); //do exception notification outside of sync'd block
addToWaitingList( conn );
}
num_bytes_remaining -= written;
}
else { //we're not allowed enough to maximize the packet payload
ready_connections.addLast( conn ); //re-add to end as currently unusable
num_unusable_connections++;
continue; //move on to the next connection
}
}
}
finally {
lists_lock.exit();
}
//manual queue listener notifications
for( int i=0; i < manual_notifications.size(); i++ ) {
NetworkConnectionBase conn = (NetworkConnectionBase)manual_notifications.get( i );
conn.getOutgoingMessageQueue().doListenerNotifications();
}
//exception notifications
for( Iterator i = connections_to_notify_of_exception.entrySet().iterator(); i.hasNext(); ) {
Map.Entry entry = (Map.Entry)i.next();
NetworkConnectionBase conn = (NetworkConnectionBase)entry.getKey();
Throwable exception = (Throwable)entry.getValue();
conn.notifyOfException( exception );
}
int num_bytes_written = num_bytes_to_write - num_bytes_remaining;
if( num_bytes_written > 0 ) {
rate_handler.bytesProcessed( num_bytes_written );
}
return num_bytes_written;
}
/**
* Does this entity have data ready for writing.
* @return true if it has data to send, false if empty
*/
/*
public boolean hasWriteDataAvailable() {
if( ready_connections.isEmpty() ) return false;
return true;
}
*/
private static class PeerData {
private OutgoingMessageQueue.MessageQueueListener queue_listener;
private long last_message_added_time;
private boolean bumped;
}
public long
getBytesReadyToWrite()
{
long total = 0;
try {
lists_lock.enter();
for( Iterator i = waiting_connections.keySet().iterator(); i.hasNext(); ) {
NetworkConnectionBase conn = (NetworkConnectionBase)i.next();
total += conn.getOutgoingMessageQueue().getTotalSize();
}
for( Iterator i = ready_connections.iterator(); i.hasNext(); ) {
NetworkConnectionBase conn = (NetworkConnectionBase)i.next();
total += conn.getOutgoingMessageQueue().getTotalSize();
}
}finally{
lists_lock.exit();
}
return( total );
}
public int
getConnectionCount()
{
return( waiting_connections.size() + ready_connections.size());
}
public int
getReadyConnectionCount(
EventWaiter waiter )
{
int total = 0;
try {
lists_lock.enter();
for( Iterator i = waiting_connections.keySet().iterator(); i.hasNext(); ) {
NetworkConnectionBase conn = (NetworkConnectionBase)i.next();
if ( conn.getTransportBase().isReadyForWrite(waiter)){
total++;
}
}
for( Iterator i = ready_connections.iterator(); i.hasNext(); ) {
NetworkConnectionBase conn = (NetworkConnectionBase)i.next();
if ( conn.getTransportBase().isReadyForWrite(waiter)){
total++;
}
}
}finally{
lists_lock.exit();
}
return( total );
}
//////////////// RateControlledWriteEntity implementation ////////////////////
public boolean canProcess( EventWaiter waiter ) {
flushCheck(); //since this method is called repeatedly from a loop, we can use it to check flushes
if( ready_connections.isEmpty() ) return false; //no data to send
if( rate_handler.getCurrentNumBytesAllowed() < 1/*NetworkManager.getTcpMssSize()*/ ) return false;
return true;
}
public boolean doProcessing( EventWaiter waiter ) {
int num_bytes_allowed = rate_handler.getCurrentNumBytesAllowed();
if( num_bytes_allowed < 1 ) return false;
return write( waiter, num_bytes_allowed ) > 0 ? true : false;
}
public int getPriority() {
return RateControlledEntity.PRIORITY_HIGH;
}
public String
getString()
{
StringBuffer str = new StringBuffer();
str.append( "MPU (" + waiting_connections.size() + "/" + ready_connections.size() + "): " );
str.append( "can_process=" + canProcess(null) + ",bytes_allowed=" + rate_handler.getCurrentNumBytesAllowed() + ", waiting=" );
try {
lists_lock.enter();
int num = 0;
for( Iterator i = waiting_connections.keySet().iterator(); i.hasNext(); ) {
NetworkConnectionBase conn = (NetworkConnectionBase)i.next();
if ( num++ > 0 ){
str.append( "," );
}
str.append( conn.getString());
}
str.append( ": ready=" );
num = 0;
for( Iterator i = ready_connections.iterator(); i.hasNext(); ) {
NetworkConnectionBase conn = (NetworkConnectionBase)i.next();
if ( num++ > 0 ){
str.append( "," );
}
str.append( conn.getString());
}
}finally{
lists_lock.exit();
}
return( str.toString());
}
}
The table below shows all metrics for MultiPeerUploader.java.
| Metric | Value | Description | |
|---|---|---|---|
| BLOCKS | 88.00 | Number of blocks | |
| BLOCK_COMMENT | 27.00 | Number of block comment lines | |
| COMMENTS | 71.00 | Comment lines | |
| COMMENT_DENSITY | 0.27 | Comment density | |
| COMPARISONS | 54.00 | Number of comparison operators | |
| CYCLOMATIC | 75.00 | Cyclomatic complexity | |
| DECL_COMMENTS | 12.00 | Comments in declarations | |
| DOC_COMMENT | 32.00 | Number of javadoc comment lines | |
| ELOC | 261.00 | Effective lines of code | |
| EXEC_COMMENTS | 7.00 | Comments in executable code | |
| EXITS | 57.00 | Procedure exits | |
| FUNCTIONS | 22.00 | Number of function declarations | |
| HALSTEAD_DIFFICULTY | 80.96 | Halstead difficulty | |
| HALSTEAD_EFFORT | 0.00 | Halstead effort | |
| INTERFACE_COMPLEXITY | 45.00 | Interface complexity | |
| JAVA0001 | 0.00 | JAVA0001 Package name does not contain only lower case letters | |
| JAVA0002 | 0.00 | JAVA0002 Package name does not begin with a top level domain name or country code | |
| JAVA0003 | 0.00 | JAVA0003 Minimize use of on-demand (.*) imports | |
| JAVA0004 | 0.00 | JAVA0004 Unnecessary import from java.lang | |
| JAVA0005 | 0.00 | JAVA0005 Imports not in specified order | |
| JAVA0006 | 0.00 | JAVA0006 Empty finally block | |
| JAVA0007 | 0.00 | JAVA0007 Should not declare public field | |
| JAVA0008 | 0.00 | JAVA0008 Empty catch block | |
| JAVA0009 | 0.00 | JAVA0009 Protected member in final class | |
| JAVA0010 | 0.00 | JAVA0010 Non-instantiable class does not contain a non-private static member | |
| JAVA0011 | 0.00 | JAVA0011 Abstract class does not contain an abstract method | |
| JAVA0012 | 0.00 | JAVA0012 Non-constructor method with same name as declaring class | |
| JAVA0013 | 0.00 | JAVA0013 Non-blank final field is not static | |
| JAVA0014 | 0.00 | JAVA0014 Class with only static members has non-private constructor | |
| JAVA0015 | 0.00 | JAVA0015 Package class contains public nested type | |
| JAVA0016 | 0.00 | JAVA0016 Abstract class contains public constructor | |
| JAVA0017 | 0.00 | JAVA0017 Class name does not have required form | |
| JAVA0018 | 0.00 | JAVA0018 Method name does not have required form | |
| JAVA0019 | 0.00 | JAVA0019 Interface name does not have required form | |
| JAVA0020 | 0.00 | JAVA0020 Field name does not have required form | |
| JAVA0021 | 0.00 | JAVA0021 Interface method name does not have required form | |
| JAVA0022 | 0.00 | JAVA0022 Static final field name does not have required form | |
| JAVA0023 | 0.00 | JAVA0023 Empty finalize method | |
| JAVA0024 | 0.00 | JAVA0024 Empty class | |
| JAVA0025 | 0.00 | JAVA0025 Method override is empty | |
| JAVA0026 | 0.00 | JAVA0026 Finalize method with parameters | |
| JAVA0029 | 0.00 | JAVA0029 Private method not used | |
| JAVA0030 | 0.00 | JAVA0030 Private field not used | |
| JAVA0031 | 0.00 | JAVA0031 Case statement not properly closed | |
| JAVA0032 | 0.00 | JAVA0032 Switch statement missing default | |
| JAVA0033 | 0.00 | JAVA0033 default: not last case in switch statement | |
| JAVA0034 | 3.00 | JAVA0034 Missing braces in if statement | |
| JAVA0035 | 0.00 | JAVA0035 Missing braces in for statement | |
| JAVA0036 | 0.00 | JAVA0036 Missing braces in while statement | |
| JAVA0038 | 0.00 | JAVA0038 Non-case label in switch statement | |
| JAVA0039 | 0.00 | JAVA0039 Break statement with label | |
| JAVA0040 | 0.00 | JAVA0040 Switch statement contains N cases (maximum: M) | |
| JAVA0041 | 0.00 | JAVA0041 Nested synchronized block | |
| JAVA0042 | 0.00 | JAVA0042 Empty synchronized statement | |
| JAVA0043 | 0.00 | JAVA0043 Inner class does not use outer class | |
| JAVA0044 | 0.00 | JAVA0044 Serializable class with no instance variables | |
| JAVA0045 | 0.00 | JAVA0045 Serializable class with only transient fields | |
| JAVA0046 | 0.00 | JAVA0046 Name of class not derived from Exception ends with 'Exception' | |
| JAVA0047 | 0.00 | JAVA0047 Serializable class derives from invalid base class | |
| JAVA0048 | 0.00 | JAVA0048 Name of class derived from Exception does not end with 'Exception' | |
| JAVA0049 | 7.00 | JAVA0049 Nested block at depth N (maximum: M) | |
| JAVA0050 | 0.00 | JAVA0050 Class derives from java.lang.Error | |
| JAVA0051 | 0.00 | JAVA0051 Class derives from java.lang.RuntimeException | |
| JAVA0052 | 0.00 | JAVA0052 Class derives from java.lang.Throwable | |
| JAVA0053 | 0.00 | JAVA0053 Unused label | |
| JAVA0054 | 0.00 | JAVA0054 Inheritance depth N exceeds maximum M | |
| JAVA0055 | 0.00 | JAVA0055 Class should be interface | |
| JAVA0056 | 0.00 | JAVA0056 Unnecessary abstract modifier for interface or annotation | |
| JAVA0057 | 0.00 | JAVA0057 Unnecessary default constructor | |
| JAVA0058 | 0.00 | JAVA0058 Constructor calls super() | |
| JAVA0059 | 0.00 | JAVA0059 Method override only calls super() | |
| JAVA0061 | 0.00 | JAVA0061 Inaccessible member in anonymous class | |
| JAVA0062 | 0.00 | JAVA0062 Public class missing public member or protected constructor | |
| JAVA0063 | 0.00 | JAVA0063 Identifier name should not contain '$' | |
| JAVA0064 | 0.00 | JAVA0064 N variations of identifier name (maximum: M) | |
| JAVA0065 | 0.00 | JAVA0065 Unnecessary final modifier for method in final class | |
| JAVA0066 | 0.00 | JAVA0066 Unnecessary modifier for interface nested type | |
| JAVA0067 | 0.00 | JAVA0067 Array descriptor on identifier name | |
| JAVA0068 | 0.00 | JAVA0068 Modifiers not declared in recommended order | |
| JAVA0071 | 0.00 | JAVA0071 Strings compared with == | |
| JAVA0073 | 0.00 | JAVA0073 Integer division in floating-point context | |
| JAVA0074 | 0.00 | JAVA0074 Use of Object.notify() | |
| JAVA0075 | 0.00 | JAVA0075 Method parameter hides field | |
| JAVA0076 | 0.00 | JAVA0076 Use of magic number | |
| JAVA0077 | 1.00 | JAVA0077 Private field not used in declaring class | |
| JAVA0078 | 0.00 | JAVA0078 Floating point values compared with == | |
| JAVA0079 | 0.00 | JAVA0079 Use of instance to reference static member | |
| JAVA0080 | 0.00 | JAVA0080 Import declaration not used | |
| JAVA0081 | 0.00 | JAVA0081 Boolean literal in comparison | |
| JAVA0082 | 0.00 | JAVA0082 Unnecessary widening cast | |
| JAVA0083 | 0.00 | JAVA0083 Unnecessary instanceof test | |
| JAVA0084 | 0.00 | JAVA0084 Should use compound assignment operator | |
| JAVA0085 | 0.00 | JAVA0085 Use of sun.* class | |
| JAVA0087 | 0.00 | JAVA0087 Use of Thread.sleep() | |
| JAVA0089 | 0.00 | JAVA0089 Use of restricted package | |
| JAVA0092 | 0.00 | JAVA0092 Use of restricted type | |
| JAVA0093 | 0.00 | JAVA0093 Redundant assignment | |
| JAVA0094 | 0.00 | JAVA0094 Field hides a superclass field | |
| JAVA0095 | 0.00 | JAVA0095 Uninitialized private field | |
| JAVA0096 | 0.00 | JAVA0096 Field in nested class hides outer field | |
| JAVA0098 | 0.00 | JAVA0098 Minimize use of implicit field initializers | |
| JAVA0100 | 0.00 | JAVA0100 Class contains N non-final fields (maximum: M) | |
| JAVA0101 | 0.00 | JAVA0101 Unnecessary modifier for field in interface | |
| JAVA0102 | 0.00 | JAVA0102 Last statement in finalize() not super.finalize() | |
| JAVA0103 | 0.00 | JAVA0103 Explicit call to finalize() | |
| JAVA0104 | 0.00 | JAVA0104 finalize() only calls super.finalize() | |
| JAVA0105 | 0.00 | JAVA0105 Duplicate import declaration | |
| JAVA0106 | 0.00 | JAVA0106 Unnecessary import from current package | |
| JAVA0108 | 0.00 | JAVA0108 Incorrect javadoc: no @param tag for 'parameter' | |
| JAVA0109 | 0.00 | JAVA0109 Incorrect javadoc: no parameter 'parameter' | |
| JAVA0110 | 0.00 | JAVA0110 Incorrect javadoc: no @return tag | |
| JAVA0111 | 0.00 | JAVA0111 Incorrect javadoc: @return tag for void method | |
| JAVA0112 | 0.00 | JAVA0112 Incorrect javadoc: no exception 'exception' in throws | |
| JAVA0113 | 1.00 | JAVA0113 Incorrect javadoc: no @author tag | |
| JAVA0114 | 1.00 | JAVA0114 Incorrect javadoc: no @version tag | |
| JAVA0115 | 0.00 | JAVA0115 Incorrect javadoc: no @throws or @exception tag for 'exception' | |
| JAVA0116 | 0.00 | JAVA0116 Missing javadoc: field 'field' | |
| JAVA0117 | 0.00 | JAVA0117 Missing javadoc: method 'method' | |
| JAVA0118 | 0.00 | JAVA0118 Missing javadoc: type 'type' | |
| JAVA0119 | 0.00 | JAVA0119 Control variable changed within body of for loop | |
| JAVA0123 | 0.00 | JAVA0123 Use all three components of for loop | |
| JAVA0125 | 0.00 | JAVA0125 Continue statement with label | |
| JAVA0126 | 0.00 | JAVA0126 Method declares unchecked exception in throws | |
| JAVA0128 | 0.00 | JAVA0128 Public constructor in non-public class | |
| JAVA0130 | 0.00 | JAVA0130 Non-static method does not use instance fields | |
| JAVA0131 | 0.00 | JAVA0131 Compatible method does not override base | |
| JAVA0132 | 0.00 | JAVA0132 Method overload with compatible signature | |
| JAVA0133 | 0.00 | JAVA0133 Non-synchronized method overrides synchronized method | |
| JAVA0135 | 0.00 | JAVA0135 Only one of Object.equals and Object.hashCode defined: missing 'method' | |
| JAVA0136 | 0.00 | JAVA0136 N methods defined in class (maximum: M) | |
| JAVA0137 | 1.00 | JAVA0137 Non-abstract class missing constructor | |
| JAVA0138 | 0.00 | JAVA0138 N parameters defined for method (maximum: M) | |
| JAVA0139 | 0.00 | JAVA0139 Definition of main other than public static void main(java.lang.String[]) | |
| JAVA0141 | 0.00 | JAVA0141 Unnecessary modifier for method in interface | |
| JAVA0143 | 0.00 | JAVA0143 Synchronized method | |
| JAVA0144 | 4.00 | JAVA0144 Line exceeds maximum M characters | |
| JAVA0145 | 250.00 | JAVA0145 Tab character used in source file | |
| JAVA0150 | 0.00 | JAVA0150 java.lang.Error (or subclass) thrown | |
| JAVA0153 | 0.00 | JAVA0153 Inefficient conversion of integer to string | |
| JAVA0159 | 0.00 | JAVA0159 Inefficient conversion of string to integer | |
| JAVA0160 | 0.00 | JAVA0160 Method does not throw specified exception | |
| JAVA0161 | 0.00 | JAVA0161 Conditional wait() not in loop | |
| JAVA0163 | 0.00 | JAVA0163 Empty statement | |
| JAVA0165 | 0.00 | JAVA0165 Conflicting return statement in finally block | |
| JAVA0166 | 1.00 | JAVA0166 Generic exception caught | |
| JAVA0167 | 0.00 | JAVA0167 ThreadDeath not rethrown | |
| JAVA0169 | 0.00 | JAVA0169 Unnecessary catch block: exception 'exception' | |
| JAVA0170 | 1.00 | JAVA0170 Caught exception not derived from java.lang.Exception | |
| JAVA0171 | 0.00 | JAVA0171 Unused local variable | |
| JAVA0173 | 0.00 | JAVA0173 Unused method parameter | |
| JAVA0174 | 0.00 | JAVA0174 Assigned local variable never used | |
| JAVA0175 | 0.00 | JAVA0175 Successive assignment to variable | |
| JAVA0176 | 0.00 | JAVA0176 Local variable name does not have required form | |
| JAVA0177 | 0.00 | JAVA0177 Variable declaration missing initializer | |
| JAVA0179 | 0.00 | JAVA0179 Local variable hides visible field | |
| JAVA0233 | 0.00 | JAVA0233 Definition of serialVersionUID other than 'private static final long serialVersionUID' | |
| JAVA0234 | 0.00 | JAVA0234 Class is Serializable but does not define serialVersionUID | |
| JAVA0235 | 0.00 | JAVA0235 Class defines serialVersionUID but does not implement Serializable | |
| JAVA0236 | 0.00 | JAVA0236 Attempt to clone an object which does not implement Cloneable | |
| JAVA0237 | 0.00 | JAVA0237 Class implements Cloneable but does not have public clone method | |
| JAVA0238 | 0.00 | JAVA0238 Clone method does not call super.clone() | |
| JAVA0239 | 0.00 | JAVA0239 Class declares 'readObject' or 'writeObject' but does not implement Serializable | |
| JAVA0240 | 0.00 | JAVA0240 Serializable class which declares readObject or writeObject but not both | |
| JAVA0241 | 0.00 | JAVA0241 'readObject' or 'writeObject' should be declared private in Serializable class | |
| JAVA0242 | 0.00 | JAVA0242 Transient field in non-Serializable class | |
| JAVA0243 | 0.00 | JAVA0243 'readResolve' or 'writeReplace' should be declared private or protected | |
| JAVA0244 | 0.00 | JAVA0244 Field or method name in subclass differs only by case from inherited field or method | |
| JAVA0245 | 0.00 | JAVA0245 JUnit TestCase with non-trivial constructor | |
| JAVA0246 | 0.00 | JAVA0246 JUnit assertXXX statement missing message parameter | |
| JAVA0247 | 0.00 | JAVA0247 JUnit 'setUp()' and 'tearDown()' should call super method | |
| JAVA0248 | 0.00 | JAVA0248 JUnit method 'setUp' or 'tearDown' with incorrect signature | |
| JAVA0249 | 0.00 | JAVA0249 JUnit TestCase 'suite()' should be declared static | |
| JAVA0250 | 0.00 | JAVA0250 JUnit TestCase declares testXXX method with incorrect signature | |
| JAVA0251 | 0.00 | JAVA0251 Use '%n' for line breaks in printf/format for platform independence | |
| JAVA0252 | 0.00 | JAVA0252 'enum' is a Java 1.5 reserved word | |
| JAVA0253 | 0.00 | JAVA0253 Not all enum constants consumed in switch statement | |
| JAVA0254 | 8.00 | JAVA0254 Use enhanced for loop construct instead of Iterator | |
| JAVA0255 | 0.00 | JAVA0255 Result of method invocation not used | |
| JAVA0256 | 0.00 | JAVA0256 Assignment of external collection/array to field | |
| JAVA0257 | 0.00 | JAVA0257 Use of 'Constant Interface' anti-pattern | |
| JAVA0258 | 0.00 | JAVA0258 Implement Iterable for foreach compatibility | |
| JAVA0259 | 0.00 | JAVA0259 Return of collection/array field | |
| JAVA0260 | 0.00 | JAVA0260 Use 'enum' instead of Enumerated Type pattern | |
| JAVA0261 | 0.00 | JAVA0261 Use specialized Enum collection types | |
| JAVA0262 | 0.00 | JAVA0262 Use of char in integer context | |
| JAVA0263 | 0.00 | JAVA0263 Long literal ends with 'l' instead of 'L' | |
| JAVA0264 | 0.00 | JAVA0264 Integer math in long context - check for overflow | |
| JAVA0265 | 0.00 | JAVA0265 Use of Throwable.printStackTrace() | |
| JAVA0266 | 1.00 | JAVA0266 Use of System.out | |
| JAVA0267 | 0.00 | JAVA0267 Use of System.err | |
| JAVA0269 | 0.00 | JAVA0269 Contents of StringBuffer never used | |
| JAVA0270 | 0.00 | JAVA0270 Use Java 5.0 enhanced for loop construct to iterate over all elements in an array | |
| JAVA0271 | 0.00 | JAVA0271 Minimize use of on-demand (.*) static imports | |
| JAVA0272 | 0.00 | JAVA0272 Thread.run() called | |
| JAVA0273 | 0.00 | JAVA0273 Non-final derivative of Thread calls start() in constructor | |
| JAVA0274 | 0.00 | JAVA0274 Serializable class has a synchronized readObject() | |
| JAVA0275 | 0.00 | JAVA0275 Serializable class has a synchronized writeObject() and no other synchronized methods | |
| JAVA0276 | 0.00 | JAVA0276 Unnecessary use of String constructor | |
| JAVA0277 | 0.00 | JAVA0277 Iterator.next() implementation does not throw NoSuchElementException | |
| JAVA0278 | 0.00 | JAVA0278 Unnecessary use of Boolean constructor | |
| JAVA0279 | 0.00 | JAVA0279 Serialization method readObject or readObjectNoData calls an overridable method | |
| JAVA0280 | 0.00 | JAVA0280 IllegalMonitorStateException caught | |
| JAVA0281 | 0.00 | JAVA0281 Iterator.next() not called in loop | |
| JAVA0282 | 0.00 | JAVA0282 Call to Iterator.next() in loop which does not test Iterator.hasNext() | |
| JAVA0283 | 0.00 | JAVA0283 Control variable not updated in loop body | |
| JAVA0284 | 0.00 | JAVA0284 Explicit garbage collection | |
| JAVA0285 | 0.00 | JAVA0285 Dereference of potentially null variable | |
| JAVA0286 | 0.00 | JAVA0286 Dereference of null variable | |
| JAVA0287 | 0.00 | JAVA0287 Unnecessary null check | |
| JAVA0288 | 0.00 | JAVA0288 Inconsistent null check | |
| LINES | 559.00 | Number of lines in the source file | |
| LINE_COMMENT | 12.00 | Number of line comments | |
| LOC | 346.00 | Lines of code | |
| LOGICAL_LINES | 184.00 | Number of statements | |
| LOOPS | 11.00 | Number of loops | |
| NEST_DEPTH | 8.00 | Maximum nesting depth | |
| OPERANDS | 708.00 | Number of operands | |
| OPERATORS | 1519.00 | Number of operators | |
| PARAMS | 16.00 | Number of formal parameter declarations | |
| PROGRAM_LENGTH | 2227.00 | Halstead program length | |
| PROGRAM_VOCAB | 274.00 | Halstead program vocabulary | |
| PROGRAM_VOLUME | 0.00 | Halstead program volume | |
| RETURNS | 29.00 | Number of return points from functions | |
| SIZE | 18416.00 | Size of the file in bytes | |
| UNIQUE_OPERANDS | 223.00 | Number of unique operands | |
| UNIQUE_OPERATORS | 51.00 | Number of unique operators | |
| WHITESPACE | 142.00 | Number of whitespace lines | |