TriMeshBeveler.java
| Index Score | ||
|---|---|---|
 |
 |
artofillusion |
 |
|
Art of Illusion |
View: Reasons, Metrics, Source Code
These are the metrics that contribute to the Enerjy Score for this file, ranked by impact. So the metrics listed at the top influence the score to a greater extent that the metrics listed at the bottom.
| Metric | Description | |
|---|---|---|
| LOOPS | Number of loops |  |
| COMPARISONS | Number of comparison operators | |
| JAVA0034 | JAVA0034 Missing braces in if statement | |
| PROGRAM_LENGTH | Halstead program length | |
| OPERANDS | Number of operands | |
| OPERATORS | Number of operators | |
| JAVA0067 | JAVA0067 Array descriptor on identifier name | |
| EXEC_COMMENTS | Comments in executable code | |
| LINE_COMMENT | Number of line comments | |
| CYCLOMATIC | Cyclomatic complexity | |
| LOGICAL_LINES | Number of statements | |
| JAVA0035 | JAVA0035 Missing braces in for statement | |
| JAVA0177 | JAVA0177 Variable declaration missing initializer | |
| LOC | Lines of code | |
| ELOC | Effective lines of code | |
| SIZE | Size of the file in bytes | |
| LINES | Number of lines in the source file | |
| JAVA0049 | JAVA0049 Nested block at depth N (maximum: M) | |
| JAVA0108 | JAVA0108 Incorrect javadoc: no @param tag for 'parameter' | |
| BLOCKS | Number of blocks | |
| JAVA0270 | JAVA0270 Use Java 5.0 enhanced for loop construct to iterate over all elements in an array | |
| UNIQUE_OPERANDS | Number of unique operands | |
| PROGRAM_VOCAB | Halstead program vocabulary | |
| JAVA0078 | JAVA0078 Floating point values compared with == | |
| JAVA0119 | JAVA0119 Control variable changed within body of for loop | |
| JAVA0110 | JAVA0110 Incorrect javadoc: no @return tag | |
| WHITESPACE | Number of whitespace lines | |
| JAVA0081 | JAVA0081 Boolean literal in comparison | |
| JAVA0173 | JAVA0173 Unused method parameter | |
| JAVA0076 | JAVA0076 Use of magic number | |
| JAVA0163 | JAVA0163 Empty statement | |
| NEST_DEPTH | Maximum nesting depth | |
| JAVA0036 | JAVA0036 Missing braces in while statement | |
| JAVA0130 | JAVA0130 Non-static method does not use instance fields | |
| JAVA0075 | JAVA0075 Method parameter hides field | |
| JAVA0116 | JAVA0116 Missing javadoc: field 'field' | |
| UNIQUE_OPERATORS | Number of unique operators | |
| PROGRAM_VOLUME | Halstead program volume | |
| JAVA0032 | JAVA0032 Switch statement missing default | |
| JAVA0126 | JAVA0126 Method declares unchecked exception in throws | |
| EXITS | Procedure exits | |
| JAVA0171 | JAVA0171 Unused local variable | |
| JAVA0117 | JAVA0117 Missing javadoc: method 'method' | |
| DOC_COMMENT | Number of javadoc comment lines | |
| FUNCTIONS | Number of function declarations | |
/* Copyright (C) 1999-2004 by Peter Eastman
This program is free software; you can redistribute it and/or modify it under the
terms of the GNU General Public License as published by the Free Software
Foundation; either version 2 of the License, or (at your option) any later version.
This program is distributed in the hope that it will be useful, but WITHOUT ANY
WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A
PARTICULAR PURPOSE. See the GNU General Public License for more details. */
package artofillusion;
import artofillusion.math.*;
import artofillusion.object.*;
import artofillusion.object.TriangleMesh.*;
import artofillusion.texture.*;
import java.util.Vector;
/** TriMeshBeveler defines methods for beveling/extruding a TriangleMesh. */
public class TriMeshBeveler
{
private TriangleMesh origMesh, mesh;
private boolean selected[], newSelection[];
private int mode;
private Vec3 faceInsets[][], faceNormal[];
private Vector newIndex;
public static final int BEVEL_FACES = 0;
public static final int BEVEL_FACE_GROUPS = 1;
public static final int BEVEL_EDGES = 2;
public static final int BEVEL_VERTICES = 3;
public TriMeshBeveler(TriangleMesh theMesh, boolean selection[], int bevelMode)
{
origMesh = theMesh;
selected = selection;
mode = bevelMode;
if (mode < 0 || mode > 3)
throw new IllegalArgumentException();
}
/**
* Construct a new mesh by beveling and extruding the original one.
*
* @param height the extrude height
* @param width the bevel width
*/
public TriangleMesh bevelMesh(double height, double width)
{
switch (mode)
{
case BEVEL_FACES:
return bevelIndividualFaces(height, width);
case BEVEL_FACE_GROUPS:
return bevelFacesAsGroup(height, width);
case BEVEL_EDGES:
return bevelEdges(height, width);
case BEVEL_VERTICES:
return bevelVertices(height, width);
}
return null;
}
/**
* Construct a new mesh, beveling each face individually.
*
* @param height the extrude height
* @param width the bevel width
*/
private TriangleMesh bevelIndividualFaces(double height, double width)
{
mesh = (TriangleMesh) origMesh.duplicate();
if (width == 0.0 && height == 0.0)
{
newSelection = selected;
return mesh;
}
Vertex v[] = (Vertex []) mesh.getVertices();
Edge e[] = mesh.getEdges();
Face f[] = mesh.getFaces();
int i, j;
Vector face = new Vector(), vert = new Vector();
newIndex = new Vector();
findVertexInsets(height, width);
// All old vertices will be in the new mesh, so first copy them over.
for (i = 0; i < v.length; i++)
vert.addElement(v[i]);
// Create the new list of faces.
for (i = 0; i < f.length; i++)
{
if (selected[i])
{
j = vert.size();
vert.addElement(offsetVertex(mesh, v[f[i].v1], faceInsets[i][0]));
vert.addElement(offsetVertex(mesh, v[f[i].v2], faceInsets[i][1]));
vert.addElement(offsetVertex(mesh, v[f[i].v3], faceInsets[i][2]));
newIndex.addElement(new Integer(face.size()));
face.addElement(new int [] {j, j+1, j+2, i});
face.addElement(new int [] {f[i].v1, f[i].v2, j, i});
face.addElement(new int [] {j, f[i].v2, j+1, i});
face.addElement(new int [] {f[i].v2, f[i].v3, j+1, i});
face.addElement(new int [] {j+1, f[i].v3, j+2, i});
face.addElement(new int [] {f[i].v3, f[i].v1, j+2, i});
face.addElement(new int [] {j+2, f[i].v1, j, i});
}
else
face.addElement(new int [] {f[i].v1, f[i].v2, f[i].v3, i});
}
prepareMesh(mesh, face, vert, null);
// Copy over smoothness values for edges.
Edge newe[] = mesh.getEdges();
for (i = 0; i < e.length; i++)
for (j = 0; j < newe.length; j++)
if ((e[i].v1 == newe[j].v1 && e[i].v2 == newe[j].v2) ||
(e[i].v1 == newe[j].v2 && e[i].v2 == newe[j].v1))
{
newe[j].smoothness = e[i].smoothness;
break;
}
// Record which faces should be selected.
newSelection = new boolean [mesh.getFaces().length];
for (i = 0; i < newIndex.size(); i++)
newSelection[((Integer) newIndex.elementAt(i)).intValue()] = true;
return mesh;
}
/** Find the list of selected faces, and for each one, calculate a displacement for each vertex. */
private void findVertexInsets(double height, double width)
{
Vertex v[] = (Vertex []) mesh.getVertices();
Face f[] = mesh.getFaces();
double length, dot;
Vec3 e1, e2, e3, normal;
int i;
faceInsets = new Vec3 [f.length][];
for (i = 0; i < f.length; i++)
if (selected[i])
{
faceInsets[i] = new Vec3 [3];
e1 = v[f[i].v2].r.minus(v[f[i].v1].r);
e2 = v[f[i].v3].r.minus(v[f[i].v2].r);
e3 = v[f[i].v1].r.minus(v[f[i].v3].r);
e1.normalize();
e2.normalize();
e3.normalize();
normal = e1.cross(e2);
length = normal.length();
if (length == 0.0) // A degenerate triangle.
faceInsets[i][0] = faceInsets[i][1] = faceInsets[i][2] = new Vec3();
else
{
normal.scale(height/length);
dot = -e1.dot(e3);
faceInsets[i][0] = e1.minus(e3).times(width/Math.sqrt(1-dot*dot)).plus(normal);
dot = -e2.dot(e1);
faceInsets[i][1] = e2.minus(e1).times(width/Math.sqrt(1-dot*dot)).plus(normal);
dot = -e3.dot(e2);
faceInsets[i][2] = e3.minus(e2).times(width/Math.sqrt(1-dot*dot)).plus(normal);
}
}
}
/**
* Construct a new mesh, beveling all selected faces as a group.
*
* @param height the extrude height
* @param width the bevel width
*/
private TriangleMesh bevelFacesAsGroup(double height, double width)
{
mesh = (TriangleMesh) origMesh.duplicate();
if (width == 0.0 && height == 0.0)
{
newSelection = selected;
return mesh;
}
Vertex v[] = (Vertex []) mesh.getVertices();
Edge e[] = mesh.getEdges();
Face f1, f2, f[] = mesh.getFaces();
int i, j, k, m, n, newface[][], vertFace[][], numVertFaces[], tempFace[], bev[];
int group[], touchCount[], groupCount;
Vec3 temp = new Vec3();
Vector face = new Vector(), vert = new Vector(), bevel = new Vector();
boolean someSelected[] = new boolean [v.length], allSelected[] = new boolean [v.length];
boolean touching[][], inGroup[], beveled[] = new boolean [e.length];
double coeff[][] = new double [3][3], rhs[] = new double [3];
newIndex = new Vector();
findEdgeInsets(height, width);
// First copy over the old faces and vertices. (Some of these will be modified later.)
for (i = 0; i < v.length; i++)
vert.addElement(v[i]);
for (i = 0; i < f.length; i++)
face.addElement(new int [] {f[i].v1, f[i].v2, f[i].v3, i});
// Each vertex goes into one of three categories: NONE of the faces touching it are
// selected, ALL of the faces touching it are selected, or (the complicated case) SOME
// of the faces touching it are selected.
for (i = 0; i < v.length; i++)
allSelected[i] = true;
for (i = 0; i < f.length; i++)
{
if (selected[i])
someSelected[f[i].v1] = someSelected[f[i].v2] = someSelected[f[i].v3] = true;
else
allSelected[f[i].v1] = allSelected[f[i].v2] = allSelected[f[i].v3] = false;
}
// For each vertex, build a list of all the selected faces that touch it.
vertFace = new int [v.length][];
numVertFaces = new int [v.length];
for (i = 0; i < f.length; i++)
if (selected[i])
{
numVertFaces[f[i].v1]++;
numVertFaces[f[i].v2]++;
numVertFaces[f[i].v3]++;
}
for (i = 0; i < v.length; i++)
{
vertFace[i] = new int [numVertFaces[i]];
numVertFaces[i] = 0;
}
for (i = 0; i < f.length; i++)
if (selected[i])
{
vertFace[f[i].v1][numVertFaces[f[i].v1]++] = i;
vertFace[f[i].v2][numVertFaces[f[i].v2]++] = i;
vertFace[f[i].v3][numVertFaces[f[i].v3]++] = i;
}
// If ALL or NONE of the faces touching a vertex are selected, everything is simple.
// If SOME but not all are selected, things get complicated. We will need to keep the
// original vertex, but also create a displaced one. Furthermore, the selected faces
// may not all touch each other (that is, share edges). In this case, we need to sort
// the selected faces into groups which touch each other, and there will be a different
// displaced vertex for each group.
for (i = 0; i < v.length; i++)
{
if (allSelected[i])
{
// Find the new position for this vertex. It is not on the boundary of the
// selection, so we don't need to worry about insets. Ideally, we would like
// it to be the correct height from every one of the faces, but in general
// this is not possible. We choose the position to minimize the sum of the
// squared height deviations.
for (j = 0; j < 3; j++)
rhs[j] = coeff[j][0] = coeff[j][1] = coeff[j][2] = 0.0;
for (j = 0; j < numVertFaces[i]; j++)
{
coeff[0][0] += faceNormal[vertFace[i][j]].x * faceNormal[vertFace[i][j]].x;
coeff[0][1] += faceNormal[vertFace[i][j]].x * faceNormal[vertFace[i][j]].y;
coeff[0][2] += faceNormal[vertFace[i][j]].x * faceNormal[vertFace[i][j]].z;
coeff[1][1] += faceNormal[vertFace[i][j]].y * faceNormal[vertFace[i][j]].y;
coeff[1][2] += faceNormal[vertFace[i][j]].y * faceNormal[vertFace[i][j]].z;
coeff[2][2] += faceNormal[vertFace[i][j]].z * faceNormal[vertFace[i][j]].z;
rhs[0] += height*faceNormal[vertFace[i][j]].x;
rhs[1] += height*faceNormal[vertFace[i][j]].y;
rhs[2] += height*faceNormal[vertFace[i][j]].z;
newIndex.addElement(new Integer(vertFace[i][j]));
}
coeff[1][0] = coeff[0][1];
coeff[2][0] = coeff[0][2];
coeff[2][1] = coeff[1][2];
SVD.solve(coeff, rhs, 1e-3);
temp.set(rhs[0], rhs[1], rhs[2]);
vert.setElementAt(offsetVertex(mesh, (Vertex) vert.elementAt(i), temp), i);
}
else if (someSelected[i])
{
// Find which faces directly touch each other.
touching = new boolean [numVertFaces[i]][numVertFaces[i]];
for (j = 1; j < numVertFaces[i]; j++)
for (k = 0; k < j; k++)
{
f1 = f[vertFace[i][j]];
f2 = f[vertFace[i][k]];
if (f1.e1 == f2.e1 || f1.e1 == f2.e2 || f1.e1 == f2.e3 ||
f1.e2 == f2.e1 || f1.e2 == f2.e2 || f1.e2 == f2.e3 ||
f1.e3 == f2.e1 || f1.e3 == f2.e2 || f1.e3 == f2.e3)
touching[j][k] = touching[k][j] = true;
}
// Count the number of other faces each face is touching.
touchCount = new int [numVertFaces[i]];
for (j = 0; j < numVertFaces[i]; j++)
for (k = 0; k < numVertFaces[i]; k++)
touchCount[j] += touching[j][k] ? 1 : 0;
// Find the groups.
inGroup = new boolean [numVertFaces[i]];
group = new int [numVertFaces[i]];
while (true)
{
groupCount = 0;
// Find the first face in the new group.
for (j = 0; j < numVertFaces[i] && (inGroup[j] == true || touchCount[j] > 1); j++);
if (j == numVertFaces[i])
break;
inGroup[j] = true;
group[0] = j;
groupCount = 1;
// Find the rest of the faces in the group.
while (touchCount[j] > (groupCount == 1 ? 0 : 1))
for (j = 0; j < numVertFaces[i]; j++)
if (!inGroup[j] && touching[group[groupCount-1]][j])
{
group[groupCount++] = j;
inGroup[j] = true;
break;
}
// We also will need to add two faces to define the beveled edge at the
// start of the group, and another two at the end of the group. We can't
// actually add them yet, since not all vertices have been determined, so
// instead we record the edges which need this.
if (groupCount == 1)
{
// If the group consists of only one face, then simply find the two edges
// which share this vertex.
f1 = f[vertFace[i][group[0]]];
m = n = -1;
if (e[f1.e1].v1 == i || e[f1.e1].v2 == i)
{
bevel.addElement(new int [] {vertFace[i][group[0]], f1.e1});
m = 0;
}
if (e[f1.e2].v1 == i || e[f1.e2].v2 == i)
{
bevel.addElement(new int [] {vertFace[i][group[0]], f1.e2});
if (m == -1)
m = 1;
else
n = 1;
}
if (e[f1.e3].v1 == i || e[f1.e3].v2 == i)
{
bevel.addElement(new int [] {vertFace[i][group[0]], f1.e3});
n = 2;
}
}
else
{
// We must find the edge of the first face which 1) shares this vertex,
// and 2) is not shared by the second face.
f1 = f[vertFace[i][group[0]]];
f2 = f[vertFace[i][group[1]]];
if ((e[f1.e1].v1 == i || e[f1.e1].v2 == i) && f2.e1 != f1.e1 && f2.e2 != f1.e1 && f2.e3 != f1.e1)
{
bevel.addElement(new int [] {vertFace[i][group[0]], f1.e1});
m = 0;
}
else if ((e[f1.e2].v1 == i || e[f1.e2].v2 == i) && f2.e1 != f1.e2 && f2.e2 != f1.e2 && f2.e3 != f1.e2)
{
bevel.addElement(new int [] {vertFace[i][group[0]], f1.e2});
m = 1;
}
else
{
bevel.addElement(new int [] {vertFace[i][group[0]], f1.e3});
m = 2;
}
// Similarly for the last face.
f1 = f[vertFace[i][group[groupCount-1]]];
f2 = f[vertFace[i][group[groupCount-2]]];
if ((e[f1.e1].v1 == i || e[f1.e1].v2 == i) && f2.e1 != f1.e1 && f2.e2 != f1.e1 && f2.e3 != f1.e1)
{
bevel.addElement(new int [] {vertFace[i][group[groupCount-1]], f1.e1});
n = 0;
}
else if ((e[f1.e2].v1 == i || e[f1.e2].v2 == i) && f2.e1 != f1.e2 && f2.e2 != f1.e2 && f2.e3 != f1.e2)
{
bevel.addElement(new int [] {vertFace[i][group[groupCount-1]], f1.e2});
n = 1;
}
else
{
bevel.addElement(new int [] {vertFace[i][group[groupCount-1]], f1.e3});
n = 2;
}
}
// Find the displaced vertex for this group. Ideally, we would like to
// satisfy both the inset (width) and extrude (height) constraints for both
// the first and last triangles in the group, but in general this is not
// possible. We settle for getting the insets, and the average of the two
// heights.
coeff[0][0] = faceInsets[vertFace[i][group[0]]][m].x;
coeff[0][1] = faceInsets[vertFace[i][group[0]]][m].y;
coeff[0][2] = faceInsets[vertFace[i][group[0]]][m].z;
coeff[1][0] = faceInsets[vertFace[i][group[groupCount-1]]][n].x;
coeff[1][1] = faceInsets[vertFace[i][group[groupCount-1]]][n].y;
coeff[1][2] = faceInsets[vertFace[i][group[groupCount-1]]][n].z;
coeff[2][0] = faceNormal[vertFace[i][group[0]]].x + faceNormal[vertFace[i][group[groupCount-1]]].x;
coeff[2][1] = faceNormal[vertFace[i][group[0]]].y + faceNormal[vertFace[i][group[groupCount-1]]].y;
coeff[2][2] = faceNormal[vertFace[i][group[0]]].z + faceNormal[vertFace[i][group[groupCount-1]]].z;
rhs[0] = rhs[1] = width;
rhs[2] = 2.0*height;
SVD.solve(coeff, rhs, 1e-3);
temp.set(rhs[0], rhs[1], rhs[2]);
vert.addElement(offsetVertex(mesh, (Vertex) vert.elementAt(i), temp));
// Modify the faces to use the new vertex.
k = vert.size()-1;
for (j = 0; j < groupCount; j++)
{
tempFace = (int []) face.elementAt(vertFace[i][group[j]]);
f1 = f[vertFace[i][group[j]]];
if (f1.v1 == i)
tempFace[0] = k;
else if (f1.v2 == i)
tempFace[1] = k;
else
tempFace[2] = k;
newIndex.addElement(new Integer(vertFace[i][group[j]]));
}
}
}
}
// Whew! Done with that. Now we need to add two faces for each edge which is at the
// end of a group.
for (i = 0; i < bevel.size(); i++)
{
bev = (int []) bevel.elementAt(i);
if (beveled[bev[1]])
continue;
beveled[bev[1]] = true;
j = e[bev[1]].v1;
k = e[bev[1]].v2;
if ((f[bev[0]].v1 == k && f[bev[0]].v2 == j) ||
(f[bev[0]].v2 == k && f[bev[0]].v3 == j) ||
(f[bev[0]].v3 == k && f[bev[0]].v1 == j))
{
m = j;
j = k;
k = m;
}
tempFace = (int []) face.elementAt(bev[0]);
if (f[bev[0]].v1 == j)
m = tempFace[0];
else if (f[bev[0]].v2 == j)
m = tempFace[1];
else
m = tempFace[2];
if (f[bev[0]].v1 == k)
n = tempFace[0];
else if (f[bev[0]].v2 == k)
n = tempFace[1];
else
n = tempFace[2];
face.addElement(new int [] {j, k, m, bev[0]});
face.addElement(new int [] {m, k, n, bev[0]});
}
// There! Nothing left to do but construct the new mesh.
prepareMesh(mesh, face, vert, null);
// Copy over smoothness values for edges.
Edge newe[] = mesh.getEdges();
for (i = 0; i < e.length; i++)
for (j = 0; j < newe.length; j++)
if ((e[i].v1 == newe[j].v1 && e[i].v2 == newe[j].v2) ||
(e[i].v1 == newe[j].v2 && e[i].v2 == newe[j].v1))
{
newe[j].smoothness = e[i].smoothness;
break;
}
// Record which faces should be selected.
newSelection = new boolean [mesh.getFaces().length];
for (i = 0; i < newIndex.size(); i++)
newSelection[((Integer) newIndex.elementAt(i)).intValue()] = true;
return mesh;
}
/** Find the list of selected faces, and for each one, calculate a displacement for each edge. */
private void findEdgeInsets(double height, double width)
{
Vertex v[] = (Vertex []) mesh.getVertices();
Face f[] = mesh.getFaces();
double length, dot;
Vec3 e1, e2, e3;
int i;
faceInsets = new Vec3 [f.length][];
faceNormal = new Vec3 [f.length];
for (i = 0; i < f.length; i++)
if (selected[i])
{
faceInsets[i] = new Vec3 [3];
e1 = v[f[i].v2].r.minus(v[f[i].v1].r);
e2 = v[f[i].v3].r.minus(v[f[i].v2].r);
e3 = v[f[i].v1].r.minus(v[f[i].v3].r);
e1.normalize();
e2.normalize();
e3.normalize();
faceNormal[i] = e1.cross(e2);
length = faceNormal[i].length();
if (length == 0.0) // A degenerate triangle.
faceInsets[i][0] = faceInsets[i][1] = faceInsets[i][2] = faceNormal[i] = new Vec3();
else
{
faceNormal[i].scale(1.0/length);
dot = -e1.dot(e2);
faceInsets[i][0] = e2.plus(e1.times(dot));
faceInsets[i][0].normalize();
dot = -e2.dot(e3);
faceInsets[i][1] = e3.plus(e2.times(dot));
faceInsets[i][1].normalize();
dot = -e3.dot(e1);
faceInsets[i][2] = e1.plus(e3.times(dot));
faceInsets[i][2].normalize();
}
}
}
/** Given one vertex, create another one which is offset from it. */
private Vertex offsetVertex(TriangleMesh mesh, Vertex v, Vec3 offset)
{
Vertex vert = mesh.new Vertex(v);
vert.r.add(offset);
vert.edges = 0;
vert.firstEdge = -1;
return vert;
}
/**
* Construct a new mesh, beveling each selected vertex.
*
* @param height the extrude height
* @param width the bevel width
*/
private TriangleMesh bevelVertices(double height, double width)
{
mesh = (TriangleMesh) origMesh.duplicate();
if (width == 0.0)
{
newSelection = selected;
return mesh;
}
Vertex v[] = (Vertex []) mesh.getVertices();
Edge e[] = mesh.getEdges();
Face f[] = mesh.getFaces();
Vec3 norm[] = mesh.getNormals();
int vertIndex[] = new int [v.length];
int extraVertIndex[][] = new int [v.length][], vertEdgeIndex[][] = new int [v.length][];
boolean forward[] = new boolean [v.length];
Vector face = new Vector(), vert = new Vector();
// Create the vertices of the new mesh.
for (int i = 0; i < v.length; i++)
{
if (!selected[i])
{
// Just copy over this vertex.
vertIndex[i] = vert.size();
vert.addElement(v[i]);
continue;
}
// Look at the edges intersecting this vertex, and determine how far along them to bevel.
int edges[] = v[i].getEdges();
vertEdgeIndex[i] = edges;
Vec3 edgeDir[] = new Vec3 [edges.length];
double dot[] = new double [edges.length];
double minDot = 1.0;
for (int j = 0; j < edges.length; j++)
{
edgeDir[j] = v[e[edges[j]].v2].r.minus(v[e[edges[j]].v1].r);
edgeDir[j].normalize();
if (e[edges[j]].v2 == i)
edgeDir[j].scale(-1.0);
dot[j] = Math.abs(norm[i].dot(edgeDir[j]));
if (dot[j] < minDot)
minDot = dot[j];
}
double bevelDist = width/Math.tan(Math.acos(minDot));
// Position the beveled vertices.
extraVertIndex[i] = new int [edges.length];
for (int j = 0; j < edges.length; j++)
{
extraVertIndex[i][j] = vert.size();
double dist = (dot[j] == 0.0 ? width : bevelDist/dot[j]);
vert.addElement(offsetVertex(mesh, v[i], edgeDir[j].times(dist)));
}
// Position the central vertex.
boolean convex = (norm[i].dot(edgeDir[0]) < 0.0);
vertIndex[i] = vert.size();
vert.addElement(offsetVertex(mesh, v[i], norm[i].times(convex ? height-bevelDist : height+bevelDist)));
// Determine which way the vertices are ordered.
Edge e0 = e[edges[0]];
Edge e1 = e[edges[1]];
Face fc = f[e0.f1];
int v0 = (e0.v1 == i ? e0.v2 : e0.v1);
int v1 = (e1.v1 == i ? e1.v2 : e1.v1);
forward[i] = ((fc.v1 == v0 && fc.v3 == v1) || (fc.v2 == v0 && fc.v1 == v1) || (fc.v3 == v0 && fc.v2 == v1));
}
// We now have all the vertices. Next, create the faces. We begin with the ones
// corresponding to the faces of the original mesh.
for (int i = 0; i < f.length; i++)
{
Face fc = f[i];
// After beveling, the three vertices of the original face may have turned into as many
// as six vertices. Find them, in order.
int origVert[] = new int [] {fc.v1, fc.v2, fc.v2, fc.v3, fc.v3, fc.v1};
int origEdge[] = new int [] {fc.e1, fc.e1, fc.e2, fc.e2, fc.e3, fc.e3};
int newVert[] = new int [6];
int numVert = 0;
for (int j = 0; j < origVert.length; j++)
{
int index = vertIndex[origVert[j]];
if (selected[origVert[j]])
{
int orig = origVert[j];
for (int k = 0; k < vertEdgeIndex[orig].length; k++)
if (vertEdgeIndex[orig][k] == origEdge[j])
{
index = extraVertIndex[orig][k];
break;
}
}
if (numVert == 0 || (index != newVert[numVert-1] && index != newVert[0]))
newVert[numVert++] = index;
}
// We now need to triangulate the vertices and create new faces.
if (numVert == 3)
face.addElement(new int [] {newVert[0], newVert[1], newVert[2], i});
else if (numVert == 4)
{
face.addElement(new int [] {newVert[0], newVert[1], newVert[2], i});
face.addElement(new int [] {newVert[0], newVert[2], newVert[3], i});
}
else
for (int step = 1; 2*step < numVert; step *= 2)
{
int start;
for (start = 0; start+2*step < numVert; start += 2*step)
face.addElement(new int [] {newVert[start], newVert[start+step], newVert[start+2*step], i});
if (start+step < numVert)
face.addElement(new int [] {newVert[start], newVert[start+step], newVert[0], i});
}
}
// Next create the faces capping the vertices that have just been beveled.
for (int i = 0; i < v.length; i++)
{
if (!selected[i])
continue;
for (int j = 0; j < extraVertIndex[i].length; j++)
{
int prev = (j == 0 ? vertEdgeIndex[i].length-1 : j-1);
if (forward[i])
face.addElement(new int [] {extraVertIndex[i][j], extraVertIndex[i][prev], vertIndex[i], -1});
else
face.addElement(new int [] {extraVertIndex[i][prev], extraVertIndex[i][j], vertIndex[i], -1});
}
}
// Create the mesh.
prepareMesh(mesh, face, vert, vertIndex);
// Copy over smoothness values for edges.
Edge newe[] = mesh.getEdges();
for (int i = 0; i < e.length; i++)
{
int v1 = vertIndex[e[i].v1];
int v2 = vertIndex[e[i].v2];
for (int j = 0; j < newe.length; j++)
if ((v1 == newe[j].v1 && v2 == newe[j].v2) ||
(v1 == newe[j].v2 && v2 == newe[j].v1))
{
newe[j].smoothness = e[i].smoothness;
break;
}
}
// Record which vertices should be selected.
newSelection = new boolean [mesh.getVertices().length];
for (int i = 0; i < vertIndex.length; i++)
if (selected[i])
newSelection[vertIndex[i]] = true;
return mesh;
}
/**
* Construct a new mesh, beveling each selected edges.
*
* @param height the extrude height
* @param width the bevel width
*/
private TriangleMesh bevelEdges(double height, double width)
{
mesh = (TriangleMesh) origMesh.duplicate();
if (width == 0.0)
{
newSelection = selected;
return mesh;
}
Vertex v[] = (Vertex []) mesh.getVertices();
Edge e[] = mesh.getEdges();
Face f[] = mesh.getFaces();
Vec3 norm[] = mesh.getNormals();
int vertIndex[] = new int [v.length];
int extraVertIndex[][] = new int [v.length][];
int faceVertIndex[][] = new int [v.length][];
boolean forward[] = new boolean [v.length];
Vector face = new Vector(), vert = new Vector();
// Find the bevel and extrude directions for every edge.
Vec3 edgeDir[] = new Vec3 [e.length];
Vec3 bevelDir[] = new Vec3 [e.length];
Vec3 extrudeDir[] = new Vec3 [e.length];
for (int i = 0; i < e.length; i++)
{
edgeDir[i] = v[e[i].v2].r.minus(v[e[i].v1].r);
if (selected[i])
{
Vec3 avgNorm = norm[e[i].v1].plus(norm[e[i].v2]);
bevelDir[i] = edgeDir[i].cross(avgNorm);
bevelDir[i].normalize();
extrudeDir[i] = bevelDir[i].cross(edgeDir[i]);
extrudeDir[i].normalize();
}
}
// Count the selected edges touching each vertex.
int vertEdgeIndex[][] = new int [v.length][];
int vertEdgeCount[] = new int [v.length];
for (int i = 0; i < v.length; i++)
{
vertEdgeIndex[i] = v[i].getEdges();
for (int j = 0; j < vertEdgeIndex[i].length; j++)
if (selected[vertEdgeIndex[i][j]])
vertEdgeCount[i]++;
}
// Record the faces touching each vertex.
int vertFaceIndex[][] = new int [v.length][];
for (int i = 0; i < v.length; i++)
{
vertFaceIndex[i] = new int [vertEdgeIndex[i].length];
int e0 = vertEdgeIndex[i][0];
int e1 = vertEdgeIndex[i][1];
int prev = e[e0].f1;
if (f[prev].e1 == e1 || f[prev].e2 == e1 || f[prev].e3 == e1)
prev = e[e0].f2;
for (int j = 0; j < vertFaceIndex[i].length; j++)
{
Edge ed = e[vertEdgeIndex[i][j]];
vertFaceIndex[i][j] = (ed.f1 == prev ? ed.f2 : ed.f1);
prev = vertFaceIndex[i][j];
}
}
// Create the vertices of the new mesh.
for (int i = 0; i < v.length; i++)
{
if (vertEdgeCount[i] == 0)
{
// Just copy over this vertex.
vertIndex[i] = vert.size();
vert.addElement(v[i]);
continue;
}
// Look at the edges intersecting this vertex, and determine how far along them to bevel.
int edges[] = vertEdgeIndex[i];
double offsetDist[] = new double [edges.length];
for (int j = 0; j < edges.length; j++)
if (selected[edges[j]])
{
// Calculate the offsets based on beveling this particular edge.
Vec3 offsetDir = extrudeDir[edges[j]];
double dot[] = new double [edges.length];
double minDot = 1.0;
for (int k = 0; k < edges.length; k++)
if (!selected[edges[k]])
{
Vec3 dir = edgeDir[vertEdgeIndex[i][k]];
dot[k] = Math.abs(offsetDir.dot(dir));
if (dot[k] < minDot)
minDot = dot[k];
}
double bevelDist = width/Math.tan(Math.acos(minDot));
for (int k = 0; k < edges.length; k++)
if (!selected[edges[k]])
{
double dist = (dot[k] == 0.0 ? width : bevelDist/dot[k]);
if (dist > offsetDist[k])
offsetDist[k] = dist;
}
}
// Position the beveled vertices.
extraVertIndex[i] = new int [edges.length];
for (int j = 0; j < edges.length; j++)
{
if (selected[edges[j]])
{
extraVertIndex[i][j] = -1;
continue;
}
extraVertIndex[i][j] = vert.size();
double dist = offsetDist[j];
if (e[edges[j]].v2 == i)
dist = -dist;
vert.addElement(offsetVertex(mesh, v[i], edgeDir[edges[j]].times(dist)));
}
// If two adjacent edges were both beveled, we need to create a new vertex between them.
faceVertIndex[i] = new int [edges.length];
for (int j = 0; j < edges.length; j++)
{
int next = j+1;
if (next == edges.length)
next = (e[edges[0]].f2 == -1 ? -1 : 0);
if (next == -1 || (!selected[edges[j]] && !selected[edges[next]]))
continue;
if (!selected[edges[j]])
{
faceVertIndex[i][j] = extraVertIndex[i][j];
continue;
}
if (!selected[edges[next]])
{
faceVertIndex[i][j] = extraVertIndex[i][next];
continue;
}
faceVertIndex[i][j] = vert.size();
// Find the vertex position.
double dist1 = offsetDist[j];
if (e[edges[j]].v2 == i)
dist1 = -dist1;
double dist2 = offsetDist[next];
if (e[edges[next]].v2 == i)
dist2 = -dist2;
double edgeDot = edgeDir[edges[j]].dot(edgeDir[edges[next]]);
double m[][] = new double [][] {{1.0, edgeDot}, {edgeDot, 1.0}};
double b[] = new double [] {dist1, dist2};
SVD.solve(m, b);
Vec3 offset = edgeDir[edges[j]].times(b[0]).plus(edgeDir[edges[next]].times(b[1]));
vert.addElement(offsetVertex(mesh, v[i], offset));
}
// Determine which way the vertices are ordered.
Edge e0 = e[edges[0]];
Edge e1 = e[edges[1]];
Face fc = f[e0.f1];
int v0 = (e0.v1 == i ? e0.v2 : e0.v1);
int v1 = (e1.v1 == i ? e1.v2 : e1.v1);
forward[i] = ((fc.v1 == v0 && fc.v3 == v1) || (fc.v2 == v0 && fc.v1 == v1) || (fc.v3 == v0 && fc.v2 == v1));
}
// For each end of each beveled edge, calculate an "ideal position" which is midway between the
// vertices on either side of it.
Vec3 idealEndPos[][] = new Vec3 [e.length][];
for (int i = 0; i < e.length; i++)
{
if (!selected[i])
continue;
// Find the vertices surrounding this edge.
int faceList[] = new int [e[i].f2 == -1 ? 1 : 2];
faceList[0] = e[i].f1;
if (faceList.length > 1)
faceList[1] = e[i].f2;
int vi[] = new int [4];
for (int j = 0; j < faceList.length; j++)
{
int v1 = -1, v2 = -1;
for (int k = 0; k < vertFaceIndex[e[i].v1].length && v1 == -1; k++)
if (vertFaceIndex[e[i].v1][k] == faceList[j])
v1 = faceVertIndex[e[i].v1][k];
for (int k = 0; k < vertFaceIndex[e[i].v2].length && v2 == -1; k++)
if (vertFaceIndex[e[i].v2][k] == faceList[j])
v2 = faceVertIndex[e[i].v2][k];
vi[j*2] = v1;
vi[j*2+1] = v2;
}
// Calculate the ideal end positions.
idealEndPos[i] = new Vec3 [2];
if (faceList.length == 1)
{
Vec3 delta;
double d;
delta = ((Vertex) vert.elementAt(vi[0])).r.minus(v[e[i].v1].r);
d = delta.dot(extrudeDir[i]);
idealEndPos[i][0] = v[e[i].v1].r.plus(extrudeDir[i].times(d));
delta = ((Vertex) vert.elementAt(vi[1])).r.minus(v[e[i].v2].r);
d = delta.dot(extrudeDir[i]);
idealEndPos[i][1] = v[e[i].v2].r.plus(extrudeDir[i].times(d));
}
else
{
idealEndPos[i][0] = ((Vertex) vert.elementAt(vi[0])).r.plus(((Vertex) vert.elementAt(vi[2])).r).times(0.5);
idealEndPos[i][1] = ((Vertex) vert.elementAt(vi[1])).r.plus(((Vertex) vert.elementAt(vi[3])).r).times(0.5);
}
}
// If a vertex is touched by multiple beveled vertices, there may be several "ideal positions" for
// it. Find a single position which is a best compromise between them.
for (int i = 0; i < v.length; i++)
{
if (vertEdgeCount[i] == 0)
continue;
Vec3 ideal[] = new Vec3 [vertEdgeCount[i]];
int index[] = new int [vertEdgeCount[i]];
int num = 0;
int edges[] = vertEdgeIndex[i];
// Find all the ideal positions (as offsets from the current vertex position) and edge indices.
for (int j = 0; j < edges.length; j++)
{
int ej = edges[j];
if (selected[ej])
{
ideal[num] = (e[ej].v1 == i ? idealEndPos[ej][0] : idealEndPos[ej][1]);
ideal[num].subtract(v[i].r);
ideal[num].add(extrudeDir[ej].times(height));
index[num] = ej;
num++;
}
}
// Combine them to find a single position.
vertIndex[i] = vert.size();
if (ideal.length == 1)
{
vert.addElement(offsetVertex(mesh, v[i], ideal[0]));
continue;
}
double m[][] = new double [2*ideal.length][];
double b[] = new double [2*ideal.length];
for (int j = 0; j < ideal.length; j++)
{
Vec3 dir;
dir = extrudeDir[index[j]];
m[2*j] = new double [] {dir.x, dir.y, dir.z};
b[2*j] = dir.dot(ideal[j]);
dir = bevelDir[index[j]];
m[2*j+1] = new double [] {dir.x, dir.y, dir.z};
b[2*j+1] = dir.dot(ideal[j]);
}
SVD.solve(m, b);
vert.addElement(offsetVertex(mesh, v[i], new Vec3(b[0], b[1], b[2])));
}
// We now have all the vertices. Next, create the faces. We begin with the ones
// corresponding to the faces of the original mesh.
for (int i = 0; i < f.length; i++)
{
Face fc = f[i];
// After beveling, the three vertices of the original face may have turned into as many
// as six vertices. Find them, in order.
int origVert[] = new int [] {fc.v1, fc.v2, fc.v2, fc.v3, fc.v3, fc.v1};
int origEdge[] = new int [] {fc.e1, fc.e1, fc.e2, fc.e2, fc.e3, fc.e3};
int newVert[] = new int [6];
int numVert = 0;
for (int j = 0; j < origEdge.length; j++)
{
int index = -1;
int orig = origVert[j];
if (extraVertIndex[orig] != null)
{
// A beveled edge touches the vertex.
for (int k = 0; k < vertEdgeIndex[orig].length; k++)
if (vertEdgeIndex[orig][k] == origEdge[j])
{
if (extraVertIndex[orig][k] == -1)
{
// Two adjacent edges were beveled.
for (int m = 0; m < vertFaceIndex[orig].length; m++)
if (vertFaceIndex[orig][m] == i)
{
index = faceVertIndex[orig][m];
break;
}
}
else
index = extraVertIndex[orig][k];
break;
}
}
else
index = vertIndex[origVert[j]];
if (index > -1 && (numVert == 0 || (index != newVert[numVert-1] && index != newVert[0])))
newVert[numVert++] = index;
}
// We now need to triangulate the vertices and create new faces.
if (numVert == 3)
face.addElement(new int [] {newVert[0], newVert[1], newVert[2], i});
else if (numVert == 4)
{
face.addElement(new int [] {newVert[0], newVert[1], newVert[2], i});
face.addElement(new int [] {newVert[0], newVert[2], newVert[3], i});
}
else
for (int step = 1; 2*step < numVert; step *= 2)
{
int start;
for (start = 0; start+2*step < numVert; start += 2*step)
face.addElement(new int [] {newVert[start], newVert[start+step], newVert[start+2*step], i});
if (start+step < numVert)
face.addElement(new int [] {newVert[start], newVert[start+step], newVert[0], i});
}
}
// Next create the faces capping the vertices at the ends of the beveled edges.
for (int i = 0; i < v.length; i++)
{
if (extraVertIndex[i] == null)
continue;
for (int j = 0; j < extraVertIndex[i].length; j++)
{
int prev = (j == 0 ? vertEdgeIndex[i].length-1 : j-1);
int v1 = extraVertIndex[i][j];
int v2 = extraVertIndex[i][prev];
if (v1 == -1 || v2 == -1)
continue;
if (forward[i])
face.addElement(new int [] {v1, v2, vertIndex[i], -1});
else
face.addElement(new int [] {v2, v1, vertIndex[i], -1});
}
}
// Finally, create the faces capping the beveled edges themselves.
for (int i = 0; i < e.length; i++)
{
if (!selected[i])
continue;
int faceList[] = new int [e[i].f2 == -1 ? 1 : 2];
faceList[0] = e[i].f1;
if (faceList.length > 1)
faceList[1] = e[i].f2;
for (int j = 0; j < faceList.length; j++)
{
int v0, v1, v2, v3;
v0 = vertIndex[e[i].v1];
v3 = vertIndex[e[i].v2];
v1 = v2 = -1;
for (int k = 0; k < vertFaceIndex[e[i].v1].length && v1 == -1; k++)
if (vertFaceIndex[e[i].v1][k] == faceList[j])
v1 = faceVertIndex[e[i].v1][k];
for (int k = 0; k < vertFaceIndex[e[i].v2].length && v2 == -1; k++)
if (vertFaceIndex[e[i].v2][k] == faceList[j])
v2 = faceVertIndex[e[i].v2][k];
Face fc = f[faceList[j]];
if ((fc.v1 == e[i].v1 && fc.v3 == e[i].v2) || (fc.v2 == e[i].v1 && fc.v1 == e[i].v2) || (fc.v3 == e[i].v1 && fc.v2 == e[i].v2))
{
face.addElement(new int [] {v0, v1, v2, -1});
face.addElement(new int [] {v2, v3, v0, -1});
}
else
{
face.addElement(new int [] {v1, v0, v2, -1});
face.addElement(new int [] {v3, v2, v0, -1});
}
}
}
// Create the mesh.
prepareMesh(mesh, face, vert, vertIndex);
// Copy over smoothness values for edges.
Edge newe[] = mesh.getEdges();
for (int i = 0; i < e.length; i++)
{
int v1 = vertIndex[e[i].v1];
int v2 = vertIndex[e[i].v2];
for (int j = 0; j < newe.length; j++)
if ((v1 == newe[j].v1 && v2 == newe[j].v2) ||
(v1 == newe[j].v2 && v2 == newe[j].v1))
{
newe[j].smoothness = e[i].smoothness;
break;
}
}
// Record which edges should be selected.
newSelection = new boolean [newe.length];
for (int i = 0; i < e.length; i++)
if (selected[i])
{
int v1 = vertIndex[e[i].v1];
int v2 = vertIndex[e[i].v2];
for (int j = 0; j < newe.length; j++)
if ((v1 == newe[j].v1 && v2 == newe[j].v2) || (v1 == newe[j].v2 && v2 == newe[j].v1))
{
newSelection[j] = true;
break;
}
}
return mesh;
}
/** Get a list of which faces, edges, or vertices (depending on the bevel mode) should
be selected after beveling. */
public boolean [] getNewSelection()
{
return newSelection;
}
/** Setup the final mesh. */
private void prepareMesh(TriangleMesh mesh, Vector face, Vector vert, int vertIndex[])
{
int newface[][] = new int [face.size()][];
Vertex newvert[] = new Vertex [vert.size()];
for (int i = 0; i < face.size(); i++)
{
int f[] = (int []) face.elementAt(i);
newface[i] = new int [] {f[0], f[1], f[2]};
}
for (int i = 0; i < vert.size(); i++)
newvert[i] = (Vertex) vert.elementAt(i);
mesh.setShape(newvert, newface);
ParameterValue oldParam[] = mesh.getParameterValues();
ParameterValue newParam[] = new ParameterValue [oldParam.length];
for (int i = 0; i < oldParam.length; i++)
{
if (oldParam[i] instanceof VertexParameterValue)
{
double oldval[] = ((VertexParameterValue) oldParam[i]).getValue();
double newval[] = new double [vert.size()];
double defaultVal = mesh.getParameters()[i].defaultVal;
for (int j = 0; j < newval.length; j++)
newval[j] = defaultVal;
if (vertIndex != null)
for (int j = 0; j < vertIndex.length; j++)
newval[vertIndex[j]] = oldval[j];
else
for (int j = 0; j < oldval.length; j++)
newval[j] = oldval[j];
newParam[i] = new VertexParameterValue(newval);
}
else if (oldParam[i] instanceof FaceParameterValue)
{
double oldval[] = ((FaceParameterValue) oldParam[i]).getValue();
double newval[] = new double [face.size()];
double defaultVal = mesh.getParameters()[i].defaultVal;
for (int j = 0; j < newval.length; j++)
{
int f[] = (int []) face.elementAt(j);
if (f[3] == -1)
newval[j] = defaultVal;
else
newval[j] = oldval[f[3]];
}
newParam[i] = new FaceParameterValue(newval);
}
else if (oldParam[i] instanceof FaceVertexParameterValue)
{
FaceVertexParameterValue fvpv = (FaceVertexParameterValue) oldParam[i];
double newval[][] = new double [face.size()][3];
double defaultVal = mesh.getParameters()[i].defaultVal;
for (int j = 0; j < face.size(); j++)
{
int f[] = (int []) face.elementAt(j);
if (f[3] == -1)
{
newval[j][0] = defaultVal;
newval[j][1] = defaultVal;
newval[j][2] = defaultVal;
}
else
{
newval[j][0] = fvpv.getValue(f[3], 0);
newval[j][1] = fvpv.getValue(f[3], 1);
newval[j][2] = fvpv.getValue(f[3], 2);
}
}
newParam[i] = new FaceVertexParameterValue(newval);
}
else
newParam[i] = oldParam[i];
}
mesh.setParameterValues(newParam);
}
}
The table below shows all metrics for TriMeshBeveler.java.
| Metric | Value | Description | |
|---|---|---|---|
| BLOCKS | 113.00 | Number of blocks | |
| BLOCK_COMMENT | 9.00 | Number of block comment lines | |
| COMMENTS | 137.00 | Comment lines | |
| COMMENT_DENSITY | 0.18 | Comment density | |
| COMPARISONS | 255.00 | Number of comparison operators | |
| CYCLOMATIC | 294.00 | Cyclomatic complexity | |
| DECL_COMMENTS | 12.00 | Comments in declarations | |
| DOC_COMMENT | 37.00 | Number of javadoc comment lines | |
| ELOC | 760.00 | Effective lines of code | |
| EXEC_COMMENTS | 64.00 | Comments in executable code | |
| EXITS | 43.00 | Procedure exits | |
| FUNCTIONS | 11.00 | Number of function declarations | |
| HALSTEAD_DIFFICULTY | 275.87 | Halstead difficulty | |
| HALSTEAD_EFFORT | 0.00 | Halstead effort | |
| INTERFACE_COMPLEXITY | 44.00 | Interface complexity | |
| JAVA0001 | 0.00 | JAVA0001 Package name does not contain only lower case letters | |
| JAVA0002 | 1.00 | JAVA0002 Package name does not begin with a top level domain name or country code | |
| JAVA0003 | 0.00 | JAVA0003 Minimize use of on-demand (.*) imports | |
| JAVA0004 | 0.00 | JAVA0004 Unnecessary import from java.lang | |
| JAVA0005 | 1.00 | JAVA0005 Imports not in specified order | |
| JAVA0006 | 0.00 | JAVA0006 Empty finally block | |
| JAVA0007 | 0.00 | JAVA0007 Should not declare public field | |
| JAVA0008 | 0.00 | JAVA0008 Empty catch block | |
| JAVA0009 | 0.00 | JAVA0009 Protected member in final class | |
| JAVA0010 | 0.00 | JAVA0010 Non-instantiable class does not contain a non-private static member | |
| JAVA0011 | 0.00 | JAVA0011 Abstract class does not contain an abstract method | |
| JAVA0012 | 0.00 | JAVA0012 Non-constructor method with same name as declaring class | |
| JAVA0013 | 0.00 | JAVA0013 Non-blank final field is not static | |
| JAVA0014 | 0.00 | JAVA0014 Class with only static members has non-private constructor | |
| JAVA0015 | 0.00 | JAVA0015 Package class contains public nested type | |
| JAVA0016 | 0.00 | JAVA0016 Abstract class contains public constructor | |
| JAVA0017 | 0.00 | JAVA0017 Class name does not have required form | |
| JAVA0018 | 0.00 | JAVA0018 Method name does not have required form | |
| JAVA0019 | 0.00 | JAVA0019 Interface name does not have required form | |
| JAVA0020 | 0.00 | JAVA0020 Field name does not have required form | |
| JAVA0021 | 0.00 | JAVA0021 Interface method name does not have required form | |
| JAVA0022 | 0.00 | JAVA0022 Static final field name does not have required form | |
| JAVA0023 | 0.00 | JAVA0023 Empty finalize method | |
| JAVA0024 | 0.00 | JAVA0024 Empty class | |
| JAVA0025 | 0.00 | JAVA0025 Method override is empty | |
| JAVA0026 | 0.00 | JAVA0026 Finalize method with parameters | |
| JAVA0029 | 0.00 | JAVA0029 Private method not used | |
| JAVA0030 | 0.00 | JAVA0030 Private field not used | |
| JAVA0031 | 0.00 | JAVA0031 Case statement not properly closed | |
| JAVA0032 | 1.00 | JAVA0032 Switch statement missing default | |
| JAVA0033 | 0.00 | JAVA0033 default: not last case in switch statement | |
| JAVA0034 | 63.00 | JAVA0034 Missing braces in if statement | |
| JAVA0035 | 42.00 | JAVA0035 Missing braces in for statement | |
| JAVA0036 | 1.00 | JAVA0036 Missing braces in while statement | |
| JAVA0038 | 0.00 | JAVA0038 Non-case label in switch statement | |
| JAVA0039 | 0.00 | JAVA0039 Break statement with label | |
| JAVA0040 | 0.00 | JAVA0040 Switch statement contains N cases (maximum: M) | |
| JAVA0041 | 0.00 | JAVA0041 Nested synchronized block | |
| JAVA0042 | 0.00 | JAVA0042 Empty synchronized statement | |
| JAVA0043 | 0.00 | JAVA0043 Inner class does not use outer class | |
| JAVA0044 | 0.00 | JAVA0044 Serializable class with no instance variables | |
| JAVA0045 | 0.00 | JAVA0045 Serializable class with only transient fields | |
| JAVA0046 | 0.00 | JAVA0046 Name of class not derived from Exception ends with 'Exception' | |
| JAVA0047 | 0.00 | JAVA0047 Serializable class derives from invalid base class | |
| JAVA0048 | 0.00 | JAVA0048 Name of class derived from Exception does not end with 'Exception' | |
| JAVA0049 | 10.00 | JAVA0049 Nested block at depth N (maximum: M) | |
| JAVA0050 | 0.00 | JAVA0050 Class derives from java.lang.Error | |
| JAVA0051 | 0.00 | JAVA0051 Class derives from java.lang.RuntimeException | |
| JAVA0052 | 0.00 | JAVA0052 Class derives from java.lang.Throwable | |
| JAVA0053 | 0.00 | JAVA0053 Unused label | |
| JAVA0054 | 0.00 | JAVA0054 Inheritance depth N exceeds maximum M | |
| JAVA0055 | 0.00 | JAVA0055 Class should be interface | |
| JAVA0056 | 0.00 | JAVA0056 Unnecessary abstract modifier for interface or annotation | |
| JAVA0057 | 0.00 | JAVA0057 Unnecessary default constructor | |
| JAVA0058 | 0.00 | JAVA0058 Constructor calls super() | |
| JAVA0059 | 0.00 | JAVA0059 Method override only calls super() | |
| JAVA0061 | 0.00 | JAVA0061 Inaccessible member in anonymous class | |
| JAVA0062 | 0.00 | JAVA0062 Public class missing public member or protected constructor | |
| JAVA0063 | 0.00 | JAVA0063 Identifier name should not contain '$' | |
| JAVA0064 | 1.00 | JAVA0064 N variations of identifier name (maximum: M) | |
| JAVA0065 | 0.00 | JAVA0065 Unnecessary final modifier for method in final class | |
| JAVA0066 | 0.00 | JAVA0066 Unnecessary modifier for interface nested type | |
| JAVA0067 | 89.00 | JAVA0067 Array descriptor on identifier name | |
| JAVA0068 | 0.00 | JAVA0068 Modifiers not declared in recommended order | |
| JAVA0071 | 0.00 | JAVA0071 Strings compared with == | |
| JAVA0073 | 0.00 | JAVA0073 Integer division in floating-point context | |
| JAVA0074 | 0.00 | JAVA0074 Use of Object.notify() | |
| JAVA0075 | 2.00 | JAVA0075 Method parameter hides field | |
| JAVA0076 | 6.00 | JAVA0076 Use of magic number | |
| JAVA0077 | 0.00 | JAVA0077 Private field not used in declaring class | |
| JAVA0078 | 10.00 | JAVA0078 Floating point values compared with == | |
| JAVA0079 | 0.00 | JAVA0079 Use of instance to reference static member | |
| JAVA0080 | 0.00 | JAVA0080 Import declaration not used | |
| JAVA0081 | 1.00 | JAVA0081 Boolean literal in comparison | |
| JAVA0082 | 0.00 | JAVA0082 Unnecessary widening cast | |
| JAVA0083 | 0.00 | JAVA0083 Unnecessary instanceof test | |
| JAVA0084 | 0.00 | JAVA0084 Should use compound assignment operator | |
| JAVA0085 | 0.00 | JAVA0085 Use of sun.* class | |
| JAVA0087 | 0.00 | JAVA0087 Use of Thread.sleep() | |
| JAVA0089 | 0.00 | JAVA0089 Use of restricted package | |
| JAVA0092 | 0.00 | JAVA0092 Use of restricted type | |
| JAVA0093 | 0.00 | JAVA0093 Redundant assignment | |
| JAVA0094 | 0.00 | JAVA0094 Field hides a superclass field | |
| JAVA0095 | 0.00 | JAVA0095 Uninitialized private field | |
| JAVA0096 | 0.00 | JAVA0096 Field in nested class hides outer field | |
| JAVA0098 | 0.00 | JAVA0098 Minimize use of implicit field initializers | |
| JAVA0100 | 0.00 | JAVA0100 Class contains N non-final fields (maximum: M) | |
| JAVA0101 | 0.00 | JAVA0101 Unnecessary modifier for field in interface | |
| JAVA0102 | 0.00 | JAVA0102 Last statement in finalize() not super.finalize() | |
| JAVA0103 | 0.00 | JAVA0103 Explicit call to finalize() | |
| JAVA0104 | 0.00 | JAVA0104 finalize() only calls super.finalize() | |
| JAVA0105 | 0.00 | JAVA0105 Duplicate import declaration | |
| JAVA0106 | 0.00 | JAVA0106 Unnecessary import from current package | |
| JAVA0108 | 11.00 | JAVA0108 Incorrect javadoc: no @param tag for 'parameter' | |
| JAVA0109 | 0.00 | JAVA0109 Incorrect javadoc: no parameter 'parameter' | |
| JAVA0110 | 7.00 | JAVA0110 Incorrect javadoc: no @return tag | |
| JAVA0111 | 0.00 | JAVA0111 Incorrect javadoc: @return tag for void method | |
| JAVA0112 | 0.00 | JAVA0112 Incorrect javadoc: no exception 'exception' in throws | |
| JAVA0113 | 1.00 | JAVA0113 Incorrect javadoc: no @author tag | |
| JAVA0114 | 1.00 | JAVA0114 Incorrect javadoc: no @version tag | |
| JAVA0115 | 0.00 | JAVA0115 Incorrect javadoc: no @throws or @exception tag for 'exception' | |
| JAVA0116 | 4.00 | JAVA0116 Missing javadoc: field 'field' | |
| JAVA0117 | 1.00 | JAVA0117 Missing javadoc: method 'method' | |
| JAVA0118 | 0.00 | JAVA0118 Missing javadoc: type 'type' | |
| JAVA0119 | 4.00 | JAVA0119 Control variable changed within body of for loop | |
| JAVA0123 | 0.00 | JAVA0123 Use all three components of for loop | |
| JAVA0125 | 0.00 | JAVA0125 Continue statement with label | |
| JAVA0126 | 0.00 | JAVA0126 Method declares unchecked exception in throws | |
| JAVA0128 | 0.00 | JAVA0128 Public constructor in non-public class | |
| JAVA0130 | 2.00 | JAVA0130 Non-static method does not use instance fields | |
| JAVA0131 | 0.00 | JAVA0131 Compatible method does not override base | |
| JAVA0132 | 0.00 | JAVA0132 Method overload with compatible signature | |
| JAVA0133 | 0.00 | JAVA0133 Non-synchronized method overrides synchronized method | |
| JAVA0135 | 0.00 | JAVA0135 Only one of Object.equals and Object.hashCode defined: missing 'method' | |
| JAVA0136 | 0.00 | JAVA0136 N methods defined in class (maximum: M) | |
| JAVA0137 | 0.00 | JAVA0137 Non-abstract class missing constructor | |
| JAVA0138 | 0.00 | JAVA0138 N parameters defined for method (maximum: M) | |
| JAVA0139 | 0.00 | JAVA0139 Definition of main other than public static void main(java.lang.String[]) | |
| JAVA0141 | 0.00 | JAVA0141 Unnecessary modifier for method in interface | |
| JAVA0143 | 0.00 | JAVA0143 Synchronized method | |
| JAVA0144 | 1.00 | JAVA0144 Line exceeds maximum M characters | |
| JAVA0145 | 496.00 | JAVA0145 Tab character used in source file | |
| JAVA0150 | 0.00 | JAVA0150 java.lang.Error (or subclass) thrown | |
| JAVA0153 | 0.00 | JAVA0153 Inefficient conversion of integer to string | |
| JAVA0159 | 0.00 | JAVA0159 Inefficient conversion of string to integer | |
| JAVA0160 | 0.00 | JAVA0160 Method does not throw specified exception | |
| JAVA0161 | 0.00 | JAVA0161 Conditional wait() not in loop | |
| JAVA0163 | 1.00 | JAVA0163 Empty statement | |
| JAVA0165 | 0.00 | JAVA0165 Conflicting return statement in finally block | |
| JAVA0166 | 0.00 | JAVA0166 Generic exception caught | |
| JAVA0167 | 0.00 | JAVA0167 ThreadDeath not rethrown | |
| JAVA0169 | 0.00 | JAVA0169 Unnecessary catch block: exception 'exception' | |
| JAVA0170 | 0.00 | JAVA0170 Caught exception not derived from java.lang.Exception | |
| JAVA0171 | 1.00 | JAVA0171 Unused local variable | |
| JAVA0173 | 2.00 | JAVA0173 Unused method parameter | |
| JAVA0174 | 0.00 | JAVA0174 Assigned local variable never used | |
| JAVA0175 | 1.00 | JAVA0175 Successive assignment to variable | |
| JAVA0176 | 0.00 | JAVA0176 Local variable name does not have required form | |
| JAVA0177 | 41.00 | JAVA0177 Variable declaration missing initializer | |
| JAVA0179 | 0.00 | JAVA0179 Local variable hides visible field | |
| JAVA0233 | 0.00 | JAVA0233 Definition of serialVersionUID other than 'private static final long serialVersionUID' | |
| JAVA0234 | 0.00 | JAVA0234 Class is Serializable but does not define serialVersionUID | |
| JAVA0235 | 0.00 | JAVA0235 Class defines serialVersionUID but does not implement Serializable | |
| JAVA0236 | 0.00 | JAVA0236 Attempt to clone an object which does not implement Cloneable | |
| JAVA0237 | 0.00 | JAVA0237 Class implements Cloneable but does not have public clone method | |
| JAVA0238 | 0.00 | JAVA0238 Clone method does not call super.clone() | |
| JAVA0239 | 0.00 | JAVA0239 Class declares 'readObject' or 'writeObject' but does not implement Serializable | |
| JAVA0240 | 0.00 | JAVA0240 Serializable class which declares readObject or writeObject but not both | |
| JAVA0241 | 0.00 | JAVA0241 'readObject' or 'writeObject' should be declared private in Serializable class | |
| JAVA0242 | 0.00 | JAVA0242 Transient field in non-Serializable class | |
| JAVA0243 | 0.00 | JAVA0243 'readResolve' or 'writeReplace' should be declared private or protected | |
| JAVA0244 | 0.00 | JAVA0244 Field or method name in subclass differs only by case from inherited field or method | |
| JAVA0245 | 0.00 | JAVA0245 JUnit TestCase with non-trivial constructor | |
| JAVA0246 | 0.00 | JAVA0246 JUnit assertXXX statement missing message parameter | |
| JAVA0247 | 0.00 | JAVA0247 JUnit 'setUp()' and 'tearDown()' should call super method | |
| JAVA0248 | 0.00 | JAVA0248 JUnit method 'setUp' or 'tearDown' with incorrect signature | |
| JAVA0249 | 0.00 | JAVA0249 JUnit TestCase 'suite()' should be declared static | |
| JAVA0250 | 0.00 | JAVA0250 JUnit TestCase declares testXXX method with incorrect signature | |
| JAVA0251 | 0.00 | JAVA0251 Use '%n' for line breaks in printf/format for platform independence | |
| JAVA0252 | 0.00 | JAVA0252 'enum' is a Java 1.5 reserved word | |
| JAVA0253 | 0.00 | JAVA0253 Not all enum constants consumed in switch statement | |
| JAVA0254 | 0.00 | JAVA0254 Use enhanced for loop construct instead of Iterator | |
| JAVA0255 | 0.00 | JAVA0255 Result of method invocation not used | |
| JAVA0256 | 1.00 | JAVA0256 Assignment of external collection/array to field | |
| JAVA0257 | 0.00 | JAVA0257 Use of 'Constant Interface' anti-pattern | |
| JAVA0258 | 0.00 | JAVA0258 Implement Iterable for foreach compatibility | |
| JAVA0259 | 1.00 | JAVA0259 Return of collection/array field | |
| JAVA0260 | 0.00 | JAVA0260 Use 'enum' instead of Enumerated Type pattern | |
| JAVA0261 | 0.00 | JAVA0261 Use specialized Enum collection types | |
| JAVA0262 | 0.00 | JAVA0262 Use of char in integer context | |
| JAVA0263 | 0.00 | JAVA0263 Long literal ends with 'l' instead of 'L' | |
| JAVA0264 | 0.00 | JAVA0264 Integer math in long context - check for overflow | |
| JAVA0265 | 0.00 | JAVA0265 Use of Throwable.printStackTrace() | |
| JAVA0266 | 0.00 | JAVA0266 Use of System.out | |
| JAVA0267 | 0.00 | JAVA0267 Use of System.err | |
| JAVA0269 | 0.00 | JAVA0269 Contents of StringBuffer never used | |
| JAVA0270 | 7.00 | JAVA0270 Use Java 5.0 enhanced for loop construct to iterate over all elements in an array | |
| JAVA0271 | 0.00 | JAVA0271 Minimize use of on-demand (.*) static imports | |
| JAVA0272 | 0.00 | JAVA0272 Thread.run() called | |
| JAVA0273 | 0.00 | JAVA0273 Non-final derivative of Thread calls start() in constructor | |
| JAVA0274 | 0.00 | JAVA0274 Serializable class has a synchronized readObject() | |
| JAVA0275 | 0.00 | JAVA0275 Serializable class has a synchronized writeObject() and no other synchronized methods | |
| JAVA0276 | 0.00 | JAVA0276 Unnecessary use of String constructor | |
| JAVA0277 | 0.00 | JAVA0277 Iterator.next() implementation does not throw NoSuchElementException | |
| JAVA0278 | 0.00 | JAVA0278 Unnecessary use of Boolean constructor | |
| JAVA0279 | 0.00 | JAVA0279 Serialization method readObject or readObjectNoData calls an overridable method | |
| JAVA0280 | 0.00 | JAVA0280 IllegalMonitorStateException caught | |
| JAVA0281 | 0.00 | JAVA0281 Iterator.next() not called in loop | |
| JAVA0282 | 0.00 | JAVA0282 Call to Iterator.next() in loop which does not test Iterator.hasNext() | |
| JAVA0283 | 0.00 | JAVA0283 Control variable not updated in loop body | |
| JAVA0284 | 0.00 | JAVA0284 Explicit garbage collection | |
| JAVA0285 | 0.00 | JAVA0285 Dereference of potentially null variable | |
| JAVA0286 | 0.00 | JAVA0286 Dereference of null variable | |
| JAVA0287 | 0.00 | JAVA0287 Unnecessary null check | |
| JAVA0288 | 0.00 | JAVA0288 Inconsistent null check | |
| LINES | 1276.00 | Number of lines in the source file | |
| LINE_COMMENT | 91.00 | Number of line comments | |
| LOC | 989.00 | Lines of code | |
| LOGICAL_LINES | 693.00 | Number of statements | |
| LOOPS | 85.00 | Number of loops | |
| NEST_DEPTH | 7.00 | Maximum nesting depth | |
| OPERANDS | 3947.00 | Number of operands | |
| OPERATORS | 7204.00 | Number of operators | |
| PARAMS | 24.00 | Number of formal parameter declarations | |
| PROGRAM_LENGTH | 11151.00 | Halstead program length | |
| PROGRAM_VOCAB | 424.00 | Halstead program vocabulary | |
| PROGRAM_VOLUME | 0.00 | Halstead program volume | |
| RETURNS | 20.00 | Number of return points from functions | |
| SIZE | 42310.00 | Size of the file in bytes | |
| UNIQUE_OPERANDS | 372.00 | Number of unique operands | |
| UNIQUE_OPERATORS | 52.00 | Number of unique operators | |
| WHITESPACE | 150.00 | Number of whitespace lines | |