NeighbourAnt.java
| Index Score | ||
|---|---|---|
 |
 |
ants.p2p |
 |
 |
ANtsP2P |
View: Reasons, Metrics, Source Code
These are the metrics that contribute to the Enerjy Score for this file, ranked by impact. So the metrics listed at the top influence the score to a greater extent that the metrics listed at the bottom.
| Metric | Description | |
|---|---|---|
| JAVA0034 | JAVA0034 Missing braces in if statement |  |
| JAVA0083 | JAVA0083 Unnecessary instanceof test | |
| JAVA0117 | JAVA0117 Missing javadoc: method 'method' | |
| JAVA0116 | JAVA0116 Missing javadoc: field 'field' | |
| JAVA0007 | JAVA0007 Should not declare public field | |
| LINE_COMMENT | Number of line comments | |
| CYCLOMATIC | Cyclomatic complexity | |
| OPERATORS | Number of operators | |
| ELOC | Effective lines of code | |
| JAVA0076 | JAVA0076 Use of magic number | |
| PROGRAM_LENGTH | Halstead program length | |
| JAVA0166 | JAVA0166 Generic exception caught | |
| BLOCKS | Number of blocks | |
| LOC | Lines of code | |
| LOGICAL_LINES | Number of statements | |
| COMPARISONS | Number of comparison operators | |
| SIZE | Size of the file in bytes | |
| UNIQUE_OPERANDS | Number of unique operands | |
| EXITS | Procedure exits | |
| PROGRAM_VOCAB | Halstead program vocabulary | |
| JAVA0177 | JAVA0177 Variable declaration missing initializer | |
| OPERANDS | Number of operands | |
| JAVA0128 | JAVA0128 Public constructor in non-public class | |
| DECL_COMMENTS | Comments in declarations | |
| JAVA0144 | JAVA0144 Line exceeds maximum M characters | |
| JAVA0008 | JAVA0008 Empty catch block | |
| JAVA0049 | JAVA0049 Nested block at depth N (maximum: M) | |
| NEST_DEPTH | Maximum nesting depth | |
| LINES | Number of lines in the source file | |
| FUNCTIONS | Number of function declarations | |
| UNIQUE_OPERATORS | Number of unique operators | |
| JAVA0143 | JAVA0143 Synchronized method | |
| RETURNS | Number of return points from functions | |
| PROGRAM_VOLUME | Halstead program volume | |
| JAVA0136 | JAVA0136 N methods defined in class (maximum: M) | |
| JAVA0126 | JAVA0126 Method declares unchecked exception in throws | |
| JAVA0110 | JAVA0110 Incorrect javadoc: no @return tag | |
| JAVA0264 | JAVA0264 Integer math in long context - check for overflow | |
| JAVA0087 | JAVA0087 Use of Thread.sleep() | |
| JAVA0013 | JAVA0013 Non-blank final field is not static | |
| JAVA0100 | JAVA0100 Class contains N non-final fields (maximum: M) | |
| JAVA0108 | JAVA0108 Incorrect javadoc: no @param tag for 'parameter' | |
| COMMENTS | Comment lines | |
| DOC_COMMENT | Number of javadoc comment lines | |
| JAVA0003 | JAVA0003 Minimize use of on-demand (.*) imports | |
| LOOPS | Number of loops | |
| JAVA0145 | JAVA0145 Tab character used in source file | |
//******************************************************************
//******************************************************************
//********** ANts Peer To Peer Sources *************
//
// ANts P2P realizes a third generation P2P net. It protects your
// privacy while you are connected and makes you not trackable, hiding
// your identity (ip) and crypting everything you are sending/receiving
// from others.
// Copyright (C) 2004 Roberto Rossi
// This program is free software; you can redistribute it and/or
// modify it under the terms of the GNU General Public License
// as published by the Free Software Foundation; either version 2
// of the License, or (at your option) any later version.
// This program is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
// You should have received a copy of the GNU General Public License
// along with this program; if not, write to the Free Software
// Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
package ants.p2p;
import java.net.*;
import java.io.*;
import java.util.*;
import javax.crypto.*;
import ants.p2p.messages.*;
import ants.p2p.query.*;
import ants.p2p.http.*;
import ants.p2p.utils.net.*;
import org.apache.log4j.*;
import com.jcraft.jzlib.*;
public class NeighbourAnt extends Thread implements Neighbour{
Ant local;
String ip;
int port;
int remoteServerPort;
Cipher enc;
Cipher dec;
Socket s;
BandwidthFilterIn bfIn;
BandwidthFilterOut bfOut;
long queuedMessages = 0;
boolean failure = false;
boolean terminate = false;
boolean isRequirer;
long timeElapsed;
long lastProbedAt;
long lastActiveUploadTime = System.currentTimeMillis();
long lastActiveDownloadTime = System.currentTimeMillis();
final int pingSize = 32;
long queryInCheckpoint = 0;
long floodInCheckpoint = 0;
long floodOutCheckpoint = 0;
int receivedQueries = 0;
int receivedFloods = 0;
int routedQueries = 0;
int routedFloods = 0;
public static int bandwidthLimit = 30 * 1024;
public static int queryBandwidthLimit = 10 * 1024;
public static final int maxQueryRatePerMinute = 60;
Prober prober;
public static double totalCompressedSizeOut;
public static double totalUncompressionSizeOut;
public static double totalCompressedSizeIn;
public static double totalUncompressionSizeIn;
public static double totalQueryCompressedSizeOut;
public static double totalQueryCompressedSizeIn;
public static double totalDataCompressedSizeOut;
public static double totalDataCompressedSizeIn;
public static double totalControlCompressedSizeOut;
public static double totalControlCompressedSizeIn;
public static double totalDownloaded = 0;
public static double totalUploaded = 0;
static Logger _logger = Logger.getLogger(NeighbourAnt.class.getName());
private Object socketLock = new Object();
public NeighbourAnt(Ant local, String ip, int port, int remoteServerPort, Cipher enc,
Cipher dec, Socket s, boolean isRequirer, long timeElapsed) throws IOException {
this.s = s;
this.ip = ip;
this.port = port;
this.remoteServerPort = remoteServerPort;
this.enc = enc;
this.dec = dec;
this.local = local;
this.isRequirer=isRequirer;
this.timeElapsed = timeElapsed;
this.lastProbedAt = System.currentTimeMillis();
_logger.info(this.getIdent() +": Net probe done at "+new java.util.Date(this.lastProbedAt)+"["+this.timeElapsed+"]");
this.bfIn = new BandwidthFilterIn(s.getInputStream());
this.bfOut = new BandwidthFilterOut(s.getOutputStream());
this.setPriority(10);
}
public void incQueuedMessages(){
this.modifyQueuedMessages(1);
}
public void decQueuedMessages(){
this.modifyQueuedMessages(-1);
}
public long getQueuedMessages(){
return this.queuedMessages;
}
private synchronized void modifyQueuedMessages(int modifier){
this.queuedMessages += modifier;
}
public long getTimeElapsed(){
return this.timeElapsed;
}
public long getLastProbedAt(){
return this.lastProbedAt;
}
public long getLastActiveDownloadTime(){
return this.lastActiveDownloadTime;
}
public long getLastActiveUploadTime(){
return this.lastActiveUploadTime;
}
public void setLastActiveDownloadTime(){
this.lastActiveDownloadTime = System.currentTimeMillis();
}
public void setLastActiveUploadTime(){
this.lastActiveUploadTime = System.currentTimeMillis();
}
public boolean isConnected(){
if(!this.terminate && this.s != null)
return !this.s.isClosed();
else
return false;
}
public boolean isRequirer(){
return this.isRequirer;
}
public void terminate(){
try{
this.terminate = true;
_logger.info("Terminating neighbour "+this.getIdent()+" socket: "+s);
if (s != null) {
_logger.info("Closing "+this.getIdent()+" socket: "+s);
this.s.close();
_logger.info("Neighbour terminated ["+ this.s.isClosed() +"] " + this.getIdent());
}else{
_logger.info("Neighbour terminated (null socket) " + this.getIdent());
}
}catch(Exception ex){_logger.error("Neighbour terminate error",ex);}
}
public String getIdent(){
if(ip.startsWith("/"))
ip = ip.substring(1);
return ip+" "+port;
}
public Ant getAnt(){
return this.local;
}
public String getRemoteId() {
if(ip.startsWith("/"))
ip = ip.substring(1);
return ip+" "+this.remoteServerPort;
}
public boolean equals(Object o){
if(o instanceof NeighbourAnt){
String idThis;
String idO;
if(this.isRequirer())
idThis = this.getIdent();
else
idThis = this.getRemoteId();
if(((NeighbourAnt)o).isRequirer())
idO = ((NeighbourAnt)o).getIdent();
else
idO = ((NeighbourAnt)o).getRemoteId();
return idThis.equals(idO);
}
else
return o==this;
}
public SenderThread route(Message m){
SenderThread st = new SenderThread(m, this);
st.start();
return st;
}
public void send(Message m) throws Exception {
try {
if(this.terminate || this.s.isClosed()) {
if(!(m instanceof NetProbeMessage) &&
!(m instanceof NetModificationAlert) &&
!(m instanceof QueryMessage)){
_logger.info(this.getIdent() +
": Neighbour terminated, routing message to a different direction. " +
m);
local.activateNewRouterProcess(m, this.getIdent());
}
return;
}
CompressedByteArray cba = null;
ByteArrayOutputStream byteArrayOut = null;
if(m instanceof NetProbeMessage){
synchronized (socketLock) {
ObjectOutputStream soos = new ObjectOutputStream(bfOut);
_logger.info(this.getIdent() + ": Sending probe message at " +
new java.util.Date(System.currentTimeMillis()));
soos.writeObject(m);
soos.writeObject(new byte[this.pingSize]);
_logger.info(this.getIdent() + ": Sent probe message at " +
new java.util.Date(System.currentTimeMillis()));
//local.propertyChangeSupport.firePropertyChange("updatePacketCompressionStats", null, null);
return;
}
}
else {
//SealedObject sealedMessage;
_logger.debug(this.getIdent() + ": Routing message: ID " + m.getAck_Id() +
" Type: " + m.getType() + " From: " + " To: " +
m.getDest());
_logger.debug(this.getIdent() + ": Message sending ["+this.getQueuedMessages()+"]"+m.getType()+" "+m);//+" From: "+m.getSource()+" To: "+m.getDest());
//sealedMessage = new SealedObject(m, this.enc);
byteArrayOut = new ByteArrayOutputStream();
ZOutputStream zOut = new ZOutputStream(byteArrayOut, JZlib.Z_BEST_COMPRESSION);
ObjectOutputStream zOOs = new ObjectOutputStream(zOut);
//zOOs.writeObject(sealedMessage);
zOOs.writeObject(m);
NeighbourAnt.totalUncompressionSizeOut += zOut.getTotalIn();
zOut.close();
NeighbourAnt.totalCompressedSizeOut += byteArrayOut.toByteArray().
length;
updateOutStats(m, byteArrayOut.toByteArray().length);
cba = new CompressedByteArray(byteArrayOut.
toByteArray());
}
if(m instanceof QueryMessage){
QueryBandwidthFilterOut.getInstance().writeQuery(byteArrayOut.toByteArray().length);
}else{
DataBandwidthFilterOut.getInstance().writeData(byteArrayOut.toByteArray().length);
}
if (Thread.currentThread() instanceof SenderThread) {
SenderThread curThread = (SenderThread) Thread.currentThread();
if (!curThread.mustSend()) {
return;
}
}
if (this.terminate || this.s.isClosed()) {
if (! (m instanceof NetProbeMessage)) {
_logger.info(this.getIdent() +
": Neighbour terminated, routing message to a different direction. " +
m);
local.activateNewRouterProcess(m, this.getIdent());
}
return;
}
synchronized (socketLock) {
ObjectOutputStream oos = new ObjectOutputStream(bfOut);
oos.writeObject(cba);
_logger.debug(this.getIdent() + ": Message sent ["+this.getQueuedMessages()+"]"+m.getType()+" "+m);//+" From: "+m.getSource()+" To: "+m.getDest());
}
}
catch (Exception e) {
_logger.info(this.getIdent() +
": Socket is closed with neighbour: " +
this.getIdent(),e);
try{
if (s != null)
s.close();
}catch(Exception ex){}
}
}
public static void updateOutStats(Message m, long size){
if (m instanceof ControlMessage ||
m instanceof FileTransferEndControlMessage ||
m instanceof FileTransferErrorControlMessage ||
m instanceof FileSizePullErrorControlMessage ||
m instanceof FileInfosPullErrorControlMessage ||
m instanceof HttpTransferEndControlMessage ||
m instanceof HttpInterruptTransferMessage ||
m instanceof SecureConnectionErrorControlMessage ||
m instanceof NetModificationAlert) {
totalControlCompressedSizeOut += size;
}
else if (m instanceof SecurityRequestMessage ||
m instanceof SecurityResponseMessage ||
m instanceof FilePullMessage ||
m instanceof FilePushMessage ||
m instanceof FileInfosPullMessage ||
m instanceof FileInfosPushMessage ||
m instanceof HttpRequestMessage) {
totalControlCompressedSizeOut += size;
}
else if (m instanceof FileSizePullMessage ||
m instanceof FileSizePushMessage) {
totalControlCompressedSizeOut += size;
}
else if (m instanceof PrivateChatMessage) {
totalControlCompressedSizeOut += size;
}
else if (m instanceof QueryMessage) {
totalQueryCompressedSizeOut += size;
}
else if (m instanceof HttpResponsePartMessage) {
totalDataCompressedSizeOut += size;
}
else if (m instanceof FilePartMessage) {
totalDataCompressedSizeOut += size;
}
else if (m instanceof Message) {
totalDataCompressedSizeOut += size;
}
}
public static void updateInStats(Message m, long size){
if (m instanceof ControlMessage ||
m instanceof FileTransferEndControlMessage ||
m instanceof FileTransferErrorControlMessage ||
m instanceof FileSizePullErrorControlMessage ||
m instanceof FileInfosPullErrorControlMessage ||
m instanceof HttpTransferEndControlMessage ||
m instanceof HttpInterruptTransferMessage ||
m instanceof SecureConnectionErrorControlMessage ||
m instanceof NetModificationAlert) {
totalControlCompressedSizeIn += size;
}
else if (m instanceof SecurityRequestMessage ||
m instanceof SecurityResponseMessage ||
m instanceof FilePullMessage ||
m instanceof FilePushMessage ||
m instanceof FileInfosPullMessage ||
m instanceof FileInfosPushMessage ||
m instanceof HttpRequestMessage) {
totalControlCompressedSizeIn += size;
}
else if (m instanceof FileSizePullMessage ||
m instanceof FileSizePushMessage) {
totalControlCompressedSizeIn += size;
}
else if (m instanceof PrivateChatMessage) {
totalControlCompressedSizeIn += size;
}
else if (m instanceof QueryMessage) {
totalQueryCompressedSizeIn += size;
}
else if (m instanceof HttpResponsePartMessage) {
totalDataCompressedSizeIn += size;
}
else if (m instanceof FilePartMessage) {
totalDataCompressedSizeIn += size;
}
else if (m instanceof Message) {
totalDataCompressedSizeIn += size;
}
}
/*
public void checkProbeTime(){
_logger.info(this+": Local time elapsed: " + this.getTimeElapsed() + "[Thresold: " +
local.getRateThresold() + "]");
if (local.getUnderRatedNeighbours() >= Math.floor(Ant.maxNeighbours * Ant.underRateConnections) &&
this.getTimeElapsed() >= local.getRateThresold()) {
this.terminate = true;
_logger.info("Rejected neighbour cause it doesn't satisfy bandwith request: ["+local.getUnderRatedNeighbours()+"/"+Math.floor(Ant.maxNeighbours*Ant.underRateConnections)+"]");
}
}*/
/*boolean checkNeighboursQueues(){
boolean allowReceive = true;
List neighbours = this.local.getNeighbours();
for(int x = 0; x < neighbours.size(); x++){
if(((NeighbourAnt)neighbours.get(x)).getQueuedMessages() > NeighbourAnt.maxQueuedMessage)
allowReceive = false;
}
return allowReceive;
}*/
public void run() {
try {
this.prober = new Prober(this);
this.prober.start();
while (!local.isDisconnected() && !terminate) {
Message m = null;
//_logger.info(this.getIdent() + ": Waiting for message to route...");
ObjectInputStream ois;
Object obj;
ois = new ObjectInputStream(this.bfIn);
obj = ois.readObject();
long size = 0;
if (obj instanceof CompressedByteArray) {
CompressedByteArray cba = (CompressedByteArray)obj;
ByteArrayInputStream in = new ByteArrayInputStream(cba.getArray());
ZInputStream zIn = new ZInputStream(in);
ObjectInputStream objIn = new ObjectInputStream(zIn);
obj = objIn.readObject();
NeighbourAnt.totalCompressedSizeIn += zIn.getTotalIn();
NeighbourAnt.totalUncompressionSizeIn += zIn.getTotalOut();
size += zIn.getTotalIn();
}else if (obj instanceof NetProbeMessage) {
long startProbe = System.currentTimeMillis();
ois.readObject();
this.timeElapsed = System.currentTimeMillis() - startProbe;
this.lastProbedAt = System.currentTimeMillis();
_logger.info(this.getIdent() +": Net probe done at "+new java.util.Date(this.lastProbedAt)+"["+this.timeElapsed+"]");
//this.checkProbeTime();
continue;
}else{
_logger.debug(obj.toString());
continue;
}
//if (obj instanceof SealedObject) {
//obj = ( (SealedObject) obj).getObject(dec);
if (obj instanceof NetModificationAlert && ((NetModificationAlert) obj).getVersion().equals(Ant.getProtocolVersion())){
this.local.processNetModificationAlert( (NetModificationAlert) obj, this);
}
else if (obj instanceof Message && ((Message) obj).getVersion().equals(Ant.getProtocolVersion())) {
m = (Message) obj;
updateInStats(m, size);
_logger.debug(this.getIdent() + ": Message received ID "+m.getAck_Id().substring(0,10)+" From: "+
((m.getSource().length() > 10) ? m.getSource().substring(0,10) : m.getSource()) +" To: "+
((m.getDest().length() > 10) ? m.getDest().substring(0,10) : m.getDest()));
if(m.getType() == 2){
long now = System.currentTimeMillis();
if(now - queryInCheckpoint > 60000){
queryInCheckpoint = now;
receivedQueries = 0;
}else{
receivedQueries++;
if(receivedQueries > maxQueryRatePerMinute){
_logger.info(this +" Query flood detected. Discarding... " +
m);
continue;
}
}
}
local.activateNewRouterProcess(m, this.getIdent());
}
else
_logger.debug(obj.toString());
//}
}
if (!failure) {
failure = true;
_logger.info(local.getShortId() +
": 1Closed connection with neighbour: " +
this.getIdent());
try{
if (s != null)
s.close();
}catch(IOException ex){}
local.removeNeighbour(this);
local.propertyChangeSupport.firePropertyChange("removedNeighbour", null, this);
}
}
catch (Exception e) {
if (!failure) {
failure = true;
_logger.info(local.getShortId() +
": 2Closed connection with neighbour: " +
this.getIdent(),e);
_logger.debug("NeighbourAnt connection failed",e);
try{
if (s != null)
s.close();
}catch(IOException ex){}
local.removeNeighbour(this);
local.propertyChangeSupport.firePropertyChange("removedNeighbour", null, this);
}
}
}
public void setFailure(){
this.failure = true;
}
public String toString(){
return this.getIdent()+" ["+this.getTimeElapsed()+"ms]["+this.queuedMessages+"]";
}
public static int getTotalCompressionGainOut(){
return (int)Math.ceil((1-(NeighbourAnt.totalCompressedSizeOut / NeighbourAnt.totalUncompressionSizeOut))*100);
}
public static int getTotalCompressionGainIn(){
return (int)Math.ceil((1-(NeighbourAnt.totalCompressedSizeIn / NeighbourAnt.totalUncompressionSizeIn))*100);
}
}
class CompressedByteArray implements Serializable{
byte[] array;
public CompressedByteArray(byte[] array){
this.array = array;
}
public byte[] getArray(){
return this.array;
}
}
class Prober extends Thread{
NeighbourAnt n;
public static long interval = 3*60*1000;
static Logger _logger = Logger.getLogger(Prober.class.getName());
public Prober(NeighbourAnt n){
this.n = n;
this.setPriority(10);
}
public void run(){
while(this.n != null && this.n.isConnected()){
try {
this.sleep(interval);
if(!this.n.getAnt().neighbours.contains(this.n)){
n.terminate();
return;
}
_logger.info(this.n.getIdent() +": Scheduled probe message at "+new java.util.Date(System.currentTimeMillis()));
this.n.send(new NetProbeMessage());
}catch(Exception e){
n.terminate();
_logger.error("Neighbour Prober error",e);
}
}
}
}
The table below shows all metrics for NeighbourAnt.java.
| Metric | Value | Description | |
|---|---|---|---|
| BLOCKS | 90.00 | Number of blocks | |
| BLOCK_COMMENT | 19.00 | Number of block comment lines | |
| COMMENTS | 48.00 | Comment lines | |
| COMMENT_DENSITY | 0.13 | Comment density | |
| COMPARISONS | 61.00 | Number of comparison operators | |
| CYCLOMATIC | 100.00 | Cyclomatic complexity | |
| DECL_COMMENTS | 22.00 | Comments in declarations | |
| DOC_COMMENT | 0.00 | Number of javadoc comment lines | |
| ELOC | 377.00 | Effective lines of code | |
| EXEC_COMMENTS | 8.00 | Comments in executable code | |
| EXITS | 62.00 | Procedure exits | |
| FUNCTIONS | 31.00 | Number of function declarations | |
| HALSTEAD_DIFFICULTY | 85.22 | Halstead difficulty | |
| HALSTEAD_EFFORT | 0.00 | Halstead effort | |
| INTERFACE_COMPLEXITY | 59.00 | Interface complexity | |
| JAVA0001 | 1.00 | JAVA0001 Package name does not contain only lower case letters | |
| JAVA0002 | 1.00 | JAVA0002 Package name does not begin with a top level domain name or country code | |
| JAVA0003 | 1.00 | JAVA0003 Minimize use of on-demand (.*) imports | |
| JAVA0004 | 0.00 | JAVA0004 Unnecessary import from java.lang | |
| JAVA0005 | 1.00 | JAVA0005 Imports not in specified order | |
| JAVA0006 | 0.00 | JAVA0006 Empty finally block | |
| JAVA0007 | 15.00 | JAVA0007 Should not declare public field | |
| JAVA0008 | 3.00 | JAVA0008 Empty catch block | |
| JAVA0009 | 0.00 | JAVA0009 Protected member in final class | |
| JAVA0010 | 0.00 | JAVA0010 Non-instantiable class does not contain a non-private static member | |
| JAVA0011 | 0.00 | JAVA0011 Abstract class does not contain an abstract method | |
| JAVA0012 | 0.00 | JAVA0012 Non-constructor method with same name as declaring class | |
| JAVA0013 | 1.00 | JAVA0013 Non-blank final field is not static | |
| JAVA0014 | 0.00 | JAVA0014 Class with only static members has non-private constructor | |
| JAVA0015 | 0.00 | JAVA0015 Package class contains public nested type | |
| JAVA0016 | 0.00 | JAVA0016 Abstract class contains public constructor | |
| JAVA0017 | 0.00 | JAVA0017 Class name does not have required form | |
| JAVA0018 | 0.00 | JAVA0018 Method name does not have required form | |
| JAVA0019 | 0.00 | JAVA0019 Interface name does not have required form | |
| JAVA0020 | 0.00 | JAVA0020 Field name does not have required form | |
| JAVA0021 | 0.00 | JAVA0021 Interface method name does not have required form | |
| JAVA0022 | 0.00 | JAVA0022 Static final field name does not have required form | |
| JAVA0023 | 0.00 | JAVA0023 Empty finalize method | |
| JAVA0024 | 0.00 | JAVA0024 Empty class | |
| JAVA0025 | 0.00 | JAVA0025 Method override is empty | |
| JAVA0026 | 0.00 | JAVA0026 Finalize method with parameters | |
| JAVA0029 | 0.00 | JAVA0029 Private method not used | |
| JAVA0030 | 0.00 | JAVA0030 Private field not used | |
| JAVA0031 | 0.00 | JAVA0031 Case statement not properly closed | |
| JAVA0032 | 0.00 | JAVA0032 Switch statement missing default | |
| JAVA0033 | 0.00 | JAVA0033 default: not last case in switch statement | |
| JAVA0034 | 13.00 | JAVA0034 Missing braces in if statement | |
| JAVA0035 | 0.00 | JAVA0035 Missing braces in for statement | |
| JAVA0036 | 0.00 | JAVA0036 Missing braces in while statement | |
| JAVA0038 | 0.00 | JAVA0038 Non-case label in switch statement | |
| JAVA0039 | 0.00 | JAVA0039 Break statement with label | |
| JAVA0040 | 0.00 | JAVA0040 Switch statement contains N cases (maximum: M) | |
| JAVA0041 | 0.00 | JAVA0041 Nested synchronized block | |
| JAVA0042 | 0.00 | JAVA0042 Empty synchronized statement | |
| JAVA0043 | 0.00 | JAVA0043 Inner class does not use outer class | |
| JAVA0044 | 0.00 | JAVA0044 Serializable class with no instance variables | |
| JAVA0045 | 0.00 | JAVA0045 Serializable class with only transient fields | |
| JAVA0046 | 0.00 | JAVA0046 Name of class not derived from Exception ends with 'Exception' | |
| JAVA0047 | 0.00 | JAVA0047 Serializable class derives from invalid base class | |
| JAVA0048 | 0.00 | JAVA0048 Name of class derived from Exception does not end with 'Exception' | |
| JAVA0049 | 2.00 | JAVA0049 Nested block at depth N (maximum: M) | |
| JAVA0050 | 0.00 | JAVA0050 Class derives from java.lang.Error | |
| JAVA0051 | 0.00 | JAVA0051 Class derives from java.lang.RuntimeException | |
| JAVA0052 | 0.00 | JAVA0052 Class derives from java.lang.Throwable | |
| JAVA0053 | 0.00 | JAVA0053 Unused label | |
| JAVA0054 | 0.00 | JAVA0054 Inheritance depth N exceeds maximum M | |
| JAVA0055 | 0.00 | JAVA0055 Class should be interface | |
| JAVA0056 | 0.00 | JAVA0056 Unnecessary abstract modifier for interface or annotation | |
| JAVA0057 | 0.00 | JAVA0057 Unnecessary default constructor | |
| JAVA0058 | 0.00 | JAVA0058 Constructor calls super() | |
| JAVA0059 | 0.00 | JAVA0059 Method override only calls super() | |
| JAVA0061 | 0.00 | JAVA0061 Inaccessible member in anonymous class | |
| JAVA0062 | 0.00 | JAVA0062 Public class missing public member or protected constructor | |
| JAVA0063 | 0.00 | JAVA0063 Identifier name should not contain '$' | |
| JAVA0064 | 0.00 | JAVA0064 N variations of identifier name (maximum: M) | |
| JAVA0065 | 0.00 | JAVA0065 Unnecessary final modifier for method in final class | |
| JAVA0066 | 0.00 | JAVA0066 Unnecessary modifier for interface nested type | |
| JAVA0067 | 0.00 | JAVA0067 Array descriptor on identifier name | |
| JAVA0068 | 0.00 | JAVA0068 Modifiers not declared in recommended order | |
| JAVA0071 | 0.00 | JAVA0071 Strings compared with == | |
| JAVA0073 | 0.00 | JAVA0073 Integer division in floating-point context | |
| JAVA0074 | 0.00 | JAVA0074 Use of Object.notify() | |
| JAVA0075 | 0.00 | JAVA0075 Method parameter hides field | |
| JAVA0076 | 13.00 | JAVA0076 Use of magic number | |
| JAVA0077 | 0.00 | JAVA0077 Private field not used in declaring class | |
| JAVA0078 | 0.00 | JAVA0078 Floating point values compared with == | |
| JAVA0079 | 1.00 | JAVA0079 Use of instance to reference static member | |
| JAVA0080 | 0.00 | JAVA0080 Import declaration not used | |
| JAVA0081 | 0.00 | JAVA0081 Boolean literal in comparison | |
| JAVA0082 | 0.00 | JAVA0082 Unnecessary widening cast | |
| JAVA0083 | 2.00 | JAVA0083 Unnecessary instanceof test | |
| JAVA0084 | 0.00 | JAVA0084 Should use compound assignment operator | |
| JAVA0085 | 0.00 | JAVA0085 Use of sun.* class | |
| JAVA0087 | 1.00 | JAVA0087 Use of Thread.sleep() | |
| JAVA0089 | 0.00 | JAVA0089 Use of restricted package | |
| JAVA0092 | 0.00 | JAVA0092 Use of restricted type | |
| JAVA0093 | 0.00 | JAVA0093 Redundant assignment | |
| JAVA0094 | 0.00 | JAVA0094 Field hides a superclass field | |
| JAVA0095 | 0.00 | JAVA0095 Uninitialized private field | |
| JAVA0096 | 0.00 | JAVA0096 Field in nested class hides outer field | |
| JAVA0098 | 0.00 | JAVA0098 Minimize use of implicit field initializers | |
| JAVA0100 | 1.00 | JAVA0100 Class contains N non-final fields (maximum: M) | |
| JAVA0101 | 0.00 | JAVA0101 Unnecessary modifier for field in interface | |
| JAVA0102 | 0.00 | JAVA0102 Last statement in finalize() not super.finalize() | |
| JAVA0103 | 0.00 | JAVA0103 Explicit call to finalize() | |
| JAVA0104 | 0.00 | JAVA0104 finalize() only calls super.finalize() | |
| JAVA0105 | 0.00 | JAVA0105 Duplicate import declaration | |
| JAVA0106 | 0.00 | JAVA0106 Unnecessary import from current package | |
| JAVA0108 | 0.00 | JAVA0108 Incorrect javadoc: no @param tag for 'parameter' | |
| JAVA0109 | 0.00 | JAVA0109 Incorrect javadoc: no parameter 'parameter' | |
| JAVA0110 | 0.00 | JAVA0110 Incorrect javadoc: no @return tag | |
| JAVA0111 | 0.00 | JAVA0111 Incorrect javadoc: @return tag for void method | |
| JAVA0112 | 0.00 | JAVA0112 Incorrect javadoc: no exception 'exception' in throws | |
| JAVA0113 | 0.00 | JAVA0113 Incorrect javadoc: no @author tag | |
| JAVA0114 | 0.00 | JAVA0114 Incorrect javadoc: no @version tag | |
| JAVA0115 | 0.00 | JAVA0115 Incorrect javadoc: no @throws or @exception tag for 'exception' | |
| JAVA0116 | 16.00 | JAVA0116 Missing javadoc: field 'field' | |
| JAVA0117 | 19.00 | JAVA0117 Missing javadoc: method 'method' | |
| JAVA0118 | 1.00 | JAVA0118 Missing javadoc: type 'type' | |
| JAVA0119 | 0.00 | JAVA0119 Control variable changed within body of for loop | |
| JAVA0123 | 0.00 | JAVA0123 Use all three components of for loop | |
| JAVA0125 | 0.00 | JAVA0125 Continue statement with label | |
| JAVA0126 | 0.00 | JAVA0126 Method declares unchecked exception in throws | |
| JAVA0128 | 2.00 | JAVA0128 Public constructor in non-public class | |
| JAVA0130 | 0.00 | JAVA0130 Non-static method does not use instance fields | |
| JAVA0131 | 0.00 | JAVA0131 Compatible method does not override base | |
| JAVA0132 | 0.00 | JAVA0132 Method overload with compatible signature | |
| JAVA0133 | 0.00 | JAVA0133 Non-synchronized method overrides synchronized method | |
| JAVA0135 | 1.00 | JAVA0135 Only one of Object.equals and Object.hashCode defined: missing 'method' | |
| JAVA0136 | 1.00 | JAVA0136 N methods defined in class (maximum: M) | |
| JAVA0137 | 0.00 | JAVA0137 Non-abstract class missing constructor | |
| JAVA0138 | 1.00 | JAVA0138 N parameters defined for method (maximum: M) | |
| JAVA0139 | 0.00 | JAVA0139 Definition of main other than public static void main(java.lang.String[]) | |
| JAVA0141 | 0.00 | JAVA0141 Unnecessary modifier for method in interface | |
| JAVA0143 | 1.00 | JAVA0143 Synchronized method | |
| JAVA0144 | 3.00 | JAVA0144 Line exceeds maximum M characters | |
| JAVA0145 | 0.00 | JAVA0145 Tab character used in source file | |
| JAVA0150 | 0.00 | JAVA0150 java.lang.Error (or subclass) thrown | |
| JAVA0153 | 0.00 | JAVA0153 Inefficient conversion of integer to string | |
| JAVA0159 | 0.00 | JAVA0159 Inefficient conversion of string to integer | |
| JAVA0160 | 0.00 | JAVA0160 Method does not throw specified exception | |
| JAVA0161 | 0.00 | JAVA0161 Conditional wait() not in loop | |
| JAVA0163 | 0.00 | JAVA0163 Empty statement | |
| JAVA0165 | 0.00 | JAVA0165 Conflicting return statement in finally block | |
| JAVA0166 | 5.00 | JAVA0166 Generic exception caught | |
| JAVA0167 | 0.00 | JAVA0167 ThreadDeath not rethrown | |
| JAVA0169 | 0.00 | JAVA0169 Unnecessary catch block: exception 'exception' | |
| JAVA0170 | 0.00 | JAVA0170 Caught exception not derived from java.lang.Exception | |
| JAVA0171 | 0.00 | JAVA0171 Unused local variable | |
| JAVA0173 | 0.00 | JAVA0173 Unused method parameter | |
| JAVA0174 | 0.00 | JAVA0174 Assigned local variable never used | |
| JAVA0175 | 0.00 | JAVA0175 Successive assignment to variable | |
| JAVA0176 | 0.00 | JAVA0176 Local variable name does not have required form | |
| JAVA0177 | 4.00 | JAVA0177 Variable declaration missing initializer | |
| JAVA0179 | 0.00 | JAVA0179 Local variable hides visible field | |
| JAVA0233 | 0.00 | JAVA0233 Definition of serialVersionUID other than 'private static final long serialVersionUID' | |
| JAVA0234 | 1.00 | JAVA0234 Class is Serializable but does not define serialVersionUID | |
| JAVA0235 | 0.00 | JAVA0235 Class defines serialVersionUID but does not implement Serializable | |
| JAVA0236 | 0.00 | JAVA0236 Attempt to clone an object which does not implement Cloneable | |
| JAVA0237 | 0.00 | JAVA0237 Class implements Cloneable but does not have public clone method | |
| JAVA0238 | 0.00 | JAVA0238 Clone method does not call super.clone() | |
| JAVA0239 | 0.00 | JAVA0239 Class declares 'readObject' or 'writeObject' but does not implement Serializable | |
| JAVA0240 | 0.00 | JAVA0240 Serializable class which declares readObject or writeObject but not both | |
| JAVA0241 | 0.00 | JAVA0241 'readObject' or 'writeObject' should be declared private in Serializable class | |
| JAVA0242 | 0.00 | JAVA0242 Transient field in non-Serializable class | |
| JAVA0243 | 0.00 | JAVA0243 'readResolve' or 'writeReplace' should be declared private or protected | |
| JAVA0244 | 0.00 | JAVA0244 Field or method name in subclass differs only by case from inherited field or method | |
| JAVA0245 | 0.00 | JAVA0245 JUnit TestCase with non-trivial constructor | |
| JAVA0246 | 0.00 | JAVA0246 JUnit assertXXX statement missing message parameter | |
| JAVA0247 | 0.00 | JAVA0247 JUnit 'setUp()' and 'tearDown()' should call super method | |
| JAVA0248 | 0.00 | JAVA0248 JUnit method 'setUp' or 'tearDown' with incorrect signature | |
| JAVA0249 | 0.00 | JAVA0249 JUnit TestCase 'suite()' should be declared static | |
| JAVA0250 | 0.00 | JAVA0250 JUnit TestCase declares testXXX method with incorrect signature | |
| JAVA0251 | 0.00 | JAVA0251 Use '%n' for line breaks in printf/format for platform independence | |
| JAVA0252 | 0.00 | JAVA0252 'enum' is a Java 1.5 reserved word | |
| JAVA0253 | 0.00 | JAVA0253 Not all enum constants consumed in switch statement | |
| JAVA0254 | 0.00 | JAVA0254 Use enhanced for loop construct instead of Iterator | |
| JAVA0255 | 0.00 | JAVA0255 Result of method invocation not used | |
| JAVA0256 | 1.00 | JAVA0256 Assignment of external collection/array to field | |
| JAVA0257 | 0.00 | JAVA0257 Use of 'Constant Interface' anti-pattern | |
| JAVA0258 | 0.00 | JAVA0258 Implement Iterable for foreach compatibility | |
| JAVA0259 | 1.00 | JAVA0259 Return of collection/array field | |
| JAVA0260 | 0.00 | JAVA0260 Use 'enum' instead of Enumerated Type pattern | |
| JAVA0261 | 0.00 | JAVA0261 Use specialized Enum collection types | |
| JAVA0262 | 0.00 | JAVA0262 Use of char in integer context | |
| JAVA0263 | 0.00 | JAVA0263 Long literal ends with 'l' instead of 'L' | |
| JAVA0264 | 1.00 | JAVA0264 Integer math in long context - check for overflow | |
| JAVA0265 | 0.00 | JAVA0265 Use of Throwable.printStackTrace() | |
| JAVA0266 | 0.00 | JAVA0266 Use of System.out | |
| JAVA0267 | 0.00 | JAVA0267 Use of System.err | |
| JAVA0269 | 0.00 | JAVA0269 Contents of StringBuffer never used | |
| JAVA0270 | 0.00 | JAVA0270 Use Java 5.0 enhanced for loop construct to iterate over all elements in an array | |
| JAVA0271 | 0.00 | JAVA0271 Minimize use of on-demand (.*) static imports | |
| JAVA0272 | 0.00 | JAVA0272 Thread.run() called | |
| JAVA0273 | 0.00 | JAVA0273 Non-final derivative of Thread calls start() in constructor | |
| JAVA0274 | 0.00 | JAVA0274 Serializable class has a synchronized readObject() | |
| JAVA0275 | 0.00 | JAVA0275 Serializable class has a synchronized writeObject() and no other synchronized methods | |
| JAVA0276 | 0.00 | JAVA0276 Unnecessary use of String constructor | |
| JAVA0277 | 0.00 | JAVA0277 Iterator.next() implementation does not throw NoSuchElementException | |
| JAVA0278 | 0.00 | JAVA0278 Unnecessary use of Boolean constructor | |
| JAVA0279 | 0.00 | JAVA0279 Serialization method readObject or readObjectNoData calls an overridable method | |
| JAVA0280 | 0.00 | JAVA0280 IllegalMonitorStateException caught | |
| JAVA0281 | 0.00 | JAVA0281 Iterator.next() not called in loop | |
| JAVA0282 | 0.00 | JAVA0282 Call to Iterator.next() in loop which does not test Iterator.hasNext() | |
| JAVA0283 | 0.00 | JAVA0283 Control variable not updated in loop body | |
| JAVA0284 | 0.00 | JAVA0284 Explicit garbage collection | |
| JAVA0285 | 0.00 | JAVA0285 Dereference of potentially null variable | |
| JAVA0286 | 0.00 | JAVA0286 Dereference of null variable | |
| JAVA0287 | 0.00 | JAVA0287 Unnecessary null check | |
| JAVA0288 | 0.00 | JAVA0288 Inconsistent null check | |
| LINES | 567.00 | Number of lines in the source file | |
| LINE_COMMENT | 29.00 | Number of line comments | |
| LOC | 456.00 | Lines of code | |
| LOGICAL_LINES | 220.00 | Number of statements | |
| LOOPS | 2.00 | Number of loops | |
| NEST_DEPTH | 7.00 | Maximum nesting depth | |
| OPERANDS | 928.00 | Number of operands | |
| OPERATORS | 2058.00 | Number of operators | |
| PARAMS | 19.00 | Number of formal parameter declarations | |
| PROGRAM_LENGTH | 2986.00 | Halstead program length | |
| PROGRAM_VOCAB | 348.00 | Halstead program vocabulary | |
| PROGRAM_VOLUME | 0.00 | Halstead program volume | |
| RETURNS | 40.00 | Number of return points from functions | |
| SIZE | 20109.00 | Size of the file in bytes | |
| UNIQUE_OPERANDS | 294.00 | Number of unique operands | |
| UNIQUE_OPERATORS | 54.00 | Number of unique operators | |
| WHITESPACE | 63.00 | Number of whitespace lines | |